[Math] JIRA issues with proposed fixes

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Math] JIRA issues with proposed fixes

Gilles Sadowski
Hi.

There are some issues reported that come with a proposed fix.
If you think that the change is adequate, do not hesitate to
apply it. E.g.:
  https://issues.apache.org/jira/browse/MATH-1381
  https://issues.apache.org/jira/browse/MATH-1400

Some may be fixed already. If you can confirm it, do not
hesitate to resolve the report (updating "changes.xml" if
not done already). E.g.:
  https://issues.apache.org/jira/browse/MATH-1401
  https://issues.apache.org/jira/browse/MATH-1370


Thanks,
Gilles


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Math] JIRA issues with proposed fixes

Gilles Sadowski
On Tue, 02 May 2017 01:44:28 +0200, Gilles wrote:
> Hi.
>
> There are some issues reported that come with a proposed fix.
> If you think that the change is adequate, do not hesitate to
> apply it. E.g.:
>  https://issues.apache.org/jira/browse/MATH-1381
>  https://issues.apache.org/jira/browse/MATH-1400

Also:
  https://issues.apache.org/jira/browse/MATH-1379
  https://issues.apache.org/jira/browse/MATH-1380

>
> Some may be fixed already. If you can confirm it, do not
> hesitate to resolve the report (updating "changes.xml" if
> not done already). E.g.:
>  https://issues.apache.org/jira/browse/MATH-1401
>  https://issues.apache.org/jira/browse/MATH-1370
>
>
> Thanks,
> Gilles


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Math] JIRA issues with proposed fixes

Rob Tompkins
In reply to this post by Gilles Sadowski


> On May 1, 2017, at 7:44 PM, Gilles <[hidden email]> wrote:
>
> Hi.
>
> There are some issues reported that come with a proposed fix.
> If you think that the change is adequate, do not hesitate to
> apply it. E.g.:
> https://issues.apache.org/jira/browse/MATH-1381
> https://issues.apache.org/jira/browse/MATH-1400

If you see any with proposed fixes that aren't in the 4.0 category, do move them over. My intent there was to keep those labeled 4.0.

>
> Some may be fixed already. If you can confirm it, do not
> hesitate to resolve the report (updating "changes.xml" if
> not done already). E.g.:
> https://issues.apache.org/jira/browse/MATH-1401
> https://issues.apache.org/jira/browse/MATH-1370
>
>
> Thanks,
> Gilles
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Math] JIRA issues with proposed fixes

Gilles Sadowski
On Mon, 1 May 2017 20:02:46 -0400, Rob Tompkins wrote:

>> On May 1, 2017, at 7:44 PM, Gilles <[hidden email]>
>> wrote:
>>
>> Hi.
>>
>> There are some issues reported that come with a proposed fix.
>> If you think that the change is adequate, do not hesitate to
>> apply it. E.g.:
>> https://issues.apache.org/jira/browse/MATH-1381
>> https://issues.apache.org/jira/browse/MATH-1400
>
> If you see any with proposed fixes that aren't in the 4.0 category,
> do move them over. My intent there was to keep those labeled 4.0.

?

My post was about whether there are people having the time
and ability to check the proposed solution and resolve the
issue.

If not, we are still in the same situation as I described one
year ago; and releasing Commons Math (with known bugs) is still
a bad idea.
The consequence of which would be to salvage yet other pieces
from it (those that have a lot of work put into them for the
last 3 years).
An example is the contents of the "o.a.c.math4.distribution"
package: there are some "clean-up" issues left, but then it
could probably become a "Commons Statistical Distributions"
component.


Regards,
Gilles

>> Some may be fixed already. If you can confirm it, do not
>> hesitate to resolve the report (updating "changes.xml" if
>> not done already). E.g.:
>> https://issues.apache.org/jira/browse/MATH-1401
>> https://issues.apache.org/jira/browse/MATH-1370
>>
>>
>> Thanks,
>> Gilles


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Math] JIRA issues with proposed fixes

Bruno P. Kinoshita-3
MATH-1401 is not fixed yet. Fixing it doesn't seem so hard, the problem is the required domain knowledge in stats - which I don't have :-)

I'm gathering links to study over the next days, so I've assigned that ticket to me. Hopefully by the weekend I will understand Clopper-Pearson intervals, and why our implementation is throwing errors while implementations in R are not.

Cheers
Bruno



________________________________
From: Gilles <[hidden email]>
To: [hidden email]
Sent: Tuesday, 2 May 2017 11:17 PM
Subject: Re: [Math] JIRA issues with proposed fixes



On Mon, 1 May 2017 20:02:46 -0400, Rob Tompkins wrote:

>> On May 1, 2017, at 7:44 PM, Gilles <[hidden email]>
>> wrote:
>>
>> Hi.
>>
>> There are some issues reported that come with a proposed fix.
>> If you think that the change is adequate, do not hesitate to
>> apply it. E.g.:
>> https://issues.apache.org/jira/browse/MATH-1381
>> https://issues.apache.org/jira/browse/MATH-1400
>
> If you see any with proposed fixes that aren't in the 4.0 category,
> do move them over. My intent there was to keep those labeled 4.0.

?

My post was about whether there are people having the time
and ability to check the proposed solution and resolve the
issue.

If not, we are still in the same situation as I described one
year ago; and releasing Commons Math (with known bugs) is still
a bad idea.
The consequence of which would be to salvage yet other pieces
from it (those that have a lot of work put into them for the
last 3 years).
An example is the contents of the "o.a.c.math4.distribution"
package: there are some "clean-up" issues left, but then it
could probably become a "Commons Statistical Distributions"
component.


Regards,

Gilles

>> Some may be fixed already. If you can confirm it, do not
>> hesitate to resolve the report (updating "changes.xml" if
>> not done already). E.g.:
>> https://issues.apache.org/jira/browse/MATH-1401
>> https://issues.apache.org/jira/browse/MATH-1370
>>
>>
>> Thanks,
>> Gilles


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Math] JIRA issues with proposed fixes

Bruno P. Kinoshita-3
In reply to this post by Gilles Sadowski
Hi,

>>> There are some issues reported that come with a proposed fix.>> If you think that the change is adequate, do not hesitate to
>> apply it. E.g.:

>> https://issues.apache.org/jira/browse/MATH-1381


Done, pull request submitted [1] and merged.

>> Some may be fixed already. If you can confirm it, do not
>> hesitate to resolve the report (updating "changes.xml" if
>> not done already). E.g.:
>> https://issues.apache.org/jira/browse/MATH-1401

This one was fun. Had to use R to check the results, and then chase stats papers to find out how to solve it. Pull request submitted [2]. Would be great if someone could review it before 4.0.

And for MATH- [3], I have another pull request [4], which I intend to merge tomorrow afternoon if there are no objections. Will break compatibility with previous versions, but given it's a major release, I assume it would be the right time for it.

Before 4.x, the next issue I am planning to work on [math] is MATH-1408 [5], for GWT and Math. This issue is related to MATH-1413, but not sure if will be able to submit a complete solution in the next weeks.

Cheers
Bruno

[1] https://github.com/apache/commons-math/pull/59
[2] https://github.com/apache/commons-math/pull/60
[3] https://issues.apache.org/jira/browse/MATH-1413
[4] https://github.com/apache/commons-math/pull/58
[5] https://issues.apache.org/jira/browse/MATH-1408

________________________________
From: Gilles <[hidden email]>
To: [hidden email]
Sent: Tuesday, 2 May 2017 11:17 PM
Subject: Re: [Math] JIRA issues with proposed fixes



On Mon, 1 May 2017 20:02:46 -0400, Rob Tompkins wrote:

>> On May 1, 2017, at 7:44 PM, Gilles <[hidden email]>
>> wrote:
>>
>> Hi.
>>
>> There are some issues reported that come with a proposed fix.
>> If you think that the change is adequate, do not hesitate to
>> apply it. E.g.:
>> https://issues.apache.org/jira/browse/MATH-1381
>> https://issues.apache.org/jira/browse/MATH-1400
>
> If you see any with proposed fixes that aren't in the 4.0 category,
> do move them over. My intent there was to keep those labeled 4.0.

?

My post was about whether there are people having the time
and ability to check the proposed solution and resolve the
issue.

If not, we are still in the same situation as I described one
year ago; and releasing Commons Math (with known bugs) is still
a bad idea.
The consequence of which would be to salvage yet other pieces
from it (those that have a lot of work put into them for the
last 3 years).
An example is the contents of the "o.a.c.math4.distribution"
package: there are some "clean-up" issues left, but then it
could probably become a "Commons Statistical Distributions"
component.


Regards,

Gilles

>> Some may be fixed already. If you can confirm it, do not
>> hesitate to resolve the report (updating "changes.xml" if
>> not done already). E.g.:
>> https://issues.apache.org/jira/browse/MATH-1401
>> https://issues.apache.org/jira/browse/MATH-1370
>>
>>
>> Thanks,
>> Gilles


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]