Question about DBCP code usage

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Question about DBCP code usage

Philippe Mouawad
Hello,
I have a question regarding code usage of DBCP.

For another pool implementation that is an Apache project, I would like to
submit a patch related to LocalXA implementation.
This patch will use (by changing their package location) the following
classes from DBCP:

   - TransactionRegistry
   - LocalXAResource
   - TransactionContext
   - TransactionContextListener

And have a class partly inspired by ManagedConnection.


My question is:

   - Can I do this if I keep the author name and Apache mention ? if no what
   must I do ?


Thank you
Regards
Philippe
Reply | Threaded
Open this post in threaded view
|

Re: Question about DBCP code usage

Mark Thomas
On 24/05/2011 15:09, Philippe Mouawad wrote:
> Hello,
> I have a question regarding code usage of DBCP.
>
> For another pool implementation that is an Apache project,
Out of interest, which one?

> I would like to
> submit a patch related to LocalXA implementation.
> This patch will use (by changing their package location) the following
> classes from DBCP:
>
>    - TransactionRegistry
>    - LocalXAResource
>    - TransactionContext
>    - TransactionContextListener
>
> And have a class partly inspired by ManagedConnection.
>
>
> My question is:
>
>    - Can I do this if I keep the author name and Apache mention ? if no what
>    must I do ?

If you are re-using code from one Apache project in another then that is
fine. You can just copy the classes and modify as you require. It is
always a good idea to reference where the classes come from somewhere
but it is not required.

Tomcat for example includes code copied from DBCP, Digester and
FileUpload to name but a few.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Question about DBCP code usage

Niall Pemberton
On Tue, May 24, 2011 at 3:18 PM, Mark Thomas <[hidden email]> wrote:

> On 24/05/2011 15:09, Philippe Mouawad wrote:
>> Hello,
>> I have a question regarding code usage of DBCP.
>>
>> For another pool implementation that is an Apache project,
> Out of interest, which one?
>
>> I would like to
>> submit a patch related to LocalXA implementation.
>> This patch will use (by changing their package location) the following
>> classes from DBCP:
>>
>>    - TransactionRegistry
>>    - LocalXAResource
>>    - TransactionContext
>>    - TransactionContextListener
>>
>> And have a class partly inspired by ManagedConnection.
>>
>>
>> My question is:
>>
>>    - Can I do this if I keep the author name and Apache mention ? if no what
>>    must I do ?
>
> If you are re-using code from one Apache project in another then that is
> fine. You can just copy the classes and modify as you require. It is
> always a good idea to reference where the classes come from somewhere
> but it is not required.

Even better if you do an svn:copy - that way the source and history
gets retained.

Niall

> Tomcat for example includes code copied from DBCP, Digester and
> FileUpload to name but a few.
>
> Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Question about DBCP code usage

Philippe Mouawad
In reply to this post by Mark Thomas
Hello,
Thanks for the quick response.

In fact I would like to contribute the code to Tomcat JDBC Pool and it first
that is Ofbiz project, because Ofbiz uses largely this Local XA feature.
But of course I will be asking them if they are interested and maybe nobody
will be :-)

Regards
Philippe

On Tue, May 24, 2011 at 4:18 PM, Mark Thomas <[hidden email]> wrote:

> On 24/05/2011 15:09, Philippe Mouawad wrote:
> > Hello,
> > I have a question regarding code usage of DBCP.
> >
> > For another pool implementation that is an Apache project,
> Out of interest, which one?
>
> > I would like to
> > submit a patch related to LocalXA implementation.
> > This patch will use (by changing their package location) the following
> > classes from DBCP:
> >
> >    - TransactionRegistry
> >    - LocalXAResource
> >    - TransactionContext
> >    - TransactionContextListener
> >
> > And have a class partly inspired by ManagedConnection.
> >
> >
> > My question is:
> >
> >    - Can I do this if I keep the author name and Apache mention ? if no
> what
> >    must I do ?
>
> If you are re-using code from one Apache project in another then that is
> fine. You can just copy the classes and modify as you require. It is
> always a good idea to reference where the classes come from somewhere
> but it is not required.
>
> Tomcat for example includes code copied from DBCP, Digester and
> FileUpload to name but a few.
>
> Mark
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
Cordialement.
Philippe Mouawad.
Ubik-Ingénierie
Reply | Threaded
Open this post in threaded view
|

Re: Question about DBCP code usage

Phil Steitz
Mark is right there is no problem sharing code across projects.  We just brought in a class from Harmony to DBCP itself.  I would encourage you guys to consider using DBCP directly though, partly so it will be easier to share patches to the XA code you are mentioning.  In particular, the patches you have already submitted should make their way into DBCP next releases. Thanks for these and thanks in advance for any more you are willing to make.

One nit on @author tags - they are discouraged and should probably be removed.

Phil



On May 24, 2011, at 7:25 AM, Philippe Mouawad <[hidden email]> wrote:

> Hello,
> Thanks for the quick response.
>
> In fact I would like to contribute the code to Tomcat JDBC Pool and it first
> that is Ofbiz project, because Ofbiz uses largely this Local XA feature.
> But of course I will be asking them if they are interested and maybe nobody
> will be :-)
>
> Regards
> Philippe
>
> On Tue, May 24, 2011 at 4:18 PM, Mark Thomas <[hidden email]> wrote:
>
>> On 24/05/2011 15:09, Philippe Mouawad wrote:
>>> Hello,
>>> I have a question regarding code usage of DBCP.
>>>
>>> For another pool implementation that is an Apache project,
>> Out of interest, which one?
>>
>>> I would like to
>>> submit a patch related to LocalXA implementation.
>>> This patch will use (by changing their package location) the following
>>> classes from DBCP:
>>>
>>>   - TransactionRegistry
>>>   - LocalXAResource
>>>   - TransactionContext
>>>   - TransactionContextListener
>>>
>>> And have a class partly inspired by ManagedConnection.
>>>
>>>
>>> My question is:
>>>
>>>   - Can I do this if I keep the author name and Apache mention ? if no
>> what
>>>   must I do ?
>>
>> If you are re-using code from one Apache project in another then that is
>> fine. You can just copy the classes and modify as you require. It is
>> always a good idea to reference where the classes come from somewhere
>> but it is not required.
>>
>> Tomcat for example includes code copied from DBCP, Digester and
>> FileUpload to name but a few.
>>
>> Mark
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
> Ubik-Ingénierie

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]