Re: [1/2] [text] [TEXT-147] Add a Base64 encoder string lookup. Better Javadoc.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [1/2] [text] [TEXT-147] Add a Base64 encoder string lookup. Better Javadoc.

Bernd Eckenfels
Should this be assertSame() instead?

Gruss
Bernd
--
http://bernd.eckenfels.net

________________________________
Von: [hidden email]
Gesendet: Samstag, Oktober 6, 2018 4:36 PM
An: [hidden email]
Betreff: [1/2] [text] [TEXT-147] Add a Base64 encoder string lookup. Better Javadoc.

Repository: commons-text
Updated Branches:
refs/heads/master 6d1e71185 -> b267aa526


[TEXT-147] Add a Base64 encoder string lookup. Better Javadoc.

Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/0e6c1394
Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/0e6c1394
Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/0e6c1394

Branch: refs/heads/master
Commit: 0e6c139442dd201455be53e100d81f84bd732d4d
Parents: d9cda57
Author: Gary Gregory <[hidden email]>
Authored: Sat Oct 6 08:13:20 2018 -0600
Committer: Gary Gregory <[hidden email]>
Committed: Sat Oct 6 08:13:20 2018 -0600

----------------------------------------------------------------------
.../org/apache/commons/text/lookup/StringLookupFactoryTest.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-text/blob/0e6c1394/src/test/java/org/apache/commons/text/lookup/StringLookupFactoryTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/text/lookup/StringLookupFactoryTest.java b/src/test/java/org/apache/commons/text/lookup/StringLookupFactoryTest.java
index 11585e7..71ca8c0 100644
--- a/src/test/java/org/apache/commons/text/lookup/StringLookupFactoryTest.java
+++ b/src/test/java/org/apache/commons/text/lookup/StringLookupFactoryTest.java
@@ -30,8 +30,8 @@ public class StringLookupFactoryTest {
@Test
public void testSingletons() {
final StringLookupFactory stringLookupFactory = StringLookupFactory.INSTANCE;
- Assertions.assertEquals(Base64DecoderStringLookup.INSTANCE, stringLookupFactory.base64StringLookup());
- Assertions.assertEquals(Base64EncoderStringLookup.INSTANCE, stringLookupFactory.base64StringLookup());
+ Assertions.assertEquals(Base64DecoderStringLookup.INSTANCE, stringLookupFactory.base64DecoderStringLookup());
+ Assertions.assertEquals(Base64EncoderStringLookup.INSTANCE, stringLookupFactory.base64EncoderStringLookup());
Assertions.assertEquals(ConstantStringLookup.INSTANCE, stringLookupFactory.constantStringLookup());
Assertions.assertEquals(DateStringLookup.INSTANCE, stringLookupFactory.dateStringLookup());
Assertions.assertEquals(EnvironmentVariableStringLookup.INSTANCE,

Reply | Threaded
Open this post in threaded view
|

Re: [1/2] [text] [TEXT-147] Add a Base64 encoder string lookup. Better Javadoc.

garydgregory
Yes, will fix...

On Sat, Oct 6, 2018 at 8:39 AM Bernd Eckenfels <[hidden email]>
wrote:

> Should this be assertSame() instead?
>
> Gruss
> Bernd
> --
> http://bernd.eckenfels.net
>
> ________________________________
> Von: [hidden email]
> Gesendet: Samstag, Oktober 6, 2018 4:36 PM
> An: [hidden email]
> Betreff: [1/2] [text] [TEXT-147] Add a Base64 encoder string lookup.
> Better Javadoc.
>
> Repository: commons-text
> Updated Branches:
> refs/heads/master 6d1e71185 -> b267aa526
>
>
> [TEXT-147] Add a Base64 encoder string lookup. Better Javadoc.
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/commons-text/commit/0e6c1394
> Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/0e6c1394
> Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/0e6c1394
>
> Branch: refs/heads/master
> Commit: 0e6c139442dd201455be53e100d81f84bd732d4d
> Parents: d9cda57
> Author: Gary Gregory <[hidden email]>
> Authored: Sat Oct 6 08:13:20 2018 -0600
> Committer: Gary Gregory <[hidden email]>
> Committed: Sat Oct 6 08:13:20 2018 -0600
>
> ----------------------------------------------------------------------
> .../org/apache/commons/text/lookup/StringLookupFactoryTest.java | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/commons-text/blob/0e6c1394/src/test/java/org/apache/commons/text/lookup/StringLookupFactoryTest.java
> ----------------------------------------------------------------------
> diff --git
> a/src/test/java/org/apache/commons/text/lookup/StringLookupFactoryTest.java
> b/src/test/java/org/apache/commons/text/lookup/StringLookupFactoryTest.java
> index 11585e7..71ca8c0 100644
> ---
> a/src/test/java/org/apache/commons/text/lookup/StringLookupFactoryTest.java
> +++
> b/src/test/java/org/apache/commons/text/lookup/StringLookupFactoryTest.java
> @@ -30,8 +30,8 @@ public class StringLookupFactoryTest {
> @Test
> public void testSingletons() {
> final StringLookupFactory stringLookupFactory =
> StringLookupFactory.INSTANCE;
> - Assertions.assertEquals(Base64DecoderStringLookup.INSTANCE,
> stringLookupFactory.base64StringLookup());
> - Assertions.assertEquals(Base64EncoderStringLookup.INSTANCE,
> stringLookupFactory.base64StringLookup());
> + Assertions.assertEquals(Base64DecoderStringLookup.INSTANCE,
> stringLookupFactory.base64DecoderStringLookup());
> + Assertions.assertEquals(Base64EncoderStringLookup.INSTANCE,
> stringLookupFactory.base64EncoderStringLookup());
> Assertions.assertEquals(ConstantStringLookup.INSTANCE,
> stringLookupFactory.constantStringLookup());
> Assertions.assertEquals(DateStringLookup.INSTANCE,
> stringLookupFactory.dateStringLookup());
> Assertions.assertEquals(EnvironmentVariableStringLookup.INSTANCE,
>
>