Re: [2/2] commons-crypto git commit: try-with-resources.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [2/2] commons-crypto git commit: try-with-resources.

sebb-2-2
On 30 June 2016 at 01:08,  <[hidden email]> wrote:

> try-with-resources.
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-crypto/repo
> Commit: http://git-wip-us.apache.org/repos/asf/commons-crypto/commit/b11f6ffa
> Tree: http://git-wip-us.apache.org/repos/asf/commons-crypto/tree/b11f6ffa
> Diff: http://git-wip-us.apache.org/repos/asf/commons-crypto/diff/b11f6ffa
>
> Branch: refs/heads/master
> Commit: b11f6ffaecef327840c3f42b880937a267ac7637
> Parents: 9ecfae2
> Author: Gary Gregory <[hidden email]>
> Authored: Wed Jun 29 17:08:49 2016 -0700
> Committer: Gary Gregory <[hidden email]>
> Committed: Wed Jun 29 17:08:49 2016 -0700
>
> ----------------------------------------------------------------------
>  .../commons/crypto/cipher/AbstractCipherTest.java   | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/b11f6ffa/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
> ----------------------------------------------------------------------
> diff --git a/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java b/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
> index 3da0511..65f1472 100644
> --- a/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
> +++ b/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
> @@ -82,18 +82,18 @@ public abstract class AbstractCipherTest {
>
>      @Test
>      public void closeTestAfterInit() throws Exception {
> -        CryptoCipher enc = getCipher(transformations[0]);
> -        enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"), new IvParameterSpec(IV));
> -        enc.close();
> +        try (CryptoCipher enc = getCipher(transformations[0])) {
> +            enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"), new IvParameterSpec(IV));
> +        }

-1

This is specifically designed to test  init and close
It's not helpful to hide the close in the try with resources block.

>      }
>
>      @Test
>      public void reInitTest() throws Exception {
> -        CryptoCipher enc = getCipher(transformations[0]);
> -        enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"), new IvParameterSpec(IV));
> -        enc.init(Cipher.DECRYPT_MODE, new SecretKeySpec(KEY, "AES"), new IvParameterSpec(IV));
> -        enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"), new IvParameterSpec(IV));
> -        enc.close();
> +        try (CryptoCipher enc = getCipher(transformations[0])) {
> +            enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"), new IvParameterSpec(IV));
> +            enc.init(Cipher.DECRYPT_MODE, new SecretKeySpec(KEY, "AES"), new IvParameterSpec(IV));
> +            enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"), new IvParameterSpec(IV));
> +        }

-1

DItto

>      }
>
>      @Test
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [2/2] commons-crypto git commit: try-with-resources.

garydgregory
I disagree with the -1s, but hey, that's just me -1. Reverted.

G

On Wed, Jun 29, 2016 at 5:19 PM, sebb <[hidden email]> wrote:

> On 30 June 2016 at 01:08,  <[hidden email]> wrote:
> > try-with-resources.
> >
> > Project: http://git-wip-us.apache.org/repos/asf/commons-crypto/repo
> > Commit:
> http://git-wip-us.apache.org/repos/asf/commons-crypto/commit/b11f6ffa
> > Tree:
> http://git-wip-us.apache.org/repos/asf/commons-crypto/tree/b11f6ffa
> > Diff:
> http://git-wip-us.apache.org/repos/asf/commons-crypto/diff/b11f6ffa
> >
> > Branch: refs/heads/master
> > Commit: b11f6ffaecef327840c3f42b880937a267ac7637
> > Parents: 9ecfae2
> > Author: Gary Gregory <[hidden email]>
> > Authored: Wed Jun 29 17:08:49 2016 -0700
> > Committer: Gary Gregory <[hidden email]>
> > Committed: Wed Jun 29 17:08:49 2016 -0700
> >
> > ----------------------------------------------------------------------
> >  .../commons/crypto/cipher/AbstractCipherTest.java   | 16
> ++++++++--------
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/b11f6ffa/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
> > ----------------------------------------------------------------------
> > diff --git
> a/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
> b/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
> > index 3da0511..65f1472 100644
> > ---
> a/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
> > +++
> b/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
> > @@ -82,18 +82,18 @@ public abstract class AbstractCipherTest {
> >
> >      @Test
> >      public void closeTestAfterInit() throws Exception {
> > -        CryptoCipher enc = getCipher(transformations[0]);
> > -        enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"),
> new IvParameterSpec(IV));
> > -        enc.close();
> > +        try (CryptoCipher enc = getCipher(transformations[0])) {
> > +            enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY,
> "AES"), new IvParameterSpec(IV));
> > +        }
>
> -1
>
> This is specifically designed to test  init and close
> It's not helpful to hide the close in the try with resources block.
>
> >      }
> >
> >      @Test
> >      public void reInitTest() throws Exception {
> > -        CryptoCipher enc = getCipher(transformations[0]);
> > -        enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"),
> new IvParameterSpec(IV));
> > -        enc.init(Cipher.DECRYPT_MODE, new SecretKeySpec(KEY, "AES"),
> new IvParameterSpec(IV));
> > -        enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"),
> new IvParameterSpec(IV));
> > -        enc.close();
> > +        try (CryptoCipher enc = getCipher(transformations[0])) {
> > +            enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY,
> "AES"), new IvParameterSpec(IV));
> > +            enc.init(Cipher.DECRYPT_MODE, new SecretKeySpec(KEY,
> "AES"), new IvParameterSpec(IV));
> > +            enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY,
> "AES"), new IvParameterSpec(IV));
> > +        }
>
> -1
>
> DItto
>
> >      }
> >
> >      @Test
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [2/2] commons-crypto git commit: try-with-resources.

Stian Soiland-Reyes
Agree for readability (and any future stack traces) that .close()
should be explicit in the one test case that actually test an early
close() doesn't fail :)

On 30 June 2016 at 01:22, Gary Gregory <[hidden email]> wrote:

> I disagree with the -1s, but hey, that's just me -1. Reverted.
>
> G
>
> On Wed, Jun 29, 2016 at 5:19 PM, sebb <[hidden email]> wrote:
>
>> On 30 June 2016 at 01:08,  <[hidden email]> wrote:
>> > try-with-resources.
>> >
>> > Project: http://git-wip-us.apache.org/repos/asf/commons-crypto/repo
>> > Commit:
>> http://git-wip-us.apache.org/repos/asf/commons-crypto/commit/b11f6ffa
>> > Tree:
>> http://git-wip-us.apache.org/repos/asf/commons-crypto/tree/b11f6ffa
>> > Diff:
>> http://git-wip-us.apache.org/repos/asf/commons-crypto/diff/b11f6ffa
>> >
>> > Branch: refs/heads/master
>> > Commit: b11f6ffaecef327840c3f42b880937a267ac7637
>> > Parents: 9ecfae2
>> > Author: Gary Gregory <[hidden email]>
>> > Authored: Wed Jun 29 17:08:49 2016 -0700
>> > Committer: Gary Gregory <[hidden email]>
>> > Committed: Wed Jun 29 17:08:49 2016 -0700
>> >
>> > ----------------------------------------------------------------------
>> >  .../commons/crypto/cipher/AbstractCipherTest.java   | 16
>> ++++++++--------
>> >  1 file changed, 8 insertions(+), 8 deletions(-)
>> > ----------------------------------------------------------------------
>> >
>> >
>> >
>> http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/b11f6ffa/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
>> > ----------------------------------------------------------------------
>> > diff --git
>> a/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
>> b/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
>> > index 3da0511..65f1472 100644
>> > ---
>> a/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
>> > +++
>> b/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
>> > @@ -82,18 +82,18 @@ public abstract class AbstractCipherTest {
>> >
>> >      @Test
>> >      public void closeTestAfterInit() throws Exception {
>> > -        CryptoCipher enc = getCipher(transformations[0]);
>> > -        enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"),
>> new IvParameterSpec(IV));
>> > -        enc.close();
>> > +        try (CryptoCipher enc = getCipher(transformations[0])) {
>> > +            enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY,
>> "AES"), new IvParameterSpec(IV));
>> > +        }
>>
>> -1
>>
>> This is specifically designed to test  init and close
>> It's not helpful to hide the close in the try with resources block.
>>
>> >      }
>> >
>> >      @Test
>> >      public void reInitTest() throws Exception {
>> > -        CryptoCipher enc = getCipher(transformations[0]);
>> > -        enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"),
>> new IvParameterSpec(IV));
>> > -        enc.init(Cipher.DECRYPT_MODE, new SecretKeySpec(KEY, "AES"),
>> new IvParameterSpec(IV));
>> > -        enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY, "AES"),
>> new IvParameterSpec(IV));
>> > -        enc.close();
>> > +        try (CryptoCipher enc = getCipher(transformations[0])) {
>> > +            enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY,
>> "AES"), new IvParameterSpec(IV));
>> > +            enc.init(Cipher.DECRYPT_MODE, new SecretKeySpec(KEY,
>> "AES"), new IvParameterSpec(IV));
>> > +            enc.init(Cipher.ENCRYPT_MODE, new SecretKeySpec(KEY,
>> "AES"), new IvParameterSpec(IV));
>> > +        }
>>
>> -1
>>
>> DItto
>>
>> >      }
>> >
>> >      @Test
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>
>
> --
> E-Mail: [hidden email] | [hidden email]
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory



--
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons
http://orcid.org/0000-0001-9842-9718

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]