Re: [2/2] [lang] remove unused bcel test dependency

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [2/2] [lang] remove unused bcel test dependency

Benedikt Ritter-4
Nice one!

<[hidden email]> schrieb am Sa. 14. Okt. 2017 um 15:27:

> remove unused bcel test dependency
>
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/commons-lang/commit/66226ec1
> Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/66226ec1
> Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/66226ec1
>
> Branch: refs/heads/master
> Commit: 66226ec1c2ff33e138189463001c649dbb404f56
> Parents: 2a8187f
> Author: pascalschumacher <[hidden email]>
> Authored: Sat Oct 14 15:27:27 2017 +0200
> Committer: pascalschumacher <[hidden email]>
> Committed: Sat Oct 14 15:27:27 2017 +0200
>
> ----------------------------------------------------------------------
>  pom.xml | 7 -------
>  1 file changed, 7 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/commons-lang/blob/66226ec1/pom.xml
> ----------------------------------------------------------------------
> diff --git a/pom.xml b/pom.xml
> index 6ba161e..6db828a 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -523,13 +523,6 @@
>      </dependency>
>
>      <dependency>
> -      <groupId>org.apache.bcel</groupId>
> -      <artifactId>bcel</artifactId>
> -      <version>6.0</version>
> -      <scope>test</scope>
> -    </dependency>
> -
> -    <dependency>
>        <groupId>org.easymock</groupId>
>        <artifactId>easymock</artifactId>
>        <version>3.5</version>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [2/2] [lang] remove unused bcel test dependency

garydgregory
boom! :-)

too bad Checkstyle does not do that for you!

Gary

On Oct 14, 2017 10:54, "Benedikt Ritter" <[hidden email]> wrote:

> Nice one!
>
> <[hidden email]> schrieb am Sa. 14. Okt. 2017 um 15:27:
>
>> remove unused bcel test dependency
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/
>> 66226ec1
>> Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/66226ec1
>> Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/66226ec1
>>
>> Branch: refs/heads/master
>> Commit: 66226ec1c2ff33e138189463001c649dbb404f56
>> Parents: 2a8187f
>> Author: pascalschumacher <[hidden email]>
>> Authored: Sat Oct 14 15:27:27 2017 +0200
>> Committer: pascalschumacher <[hidden email]>
>> Committed: Sat Oct 14 15:27:27 2017 +0200
>>
>> ----------------------------------------------------------------------
>>  pom.xml | 7 -------
>>  1 file changed, 7 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/commons-lang/blob/66226ec1/pom.xml
>> ----------------------------------------------------------------------
>> diff --git a/pom.xml b/pom.xml
>> index 6ba161e..6db828a 100644
>> --- a/pom.xml
>> +++ b/pom.xml
>> @@ -523,13 +523,6 @@
>>      </dependency>
>>
>>      <dependency>
>> -      <groupId>org.apache.bcel</groupId>
>> -      <artifactId>bcel</artifactId>
>> -      <version>6.0</version>
>> -      <scope>test</scope>
>> -    </dependency>
>> -
>> -    <dependency>
>>        <groupId>org.easymock</groupId>
>>        <artifactId>easymock</artifactId>
>>        <version>3.5</version>
>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: [2/2] [lang] remove unused bcel test dependency

Charles Honton
You can use dependency:analyze to find used and undeclared or unused and declared dependencies.  Perhaps we should add dependency:analyze-only to release profile of parent pom to make sure dependencies are clean.

Chas

> On Oct 14, 2017, at 9:56 AM, Gary Gregory <[hidden email]> wrote:
>
> boom! :-)
>
> too bad Checkstyle does not do that for you!
>
> Gary
>
>> On Oct 14, 2017 10:54, "Benedikt Ritter" <[hidden email]> wrote:
>>
>> Nice one!
>>
>> <[hidden email]> schrieb am Sa. 14. Okt. 2017 um 15:27:
>>
>>> remove unused bcel test dependency
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/
>>> 66226ec1
>>> Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/66226ec1
>>> Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/66226ec1
>>>
>>> Branch: refs/heads/master
>>> Commit: 66226ec1c2ff33e138189463001c649dbb404f56
>>> Parents: 2a8187f
>>> Author: pascalschumacher <[hidden email]>
>>> Authored: Sat Oct 14 15:27:27 2017 +0200
>>> Committer: pascalschumacher <[hidden email]>
>>> Committed: Sat Oct 14 15:27:27 2017 +0200
>>>
>>> ----------------------------------------------------------------------
>>> pom.xml | 7 -------
>>> 1 file changed, 7 deletions(-)
>>> ----------------------------------------------------------------------
>>>
>>>
>>> http://git-wip-us.apache.org/repos/asf/commons-lang/blob/66226ec1/pom.xml
>>> ----------------------------------------------------------------------
>>> diff --git a/pom.xml b/pom.xml
>>> index 6ba161e..6db828a 100644
>>> --- a/pom.xml
>>> +++ b/pom.xml
>>> @@ -523,13 +523,6 @@
>>>     </dependency>
>>>
>>>     <dependency>
>>> -      <groupId>org.apache.bcel</groupId>
>>> -      <artifactId>bcel</artifactId>
>>> -      <version>6.0</version>
>>> -      <scope>test</scope>
>>> -    </dependency>
>>> -
>>> -    <dependency>
>>>       <groupId>org.easymock</groupId>
>>>       <artifactId>easymock</artifactId>
>>>       <version>3.5</version>
>>>
>>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [2/2] [lang] remove unused bcel test dependency

Benedikt Ritter-4
Hi Chas,

> Am 15.10.2017 um 20:29 schrieb Chas Honton <[hidden email]>:
>
> You can use dependency:analyze to find used and undeclared or unused and declared dependencies.  Perhaps we should add dependency:analyze-only to release profile of parent pom to make sure dependencies are clean.

Good idea! We could even add it to our default goal, so that it will be run on every Travis build.

Benedikt

>
> Chas
>
>> On Oct 14, 2017, at 9:56 AM, Gary Gregory <[hidden email]> wrote:
>>
>> boom! :-)
>>
>> too bad Checkstyle does not do that for you!
>>
>> Gary
>>
>>> On Oct 14, 2017 10:54, "Benedikt Ritter" <[hidden email]> wrote:
>>>
>>> Nice one!
>>>
>>> <[hidden email]> schrieb am Sa. 14. Okt. 2017 um 15:27:
>>>
>>>> remove unused bcel test dependency
>>>>
>>>>
>>>> Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
>>>> Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/
>>>> 66226ec1
>>>> Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/66226ec1
>>>> Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/66226ec1
>>>>
>>>> Branch: refs/heads/master
>>>> Commit: 66226ec1c2ff33e138189463001c649dbb404f56
>>>> Parents: 2a8187f
>>>> Author: pascalschumacher <[hidden email]>
>>>> Authored: Sat Oct 14 15:27:27 2017 +0200
>>>> Committer: pascalschumacher <[hidden email]>
>>>> Committed: Sat Oct 14 15:27:27 2017 +0200
>>>>
>>>> ----------------------------------------------------------------------
>>>> pom.xml | 7 -------
>>>> 1 file changed, 7 deletions(-)
>>>> ----------------------------------------------------------------------
>>>>
>>>>
>>>> http://git-wip-us.apache.org/repos/asf/commons-lang/blob/66226ec1/pom.xml
>>>> ----------------------------------------------------------------------
>>>> diff --git a/pom.xml b/pom.xml
>>>> index 6ba161e..6db828a 100644
>>>> --- a/pom.xml
>>>> +++ b/pom.xml
>>>> @@ -523,13 +523,6 @@
>>>>    </dependency>
>>>>
>>>>    <dependency>
>>>> -      <groupId>org.apache.bcel</groupId>
>>>> -      <artifactId>bcel</artifactId>
>>>> -      <version>6.0</version>
>>>> -      <scope>test</scope>
>>>> -    </dependency>
>>>> -
>>>> -    <dependency>
>>>>      <groupId>org.easymock</groupId>
>>>>      <artifactId>easymock</artifactId>
>>>>      <version>3.5</version>
>>>>
>>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [2/2] [lang] remove unused bcel test dependency

sebb-2-2
On 16 October 2017 at 08:54, Benedikt Ritter <[hidden email]> wrote:
> Hi Chas,
>
>> Am 15.10.2017 um 20:29 schrieb Chas Honton <[hidden email]>:
>>
>> You can use dependency:analyze to find used and undeclared or unused and declared dependencies.  Perhaps we should add dependency:analyze-only to release profile of parent pom to make sure dependencies are clean.
>
> Good idea! We could even add it to our default goal, so that it will be run on every Travis build.

I'm not keen on adding more to the default goal.
Depends on how long it takes to run, and does it use network resources?

> Benedikt
>
>>
>> Chas
>>
>>> On Oct 14, 2017, at 9:56 AM, Gary Gregory <[hidden email]> wrote:
>>>
>>> boom! :-)
>>>
>>> too bad Checkstyle does not do that for you!
>>>
>>> Gary
>>>
>>>> On Oct 14, 2017 10:54, "Benedikt Ritter" <[hidden email]> wrote:
>>>>
>>>> Nice one!
>>>>
>>>> <[hidden email]> schrieb am Sa. 14. Okt. 2017 um 15:27:
>>>>
>>>>> remove unused bcel test dependency
>>>>>
>>>>>
>>>>> Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
>>>>> Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/
>>>>> 66226ec1
>>>>> Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/66226ec1
>>>>> Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/66226ec1
>>>>>
>>>>> Branch: refs/heads/master
>>>>> Commit: 66226ec1c2ff33e138189463001c649dbb404f56
>>>>> Parents: 2a8187f
>>>>> Author: pascalschumacher <[hidden email]>
>>>>> Authored: Sat Oct 14 15:27:27 2017 +0200
>>>>> Committer: pascalschumacher <[hidden email]>
>>>>> Committed: Sat Oct 14 15:27:27 2017 +0200
>>>>>
>>>>> ----------------------------------------------------------------------
>>>>> pom.xml | 7 -------
>>>>> 1 file changed, 7 deletions(-)
>>>>> ----------------------------------------------------------------------
>>>>>
>>>>>
>>>>> http://git-wip-us.apache.org/repos/asf/commons-lang/blob/66226ec1/pom.xml
>>>>> ----------------------------------------------------------------------
>>>>> diff --git a/pom.xml b/pom.xml
>>>>> index 6ba161e..6db828a 100644
>>>>> --- a/pom.xml
>>>>> +++ b/pom.xml
>>>>> @@ -523,13 +523,6 @@
>>>>>    </dependency>
>>>>>
>>>>>    <dependency>
>>>>> -      <groupId>org.apache.bcel</groupId>
>>>>> -      <artifactId>bcel</artifactId>
>>>>> -      <version>6.0</version>
>>>>> -      <scope>test</scope>
>>>>> -    </dependency>
>>>>> -
>>>>> -    <dependency>
>>>>>      <groupId>org.easymock</groupId>
>>>>>      <artifactId>easymock</artifactId>
>>>>>      <version>3.5</version>
>>>>>
>>>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]