Re: [3/3] commons-complex git commit: Two patches from Raymond DeCampo

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [3/3] commons-complex git commit: Two patches from Raymond DeCampo

Gilles Sadowski
Hi Eric.

This commit contains a whole slew of spurious files.
Please revert.

On Fri, 06 Jan 2017 11:09:13 -0000, [hidden email] wrote:
> Two patches from Raymond DeCampo

We should try and be more explicit: JIRA issue number if applicable
and short description of what is being committed or the type of change
if it is a minor change (e.g. "Javadoc" or "Unit test").

Thanks,
Gilles

>
> Project: http://git-wip-us.apache.org/repos/asf/commons-complex/repo
> Commit:
>
> http://git-wip-us.apache.org/repos/asf/commons-complex/commit/dbad5ed4
> Tree:
> http://git-wip-us.apache.org/repos/asf/commons-complex/tree/dbad5ed4
> Diff:
> http://git-wip-us.apache.org/repos/asf/commons-complex/diff/dbad5ed4
>
> Branch: refs/heads/master
> Commit: dbad5ed4b7d577f9cf8cc757807b4b886c9dcbbf
> Parents: b0db8fc
> Author: Eric Barnhill <[hidden email]>
> Authored: Fri Jan 6 12:05:58 2017 +0100
> Committer: Eric Barnhill <[hidden email]>
> Committed: Fri Jan 6 12:05:58 2017 +0100
>
>
> ----------------------------------------------------------------------
>  .classpath                                      |   26 -
>  .gitignore                                      |   18 +
>  .project                                        |   23 -
>  .settings/org.eclipse.core.resources.prefs      |    4 -
>  .settings/org.eclipse.jdt.core.prefs            |    5 -
>  .settings/org.eclipse.m2e.core.prefs            |    4 -
>  log.txt                                         |  121 +--
>  .../commons/complex/RootsOfUnityTest.java       |   13 +-
>  .../util/LocalizedFormats_fr.properties         |  343 ------
>  .../commons/math4/random/new-joe-kuo-6.1000     | 1000
> ------------------
>  target/jacoco.exec                              |  Bin 14200 ->
> 14200 bytes
>  .../compile/default-compile/createdFiles.lst    |    1 +
>  .../default-testCompile/createdFiles.lst        |    7 +
>  target/osgi/MANIFEST.MF                         |    4 +-
>  ...apache.commons.complex.ComplexFormatTest.xml |    4 +-
>  ...T-org.apache.commons.complex.ComplexTest.xml |   48 +-
>  ....apache.commons.complex.ComplexUtilsTest.xml |   34 +-
>  ....commons.complex.FrenchComplexFormatTest.xml |   16 +-
>  ...rg.apache.commons.complex.QuaternionTest.xml |    8 +-
>  ...g.apache.commons.complex.RetryRunnerTest.xml |    6 +-
>  ....apache.commons.complex.RootsOfUnityTest.xml |   23 +-
>  ...apache.commons.complex.ComplexFormatTest.txt |    2 +-
>  .../org.apache.commons.complex.ComplexTest.txt  |   18 +-
>  ....apache.commons.complex.ComplexUtilsTest.txt |   30 +-
>  ....commons.complex.FrenchComplexFormatTest.txt |    2 +-
>  ...rg.apache.commons.complex.QuaternionTest.txt |    8 +-
>  ...g.apache.commons.complex.RetryRunnerTest.txt |    2 +-
>  ....apache.commons.complex.RootsOfUnityTest.txt |   17 +-
>  .../commons/complex/RootsOfUnityTest.class      |  Bin 2507 -> 2480
> bytes
>  29 files changed, 166 insertions(+), 1621 deletions(-)
>
> ----------------------------------------------------------------------
>
>
> [...]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [3/3] commons-complex git commit: Two patches from Raymond DeCampo

Eric Barnhill
Seems to me that detailed discussions about what happened are more suitable
for a JIRA tag.
If so let's continue this thread over in
https://issues.apache.org/jira/browse/COMPLEX-1 .

Eric

On Fri, Jan 6, 2017 at 1:12 PM, Gilles <[hidden email]> wrote:

> Hi Eric.
>
> This commit contains a whole slew of spurious files.
> Please revert.
>
> On Fri, 06 Jan 2017 11:09:13 -0000, [hidden email] wrote:
>
>> Two patches from Raymond DeCampo
>>
>
> We should try and be more explicit: JIRA issue number if applicable
> and short description of what is being committed or the type of change
> if it is a minor change (e.g. "Javadoc" or "Unit test").
>
> Thanks,
> Gilles
>
>
>> Project: http://git-wip-us.apache.org/repos/asf/commons-complex/repo
>> Commit:
>>
>> http://git-wip-us.apache.org/repos/asf/commons-complex/commit/dbad5ed4
>> Tree: http://git-wip-us.apache.org/repos/asf/commons-complex/tree/
>> dbad5ed4
>> Diff: http://git-wip-us.apache.org/repos/asf/commons-complex/diff/
>> dbad5ed4
>>
>> Branch: refs/heads/master
>> Commit: dbad5ed4b7d577f9cf8cc757807b4b886c9dcbbf
>> Parents: b0db8fc
>> Author: Eric Barnhill <[hidden email]>
>> Authored: Fri Jan 6 12:05:58 2017 +0100
>> Committer: Eric Barnhill <[hidden email]>
>> Committed: Fri Jan 6 12:05:58 2017 +0100
>>
>>
>> ----------------------------------------------------------------------
>>  .classpath                                      |   26 -
>>  .gitignore                                      |   18 +
>>  .project                                        |   23 -
>>  .settings/org.eclipse.core.resources.prefs      |    4 -
>>  .settings/org.eclipse.jdt.core.prefs            |    5 -
>>  .settings/org.eclipse.m2e.core.prefs            |    4 -
>>  log.txt                                         |  121 +--
>>  .../commons/complex/RootsOfUnityTest.java       |   13 +-
>>  .../util/LocalizedFormats_fr.properties         |  343 ------
>>  .../commons/math4/random/new-joe-kuo-6.1000     | 1000
>> ------------------
>>  target/jacoco.exec                              |  Bin 14200 -> 14200
>> bytes
>>  .../compile/default-compile/createdFiles.lst    |    1 +
>>  .../default-testCompile/createdFiles.lst        |    7 +
>>  target/osgi/MANIFEST.MF                         |    4 +-
>>  ...apache.commons.complex.ComplexFormatTest.xml |    4 +-
>>  ...T-org.apache.commons.complex.ComplexTest.xml |   48 +-
>>  ....apache.commons.complex.ComplexUtilsTest.xml |   34 +-
>>  ....commons.complex.FrenchComplexFormatTest.xml |   16 +-
>>  ...rg.apache.commons.complex.QuaternionTest.xml |    8 +-
>>  ...g.apache.commons.complex.RetryRunnerTest.xml |    6 +-
>>  ....apache.commons.complex.RootsOfUnityTest.xml |   23 +-
>>  ...apache.commons.complex.ComplexFormatTest.txt |    2 +-
>>  .../org.apache.commons.complex.ComplexTest.txt  |   18 +-
>>  ....apache.commons.complex.ComplexUtilsTest.txt |   30 +-
>>  ....commons.complex.FrenchComplexFormatTest.txt |    2 +-
>>  ...rg.apache.commons.complex.QuaternionTest.txt |    8 +-
>>  ...g.apache.commons.complex.RetryRunnerTest.txt |    2 +-
>>  ....apache.commons.complex.RootsOfUnityTest.txt |   17 +-
>>  .../commons/complex/RootsOfUnityTest.class      |  Bin 2507 -> 2480
>> bytes
>>  29 files changed, 166 insertions(+), 1621 deletions(-)
>>
>> ----------------------------------------------------------------------
>>
>>
>> [...]
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>