Re: [commons-daemon] 02/02: Update RAT config to exclude generated files and autoconf related files

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [commons-daemon] 02/02: Update RAT config to exclude generated files and autoconf related files

Rob Tompkins
Given that the files were auto-generated, do we require another RC? I
think that the precedent is yes, but the question I think is a
reasonable one.

-Rob


On 6/19/2019 6:46 AM, [hidden email] wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> markt pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/commons-daemon.git
>
> commit a089ee036affef903029b481de9e9137294b0217
> Author: Mark Thomas <[hidden email]>
> AuthorDate: Wed Jun 19 11:46:19 2019 +0100
>
>      Update RAT config to exclude generated files and autoconf related files
> ---
>   pom.xml | 49 ++++++++++++++++++++++++++++++++++---------------
>   1 file changed, 34 insertions(+), 15 deletions(-)
>
> diff --git a/pom.xml b/pom.xml
> index 5110711..c8c4c40 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -116,20 +116,39 @@
>     </properties>
>  
>     <build>
> -    <plugins>
> -      <plugin>
> -        <artifactId>maven-assembly-plugin</artifactId>
> -        <configuration>
> -          <descriptors>
> -            <descriptor>src/assembly/native-src.xml</descriptor>
> -            <descriptor>src/assembly/bin.xml</descriptor>
> -            <descriptor>src/assembly/src.xml</descriptor>
> -            <descriptor>src/assembly/win.xml</descriptor>
> -          </descriptors>
> -          <tarLongFileMode>gnu</tarLongFileMode>
> -        </configuration>
> -      </plugin>
> -    </plugins>
> +    <pluginManagement>
> +      <plugins>
> +        <plugin>
> +          <groupId>org.apache.rat</groupId>
> +          <artifactId>apache-rat-plugin</artifactId>
> +          <configuration>
> +            <excludes>
> +              <!-- Free Software (see header) -->
> +              <exclude>src/native/unix/configure</exclude>
> +              <!-- GPL with applicable exception that allows ALv2 -->
> +              <exclude>src/native/unix/support/config.guess</exclude>
> +              <exclude>src/native/unix/support/config.sub</exclude>
> +              <!-- Files created by Configure -->
> +              <!-- Excluded from Git but may be present locally -->
> +              <exclude>src/native/unix/config.nice</exclude>
> +              <exclude>src/native/unix/config.status</exclude>
> +              <exclude>src/native/unix/config.log</exclude>
> +            </excludes>
> +          </configuration>
> +        </plugin>
> +        <plugin>
> +          <artifactId>maven-assembly-plugin</artifactId>
> +          <configuration>
> +            <descriptors>
> +              <descriptor>src/assembly/native-src.xml</descriptor>
> +              <descriptor>src/assembly/bin.xml</descriptor>
> +              <descriptor>src/assembly/src.xml</descriptor>
> +              <descriptor>src/assembly/win.xml</descriptor>
> +            </descriptors>
> +            <tarLongFileMode>gnu</tarLongFileMode>
> +          </configuration>
> +        </plugin>
> +      </plugins>
> +    </pluginManagement>
>     </build>
> -
>   </project>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [commons-daemon] 02/02: Update RAT config to exclude generated files and autoconf related files

Mark Thomas
On 19/06/2019 12:24, Rob Tompkins wrote:
> Given that the files were auto-generated, do we require another RC? I
> think that the precedent is yes, but the question I think is a
> reasonable one.

ASF policy doesn't require another RC in these circumstances.

Whether we choose to is a slightly different questions. The more
frequently a product is released, the more relaxed I am about just
fixing minor issues in the next release.

Nearly all of the changes since 1.1.1 have been cosmetic. The exception
is the PR I missed to improve mips detection. The other factor is the
change in Windows OS support.

Given the relative low frequency of releases, the mips PR and the
Windows version support, a 1.2.0 RC (and it can be an RC now I have got
my head around how to get the code signing to handle multiple RCs
without complaining about duplicate version numbers) looks like the
right way to go.

That said, given that the changes since the 1.1.1 tag are nearly all
cosmetic, I think it makes sense to keep testing 1.1.1 to ensure we ID
all the issues to avoid multiple 1.2.0 RCs.

Any issues that emerge during the 1.2.0 release vote that were also
present, but not found, in 1.1.1 are going to have to have significant
end-user impact to motivate me to roll as second 1.2.0 RC.

Mark


>
> -Rob
>
>
> On 6/19/2019 6:46 AM, [hidden email] wrote:
>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> markt pushed a commit to branch master
>> in repository https://gitbox.apache.org/repos/asf/commons-daemon.git
>>
>> commit a089ee036affef903029b481de9e9137294b0217
>> Author: Mark Thomas <[hidden email]>
>> AuthorDate: Wed Jun 19 11:46:19 2019 +0100
>>
>>      Update RAT config to exclude generated files and autoconf related
>> files
>> ---
>>   pom.xml | 49 ++++++++++++++++++++++++++++++++++---------------
>>   1 file changed, 34 insertions(+), 15 deletions(-)
>>
>> diff --git a/pom.xml b/pom.xml
>> index 5110711..c8c4c40 100644
>> --- a/pom.xml
>> +++ b/pom.xml
>> @@ -116,20 +116,39 @@
>>     </properties>
>>       <build>
>> -    <plugins>
>> -      <plugin>
>> -        <artifactId>maven-assembly-plugin</artifactId>
>> -        <configuration>
>> -          <descriptors>
>> -            <descriptor>src/assembly/native-src.xml</descriptor>
>> -            <descriptor>src/assembly/bin.xml</descriptor>
>> -            <descriptor>src/assembly/src.xml</descriptor>
>> -            <descriptor>src/assembly/win.xml</descriptor>
>> -          </descriptors>
>> -          <tarLongFileMode>gnu</tarLongFileMode>
>> -        </configuration>
>> -      </plugin>
>> -    </plugins>
>> +    <pluginManagement>
>> +      <plugins>
>> +        <plugin>
>> +          <groupId>org.apache.rat</groupId>
>> +          <artifactId>apache-rat-plugin</artifactId>
>> +          <configuration>
>> +            <excludes>
>> +              <!-- Free Software (see header) -->
>> +              <exclude>src/native/unix/configure</exclude>
>> +              <!-- GPL with applicable exception that allows ALv2 -->
>> +              <exclude>src/native/unix/support/config.guess</exclude>
>> +              <exclude>src/native/unix/support/config.sub</exclude>
>> +              <!-- Files created by Configure -->
>> +              <!-- Excluded from Git but may be present locally -->
>> +              <exclude>src/native/unix/config.nice</exclude>
>> +              <exclude>src/native/unix/config.status</exclude>
>> +              <exclude>src/native/unix/config.log</exclude>
>> +            </excludes>
>> +          </configuration>
>> +        </plugin>
>> +        <plugin>
>> +          <artifactId>maven-assembly-plugin</artifactId>
>> +          <configuration>
>> +            <descriptors>
>> +              <descriptor>src/assembly/native-src.xml</descriptor>
>> +              <descriptor>src/assembly/bin.xml</descriptor>
>> +              <descriptor>src/assembly/src.xml</descriptor>
>> +              <descriptor>src/assembly/win.xml</descriptor>
>> +            </descriptors>
>> +            <tarLongFileMode>gnu</tarLongFileMode>
>> +          </configuration>
>> +        </plugin>
>> +      </plugins>
>> +    </pluginManagement>
>>     </build>
>> -
>>   </project>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]