Re: commons-numbers git commit: NUMBERS-79: Fraction.add() and .subtract() are long-based

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: commons-numbers git commit: NUMBERS-79: Fraction.add() and .subtract() are long-based

Gilles Sadowski
Convention is to set the "serialVersionUID" to the date of the change.

Regards,
Gilles

On Sat,  1 Dec 2018 00:10:48 +0000 (UTC), [hidden email]
wrote:

> Repository: commons-numbers
> Updated Branches:
>   refs/heads/fraction-dev 16f60190b -> ac4d27549
>
>
> NUMBERS-79: Fraction.add() and .subtract() are long-based
>
> Converted add() and subtract() methods of Fraction class to
> long-based
> operations with recommendation to use BigFraction for very large
> numerators and denominators. Updated corresponding documentation.
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-numbers/repo
> Commit:
>
> http://git-wip-us.apache.org/repos/asf/commons-numbers/commit/ac4d2754
> Tree:
> http://git-wip-us.apache.org/repos/asf/commons-numbers/tree/ac4d2754
> Diff:
> http://git-wip-us.apache.org/repos/asf/commons-numbers/diff/ac4d2754
>
> Branch: refs/heads/fraction-dev
> Commit: ac4d27549483a67b5cb1f87fe952c86ea687ccd3
> Parents: 16f6019
> Author: Eric Barnhill <[hidden email]>
> Authored: Fri Nov 30 16:07:17 2018 -0800
> Committer: Eric Barnhill <[hidden email]>
> Committed: Fri Nov 30 16:07:17 2018 -0800
>
>
> ----------------------------------------------------------------------
>  .../commons/numbers/fraction/Fraction.java      | 177
> ++++++++-----------
>  1 file changed, 76 insertions(+), 101 deletions(-)
>
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/commons-numbers/blob/ac4d2754/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
>
> ----------------------------------------------------------------------
> diff --git
>
> a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
>
> b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
> index 673d0d5..aeb5030 100644
> ---
>
> a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
> +++
>
> b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
> @@ -19,18 +19,19 @@ package org.apache.commons.numbers.fraction;
>  import java.io.Serializable;
>  import java.math.BigInteger;
>  import org.apache.commons.numbers.core.ArithmeticUtils;
> +import org.apache.commons.numbers.core.NativeOperators;
>
>  /**
>   * Representation of a rational number.
> - *
> - * implements Serializable since 2.0
>   */
>  public class Fraction
>      extends Number
> -    implements Comparable<Fraction>, Serializable {
> +    implements Comparable<Fraction>,
> +               Serializable,
> +               NativeOperators<Fraction> {
>
> -    /** A fraction representing "2 / 1". */
> -    public static final Fraction TWO = new Fraction(2, 1);
> +    /** Serializable version identifier */
> +    private static final long serialVersionUID =
> 3698073679419233275L;
>
> [...]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]