Re: [lang] JUnit imports (closes #247)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [lang] JUnit imports (closes #247)

Benedikt Ritter-4
Nice catch!

> Am 28.02.2017 um 23:34 schrieb [hidden email]:
>
> Repository: commons-lang
> Updated Branches:
>  refs/heads/master 98fa164cd -> c79e6fb8f
>
>
> JUnit imports (closes #247)
>
> The junit.framework package has been deprecated, and should no longer
> be used.
>
> This patch fixes the one remaining import from it to statically import
> org.junit.Assert.assertNull instead.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
> Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/c79e6fb8
> Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/c79e6fb8
> Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/c79e6fb8
>
> Branch: refs/heads/master
> Commit: c79e6fb8f95bb07d2394221b29b75fcc016f4900
> Parents: 98fa164
> Author: Allon Mureinik <[hidden email]>
> Authored: Tue Feb 28 23:17:51 2017 +0200
> Committer: pascalschumacher <[hidden email]>
> Committed: Tue Feb 28 23:33:26 2017 +0100
>
> ----------------------------------------------------------------------
> src/test/java/org/apache/commons/lang3/RandomUtilsTest.java | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/commons-lang/blob/c79e6fb8/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> ----------------------------------------------------------------------
> diff --git a/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java b/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> index ed032e7..ddbaab1 100644
> --- a/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> +++ b/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> @@ -16,10 +16,10 @@
>  */
> package org.apache.commons.lang3;
>
> -import static junit.framework.TestCase.assertNotNull;
> import static org.junit.Assert.assertArrayEquals;
> import static org.junit.Assert.assertEquals;
> import static org.junit.Assert.assertFalse;
> +import static org.junit.Assert.assertNotNull;
> import static org.junit.Assert.assertTrue;
>
> import org.junit.Test;
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [lang] JUnit imports (closes #247)

Allon Mureinik
thanks

On Wed, Mar 8, 2017 at 10:22 AM, Benedikt Ritter <[hidden email]> wrote:

> Nice catch!
>
> > Am 28.02.2017 um 23:34 schrieb [hidden email]:
> >
> > Repository: commons-lang
> > Updated Branches:
> >  refs/heads/master 98fa164cd -> c79e6fb8f
> >
> >
> > JUnit imports (closes #247)
> >
> > The junit.framework package has been deprecated, and should no longer
> > be used.
> >
> > This patch fixes the one remaining import from it to statically import
> > org.junit.Assert.assertNull instead.
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/
> c79e6fb8
> > Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/c79e6fb8
> > Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/c79e6fb8
> >
> > Branch: refs/heads/master
> > Commit: c79e6fb8f95bb07d2394221b29b75fcc016f4900
> > Parents: 98fa164
> > Author: Allon Mureinik <[hidden email]>
> > Authored: Tue Feb 28 23:17:51 2017 +0200
> > Committer: pascalschumacher <[hidden email]>
> > Committed: Tue Feb 28 23:33:26 2017 +0100
> >
> > ----------------------------------------------------------------------
> > src/test/java/org/apache/commons/lang3/RandomUtilsTest.java | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > ----------------------------------------------------------------------
> >
> >
> > http://git-wip-us.apache.org/repos/asf/commons-lang/blob/
> c79e6fb8/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> > ----------------------------------------------------------------------
> > diff --git a/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> b/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> > index ed032e7..ddbaab1 100644
> > --- a/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> > +++ b/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> > @@ -16,10 +16,10 @@
> >  */
> > package org.apache.commons.lang3;
> >
> > -import static junit.framework.TestCase.assertNotNull;
> > import static org.junit.Assert.assertArrayEquals;
> > import static org.junit.Assert.assertEquals;
> > import static org.junit.Assert.assertFalse;
> > +import static org.junit.Assert.assertNotNull;
> > import static org.junit.Assert.assertTrue;
> >
> > import org.junit.Test;
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>