Re: svn commit: r1447004 - in /commons/proper/cli/trunk: RELEASE-NOTES.txt src/changes/changes.xml src/conf/checkstyle.xml src/site/xdoc/release_1_3.xml

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1447004 - in /commons/proper/cli/trunk: RELEASE-NOTES.txt src/changes/changes.xml src/conf/checkstyle.xml src/site/xdoc/release_1_3.xml

Benedikt Ritter-4
Hi Thomas,


2013/2/17 <[hidden email]>

> Author: tn
> Date: Sun Feb 17 10:00:32 2013
> New Revision: 1447004
>
> URL: http://svn.apache.org/r1447004
> Log:
> [CLI-231] removed DoubleCheckedLocking test in checkstyle config.
>

According to the committer's FAQ [1] the name of the contributor should be
mentioned in the commit log. Does this not apply to our projects because we
supply changes.xml?

Regards,
Benedikt

[1] http://www.apache.org/dev/committers.html#applying-patches


>
> Modified:
>     commons/proper/cli/trunk/RELEASE-NOTES.txt
>     commons/proper/cli/trunk/src/changes/changes.xml
>     commons/proper/cli/trunk/src/conf/checkstyle.xml
>     commons/proper/cli/trunk/src/site/xdoc/release_1_3.xml
>
> Modified: commons/proper/cli/trunk/RELEASE-NOTES.txt
> URL:
> http://svn.apache.org/viewvc/commons/proper/cli/trunk/RELEASE-NOTES.txt?rev=1447004&r1=1447003&r2=1447004&view=diff
>
> ==============================================================================
> --- commons/proper/cli/trunk/RELEASE-NOTES.txt (original)
> +++ commons/proper/cli/trunk/RELEASE-NOTES.txt Sun Feb 17 10:00:32 2013
> @@ -88,4 +88,6 @@ CHANGES:
>    * Corrected javadoc for return type of
> MissingOptionException.getMissingOptions(). Thanks to Joe Casadonte.
> (CLI-220)
>
>    * Improve description of parameter "stopAtNonOption" in method
> -    CommandLine.parse(Options, String[], boolean). Thanks to Anders
> Larsson. (CLI-197)
> +    CommandLine.parse(Options, String[], boolean). Thanks to Anders
> Larsson. (CLI-197)
> +
> +  * Removed DoubleCheckedLocking test from checkstyle configuration.
> Thanks to Duncan Jones. (CLI-231)
>
> Modified: commons/proper/cli/trunk/src/changes/changes.xml
> URL:
> http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/changes/changes.xml?rev=1447004&r1=1447003&r2=1447004&view=diff
>
> ==============================================================================
> --- commons/proper/cli/trunk/src/changes/changes.xml (original)
> +++ commons/proper/cli/trunk/src/changes/changes.xml Sun Feb 17 10:00:32
> 2013
> @@ -23,6 +23,9 @@
>    <body>
>
>      <release version="1.3" date="in SVN" description="This is a
> maintenance release containing bug fixes.">
> +      <action type="update" dev="tn" issue="CLI-231" due-to="Duncan
> Jones">
> +        Removed DoubleCheckedLocking test from checkstyle configuration.
> +      </action>
>        <action type="update" dev="tn" issue="CLI-230">
>          Options.getRequiredOptions() now returns an unmodifiable list.
>        </action>
>
> Modified: commons/proper/cli/trunk/src/conf/checkstyle.xml
> URL:
> http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/conf/checkstyle.xml?rev=1447004&r1=1447003&r2=1447004&view=diff
>
> ==============================================================================
> --- commons/proper/cli/trunk/src/conf/checkstyle.xml (original)
> +++ commons/proper/cli/trunk/src/conf/checkstyle.xml Sun Feb 17 10:00:32
> 2013
> @@ -135,7 +135,6 @@ limitations under the License.
>          <!-- Checks for common coding problems               -->
>          <!-- See http://checkstyle.sf.net/config_coding.html -->
>          <module name="CovariantEquals"/>
> -        <module name="DoubleCheckedLocking"/>
>          <module name="EqualsHashCode"/>
>          <module name="IllegalInstantiation"/>
>          <module name="InnerAssignment"/>
>
> Modified: commons/proper/cli/trunk/src/site/xdoc/release_1_3.xml
> URL:
> http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/site/xdoc/release_1_3.xml?rev=1447004&r1=1447003&r2=1447004&view=diff
>
> ==============================================================================
> --- commons/proper/cli/trunk/src/site/xdoc/release_1_3.xml (original)
> +++ commons/proper/cli/trunk/src/site/xdoc/release_1_3.xml Sun Feb 17
> 10:00:32 2013
> @@ -111,6 +111,8 @@ CHANGES:
>
>    * Improve description of parameter "stopAtNonOption" in method
>      CommandLine.parse(Options, String[], boolean). Thanks to Anders
> Larsson. (CLI-197)
> +
> +  * Removed DoubleCheckedLocking test from checkstyle configuration.
> Thanks to Duncan Jones. (CLI-231)
>  </source>
>
>  </section>
>
>
>


--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1447004 - in /commons/proper/cli/trunk: RELEASE-NOTES.txt src/changes/changes.xml src/conf/checkstyle.xml src/site/xdoc/release_1_3.xml

Thomas Neidhart
On 02/17/2013 12:56 PM, Benedikt Ritter wrote:

> Hi Thomas,
>
>
> 2013/2/17 <[hidden email]>
>
>> Author: tn
>> Date: Sun Feb 17 10:00:32 2013
>> New Revision: 1447004
>>
>> URL: http://svn.apache.org/r1447004
>> Log:
>> [CLI-231] removed DoubleCheckedLocking test in checkstyle config.
>>
>
> According to the committer's FAQ [1] the name of the contributor should be
> mentioned in the commit log. Does this not apply to our projects because we
> supply changes.xml?

Well yes, normally the contributor should be mentioned, but as this was
just a removal of a line in a configuration file I omitted it.

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1447004 - in /commons/proper/cli/trunk: RELEASE-NOTES.txt src/changes/changes.xml src/conf/checkstyle.xml src/site/xdoc/release_1_3.xml

Benedikt Ritter-4
2013/2/17 Thomas Neidhart <[hidden email]>

> On 02/17/2013 12:56 PM, Benedikt Ritter wrote:
> > Hi Thomas,
> >
> >
> > 2013/2/17 <[hidden email]>
> >
> >> Author: tn
> >> Date: Sun Feb 17 10:00:32 2013
> >> New Revision: 1447004
> >>
> >> URL: http://svn.apache.org/r1447004
> >> Log:
> >> [CLI-231] removed DoubleCheckedLocking test in checkstyle config.
> >>
> >
> > According to the committer's FAQ [1] the name of the contributor should
> be
> > mentioned in the commit log. Does this not apply to our projects because
> we
> > supply changes.xml?
>
> Well yes, normally the contributor should be mentioned, but as this was
> just a removal of a line in a configuration file I omitted it.
>

Thanks for the info!

Benedikt


>
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter