Re: [text] Update .gitignore, using [lang]'s as basis

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [text] Update .gitignore, using [lang]'s as basis

Benedikt Ritter-4
I know we have this in lang's .gitignore. I've added that back when I
didn't know git too well. Today I tend to say that this does not belong
into a project's .gitignore. Ignores for tooling have to go to your global
gitignore imho.

WDYT?

Benedikt

2014-12-13 4:22 GMT+01:00 <[hidden email]>:

>
> Repository: commons-text
> Updated Branches:
>   refs/heads/master 7570eb016 -> 182154e5b
>
>
> Update .gitignore, using [lang]'s as basis
>
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/commons-text/commit/182154e5
> Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/182154e5
> Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/182154e5
>
> Branch: refs/heads/master
> Commit: 182154e5bd4f7f52ffba3728fc03987ff0afda4c
> Parents: 7570eb0
> Author: Bruno P. Kinoshita <[hidden email]>
> Authored: Sat Dec 13 01:22:12 2014 -0200
> Committer: Bruno P. Kinoshita <[hidden email]>
> Committed: Sat Dec 13 01:22:12 2014 -0200
>
> ----------------------------------------------------------------------
>  .gitignore | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/commons-text/blob/182154e5/.gitignore
> ----------------------------------------------------------------------
> diff --git a/.gitignore b/.gitignore
> index c2b8af5..338a65b 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1,3 +1,17 @@
> -target/
> +# Maven build files
> +target
> +*.log
> +maven-eclipse.xml
> +build.properties
>  site-content
>
> +# IntelliJ IDEA files
> +.idea
> +.iws
> +*.iml
> +*.ipr
> +
> +# Eclipse files
> +.settings
> +.classpath
> +.project
>
>

--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Reply | Threaded
Open this post in threaded view
|

Re: [text] Update .gitignore, using [lang]'s as basis

Bruno P. Kinoshita
+1 Benedikt!
Just learned that I can have a global .gitignore :-)
For others that didn't know, here's what I read to grok it.
https://help.github.com/articles/ignoring-files/

@Benedikt, should we delete the .gitignore then or revert to what it was?
ThanksBurno
 
      From: Benedikt Ritter <[hidden email]>
 To: Commons Developers List <[hidden email]>
 Sent: Sunday, December 14, 2014 5:50 PM
 Subject: Re: [text] Update .gitignore, using [lang]'s as basis
   
I know we have this in lang's .gitignore. I've added that back when I
didn't know git too well. Today I tend to say that this does not belong
into a project's .gitignore. Ignores for tooling have to go to your global
gitignore imho.

WDYT?

Benedikt



2014-12-13 4:22 GMT+01:00 <[hidden email]>:

>
> Repository: commons-text
> Updated Branches:
>  refs/heads/master 7570eb016 -> 182154e5b
>
>
> Update .gitignore, using [lang]'s as basis
>
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/commons-text/commit/182154e5
> Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/182154e5
> Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/182154e5
>
> Branch: refs/heads/master
> Commit: 182154e5bd4f7f52ffba3728fc03987ff0afda4c
> Parents: 7570eb0
> Author: Bruno P. Kinoshita <[hidden email]>
> Authored: Sat Dec 13 01:22:12 2014 -0200
> Committer: Bruno P. Kinoshita <[hidden email]>
> Committed: Sat Dec 13 01:22:12 2014 -0200
>
> ----------------------------------------------------------------------
>  .gitignore | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/commons-text/blob/182154e5/.gitignore
> ----------------------------------------------------------------------
> diff --git a/.gitignore b/.gitignore
> index c2b8af5..338a65b 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1,3 +1,17 @@
> -target/
> +# Maven build files
> +target
> +*.log
> +maven-eclipse.xml
> +build.properties
>  site-content
>
> +# IntelliJ IDEA files
> +.idea
> +.iws
> +*.iml
> +*.ipr
> +
> +# Eclipse files
> +.settings
> +.classpath
> +.project
>
>

--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter


   
Reply | Threaded
Open this post in threaded view
|

Re: [text] Update .gitignore, using [lang]'s as basis

Benedikt Ritter-4
2014-12-14 20:54 GMT+01:00 Bruno P. Kinoshita <[hidden email]>:
>
> +1 Benedikt!
> Just learned that I can have a global .gitignore :-)
> For others that didn't know, here's what I read to grok it.
> https://help.github.com/articles/ignoring-files/
>
> @Benedikt, should we delete the .gitignore then or revert to what it was?
>

I think we should revert it to it's initial state. My opinion is, that a
project should ignore any files that are used by build tools in the
project, but nothing more. So in our case we ignore the maven target
directory and the site-content directory we need for our side build.

Can you do that?

TIA!
Benedikt


> ThanksBurno
>
>       From: Benedikt Ritter <[hidden email]>
>  To: Commons Developers List <[hidden email]>
>  Sent: Sunday, December 14, 2014 5:50 PM
>  Subject: Re: [text] Update .gitignore, using [lang]'s as basis
>
> I know we have this in lang's .gitignore. I've added that back when I
> didn't know git too well. Today I tend to say that this does not belong
> into a project's .gitignore. Ignores for tooling have to go to your global
> gitignore imho.
>
> WDYT?
>
> Benedikt
>
>
>
> 2014-12-13 4:22 GMT+01:00 <[hidden email]>:
> >
> > Repository: commons-text
> > Updated Branches:
> >  refs/heads/master 7570eb016 -> 182154e5b
> >
> >
> > Update .gitignore, using [lang]'s as basis
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
> > Commit:
> > http://git-wip-us.apache.org/repos/asf/commons-text/commit/182154e5
> > Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/182154e5
> > Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/182154e5
> >
> > Branch: refs/heads/master
> > Commit: 182154e5bd4f7f52ffba3728fc03987ff0afda4c
> > Parents: 7570eb0
> > Author: Bruno P. Kinoshita <[hidden email]>
> > Authored: Sat Dec 13 01:22:12 2014 -0200
> > Committer: Bruno P. Kinoshita <[hidden email]>
> > Committed: Sat Dec 13 01:22:12 2014 -0200
> >
> > ----------------------------------------------------------------------
> >  .gitignore | 16 +++++++++++++++-
> >  1 file changed, 15 insertions(+), 1 deletion(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/commons-text/blob/182154e5/.gitignore
> > ----------------------------------------------------------------------
> > diff --git a/.gitignore b/.gitignore
> > index c2b8af5..338a65b 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -1,3 +1,17 @@
> > -target/
> > +# Maven build files
> > +target
> > +*.log
> > +maven-eclipse.xml
> > +build.properties
> >  site-content
> >
> > +# IntelliJ IDEA files
> > +.idea
> > +.iws
> > +*.iml
> > +*.ipr
> > +
> > +# Eclipse files
> > +.settings
> > +.classpath
> > +.project
> >
> >
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>
>
>
>

--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Reply | Threaded
Open this post in threaded view
|

Re: [text] Update .gitignore, using [lang]'s as basis

Bruno P. Kinoshita
Good point Benedikt! Changes reverted! Thank you!
https://git-wip-us.apache.org/repos/asf?p=commons-text.git;a=commitdiff;h=37c78040


 
      From: Benedikt Ritter <[hidden email]>
 To: Commons Developers List <[hidden email]>; Bruno P. Kinoshita <[hidden email]>
 Sent: Sunday, December 14, 2014 6:10 PM
 Subject: Re: [text] Update .gitignore, using [lang]'s as basis
   
2014-12-14 20:54 GMT+01:00 Bruno P. Kinoshita <[hidden email]>:
>
> +1 Benedikt!
> Just learned that I can have a global .gitignore :-)
> For others that didn't know, here's what I read to grok it.
> https://help.github.com/articles/ignoring-files/
>
> @Benedikt, should we delete the .gitignore then or revert to what it was?
>

I think we should revert it to it's initial state. My opinion is, that a
project should ignore any files that are used by build tools in the
project, but nothing more. So in our case we ignore the maven target
directory and the site-content directory we need for our side build.

Can you do that?

TIA!
Benedikt


> ThanksBurno
>
>      From: Benedikt Ritter <[hidden email]>
>  To: Commons Developers List <[hidden email]>
>  Sent: Sunday, December 14, 2014 5:50 PM
>  Subject: Re: [text] Update .gitignore, using [lang]'s as basis
>
> I know we have this in lang's .gitignore. I've added that back when I
> didn't know git too well. Today I tend to say that this does not belong
> into a project's .gitignore. Ignores for tooling have to go to your global
> gitignore imho.
>
> WDYT?
>
> Benedikt
>
>
>
> 2014-12-13 4:22 GMT+01:00 <[hidden email]>:
> >
> > Repository: commons-text
> > Updated Branches:
> >  refs/heads/master 7570eb016 -> 182154e5b
> >
> >
> > Update .gitignore, using [lang]'s as basis
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
> > Commit:
> > http://git-wip-us.apache.org/repos/asf/commons-text/commit/182154e5
> > Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/182154e5
> > Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/182154e5
> >
> > Branch: refs/heads/master
> > Commit: 182154e5bd4f7f52ffba3728fc03987ff0afda4c
> > Parents: 7570eb0
> > Author: Bruno P. Kinoshita <[hidden email]>
> > Authored: Sat Dec 13 01:22:12 2014 -0200
> > Committer: Bruno P. Kinoshita <[hidden email]>
> > Committed: Sat Dec 13 01:22:12 2014 -0200
> >
> > ----------------------------------------------------------------------
> >  .gitignore | 16 +++++++++++++++-
> >  1 file changed, 15 insertions(+), 1 deletion(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/commons-text/blob/182154e5/.gitignore
> > ----------------------------------------------------------------------
> > diff --git a/.gitignore b/.gitignore
> > index c2b8af5..338a65b 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -1,3 +1,17 @@
> > -target/
> > +# Maven build files
> > +target
> > +*.log
> > +maven-eclipse.xml
> > +build.properties
> >  site-content
> >
> > +# IntelliJ IDEA files
> > +.idea
> > +.iws
> > +*.iml
> > +*.ipr
> > +
> > +# Eclipse files
> > +.settings
> > +.classpath
> > +.project
> >
> >
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter


>
>
>
>

--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter


   
Reply | Threaded
Open this post in threaded view
|

Re: [text] Update .gitignore, using [lang]'s as basis

sebb-2-2
I suggest you add a comment to .gitignore to document this decision.

On 14 December 2014 at 20:20, Bruno P. Kinoshita
<[hidden email]> wrote:

> Good point Benedikt! Changes reverted! Thank you!
> https://git-wip-us.apache.org/repos/asf?p=commons-text.git;a=commitdiff;h=37c78040
>
>
>
>       From: Benedikt Ritter <[hidden email]>
>  To: Commons Developers List <[hidden email]>; Bruno P. Kinoshita <[hidden email]>
>  Sent: Sunday, December 14, 2014 6:10 PM
>  Subject: Re: [text] Update .gitignore, using [lang]'s as basis
>
> 2014-12-14 20:54 GMT+01:00 Bruno P. Kinoshita <[hidden email]>:
>>
>> +1 Benedikt!
>> Just learned that I can have a global .gitignore :-)
>> For others that didn't know, here's what I read to grok it.
>> https://help.github.com/articles/ignoring-files/
>>
>> @Benedikt, should we delete the .gitignore then or revert to what it was?
>>
>
> I think we should revert it to it's initial state. My opinion is, that a
> project should ignore any files that are used by build tools in the
> project, but nothing more. So in our case we ignore the maven target
> directory and the site-content directory we need for our side build.
>
> Can you do that?
>
> TIA!
> Benedikt
>
>
>> ThanksBurno
>>
>>      From: Benedikt Ritter <[hidden email]>
>>  To: Commons Developers List <[hidden email]>
>>  Sent: Sunday, December 14, 2014 5:50 PM
>>  Subject: Re: [text] Update .gitignore, using [lang]'s as basis
>>
>> I know we have this in lang's .gitignore. I've added that back when I
>> didn't know git too well. Today I tend to say that this does not belong
>> into a project's .gitignore. Ignores for tooling have to go to your global
>> gitignore imho.
>>
>> WDYT?
>>
>> Benedikt
>>
>>
>>
>> 2014-12-13 4:22 GMT+01:00 <[hidden email]>:
>> >
>> > Repository: commons-text
>> > Updated Branches:
>> >  refs/heads/master 7570eb016 -> 182154e5b
>> >
>> >
>> > Update .gitignore, using [lang]'s as basis
>> >
>> >
>> > Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
>> > Commit:
>> > http://git-wip-us.apache.org/repos/asf/commons-text/commit/182154e5
>> > Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/182154e5
>> > Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/182154e5
>> >
>> > Branch: refs/heads/master
>> > Commit: 182154e5bd4f7f52ffba3728fc03987ff0afda4c
>> > Parents: 7570eb0
>> > Author: Bruno P. Kinoshita <[hidden email]>
>> > Authored: Sat Dec 13 01:22:12 2014 -0200
>> > Committer: Bruno P. Kinoshita <[hidden email]>
>> > Committed: Sat Dec 13 01:22:12 2014 -0200
>> >
>> > ----------------------------------------------------------------------
>> >  .gitignore | 16 +++++++++++++++-
>> >  1 file changed, 15 insertions(+), 1 deletion(-)
>> > ----------------------------------------------------------------------
>> >
>> >
>> >
>> >
>> http://git-wip-us.apache.org/repos/asf/commons-text/blob/182154e5/.gitignore
>> > ----------------------------------------------------------------------
>> > diff --git a/.gitignore b/.gitignore
>> > index c2b8af5..338a65b 100644
>> > --- a/.gitignore
>> > +++ b/.gitignore
>> > @@ -1,3 +1,17 @@
>> > -target/
>> > +# Maven build files
>> > +target
>> > +*.log
>> > +maven-eclipse.xml
>> > +build.properties
>> >  site-content
>> >
>> > +# IntelliJ IDEA files
>> > +.idea
>> > +.iws
>> > +*.iml
>> > +*.ipr
>> > +
>> > +# Eclipse files
>> > +.settings
>> > +.classpath
>> > +.project
>> >
>> >
>>
>> --
>> http://people.apache.org/~britter/
>> http://www.systemoutprintln.de/
>> http://twitter.com/BenediktRitter
>> http://github.com/britter
>
>
>>
>>
>>
>>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [text] Update .gitignore, using [lang]'s as basis

Bruno P. Kinoshita
Very good idea Sebb!
Done in 1a236bada5163388a3051083fba454b19edc1fb8, thanks!!
Bruno
 
      From: sebb <[hidden email]>
 To: Commons Developers List <[hidden email]>; Bruno P. Kinoshita <[hidden email]>
 Sent: Monday, December 15, 2014 8:27 AM
 Subject: Re: [text] Update .gitignore, using [lang]'s as basis
   
I suggest you add a comment to .gitignore to document this decision.



On 14 December 2014 at 20:20, Bruno P. Kinoshita
<[hidden email]> wrote:

> Good point Benedikt! Changes reverted! Thank you!
> https://git-wip-us.apache.org/repos/asf?p=commons-text.git;a=commitdiff;h=37c78040
>
>
>
>      From: Benedikt Ritter <[hidden email]>
>  To: Commons Developers List <[hidden email]>; Bruno P. Kinoshita <[hidden email]>
>  Sent: Sunday, December 14, 2014 6:10 PM
>  Subject: Re: [text] Update .gitignore, using [lang]'s as basis
>
> 2014-12-14 20:54 GMT+01:00 Bruno P. Kinoshita <[hidden email]>:
>>
>> +1 Benedikt!
>> Just learned that I can have a global .gitignore :-)
>> For others that didn't know, here's what I read to grok it.
>> https://help.github.com/articles/ignoring-files/
>>
>> @Benedikt, should we delete the .gitignore then or revert to what it was?
>>
>
> I think we should revert it to it's initial state. My opinion is, that a
> project should ignore any files that are used by build tools in the
> project, but nothing more. So in our case we ignore the maven target
> directory and the site-content directory we need for our side build.
>
> Can you do that?
>
> TIA!
> Benedikt
>
>
>> ThanksBurno
>>
>>      From: Benedikt Ritter <[hidden email]>
>>  To: Commons Developers List <[hidden email]>
>>  Sent: Sunday, December 14, 2014 5:50 PM
>>  Subject: Re: [text] Update .gitignore, using [lang]'s as basis
>>
>> I know we have this in lang's .gitignore. I've added that back when I
>> didn't know git too well. Today I tend to say that this does not belong
>> into a project's .gitignore. Ignores for tooling have to go to your global
>> gitignore imho.
>>
>> WDYT?
>>
>> Benedikt
>>
>>
>>
>> 2014-12-13 4:22 GMT+01:00 <[hidden email]>:
>> >
>> > Repository: commons-text
>> > Updated Branches:
>> >  refs/heads/master 7570eb016 -> 182154e5b
>> >
>> >
>> > Update .gitignore, using [lang]'s as basis
>> >
>> >
>> > Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
>> > Commit:
>> > http://git-wip-us.apache.org/repos/asf/commons-text/commit/182154e5
>> > Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/182154e5
>> > Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/182154e5
>> >
>> > Branch: refs/heads/master
>> > Commit: 182154e5bd4f7f52ffba3728fc03987ff0afda4c
>> > Parents: 7570eb0
>> > Author: Bruno P. Kinoshita <[hidden email]>
>> > Authored: Sat Dec 13 01:22:12 2014 -0200
>> > Committer: Bruno P. Kinoshita <[hidden email]>
>> > Committed: Sat Dec 13 01:22:12 2014 -0200
>> >
>> > ----------------------------------------------------------------------
>> >  .gitignore | 16 +++++++++++++++-
>> >  1 file changed, 15 insertions(+), 1 deletion(-)
>> > ----------------------------------------------------------------------
>> >
>> >
>> >
>> >
>> http://git-wip-us.apache.org/repos/asf/commons-text/blob/182154e5/.gitignore
>> > ----------------------------------------------------------------------
>> > diff --git a/.gitignore b/.gitignore
>> > index c2b8af5..338a65b 100644
>> > --- a/.gitignore
>> > +++ b/.gitignore
>> > @@ -1,3 +1,17 @@
>> > -target/
>> > +# Maven build files
>> > +target
>> > +*.log
>> > +maven-eclipse.xml
>> > +build.properties
>> >  site-content
>> >
>> > +# IntelliJ IDEA files
>> > +.idea
>> > +.iws
>> > +*.iml
>> > +*.ipr
>> > +
>> > +# Eclipse files
>> > +.settings
>> > +.classpath
>> > +.project
>> >
>> >
>>
>> --
>> http://people.apache.org/~britter/
>> http://www.systemoutprintln.de/
>> http://twitter.com/BenediktRitter
>> http://github.com/britter
>
>
>>
>>
>>
>>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>
>
>