[VFS] code comment cleanups (GitHub Pull#1)

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[VFS] code comment cleanups (GitHub Pull#1)

Bernd Eckenfels
Hello,

all over the VFS core and providers there are many places where code is  
commented out. Most of the time it looks like it is old code, but  
sometimes it also looks like suggested new implementations or even TODO  
style of things.

I started to remove some of the places, especially where it looks obvious  
to me that it is simply commented out code variantes of older versions.  
Also some other minor comment related stuff is in this pull request here:

https://github.com/apache/commons-vfs/pull/1

Can you check out and see if you think I removed too much or not enough? I  
did not reviewed all files systematically it is more like the files I  
happen to look at anyway.

Greetings
Bernd
--
http://www.zusammenkunft.net

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VFS] code comment cleanups (GitHub Pull#1)

Bernd Eckenfels
Hello,

I rebased Pull#1 against trunk and made a fixup of the commits into one.

https://github.com/apache/commons-vfs/pull/1

Do I need to file it on Jira?

Greetings
Bernd

Am 18.09.2013, 22:00 Uhr, schrieb Bernd Eckenfels <[hidden email]>:

> all over the VFS core and providers there are many places where code is  
> commented out. Most of the time it looks like it is old code, but  
> sometimes it also looks like suggested new implementations or even TODO  
> style of things.
>
> I started to remove some of the places, especially where it looks  
> obvious to me that it is simply commented out code variantes of older  
> versions. Also some other minor comment related stuff is in this pull  
> request here:
>
> https://github.com/apache/commons-vfs/pull/1
>
> Can you check out and see if you think I removed too much or not enough?  
> I did not reviewed all files systematically it is more like the files I  
> happen to look at anyway.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VFS] code comment cleanups (GitHub Pull#1)

garydgregory
Hello Bernd,

I am sorry for the delay in replying to you.

The best input to any Commons project is to create a Jira and attach a
patch in diff file format.

As for our process, Github is fun but we only use it as a mirror and it
just makes it harder to merge changes back in SVN. So I am not sure why we
do that in the first place instead of switching the project to Git, but
that's a different story.

Gary


On Wed, Sep 25, 2013 at 7:57 PM, Bernd Eckenfels <[hidden email]>wrote:

> Hello,
>
> I rebased Pull#1 against trunk and made a fixup of the commits into one.
>
> https://github.com/apache/**commons-vfs/pull/1<https://github.com/apache/commons-vfs/pull/1>
>
> Do I need to file it on Jira?
>
> Greetings
> Bernd
>
> Am 18.09.2013, 22:00 Uhr, schrieb Bernd Eckenfels <[hidden email]
> >:
>
>  all over the VFS core and providers there are many places where code is
>> commented out. Most of the time it looks like it is old code, but sometimes
>> it also looks like suggested new implementations or even TODO style of
>> things.
>>
>> I started to remove some of the places, especially where it looks obvious
>> to me that it is simply commented out code variantes of older versions.
>> Also some other minor comment related stuff is in this pull request here:
>>
>> https://github.com/apache/**commons-vfs/pull/1<https://github.com/apache/commons-vfs/pull/1>
>>
>> Can you check out and see if you think I removed too much or not enough?
>> I did not reviewed all files systematically it is more like the files I
>> happen to look at anyway.
>>
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: dev-unsubscribe@commons.**apache.org<[hidden email]>
> For additional commands, e-mail: [hidden email]
>
>


--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VFS] code comment cleanups (GitHub Pull#1)

Bernd Eckenfels
Hello,

Thanks for the answer - i was hoping to get a confirmation that this change is actually wanted before I put more time in it. I will file a Jira for it.

BTW: die you know you can add .patch to a Guthub Pull request to get a patch? I dont want to Mesa with SVN, so this is how I create the patches:
https://github.com/apache/commons-vfs/pull/1.patch

Greetings
Bernd

Am 28.09.2013 um 19:01 schrieb Gary Gregory <[hidden email]>:

> Hello Bernd,
>
> I am sorry for the delay in replying to you.
>
> The best input to any Commons project is to create a Jira and attach a
> patch in diff file format.
>
> As for our process, Github is fun but we only use it as a mirror and it
> just makes it harder to merge changes back in SVN. So I am not sure why we
> do that in the first place instead of switching the project to Git, but
> that's a different story.
>
> Gary
>
>
> On Wed, Sep 25, 2013 at 7:57 PM, Bernd Eckenfels <[hidden email]>wrote:
>
>> Hello,
>>
>> I rebased Pull#1 against trunk and made a fixup of the commits into one.
>>
>> https://github.com/apache/**commons-vfs/pull/1<https://github.com/apache/commons-vfs/pull/1>
>>
>> Do I need to file it on Jira?
>>
>> Greetings
>> Bernd
>>
>> Am 18.09.2013, 22:00 Uhr, schrieb Bernd Eckenfels <[hidden email]
>>> :
>>
>> all over the VFS core and providers there are many places where code is
>>> commented out. Most of the time it looks like it is old code, but sometimes
>>> it also looks like suggested new implementations or even TODO style of
>>> things.
>>>
>>> I started to remove some of the places, especially where it looks obvious
>>> to me that it is simply commented out code variantes of older versions.
>>> Also some other minor comment related stuff is in this pull request here:
>>>
>>> https://github.com/apache/**commons-vfs/pull/1<https://github.com/apache/commons-vfs/pull/1>
>>>
>>> Can you check out and see if you think I removed too much or not enough?
>>> I did not reviewed all files systematically it is more like the files I
>>> happen to look at anyway.
>>>
>>
>> ------------------------------**------------------------------**---------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.**apache.org<[hidden email]>
>> For additional commands, e-mail: [hidden email]
>>
>>
>
>
> --
> E-Mail: [hidden email] | [hidden email]
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VFS] code comment cleanups (GitHub Pull#1)

James Carman
Git patches work fine.  Just attach the file to a jira.

On Saturday, September 28, 2013, Bernd Eckenfels wrote:

> Hello,
>
> Thanks for the answer - i was hoping to get a confirmation that this
> change is actually wanted before I put more time in it. I will file a Jira
> for it.
>
> BTW: die you know you can add .patch to a Guthub Pull request to get a
> patch? I dont want to Mesa with SVN, so this is how I create the patches:
> https://github.com/apache/commons-vfs/pull/1.patch
>
> Greetings
> Bernd
>
> Am 28.09.2013 um 19:01 schrieb Gary Gregory <[hidden email]<javascript:;>
> >:
>
> > Hello Bernd,
> >
> > I am sorry for the delay in replying to you.
> >
> > The best input to any Commons project is to create a Jira and attach a
> > patch in diff file format.
> >
> > As for our process, Github is fun but we only use it as a mirror and it
> > just makes it harder to merge changes back in SVN. So I am not sure why
> we
> > do that in the first place instead of switching the project to Git, but
> > that's a different story.
> >
> > Gary
> >
> >
> > On Wed, Sep 25, 2013 at 7:57 PM, Bernd Eckenfels <[hidden email]<javascript:;>
> >wrote:
> >
> >> Hello,
> >>
> >> I rebased Pull#1 against trunk and made a fixup of the commits into one.
> >>
> >> https://github.com/apache/**commons-vfs/pull/1<
> https://github.com/apache/commons-vfs/pull/1>
> >>
> >> Do I need to file it on Jira?
> >>
> >> Greetings
> >> Bernd
> >>
> >> Am 18.09.2013, 22:00 Uhr, schrieb Bernd Eckenfels <
> [hidden email] <javascript:;>
> >>> :
> >>
> >> all over the VFS core and providers there are many places where code is
> >>> commented out. Most of the time it looks like it is old code, but
> sometimes
> >>> it also looks like suggested new implementations or even TODO style of
> >>> things.
> >>>
> >>> I started to remove some of the places, especially where it looks
> obvious
> >>> to me that it is simply commented out code variantes of older versions.
> >>> Also some other minor comment related stuff is in this pull request
> here:
> >>>
> >>> https://github.com/apache/**commons-vfs/pull/1<
> https://github.com/apache/commons-vfs/pull/1>
> >>>
> >>> Can you check out and see if you think I removed too much or not
> enough?
> >>> I did not reviewed all files systematically it is more like the files I
> >>> happen to look at anyway.
> >>>
> >>
> >>
> ------------------------------**------------------------------**---------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.**apache.org<
> [hidden email] <javascript:;>>
> >> For additional commands, e-mail: [hidden email]<javascript:;>
> >>
> >>
> >
> >
> > --
> > E-Mail: [hidden email] <javascript:;> | [hidden email]<javascript:;>
> > Java Persistence with Hibernate, Second Edition<
> http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email] <javascript:;>
> For additional commands, e-mail: [hidden email]<javascript:;>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VFS] code comment cleanups (GitHub Pull#1)

garydgregory
On Sat, Sep 28, 2013 at 1:41 PM, James Carman <[hidden email]>wrote:

> Git patches work fine.  Just attach the file to a jira.
>

Not really, if you add .diff to a GitHub URL, yes, you do get a diff file,
but it does not apply cleanly to an SVN check out project. This at least
because GitHub (or Git) adds a leading "a/" and "b/" to paths.

Gary



>
> On Saturday, September 28, 2013, Bernd Eckenfels wrote:
>
> > Hello,
> >
> > Thanks for the answer - i was hoping to get a confirmation that this
> > change is actually wanted before I put more time in it. I will file a
> Jira
> > for it.
> >
> > BTW: die you know you can add .patch to a Guthub Pull request to get a
> > patch? I dont want to Mesa with SVN, so this is how I create the patches:
> > https://github.com/apache/commons-vfs/pull/1.patch
> >
> > Greetings
> > Bernd
> >
> > Am 28.09.2013 um 19:01 schrieb Gary Gregory <[hidden email]
> <javascript:;>
> > >:
> >
> > > Hello Bernd,
> > >
> > > I am sorry for the delay in replying to you.
> > >
> > > The best input to any Commons project is to create a Jira and attach a
> > > patch in diff file format.
> > >
> > > As for our process, Github is fun but we only use it as a mirror and it
> > > just makes it harder to merge changes back in SVN. So I am not sure why
> > we
> > > do that in the first place instead of switching the project to Git, but
> > > that's a different story.
> > >
> > > Gary
> > >
> > >
> > > On Wed, Sep 25, 2013 at 7:57 PM, Bernd Eckenfels <
> [hidden email]<javascript:;>
> > >wrote:
> > >
> > >> Hello,
> > >>
> > >> I rebased Pull#1 against trunk and made a fixup of the commits into
> one.
> > >>
> > >> https://github.com/apache/**commons-vfs/pull/1<
> > https://github.com/apache/commons-vfs/pull/1>
> > >>
> > >> Do I need to file it on Jira?
> > >>
> > >> Greetings
> > >> Bernd
> > >>
> > >> Am 18.09.2013, 22:00 Uhr, schrieb Bernd Eckenfels <
> > [hidden email] <javascript:;>
> > >>> :
> > >>
> > >> all over the VFS core and providers there are many places where code
> is
> > >>> commented out. Most of the time it looks like it is old code, but
> > sometimes
> > >>> it also looks like suggested new implementations or even TODO style
> of
> > >>> things.
> > >>>
> > >>> I started to remove some of the places, especially where it looks
> > obvious
> > >>> to me that it is simply commented out code variantes of older
> versions.
> > >>> Also some other minor comment related stuff is in this pull request
> > here:
> > >>>
> > >>> https://github.com/apache/**commons-vfs/pull/1<
> > https://github.com/apache/commons-vfs/pull/1>
> > >>>
> > >>> Can you check out and see if you think I removed too much or not
> > enough?
> > >>> I did not reviewed all files systematically it is more like the
> files I
> > >>> happen to look at anyway.
> > >>>
> > >>
> > >>
> > ------------------------------**------------------------------**---------
> > >> To unsubscribe, e-mail: dev-unsubscribe@commons.**apache.org<
> > [hidden email] <javascript:;>>
> > >> For additional commands, e-mail: [hidden email]
> <javascript:;>
> > >>
> > >>
> > >
> > >
> > > --
> > > E-Mail: [hidden email] <javascript:;> | [hidden email]
> <javascript:;>
> > > Java Persistence with Hibernate, Second Edition<
> > http://www.manning.com/bauer3/>
> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > > Spring Batch in Action <http://www.manning.com/templier/>
> > > Blog: http://garygregory.wordpress.com
> > > Home: http://garygregory.com/
> > > Tweet! http://twitter.com/GaryGregory
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]<javascript:;>
> > For additional commands, e-mail: [hidden email]
> <javascript:;>
> >
> >
>



--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VFS] code comment cleanups (GitHub Pull#1)

garydgregory
On Sun, Sep 29, 2013 at 1:04 PM, Gary Gregory <[hidden email]>wrote:

> On Sat, Sep 28, 2013 at 1:41 PM, James Carman <[hidden email]>wrote:
>
>> Git patches work fine.  Just attach the file to a jira.
>>
>
> Not really, if you add .diff to a GitHub URL, yes, you do get a diff file,
> but it does not apply cleanly to an SVN check out project. This at least
> because GitHub (or Git) adds a leading "a/" and "b/" to paths.
>

I should have specified that Eclipse (4.3.1) with the latest Subclipse does
not apply the patch.

Gary


> Gary
>
>
>
>>
>> On Saturday, September 28, 2013, Bernd Eckenfels wrote:
>>
>> > Hello,
>> >
>> > Thanks for the answer - i was hoping to get a confirmation that this
>> > change is actually wanted before I put more time in it. I will file a
>> Jira
>> > for it.
>> >
>> > BTW: die you know you can add .patch to a Guthub Pull request to get a
>> > patch? I dont want to Mesa with SVN, so this is how I create the
>> patches:
>> > https://github.com/apache/commons-vfs/pull/1.patch
>> >
>> > Greetings
>> > Bernd
>> >
>> > Am 28.09.2013 um 19:01 schrieb Gary Gregory <[hidden email]
>> <javascript:;>
>> > >:
>> >
>> > > Hello Bernd,
>> > >
>> > > I am sorry for the delay in replying to you.
>> > >
>> > > The best input to any Commons project is to create a Jira and attach a
>> > > patch in diff file format.
>> > >
>> > > As for our process, Github is fun but we only use it as a mirror and
>> it
>> > > just makes it harder to merge changes back in SVN. So I am not sure
>> why
>> > we
>> > > do that in the first place instead of switching the project to Git,
>> but
>> > > that's a different story.
>> > >
>> > > Gary
>> > >
>> > >
>> > > On Wed, Sep 25, 2013 at 7:57 PM, Bernd Eckenfels <
>> [hidden email]<javascript:;>
>> > >wrote:
>> > >
>> > >> Hello,
>> > >>
>> > >> I rebased Pull#1 against trunk and made a fixup of the commits into
>> one.
>> > >>
>> > >> https://github.com/apache/**commons-vfs/pull/1<
>> > https://github.com/apache/commons-vfs/pull/1>
>> > >>
>> > >> Do I need to file it on Jira?
>> > >>
>> > >> Greetings
>> > >> Bernd
>> > >>
>> > >> Am 18.09.2013, 22:00 Uhr, schrieb Bernd Eckenfels <
>> > [hidden email] <javascript:;>
>> > >>> :
>> > >>
>> > >> all over the VFS core and providers there are many places where code
>> is
>> > >>> commented out. Most of the time it looks like it is old code, but
>> > sometimes
>> > >>> it also looks like suggested new implementations or even TODO style
>> of
>> > >>> things.
>> > >>>
>> > >>> I started to remove some of the places, especially where it looks
>> > obvious
>> > >>> to me that it is simply commented out code variantes of older
>> versions.
>> > >>> Also some other minor comment related stuff is in this pull request
>> > here:
>> > >>>
>> > >>> https://github.com/apache/**commons-vfs/pull/1<
>> > https://github.com/apache/commons-vfs/pull/1>
>> > >>>
>> > >>> Can you check out and see if you think I removed too much or not
>> > enough?
>> > >>> I did not reviewed all files systematically it is more like the
>> files I
>> > >>> happen to look at anyway.
>> > >>>
>> > >>
>> > >>
>> >
>> ------------------------------**------------------------------**---------
>> > >> To unsubscribe, e-mail: dev-unsubscribe@commons.**apache.org<
>> > [hidden email] <javascript:;>>
>> > >> For additional commands, e-mail: [hidden email]
>> <javascript:;>
>> > >>
>> > >>
>> > >
>> > >
>> > > --
>> > > E-Mail: [hidden email] <javascript:;> | [hidden email]
>> <javascript:;>
>> > > Java Persistence with Hibernate, Second Edition<
>> > http://www.manning.com/bauer3/>
>> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> > > Spring Batch in Action <http://www.manning.com/templier/>
>> > > Blog: http://garygregory.wordpress.com
>> > > Home: http://garygregory.com/
>> > > Tweet! http://twitter.com/GaryGregory
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: [hidden email]<javascript:;>
>> > For additional commands, e-mail: [hidden email]
>> <javascript:;>
>> >
>> >
>>
>
>
>
> --
> E-Mail: [hidden email] | [hidden email]
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VFS] code comment cleanups (GitHub Pull#1)

James Carman
I think you need to use the -no-prefix option to get it to work.  I was
mistaken.

On Sunday, September 29, 2013, Gary Gregory wrote:

> On Sun, Sep 29, 2013 at 1:04 PM, Gary Gregory <[hidden email]<javascript:;>
> >wrote:
>
> > On Sat, Sep 28, 2013 at 1:41 PM, James Carman <
> [hidden email] <javascript:;>>wrote:
> >
> >> Git patches work fine.  Just attach the file to a jira.
> >>
> >
> > Not really, if you add .diff to a GitHub URL, yes, you do get a diff
> file,
> > but it does not apply cleanly to an SVN check out project. This at least
> > because GitHub (or Git) adds a leading "a/" and "b/" to paths.
> >
>
> I should have specified that Eclipse (4.3.1) with the latest Subclipse does
> not apply the patch.
>
> Gary
>
>
> > Gary
> >
> >
> >
> >>
> >> On Saturday, September 28, 2013, Bernd Eckenfels wrote:
> >>
> >> > Hello,
> >> >
> >> > Thanks for the answer - i was hoping to get a confirmation that this
> >> > change is actually wanted before I put more time in it. I will file a
> >> Jira
> >> > for it.
> >> >
> >> > BTW: die you know you can add .patch to a Guthub Pull request to get a
> >> > patch? I dont want to Mesa with SVN, so this is how I create the
> >> patches:
> >> > https://github.com/apache/commons-vfs/pull/1.patch
> >> >
> >> > Greetings
> >> > Bernd
> >> >
> >> > Am 28.09.2013 um 19:01 schrieb Gary Gregory <[hidden email]
> >> <javascript:;>
> >> > >:
> >> >
> >> > > Hello Bernd,
> >> > >
> >> > > I am sorry for the delay in replying to you.
> >> > >
> >> > > The best input to any Commons project is to create a Jira and
> attach a
> >> > > patch in diff file format.
> >> > >
> >> > > As for our process, Github is fun but we only use it as a mirror and
> >> it
> >> > > just makes it harder to merge changes back in SVN. So I am not sure
> >> why
> >> > we
> >> > > do that in the first place instead of switching the project to Git,
> >> but
> >> > > that's a different story.
> >> > >
> >> > > Gary
> >> > >
> >> > >
> >> > > On Wed, Sep 25, 2013 at 7:57 PM, Bernd Eckenfels <
> >> [hidden email]<javascript:;>
> >> > >wrote:
> >> > >
> >> > >> Hello,
> >> > >>
> >> > >> I rebased Pull#1 against trunk and made a fixup of the commits into
> >> one.
> >> > >>
> >> > >> https://github.com/apache/**commons-vfs/pull/1<
> >> > https://github.com/apache/commons-vfs/pull/1>
> >> > >>
> >> > >> Do I need to file it on Jira?
> >> > >>
> >> > >> Greetings
> >> > >> Bernd
> >> > >>
> >> > >> Am 18.09.2013, 22:00 Uhr, schrieb Bernd Eckenfels <
> >> > [hidden email] <javascript:;>
> >> > >>> :
> >> > >>
> >> > >> all over the VFS core and providers there are many places where
> code
> >> is
> >> > >>> commented out. Most of the time it looks like it is old code, but
> >> > sometimes
> >> > >>> it also looks like suggested new implementations or even TODO
> style
> >> of
> >> > >>> things.
> >> > >>>
> >> > >>> I started to remove some of the places, especially where it looks
> >> > obvious
> >> > >>> to me that it is simply commented out code variantes of older
> >> versions.
> >> > >>> Also some other minor comment related stuff is in this pull
> request
> >> > here:
> >> > >>>
> >> > >>> https://github.com/apache/**commons-vfs/pull/1<
> >> > https://github.com/apache/commons-vfs/pull/1>
> >> > >>>
> >> > >>> Can you check out and see if you think I removed too much or not
> >> > enough?
> >> > >>> I did not reviewed all files systematically it is more like the
> >> files I
> >> > >>> happen to look at anyway.
> >> > >>>
> >> > >>
> >> > >>
> >> >
> >>
> ------------------------------**------------------------------**---------
> >> > >> To unsubscribe, e-mail: dev-unsubscribe@commons.**<http://apache.org>
Reply | Threaded
Open this post in threaded view
|

Re: [VFS] code comment cleanups (GitHub Pull#1)

Olivier Lamy
In reply to this post by garydgregory
Use: patch -p1 < patch.file

--
Olivier
On Sep 30, 2013 3:04 AM, "Gary Gregory" <[hidden email]> wrote:

> On Sat, Sep 28, 2013 at 1:41 PM, James Carman <[hidden email]
> >wrote:
>
> > Git patches work fine.  Just attach the file to a jira.
> >
>
> Not really, if you add .diff to a GitHub URL, yes, you do get a diff file,
> but it does not apply cleanly to an SVN check out project. This at least
> because GitHub (or Git) adds a leading "a/" and "b/" to paths.
>
> Gary
>
>
>
> >
> > On Saturday, September 28, 2013, Bernd Eckenfels wrote:
> >
> > > Hello,
> > >
> > > Thanks for the answer - i was hoping to get a confirmation that this
> > > change is actually wanted before I put more time in it. I will file a
> > Jira
> > > for it.
> > >
> > > BTW: die you know you can add .patch to a Guthub Pull request to get a
> > > patch? I dont want to Mesa with SVN, so this is how I create the
> patches:
> > > https://github.com/apache/commons-vfs/pull/1.patch
> > >
> > > Greetings
> > > Bernd
> > >
> > > Am 28.09.2013 um 19:01 schrieb Gary Gregory <[hidden email]
> > <javascript:;>
> > > >:
> > >
> > > > Hello Bernd,
> > > >
> > > > I am sorry for the delay in replying to you.
> > > >
> > > > The best input to any Commons project is to create a Jira and attach
> a
> > > > patch in diff file format.
> > > >
> > > > As for our process, Github is fun but we only use it as a mirror and
> it
> > > > just makes it harder to merge changes back in SVN. So I am not sure
> why
> > > we
> > > > do that in the first place instead of switching the project to Git,
> but
> > > > that's a different story.
> > > >
> > > > Gary
> > > >
> > > >
> > > > On Wed, Sep 25, 2013 at 7:57 PM, Bernd Eckenfels <
> > [hidden email]<javascript:;>
> > > >wrote:
> > > >
> > > >> Hello,
> > > >>
> > > >> I rebased Pull#1 against trunk and made a fixup of the commits into
> > one.
> > > >>
> > > >> https://github.com/apache/**commons-vfs/pull/1<
> > > https://github.com/apache/commons-vfs/pull/1>
> > > >>
> > > >> Do I need to file it on Jira?
> > > >>
> > > >> Greetings
> > > >> Bernd
> > > >>
> > > >> Am 18.09.2013, 22:00 Uhr, schrieb Bernd Eckenfels <
> > > [hidden email] <javascript:;>
> > > >>> :
> > > >>
> > > >> all over the VFS core and providers there are many places where code
> > is
> > > >>> commented out. Most of the time it looks like it is old code, but
> > > sometimes
> > > >>> it also looks like suggested new implementations or even TODO style
> > of
> > > >>> things.
> > > >>>
> > > >>> I started to remove some of the places, especially where it looks
> > > obvious
> > > >>> to me that it is simply commented out code variantes of older
> > versions.
> > > >>> Also some other minor comment related stuff is in this pull request
> > > here:
> > > >>>
> > > >>> https://github.com/apache/**commons-vfs/pull/1<
> > > https://github.com/apache/commons-vfs/pull/1>
> > > >>>
> > > >>> Can you check out and see if you think I removed too much or not
> > > enough?
> > > >>> I did not reviewed all files systematically it is more like the
> > files I
> > > >>> happen to look at anyway.
> > > >>>
> > > >>
> > > >>
> > >
> ------------------------------**------------------------------**---------
> > > >> To unsubscribe, e-mail: dev-unsubscribe@commons.**apache.org<
> > > [hidden email] <javascript:;>>
> > > >> For additional commands, e-mail: [hidden email]
> > <javascript:;>
> > > >>
> > > >>
> > > >
> > > >
> > > > --
> > > > E-Mail: [hidden email] <javascript:;> | [hidden email]
> > <javascript:;>
> > > > Java Persistence with Hibernate, Second Edition<
> > > http://www.manning.com/bauer3/>
> > > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > > > Spring Batch in Action <http://www.manning.com/templier/>
> > > > Blog: http://garygregory.wordpress.com
> > > > Home: http://garygregory.com/
> > > > Tweet! http://twitter.com/GaryGregory
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [hidden email]
> <javascript:;>
> > > For additional commands, e-mail: [hidden email]
> > <javascript:;>
> > >
> > >
> >
>
>
>
> --
> E-Mail: [hidden email] | [hidden email]
> Java Persistence with Hibernate, Second Edition<
> http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>