[VOTE][RC1] Commons collections 4.3

classic Classic list List threaded Threaded
18 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE][RC1] Commons collections 4.3

Maxim Solodovnik-2
commons-collections4-4.3-src.zip.sha256This is a [VOTE] for releasing
Apache Commons collections 4.3

Tag name:
collections-4.3-RC1 (signature can be checked from git using 'git tag -v')

Tag URL:
    https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4d1e1fff27167f803

Commit ID the tag points at:
    5f959fd8e77bf28f6286cfb4d1e1fff27167f803

Site:
    https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/index.html

Distribution files (committed at revision 31605):
    https://dist.apache.org/repos/dist/dev/commons/collections/

Distribution files hashes (SHA256):
    201e1d527c67643b4e75065e113006d0610e8bf5620b4e056a2e044f3676df12
commons-collections4-4.3-bin.tar.gz
    706a0f5b4ddfd85e5444933576ea37776219748973bf4fc3944d846823f79395
commons-collections4-4.3-bin.zip
    7a18a39b8b24d8688400276388d5c63da448ee7a8166561a5cffb617b952ed96
commons-collections4-4.3-src.tar.gz
    8a7b3ccd3fb2ba7edde7e08aa7606b3eacef260eab887358c56473a9e395067a
commons-collections4-4.3-src.zip

KEYS file to check signatures:
    https://www.apache.org/dist/commons/KEYS

Maven artifacts:
    https://repository.apache.org/content/repositories/orgapachecommons-1401/

Please select one of the following options:
  [ ] +1 Release it.
  [ ] +0 Go ahead; I don't care.
  [ ] -0 There are a few minor glitches: ...
  [ ] -1 No, do not release it because ...

This vote will be open for at least 72 hours, i.e. until 2018-12-22T14:00:00Z
(this is UTC time).

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC1] Commons collections 4.3

Gilles Sadowski
Hi.

Congratulations for getting that far in a fairly short time. ;-)

The BC report (Clirr) notes several incompatible changes:
   
https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/clirr-report.html
[No idea whether that was expected.  If so, perhaps there should be
a remark in the release notes?]

In the site, the link to the release note is dead:
   
https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/release_4_3.html
[File must be copied manually (?). It does not seem to be at same place
in "Collections" and in "RNG"!]

On Wed, 19 Dec 2018 20:41:15 +0700, Maxim Solodovnik wrote:
> This is a [VOTE] for releasing
> Apache Commons collections 4.3
>
> Tag name:
> collections-4.3-RC1 (signature can be checked from git using 'git tag
> -v')

OK.

> Tag URL:
>
>
> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4d1e1fff27167f803
>
> Commit ID the tag points at:
>     5f959fd8e77bf28f6286cfb4d1e1fff27167f803

OK.

>
> Site:
>
>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/index.html

Download page will be wrong (cf. other thread with subject "Fixing
the download page).

>
> Distribution files (committed at revision 31605):
>     https://dist.apache.org/repos/dist/dev/commons/collections/
>
> Distribution files hashes (SHA256):
>     201e1d527c67643b4e75065e113006d0610e8bf5620b4e056a2e044f3676df12
> commons-collections4-4.3-bin.tar.gz

OK.

>     706a0f5b4ddfd85e5444933576ea37776219748973bf4fc3944d846823f79395
> commons-collections4-4.3-bin.zip
>     7a18a39b8b24d8688400276388d5c63da448ee7a8166561a5cffb617b952ed96
> commons-collections4-4.3-src.tar.gz

OK.

>     8a7b3ccd3fb2ba7edde7e08aa7606b3eacef260eab887358c56473a9e395067a
> commons-collections4-4.3-src.zip
>
> KEYS file to check signatures:
>     https://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
>    
> https://repository.apache.org/content/repositories/orgapachecommons-1401/
>
> Please select one of the following options:
>   [ ] +1 Release it.
>   [ ] +0 Go ahead; I don't care.
>   [ ] -0 There are a few minor glitches: ...
>   [ ] -1 No, do not release it because ...
>
> This vote will be open for at least 72 hours, i.e. until
> 2018-12-22T14:00:00Z
> (this is UTC time).
>

Regards,
Gilles


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC1] Commons collections 4.3

Maxim Solodovnik
Thanks for checking Gilles,

Regarding clirr errors instruction states [1] to check errors only for
minor release
Since it is 4.3.0 and not 4.2.1 I thought it is OK ..
How this should be properly addressed?

release_4_3.html was not genarated during build :( How can I generate it?

Is it possible to perform site re-generation and maybe manual update
of apache-dev?

I will be OOO Thu-Sun, so will resolve all issues on return

[1] https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=blob;f=doc/release/release.howto.txt#l73

On Wed, 19 Dec 2018 at 21:59, Gilles <[hidden email]> wrote:

>
> Hi.
>
> Congratulations for getting that far in a fairly short time. ;-)
>
> The BC report (Clirr) notes several incompatible changes:
>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/clirr-report.html
> [No idea whether that was expected.  If so, perhaps there should be
> a remark in the release notes?]
>
> In the site, the link to the release note is dead:
>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/release_4_3.html
> [File must be copied manually (?). It does not seem to be at same place
> in "Collections" and in "RNG"!]
>
> On Wed, 19 Dec 2018 20:41:15 +0700, Maxim Solodovnik wrote:
> > This is a [VOTE] for releasing
> > Apache Commons collections 4.3
> >
> > Tag name:
> > collections-4.3-RC1 (signature can be checked from git using 'git tag
> > -v')
>
> OK.
>
> > Tag URL:
> >
> >
> > https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4d1e1fff27167f803
> >
> > Commit ID the tag points at:
> >     5f959fd8e77bf28f6286cfb4d1e1fff27167f803
>
> OK.
>
> >
> > Site:
> >
> >
> > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/index.html
>
> Download page will be wrong (cf. other thread with subject "Fixing
> the download page).
>
> >
> > Distribution files (committed at revision 31605):
> >     https://dist.apache.org/repos/dist/dev/commons/collections/
> >
> > Distribution files hashes (SHA256):
> >     201e1d527c67643b4e75065e113006d0610e8bf5620b4e056a2e044f3676df12
> > commons-collections4-4.3-bin.tar.gz
>
> OK.
>
> >     706a0f5b4ddfd85e5444933576ea37776219748973bf4fc3944d846823f79395
> > commons-collections4-4.3-bin.zip
> >     7a18a39b8b24d8688400276388d5c63da448ee7a8166561a5cffb617b952ed96
> > commons-collections4-4.3-src.tar.gz
>
> OK.
>
> >     8a7b3ccd3fb2ba7edde7e08aa7606b3eacef260eab887358c56473a9e395067a
> > commons-collections4-4.3-src.zip
> >
> > KEYS file to check signatures:
> >     https://www.apache.org/dist/commons/KEYS
> >
> > Maven artifacts:
> >
> > https://repository.apache.org/content/repositories/orgapachecommons-1401/
> >
> > Please select one of the following options:
> >   [ ] +1 Release it.
> >   [ ] +0 Go ahead; I don't care.
> >   [ ] -0 There are a few minor glitches: ...
> >   [ ] -1 No, do not release it because ...
> >
> > This vote will be open for at least 72 hours, i.e. until
> > 2018-12-22T14:00:00Z
> > (this is UTC time).
> >
>
> Regards,
> Gilles
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


--
WBR
Maxim aka solomax

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC1] Commons collections 4.3

Gilles Sadowski
On Wed, 19 Dec 2018 23:08:44 +0700, Maxim Solodovnik wrote:
> Thanks for checking Gilles,
>
> Regarding clirr errors instruction states [1] to check errors only
> for
> minor release
> Since it is 4.3.0 and not 4.2.1 I thought it is OK ..

4.X is a minor release ("Y.0" is a major one).

Usually (with no other explanation), this would be a blocker.
There was a change of supported platform (Java 7 -> 8)...


> How this should be properly addressed?
>
> release_4_3.html was not genarated during build :( How can I generate
> it?

No, indeed.
It comes from a copy of the "RELEASE-NOTES.txt" that's at the
top-level.

But this is not blocker (site can be updated at any time).

Regards,
Gilles

>
> Is it possible to perform site re-generation and maybe manual update
> of apache-dev?
>
> I will be OOO Thu-Sun, so will resolve all issues on return
>
> [1]
>
> https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=blob;f=doc/release/release.howto.txt#l73
>
> On Wed, 19 Dec 2018 at 21:59, Gilles <[hidden email]>
> wrote:
>>
>> Hi.
>>
>> Congratulations for getting that far in a fairly short time. ;-)
>>
>> The BC report (Clirr) notes several incompatible changes:
>>
>>
>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/clirr-report.html
>> [No idea whether that was expected.  If so, perhaps there should be
>> a remark in the release notes?]
>>
>> In the site, the link to the release note is dead:
>>
>>
>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/release_4_3.html
>> [File must be copied manually (?). It does not seem to be at same
>> place
>> in "Collections" and in "RNG"!]
>>
>> On Wed, 19 Dec 2018 20:41:15 +0700, Maxim Solodovnik wrote:
>> > This is a [VOTE] for releasing
>> > Apache Commons collections 4.3
>> >
>> > Tag name:
>> > collections-4.3-RC1 (signature can be checked from git using 'git
>> tag
>> > -v')
>>
>> OK.
>>
>> > Tag URL:
>> >
>> >
>> >
>> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4d1e1fff27167f803
>> >
>> > Commit ID the tag points at:
>> >     5f959fd8e77bf28f6286cfb4d1e1fff27167f803
>>
>> OK.
>>
>> >
>> > Site:
>> >
>> >
>> >
>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/index.html
>>
>> Download page will be wrong (cf. other thread with subject "Fixing
>> the download page).
>>
>> >
>> > Distribution files (committed at revision 31605):
>> >     https://dist.apache.org/repos/dist/dev/commons/collections/
>> >
>> > Distribution files hashes (SHA256):
>> >    
>> 201e1d527c67643b4e75065e113006d0610e8bf5620b4e056a2e044f3676df12
>> > commons-collections4-4.3-bin.tar.gz
>>
>> OK.
>>
>> >    
>> 706a0f5b4ddfd85e5444933576ea37776219748973bf4fc3944d846823f79395
>> > commons-collections4-4.3-bin.zip
>> >    
>> 7a18a39b8b24d8688400276388d5c63da448ee7a8166561a5cffb617b952ed96
>> > commons-collections4-4.3-src.tar.gz
>>
>> OK.
>>
>> >    
>> 8a7b3ccd3fb2ba7edde7e08aa7606b3eacef260eab887358c56473a9e395067a
>> > commons-collections4-4.3-src.zip
>> >
>> > KEYS file to check signatures:
>> >     https://www.apache.org/dist/commons/KEYS
>> >
>> > Maven artifacts:
>> >
>> >
>> https://repository.apache.org/content/repositories/orgapachecommons-1401/
>> >
>> > Please select one of the following options:
>> >   [ ] +1 Release it.
>> >   [ ] +0 Go ahead; I don't care.
>> >   [ ] -0 There are a few minor glitches: ...
>> >   [ ] -1 No, do not release it because ...
>> >
>> > This vote will be open for at least 72 hours, i.e. until
>> > 2018-12-22T14:00:00Z
>> > (this is UTC time).
>> >
>>
>> Regards,
>> Gilles
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC1] Commons collections 4.3

sebb-2-2
In reply to this post by Maxim Solodovnik
On Wed, 19 Dec 2018 at 16:09, Maxim Solodovnik <[hidden email]> wrote:
>
> Thanks for checking Gilles,
>
> Regarding clirr errors instruction states [1] to check errors only for
> minor release

That is not the understanding I have of how to handle Clirr errors,
nor does the doc [1] actually say that.
The cited doc [1] does not detail the process for major releases.

A major release can be binary incompatible, but in that case a new
package name and Maven coords are needed so the old and new versions
can co-exist.

Errors reported by Clirr can never be ignored.

> Since it is 4.3.0 and not 4.2.1 I thought it is OK ..
> How this should be properly addressed?

In all cases, errors must be examined.
The Clirr plugin does not distinguish binary and source compatibility
issues, so it's not always obvious what to do.

In this case, additions to interfaces are binary compatible - i.e.
don't create problems at run-time - however source changes may be
required if a 3rd party source implements the interface.

Is it possible to avoid these by using default implementations?
Are the interfaces part of the external API?

Any Clirr errors should be noted in the Release Notes, with
information on how they affect the user.

> release_4_3.html was not genarated during build :( How can I generate it?
>
> Is it possible to perform site re-generation and maybe manual update
> of apache-dev?
>
> I will be OOO Thu-Sun, so will resolve all issues on return
>
> [1] https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=blob;f=doc/release/release.howto.txt#l73
>
> On Wed, 19 Dec 2018 at 21:59, Gilles <[hidden email]> wrote:
> >
> > Hi.
> >
> > Congratulations for getting that far in a fairly short time. ;-)
> >
> > The BC report (Clirr) notes several incompatible changes:
> >
> > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/clirr-report.html
> > [No idea whether that was expected.  If so, perhaps there should be
> > a remark in the release notes?]
> >
> > In the site, the link to the release note is dead:
> >
> > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/release_4_3.html
> > [File must be copied manually (?). It does not seem to be at same place
> > in "Collections" and in "RNG"!]
> >
> > On Wed, 19 Dec 2018 20:41:15 +0700, Maxim Solodovnik wrote:
> > > This is a [VOTE] for releasing
> > > Apache Commons collections 4.3
> > >
> > > Tag name:
> > > collections-4.3-RC1 (signature can be checked from git using 'git tag
> > > -v')
> >
> > OK.
> >
> > > Tag URL:
> > >
> > >
> > > https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4d1e1fff27167f803
> > >
> > > Commit ID the tag points at:
> > >     5f959fd8e77bf28f6286cfb4d1e1fff27167f803
> >
> > OK.
> >
> > >
> > > Site:
> > >
> > >
> > > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/index.html
> >
> > Download page will be wrong (cf. other thread with subject "Fixing
> > the download page).
> >
> > >
> > > Distribution files (committed at revision 31605):
> > >     https://dist.apache.org/repos/dist/dev/commons/collections/
> > >
> > > Distribution files hashes (SHA256):
> > >     201e1d527c67643b4e75065e113006d0610e8bf5620b4e056a2e044f3676df12
> > > commons-collections4-4.3-bin.tar.gz
> >
> > OK.
> >
> > >     706a0f5b4ddfd85e5444933576ea37776219748973bf4fc3944d846823f79395
> > > commons-collections4-4.3-bin.zip
> > >     7a18a39b8b24d8688400276388d5c63da448ee7a8166561a5cffb617b952ed96
> > > commons-collections4-4.3-src.tar.gz
> >
> > OK.
> >
> > >     8a7b3ccd3fb2ba7edde7e08aa7606b3eacef260eab887358c56473a9e395067a
> > > commons-collections4-4.3-src.zip
> > >
> > > KEYS file to check signatures:
> > >     https://www.apache.org/dist/commons/KEYS
> > >
> > > Maven artifacts:
> > >
> > > https://repository.apache.org/content/repositories/orgapachecommons-1401/
> > >
> > > Please select one of the following options:
> > >   [ ] +1 Release it.
> > >   [ ] +0 Go ahead; I don't care.
> > >   [ ] -0 There are a few minor glitches: ...
> > >   [ ] -1 No, do not release it because ...
> > >
> > > This vote will be open for at least 72 hours, i.e. until
> > > 2018-12-22T14:00:00Z
> > > (this is UTC time).
> > >
> >
> > Regards,
> > Gilles
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
>
> --
> WBR
> Maxim aka solomax
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC1] Commons collections 4.3

Maxim Solodovnik
My bad,

Here is the analysis (please correct me if I'm wrong)
Errors:
1) `org.apache.commons.collections4.BidiMap:: Method 'public
java.util.Collection values()' has been added to an interface`
2) `org.apache.commons.collections4.ListValuedMap:: Method 'public
java.util.Collection get(java.lang.Object)' has been added to an
interface`
3) `org.apache.commons.collections4.ListValuedMap:: Method 'public
java.util.Collection remove(java.lang.Object)' has been added to an
interface`
4) `org.apache.commons.collections4.OrderedBidiMap:: Method 'public
org.apache.commons.collections4.BidiMap inverseBidiMap()' has been
added to an interface`
5) `org.apache.commons.collections4.OrderedMap:: Method 'public
org.apache.commons.collections4.MapIterator mapIterator()' has been
added to an interface`
6) `org.apache.commons.collections4.SetValuedMap:: Method 'public
java.util.Collection get(java.lang.Object)' has been added to an
interface`
7) `org.apache.commons.collections4.SetValuedMap:: Method 'public
java.util.Collection remove(java.lang.Object)' has been added to an
interface`
8) `org.apache.commons.collections4.SortedBidiMap:: Method 'public
org.apache.commons.collections4.OrderedBidiMap inverseBidiMap()' has
been added to an interface`
9) `org.apache.commons.collections4.SortedBidiMap:: Method 'public
org.apache.commons.collections4.BidiMap inverseBidiMap()' has been
added to an interface`
    these errors are weird. Above classes has no changes comparing to 4.2 [1]

Infos:
1) `org.apache.commons.collections4.SetUtils:: Method 'public
java.util.HashSet hashSet(java.lang.Object[])' has been added`
2) `org.apache.commons.collections4.SetUtils:: Method 'public
java.util.Set unmodifiableSet(java.lang.Object[])' has been added`
    both methods are public static and implemented, should cause no issues
3) - 6) `org.apache.commons.collections4.map.AbstractReferenceMap`
    methods with implementations were added to class, and
accessibility has been increased

I see no issues need to be noted

[1] https://github.com/apache/commons-collections/compare/commons-collections-4.2-RC1...collections-4.3-RC1

On Thu, 20 Dec 2018 at 00:29, sebb <[hidden email]> wrote:

>
> On Wed, 19 Dec 2018 at 16:09, Maxim Solodovnik <[hidden email]> wrote:
> >
> > Thanks for checking Gilles,
> >
> > Regarding clirr errors instruction states [1] to check errors only for
> > minor release
>
> That is not the understanding I have of how to handle Clirr errors,
> nor does the doc [1] actually say that.
> The cited doc [1] does not detail the process for major releases.
>
> A major release can be binary incompatible, but in that case a new
> package name and Maven coords are needed so the old and new versions
> can co-exist.
>
> Errors reported by Clirr can never be ignored.
>
> > Since it is 4.3.0 and not 4.2.1 I thought it is OK ..
> > How this should be properly addressed?
>
> In all cases, errors must be examined.
> The Clirr plugin does not distinguish binary and source compatibility
> issues, so it's not always obvious what to do.
>
> In this case, additions to interfaces are binary compatible - i.e.
> don't create problems at run-time - however source changes may be
> required if a 3rd party source implements the interface.
>
> Is it possible to avoid these by using default implementations?
> Are the interfaces part of the external API?
>
> Any Clirr errors should be noted in the Release Notes, with
> information on how they affect the user.
>
> > release_4_3.html was not genarated during build :( How can I generate it?
> >
> > Is it possible to perform site re-generation and maybe manual update
> > of apache-dev?
> >
> > I will be OOO Thu-Sun, so will resolve all issues on return
> >
> > [1] https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=blob;f=doc/release/release.howto.txt#l73
> >
> > On Wed, 19 Dec 2018 at 21:59, Gilles <[hidden email]> wrote:
> > >
> > > Hi.
> > >
> > > Congratulations for getting that far in a fairly short time. ;-)
> > >
> > > The BC report (Clirr) notes several incompatible changes:
> > >
> > > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/clirr-report.html
> > > [No idea whether that was expected.  If so, perhaps there should be
> > > a remark in the release notes?]
> > >
> > > In the site, the link to the release note is dead:
> > >
> > > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/release_4_3.html
> > > [File must be copied manually (?). It does not seem to be at same place
> > > in "Collections" and in "RNG"!]
> > >
> > > On Wed, 19 Dec 2018 20:41:15 +0700, Maxim Solodovnik wrote:
> > > > This is a [VOTE] for releasing
> > > > Apache Commons collections 4.3
> > > >
> > > > Tag name:
> > > > collections-4.3-RC1 (signature can be checked from git using 'git tag
> > > > -v')
> > >
> > > OK.
> > >
> > > > Tag URL:
> > > >
> > > >
> > > > https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4d1e1fff27167f803
> > > >
> > > > Commit ID the tag points at:
> > > >     5f959fd8e77bf28f6286cfb4d1e1fff27167f803
> > >
> > > OK.
> > >
> > > >
> > > > Site:
> > > >
> > > >
> > > > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/index.html
> > >
> > > Download page will be wrong (cf. other thread with subject "Fixing
> > > the download page).
> > >
> > > >
> > > > Distribution files (committed at revision 31605):
> > > >     https://dist.apache.org/repos/dist/dev/commons/collections/
> > > >
> > > > Distribution files hashes (SHA256):
> > > >     201e1d527c67643b4e75065e113006d0610e8bf5620b4e056a2e044f3676df12
> > > > commons-collections4-4.3-bin.tar.gz
> > >
> > > OK.
> > >
> > > >     706a0f5b4ddfd85e5444933576ea37776219748973bf4fc3944d846823f79395
> > > > commons-collections4-4.3-bin.zip
> > > >     7a18a39b8b24d8688400276388d5c63da448ee7a8166561a5cffb617b952ed96
> > > > commons-collections4-4.3-src.tar.gz
> > >
> > > OK.
> > >
> > > >     8a7b3ccd3fb2ba7edde7e08aa7606b3eacef260eab887358c56473a9e395067a
> > > > commons-collections4-4.3-src.zip
> > > >
> > > > KEYS file to check signatures:
> > > >     https://www.apache.org/dist/commons/KEYS
> > > >
> > > > Maven artifacts:
> > > >
> > > > https://repository.apache.org/content/repositories/orgapachecommons-1401/
> > > >
> > > > Please select one of the following options:
> > > >   [ ] +1 Release it.
> > > >   [ ] +0 Go ahead; I don't care.
> > > >   [ ] -0 There are a few minor glitches: ...
> > > >   [ ] -1 No, do not release it because ...
> > > >
> > > > This vote will be open for at least 72 hours, i.e. until
> > > > 2018-12-22T14:00:00Z
> > > > (this is UTC time).
> > > >
> > >
> > > Regards,
> > > Gilles
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [hidden email]
> > > For additional commands, e-mail: [hidden email]
> > >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


--
WBR
Maxim aka solomax

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC1] Commons collections 4.3

Gilles Sadowski
On Thu, 20 Dec 2018 10:46:46 +0700, Maxim Solodovnik wrote:
> My bad,
>
> Here is the analysis (please correct me if I'm wrong)
> Errors:
> [...]
>     these errors are weird. Above classes has no changes comparing to
> 4.2 [1]

It might the same problem which I've encountered a few eeks ago:
Try to delete your local maven cache (i.e. all the subdirectories
of "~/.m2" that refer to "collections").

HTH,
Gilles

>
> [...]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC1] Commons collections 4.3

garydgregory
In reply to this post by Maxim Solodovnik-2
Hi all, I am unable to review for at least 3 or 4 days. I am on the road
and my laptop just died...

Gary

On Wed, Dec 19, 2018, 08:41 Maxim Solodovnik <[hidden email] wrote:

> commons-collections4-4.3-src.zip.sha256This is a [VOTE] for releasing
> Apache Commons collections 4.3
>
> Tag name:
> collections-4.3-RC1 (signature can be checked from git using 'git tag -v')
>
> Tag URL:
>
> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4d1e1fff27167f803
>
> Commit ID the tag points at:
>     5f959fd8e77bf28f6286cfb4d1e1fff27167f803
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/index.html
>
> Distribution files (committed at revision 31605):
>     https://dist.apache.org/repos/dist/dev/commons/collections/
>
> Distribution files hashes (SHA256):
>     201e1d527c67643b4e75065e113006d0610e8bf5620b4e056a2e044f3676df12
> commons-collections4-4.3-bin.tar.gz
>     706a0f5b4ddfd85e5444933576ea37776219748973bf4fc3944d846823f79395
> commons-collections4-4.3-bin.zip
>     7a18a39b8b24d8688400276388d5c63da448ee7a8166561a5cffb617b952ed96
> commons-collections4-4.3-src.tar.gz
>     8a7b3ccd3fb2ba7edde7e08aa7606b3eacef260eab887358c56473a9e395067a
> commons-collections4-4.3-src.zip
>
> KEYS file to check signatures:
>     https://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1401/
>
> Please select one of the following options:
>   [ ] +1 Release it.
>   [ ] +0 Go ahead; I don't care.
>   [ ] -0 There are a few minor glitches: ...
>   [ ] -1 No, do not release it because ...
>
> This vote will be open for at least 72 hours, i.e. until
> 2018-12-22T14:00:00Z
> (this is UTC time).
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC1] Commons collections 4.3

Maxim Solodovnik
Hello All,

I'm back :)
Shall I try to regenerate clirr report? and upload release_4_3.html?

According to download page: it seems `mvn
org.apache.commons:commons-build-plugin:1.10-SNAPSHOT:download-page`
does nothing for me
Shall I manually update download page? What need to be updated?


On Fri, 21 Dec 2018 at 01:17, Gary Gregory <[hidden email]> wrote:

>
> Hi all, I am unable to review for at least 3 or 4 days. I am on the road
> and my laptop just died...
>
> Gary
>
> On Wed, Dec 19, 2018, 08:41 Maxim Solodovnik <[hidden email] wrote:
>
> > commons-collections4-4.3-src.zip.sha256This is a [VOTE] for releasing
> > Apache Commons collections 4.3
> >
> > Tag name:
> > collections-4.3-RC1 (signature can be checked from git using 'git tag -v')
> >
> > Tag URL:
> >
> > https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4d1e1fff27167f803
> >
> > Commit ID the tag points at:
> >     5f959fd8e77bf28f6286cfb4d1e1fff27167f803
> >
> > Site:
> >
> > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/index.html
> >
> > Distribution files (committed at revision 31605):
> >     https://dist.apache.org/repos/dist/dev/commons/collections/
> >
> > Distribution files hashes (SHA256):
> >     201e1d527c67643b4e75065e113006d0610e8bf5620b4e056a2e044f3676df12
> > commons-collections4-4.3-bin.tar.gz
> >     706a0f5b4ddfd85e5444933576ea37776219748973bf4fc3944d846823f79395
> > commons-collections4-4.3-bin.zip
> >     7a18a39b8b24d8688400276388d5c63da448ee7a8166561a5cffb617b952ed96
> > commons-collections4-4.3-src.tar.gz
> >     8a7b3ccd3fb2ba7edde7e08aa7606b3eacef260eab887358c56473a9e395067a
> > commons-collections4-4.3-src.zip
> >
> > KEYS file to check signatures:
> >     https://www.apache.org/dist/commons/KEYS
> >
> > Maven artifacts:
> >
> > https://repository.apache.org/content/repositories/orgapachecommons-1401/
> >
> > Please select one of the following options:
> >   [ ] +1 Release it.
> >   [ ] +0 Go ahead; I don't care.
> >   [ ] -0 There are a few minor glitches: ...
> >   [ ] -1 No, do not release it because ...
> >
> > This vote will be open for at least 72 hours, i.e. until
> > 2018-12-22T14:00:00Z
> > (this is UTC time).
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >



--
WBR
Maxim aka solomax

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC1] Commons collections 4.3

Gilles Sadowski
On Mon, 24 Dec 2018 22:11:11 +0700, Maxim Solodovnik wrote:
> Hello All,
>
> I'm back :)
> Shall I try to regenerate clirr report? and upload release_4_3.html?

Personally, I'd redo all the steps needed to ensure
consistency of what is used to create the release
but YMMV (and others may confirm that the above will
be fine).

>
> According to download page: it seems `mvn
> org.apache.commons:commons-build-plugin:1.10-SNAPSHOT:download-page`
> does nothing for me

Works here.

But it seems there is a big mix-up in the POM with
the "commons.release.<X>.version" properties (comment
does not match the property name and value).
And the generated template of the download page contains
at least one undefined property:
   ${commons.release.4.binary.suffix}

> Shall I manually update download page? What need to be updated?

Personally, I would not do it; IMHO, the POM needs fixing.

Best regards,
Gilles

>
> On Fri, 21 Dec 2018 at 01:17, Gary Gregory <[hidden email]>
> wrote:
>>
>> Hi all, I am unable to review for at least 3 or 4 days. I am on the
>> road
>> and my laptop just died...
>>
>> Gary
>>
>> On Wed, Dec 19, 2018, 08:41 Maxim Solodovnik <[hidden email]
>> wrote:
>>
>> > commons-collections4-4.3-src.zip.sha256This is a [VOTE] for
>> releasing
>> > Apache Commons collections 4.3
>> >
>> > Tag name:
>> > collections-4.3-RC1 (signature can be checked from git using 'git
>> tag -v')
>> >
>> > Tag URL:
>> >
>> >
>> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4d1e1fff27167f803
>> >
>> > Commit ID the tag points at:
>> >     5f959fd8e77bf28f6286cfb4d1e1fff27167f803
>> >
>> > Site:
>> >
>> >
>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/index.html
>> >
>> > Distribution files (committed at revision 31605):
>> >     https://dist.apache.org/repos/dist/dev/commons/collections/
>> >
>> > Distribution files hashes (SHA256):
>> >    
>> 201e1d527c67643b4e75065e113006d0610e8bf5620b4e056a2e044f3676df12
>> > commons-collections4-4.3-bin.tar.gz
>> >    
>> 706a0f5b4ddfd85e5444933576ea37776219748973bf4fc3944d846823f79395
>> > commons-collections4-4.3-bin.zip
>> >    
>> 7a18a39b8b24d8688400276388d5c63da448ee7a8166561a5cffb617b952ed96
>> > commons-collections4-4.3-src.tar.gz
>> >    
>> 8a7b3ccd3fb2ba7edde7e08aa7606b3eacef260eab887358c56473a9e395067a
>> > commons-collections4-4.3-src.zip
>> >
>> > KEYS file to check signatures:
>> >     https://www.apache.org/dist/commons/KEYS
>> >
>> > Maven artifacts:
>> >
>> >
>> https://repository.apache.org/content/repositories/orgapachecommons-1401/
>> >
>> > Please select one of the following options:
>> >   [ ] +1 Release it.
>> >   [ ] +0 Go ahead; I don't care.
>> >   [ ] -0 There are a few minor glitches: ...
>> >   [ ] -1 No, do not release it because ...
>> >
>> > This vote will be open for at least 72 hours, i.e. until
>> > 2018-12-22T14:00:00Z
>> > (this is UTC time).
>> >
>> >
>> ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: [hidden email]
>> > For additional commands, e-mail: [hidden email]
>> >
>> >
>
>
>
> --
> WBR
> Maxim aka solomax
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC1] Commons collections 4.3

Gilles Sadowski
On Tue, 25 Dec 2018 01:15:23 +0100, Gilles wrote:

> On Mon, 24 Dec 2018 22:11:11 +0700, Maxim Solodovnik wrote:
>> Hello All,
>>
>> I'm back :)
>> Shall I try to regenerate clirr report? and upload release_4_3.html?
>
> Personally, I'd redo all the steps needed to ensure
> consistency of what is used to create the release
> but YMMV (and others may confirm that the above will
> be fine).

Also, I've just noticed that in the "4.3-release" branch,
the POM still refers to "4.3-SNAPSHOT" whereas it should
have been changed to "4.3". [That's the primary reason
for creating that branch.]

You should also update the properties used by the release
plugin (RM's name and GPG key, etc).

>
>>
>> According to download page: it seems `mvn
>> org.apache.commons:commons-build-plugin:1.10-SNAPSHOT:download-page`
>> does nothing for me
>
> Works here.

Means: it creates the template file that will be used by the
"site" goal to generate the HTML page.

Regards,
Gilles

> But it seems there is a big mix-up in the POM with
> the "commons.release.<X>.version" properties (comment
> does not match the property name and value).
> And the generated template of the download page contains
> at least one undefined property:
>   ${commons.release.4.binary.suffix}
>
>> Shall I manually update download page? What need to be updated?
>
> Personally, I would not do it; IMHO, the POM needs fixing.
>
> Best regards,
> Gilles
>
>>
>> On Fri, 21 Dec 2018 at 01:17, Gary Gregory <[hidden email]>
>> wrote:
>>>
>>> Hi all, I am unable to review for at least 3 or 4 days. I am on the
>>> road
>>> and my laptop just died...
>>>
>>> Gary
>>>
>>> On Wed, Dec 19, 2018, 08:41 Maxim Solodovnik <[hidden email]
>>> wrote:
>>>
>>> > commons-collections4-4.3-src.zip.sha256This is a [VOTE] for
>>> releasing
>>> > Apache Commons collections 4.3
>>> >
>>> > Tag name:
>>> > collections-4.3-RC1 (signature can be checked from git using 'git
>>> tag -v')
>>> >
>>> > Tag URL:
>>> >
>>> >
>>> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4d1e1fff27167f803
>>> >
>>> > Commit ID the tag points at:
>>> >     5f959fd8e77bf28f6286cfb4d1e1fff27167f803
>>> >
>>> > Site:
>>> >
>>> >
>>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/index.html
>>> >
>>> > Distribution files (committed at revision 31605):
>>> >     https://dist.apache.org/repos/dist/dev/commons/collections/
>>> >
>>> > Distribution files hashes (SHA256):
>>> >    
>>> 201e1d527c67643b4e75065e113006d0610e8bf5620b4e056a2e044f3676df12
>>> > commons-collections4-4.3-bin.tar.gz
>>> >    
>>> 706a0f5b4ddfd85e5444933576ea37776219748973bf4fc3944d846823f79395
>>> > commons-collections4-4.3-bin.zip
>>> >    
>>> 7a18a39b8b24d8688400276388d5c63da448ee7a8166561a5cffb617b952ed96
>>> > commons-collections4-4.3-src.tar.gz
>>> >    
>>> 8a7b3ccd3fb2ba7edde7e08aa7606b3eacef260eab887358c56473a9e395067a
>>> > commons-collections4-4.3-src.zip
>>> >
>>> > KEYS file to check signatures:
>>> >     https://www.apache.org/dist/commons/KEYS
>>> >
>>> > Maven artifacts:
>>> >
>>> >
>>> https://repository.apache.org/content/repositories/orgapachecommons-1401/
>>> >
>>> > Please select one of the following options:
>>> >   [ ] +1 Release it.
>>> >   [ ] +0 Go ahead; I don't care.
>>> >   [ ] -0 There are a few minor glitches: ...
>>> >   [ ] -1 No, do not release it because ...
>>> >
>>> > This vote will be open for at least 72 hours, i.e. until
>>> > 2018-12-22T14:00:00Z
>>> > (this is UTC time).
>>> >
>>> >
>>> ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: [hidden email]
>>> > For additional commands, e-mail: [hidden email]
>>> >
>>> >
>>
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC1] Commons collections 4.3

Maxim Solodovnik
Hello Gilles,

Actually if release is made based on git it is not necessary to
perform commits into local branch you are using to create RC tag
this why I previously ask if I can drop useless branch

I can fix issues with site manually, but it will be impossible to
modify pom without canceling release
I totally miss these properties :(
<commons.bc.version>
<commons.releaseManagerName>
<commons.releaseManagerKey>

Shall I cancel the VOTE and create RC2?

On Tue, 25 Dec 2018 at 07:48, Gilles <[hidden email]> wrote:

>
> On Tue, 25 Dec 2018 01:15:23 +0100, Gilles wrote:
> > On Mon, 24 Dec 2018 22:11:11 +0700, Maxim Solodovnik wrote:
> >> Hello All,
> >>
> >> I'm back :)
> >> Shall I try to regenerate clirr report? and upload release_4_3.html?
> >
> > Personally, I'd redo all the steps needed to ensure
> > consistency of what is used to create the release
> > but YMMV (and others may confirm that the above will
> > be fine).
>
> Also, I've just noticed that in the "4.3-release" branch,
> the POM still refers to "4.3-SNAPSHOT" whereas it should
> have been changed to "4.3". [That's the primary reason
> for creating that branch.]
>
> You should also update the properties used by the release
> plugin (RM's name and GPG key, etc).
>
> >
> >>
> >> According to download page: it seems `mvn
> >> org.apache.commons:commons-build-plugin:1.10-SNAPSHOT:download-page`
> >> does nothing for me
> >
> > Works here.
>
> Means: it creates the template file that will be used by the
> "site" goal to generate the HTML page.
>
> Regards,
> Gilles
>
> > But it seems there is a big mix-up in the POM with
> > the "commons.release.<X>.version" properties (comment
> > does not match the property name and value).
> > And the generated template of the download page contains
> > at least one undefined property:
> >   ${commons.release.4.binary.suffix}
> >
> >> Shall I manually update download page? What need to be updated?
> >
> > Personally, I would not do it; IMHO, the POM needs fixing.
> >
> > Best regards,
> > Gilles
> >
> >>
> >> On Fri, 21 Dec 2018 at 01:17, Gary Gregory <[hidden email]>
> >> wrote:
> >>>
> >>> Hi all, I am unable to review for at least 3 or 4 days. I am on the
> >>> road
> >>> and my laptop just died...
> >>>
> >>> Gary
> >>>
> >>> On Wed, Dec 19, 2018, 08:41 Maxim Solodovnik <[hidden email]
> >>> wrote:
> >>>
> >>> > commons-collections4-4.3-src.zip.sha256This is a [VOTE] for
> >>> releasing
> >>> > Apache Commons collections 4.3
> >>> >
> >>> > Tag name:
> >>> > collections-4.3-RC1 (signature can be checked from git using 'git
> >>> tag -v')
> >>> >
> >>> > Tag URL:
> >>> >
> >>> >
> >>> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4d1e1fff27167f803
> >>> >
> >>> > Commit ID the tag points at:
> >>> >     5f959fd8e77bf28f6286cfb4d1e1fff27167f803
> >>> >
> >>> > Site:
> >>> >
> >>> >
> >>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/index.html
> >>> >
> >>> > Distribution files (committed at revision 31605):
> >>> >     https://dist.apache.org/repos/dist/dev/commons/collections/
> >>> >
> >>> > Distribution files hashes (SHA256):
> >>> >
> >>> 201e1d527c67643b4e75065e113006d0610e8bf5620b4e056a2e044f3676df12
> >>> > commons-collections4-4.3-bin.tar.gz
> >>> >
> >>> 706a0f5b4ddfd85e5444933576ea37776219748973bf4fc3944d846823f79395
> >>> > commons-collections4-4.3-bin.zip
> >>> >
> >>> 7a18a39b8b24d8688400276388d5c63da448ee7a8166561a5cffb617b952ed96
> >>> > commons-collections4-4.3-src.tar.gz
> >>> >
> >>> 8a7b3ccd3fb2ba7edde7e08aa7606b3eacef260eab887358c56473a9e395067a
> >>> > commons-collections4-4.3-src.zip
> >>> >
> >>> > KEYS file to check signatures:
> >>> >     https://www.apache.org/dist/commons/KEYS
> >>> >
> >>> > Maven artifacts:
> >>> >
> >>> >
> >>> https://repository.apache.org/content/repositories/orgapachecommons-1401/
> >>> >
> >>> > Please select one of the following options:
> >>> >   [ ] +1 Release it.
> >>> >   [ ] +0 Go ahead; I don't care.
> >>> >   [ ] -0 There are a few minor glitches: ...
> >>> >   [ ] -1 No, do not release it because ...
> >>> >
> >>> > This vote will be open for at least 72 hours, i.e. until
> >>> > 2018-12-22T14:00:00Z
> >>> > (this is UTC time).
> >>> >
> >>> >
> >>> ---------------------------------------------------------------------
> >>> > To unsubscribe, e-mail: [hidden email]
> >>> > For additional commands, e-mail: [hidden email]
> >>> >
> >>> >
> >>
> >>
> >>
> >> --
> >> WBR
> >> Maxim aka solomax
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


--
WBR
Maxim aka solomax

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC1] Commons collections 4.3

Gilles Sadowski
Hi.

On Tue, 25 Dec 2018 22:22:43 +0700, Maxim Solodovnik wrote:
> Hello Gilles,
>
> Actually if release is made based on git it is not necessary to
> perform commits

?
I don't know other ways to perform the release; I follow
the practice established for "svn", that was then adapted
for "git" when we switched to it.

Do you propose an alternative way to do it?  Please
share some link describing the process

> into local branch you are using to create RC tag
> this why I previously ask if I can drop useless branch

In the current scheme, it does not seem useless... ;-)

> I can fix issues with site manually, but it will be impossible to
> modify pom without canceling release
> I totally miss these properties :(
> <commons.bc.version>
> <commons.releaseManagerName>
> <commons.releaseManagerKey>

I think that you can specify the values on the command
line too.

> Shall I cancel the VOTE and create RC2?

It's up to you.  Personally, I'd take the safest way to
ensure an RC with no issues.

Regards,
Gilles

> On Tue, 25 Dec 2018 at 07:48, Gilles <[hidden email]>
> wrote:
>>
>> On Tue, 25 Dec 2018 01:15:23 +0100, Gilles wrote:
>> > On Mon, 24 Dec 2018 22:11:11 +0700, Maxim Solodovnik wrote:
>> >> Hello All,
>> >>
>> >> I'm back :)
>> >> Shall I try to regenerate clirr report? and upload
>> release_4_3.html?
>> >
>> > Personally, I'd redo all the steps needed to ensure
>> > consistency of what is used to create the release
>> > but YMMV (and others may confirm that the above will
>> > be fine).
>>
>> Also, I've just noticed that in the "4.3-release" branch,
>> the POM still refers to "4.3-SNAPSHOT" whereas it should
>> have been changed to "4.3". [That's the primary reason
>> for creating that branch.]
>>
>> You should also update the properties used by the release
>> plugin (RM's name and GPG key, etc).
>>
>> >
>> >>
>> >> According to download page: it seems `mvn
>> >>
>> org.apache.commons:commons-build-plugin:1.10-SNAPSHOT:download-page`
>> >> does nothing for me
>> >
>> > Works here.
>>
>> Means: it creates the template file that will be used by the
>> "site" goal to generate the HTML page.
>>
>> Regards,
>> Gilles
>>
>> > But it seems there is a big mix-up in the POM with
>> > the "commons.release.<X>.version" properties (comment
>> > does not match the property name and value).
>> > And the generated template of the download page contains
>> > at least one undefined property:
>> >   ${commons.release.4.binary.suffix}
>> >
>> >> Shall I manually update download page? What need to be updated?
>> >
>> > Personally, I would not do it; IMHO, the POM needs fixing.
>> >
>> > Best regards,
>> > Gilles
>> >
>> >>
>> >> On Fri, 21 Dec 2018 at 01:17, Gary Gregory
>> <[hidden email]>
>> >> wrote:
>> >>>
>> >>> Hi all, I am unable to review for at least 3 or 4 days. I am on
>> the
>> >>> road
>> >>> and my laptop just died...
>> >>>
>> >>> Gary
>> >>>
>> >>> On Wed, Dec 19, 2018, 08:41 Maxim Solodovnik <[hidden email]
>> >>> wrote:
>> >>>
>> >>> > commons-collections4-4.3-src.zip.sha256This is a [VOTE] for
>> >>> releasing
>> >>> > Apache Commons collections 4.3
>> >>> >
>> >>> > Tag name:
>> >>> > collections-4.3-RC1 (signature can be checked from git using
>> 'git
>> >>> tag -v')
>> >>> >
>> >>> > Tag URL:
>> >>> >
>> >>> >
>> >>>
>> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4d1e1fff27167f803
>> >>> >
>> >>> > Commit ID the tag points at:
>> >>> >     5f959fd8e77bf28f6286cfb4d1e1fff27167f803
>> >>> >
>> >>> > Site:
>> >>> >
>> >>> >
>> >>>
>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/index.html
>> >>> >
>> >>> > Distribution files (committed at revision 31605):
>> >>> >    
>> https://dist.apache.org/repos/dist/dev/commons/collections/
>> >>> >
>> >>> > Distribution files hashes (SHA256):
>> >>> >
>> >>> 201e1d527c67643b4e75065e113006d0610e8bf5620b4e056a2e044f3676df12
>> >>> > commons-collections4-4.3-bin.tar.gz
>> >>> >
>> >>> 706a0f5b4ddfd85e5444933576ea37776219748973bf4fc3944d846823f79395
>> >>> > commons-collections4-4.3-bin.zip
>> >>> >
>> >>> 7a18a39b8b24d8688400276388d5c63da448ee7a8166561a5cffb617b952ed96
>> >>> > commons-collections4-4.3-src.tar.gz
>> >>> >
>> >>> 8a7b3ccd3fb2ba7edde7e08aa7606b3eacef260eab887358c56473a9e395067a
>> >>> > commons-collections4-4.3-src.zip
>> >>> >
>> >>> > KEYS file to check signatures:
>> >>> >     https://www.apache.org/dist/commons/KEYS
>> >>> >
>> >>> > Maven artifacts:
>> >>> >
>> >>> >
>> >>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1401/
>> >>> >
>> >>> > Please select one of the following options:
>> >>> >   [ ] +1 Release it.
>> >>> >   [ ] +0 Go ahead; I don't care.
>> >>> >   [ ] -0 There are a few minor glitches: ...
>> >>> >   [ ] -1 No, do not release it because ...
>> >>> >
>> >>> > This vote will be open for at least 72 hours, i.e. until
>> >>> > 2018-12-22T14:00:00Z
>> >>> > (this is UTC time).
>> >>> >
>> >>> >
>> >>>
>> ---------------------------------------------------------------------
>> >>> > To unsubscribe, e-mail: [hidden email]
>> >>> > For additional commands, e-mail: [hidden email]
>> >>> >
>> >>> >
>> >>
>> >>
>> >>
>> >> --
>> >> WBR
>> >> Maxim aka solomax
>> >>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[CANCELED] [VOTE][RC1] Commons collections 4.3

Maxim Solodovnik
Hello All,

I will cancel the VOTE due to issues found in this RC
Will try to create RC2 ASAP

Thanks for your help!

On Wed, 26 Dec 2018 at 05:40, Gilles <[hidden email]> wrote:

> Hi.
>
> On Tue, 25 Dec 2018 22:22:43 +0700, Maxim Solodovnik wrote:
> > Hello Gilles,
> >
> > Actually if release is made based on git it is not necessary to
> > perform commits
>
> ?
> I don't know other ways to perform the release; I follow
> the practice established for "svn", that was then adapted
> for "git" when we switched to it.
>
> Do you propose an alternative way to do it?  Please
> share some link describing the process
>
> > into local branch you are using to create RC tag
> > this why I previously ask if I can drop useless branch
>
> In the current scheme, it does not seem useless... ;-)
>
> > I can fix issues with site manually, but it will be impossible to
> > modify pom without canceling release
> > I totally miss these properties :(
> > <commons.bc.version>
> > <commons.releaseManagerName>
> > <commons.releaseManagerKey>
>
> I think that you can specify the values on the command
> line too.
>
> > Shall I cancel the VOTE and create RC2?
>
> It's up to you.  Personally, I'd take the safest way to
> ensure an RC with no issues.
>
> Regards,
> Gilles
>
> > On Tue, 25 Dec 2018 at 07:48, Gilles <[hidden email]>
> > wrote:
> >>
> >> On Tue, 25 Dec 2018 01:15:23 +0100, Gilles wrote:
> >> > On Mon, 24 Dec 2018 22:11:11 +0700, Maxim Solodovnik wrote:
> >> >> Hello All,
> >> >>
> >> >> I'm back :)
> >> >> Shall I try to regenerate clirr report? and upload
> >> release_4_3.html?
> >> >
> >> > Personally, I'd redo all the steps needed to ensure
> >> > consistency of what is used to create the release
> >> > but YMMV (and others may confirm that the above will
> >> > be fine).
> >>
> >> Also, I've just noticed that in the "4.3-release" branch,
> >> the POM still refers to "4.3-SNAPSHOT" whereas it should
> >> have been changed to "4.3". [That's the primary reason
> >> for creating that branch.]
> >>
> >> You should also update the properties used by the release
> >> plugin (RM's name and GPG key, etc).
> >>
> >> >
> >> >>
> >> >> According to download page: it seems `mvn
> >> >>
> >> org.apache.commons:commons-build-plugin:1.10-SNAPSHOT:download-page`
> >> >> does nothing for me
> >> >
> >> > Works here.
> >>
> >> Means: it creates the template file that will be used by the
> >> "site" goal to generate the HTML page.
> >>
> >> Regards,
> >> Gilles
> >>
> >> > But it seems there is a big mix-up in the POM with
> >> > the "commons.release.<X>.version" properties (comment
> >> > does not match the property name and value).
> >> > And the generated template of the download page contains
> >> > at least one undefined property:
> >> >   ${commons.release.4.binary.suffix}
> >> >
> >> >> Shall I manually update download page? What need to be updated?
> >> >
> >> > Personally, I would not do it; IMHO, the POM needs fixing.
> >> >
> >> > Best regards,
> >> > Gilles
> >> >
> >> >>
> >> >> On Fri, 21 Dec 2018 at 01:17, Gary Gregory
> >> <[hidden email]>
> >> >> wrote:
> >> >>>
> >> >>> Hi all, I am unable to review for at least 3 or 4 days. I am on
> >> the
> >> >>> road
> >> >>> and my laptop just died...
> >> >>>
> >> >>> Gary
> >> >>>
> >> >>> On Wed, Dec 19, 2018, 08:41 Maxim Solodovnik <[hidden email]
> >> >>> wrote:
> >> >>>
> >> >>> > commons-collections4-4.3-src.zip.sha256This is a [VOTE] for
> >> >>> releasing
> >> >>> > Apache Commons collections 4.3
> >> >>> >
> >> >>> > Tag name:
> >> >>> > collections-4.3-RC1 (signature can be checked from git using
> >> 'git
> >> >>> tag -v')
> >> >>> >
> >> >>> > Tag URL:
> >> >>> >
> >> >>> >
> >> >>>
> >>
> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4d1e1fff27167f803
> >> >>> >
> >> >>> > Commit ID the tag points at:
> >> >>> >     5f959fd8e77bf28f6286cfb4d1e1fff27167f803
> >> >>> >
> >> >>> > Site:
> >> >>> >
> >> >>> >
> >> >>>
> >>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/index.html
> >> >>> >
> >> >>> > Distribution files (committed at revision 31605):
> >> >>> >
> >> https://dist.apache.org/repos/dist/dev/commons/collections/
> >> >>> >
> >> >>> > Distribution files hashes (SHA256):
> >> >>> >
> >> >>> 201e1d527c67643b4e75065e113006d0610e8bf5620b4e056a2e044f3676df12
> >> >>> > commons-collections4-4.3-bin.tar.gz
> >> >>> >
> >> >>> 706a0f5b4ddfd85e5444933576ea37776219748973bf4fc3944d846823f79395
> >> >>> > commons-collections4-4.3-bin.zip
> >> >>> >
> >> >>> 7a18a39b8b24d8688400276388d5c63da448ee7a8166561a5cffb617b952ed96
> >> >>> > commons-collections4-4.3-src.tar.gz
> >> >>> >
> >> >>> 8a7b3ccd3fb2ba7edde7e08aa7606b3eacef260eab887358c56473a9e395067a
> >> >>> > commons-collections4-4.3-src.zip
> >> >>> >
> >> >>> > KEYS file to check signatures:
> >> >>> >     https://www.apache.org/dist/commons/KEYS
> >> >>> >
> >> >>> > Maven artifacts:
> >> >>> >
> >> >>> >
> >> >>>
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-1401/
> >> >>> >
> >> >>> > Please select one of the following options:
> >> >>> >   [ ] +1 Release it.
> >> >>> >   [ ] +0 Go ahead; I don't care.
> >> >>> >   [ ] -0 There are a few minor glitches: ...
> >> >>> >   [ ] -1 No, do not release it because ...
> >> >>> >
> >> >>> > This vote will be open for at least 72 hours, i.e. until
> >> >>> > 2018-12-22T14:00:00Z
> >> >>> > (this is UTC time).
> >> >>> >
> >> >>> >
> >> >>>
> >> ---------------------------------------------------------------------
> >> >>> > To unsubscribe, e-mail: [hidden email]
> >> >>> > For additional commands, e-mail: [hidden email]
> >> >>> >
> >> >>> >
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> WBR
> >> >> Maxim aka solomax
> >> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

--
WBR
Maxim aka solomax
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC1] Commons collections 4.3

Maxim Solodovnik
In reply to this post by Gilles Sadowski
In both git and svn you need a branch to create tag
But since git has local and remote repository, steps can be:

1) create local branch
2) made "release" changes
3) create tag
4) push the tag

In this case only tag will be pushed, and there will be no useless branches
with minimal "release" changes

On Wed, 26 Dec 2018 at 05:40, Gilles <[hidden email]> wrote:

> Hi.
>
> On Tue, 25 Dec 2018 22:22:43 +0700, Maxim Solodovnik wrote:
> > Hello Gilles,
> >
> > Actually if release is made based on git it is not necessary to
> > perform commits
>
> ?
> I don't know other ways to perform the release; I follow
> the practice established for "svn", that was then adapted
> for "git" when we switched to it.
>
> Do you propose an alternative way to do it?  Please
> share some link describing the process
>
> > into local branch you are using to create RC tag
> > this why I previously ask if I can drop useless branch
>
> In the current scheme, it does not seem useless... ;-)
>
> > I can fix issues with site manually, but it will be impossible to
> > modify pom without canceling release
> > I totally miss these properties :(
> > <commons.bc.version>
> > <commons.releaseManagerName>
> > <commons.releaseManagerKey>
>
> I think that you can specify the values on the command
> line too.
>
> > Shall I cancel the VOTE and create RC2?
>
> It's up to you.  Personally, I'd take the safest way to
> ensure an RC with no issues.
>
> Regards,
> Gilles
>
> > On Tue, 25 Dec 2018 at 07:48, Gilles <[hidden email]>
> > wrote:
> >>
> >> On Tue, 25 Dec 2018 01:15:23 +0100, Gilles wrote:
> >> > On Mon, 24 Dec 2018 22:11:11 +0700, Maxim Solodovnik wrote:
> >> >> Hello All,
> >> >>
> >> >> I'm back :)
> >> >> Shall I try to regenerate clirr report? and upload
> >> release_4_3.html?
> >> >
> >> > Personally, I'd redo all the steps needed to ensure
> >> > consistency of what is used to create the release
> >> > but YMMV (and others may confirm that the above will
> >> > be fine).
> >>
> >> Also, I've just noticed that in the "4.3-release" branch,
> >> the POM still refers to "4.3-SNAPSHOT" whereas it should
> >> have been changed to "4.3". [That's the primary reason
> >> for creating that branch.]
> >>
> >> You should also update the properties used by the release
> >> plugin (RM's name and GPG key, etc).
> >>
> >> >
> >> >>
> >> >> According to download page: it seems `mvn
> >> >>
> >> org.apache.commons:commons-build-plugin:1.10-SNAPSHOT:download-page`
> >> >> does nothing for me
> >> >
> >> > Works here.
> >>
> >> Means: it creates the template file that will be used by the
> >> "site" goal to generate the HTML page.
> >>
> >> Regards,
> >> Gilles
> >>
> >> > But it seems there is a big mix-up in the POM with
> >> > the "commons.release.<X>.version" properties (comment
> >> > does not match the property name and value).
> >> > And the generated template of the download page contains
> >> > at least one undefined property:
> >> >   ${commons.release.4.binary.suffix}
> >> >
> >> >> Shall I manually update download page? What need to be updated?
> >> >
> >> > Personally, I would not do it; IMHO, the POM needs fixing.
> >> >
> >> > Best regards,
> >> > Gilles
> >> >
> >> >>
> >> >> On Fri, 21 Dec 2018 at 01:17, Gary Gregory
> >> <[hidden email]>
> >> >> wrote:
> >> >>>
> >> >>> Hi all, I am unable to review for at least 3 or 4 days. I am on
> >> the
> >> >>> road
> >> >>> and my laptop just died...
> >> >>>
> >> >>> Gary
> >> >>>
> >> >>> On Wed, Dec 19, 2018, 08:41 Maxim Solodovnik <[hidden email]
> >> >>> wrote:
> >> >>>
> >> >>> > commons-collections4-4.3-src.zip.sha256This is a [VOTE] for
> >> >>> releasing
> >> >>> > Apache Commons collections 4.3
> >> >>> >
> >> >>> > Tag name:
> >> >>> > collections-4.3-RC1 (signature can be checked from git using
> >> 'git
> >> >>> tag -v')
> >> >>> >
> >> >>> > Tag URL:
> >> >>> >
> >> >>> >
> >> >>>
> >>
> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4d1e1fff27167f803
> >> >>> >
> >> >>> > Commit ID the tag points at:
> >> >>> >     5f959fd8e77bf28f6286cfb4d1e1fff27167f803
> >> >>> >
> >> >>> > Site:
> >> >>> >
> >> >>> >
> >> >>>
> >>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/index.html
> >> >>> >
> >> >>> > Distribution files (committed at revision 31605):
> >> >>> >
> >> https://dist.apache.org/repos/dist/dev/commons/collections/
> >> >>> >
> >> >>> > Distribution files hashes (SHA256):
> >> >>> >
> >> >>> 201e1d527c67643b4e75065e113006d0610e8bf5620b4e056a2e044f3676df12
> >> >>> > commons-collections4-4.3-bin.tar.gz
> >> >>> >
> >> >>> 706a0f5b4ddfd85e5444933576ea37776219748973bf4fc3944d846823f79395
> >> >>> > commons-collections4-4.3-bin.zip
> >> >>> >
> >> >>> 7a18a39b8b24d8688400276388d5c63da448ee7a8166561a5cffb617b952ed96
> >> >>> > commons-collections4-4.3-src.tar.gz
> >> >>> >
> >> >>> 8a7b3ccd3fb2ba7edde7e08aa7606b3eacef260eab887358c56473a9e395067a
> >> >>> > commons-collections4-4.3-src.zip
> >> >>> >
> >> >>> > KEYS file to check signatures:
> >> >>> >     https://www.apache.org/dist/commons/KEYS
> >> >>> >
> >> >>> > Maven artifacts:
> >> >>> >
> >> >>> >
> >> >>>
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-1401/
> >> >>> >
> >> >>> > Please select one of the following options:
> >> >>> >   [ ] +1 Release it.
> >> >>> >   [ ] +0 Go ahead; I don't care.
> >> >>> >   [ ] -0 There are a few minor glitches: ...
> >> >>> >   [ ] -1 No, do not release it because ...
> >> >>> >
> >> >>> > This vote will be open for at least 72 hours, i.e. until
> >> >>> > 2018-12-22T14:00:00Z
> >> >>> > (this is UTC time).
> >> >>> >
> >> >>> >
> >> >>>
> >> ---------------------------------------------------------------------
> >> >>> > To unsubscribe, e-mail: [hidden email]
> >> >>> > For additional commands, e-mail: [hidden email]
> >> >>> >
> >> >>> >
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> WBR
> >> >> Maxim aka solomax
> >> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

--
WBR
Maxim aka solomax
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC1] Commons collections 4.3

Rob Tompkins


> On Dec 25, 2018, at 8:04 PM, Maxim Solodovnik <[hidden email]> wrote:
>
> In both git and svn you need a branch to create tag
> But since git has local and remote repository, steps can be:
>
> 1) create local branch
> 2) made "release" changes
> 3) create tag
> 4) push the tag
>
> In this case only tag will be pushed, and there will be no useless branches
> with minimal "release" changes
>

Yes that is true. But so long as the vote has yet to be initiated, the tag can be pushed even after the build has been made.

-Rob

>> On Wed, 26 Dec 2018 at 05:40, Gilles <[hidden email]> wrote:
>>
>> Hi.
>>
>>> On Tue, 25 Dec 2018 22:22:43 +0700, Maxim Solodovnik wrote:
>>> Hello Gilles,
>>>
>>> Actually if release is made based on git it is not necessary to
>>> perform commits
>>
>> ?
>> I don't know other ways to perform the release; I follow
>> the practice established for "svn", that was then adapted
>> for "git" when we switched to it.
>>
>> Do you propose an alternative way to do it?  Please
>> share some link describing the process
>>
>>> into local branch you are using to create RC tag
>>> this why I previously ask if I can drop useless branch
>>
>> In the current scheme, it does not seem useless... ;-)
>>
>>> I can fix issues with site manually, but it will be impossible to
>>> modify pom without canceling release
>>> I totally miss these properties :(
>>> <commons.bc.version>
>>> <commons.releaseManagerName>
>>> <commons.releaseManagerKey>
>>
>> I think that you can specify the values on the command
>> line too.
>>
>>> Shall I cancel the VOTE and create RC2?
>>
>> It's up to you.  Personally, I'd take the safest way to
>> ensure an RC with no issues.
>>
>> Regards,
>> Gilles
>>
>>> On Tue, 25 Dec 2018 at 07:48, Gilles <[hidden email]>
>>> wrote:
>>>>
>>>>> On Tue, 25 Dec 2018 01:15:23 +0100, Gilles wrote:
>>>>>> On Mon, 24 Dec 2018 22:11:11 +0700, Maxim Solodovnik wrote:
>>>>>> Hello All,
>>>>>>
>>>>>> I'm back :)
>>>>>> Shall I try to regenerate clirr report? and upload
>>>> release_4_3.html?
>>>>>
>>>>> Personally, I'd redo all the steps needed to ensure
>>>>> consistency of what is used to create the release
>>>>> but YMMV (and others may confirm that the above will
>>>>> be fine).
>>>>
>>>> Also, I've just noticed that in the "4.3-release" branch,
>>>> the POM still refers to "4.3-SNAPSHOT" whereas it should
>>>> have been changed to "4.3". [That's the primary reason
>>>> for creating that branch.]
>>>>
>>>> You should also update the properties used by the release
>>>> plugin (RM's name and GPG key, etc).
>>>>
>>>>>
>>>>>>
>>>>>> According to download page: it seems `mvn
>>>>>>
>>>> org.apache.commons:commons-build-plugin:1.10-SNAPSHOT:download-page`
>>>>>> does nothing for me
>>>>>
>>>>> Works here.
>>>>
>>>> Means: it creates the template file that will be used by the
>>>> "site" goal to generate the HTML page.
>>>>
>>>> Regards,
>>>> Gilles
>>>>
>>>>> But it seems there is a big mix-up in the POM with
>>>>> the "commons.release.<X>.version" properties (comment
>>>>> does not match the property name and value).
>>>>> And the generated template of the download page contains
>>>>> at least one undefined property:
>>>>>  ${commons.release.4.binary.suffix}
>>>>>
>>>>>> Shall I manually update download page? What need to be updated?
>>>>>
>>>>> Personally, I would not do it; IMHO, the POM needs fixing.
>>>>>
>>>>> Best regards,
>>>>> Gilles
>>>>>
>>>>>>
>>>>>> On Fri, 21 Dec 2018 at 01:17, Gary Gregory
>>>> <[hidden email]>
>>>>>> wrote:
>>>>>>>
>>>>>>> Hi all, I am unable to review for at least 3 or 4 days. I am on
>>>> the
>>>>>>> road
>>>>>>> and my laptop just died...
>>>>>>>
>>>>>>> Gary
>>>>>>>
>>>>>>> On Wed, Dec 19, 2018, 08:41 Maxim Solodovnik <[hidden email]
>>>>>>> wrote:
>>>>>>>
>>>>>>>> commons-collections4-4.3-src.zip.sha256This is a [VOTE] for
>>>>>>> releasing
>>>>>>>> Apache Commons collections 4.3
>>>>>>>>
>>>>>>>> Tag name:
>>>>>>>> collections-4.3-RC1 (signature can be checked from git using
>>>> 'git
>>>>>>> tag -v')
>>>>>>>>
>>>>>>>> Tag URL:
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>
>> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4d1e1fff27167f803
>>>>>>>>
>>>>>>>> Commit ID the tag points at:
>>>>>>>>    5f959fd8e77bf28f6286cfb4d1e1fff27167f803
>>>>>>>>
>>>>>>>> Site:
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>
>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/index.html
>>>>>>>>
>>>>>>>> Distribution files (committed at revision 31605):
>>>>>>>>
>>>> https://dist.apache.org/repos/dist/dev/commons/collections/
>>>>>>>>
>>>>>>>> Distribution files hashes (SHA256):
>>>>>>>>
>>>>>>> 201e1d527c67643b4e75065e113006d0610e8bf5620b4e056a2e044f3676df12
>>>>>>>> commons-collections4-4.3-bin.tar.gz
>>>>>>>>
>>>>>>> 706a0f5b4ddfd85e5444933576ea37776219748973bf4fc3944d846823f79395
>>>>>>>> commons-collections4-4.3-bin.zip
>>>>>>>>
>>>>>>> 7a18a39b8b24d8688400276388d5c63da448ee7a8166561a5cffb617b952ed96
>>>>>>>> commons-collections4-4.3-src.tar.gz
>>>>>>>>
>>>>>>> 8a7b3ccd3fb2ba7edde7e08aa7606b3eacef260eab887358c56473a9e395067a
>>>>>>>> commons-collections4-4.3-src.zip
>>>>>>>>
>>>>>>>> KEYS file to check signatures:
>>>>>>>>    https://www.apache.org/dist/commons/KEYS
>>>>>>>>
>>>>>>>> Maven artifacts:
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1401/
>>>>>>>>
>>>>>>>> Please select one of the following options:
>>>>>>>>  [ ] +1 Release it.
>>>>>>>>  [ ] +0 Go ahead; I don't care.
>>>>>>>>  [ ] -0 There are a few minor glitches: ...
>>>>>>>>  [ ] -1 No, do not release it because ...
>>>>>>>>
>>>>>>>> This vote will be open for at least 72 hours, i.e. until
>>>>>>>> 2018-12-22T14:00:00Z
>>>>>>>> (this is UTC time).
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: [hidden email]
>>>>>>>> For additional commands, e-mail: [hidden email]
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> WBR
>>>>>> Maxim aka solomax
>>>>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>
> --
> WBR
> Maxim aka solomax

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC1] Commons collections 4.3

Maxim Solodovnik
This is the way Wicketstuff build is performed [1]
The project consist of ~285 modules and it is wise to create tag only if
build is already in Nexus :)

[1]
https://github.com/wicketstuff/core/wiki/Wicket-Stuff-Core-Release-Process

On Wed, 26 Dec 2018 at 08:11, Rob Tompkins <[hidden email]> wrote:

>
>
> > On Dec 25, 2018, at 8:04 PM, Maxim Solodovnik <[hidden email]>
> wrote:
> >
> > In both git and svn you need a branch to create tag
> > But since git has local and remote repository, steps can be:
> >
> > 1) create local branch
> > 2) made "release" changes
> > 3) create tag
> > 4) push the tag
> >
> > In this case only tag will be pushed, and there will be no useless
> branches
> > with minimal "release" changes
> >
>
> Yes that is true. But so long as the vote has yet to be initiated, the tag
> can be pushed even after the build has been made.
>
> -Rob
>
> >> On Wed, 26 Dec 2018 at 05:40, Gilles <[hidden email]>
> wrote:
> >>
> >> Hi.
> >>
> >>> On Tue, 25 Dec 2018 22:22:43 +0700, Maxim Solodovnik wrote:
> >>> Hello Gilles,
> >>>
> >>> Actually if release is made based on git it is not necessary to
> >>> perform commits
> >>
> >> ?
> >> I don't know other ways to perform the release; I follow
> >> the practice established for "svn", that was then adapted
> >> for "git" when we switched to it.
> >>
> >> Do you propose an alternative way to do it?  Please
> >> share some link describing the process
> >>
> >>> into local branch you are using to create RC tag
> >>> this why I previously ask if I can drop useless branch
> >>
> >> In the current scheme, it does not seem useless... ;-)
> >>
> >>> I can fix issues with site manually, but it will be impossible to
> >>> modify pom without canceling release
> >>> I totally miss these properties :(
> >>> <commons.bc.version>
> >>> <commons.releaseManagerName>
> >>> <commons.releaseManagerKey>
> >>
> >> I think that you can specify the values on the command
> >> line too.
> >>
> >>> Shall I cancel the VOTE and create RC2?
> >>
> >> It's up to you.  Personally, I'd take the safest way to
> >> ensure an RC with no issues.
> >>
> >> Regards,
> >> Gilles
> >>
> >>> On Tue, 25 Dec 2018 at 07:48, Gilles <[hidden email]>
> >>> wrote:
> >>>>
> >>>>> On Tue, 25 Dec 2018 01:15:23 +0100, Gilles wrote:
> >>>>>> On Mon, 24 Dec 2018 22:11:11 +0700, Maxim Solodovnik wrote:
> >>>>>> Hello All,
> >>>>>>
> >>>>>> I'm back :)
> >>>>>> Shall I try to regenerate clirr report? and upload
> >>>> release_4_3.html?
> >>>>>
> >>>>> Personally, I'd redo all the steps needed to ensure
> >>>>> consistency of what is used to create the release
> >>>>> but YMMV (and others may confirm that the above will
> >>>>> be fine).
> >>>>
> >>>> Also, I've just noticed that in the "4.3-release" branch,
> >>>> the POM still refers to "4.3-SNAPSHOT" whereas it should
> >>>> have been changed to "4.3". [That's the primary reason
> >>>> for creating that branch.]
> >>>>
> >>>> You should also update the properties used by the release
> >>>> plugin (RM's name and GPG key, etc).
> >>>>
> >>>>>
> >>>>>>
> >>>>>> According to download page: it seems `mvn
> >>>>>>
> >>>> org.apache.commons:commons-build-plugin:1.10-SNAPSHOT:download-page`
> >>>>>> does nothing for me
> >>>>>
> >>>>> Works here.
> >>>>
> >>>> Means: it creates the template file that will be used by the
> >>>> "site" goal to generate the HTML page.
> >>>>
> >>>> Regards,
> >>>> Gilles
> >>>>
> >>>>> But it seems there is a big mix-up in the POM with
> >>>>> the "commons.release.<X>.version" properties (comment
> >>>>> does not match the property name and value).
> >>>>> And the generated template of the download page contains
> >>>>> at least one undefined property:
> >>>>>  ${commons.release.4.binary.suffix}
> >>>>>
> >>>>>> Shall I manually update download page? What need to be updated?
> >>>>>
> >>>>> Personally, I would not do it; IMHO, the POM needs fixing.
> >>>>>
> >>>>> Best regards,
> >>>>> Gilles
> >>>>>
> >>>>>>
> >>>>>> On Fri, 21 Dec 2018 at 01:17, Gary Gregory
> >>>> <[hidden email]>
> >>>>>> wrote:
> >>>>>>>
> >>>>>>> Hi all, I am unable to review for at least 3 or 4 days. I am on
> >>>> the
> >>>>>>> road
> >>>>>>> and my laptop just died...
> >>>>>>>
> >>>>>>> Gary
> >>>>>>>
> >>>>>>> On Wed, Dec 19, 2018, 08:41 Maxim Solodovnik <[hidden email]
> >>>>>>> wrote:
> >>>>>>>
> >>>>>>>> commons-collections4-4.3-src.zip.sha256This is a [VOTE] for
> >>>>>>> releasing
> >>>>>>>> Apache Commons collections 4.3
> >>>>>>>>
> >>>>>>>> Tag name:
> >>>>>>>> collections-4.3-RC1 (signature can be checked from git using
> >>>> 'git
> >>>>>>> tag -v')
> >>>>>>>>
> >>>>>>>> Tag URL:
> >>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>
> >>
> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4d1e1fff27167f803
> >>>>>>>>
> >>>>>>>> Commit ID the tag points at:
> >>>>>>>>    5f959fd8e77bf28f6286cfb4d1e1fff27167f803
> >>>>>>>>
> >>>>>>>> Site:
> >>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>
> >>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/index.html
> >>>>>>>>
> >>>>>>>> Distribution files (committed at revision 31605):
> >>>>>>>>
> >>>> https://dist.apache.org/repos/dist/dev/commons/collections/
> >>>>>>>>
> >>>>>>>> Distribution files hashes (SHA256):
> >>>>>>>>
> >>>>>>> 201e1d527c67643b4e75065e113006d0610e8bf5620b4e056a2e044f3676df12
> >>>>>>>> commons-collections4-4.3-bin.tar.gz
> >>>>>>>>
> >>>>>>> 706a0f5b4ddfd85e5444933576ea37776219748973bf4fc3944d846823f79395
> >>>>>>>> commons-collections4-4.3-bin.zip
> >>>>>>>>
> >>>>>>> 7a18a39b8b24d8688400276388d5c63da448ee7a8166561a5cffb617b952ed96
> >>>>>>>> commons-collections4-4.3-src.tar.gz
> >>>>>>>>
> >>>>>>> 8a7b3ccd3fb2ba7edde7e08aa7606b3eacef260eab887358c56473a9e395067a
> >>>>>>>> commons-collections4-4.3-src.zip
> >>>>>>>>
> >>>>>>>> KEYS file to check signatures:
> >>>>>>>>    https://www.apache.org/dist/commons/KEYS
> >>>>>>>>
> >>>>>>>> Maven artifacts:
> >>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-1401/
> >>>>>>>>
> >>>>>>>> Please select one of the following options:
> >>>>>>>>  [ ] +1 Release it.
> >>>>>>>>  [ ] +0 Go ahead; I don't care.
> >>>>>>>>  [ ] -0 There are a few minor glitches: ...
> >>>>>>>>  [ ] -1 No, do not release it because ...
> >>>>>>>>
> >>>>>>>> This vote will be open for at least 72 hours, i.e. until
> >>>>>>>> 2018-12-22T14:00:00Z
> >>>>>>>> (this is UTC time).
> >>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>> ---------------------------------------------------------------------
> >>>>>>>> To unsubscribe, e-mail: [hidden email]
> >>>>>>>> For additional commands, e-mail: [hidden email]
> >>>>>>>>
> >>>>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> --
> >>>>>> WBR
> >>>>>> Maxim aka solomax
> >>>>>>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
> >>
> >
> > --
> > WBR
> > Maxim aka solomax
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

--
WBR
Maxim aka solomax
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC1] Commons collections 4.3

Gilles Sadowski
Hi.

On Wed, 26 Dec 2018 08:23:03 +0700, Maxim Solodovnik wrote:
> This is the way Wicketstuff build is performed [1]
> The project consist of ~285 modules and it is wise to create tag only
> if
> build is already in Nexus :)
>
> [1]
>
> https://github.com/wicketstuff/core/wiki/Wicket-Stuff-Core-Release-Process

I get it now!
So indeed, a "release" branch that is pushed upstream is not
necessary.[1]

And there is another couple of improvements which I could use
next time.

Thanks for sharing,
Gilles

[1] It might become useful only if the RC has problems _and_
     other people want to help with fixing (?).

>
> On Wed, 26 Dec 2018 at 08:11, Rob Tompkins <[hidden email]>
> wrote:
>
>>
>>
>> > On Dec 25, 2018, at 8:04 PM, Maxim Solodovnik
>> <[hidden email]>
>> wrote:
>> >
>> > In both git and svn you need a branch to create tag
>> > But since git has local and remote repository, steps can be:
>> >
>> > 1) create local branch
>> > 2) made "release" changes
>> > 3) create tag
>> > 4) push the tag
>> >
>> > In this case only tag will be pushed, and there will be no useless
>> branches
>> > with minimal "release" changes
>> >
>>
>> Yes that is true. But so long as the vote has yet to be initiated,
>> the tag
>> can be pushed even after the build has been made.
>>
>> -Rob
>>
>> >> On Wed, 26 Dec 2018 at 05:40, Gilles
>> <[hidden email]>
>> wrote:
>> >>
>> >> Hi.
>> >>
>> >>> On Tue, 25 Dec 2018 22:22:43 +0700, Maxim Solodovnik wrote:
>> >>> Hello Gilles,
>> >>>
>> >>> Actually if release is made based on git it is not necessary to
>> >>> perform commits
>> >>
>> >> ?
>> >> I don't know other ways to perform the release; I follow
>> >> the practice established for "svn", that was then adapted
>> >> for "git" when we switched to it.
>> >>
>> >> Do you propose an alternative way to do it?  Please
>> >> share some link describing the process
>> >>
>>>> [...]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]