[VOTE][RC2] Commons collections 4.3 (take 2)

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE][RC2] Commons collections 4.3 (take 2)

Maxim Solodovnik
This is a [VOTE] for releasing
Apache Commons collections 4.3

Tag name:
    collections-4.3-RC2 (signature can be checked from git using 'git tag
-v')

Previous RC2 VOTE was canceled due to long discussion regarding
Clirr report [1]. To resolve this Japicmp report has been created [2] as
well
simple test displaying everything is OK [3]

Tag URL:

https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01

Commit ID the tag points at:
    77e37dbf238d26351edb29e95391e3df75095d01

Site:

https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html

Distribution files (committed at revision 31689):
    https://dist.apache.org/repos/dist/dev/commons/collections/

Distribution files hashes (SHA256):
  commons-collections4-4.3-bin.tar.gz
    214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
  commons-collections4-4.3-bin.zip
    75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
  commons-collections4-4.3-src.tar.gz
    399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
  commons-collections4-4.3-src.zip
    1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3

KEYS file to check signatures:
    https://www.apache.org/dist/commons/KEYS

Maven artifacts:

https://repository.apache.org/content/repositories/orgapachecommons-1405/

Please select one of the following options:
  [ ] +1 Release it.
  [ ] +0 Go ahead; I don't care.
  [ ] -0 There are a few minor glitches: ...
  [ ] -1 No, do not release it because ...

This vote will be open for at least 72 hours, i.e. until
2019-02-03T00:00:00Z
(this is UTC time).

[1]
https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
[2]
https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/japicmp.html
[3] https://gist.github.com/solomax/a6fbec6db71bb28dfe53afc566086505
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3 (take 2)

Rob Tompkins
Doh…pardon the noise….reading through the emails just now.

+1 (binding)
signatures all match, rat, good, java8, java11 both work with tests (Assuming you upversion jacoco for 11), and I believe that with japicmp, the clirr failures are no longer valid.

-Rob




> On Jan 31, 2019, at 6:23 AM, Maxim Solodovnik <[hidden email]> wrote:
>
> This is a [VOTE] for releasing
> Apache Commons collections 4.3
>
> Tag name:
>    collections-4.3-RC2 (signature can be checked from git using 'git tag
> -v')
>
> Previous RC2 VOTE was canceled due to long discussion regarding
> Clirr report [1]. To resolve this Japicmp report has been created [2] as
> well
> simple test displaying everything is OK [3]
>
> Tag URL:
>
> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
>
> Commit ID the tag points at:
>    77e37dbf238d26351edb29e95391e3df75095d01
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
>
> Distribution files (committed at revision 31689):
>    https://dist.apache.org/repos/dist/dev/commons/collections/
>
> Distribution files hashes (SHA256):
>  commons-collections4-4.3-bin.tar.gz
>    214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
>  commons-collections4-4.3-bin.zip
>    75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
>  commons-collections4-4.3-src.tar.gz
>    399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
>  commons-collections4-4.3-src.zip
>    1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
>
> KEYS file to check signatures:
>    https://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1405/
>
> Please select one of the following options:
>  [ ] +1 Release it.
>  [ ] +0 Go ahead; I don't care.
>  [ ] -0 There are a few minor glitches: ...
>  [ ] -1 No, do not release it because ...
>
> This vote will be open for at least 72 hours, i.e. until
> 2019-02-03T00:00:00Z
> (this is UTC time).
>
> [1]
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
> [2]
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/japicmp.html
> [3] https://gist.github.com/solomax/a6fbec6db71bb28dfe53afc566086505


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3 (take 2)

garydgregory
In reply to this post by Maxim Solodovnik
+1

From the RC tag:

RAT Check OK.

Building on Java 11 OK with: mvn -V clean package site
-Dcommons.jacoco.version=0.8.3

Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
2018-10-24T14:41:47-04:00)
Maven home: C:\Java\apache-maven-3.6.0\bin\..
Java version: 11.0.2, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk-11.0.2
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

The commons.jacoco.version property is needed on Java 11 to make site
building work.

Building on Java 8 OK:

Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
2018-10-24T14:41:47-04:00)
Maven home: C:\Java\apache-maven-3.6.0\bin\..
Java version: 1.8.0_202, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_202\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Clirr failures are actually false positives:

[INFO] --- clirr-maven-plugin:2.8:check (default-cli) @
commons-collections4 ---
[INFO] Comparing to version: 4.2
[ERROR] 7012: org.apache.commons.collections4.BidiMap: Method 'public
java.util.Collection values()' has been added to an interface
[ERROR] 7012: org.apache.commons.collections4.ListValuedMap: Method 'public
java.util.Collection get(java.lang.Object)' has been added to an interface
[ERROR] 7012: org.apache.commons.collections4.ListValuedMap: Method 'public
java.util.Collection remove(java.lang.Object)' has been added to an
interface
[ERROR] 7012: org.apache.commons.collections4.OrderedBidiMap: Method
'public org.apache.commons.collections4.BidiMap inverseBidiMap()' has been
added to an interface
[ERROR] 7012: org.apache.commons.collections4.OrderedMap: Method 'public
org.apache.commons.collections4.MapIterator mapIterator()' has been added
to an interface
[ERROR] 7012: org.apache.commons.collections4.SetValuedMap: Method 'public
java.util.Collection get(java.lang.Object)' has been added to an interface
[ERROR] 7012: org.apache.commons.collections4.SetValuedMap: Method 'public
java.util.Collection remove(java.lang.Object)' has been added to an
interface
[ERROR] 7012: org.apache.commons.collections4.SortedBidiMap: Method 'public
org.apache.commons.collections4.OrderedBidiMap inverseBidiMap()' has been
added to an interface
[ERROR] 7012: org.apache.commons.collections4.SortedBidiMap: Method 'public
org.apache.commons.collections4.BidiMap inverseBidiMap()' has been added to
an interface

Gary



On Thu, Jan 31, 2019 at 6:23 AM Maxim Solodovnik <[hidden email]>
wrote:

> This is a [VOTE] for releasing
> Apache Commons collections 4.3
>
> Tag name:
>     collections-4.3-RC2 (signature can be checked from git using 'git tag
> -v')
>
> Previous RC2 VOTE was canceled due to long discussion regarding
> Clirr report [1]. To resolve this Japicmp report has been created [2] as
> well
> simple test displaying everything is OK [3]
>
> Tag URL:
>
>
> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
>
> Commit ID the tag points at:
>     77e37dbf238d26351edb29e95391e3df75095d01
>
> Site:
>
>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
>
> Distribution files (committed at revision 31689):
>     https://dist.apache.org/repos/dist/dev/commons/collections/
>
> Distribution files hashes (SHA256):
>   commons-collections4-4.3-bin.tar.gz
>     214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
>   commons-collections4-4.3-bin.zip
>     75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
>   commons-collections4-4.3-src.tar.gz
>     399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
>   commons-collections4-4.3-src.zip
>     1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
>
> KEYS file to check signatures:
>     https://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1405/
>
> Please select one of the following options:
>   [ ] +1 Release it.
>   [ ] +0 Go ahead; I don't care.
>   [ ] -0 There are a few minor glitches: ...
>   [ ] -1 No, do not release it because ...
>
> This vote will be open for at least 72 hours, i.e. until
> 2019-02-03T00:00:00Z
> (this is UTC time).
>
> [1]
>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
> [2]
>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/japicmp.html
> [3] https://gist.github.com/solomax/a6fbec6db71bb28dfe53afc566086505
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3 (take 2)

Gilles Sadowski-2
In reply to this post by Maxim Solodovnik
Hi.

Le jeu. 31 janv. 2019 à 12:23, Maxim Solodovnik <[hidden email]> a écrit :

>
> This is a [VOTE] for releasing
> Apache Commons collections 4.3
>
> Tag name:
>     collections-4.3-RC2 (signature can be checked from git using 'git tag
> -v')
>
> Previous RC2 VOTE was canceled due to long discussion regarding
> Clirr report [1]. To resolve this Japicmp report has been created [2] as
> well
> simple test displaying everything is OK [3]
>
> Tag URL:
>
> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
>
> Commit ID the tag points at:
>     77e37dbf238d26351edb29e95391e3df75095d01
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html

There are CheckStyle issues (we usually clean that up).
There are FindBugs issues (one is tagged as "high" priority).

> Distribution files (committed at revision 31689):
>     https://dist.apache.org/repos/dist/dev/commons/collections/
>
> Distribution files hashes (SHA256):
>   commons-collections4-4.3-bin.tar.gz
>     214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
>   commons-collections4-4.3-bin.zip
>     75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
>   commons-collections4-4.3-src.tar.gz
>     399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
>   commons-collections4-4.3-src.zip
>     1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3

Checksums (of source archives): OK

Suggestion for release plugin developers: create a single checksums report
file (with properly formatted lines: <checksum> <filename>).

>
> KEYS file to check signatures:
>     https://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1405/

They are there. ;-)
Not sure whether/how we may test.
Again, automated tests can perhaps be performed by the release
plugin (e.g. download the "source" and "test" JARs, unpack in a
clean temp dir, run the build, and produce a report relating build and
artefacts for reviewers to evaluate).

> Please select one of the following options:
   [X] +1 Release it.
>   [ ] +0 Go ahead; I don't care.
>   [ ] -0 There are a few minor glitches: ...
>   [ ] -1 No, do not release it because ...

Regards,
Gilles

> This vote will be open for at least 72 hours, i.e. until
> 2019-02-03T00:00:00Z
> (this is UTC time).
>
> [1]
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
> [2]
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/japicmp.html
> [3] https://gist.github.com/solomax/a6fbec6db71bb28dfe53afc566086505

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[RESULT][VOTE][RC2] Commons collections 4.3 (take 2)

Maxim Solodovnik
Hello All,

I'm closing the VOTE, 72 hours are over
The VOTE was successful, it receives 3 binding +1 Rob Tompkins, Gary
Gregory, Gilles Sadowski


On Fri, 1 Feb 2019 at 20:49, Gilles Sadowski <[hidden email]> wrote:

>
> Hi.
>
> Le jeu. 31 janv. 2019 à 12:23, Maxim Solodovnik <[hidden email]> a écrit :
> >
> > This is a [VOTE] for releasing
> > Apache Commons collections 4.3
> >
> > Tag name:
> >     collections-4.3-RC2 (signature can be checked from git using 'git tag
> > -v')
> >
> > Previous RC2 VOTE was canceled due to long discussion regarding
> > Clirr report [1]. To resolve this Japicmp report has been created [2] as
> > well
> > simple test displaying everything is OK [3]
> >
> > Tag URL:
> >
> > https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
> >
> > Commit ID the tag points at:
> >     77e37dbf238d26351edb29e95391e3df75095d01
> >
> > Site:
> >
> > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
>
> There are CheckStyle issues (we usually clean that up).
> There are FindBugs issues (one is tagged as "high" priority).
>
> > Distribution files (committed at revision 31689):
> >     https://dist.apache.org/repos/dist/dev/commons/collections/
> >
> > Distribution files hashes (SHA256):
> >   commons-collections4-4.3-bin.tar.gz
> >     214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
> >   commons-collections4-4.3-bin.zip
> >     75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
> >   commons-collections4-4.3-src.tar.gz
> >     399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
> >   commons-collections4-4.3-src.zip
> >     1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
>
> Checksums (of source archives): OK
>
> Suggestion for release plugin developers: create a single checksums report
> file (with properly formatted lines: <checksum> <filename>).
>
> >
> > KEYS file to check signatures:
> >     https://www.apache.org/dist/commons/KEYS
> >
> > Maven artifacts:
> >
> > https://repository.apache.org/content/repositories/orgapachecommons-1405/
>
> They are there. ;-)
> Not sure whether/how we may test.
> Again, automated tests can perhaps be performed by the release
> plugin (e.g. download the "source" and "test" JARs, unpack in a
> clean temp dir, run the build, and produce a report relating build and
> artefacts for reviewers to evaluate).
>
> > Please select one of the following options:
>    [X] +1 Release it.
> >   [ ] +0 Go ahead; I don't care.
> >   [ ] -0 There are a few minor glitches: ...
> >   [ ] -1 No, do not release it because ...
>
> Regards,
> Gilles
>
> > This vote will be open for at least 72 hours, i.e. until
> > 2019-02-03T00:00:00Z
> > (this is UTC time).
> >
> > [1]
> > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
> > [2]
> > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/japicmp.html
> > [3] https://gist.github.com/solomax/a6fbec6db71bb28dfe53afc566086505
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


--
WBR
Maxim aka solomax

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]