[VOTE][RC2] Commons collections 4.3

classic Classic list List threaded Threaded
71 messages Options
1234
Reply | Threaded
Open this post in threaded view
|

[VOTE][RC2] Commons collections 4.3

Maxim Solodovnik
This is a [VOTE] for releasing
Apache Commons collections 4.3

Tag name:
    collections-4.3-RC2 (signature can be checked from git using 'git tag -v')
RC1 was cancelled due to some release steps were not done

Tag URL:
    https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01

Commit ID the tag points at:
    77e37dbf238d26351edb29e95391e3df75095d01

Site:
    https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html

Distribution files (committed at revision 31689):
    https://dist.apache.org/repos/dist/dev/commons/collections/

Distribution files hashes (SHA256):
  commons-collections4-4.3-bin.tar.gz
    214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
  commons-collections4-4.3-bin.zip
    75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
  commons-collections4-4.3-src.tar.gz
    399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
  commons-collections4-4.3-src.zip
    1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3

KEYS file to check signatures:
    https://www.apache.org/dist/commons/KEYS

Maven artifacts:
    https://repository.apache.org/content/repositories/orgapachecommons-1405/

Please select one of the following options:
  [ ] +1 Release it.
  [ ] +0 Go ahead; I don't care.
  [ ] -0 There are a few minor glitches: ...
  [ ] -1 No, do not release it because ...

This vote will be open for at least 72 hours, i.e. until 2018-12-29T14:00:00Z
(this is UTC time).

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

Gilles Sadowski
Hi.

On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
> This is a [VOTE] for releasing
> Apache Commons collections 4.3
>
> Tag name:
>     collections-4.3-RC2 (signature can be checked from git using 'git
> tag -v')

$ git tag -v collections-4.3-RC2
error: tag 'collections-4.3-RC2' not found.

Although I see it in the link below...
What is going on?

> RC1 was cancelled due to some release steps were not done
>
> Tag URL:
>
>
> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
>
> Commit ID the tag points at:
>     77e37dbf238d26351edb29e95391e3df75095d01
>
> Site:
>
>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html

The Clirr report is still a problem:
   
https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html

[The same errors are reported on my machine, so it's
not a cache issue...]

Regards,
Gilles

>
> Distribution files (committed at revision 31689):
>     https://dist.apache.org/repos/dist/dev/commons/collections/
>
> Distribution files hashes (SHA256):
>   commons-collections4-4.3-bin.tar.gz
>     214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
>   commons-collections4-4.3-bin.zip
>     75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
>   commons-collections4-4.3-src.tar.gz
>     399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
>   commons-collections4-4.3-src.zip
>     1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
>
> KEYS file to check signatures:
>     https://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
>    
> https://repository.apache.org/content/repositories/orgapachecommons-1405/
>
> Please select one of the following options:
>   [ ] +1 Release it.
>   [ ] +0 Go ahead; I don't care.
>   [ ] -0 There are a few minor glitches: ...
>   [ ] -1 No, do not release it because ...
>
> This vote will be open for at least 72 hours, i.e. until
> 2018-12-29T14:00:00Z
> (this is UTC time).
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

Gilles Sadowski
On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:

> Hi.
>
> On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
>> This is a [VOTE] for releasing
>> Apache Commons collections 4.3
>>
>> Tag name:
>>     collections-4.3-RC2 (signature can be checked from git using
>> 'git
>> tag -v')
>
> $ git tag -v collections-4.3-RC2
> error: tag 'collections-4.3-RC2' not found.
>
> Although I see it in the link below...
> What is going on?

Issue vanished with a fresh "clone".
[Sorry for the noise.]

>> RC1 was cancelled due to some release steps were not done
>>
>> Tag URL:
>>
>>
>> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
>>
>> Commit ID the tag points at:
>>     77e37dbf238d26351edb29e95391e3df75095d01
>>
>> Site:
>>
>>
>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
>
> The Clirr report is still a problem:
>
>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
>
> [The same errors are reported on my machine, so it's
> not a cache issue...]
>
> Regards,
> Gilles
>
>>
>> Distribution files (committed at revision 31689):
>>     https://dist.apache.org/repos/dist/dev/commons/collections/
>>
>> Distribution files hashes (SHA256):
>>   commons-collections4-4.3-bin.tar.gz
>>     214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
>>   commons-collections4-4.3-bin.zip
>>     75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
>>   commons-collections4-4.3-src.tar.gz
>>     399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
>>   commons-collections4-4.3-src.zip
>>     1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
>>
>> KEYS file to check signatures:
>>     https://www.apache.org/dist/commons/KEYS
>>
>> Maven artifacts:
>>    
>> https://repository.apache.org/content/repositories/orgapachecommons-1405/
>>
>> Please select one of the following options:
>>   [ ] +1 Release it.
>>   [ ] +0 Go ahead; I don't care.
>>   [ ] -0 There are a few minor glitches: ...
>>   [ ] -1 No, do not release it because ...
>>
>> This vote will be open for at least 72 hours, i.e. until
>> 2018-12-29T14:00:00Z
>> (this is UTC time).
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

Bruno P. Kinoshita-2
FWIW I had a similar experience, and realized I was doing `git fetch --all`, but it didn't bring the tags. `git fetch --tags` did the trick. After that I could `git checkout $tag-name`

Cheers
Bruno




________________________________
From: Gilles <[hidden email]>
To: [hidden email]
Sent: Thursday, 27 December 2018 9:26 AM
Subject: Re: [VOTE][RC2] Commons collections 4.3



On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:

> Hi.
>
> On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
>> This is a [VOTE] for releasing
>> Apache Commons collections 4.3
>>
>> Tag name:
>>     collections-4.3-RC2 (signature can be checked from git using
>> 'git
>> tag -v')
>
> $ git tag -v collections-4.3-RC2
> error: tag 'collections-4.3-RC2' not found.
>
> Although I see it in the link below...
> What is going on?

Issue vanished with a fresh "clone".
[Sorry for the noise.]


>> RC1 was cancelled due to some release steps were not done
>>
>> Tag URL:
>>
>>
>> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
>>
>> Commit ID the tag points at:
>>     77e37dbf238d26351edb29e95391e3df75095d01
>>
>> Site:
>>
>>
>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
>
> The Clirr report is still a problem:
>
>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
>
> [The same errors are reported on my machine, so it's
> not a cache issue...]
>
> Regards,
> Gilles
>
>>
>> Distribution files (committed at revision 31689):
>>    https://dist.apache.org/repos/dist/dev/commons/collections/
>>
>> Distribution files hashes (SHA256):
>>   commons-collections4-4.3-bin.tar.gz
>>     214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
>>   commons-collections4-4.3-bin.zip
>>     75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
>>   commons-collections4-4.3-src.tar.gz
>>     399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
>>   commons-collections4-4.3-src.zip
>>     1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
>>
>> KEYS file to check signatures:
>>    https://www.apache.org/dist/commons/KEYS
>>
>> Maven artifacts:
>>    
>> https://repository.apache.org/content/repositories/orgapachecommons-1405/
>>
>> Please select one of the following options:
>>   [ ] +1 Release it.
>>   [ ] +0 Go ahead; I don't care.
>>   [ ] -0 There are a few minor glitches: ...
>>   [ ] -1 No, do not release it because ...
>>
>> This vote will be open for at least 72 hours, i.e. until
>> 2018-12-29T14:00:00Z
>> (this is UTC time).
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

Maxim Solodovnik
No votes after 3 days :(
Is there anything wrong with the RC?

On Thu, 27 Dec 2018 at 05:20, Bruno P. Kinoshita <[hidden email]> wrote:

>
> FWIW I had a similar experience, and realized I was doing `git fetch --all`, but it didn't bring the tags. `git fetch --tags` did the trick. After that I could `git checkout $tag-name`
>
> Cheers
> Bruno
>
>
>
>
> ________________________________
> From: Gilles <[hidden email]>
> To: [hidden email]
> Sent: Thursday, 27 December 2018 9:26 AM
> Subject: Re: [VOTE][RC2] Commons collections 4.3
>
>
>
> On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
> > Hi.
> >
> > On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
> >> This is a [VOTE] for releasing
> >> Apache Commons collections 4.3
> >>
> >> Tag name:
> >>     collections-4.3-RC2 (signature can be checked from git using
> >> 'git
> >> tag -v')
> >
> > $ git tag -v collections-4.3-RC2
> > error: tag 'collections-4.3-RC2' not found.
> >
> > Although I see it in the link below...
> > What is going on?
>
> Issue vanished with a fresh "clone".
> [Sorry for the noise.]
>
>
> >> RC1 was cancelled due to some release steps were not done
> >>
> >> Tag URL:
> >>
> >>
> >> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
> >>
> >> Commit ID the tag points at:
> >>     77e37dbf238d26351edb29e95391e3df75095d01
> >>
> >> Site:
> >>
> >>
> >> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
> >
> > The Clirr report is still a problem:
> >
> >
> > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
> >
> > [The same errors are reported on my machine, so it's
> > not a cache issue...]
> >
> > Regards,
> > Gilles
> >
> >>
> >> Distribution files (committed at revision 31689):
> >>    https://dist.apache.org/repos/dist/dev/commons/collections/
> >>
> >> Distribution files hashes (SHA256):
> >>   commons-collections4-4.3-bin.tar.gz
> >>     214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
> >>   commons-collections4-4.3-bin.zip
> >>     75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
> >>   commons-collections4-4.3-src.tar.gz
> >>     399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
> >>   commons-collections4-4.3-src.zip
> >>     1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
> >>
> >> KEYS file to check signatures:
> >>    https://www.apache.org/dist/commons/KEYS
> >>
> >> Maven artifacts:
> >>
> >> https://repository.apache.org/content/repositories/orgapachecommons-1405/
> >>
> >> Please select one of the following options:
> >>   [ ] +1 Release it.
> >>   [ ] +0 Go ahead; I don't care.
> >>   [ ] -0 There are a few minor glitches: ...
> >>   [ ] -1 No, do not release it because ...
> >>
> >> This vote will be open for at least 72 hours, i.e. until
> >> 2018-12-29T14:00:00Z
> >> (this is UTC time).
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


--
WBR
Maxim aka solomax

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

Bruno P. Kinoshita-2
I got confused by vote/cancel threads, but the RC should be good. Will check what's the latest vote thread, sorry.
And I guess the lack of votes right now is probably due to holidays (:

CheersBruno

      From: Maxim Solodovnik <[hidden email]>
 To: Commons Developers List <[hidden email]>; Bruno P. Kinoshita <[hidden email]>
 Sent: Sunday, 30 December 2018 6:26 PM
 Subject: Re: [VOTE][RC2] Commons collections 4.3
   
No votes after 3 days :(
Is there anything wrong with the RC?

On Thu, 27 Dec 2018 at 05:20, Bruno P. Kinoshita <[hidden email]> wrote:

>
> FWIW I had a similar experience, and realized I was doing `git fetch --all`, but it didn't bring the tags. `git fetch --tags` did the trick. After that I could `git checkout $tag-name`
>
> Cheers
> Bruno
>
>
>
>
> ________________________________
> From: Gilles <[hidden email]>
> To: [hidden email]
> Sent: Thursday, 27 December 2018 9:26 AM
> Subject: Re: [VOTE][RC2] Commons collections 4.3
>
>
>
> On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
> > Hi.
> >
> > On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
> >> This is a [VOTE] for releasing
> >> Apache Commons collections 4.3
> >>
> >> Tag name:
> >>    collections-4.3-RC2 (signature can be checked from git using
> >> 'git
> >> tag -v')
> >
> > $ git tag -v collections-4.3-RC2
> > error: tag 'collections-4.3-RC2' not found.
> >
> > Although I see it in the link below...
> > What is going on?
>
> Issue vanished with a fresh "clone".
> [Sorry for the noise.]
>
>
> >> RC1 was cancelled due to some release steps were not done
> >>
> >> Tag URL:
> >>
> >>
> >> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
> >>
> >> Commit ID the tag points at:
> >>    77e37dbf238d26351edb29e95391e3df75095d01
> >>
> >> Site:
> >>
> >>
> >> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
> >
> > The Clirr report is still a problem:
> >
> >
> > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
> >
> > [The same errors are reported on my machine, so it's
> > not a cache issue...]
> >
> > Regards,
> > Gilles
> >
> >>
> >> Distribution files (committed at revision 31689):
> >>    https://dist.apache.org/repos/dist/dev/commons/collections/
> >>
> >> Distribution files hashes (SHA256):
> >>  commons-collections4-4.3-bin.tar.gz
> >>    214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
> >>  commons-collections4-4.3-bin.zip
> >>    75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
> >>  commons-collections4-4.3-src.tar.gz
> >>    399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
> >>  commons-collections4-4.3-src.zip
> >>    1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
> >>
> >> KEYS file to check signatures:
> >>    https://www.apache.org/dist/commons/KEYS
> >>
> >> Maven artifacts:
> >>
> >> https://repository.apache.org/content/repositories/orgapachecommons-1405/
> >>
> >> Please select one of the following options:
> >>  [ ] +1 Release it.
> >>  [ ] +0 Go ahead; I don't care.
> >>  [ ] -0 There are a few minor glitches: ...
> >>  [ ] -1 No, do not release it because ...
> >>
> >> This vote will be open for at least 72 hours, i.e. until
> >> 2018-12-29T14:00:00Z
> >> (this is UTC time).
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


--
WBR
Maxim aka solomax

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]



   
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

Bruno P. Kinoshita-2
In reply to this post by Maxim Solodovnik
[ x ] +1 Release it.

Build from tag passing on Ubuntu LTS Java 8 with mvn clean test install site on

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T06:33:14+12:00)
Maven home: /opt/apache-maven-3.5.4
Java version: 1.8.0_191, vendor: Oracle Corporation, runtime: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_NZ, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-43-generic", arch: "amd64", family: "unix"


One easy new issue in PMD, regarding the constructor of an enum marked as private. Also two new checkstyle issues that can be easily fixed later. (sending pull requests in a bit)
Change reported generated OK.

Had a look inside the binaries in the dist area, and check some signatures for Maven and dist artefacts. Everything looking OK.

Thanks for RM'ing, and happy holidays!

Bruno







________________________________
From: Maxim Solodovnik <[hidden email]>
To: Commons Developers List <[hidden email]>
Sent: Thursday, 27 December 2018 2:42 AM
Subject: [VOTE][RC2] Commons collections 4.3



This is a [VOTE] for releasing

Apache Commons collections 4.3


Tag name:

    collections-4.3-RC2 (signature can be checked from git using 'git tag -v')

RC1 was cancelled due to some release steps were not done


Tag URL:

    https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01


Commit ID the tag points at:

    77e37dbf238d26351edb29e95391e3df75095d01


Site:

    https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html


Distribution files (committed at revision 31689):

    https://dist.apache.org/repos/dist/dev/commons/collections/


Distribution files hashes (SHA256):

  commons-collections4-4.3-bin.tar.gz

    214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94

  commons-collections4-4.3-bin.zip

    75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb

  commons-collections4-4.3-src.tar.gz

    399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434

  commons-collections4-4.3-src.zip

    1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3


KEYS file to check signatures:

    https://www.apache.org/dist/commons/KEYS


Maven artifacts:

    https://repository.apache.org/content/repositories/orgapachecommons-1405/


Please select one of the following options:

  [ ] +1 Release it.

  [ ] +0 Go ahead; I don't care.

  [ ] -0 There are a few minor glitches: ...

  [ ] -1 No, do not release it because ...


This vote will be open for at least 72 hours, i.e. until 2018-12-29T14:00:00Z

(this is UTC time).


---------------------------------------------------------------------

To unsubscribe, e-mail: [hidden email]

For additional commands, e-mail: [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

Gilles Sadowski
In reply to this post by Maxim Solodovnik
On Sun, 30 Dec 2018 12:25:55 +0700, Maxim Solodovnik wrote:
> No votes after 3 days :(
> Is there anything wrong with the RC?

See my 4-days-old comment in the thread (Clirr errors).
[Quoted below.]

Regards,
Gilles

>
> On Thu, 27 Dec 2018 at 05:20, Bruno P. Kinoshita <[hidden email]>
> wrote:
>>
>> FWIW I had a similar experience, and realized I was doing `git fetch
>> --all`, but it didn't bring the tags. `git fetch --tags` did the
>> trick. After that I could `git checkout $tag-name`
>>
>> Cheers
>> Bruno
>>
>>
>>
>>
>> ________________________________
>> From: Gilles <[hidden email]>
>> To: [hidden email]
>> Sent: Thursday, 27 December 2018 9:26 AM
>> Subject: Re: [VOTE][RC2] Commons collections 4.3
>>
>>
>>
>> On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
>> > Hi.
>> >
>> > On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
>> >> This is a [VOTE] for releasing
>> >> Apache Commons collections 4.3
>> >>
>> >> Tag name:
>> >>     collections-4.3-RC2 (signature can be checked from git using
>> >> 'git
>> >> tag -v')
>> >
>> > $ git tag -v collections-4.3-RC2
>> > error: tag 'collections-4.3-RC2' not found.
>> >
>> > Although I see it in the link below...
>> > What is going on?
>>
>> Issue vanished with a fresh "clone".
>> [Sorry for the noise.]
>>
>>
>> >> RC1 was cancelled due to some release steps were not done
>> >>
>> >> Tag URL:
>> >>
>> >>
>> >>
>> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
>> >>
>> >> Commit ID the tag points at:
>> >>     77e37dbf238d26351edb29e95391e3df75095d01
>> >>
>> >> Site:
>> >>
>> >>
>> >>
>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
>> >
>> > The Clirr report is still a problem:
>> >
>> >
>> >
>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
>> >
>> > [The same errors are reported on my machine, so it's
>> > not a cache issue...]
>> >
>> > Regards,
>> > Gilles
>> >
>> >>
>> >> Distribution files (committed at revision 31689):
>> >>    https://dist.apache.org/repos/dist/dev/commons/collections/
>> >>
>> >> Distribution files hashes (SHA256):
>> >>   commons-collections4-4.3-bin.tar.gz
>> >>    
>> 214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
>> >>   commons-collections4-4.3-bin.zip
>> >>    
>> 75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
>> >>   commons-collections4-4.3-src.tar.gz
>> >>    
>> 399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
>> >>   commons-collections4-4.3-src.zip
>> >>    
>> 1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
>> >>
>> >> KEYS file to check signatures:
>> >>    https://www.apache.org/dist/commons/KEYS
>> >>
>> >> Maven artifacts:
>> >>
>> >>
>> https://repository.apache.org/content/repositories/orgapachecommons-1405/
>> >>
>> >> Please select one of the following options:
>> >>   [ ] +1 Release it.
>> >>   [ ] +0 Go ahead; I don't care.
>> >>   [ ] -0 There are a few minor glitches: ...
>> >>   [ ] -1 No, do not release it because ...
>> >>
>> >> This vote will be open for at least 72 hours, i.e. until
>> >> 2018-12-29T14:00:00Z
>> >> (this is UTC time).
>> >>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

Rob Tompkins
In reply to this post by Maxim Solodovnik
I’ll give it a look tonight or in the morning.

-Rob

> On Dec 30, 2018, at 12:25 AM, Maxim Solodovnik <[hidden email]> wrote:
>
> No votes after 3 days :(
> Is there anything wrong with the RC?
>
>> On Thu, 27 Dec 2018 at 05:20, Bruno P. Kinoshita <[hidden email]> wrote:
>>
>> FWIW I had a similar experience, and realized I was doing `git fetch --all`, but it didn't bring the tags. `git fetch --tags` did the trick. After that I could `git checkout $tag-name`
>>
>> Cheers
>> Bruno
>>
>>
>>
>>
>> ________________________________
>> From: Gilles <[hidden email]>
>> To: [hidden email]
>> Sent: Thursday, 27 December 2018 9:26 AM
>> Subject: Re: [VOTE][RC2] Commons collections 4.3
>>
>>
>>
>>> On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
>>> Hi.
>>>
>>>> On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
>>>> This is a [VOTE] for releasing
>>>> Apache Commons collections 4.3
>>>>
>>>> Tag name:
>>>>    collections-4.3-RC2 (signature can be checked from git using
>>>> 'git
>>>> tag -v')
>>>
>>> $ git tag -v collections-4.3-RC2
>>> error: tag 'collections-4.3-RC2' not found.
>>>
>>> Although I see it in the link below...
>>> What is going on?
>>
>> Issue vanished with a fresh "clone".
>> [Sorry for the noise.]
>>
>>
>>>> RC1 was cancelled due to some release steps were not done
>>>>
>>>> Tag URL:
>>>>
>>>>
>>>> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
>>>>
>>>> Commit ID the tag points at:
>>>>    77e37dbf238d26351edb29e95391e3df75095d01
>>>>
>>>> Site:
>>>>
>>>>
>>>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
>>>
>>> The Clirr report is still a problem:
>>>
>>>
>>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
>>>
>>> [The same errors are reported on my machine, so it's
>>> not a cache issue...]
>>>
>>> Regards,
>>> Gilles
>>>
>>>>
>>>> Distribution files (committed at revision 31689):
>>>>   https://dist.apache.org/repos/dist/dev/commons/collections/
>>>>
>>>> Distribution files hashes (SHA256):
>>>>  commons-collections4-4.3-bin.tar.gz
>>>>    214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
>>>>  commons-collections4-4.3-bin.zip
>>>>    75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
>>>>  commons-collections4-4.3-src.tar.gz
>>>>    399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
>>>>  commons-collections4-4.3-src.zip
>>>>    1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
>>>>
>>>> KEYS file to check signatures:
>>>>   https://www.apache.org/dist/commons/KEYS
>>>>
>>>> Maven artifacts:
>>>>
>>>> https://repository.apache.org/content/repositories/orgapachecommons-1405/
>>>>
>>>> Please select one of the following options:
>>>>  [ ] +1 Release it.
>>>>  [ ] +0 Go ahead; I don't care.
>>>>  [ ] -0 There are a few minor glitches: ...
>>>>  [ ] -1 No, do not release it because ...
>>>>
>>>> This vote will be open for at least 72 hours, i.e. until
>>>> 2018-12-29T14:00:00Z
>>>> (this is UTC time).
>>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
>
> --
> WBR
> Maxim aka solomax
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

Maxim Solodovnik
Hello Gilles,

I already did analysis: [1], all errors are caused by previous release
4.3 doesn't introduce any new errors ...

[1] https://markmail.org/message/l7ftxlvdk4yqxijt

On Mon, 31 Dec 2018 at 07:26, Rob Tompkins <[hidden email]> wrote:

>
> I’ll give it a look tonight or in the morning.
>
> -Rob
>
> > On Dec 30, 2018, at 12:25 AM, Maxim Solodovnik <[hidden email]> wrote:
> >
> > No votes after 3 days :(
> > Is there anything wrong with the RC?
> >
> >> On Thu, 27 Dec 2018 at 05:20, Bruno P. Kinoshita <[hidden email]> wrote:
> >>
> >> FWIW I had a similar experience, and realized I was doing `git fetch --all`, but it didn't bring the tags. `git fetch --tags` did the trick. After that I could `git checkout $tag-name`
> >>
> >> Cheers
> >> Bruno
> >>
> >>
> >>
> >>
> >> ________________________________
> >> From: Gilles <[hidden email]>
> >> To: [hidden email]
> >> Sent: Thursday, 27 December 2018 9:26 AM
> >> Subject: Re: [VOTE][RC2] Commons collections 4.3
> >>
> >>
> >>
> >>> On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
> >>> Hi.
> >>>
> >>>> On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
> >>>> This is a [VOTE] for releasing
> >>>> Apache Commons collections 4.3
> >>>>
> >>>> Tag name:
> >>>>    collections-4.3-RC2 (signature can be checked from git using
> >>>> 'git
> >>>> tag -v')
> >>>
> >>> $ git tag -v collections-4.3-RC2
> >>> error: tag 'collections-4.3-RC2' not found.
> >>>
> >>> Although I see it in the link below...
> >>> What is going on?
> >>
> >> Issue vanished with a fresh "clone".
> >> [Sorry for the noise.]
> >>
> >>
> >>>> RC1 was cancelled due to some release steps were not done
> >>>>
> >>>> Tag URL:
> >>>>
> >>>>
> >>>> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
> >>>>
> >>>> Commit ID the tag points at:
> >>>>    77e37dbf238d26351edb29e95391e3df75095d01
> >>>>
> >>>> Site:
> >>>>
> >>>>
> >>>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
> >>>
> >>> The Clirr report is still a problem:
> >>>
> >>>
> >>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
> >>>
> >>> [The same errors are reported on my machine, so it's
> >>> not a cache issue...]
> >>>
> >>> Regards,
> >>> Gilles
> >>>
> >>>>
> >>>> Distribution files (committed at revision 31689):
> >>>>   https://dist.apache.org/repos/dist/dev/commons/collections/
> >>>>
> >>>> Distribution files hashes (SHA256):
> >>>>  commons-collections4-4.3-bin.tar.gz
> >>>>    214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
> >>>>  commons-collections4-4.3-bin.zip
> >>>>    75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
> >>>>  commons-collections4-4.3-src.tar.gz
> >>>>    399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
> >>>>  commons-collections4-4.3-src.zip
> >>>>    1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
> >>>>
> >>>> KEYS file to check signatures:
> >>>>   https://www.apache.org/dist/commons/KEYS
> >>>>
> >>>> Maven artifacts:
> >>>>
> >>>> https://repository.apache.org/content/repositories/orgapachecommons-1405/
> >>>>
> >>>> Please select one of the following options:
> >>>>  [ ] +1 Release it.
> >>>>  [ ] +0 Go ahead; I don't care.
> >>>>  [ ] -0 There are a few minor glitches: ...
> >>>>  [ ] -1 No, do not release it because ...
> >>>>
> >>>> This vote will be open for at least 72 hours, i.e. until
> >>>> 2018-12-29T14:00:00Z
> >>>> (this is UTC time).
> >>>>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


--
WBR
Maxim aka solomax

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

Gilles Sadowski
On Mon, 31 Dec 2018 07:41:40 +0700, Maxim Solodovnik wrote:
> Hello Gilles,
>
> I already did analysis: [1], all errors are caused by previous
> release
> 4.3 doesn't introduce any new errors ...
>
> [1] https://markmail.org/message/l7ftxlvdk4yqxijt

I had seen the post but it says:
---
these errors are weird. Above classes has no changes comparing to 4.2
---

But IMHO it was not a conclusion: If the cause of the errors was
identified, it could have been mentioned in the release notes
and/or the [VOTE] email, in order to avoid further questioning.

Is the cause the change of supported JDK?

Regards,
Gilles

>
> On Mon, 31 Dec 2018 at 07:26, Rob Tompkins <[hidden email]>
> wrote:
>>
>> I’ll give it a look tonight or in the morning.
>>
>> -Rob
>>
>> > On Dec 30, 2018, at 12:25 AM, Maxim Solodovnik
>> <[hidden email]> wrote:
>> >
>> > No votes after 3 days :(
>> > Is there anything wrong with the RC?
>> >
>> >> On Thu, 27 Dec 2018 at 05:20, Bruno P. Kinoshita
>> <[hidden email]> wrote:
>> >>
>> >> FWIW I had a similar experience, and realized I was doing `git
>> fetch --all`, but it didn't bring the tags. `git fetch --tags` did the
>> trick. After that I could `git checkout $tag-name`
>> >>
>> >> Cheers
>> >> Bruno
>> >>
>> >>
>> >>
>> >>
>> >> ________________________________
>> >> From: Gilles <[hidden email]>
>> >> To: [hidden email]
>> >> Sent: Thursday, 27 December 2018 9:26 AM
>> >> Subject: Re: [VOTE][RC2] Commons collections 4.3
>> >>
>> >>
>> >>
>> >>> On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
>> >>> Hi.
>> >>>
>> >>>> On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
>> >>>> This is a [VOTE] for releasing
>> >>>> Apache Commons collections 4.3
>> >>>>
>> >>>> Tag name:
>> >>>>    collections-4.3-RC2 (signature can be checked from git using
>> >>>> 'git
>> >>>> tag -v')
>> >>>
>> >>> $ git tag -v collections-4.3-RC2
>> >>> error: tag 'collections-4.3-RC2' not found.
>> >>>
>> >>> Although I see it in the link below...
>> >>> What is going on?
>> >>
>> >> Issue vanished with a fresh "clone".
>> >> [Sorry for the noise.]
>> >>
>> >>
>> >>>> RC1 was cancelled due to some release steps were not done
>> >>>>
>> >>>> Tag URL:
>> >>>>
>> >>>>
>> >>>>
>> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
>> >>>>
>> >>>> Commit ID the tag points at:
>> >>>>    77e37dbf238d26351edb29e95391e3df75095d01
>> >>>>
>> >>>> Site:
>> >>>>
>> >>>>
>> >>>>
>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
>> >>>
>> >>> The Clirr report is still a problem:
>> >>>
>> >>>
>> >>>
>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
>> >>>
>> >>> [The same errors are reported on my machine, so it's
>> >>> not a cache issue...]
>> >>>
>> >>> Regards,
>> >>> Gilles
>> >>>
>> >>>>
>> >>>> Distribution files (committed at revision 31689):
>> >>>>   https://dist.apache.org/repos/dist/dev/commons/collections/
>> >>>>
>> >>>> Distribution files hashes (SHA256):
>> >>>>  commons-collections4-4.3-bin.tar.gz
>> >>>>    
>> 214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
>> >>>>  commons-collections4-4.3-bin.zip
>> >>>>    
>> 75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
>> >>>>  commons-collections4-4.3-src.tar.gz
>> >>>>    
>> 399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
>> >>>>  commons-collections4-4.3-src.zip
>> >>>>    
>> 1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
>> >>>>
>> >>>> KEYS file to check signatures:
>> >>>>   https://www.apache.org/dist/commons/KEYS
>> >>>>
>> >>>> Maven artifacts:
>> >>>>
>> >>>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1405/
>> >>>>
>> >>>> Please select one of the following options:
>> >>>>  [ ] +1 Release it.
>> >>>>  [ ] +0 Go ahead; I don't care.
>> >>>>  [ ] -0 There are a few minor glitches: ...
>> >>>>  [ ] -1 No, do not release it because ...
>> >>>>
>> >>>> This vote will be open for at least 72 hours, i.e. until
>> >>>> 2018-12-29T14:00:00Z
>> >>>> (this is UTC time).
>> >>>>
>> >>
>> >>
>> >>
>> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: [hidden email]
>> >> For additional commands, e-mail: [hidden email]
>> >>
>> >>
>> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: [hidden email]
>> >> For additional commands, e-mail: [hidden email]
>> >>
>> >
>> >
>> > --
>> > WBR
>> > Maxim aka solomax
>> >
>> >
>> ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: [hidden email]
>> > For additional commands, e-mail: [hidden email]
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

Maxim Solodovnik
Hello All,

Just checked clirr report one more time
This time I took 1 error and perform investigation:

"Method 'public java.util.Collection values()' has been added to an
interface" org.apache.commons.collections4.BidiMap

In fact I don't understand why this error was reported
BidiMap extends java.util.Map
Map has method "public java.util.Collection values()" in all versions:
https://docs.oracle.com/javase/6/docs/api/java/util/Map.html
https://docs.oracle.com/javase/7/docs/api/java/util/Map.html
https://docs.oracle.com/javase/8/docs/api/java/util/Map.html

Maybe its clirr issue?
Would appreciate any help with this investigation

On Mon, 31 Dec 2018 at 16:53, Gilles <[hidden email]> wrote:

>
> On Mon, 31 Dec 2018 07:41:40 +0700, Maxim Solodovnik wrote:
> > Hello Gilles,
> >
> > I already did analysis: [1], all errors are caused by previous
> > release
> > 4.3 doesn't introduce any new errors ...
> >
> > [1] https://markmail.org/message/l7ftxlvdk4yqxijt
>
> I had seen the post but it says:
> ---
> these errors are weird. Above classes has no changes comparing to 4.2
> ---
>
> But IMHO it was not a conclusion: If the cause of the errors was
> identified, it could have been mentioned in the release notes
> and/or the [VOTE] email, in order to avoid further questioning.
>
> Is the cause the change of supported JDK?
>
> Regards,
> Gilles
>
> >
> > On Mon, 31 Dec 2018 at 07:26, Rob Tompkins <[hidden email]>
> > wrote:
> >>
> >> I’ll give it a look tonight or in the morning.
> >>
> >> -Rob
> >>
> >> > On Dec 30, 2018, at 12:25 AM, Maxim Solodovnik
> >> <[hidden email]> wrote:
> >> >
> >> > No votes after 3 days :(
> >> > Is there anything wrong with the RC?
> >> >
> >> >> On Thu, 27 Dec 2018 at 05:20, Bruno P. Kinoshita
> >> <[hidden email]> wrote:
> >> >>
> >> >> FWIW I had a similar experience, and realized I was doing `git
> >> fetch --all`, but it didn't bring the tags. `git fetch --tags` did the
> >> trick. After that I could `git checkout $tag-name`
> >> >>
> >> >> Cheers
> >> >> Bruno
> >> >>
> >> >>
> >> >>
> >> >>
> >> >> ________________________________
> >> >> From: Gilles <[hidden email]>
> >> >> To: [hidden email]
> >> >> Sent: Thursday, 27 December 2018 9:26 AM
> >> >> Subject: Re: [VOTE][RC2] Commons collections 4.3
> >> >>
> >> >>
> >> >>
> >> >>> On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
> >> >>> Hi.
> >> >>>
> >> >>>> On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
> >> >>>> This is a [VOTE] for releasing
> >> >>>> Apache Commons collections 4.3
> >> >>>>
> >> >>>> Tag name:
> >> >>>>    collections-4.3-RC2 (signature can be checked from git using
> >> >>>> 'git
> >> >>>> tag -v')
> >> >>>
> >> >>> $ git tag -v collections-4.3-RC2
> >> >>> error: tag 'collections-4.3-RC2' not found.
> >> >>>
> >> >>> Although I see it in the link below...
> >> >>> What is going on?
> >> >>
> >> >> Issue vanished with a fresh "clone".
> >> >> [Sorry for the noise.]
> >> >>
> >> >>
> >> >>>> RC1 was cancelled due to some release steps were not done
> >> >>>>
> >> >>>> Tag URL:
> >> >>>>
> >> >>>>
> >> >>>>
> >> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
> >> >>>>
> >> >>>> Commit ID the tag points at:
> >> >>>>    77e37dbf238d26351edb29e95391e3df75095d01
> >> >>>>
> >> >>>> Site:
> >> >>>>
> >> >>>>
> >> >>>>
> >> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
> >> >>>
> >> >>> The Clirr report is still a problem:
> >> >>>
> >> >>>
> >> >>>
> >> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
> >> >>>
> >> >>> [The same errors are reported on my machine, so it's
> >> >>> not a cache issue...]
> >> >>>
> >> >>> Regards,
> >> >>> Gilles
> >> >>>
> >> >>>>
> >> >>>> Distribution files (committed at revision 31689):
> >> >>>>   https://dist.apache.org/repos/dist/dev/commons/collections/
> >> >>>>
> >> >>>> Distribution files hashes (SHA256):
> >> >>>>  commons-collections4-4.3-bin.tar.gz
> >> >>>>
> >> 214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
> >> >>>>  commons-collections4-4.3-bin.zip
> >> >>>>
> >> 75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
> >> >>>>  commons-collections4-4.3-src.tar.gz
> >> >>>>
> >> 399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
> >> >>>>  commons-collections4-4.3-src.zip
> >> >>>>
> >> 1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
> >> >>>>
> >> >>>> KEYS file to check signatures:
> >> >>>>   https://www.apache.org/dist/commons/KEYS
> >> >>>>
> >> >>>> Maven artifacts:
> >> >>>>
> >> >>>>
> >> https://repository.apache.org/content/repositories/orgapachecommons-1405/
> >> >>>>
> >> >>>> Please select one of the following options:
> >> >>>>  [ ] +1 Release it.
> >> >>>>  [ ] +0 Go ahead; I don't care.
> >> >>>>  [ ] -0 There are a few minor glitches: ...
> >> >>>>  [ ] -1 No, do not release it because ...
> >> >>>>
> >> >>>> This vote will be open for at least 72 hours, i.e. until
> >> >>>> 2018-12-29T14:00:00Z
> >> >>>> (this is UTC time).
> >> >>>>
> >> >>
> >> >>
> >> >>
> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: [hidden email]
> >> >> For additional commands, e-mail: [hidden email]
> >> >>
> >> >>
> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: [hidden email]
> >> >> For additional commands, e-mail: [hidden email]
> >> >>
> >> >
> >> >
> >> > --
> >> > WBR
> >> > Maxim aka solomax
> >> >
> >> >
> >> ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: [hidden email]
> >> > For additional commands, e-mail: [hidden email]
> >> >
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


--
WBR
Maxim aka solomax

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

Gilles Sadowski
Hello.

On Wed, 2 Jan 2019 14:01:24 +0700, Maxim Solodovnik wrote:

> Hello All,
>
> Just checked clirr report one more time
> This time I took 1 error and perform investigation:
>
> "Method 'public java.util.Collection values()' has been added to an
> interface" org.apache.commons.collections4.BidiMap
>
> In fact I don't understand why this error was reported
> BidiMap extends java.util.Map
> Map has method "public java.util.Collection values()" in all
> versions:
> https://docs.oracle.com/javase/6/docs/api/java/util/Map.html
> https://docs.oracle.com/javase/7/docs/api/java/util/Map.html
> https://docs.oracle.com/javase/8/docs/api/java/util/Map.html
>
> Maybe its clirr issue?

Might worth trying another tool:
   https://revapi.org/

[If you look into the log of "Commons RNG", there was a
recent commit with the config to activate it (which I've
removed afterwards since Clirr was not the cause of my
problem there).]

> Would appreciate any help with this investigation

Maybe totally unrelated but I've noticed that after deleting
all "collections"-related maven caches, the build
   $ mvn clean site
started by downloading _all_ older versions...

Regards,
Gilles

>
> On Mon, 31 Dec 2018 at 16:53, Gilles <[hidden email]>
> wrote:
>>
>> On Mon, 31 Dec 2018 07:41:40 +0700, Maxim Solodovnik wrote:
>> > Hello Gilles,
>> >
>> > I already did analysis: [1], all errors are caused by previous
>> > release
>> > 4.3 doesn't introduce any new errors ...
>> >
>> > [1] https://markmail.org/message/l7ftxlvdk4yqxijt
>>
>> I had seen the post but it says:
>> ---
>> these errors are weird. Above classes has no changes comparing to
>> 4.2
>> ---
>>
>> But IMHO it was not a conclusion: If the cause of the errors was
>> identified, it could have been mentioned in the release notes
>> and/or the [VOTE] email, in order to avoid further questioning.
>>
>> Is the cause the change of supported JDK?
>>
>> Regards,
>> Gilles
>>
>> >
>> > On Mon, 31 Dec 2018 at 07:26, Rob Tompkins <[hidden email]>
>> > wrote:
>> >>
>> >> I’ll give it a look tonight or in the morning.
>> >>
>> >> -Rob
>> >>
>> >> > On Dec 30, 2018, at 12:25 AM, Maxim Solodovnik
>> >> <[hidden email]> wrote:
>> >> >
>> >> > No votes after 3 days :(
>> >> > Is there anything wrong with the RC?
>> >> >
>> >> >> On Thu, 27 Dec 2018 at 05:20, Bruno P. Kinoshita
>> >> <[hidden email]> wrote:
>> >> >>
>> >> >> FWIW I had a similar experience, and realized I was doing `git
>> >> fetch --all`, but it didn't bring the tags. `git fetch --tags`
>> did the
>> >> trick. After that I could `git checkout $tag-name`
>> >> >>
>> >> >> Cheers
>> >> >> Bruno
>> >> >>
>> >> >>
>> >> >>
>> >> >>
>> >> >> ________________________________
>> >> >> From: Gilles <[hidden email]>
>> >> >> To: [hidden email]
>> >> >> Sent: Thursday, 27 December 2018 9:26 AM
>> >> >> Subject: Re: [VOTE][RC2] Commons collections 4.3
>> >> >>
>> >> >>
>> >> >>
>> >> >>> On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
>> >> >>> Hi.
>> >> >>>
>> >> >>>> On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
>> >> >>>> This is a [VOTE] for releasing
>> >> >>>> Apache Commons collections 4.3
>> >> >>>>
>> >> >>>> Tag name:
>> >> >>>>    collections-4.3-RC2 (signature can be checked from git
>> using
>> >> >>>> 'git
>> >> >>>> tag -v')
>> >> >>>
>> >> >>> $ git tag -v collections-4.3-RC2
>> >> >>> error: tag 'collections-4.3-RC2' not found.
>> >> >>>
>> >> >>> Although I see it in the link below...
>> >> >>> What is going on?
>> >> >>
>> >> >> Issue vanished with a fresh "clone".
>> >> >> [Sorry for the noise.]
>> >> >>
>> >> >>
>> >> >>>> RC1 was cancelled due to some release steps were not done
>> >> >>>>
>> >> >>>> Tag URL:
>> >> >>>>
>> >> >>>>
>> >> >>>>
>> >>
>> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
>> >> >>>>
>> >> >>>> Commit ID the tag points at:
>> >> >>>>    77e37dbf238d26351edb29e95391e3df75095d01
>> >> >>>>
>> >> >>>> Site:
>> >> >>>>
>> >> >>>>
>> >> >>>>
>> >>
>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
>> >> >>>
>> >> >>> The Clirr report is still a problem:
>> >> >>>
>> >> >>>
>> >> >>>
>> >>
>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
>> >> >>>
>> >> >>> [The same errors are reported on my machine, so it's
>> >> >>> not a cache issue...]
>> >> >>>
>> >> >>> Regards,
>> >> >>> Gilles
>> >> >>>
>> >> >>>>
>> >> >>>> Distribution files (committed at revision 31689):
>> >> >>>>  
>> https://dist.apache.org/repos/dist/dev/commons/collections/
>> >> >>>>
>> >> >>>> Distribution files hashes (SHA256):
>> >> >>>>  commons-collections4-4.3-bin.tar.gz
>> >> >>>>
>> >> 214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
>> >> >>>>  commons-collections4-4.3-bin.zip
>> >> >>>>
>> >> 75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
>> >> >>>>  commons-collections4-4.3-src.tar.gz
>> >> >>>>
>> >> 399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
>> >> >>>>  commons-collections4-4.3-src.zip
>> >> >>>>
>> >> 1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
>> >> >>>>
>> >> >>>> KEYS file to check signatures:
>> >> >>>>   https://www.apache.org/dist/commons/KEYS
>> >> >>>>
>> >> >>>> Maven artifacts:
>> >> >>>>
>> >> >>>>
>> >>
>> https://repository.apache.org/content/repositories/orgapachecommons-1405/
>> >> >>>>
>> >> >>>> Please select one of the following options:
>> >> >>>>  [ ] +1 Release it.
>> >> >>>>  [ ] +0 Go ahead; I don't care.
>> >> >>>>  [ ] -0 There are a few minor glitches: ...
>> >> >>>>  [ ] -1 No, do not release it because ...
>> >> >>>>
>> >> >>>> This vote will be open for at least 72 hours, i.e. until
>> >> >>>> 2018-12-29T14:00:00Z
>> >> >>>> (this is UTC time).
>> >> >>>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

Gilles Sadowski
On Wed, 02 Jan 2019 12:38:23 +0100, Gilles wrote:

> Hello.
>
> On Wed, 2 Jan 2019 14:01:24 +0700, Maxim Solodovnik wrote:
>> Hello All,
>>
>> Just checked clirr report one more time
>> This time I took 1 error and perform investigation:
>>
>> "Method 'public java.util.Collection values()' has been added to an
>> interface" org.apache.commons.collections4.BidiMap
>>
>> In fact I don't understand why this error was reported
>> BidiMap extends java.util.Map
>> Map has method "public java.util.Collection values()" in all
>> versions:
>> https://docs.oracle.com/javase/6/docs/api/java/util/Map.html
>> https://docs.oracle.com/javase/7/docs/api/java/util/Map.html
>> https://docs.oracle.com/javase/8/docs/api/java/util/Map.html
>>
>> Maybe its clirr issue?
>
> Might worth trying another tool:
>   https://revapi.org/

This is the config for the "<build>" section:
---CUT---
       <plugin>
         <groupId>org.revapi</groupId>
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.10.5</version>
         <dependencies>
           <dependency>
             <groupId>org.revapi</groupId>
             <artifactId>revapi-java</artifactId>
             <version>0.18.2</version>
           </dependency>
         </dependencies>
         <executions>
           <execution>
             <id>check</id>
             <goals><goal>check</goal></goals>
           </execution>
         </executions>
       </plugin>
---CUT---
and for the "<reporting>":
---CUT---
       <plugin>
         <groupId>org.revapi</groupId>
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.10.5</version>
         <reportSets>
           <reportSet>
             <reports>
               <report>report</report>
               <report>report-aggregate</report>
             </reports>
           </reportSet>
         </reportSets>
       </plugin>
---CUT---

Gilles

> [If you look into the log of "Commons RNG", there was a
> recent commit with the config to activate it (which I've
> removed afterwards since Clirr was not the cause of my
> problem there).]
>
>> Would appreciate any help with this investigation
>
> Maybe totally unrelated but I've noticed that after deleting
> all "collections"-related maven caches, the build
>   $ mvn clean site
> started by downloading _all_ older versions...
>
> Regards,
> Gilles
>
>>
>> On Mon, 31 Dec 2018 at 16:53, Gilles <[hidden email]>
>> wrote:
>>>
>>> On Mon, 31 Dec 2018 07:41:40 +0700, Maxim Solodovnik wrote:
>>> > Hello Gilles,
>>> >
>>> > I already did analysis: [1], all errors are caused by previous
>>> > release
>>> > 4.3 doesn't introduce any new errors ...
>>> >
>>> > [1] https://markmail.org/message/l7ftxlvdk4yqxijt
>>>
>>> I had seen the post but it says:
>>> ---
>>> these errors are weird. Above classes has no changes comparing to
>>> 4.2
>>> ---
>>>
>>> But IMHO it was not a conclusion: If the cause of the errors was
>>> identified, it could have been mentioned in the release notes
>>> and/or the [VOTE] email, in order to avoid further questioning.
>>>
>>> Is the cause the change of supported JDK?
>>>
>>> Regards,
>>> Gilles
>>>
>>> >
>>> > On Mon, 31 Dec 2018 at 07:26, Rob Tompkins <[hidden email]>
>>> > wrote:
>>> >>
>>> >> I’ll give it a look tonight or in the morning.
>>> >>
>>> >> -Rob
>>> >>
>>> >> > On Dec 30, 2018, at 12:25 AM, Maxim Solodovnik
>>> >> <[hidden email]> wrote:
>>> >> >
>>> >> > No votes after 3 days :(
>>> >> > Is there anything wrong with the RC?
>>> >> >
>>> >> >> On Thu, 27 Dec 2018 at 05:20, Bruno P. Kinoshita
>>> >> <[hidden email]> wrote:
>>> >> >>
>>> >> >> FWIW I had a similar experience, and realized I was doing
>>> `git
>>> >> fetch --all`, but it didn't bring the tags. `git fetch --tags`
>>> did the
>>> >> trick. After that I could `git checkout $tag-name`
>>> >> >>
>>> >> >> Cheers
>>> >> >> Bruno
>>> >> >>
>>> >> >>
>>> >> >>
>>> >> >>
>>> >> >> ________________________________
>>> >> >> From: Gilles <[hidden email]>
>>> >> >> To: [hidden email]
>>> >> >> Sent: Thursday, 27 December 2018 9:26 AM
>>> >> >> Subject: Re: [VOTE][RC2] Commons collections 4.3
>>> >> >>
>>> >> >>
>>> >> >>
>>> >> >>> On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
>>> >> >>> Hi.
>>> >> >>>
>>> >> >>>> On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
>>> >> >>>> This is a [VOTE] for releasing
>>> >> >>>> Apache Commons collections 4.3
>>> >> >>>>
>>> >> >>>> Tag name:
>>> >> >>>>    collections-4.3-RC2 (signature can be checked from git
>>> using
>>> >> >>>> 'git
>>> >> >>>> tag -v')
>>> >> >>>
>>> >> >>> $ git tag -v collections-4.3-RC2
>>> >> >>> error: tag 'collections-4.3-RC2' not found.
>>> >> >>>
>>> >> >>> Although I see it in the link below...
>>> >> >>> What is going on?
>>> >> >>
>>> >> >> Issue vanished with a fresh "clone".
>>> >> >> [Sorry for the noise.]
>>> >> >>
>>> >> >>
>>> >> >>>> RC1 was cancelled due to some release steps were not done
>>> >> >>>>
>>> >> >>>> Tag URL:
>>> >> >>>>
>>> >> >>>>
>>> >> >>>>
>>> >>
>>> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
>>> >> >>>>
>>> >> >>>> Commit ID the tag points at:
>>> >> >>>>    77e37dbf238d26351edb29e95391e3df75095d01
>>> >> >>>>
>>> >> >>>> Site:
>>> >> >>>>
>>> >> >>>>
>>> >> >>>>
>>> >>
>>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
>>> >> >>>
>>> >> >>> The Clirr report is still a problem:
>>> >> >>>
>>> >> >>>
>>> >> >>>
>>> >>
>>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
>>> >> >>>
>>> >> >>> [The same errors are reported on my machine, so it's
>>> >> >>> not a cache issue...]
>>> >> >>>
>>> >> >>> Regards,
>>> >> >>> Gilles
>>> >> >>>
>>> >> >>>>
>>> >> >>>> Distribution files (committed at revision 31689):
>>> >> >>>>  
>>> https://dist.apache.org/repos/dist/dev/commons/collections/
>>> >> >>>>
>>> >> >>>> Distribution files hashes (SHA256):
>>> >> >>>>  commons-collections4-4.3-bin.tar.gz
>>> >> >>>>
>>> >> 214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
>>> >> >>>>  commons-collections4-4.3-bin.zip
>>> >> >>>>
>>> >> 75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
>>> >> >>>>  commons-collections4-4.3-src.tar.gz
>>> >> >>>>
>>> >> 399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
>>> >> >>>>  commons-collections4-4.3-src.zip
>>> >> >>>>
>>> >> 1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
>>> >> >>>>
>>> >> >>>> KEYS file to check signatures:
>>> >> >>>>   https://www.apache.org/dist/commons/KEYS
>>> >> >>>>
>>> >> >>>> Maven artifacts:
>>> >> >>>>
>>> >> >>>>
>>> >>
>>> https://repository.apache.org/content/repositories/orgapachecommons-1405/
>>> >> >>>>
>>> >> >>>> Please select one of the following options:
>>> >> >>>>  [ ] +1 Release it.
>>> >> >>>>  [ ] +0 Go ahead; I don't care.
>>> >> >>>>  [ ] -0 There are a few minor glitches: ...
>>> >> >>>>  [ ] -1 No, do not release it because ...
>>> >> >>>>
>>> >> >>>> This vote will be open for at least 72 hours, i.e. until
>>> >> >>>> 2018-12-29T14:00:00Z
>>> >> >>>> (this is UTC time).
>>> >> >>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

garydgregory
In reply to this post by Gilles Sadowski
We need something better than Clirr for certain. I'm not sure japicmp is
going to cut it either. I'm glad someone is looking into a new alternative.

Gary

On Wed, Jan 2, 2019 at 6:38 AM Gilles <[hidden email]> wrote:

> Hello.
>
> On Wed, 2 Jan 2019 14:01:24 +0700, Maxim Solodovnik wrote:
> > Hello All,
> >
> > Just checked clirr report one more time
> > This time I took 1 error and perform investigation:
> >
> > "Method 'public java.util.Collection values()' has been added to an
> > interface" org.apache.commons.collections4.BidiMap
> >
> > In fact I don't understand why this error was reported
> > BidiMap extends java.util.Map
> > Map has method "public java.util.Collection values()" in all
> > versions:
> > https://docs.oracle.com/javase/6/docs/api/java/util/Map.html
> > https://docs.oracle.com/javase/7/docs/api/java/util/Map.html
> > https://docs.oracle.com/javase/8/docs/api/java/util/Map.html
> >
> > Maybe its clirr issue?
>
> Might worth trying another tool:
>    https://revapi.org/
>
> [If you look into the log of "Commons RNG", there was a
> recent commit with the config to activate it (which I've
> removed afterwards since Clirr was not the cause of my
> problem there).]
>
> > Would appreciate any help with this investigation
>
> Maybe totally unrelated but I've noticed that after deleting
> all "collections"-related maven caches, the build
>    $ mvn clean site
> started by downloading _all_ older versions...
>
> Regards,
> Gilles
>
> >
> > On Mon, 31 Dec 2018 at 16:53, Gilles <[hidden email]>
> > wrote:
> >>
> >> On Mon, 31 Dec 2018 07:41:40 +0700, Maxim Solodovnik wrote:
> >> > Hello Gilles,
> >> >
> >> > I already did analysis: [1], all errors are caused by previous
> >> > release
> >> > 4.3 doesn't introduce any new errors ...
> >> >
> >> > [1] https://markmail.org/message/l7ftxlvdk4yqxijt
> >>
> >> I had seen the post but it says:
> >> ---
> >> these errors are weird. Above classes has no changes comparing to
> >> 4.2
> >> ---
> >>
> >> But IMHO it was not a conclusion: If the cause of the errors was
> >> identified, it could have been mentioned in the release notes
> >> and/or the [VOTE] email, in order to avoid further questioning.
> >>
> >> Is the cause the change of supported JDK?
> >>
> >> Regards,
> >> Gilles
> >>
> >> >
> >> > On Mon, 31 Dec 2018 at 07:26, Rob Tompkins <[hidden email]>
> >> > wrote:
> >> >>
> >> >> I’ll give it a look tonight or in the morning.
> >> >>
> >> >> -Rob
> >> >>
> >> >> > On Dec 30, 2018, at 12:25 AM, Maxim Solodovnik
> >> >> <[hidden email]> wrote:
> >> >> >
> >> >> > No votes after 3 days :(
> >> >> > Is there anything wrong with the RC?
> >> >> >
> >> >> >> On Thu, 27 Dec 2018 at 05:20, Bruno P. Kinoshita
> >> >> <[hidden email]> wrote:
> >> >> >>
> >> >> >> FWIW I had a similar experience, and realized I was doing `git
> >> >> fetch --all`, but it didn't bring the tags. `git fetch --tags`
> >> did the
> >> >> trick. After that I could `git checkout $tag-name`
> >> >> >>
> >> >> >> Cheers
> >> >> >> Bruno
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> >> ________________________________
> >> >> >> From: Gilles <[hidden email]>
> >> >> >> To: [hidden email]
> >> >> >> Sent: Thursday, 27 December 2018 9:26 AM
> >> >> >> Subject: Re: [VOTE][RC2] Commons collections 4.3
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> >>> On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
> >> >> >>> Hi.
> >> >> >>>
> >> >> >>>> On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
> >> >> >>>> This is a [VOTE] for releasing
> >> >> >>>> Apache Commons collections 4.3
> >> >> >>>>
> >> >> >>>> Tag name:
> >> >> >>>>    collections-4.3-RC2 (signature can be checked from git
> >> using
> >> >> >>>> 'git
> >> >> >>>> tag -v')
> >> >> >>>
> >> >> >>> $ git tag -v collections-4.3-RC2
> >> >> >>> error: tag 'collections-4.3-RC2' not found.
> >> >> >>>
> >> >> >>> Although I see it in the link below...
> >> >> >>> What is going on?
> >> >> >>
> >> >> >> Issue vanished with a fresh "clone".
> >> >> >> [Sorry for the noise.]
> >> >> >>
> >> >> >>
> >> >> >>>> RC1 was cancelled due to some release steps were not done
> >> >> >>>>
> >> >> >>>> Tag URL:
> >> >> >>>>
> >> >> >>>>
> >> >> >>>>
> >> >>
> >>
> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
> >> >> >>>>
> >> >> >>>> Commit ID the tag points at:
> >> >> >>>>    77e37dbf238d26351edb29e95391e3df75095d01
> >> >> >>>>
> >> >> >>>> Site:
> >> >> >>>>
> >> >> >>>>
> >> >> >>>>
> >> >>
> >>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
> >> >> >>>
> >> >> >>> The Clirr report is still a problem:
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >>
> >>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
> >> >> >>>
> >> >> >>> [The same errors are reported on my machine, so it's
> >> >> >>> not a cache issue...]
> >> >> >>>
> >> >> >>> Regards,
> >> >> >>> Gilles
> >> >> >>>
> >> >> >>>>
> >> >> >>>> Distribution files (committed at revision 31689):
> >> >> >>>>
> >> https://dist.apache.org/repos/dist/dev/commons/collections/
> >> >> >>>>
> >> >> >>>> Distribution files hashes (SHA256):
> >> >> >>>>  commons-collections4-4.3-bin.tar.gz
> >> >> >>>>
> >> >> 214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
> >> >> >>>>  commons-collections4-4.3-bin.zip
> >> >> >>>>
> >> >> 75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
> >> >> >>>>  commons-collections4-4.3-src.tar.gz
> >> >> >>>>
> >> >> 399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
> >> >> >>>>  commons-collections4-4.3-src.zip
> >> >> >>>>
> >> >> 1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
> >> >> >>>>
> >> >> >>>> KEYS file to check signatures:
> >> >> >>>>   https://www.apache.org/dist/commons/KEYS
> >> >> >>>>
> >> >> >>>> Maven artifacts:
> >> >> >>>>
> >> >> >>>>
> >> >>
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-1405/
> >> >> >>>>
> >> >> >>>> Please select one of the following options:
> >> >> >>>>  [ ] +1 Release it.
> >> >> >>>>  [ ] +0 Go ahead; I don't care.
> >> >> >>>>  [ ] -0 There are a few minor glitches: ...
> >> >> >>>>  [ ] -1 No, do not release it because ...
> >> >> >>>>
> >> >> >>>> This vote will be open for at least 72 hours, i.e. until
> >> >> >>>> 2018-12-29T14:00:00Z
> >> >> >>>> (this is UTC time).
> >> >> >>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

Amey Jadiye
In reply to this post by Maxim Solodovnik
I spared little time on finding issue however didn't found it in clirr(may
be hidden somewhere),  today will check if clirr maven plugin have any
issues. also I saw that few other apache commons modules having same issue
and are released.

I also gave try on revapi with commons collection4 4.3RC2. revapi:check was
clean unlike clirr, looks promising to replace clirr.

Regards,
Amey

On Wed, 2 Jan 2019, 12:31 pm Maxim Solodovnik <[hidden email] wrote:

> Hello All,
>
> Just checked clirr report one more time
> This time I took 1 error and perform investigation:
>
> "Method 'public java.util.Collection values()' has been added to an
> interface" org.apache.commons.collections4.BidiMap
>
> In fact I don't understand why this error was reported
> BidiMap extends java.util.Map
> Map has method "public java.util.Collection values()" in all versions:
> https://docs.oracle.com/javase/6/docs/api/java/util/Map.html
> https://docs.oracle.com/javase/7/docs/api/java/util/Map.html
> https://docs.oracle.com/javase/8/docs/api/java/util/Map.html
>
> Maybe its clirr issue?
> Would appreciate any help with this investigation
>
> On Mon, 31 Dec 2018 at 16:53, Gilles <[hidden email]> wrote:
> >
> > On Mon, 31 Dec 2018 07:41:40 +0700, Maxim Solodovnik wrote:
> > > Hello Gilles,
> > >
> > > I already did analysis: [1], all errors are caused by previous
> > > release
> > > 4.3 doesn't introduce any new errors ...
> > >
> > > [1] https://markmail.org/message/l7ftxlvdk4yqxijt
> >
> > I had seen the post but it says:
> > ---
> > these errors are weird. Above classes has no changes comparing to 4.2
> > ---
> >
> > But IMHO it was not a conclusion: If the cause of the errors was
> > identified, it could have been mentioned in the release notes
> > and/or the [VOTE] email, in order to avoid further questioning.
> >
> > Is the cause the change of supported JDK?
> >
> > Regards,
> > Gilles
> >
> > >
> > > On Mon, 31 Dec 2018 at 07:26, Rob Tompkins <[hidden email]>
> > > wrote:
> > >>
> > >> I’ll give it a look tonight or in the morning.
> > >>
> > >> -Rob
> > >>
> > >> > On Dec 30, 2018, at 12:25 AM, Maxim Solodovnik
> > >> <[hidden email]> wrote:
> > >> >
> > >> > No votes after 3 days :(
> > >> > Is there anything wrong with the RC?
> > >> >
> > >> >> On Thu, 27 Dec 2018 at 05:20, Bruno P. Kinoshita
> > >> <[hidden email]> wrote:
> > >> >>
> > >> >> FWIW I had a similar experience, and realized I was doing `git
> > >> fetch --all`, but it didn't bring the tags. `git fetch --tags` did the
> > >> trick. After that I could `git checkout $tag-name`
> > >> >>
> > >> >> Cheers
> > >> >> Bruno
> > >> >>
> > >> >>
> > >> >>
> > >> >>
> > >> >> ________________________________
> > >> >> From: Gilles <[hidden email]>
> > >> >> To: [hidden email]
> > >> >> Sent: Thursday, 27 December 2018 9:26 AM
> > >> >> Subject: Re: [VOTE][RC2] Commons collections 4.3
> > >> >>
> > >> >>
> > >> >>
> > >> >>> On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
> > >> >>> Hi.
> > >> >>>
> > >> >>>> On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
> > >> >>>> This is a [VOTE] for releasing
> > >> >>>> Apache Commons collections 4.3
> > >> >>>>
> > >> >>>> Tag name:
> > >> >>>>    collections-4.3-RC2 (signature can be checked from git using
> > >> >>>> 'git
> > >> >>>> tag -v')
> > >> >>>
> > >> >>> $ git tag -v collections-4.3-RC2
> > >> >>> error: tag 'collections-4.3-RC2' not found.
> > >> >>>
> > >> >>> Although I see it in the link below...
> > >> >>> What is going on?
> > >> >>
> > >> >> Issue vanished with a fresh "clone".
> > >> >> [Sorry for the noise.]
> > >> >>
> > >> >>
> > >> >>>> RC1 was cancelled due to some release steps were not done
> > >> >>>>
> > >> >>>> Tag URL:
> > >> >>>>
> > >> >>>>
> > >> >>>>
> > >>
> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
> > >> >>>>
> > >> >>>> Commit ID the tag points at:
> > >> >>>>    77e37dbf238d26351edb29e95391e3df75095d01
> > >> >>>>
> > >> >>>> Site:
> > >> >>>>
> > >> >>>>
> > >> >>>>
> > >>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
> > >> >>>
> > >> >>> The Clirr report is still a problem:
> > >> >>>
> > >> >>>
> > >> >>>
> > >>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
> > >> >>>
> > >> >>> [The same errors are reported on my machine, so it's
> > >> >>> not a cache issue...]
> > >> >>>
> > >> >>> Regards,
> > >> >>> Gilles
> > >> >>>
> > >> >>>>
> > >> >>>> Distribution files (committed at revision 31689):
> > >> >>>>   https://dist.apache.org/repos/dist/dev/commons/collections/
> > >> >>>>
> > >> >>>> Distribution files hashes (SHA256):
> > >> >>>>  commons-collections4-4.3-bin.tar.gz
> > >> >>>>
> > >> 214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
> > >> >>>>  commons-collections4-4.3-bin.zip
> > >> >>>>
> > >> 75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
> > >> >>>>  commons-collections4-4.3-src.tar.gz
> > >> >>>>
> > >> 399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
> > >> >>>>  commons-collections4-4.3-src.zip
> > >> >>>>
> > >> 1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
> > >> >>>>
> > >> >>>> KEYS file to check signatures:
> > >> >>>>   https://www.apache.org/dist/commons/KEYS
> > >> >>>>
> > >> >>>> Maven artifacts:
> > >> >>>>
> > >> >>>>
> > >>
> https://repository.apache.org/content/repositories/orgapachecommons-1405/
> > >> >>>>
> > >> >>>> Please select one of the following options:
> > >> >>>>  [ ] +1 Release it.
> > >> >>>>  [ ] +0 Go ahead; I don't care.
> > >> >>>>  [ ] -0 There are a few minor glitches: ...
> > >> >>>>  [ ] -1 No, do not release it because ...
> > >> >>>>
> > >> >>>> This vote will be open for at least 72 hours, i.e. until
> > >> >>>> 2018-12-29T14:00:00Z
> > >> >>>> (this is UTC time).
> > >> >>>>
> > >> >>
> > >> >>
> > >> >>
> > >> ---------------------------------------------------------------------
> > >> >> To unsubscribe, e-mail: [hidden email]
> > >> >> For additional commands, e-mail: [hidden email]
> > >> >>
> > >> >>
> > >> ---------------------------------------------------------------------
> > >> >> To unsubscribe, e-mail: [hidden email]
> > >> >> For additional commands, e-mail: [hidden email]
> > >> >>
> > >> >
> > >> >
> > >> > --
> > >> > WBR
> > >> > Maxim aka solomax
> > >> >
> > >> >
> > >> ---------------------------------------------------------------------
> > >> > To unsubscribe, e-mail: [hidden email]
> > >> > For additional commands, e-mail: [hidden email]
> > >> >
> > >>
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: [hidden email]
> > >> For additional commands, e-mail: [hidden email]
> > >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
>
> --
> WBR
> Maxim aka solomax
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

garydgregory
In reply to this post by Maxim Solodovnik
I am slowly coming back to FOSS setting up a new laptop and house... may
someone summarize where we stand on this vote?

Gary

On Wed, Dec 26, 2018 at 8:42 AM Maxim Solodovnik <[hidden email]>
wrote:

> This is a [VOTE] for releasing
> Apache Commons collections 4.3
>
> Tag name:
>     collections-4.3-RC2 (signature can be checked from git using 'git tag
> -v')
> RC1 was cancelled due to some release steps were not done
>
> Tag URL:
>
> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
>
> Commit ID the tag points at:
>     77e37dbf238d26351edb29e95391e3df75095d01
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
>
> Distribution files (committed at revision 31689):
>     https://dist.apache.org/repos/dist/dev/commons/collections/
>
> Distribution files hashes (SHA256):
>   commons-collections4-4.3-bin.tar.gz
>     214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
>   commons-collections4-4.3-bin.zip
>     75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
>   commons-collections4-4.3-src.tar.gz
>     399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
>   commons-collections4-4.3-src.zip
>     1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
>
> KEYS file to check signatures:
>     https://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1405/
>
> Please select one of the following options:
>   [ ] +1 Release it.
>   [ ] +0 Go ahead; I don't care.
>   [ ] -0 There are a few minor glitches: ...
>   [ ] -1 No, do not release it because ...
>
> This vote will be open for at least 72 hours, i.e. until
> 2018-12-29T14:00:00Z
> (this is UTC time).
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

Amey Jadiye
In reply to this post by Amey Jadiye
Hello Maxim / All

I put little more efforts to find out the possible cause of the error.
In the clirr code, I found the reason for this error and same is documented
in clirr documentation [1].

A method declaration has been added to the specified interface. This is
always reported as a binary-compatibility error, but in practice, the
changed class might be used successfully with code compiled against the old
interface depending upon usage patterns.

Old code which invokes methods upon code compiled against the new
(expanded) interface will continue to work without issues. And old code
which implements the old version of the interface will also continue to
work correctly as long as no code attempts to invoke any of the newly-added
methods against that instance. But the code which (validly) invokes one of
the new methods in the interface against an object which implements only
the old version of the interface will cause an AbstractMethodError to be
thrown at the time the method invocation is attempted.

In 4.2 and 4.3 looks like we have upgraded the java version[2] where for
example for Map interface might have added a few more methods causing these
errors.

For this release, I am voting 0 (Non-Binding) as there is unharmed mess
around the clirr.

rest of the things are OK with this release, I would encourage to have
revapi replacing clirr.


[1]  http://clirr.sourceforge.net/clirr-core/exegesis.html
[2]
https://github.com/apache/commons-collections/commit/482762a13f739631f94d03642b0a55a9b7214c44

Regards,
Amey


On Thu, Jan 3, 2019 at 11:53 AM Amey Jadiye <[hidden email]> wrote:

> I spared little time on finding issue however didn't found it in clirr(may
> be hidden somewhere),  today will check if clirr maven plugin have any
> issues. also I saw that few other apache commons modules having same issue
> and are released.
>
> I also gave try on revapi with commons collection4 4.3RC2. revapi:check
> was clean unlike clirr, looks promising to replace clirr.
>
> Regards,
> Amey
>
> On Wed, 2 Jan 2019, 12:31 pm Maxim Solodovnik <[hidden email] wrote:
>
>> Hello All,
>>
>> Just checked clirr report one more time
>> This time I took 1 error and perform investigation:
>>
>> "Method 'public java.util.Collection values()' has been added to an
>> interface" org.apache.commons.collections4.BidiMap
>>
>> In fact I don't understand why this error was reported
>> BidiMap extends java.util.Map
>> Map has method "public java.util.Collection values()" in all versions:
>> https://docs.oracle.com/javase/6/docs/api/java/util/Map.html
>> https://docs.oracle.com/javase/7/docs/api/java/util/Map.html
>> https://docs.oracle.com/javase/8/docs/api/java/util/Map.html
>>
>> Maybe its clirr issue?
>> Would appreciate any help with this investigation
>>
>> On Mon, 31 Dec 2018 at 16:53, Gilles <[hidden email]>
>> wrote:
>> >
>> > On Mon, 31 Dec 2018 07:41:40 +0700, Maxim Solodovnik wrote:
>> > > Hello Gilles,
>> > >
>> > > I already did analysis: [1], all errors are caused by previous
>> > > release
>> > > 4.3 doesn't introduce any new errors ...
>> > >
>> > > [1] https://markmail.org/message/l7ftxlvdk4yqxijt
>> >
>> > I had seen the post but it says:
>> > ---
>> > these errors are weird. Above classes has no changes comparing to 4.2
>> > ---
>> >
>> > But IMHO it was not a conclusion: If the cause of the errors was
>> > identified, it could have been mentioned in the release notes
>> > and/or the [VOTE] email, in order to avoid further questioning.
>> >
>> > Is the cause the change of supported JDK?
>> >
>> > Regards,
>> > Gilles
>> >
>> > >
>> > > On Mon, 31 Dec 2018 at 07:26, Rob Tompkins <[hidden email]>
>> > > wrote:
>> > >>
>> > >> I’ll give it a look tonight or in the morning.
>> > >>
>> > >> -Rob
>> > >>
>> > >> > On Dec 30, 2018, at 12:25 AM, Maxim Solodovnik
>> > >> <[hidden email]> wrote:
>> > >> >
>> > >> > No votes after 3 days :(
>> > >> > Is there anything wrong with the RC?
>> > >> >
>> > >> >> On Thu, 27 Dec 2018 at 05:20, Bruno P. Kinoshita
>> > >> <[hidden email]> wrote:
>> > >> >>
>> > >> >> FWIW I had a similar experience, and realized I was doing `git
>> > >> fetch --all`, but it didn't bring the tags. `git fetch --tags` did
>> the
>> > >> trick. After that I could `git checkout $tag-name`
>> > >> >>
>> > >> >> Cheers
>> > >> >> Bruno
>> > >> >>
>> > >> >>
>> > >> >>
>> > >> >>
>> > >> >> ________________________________
>> > >> >> From: Gilles <[hidden email]>
>> > >> >> To: [hidden email]
>> > >> >> Sent: Thursday, 27 December 2018 9:26 AM
>> > >> >> Subject: Re: [VOTE][RC2] Commons collections 4.3
>> > >> >>
>> > >> >>
>> > >> >>
>> > >> >>> On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
>> > >> >>> Hi.
>> > >> >>>
>> > >> >>>> On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
>> > >> >>>> This is a [VOTE] for releasing
>> > >> >>>> Apache Commons collections 4.3
>> > >> >>>>
>> > >> >>>> Tag name:
>> > >> >>>>    collections-4.3-RC2 (signature can be checked from git using
>> > >> >>>> 'git
>> > >> >>>> tag -v')
>> > >> >>>
>> > >> >>> $ git tag -v collections-4.3-RC2
>> > >> >>> error: tag 'collections-4.3-RC2' not found.
>> > >> >>>
>> > >> >>> Although I see it in the link below...
>> > >> >>> What is going on?
>> > >> >>
>> > >> >> Issue vanished with a fresh "clone".
>> > >> >> [Sorry for the noise.]
>> > >> >>
>> > >> >>
>> > >> >>>> RC1 was cancelled due to some release steps were not done
>> > >> >>>>
>> > >> >>>> Tag URL:
>> > >> >>>>
>> > >> >>>>
>> > >> >>>>
>> > >>
>> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
>> > >> >>>>
>> > >> >>>> Commit ID the tag points at:
>> > >> >>>>    77e37dbf238d26351edb29e95391e3df75095d01
>> > >> >>>>
>> > >> >>>> Site:
>> > >> >>>>
>> > >> >>>>
>> > >> >>>>
>> > >>
>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
>> > >> >>>
>> > >> >>> The Clirr report is still a problem:
>> > >> >>>
>> > >> >>>
>> > >> >>>
>> > >>
>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
>> > >> >>>
>> > >> >>> [The same errors are reported on my machine, so it's
>> > >> >>> not a cache issue...]
>> > >> >>>
>> > >> >>> Regards,
>> > >> >>> Gilles
>> > >> >>>
>> > >> >>>>
>> > >> >>>> Distribution files (committed at revision 31689):
>> > >> >>>>   https://dist.apache.org/repos/dist/dev/commons/collections/
>> > >> >>>>
>> > >> >>>> Distribution files hashes (SHA256):
>> > >> >>>>  commons-collections4-4.3-bin.tar.gz
>> > >> >>>>
>> > >> 214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
>> > >> >>>>  commons-collections4-4.3-bin.zip
>> > >> >>>>
>> > >> 75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
>> > >> >>>>  commons-collections4-4.3-src.tar.gz
>> > >> >>>>
>> > >> 399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
>> > >> >>>>  commons-collections4-4.3-src.zip
>> > >> >>>>
>> > >> 1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
>> > >> >>>>
>> > >> >>>> KEYS file to check signatures:
>> > >> >>>>   https://www.apache.org/dist/commons/KEYS
>> > >> >>>>
>> > >> >>>> Maven artifacts:
>> > >> >>>>
>> > >> >>>>
>> > >>
>> https://repository.apache.org/content/repositories/orgapachecommons-1405/
>> > >> >>>>
>> > >> >>>> Please select one of the following options:
>> > >> >>>>  [ ] +1 Release it.
>> > >> >>>>  [ ] +0 Go ahead; I don't care.
>> > >> >>>>  [ ] -0 There are a few minor glitches: ...
>> > >> >>>>  [ ] -1 No, do not release it because ...
>> > >> >>>>
>> > >> >>>> This vote will be open for at least 72 hours, i.e. until
>> > >> >>>> 2018-12-29T14:00:00Z
>> > >> >>>> (this is UTC time).
>> > >> >>>>
>> > >> >>
>> > >> >>
>> > >> >>
>> > >> ---------------------------------------------------------------------
>> > >> >> To unsubscribe, e-mail: [hidden email]
>> > >> >> For additional commands, e-mail: [hidden email]
>> > >> >>
>> > >> >>
>> > >> ---------------------------------------------------------------------
>> > >> >> To unsubscribe, e-mail: [hidden email]
>> > >> >> For additional commands, e-mail: [hidden email]
>> > >> >>
>> > >> >
>> > >> >
>> > >> > --
>> > >> > WBR
>> > >> > Maxim aka solomax
>> > >> >
>> > >> >
>> > >> ---------------------------------------------------------------------
>> > >> > To unsubscribe, e-mail: [hidden email]
>> > >> > For additional commands, e-mail: [hidden email]
>> > >> >
>> > >>
>> > >>
>> > >> ---------------------------------------------------------------------
>> > >> To unsubscribe, e-mail: [hidden email]
>> > >> For additional commands, e-mail: [hidden email]
>> > >>
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: [hidden email]
>> > For additional commands, e-mail: [hidden email]
>> >
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>

--

---------------------------------------------------------------------

To unsubscribe, e-mail: [hidden email]

For additional commands, e-mail: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

Gilles Sadowski
hi.

On Thu, 3 Jan 2019 22:04:24 +0530, Amey Jadiye wrote:

> Hello Maxim / All
>
> I put little more efforts to find out the possible cause of the
> error.
> In the clirr code, I found the reason for this error and same is
> documented
> in clirr documentation [1].
>
> A method declaration has been added to the specified interface. This
> is
> always reported as a binary-compatibility error, but in practice, the
> changed class might be used successfully with code compiled against
> the old
> interface depending upon usage patterns.
>
> Old code which invokes methods upon code compiled against the new
> (expanded) interface will continue to work without issues. And old
> code
> which implements the old version of the interface will also continue
> to
> work correctly as long as no code attempts to invoke any of the
> newly-added
> methods against that instance. But the code which (validly) invokes
> one of
> the new methods in the interface against an object which implements
> only
> the old version of the interface will cause an AbstractMethodError to
> be
> thrown at the time the method invocation is attempted.

IIUC, new code that calls the new methods on [Collections] classes
will crash.  Does not look good.
On the other hand, Maxim wrote earlier that a method reported by
Clirr as "new" (cf. below) was in fact present since Java 6...

Are we then sure that it's a Clirr bug?
If so, why did you not vote "+1" (on the condition that the false
positive is mentioned in the release notes)?

We could also make some definite progress with an actual code
example that calls the incriminated methods, compiled against the
current version of the library and then run against the current RC,
and see whether it crashes.

Alternatively, we could instate "revapi" in the POM (and disable
Clirr); and if the report is clean, trust that (though "revapi" is
still beta).

Opinions?

Gilles

>
> In 4.2 and 4.3 looks like we have upgraded the java version[2] where
> for
> example for Map interface might have added a few more methods causing
> these
> errors.
>
> For this release, I am voting 0 (Non-Binding) as there is unharmed
> mess
> around the clirr.
>
> rest of the things are OK with this release, I would encourage to
> have
> revapi replacing clirr.
>
>
> [1]  http://clirr.sourceforge.net/clirr-core/exegesis.html
> [2]
>
> https://github.com/apache/commons-collections/commit/482762a13f739631f94d03642b0a55a9b7214c44
>
> Regards,
> Amey
>
>
> On Thu, Jan 3, 2019 at 11:53 AM Amey Jadiye <[hidden email]>
> wrote:
>
>> I spared little time on finding issue however didn't found it in
>> clirr(may
>> be hidden somewhere),  today will check if clirr maven plugin have
>> any
>> issues. also I saw that few other apache commons modules having same
>> issue
>> and are released.
>>
>> I also gave try on revapi with commons collection4 4.3RC2.
>> revapi:check
>> was clean unlike clirr, looks promising to replace clirr.
>>
>> Regards,
>> Amey
>>
>> On Wed, 2 Jan 2019, 12:31 pm Maxim Solodovnik <[hidden email]
>> wrote:
>>
>>> Hello All,
>>>
>>> Just checked clirr report one more time
>>> This time I took 1 error and perform investigation:
>>>
>>> "Method 'public java.util.Collection values()' has been added to an
>>> interface" org.apache.commons.collections4.BidiMap
>>>
>>> In fact I don't understand why this error was reported
>>> BidiMap extends java.util.Map
>>> Map has method "public java.util.Collection values()" in all
>>> versions:
>>> https://docs.oracle.com/javase/6/docs/api/java/util/Map.html
>>> https://docs.oracle.com/javase/7/docs/api/java/util/Map.html
>>> https://docs.oracle.com/javase/8/docs/api/java/util/Map.html
>>>
>>> Maybe its clirr issue?
>>> Would appreciate any help with this investigation
>>>
>>> On Mon, 31 Dec 2018 at 16:53, Gilles <[hidden email]>
>>> wrote:
>>> >
>>> > On Mon, 31 Dec 2018 07:41:40 +0700, Maxim Solodovnik wrote:
>>> > > Hello Gilles,
>>> > >
>>> > > I already did analysis: [1], all errors are caused by previous
>>> > > release
>>> > > 4.3 doesn't introduce any new errors ...
>>> > >
>>> > > [1] https://markmail.org/message/l7ftxlvdk4yqxijt
>>> >
>>> > I had seen the post but it says:
>>> > ---
>>> > these errors are weird. Above classes has no changes comparing to
>>> 4.2
>>> > ---
>>> >
>>> > But IMHO it was not a conclusion: If the cause of the errors was
>>> > identified, it could have been mentioned in the release notes
>>> > and/or the [VOTE] email, in order to avoid further questioning.
>>> >
>>> > Is the cause the change of supported JDK?
>>> >
>>> > Regards,
>>> > Gilles
>>> >
>>> > >
>>> > > On Mon, 31 Dec 2018 at 07:26, Rob Tompkins <[hidden email]>
>>> > > wrote:
>>> > >>
>>> > >> I’ll give it a look tonight or in the morning.
>>> > >>
>>> > >> -Rob
>>> > >>
>>> > >> > On Dec 30, 2018, at 12:25 AM, Maxim Solodovnik
>>> > >> <[hidden email]> wrote:
>>> > >> >
>>> > >> > No votes after 3 days :(
>>> > >> > Is there anything wrong with the RC?
>>> > >> >
>>> > >> >> On Thu, 27 Dec 2018 at 05:20, Bruno P. Kinoshita
>>> > >> <[hidden email]> wrote:
>>> > >> >>
>>> > >> >> FWIW I had a similar experience, and realized I was doing
>>> `git
>>> > >> fetch --all`, but it didn't bring the tags. `git fetch --tags`
>>> did
>>> the
>>> > >> trick. After that I could `git checkout $tag-name`
>>> > >> >>
>>> > >> >> Cheers
>>> > >> >> Bruno
>>> > >> >>
>>> > >> >>
>>> > >> >>
>>> > >> >>
>>> > >> >> ________________________________
>>> > >> >> From: Gilles <[hidden email]>
>>> > >> >> To: [hidden email]
>>> > >> >> Sent: Thursday, 27 December 2018 9:26 AM
>>> > >> >> Subject: Re: [VOTE][RC2] Commons collections 4.3
>>> > >> >>
>>> > >> >>
>>> > >> >>
>>> > >> >>> On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
>>> > >> >>> Hi.
>>> > >> >>>
>>> > >> >>>> On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik
>>> wrote:
>>> > >> >>>> This is a [VOTE] for releasing
>>> > >> >>>> Apache Commons collections 4.3
>>> > >> >>>>
>>> > >> >>>> Tag name:
>>> > >> >>>>    collections-4.3-RC2 (signature can be checked from git
>>> using
>>> > >> >>>> 'git
>>> > >> >>>> tag -v')
>>> > >> >>>
>>> > >> >>> $ git tag -v collections-4.3-RC2
>>> > >> >>> error: tag 'collections-4.3-RC2' not found.
>>> > >> >>>
>>> > >> >>> Although I see it in the link below...
>>> > >> >>> What is going on?
>>> > >> >>
>>> > >> >> Issue vanished with a fresh "clone".
>>> > >> >> [Sorry for the noise.]
>>> > >> >>
>>> > >> >>
>>> > >> >>>> RC1 was cancelled due to some release steps were not done
>>> > >> >>>>
>>> > >> >>>> Tag URL:
>>> > >> >>>>
>>> > >> >>>>
>>> > >> >>>>
>>> > >>
>>>
>>> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
>>> > >> >>>>
>>> > >> >>>> Commit ID the tag points at:
>>> > >> >>>>    77e37dbf238d26351edb29e95391e3df75095d01
>>> > >> >>>>
>>> > >> >>>> Site:
>>> > >> >>>>
>>> > >> >>>>
>>> > >> >>>>
>>> > >>
>>>
>>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
>>> > >> >>>
>>> > >> >>> The Clirr report is still a problem:
>>> > >> >>>
>>> > >> >>>
>>> > >> >>>
>>> > >>
>>>
>>> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
>>> > >> >>>
>>> > >> >>> [The same errors are reported on my machine, so it's
>>> > >> >>> not a cache issue...]
>>> > >> >>>
>>> > >> >>> Regards,
>>> > >> >>> Gilles
>>> > >> >>>
>>> > >> >>>>
>>> > >> >>>> Distribution files (committed at revision 31689):
>>> > >> >>>>  
>>> https://dist.apache.org/repos/dist/dev/commons/collections/
>>> > >> >>>>
>>> > >> >>>> Distribution files hashes (SHA256):
>>> > >> >>>>  commons-collections4-4.3-bin.tar.gz
>>> > >> >>>>
>>> > >>
>>> 214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
>>> > >> >>>>  commons-collections4-4.3-bin.zip
>>> > >> >>>>
>>> > >>
>>> 75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
>>> > >> >>>>  commons-collections4-4.3-src.tar.gz
>>> > >> >>>>
>>> > >>
>>> 399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
>>> > >> >>>>  commons-collections4-4.3-src.zip
>>> > >> >>>>
>>> > >>
>>> 1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
>>> > >> >>>>
>>> > >> >>>> KEYS file to check signatures:
>>> > >> >>>>   https://www.apache.org/dist/commons/KEYS
>>> > >> >>>>
>>> > >> >>>> Maven artifacts:
>>> > >> >>>>
>>> > >> >>>>
>>> > >>
>>>
>>> https://repository.apache.org/content/repositories/orgapachecommons-1405/
>>> > >> >>>>
>>> > >> >>>> Please select one of the following options:
>>> > >> >>>>  [ ] +1 Release it.
>>> > >> >>>>  [ ] +0 Go ahead; I don't care.
>>> > >> >>>>  [ ] -0 There are a few minor glitches: ...
>>> > >> >>>>  [ ] -1 No, do not release it because ...
>>> > >> >>>>
>>> > >> >>>> This vote will be open for at least 72 hours, i.e. until
>>> > >> >>>> 2018-12-29T14:00:00Z
>>> > >> >>>> (this is UTC time).
>>> > >> >>>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC2] Commons collections 4.3

garydgregory
On Fri, Jan 4, 2019 at 6:55 AM Gilles <[hidden email]> wrote:

> hi.
>
> On Thu, 3 Jan 2019 22:04:24 +0530, Amey Jadiye wrote:
> > Hello Maxim / All
> >
> > I put little more efforts to find out the possible cause of the
> > error.
> > In the clirr code, I found the reason for this error and same is
> > documented
> > in clirr documentation [1].
> >
> > A method declaration has been added to the specified interface. This
> > is
> > always reported as a binary-compatibility error, but in practice, the
> > changed class might be used successfully with code compiled against
> > the old
> > interface depending upon usage patterns.
> >
> > Old code which invokes methods upon code compiled against the new
> > (expanded) interface will continue to work without issues. And old
> > code
> > which implements the old version of the interface will also continue
> > to
> > work correctly as long as no code attempts to invoke any of the
> > newly-added
> > methods against that instance. But the code which (validly) invokes
> > one of
> > the new methods in the interface against an object which implements
> > only
> > the old version of the interface will cause an AbstractMethodError to
> > be
> > thrown at the time the method invocation is attempted.
>
> IIUC, new code that calls the new methods on [Collections] classes
> will crash.  Does not look good.
> On the other hand, Maxim wrote earlier that a method reported by
> Clirr as "new" (cf. below) was in fact present since Java 6...
>
> Are we then sure that it's a Clirr bug?
> If so, why did you not vote "+1" (on the condition that the false
> positive is mentioned in the release notes)?
>
> We could also make some definite progress with an actual code
> example that calls the incriminated methods, compiled against the
> current version of the library and then run against the current RC,
> and see whether it crashes.
>
> Alternatively, we could instate "revapi" in the POM (and disable
> Clirr); and if the report is clean, trust that (though "revapi" is
> still beta).
>
> Opinions?
>

What does japicmp say?

Gary


>
> Gilles
>
> >
> > In 4.2 and 4.3 looks like we have upgraded the java version[2] where
> > for
> > example for Map interface might have added a few more methods causing
> > these
> > errors.
> >
> > For this release, I am voting 0 (Non-Binding) as there is unharmed
> > mess
> > around the clirr.
> >
> > rest of the things are OK with this release, I would encourage to
> > have
> > revapi replacing clirr.
> >
> >
> > [1]  http://clirr.sourceforge.net/clirr-core/exegesis.html
> > [2]
> >
> >
> https://github.com/apache/commons-collections/commit/482762a13f739631f94d03642b0a55a9b7214c44
> >
> > Regards,
> > Amey
> >
> >
> > On Thu, Jan 3, 2019 at 11:53 AM Amey Jadiye <[hidden email]>
> > wrote:
> >
> >> I spared little time on finding issue however didn't found it in
> >> clirr(may
> >> be hidden somewhere),  today will check if clirr maven plugin have
> >> any
> >> issues. also I saw that few other apache commons modules having same
> >> issue
> >> and are released.
> >>
> >> I also gave try on revapi with commons collection4 4.3RC2.
> >> revapi:check
> >> was clean unlike clirr, looks promising to replace clirr.
> >>
> >> Regards,
> >> Amey
> >>
> >> On Wed, 2 Jan 2019, 12:31 pm Maxim Solodovnik <[hidden email]
> >> wrote:
> >>
> >>> Hello All,
> >>>
> >>> Just checked clirr report one more time
> >>> This time I took 1 error and perform investigation:
> >>>
> >>> "Method 'public java.util.Collection values()' has been added to an
> >>> interface" org.apache.commons.collections4.BidiMap
> >>>
> >>> In fact I don't understand why this error was reported
> >>> BidiMap extends java.util.Map
> >>> Map has method "public java.util.Collection values()" in all
> >>> versions:
> >>> https://docs.oracle.com/javase/6/docs/api/java/util/Map.html
> >>> https://docs.oracle.com/javase/7/docs/api/java/util/Map.html
> >>> https://docs.oracle.com/javase/8/docs/api/java/util/Map.html
> >>>
> >>> Maybe its clirr issue?
> >>> Would appreciate any help with this investigation
> >>>
> >>> On Mon, 31 Dec 2018 at 16:53, Gilles <[hidden email]>
> >>> wrote:
> >>> >
> >>> > On Mon, 31 Dec 2018 07:41:40 +0700, Maxim Solodovnik wrote:
> >>> > > Hello Gilles,
> >>> > >
> >>> > > I already did analysis: [1], all errors are caused by previous
> >>> > > release
> >>> > > 4.3 doesn't introduce any new errors ...
> >>> > >
> >>> > > [1] https://markmail.org/message/l7ftxlvdk4yqxijt
> >>> >
> >>> > I had seen the post but it says:
> >>> > ---
> >>> > these errors are weird. Above classes has no changes comparing to
> >>> 4.2
> >>> > ---
> >>> >
> >>> > But IMHO it was not a conclusion: If the cause of the errors was
> >>> > identified, it could have been mentioned in the release notes
> >>> > and/or the [VOTE] email, in order to avoid further questioning.
> >>> >
> >>> > Is the cause the change of supported JDK?
> >>> >
> >>> > Regards,
> >>> > Gilles
> >>> >
> >>> > >
> >>> > > On Mon, 31 Dec 2018 at 07:26, Rob Tompkins <[hidden email]>
> >>> > > wrote:
> >>> > >>
> >>> > >> I’ll give it a look tonight or in the morning.
> >>> > >>
> >>> > >> -Rob
> >>> > >>
> >>> > >> > On Dec 30, 2018, at 12:25 AM, Maxim Solodovnik
> >>> > >> <[hidden email]> wrote:
> >>> > >> >
> >>> > >> > No votes after 3 days :(
> >>> > >> > Is there anything wrong with the RC?
> >>> > >> >
> >>> > >> >> On Thu, 27 Dec 2018 at 05:20, Bruno P. Kinoshita
> >>> > >> <[hidden email]> wrote:
> >>> > >> >>
> >>> > >> >> FWIW I had a similar experience, and realized I was doing
> >>> `git
> >>> > >> fetch --all`, but it didn't bring the tags. `git fetch --tags`
> >>> did
> >>> the
> >>> > >> trick. After that I could `git checkout $tag-name`
> >>> > >> >>
> >>> > >> >> Cheers
> >>> > >> >> Bruno
> >>> > >> >>
> >>> > >> >>
> >>> > >> >>
> >>> > >> >>
> >>> > >> >> ________________________________
> >>> > >> >> From: Gilles <[hidden email]>
> >>> > >> >> To: [hidden email]
> >>> > >> >> Sent: Thursday, 27 December 2018 9:26 AM
> >>> > >> >> Subject: Re: [VOTE][RC2] Commons collections 4.3
> >>> > >> >>
> >>> > >> >>
> >>> > >> >>
> >>> > >> >>> On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
> >>> > >> >>> Hi.
> >>> > >> >>>
> >>> > >> >>>> On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik
> >>> wrote:
> >>> > >> >>>> This is a [VOTE] for releasing
> >>> > >> >>>> Apache Commons collections 4.3
> >>> > >> >>>>
> >>> > >> >>>> Tag name:
> >>> > >> >>>>    collections-4.3-RC2 (signature can be checked from git
> >>> using
> >>> > >> >>>> 'git
> >>> > >> >>>> tag -v')
> >>> > >> >>>
> >>> > >> >>> $ git tag -v collections-4.3-RC2
> >>> > >> >>> error: tag 'collections-4.3-RC2' not found.
> >>> > >> >>>
> >>> > >> >>> Although I see it in the link below...
> >>> > >> >>> What is going on?
> >>> > >> >>
> >>> > >> >> Issue vanished with a fresh "clone".
> >>> > >> >> [Sorry for the noise.]
> >>> > >> >>
> >>> > >> >>
> >>> > >> >>>> RC1 was cancelled due to some release steps were not done
> >>> > >> >>>>
> >>> > >> >>>> Tag URL:
> >>> > >> >>>>
> >>> > >> >>>>
> >>> > >> >>>>
> >>> > >>
> >>>
> >>>
> https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=77e37dbf238d26351edb29e95391e3df75095d01
> >>> > >> >>>>
> >>> > >> >>>> Commit ID the tag points at:
> >>> > >> >>>>    77e37dbf238d26351edb29e95391e3df75095d01
> >>> > >> >>>>
> >>> > >> >>>> Site:
> >>> > >> >>>>
> >>> > >> >>>>
> >>> > >> >>>>
> >>> > >>
> >>>
> >>>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/index.html
> >>> > >> >>>
> >>> > >> >>> The Clirr report is still a problem:
> >>> > >> >>>
> >>> > >> >>>
> >>> > >> >>>
> >>> > >>
> >>>
> >>>
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/clirr-report.html
> >>> > >> >>>
> >>> > >> >>> [The same errors are reported on my machine, so it's
> >>> > >> >>> not a cache issue...]
> >>> > >> >>>
> >>> > >> >>> Regards,
> >>> > >> >>> Gilles
> >>> > >> >>>
> >>> > >> >>>>
> >>> > >> >>>> Distribution files (committed at revision 31689):
> >>> > >> >>>>
> >>> https://dist.apache.org/repos/dist/dev/commons/collections/
> >>> > >> >>>>
> >>> > >> >>>> Distribution files hashes (SHA256):
> >>> > >> >>>>  commons-collections4-4.3-bin.tar.gz
> >>> > >> >>>>
> >>> > >>
> >>> 214c12fae27403f1a16ca6c108b5a8682be1a885a0dbbfc8eb30941303e1fe94
> >>> > >> >>>>  commons-collections4-4.3-bin.zip
> >>> > >> >>>>
> >>> > >>
> >>> 75b51a98fea6fca3746a3f70c6a0be24c99849e4976c4649214eaa5a009d0aeb
> >>> > >> >>>>  commons-collections4-4.3-src.tar.gz
> >>> > >> >>>>
> >>> > >>
> >>> 399f403feca86dbba7c4162eb90174db45979a2f7db2b3e0ba48240dc43ab434
> >>> > >> >>>>  commons-collections4-4.3-src.zip
> >>> > >> >>>>
> >>> > >>
> >>> 1c637e260b5b9e372d196593c7617ad3adedb6da3ac9196d086f9fc24401f5c3
> >>> > >> >>>>
> >>> > >> >>>> KEYS file to check signatures:
> >>> > >> >>>>   https://www.apache.org/dist/commons/KEYS
> >>> > >> >>>>
> >>> > >> >>>> Maven artifacts:
> >>> > >> >>>>
> >>> > >> >>>>
> >>> > >>
> >>>
> >>>
> https://repository.apache.org/content/repositories/orgapachecommons-1405/
> >>> > >> >>>>
> >>> > >> >>>> Please select one of the following options:
> >>> > >> >>>>  [ ] +1 Release it.
> >>> > >> >>>>  [ ] +0 Go ahead; I don't care.
> >>> > >> >>>>  [ ] -0 There are a few minor glitches: ...
> >>> > >> >>>>  [ ] -1 No, do not release it because ...
> >>> > >> >>>>
> >>> > >> >>>> This vote will be open for at least 72 hours, i.e. until
> >>> > >> >>>> 2018-12-29T14:00:00Z
> >>> > >> >>>> (this is UTC time).
> >>> > >> >>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
1234