[VOTE][RC5] Release "Apache Commons RNG" version 1.0

classic Classic list List threaded Threaded
18 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE][RC5] Release "Apache Commons RNG" version 1.0

Gilles Sadowski
Hi.

This is a [VOTE] for releasing Apache Commons RNG 1.0 (from RC5).

Main changes wrt the preceding vote (RC2, on September 16) are:
   * Modularization
   * Non-uniform deviates (in module "commons-rng-sampling")


Tag name:
   RNG_1_0_RC5 (signature can be checked from git using 'git tag -v')

Tag URL:
   
https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=commit;h=f9de6401e981554c3f44936c2272429e290fdbec

Commit ID the tag points at:
   f9de6401e981554c3f44936c2272429e290fdbec

Site:
   http://home.apache.org/~erans/commons-rng-1.0-RC5-site

Distribution files:
   https://dist.apache.org/repos/dist/dev/commons/rng/

Distribution files hashes (SHA1):
   de2a54518a0ef10ba5a2be1c3b060a441f4466e2  
commons-rng-1.0-bin.tar.gz.sha1
   cfcfde1f65dec9c30be1273ff2237d551eb87933  
commons-rng-1.0-bin.zip.sha1
   6d529de9418314066727a7d5ada88dd87dc0163d  
commons-rng-1.0-src.tar.gz.sha1
   561dd3e5ebf53d60e883d5c04e543f58374c45b6  
commons-rng-1.0-src.zip.sha1

KEYS file to check signatures:
   http://www.apache.org/dist/commons/KEYS

Maven artifacts:
   
https://repository.apache.org/content/repositories/orgapachecommons-1225/


[ ] +1 Release it.
[ ] +0 Go ahead; I don't care.
[ ] -0 There are a few minor glitches: ...
[ ] -1 No, do not release it because ...

This vote will close in 72 hours, at 2016-12-03T00:00:00Z (this is UTC
time).
----------


Thanks,
Gilles


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC5] Release "Apache Commons RNG" version 1.0

Stian Soiland-Reyes
My vote: +1 (binding)

Looking good!


Checked:

+1 commit matches tag (even signed tag, yay!)
+0 commit matches src (git tag is missing
"<createChecksum>true</createChecksum>" -- why?)
+0 src matches staging repo -sources (hard to check as *-src.tar.gz
was not staged :-( )
+1 bin JARs matches staging repo hashes
+1 zip vs tar.gz
+1 .asc signatures of dist and repo
+1 md5/sha1 hashes (email's hash filenames says .sha1, but match
correctly the zip/tar.gz)
+0 mvn apache-rat:check (exceptions are already excluded for <reporting>)
+1 no unexpected binaries
+1 mvn clean install
  +1 .. and afterwards in commons-rng-examples
+0 binary vs source (binary adds commons-rng-examples-1.0.jar, built
separately in source)
+1 RELEASE-NOTES
+1 LICENSE, NOTICE
+1 site (minor markdown highlight bug "64 bits" at
http://home.apache.org/~erans/commons-rng-1.0-RC5-site/userguide/rng.html)
+1 javadoc

On 30 November 2016 at 00:08, Gilles <[hidden email]> wrote:

> Hi.
>
> This is a [VOTE] for releasing Apache Commons RNG 1.0 (from RC5).
>
> Main changes wrt the preceding vote (RC2, on September 16) are:
>   * Modularization
>   * Non-uniform deviates (in module "commons-rng-sampling")
>
>
> Tag name:
>   RNG_1_0_RC5 (signature can be checked from git using 'git tag -v')
>
> Tag URL:
>
> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=commit;h=f9de6401e981554c3f44936c2272429e290fdbec
>
> Commit ID the tag points at:
>   f9de6401e981554c3f44936c2272429e290fdbec
>
> Site:
>   http://home.apache.org/~erans/commons-rng-1.0-RC5-site
>
> Distribution files:
>   https://dist.apache.org/repos/dist/dev/commons/rng/
>
> Distribution files hashes (SHA1):
>   de2a54518a0ef10ba5a2be1c3b060a441f4466e2  commons-rng-1.0-bin.tar.gz.sha1
>   cfcfde1f65dec9c30be1273ff2237d551eb87933  commons-rng-1.0-bin.zip.sha1
>   6d529de9418314066727a7d5ada88dd87dc0163d  commons-rng-1.0-src.tar.gz.sha1
>   561dd3e5ebf53d60e883d5c04e543f58374c45b6  commons-rng-1.0-src.zip.sha1
>
> KEYS file to check signatures:
>   http://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
>   https://repository.apache.org/content/repositories/orgapachecommons-1225/
>
>
> [ ] +1 Release it.
> [ ] +0 Go ahead; I don't care.
> [ ] -0 There are a few minor glitches: ...
> [ ] -1 No, do not release it because ...
>
> This vote will close in 72 hours, at 2016-12-03T00:00:00Z (this is UTC
> time).
> ----------
>
>
> Thanks,
> Gilles
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>



--
Stian Soiland-Reyes
http://orcid.org/0000-0001-9842-9718

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC5] Release "Apache Commons RNG" version 1.0

Artem Barger
My vote: +1

Best regards,
                      Artem Barger.

On Thu, Dec 1, 2016 at 2:01 PM, Stian Soiland-Reyes <[hidden email]>
wrote:

> My vote: +1 (binding)
>
> Looking good!
>
>
> Checked:
>
> +1 commit matches tag (even signed tag, yay!)
> +0 commit matches src (git tag is missing
> "<createChecksum>true</createChecksum>" -- why?)
> +0 src matches staging repo -sources (hard to check as *-src.tar.gz
> was not staged :-( )
> +1 bin JARs matches staging repo hashes
> +1 zip vs tar.gz
> +1 .asc signatures of dist and repo
> +1 md5/sha1 hashes (email's hash filenames says .sha1, but match
> correctly the zip/tar.gz)
> +0 mvn apache-rat:check (exceptions are already excluded for <reporting>)
> +1 no unexpected binaries
> +1 mvn clean install
>   +1 .. and afterwards in commons-rng-examples
> +0 binary vs source (binary adds commons-rng-examples-1.0.jar, built
> separately in source)
> +1 RELEASE-NOTES
> +1 LICENSE, NOTICE
> +1 site (minor markdown highlight bug "64 bits" at
> http://home.apache.org/~erans/commons-rng-1.0-RC5-site/userguide/rng.html)
> +1 javadoc
>
> On 30 November 2016 at 00:08, Gilles <[hidden email]> wrote:
> > Hi.
> >
> > This is a [VOTE] for releasing Apache Commons RNG 1.0 (from RC5).
> >
> > Main changes wrt the preceding vote (RC2, on September 16) are:
> >   * Modularization
> >   * Non-uniform deviates (in module "commons-rng-sampling")
> >
> >
> > Tag name:
> >   RNG_1_0_RC5 (signature can be checked from git using 'git tag -v')
> >
> > Tag URL:
> >
> > https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=commit;h=
> f9de6401e981554c3f44936c2272429e290fdbec
> >
> > Commit ID the tag points at:
> >   f9de6401e981554c3f44936c2272429e290fdbec
> >
> > Site:
> >   http://home.apache.org/~erans/commons-rng-1.0-RC5-site
> >
> > Distribution files:
> >   https://dist.apache.org/repos/dist/dev/commons/rng/
> >
> > Distribution files hashes (SHA1):
> >   de2a54518a0ef10ba5a2be1c3b060a441f4466e2  commons-rng-1.0-bin.tar.gz.
> sha1
> >   cfcfde1f65dec9c30be1273ff2237d551eb87933  commons-rng-1.0-bin.zip.sha1
> >   6d529de9418314066727a7d5ada88dd87dc0163d  commons-rng-1.0-src.tar.gz.
> sha1
> >   561dd3e5ebf53d60e883d5c04e543f58374c45b6  commons-rng-1.0-src.zip.sha1
> >
> > KEYS file to check signatures:
> >   http://www.apache.org/dist/commons/KEYS
> >
> > Maven artifacts:
> >   https://repository.apache.org/content/repositories/
> orgapachecommons-1225/
> >
> >
> > [ ] +1 Release it.
> > [ ] +0 Go ahead; I don't care.
> > [ ] -0 There are a few minor glitches: ...
> > [ ] -1 No, do not release it because ...
> >
> > This vote will close in 72 hours, at 2016-12-03T00:00:00Z (this is UTC
> > time).
> > ----------
> >
> >
> > Thanks,
> > Gilles
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
>
>
> --
> Stian Soiland-Reyes
> http://orcid.org/0000-0001-9842-9718
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC5] Release "Apache Commons RNG" version 1.0

Oliver Heger-3
In reply to this post by Gilles Sadowski
Hi,

build works fine with Java 7 and Java 8 on Windows 10. When building
with Java 1.6 I got a test failure in the Sampling module (see below),
but it does not seem to be reproducible; probably not blocking.

The artifacts from the binary distribution do not contain the LICENSE
and NOTICE files. I think this is a blocker for the release.

The site looks good, but I am missing a link for the Javadocs. As a
minor nit, the RAT report contains unknown licenses in some checksum
files; maybe some spurious files?

-1 because of the missing license files, sorry.

Oliver

Test failure:
Failed tests:
  ContinuousSamplerParametricTest.testSampling:53->check:127
org.apache.commons.math3.distribution.NormalDistribution@59d2400d
(inverse method) [rng=org.apache.commons.rng.core.source32.KISSRandom]:
Too many failures for sample size = 20000 (3 out of 50 tests failed,
chi2=[26.369, 23.043, 31.568000000000005]
  ContinuousSamplerParametricTest.testSampling:53->check:127
Ahrens-Dieter-Marsaglia-Tsang Gamma deviate
[rng=org.apache.commons.rng.core.source64.XorShift1024Star]: Too many
failures for sample size = 20000 (3 out of 50 tests failed,
chi2=[25.784999999999997, 24.829, 22.042000000000005]

Am 30.11.2016 um 01:08 schrieb Gilles:

> Hi.
>
> This is a [VOTE] for releasing Apache Commons RNG 1.0 (from RC5).
>
> Main changes wrt the preceding vote (RC2, on September 16) are:
>   * Modularization
>   * Non-uniform deviates (in module "commons-rng-sampling")
>
>
> Tag name:
>   RNG_1_0_RC5 (signature can be checked from git using 'git tag -v')
>
> Tag URL:
>  
> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=commit;h=f9de6401e981554c3f44936c2272429e290fdbec
>
>
> Commit ID the tag points at:
>   f9de6401e981554c3f44936c2272429e290fdbec
>
> Site:
>   http://home.apache.org/~erans/commons-rng-1.0-RC5-site
>
> Distribution files:
>   https://dist.apache.org/repos/dist/dev/commons/rng/
>
> Distribution files hashes (SHA1):
>   de2a54518a0ef10ba5a2be1c3b060a441f4466e2  commons-rng-1.0-bin.tar.gz.sha1
>   cfcfde1f65dec9c30be1273ff2237d551eb87933  commons-rng-1.0-bin.zip.sha1
>   6d529de9418314066727a7d5ada88dd87dc0163d  commons-rng-1.0-src.tar.gz.sha1
>   561dd3e5ebf53d60e883d5c04e543f58374c45b6  commons-rng-1.0-src.zip.sha1
>
> KEYS file to check signatures:
>   http://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
>   https://repository.apache.org/content/repositories/orgapachecommons-1225/
>
>
> [ ] +1 Release it.
> [ ] +0 Go ahead; I don't care.
> [ ] -0 There are a few minor glitches: ...
> [ ] -1 No, do not release it because ...
>
> This vote will close in 72 hours, at 2016-12-03T00:00:00Z (this is UTC
> time).
> ----------
>
>
> Thanks,
> Gilles
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC5] Release "Apache Commons RNG" version 1.0

Gilles Sadowski
Hello.

On Thu, 1 Dec 2016 22:14:58 +0100, Oliver Heger wrote:
> Hi,
>
> build works fine with Java 7 and Java 8 on Windows 10. When building
> with Java 1.6 I got a test failure in the Sampling module (see
> below),
> but it does not seem to be reproducible; probably not blocking.

Cf. https://issues.apache.org/jira/browse/RNG-30

>
> The artifacts from the binary distribution do not contain the LICENSE
> and NOTICE files. I think this is a blocker for the release.

Which artefacts (link)?

> The site looks good, but I am missing a link for the Javadocs. As a
> minor nit, the RAT report contains unknown licenses in some checksum
> files; maybe some spurious files?

Indeed. They are not included in the tag.
[Shouldn't the "target" directory be ignored by default?]

Thanks,
Gilles

> -1 because of the missing license files, sorry.
>
> Oliver
>
> Test failure:
> Failed tests:
>   ContinuousSamplerParametricTest.testSampling:53->check:127
> org.apache.commons.math3.distribution.NormalDistribution@59d2400d
> (inverse method)
> [rng=org.apache.commons.rng.core.source32.KISSRandom]:
> Too many failures for sample size = 20000 (3 out of 50 tests failed,
> chi2=[26.369, 23.043, 31.568000000000005]
>   ContinuousSamplerParametricTest.testSampling:53->check:127
> Ahrens-Dieter-Marsaglia-Tsang Gamma deviate
> [rng=org.apache.commons.rng.core.source64.XorShift1024Star]: Too many
> failures for sample size = 20000 (3 out of 50 tests failed,
> chi2=[25.784999999999997, 24.829, 22.042000000000005]
>
> Am 30.11.2016 um 01:08 schrieb Gilles:
>> Hi.
>>
>> This is a [VOTE] for releasing Apache Commons RNG 1.0 (from RC5).
>>
>> Main changes wrt the preceding vote (RC2, on September 16) are:
>>   * Modularization
>>   * Non-uniform deviates (in module "commons-rng-sampling")
>>
>>
>> Tag name:
>>   RNG_1_0_RC5 (signature can be checked from git using 'git tag -v')
>>
>> Tag URL:
>>
>>
>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=commit;h=f9de6401e981554c3f44936c2272429e290fdbec
>>
>>
>> Commit ID the tag points at:
>>   f9de6401e981554c3f44936c2272429e290fdbec
>>
>> Site:
>>   http://home.apache.org/~erans/commons-rng-1.0-RC5-site
>>
>> Distribution files:
>>   https://dist.apache.org/repos/dist/dev/commons/rng/
>>
>> Distribution files hashes (SHA1):
>>   de2a54518a0ef10ba5a2be1c3b060a441f4466e2  
>> commons-rng-1.0-bin.tar.gz.sha1
>>   cfcfde1f65dec9c30be1273ff2237d551eb87933  
>> commons-rng-1.0-bin.zip.sha1
>>   6d529de9418314066727a7d5ada88dd87dc0163d  
>> commons-rng-1.0-src.tar.gz.sha1
>>   561dd3e5ebf53d60e883d5c04e543f58374c45b6  
>> commons-rng-1.0-src.zip.sha1
>>
>> KEYS file to check signatures:
>>   http://www.apache.org/dist/commons/KEYS
>>
>> Maven artifacts:
>>  
>> https://repository.apache.org/content/repositories/orgapachecommons-1225/
>>
>>
>> [ ] +1 Release it.
>> [ ] +0 Go ahead; I don't care.
>> [ ] -0 There are a few minor glitches: ...
>> [ ] -1 No, do not release it because ...
>>
>> This vote will close in 72 hours, at 2016-12-03T00:00:00Z (this is
>> UTC
>> time).
>> ----------
>>
>>
>> Thanks,
>> Gilles
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC5] Release "Apache Commons RNG" version 1.0

Rob Tompkins
In reply to this post by Artem Barger
Vote: -1 mainly for license, but there’s the following as well.

I just ran “mvn clean test" with java 1.7.0_60 on OS X 10.12.1 and got the following test failure (note that it seems to be intermittent):

testSampling[22: data=org.apache.commons.math3.distribution.ParetoDistribution@185c0deb (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres: [0x0f1505c780688cb5L, 33, 192641895])]: deciles=[55.074313383177326, 143.04583109008863, 422.11049795027907, 1472.1250669034735, 6450.716651619402, 39349.60019433535, 404957.85425759235, 1.0824440136808794E7, 2.9776288373121433E9]](org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest)  Time elapsed: 2.792 sec  <<< FAILURE!
java.lang.AssertionError: org.apache.commons.math3.distribution.ParetoDistribution@185c0deb (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres: [0x0f1505c780688cb5L, 33, 192641895])]: Too many failures for sample size = 20000 (3 out of 50 tests failed, chi2=[24.237000000000002, 21.682000000000002, 23.912000000000003]
        at org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest.check(ContinuousSamplerParametricTest.java:127)
        at org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest.testSampling(ContinuousSamplerParametricTest.java:53)

Running org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.134 sec - in org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
Running org.apache.commons.rng.sampling.ListSamplerTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.034 sec - in org.apache.commons.rng.sampling.ListSamplerTest
Running org.apache.commons.rng.sampling.PermutationSamplerTest
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec - in org.apache.commons.rng.sampling.PermutationSamplerTest

Results :

Failed tests:
  ContinuousSamplerParametricTest.testSampling:53->check:127 org.apache.commons.math3.distribution.ParetoDistribution@185c0deb (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres: [0x0f1505c780688cb5L, 33, 192641895])]: Too many failures for sample size = 20000 (3 out of 50 tests failed, chi2=[24.237000000000002, 21.682000000000002, 23.912000000000003]


> On Dec 1, 2016, at 6:18 AM, Artem Barger <[hidden email]> wrote:
>
> My vote: +1
>
> Best regards,
>                      Artem Barger.
>
> On Thu, Dec 1, 2016 at 2:01 PM, Stian Soiland-Reyes <[hidden email]>
> wrote:
>
>> My vote: +1 (binding)
>>
>> Looking good!
>>
>>
>> Checked:
>>
>> +1 commit matches tag (even signed tag, yay!)
>> +0 commit matches src (git tag is missing
>> "<createChecksum>true</createChecksum>" -- why?)
>> +0 src matches staging repo -sources (hard to check as *-src.tar.gz
>> was not staged :-( )
>> +1 bin JARs matches staging repo hashes
>> +1 zip vs tar.gz
>> +1 .asc signatures of dist and repo
>> +1 md5/sha1 hashes (email's hash filenames says .sha1, but match
>> correctly the zip/tar.gz)
>> +0 mvn apache-rat:check (exceptions are already excluded for <reporting>)
>> +1 no unexpected binaries
>> +1 mvn clean install
>>  +1 .. and afterwards in commons-rng-examples
>> +0 binary vs source (binary adds commons-rng-examples-1.0.jar, built
>> separately in source)
>> +1 RELEASE-NOTES
>> +1 LICENSE, NOTICE
>> +1 site (minor markdown highlight bug "64 bits" at
>> http://home.apache.org/~erans/commons-rng-1.0-RC5-site/userguide/rng.html)
>> +1 javadoc
>>
>> On 30 November 2016 at 00:08, Gilles <[hidden email]> wrote:
>>> Hi.
>>>
>>> This is a [VOTE] for releasing Apache Commons RNG 1.0 (from RC5).
>>>
>>> Main changes wrt the preceding vote (RC2, on September 16) are:
>>>  * Modularization
>>>  * Non-uniform deviates (in module "commons-rng-sampling")
>>>
>>>
>>> Tag name:
>>>  RNG_1_0_RC5 (signature can be checked from git using 'git tag -v')
>>>
>>> Tag URL:
>>>
>>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=commit;h=
>> f9de6401e981554c3f44936c2272429e290fdbec
>>>
>>> Commit ID the tag points at:
>>>  f9de6401e981554c3f44936c2272429e290fdbec
>>>
>>> Site:
>>>  http://home.apache.org/~erans/commons-rng-1.0-RC5-site
>>>
>>> Distribution files:
>>>  https://dist.apache.org/repos/dist/dev/commons/rng/
>>>
>>> Distribution files hashes (SHA1):
>>>  de2a54518a0ef10ba5a2be1c3b060a441f4466e2  commons-rng-1.0-bin.tar.gz.
>> sha1
>>>  cfcfde1f65dec9c30be1273ff2237d551eb87933  commons-rng-1.0-bin.zip.sha1
>>>  6d529de9418314066727a7d5ada88dd87dc0163d  commons-rng-1.0-src.tar.gz.
>> sha1
>>>  561dd3e5ebf53d60e883d5c04e543f58374c45b6  commons-rng-1.0-src.zip.sha1
>>>
>>> KEYS file to check signatures:
>>>  http://www.apache.org/dist/commons/KEYS
>>>
>>> Maven artifacts:
>>>  https://repository.apache.org/content/repositories/
>> orgapachecommons-1225/
>>>
>>>
>>> [ ] +1 Release it.
>>> [ ] +0 Go ahead; I don't care.
>>> [ ] -0 There are a few minor glitches: ...
>>> [ ] -1 No, do not release it because ...
>>>
>>> This vote will close in 72 hours, at 2016-12-03T00:00:00Z (this is UTC
>>> time).
>>> ----------
>>>
>>>
>>> Thanks,
>>> Gilles
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>
>>
>>
>> --
>> Stian Soiland-Reyes
>> http://orcid.org/0000-0001-9842-9718
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC5] Release "Apache Commons RNG" version 1.0

Gilles Sadowski
On Thu, 1 Dec 2016 15:29:17 -0800, Rob Tompkins wrote:
> Vote: -1 mainly for license,

Which files?

> but there’s the following as well.
>
> I just ran “mvn clean test" with java 1.7.0_60 on OS X 10.12.1 and
> got the following test failure (note that it seems to be
> intermittent):

Cf. https://issues.apache.org/jira/browse/RNG-30

Regards,
Gilles

> testSampling[22:
>
> data=org.apache.commons.math3.distribution.ParetoDistribution@185c0deb
> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
> [0x0f1505c780688cb5L, 33, 192641895])]: deciles=[55.074313383177326,
> 143.04583109008863, 422.11049795027907, 1472.1250669034735,
> 6450.716651619402, 39349.60019433535, 404957.85425759235,
> 1.0824440136808794E7,
>
> 2.9776288373121433E9]](org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest)
>  Time elapsed: 2.792 sec  <<< FAILURE!
> java.lang.AssertionError:
> org.apache.commons.math3.distribution.ParetoDistribution@185c0deb
> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
> [0x0f1505c780688cb5L, 33, 192641895])]: Too many failures for sample
> size = 20000 (3 out of 50 tests failed, chi2=[24.237000000000002,
> 21.682000000000002, 23.912000000000003]
> at
>
> org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest.check(ContinuousSamplerParametricTest.java:127)
> at
>
> org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest.testSampling(ContinuousSamplerParametricTest.java:53)
>
> Running
>
> org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
> Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
> 7.134 sec - in
>
> org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
> Running org.apache.commons.rng.sampling.ListSamplerTest
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.034
> sec - in org.apache.commons.rng.sampling.ListSamplerTest
> Running org.apache.commons.rng.sampling.PermutationSamplerTest
> Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
> 0.014 sec - in org.apache.commons.rng.sampling.PermutationSamplerTest
>
> Results :
>
> Failed tests:
>   ContinuousSamplerParametricTest.testSampling:53->check:127
> org.apache.commons.math3.distribution.ParetoDistribution@185c0deb
> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
> [0x0f1505c780688cb5L, 33, 192641895])]: Too many failures for sample
> size = 20000 (3 out of 50 tests failed, chi2=[24.237000000000002,
> 21.682000000000002, 23.912000000000003]
>
>
>> On Dec 1, 2016, at 6:18 AM, Artem Barger <[hidden email]> wrote:
>>
>> My vote: +1
>>
>> Best regards,
>>                      Artem Barger.
>>
>> On Thu, Dec 1, 2016 at 2:01 PM, Stian Soiland-Reyes
>> <[hidden email]>
>> wrote:
>>
>>> My vote: +1 (binding)
>>>
>>> Looking good!
>>>
>>>
>>> Checked:
>>>
>>> +1 commit matches tag (even signed tag, yay!)
>>> +0 commit matches src (git tag is missing
>>> "<createChecksum>true</createChecksum>" -- why?)
>>> +0 src matches staging repo -sources (hard to check as *-src.tar.gz
>>> was not staged :-( )
>>> +1 bin JARs matches staging repo hashes
>>> +1 zip vs tar.gz
>>> +1 .asc signatures of dist and repo
>>> +1 md5/sha1 hashes (email's hash filenames says .sha1, but match
>>> correctly the zip/tar.gz)
>>> +0 mvn apache-rat:check (exceptions are already excluded for
>>> <reporting>)
>>> +1 no unexpected binaries
>>> +1 mvn clean install
>>>  +1 .. and afterwards in commons-rng-examples
>>> +0 binary vs source (binary adds commons-rng-examples-1.0.jar,
>>> built
>>> separately in source)
>>> +1 RELEASE-NOTES
>>> +1 LICENSE, NOTICE
>>> +1 site (minor markdown highlight bug "64 bits" at
>>>
>>> http://home.apache.org/~erans/commons-rng-1.0-RC5-site/userguide/rng.html)
>>> +1 javadoc
>>>
>>> On 30 November 2016 at 00:08, Gilles <[hidden email]>
>>> wrote:
>>>> Hi.
>>>>
>>>> This is a [VOTE] for releasing Apache Commons RNG 1.0 (from RC5).
>>>>
>>>> Main changes wrt the preceding vote (RC2, on September 16) are:
>>>>  * Modularization
>>>>  * Non-uniform deviates (in module "commons-rng-sampling")
>>>>
>>>>
>>>> Tag name:
>>>>  RNG_1_0_RC5 (signature can be checked from git using 'git tag
>>>> -v')
>>>>
>>>> Tag URL:
>>>>
>>>>
>>>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=commit;h=
>>> f9de6401e981554c3f44936c2272429e290fdbec
>>>>
>>>> Commit ID the tag points at:
>>>>  f9de6401e981554c3f44936c2272429e290fdbec
>>>>
>>>> Site:
>>>>  http://home.apache.org/~erans/commons-rng-1.0-RC5-site
>>>>
>>>> Distribution files:
>>>>  https://dist.apache.org/repos/dist/dev/commons/rng/
>>>>
>>>> Distribution files hashes (SHA1):
>>>>  de2a54518a0ef10ba5a2be1c3b060a441f4466e2  
>>>> commons-rng-1.0-bin.tar.gz.
>>> sha1
>>>>  cfcfde1f65dec9c30be1273ff2237d551eb87933  
>>>> commons-rng-1.0-bin.zip.sha1
>>>>  6d529de9418314066727a7d5ada88dd87dc0163d  
>>>> commons-rng-1.0-src.tar.gz.
>>> sha1
>>>>  561dd3e5ebf53d60e883d5c04e543f58374c45b6  
>>>> commons-rng-1.0-src.zip.sha1
>>>>
>>>> KEYS file to check signatures:
>>>>  http://www.apache.org/dist/commons/KEYS
>>>>
>>>> Maven artifacts:
>>>>  https://repository.apache.org/content/repositories/
>>> orgapachecommons-1225/
>>>>
>>>>
>>>> [ ] +1 Release it.
>>>> [ ] +0 Go ahead; I don't care.
>>>> [ ] -0 There are a few minor glitches: ...
>>>> [ ] -1 No, do not release it because ...
>>>>
>>>> This vote will close in 72 hours, at 2016-12-03T00:00:00Z (this is
>>>> UTC
>>>> time).
>>>> ----------
>>>>
>>>>
>>>> Thanks,
>>>> Gilles
>>>>
>>>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC5] Release "Apache Commons RNG" version 1.0

Rob Tompkins

> On Dec 1, 2016, at 3:32 PM, Gilles <[hidden email]> wrote:
>
> On Thu, 1 Dec 2016 15:29:17 -0800, Rob Tompkins wrote:
>> Vote: -1 mainly for license,
>
> Which files?

The LICENSE.txt and NOTICE.txt aren’t in the META-INF directory of the main jar artifact for at least rng-core, whereas http://repo1.maven.org/maven2/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar <http://repo1.maven.org/maven2/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar> does contain those files.

Sorry…If you want I can hop in and see if I can get the assembly plugin to accommodate for that and include them.

-Rob

>
>> but there’s the following as well.
>>
>> I just ran “mvn clean test" with java 1.7.0_60 on OS X 10.12.1 and
>> got the following test failure (note that it seems to be
>> intermittent):
>
> Cf. https://issues.apache.org/jira/browse/RNG-30
>
> Regards,
> Gilles
>
>> testSampling[22:
>> data=org.apache.commons.math3.distribution.ParetoDistribution@185c0deb
>> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
>> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
>> [0x0f1505c780688cb5L, 33, 192641895])]: deciles=[55.074313383177326,
>> 143.04583109008863, 422.11049795027907, 1472.1250669034735,
>> 6450.716651619402, 39349.60019433535, 404957.85425759235,
>> 1.0824440136808794E7,
>> 2.9776288373121433E9]](org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest)
>> Time elapsed: 2.792 sec  <<< FAILURE!
>> java.lang.AssertionError:
>> org.apache.commons.math3.distribution.ParetoDistribution@185c0deb
>> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
>> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
>> [0x0f1505c780688cb5L, 33, 192641895])]: Too many failures for sample
>> size = 20000 (3 out of 50 tests failed, chi2=[24.237000000000002,
>> 21.682000000000002, 23.912000000000003]
>> at
>> org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest.check(ContinuousSamplerParametricTest.java:127)
>> at
>> org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest.testSampling(ContinuousSamplerParametricTest.java:53)
>>
>> Running
>> org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
>> Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
>> 7.134 sec - in
>> org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
>> Running org.apache.commons.rng.sampling.ListSamplerTest
>> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.034
>> sec - in org.apache.commons.rng.sampling.ListSamplerTest
>> Running org.apache.commons.rng.sampling.PermutationSamplerTest
>> Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
>> 0.014 sec - in org.apache.commons.rng.sampling.PermutationSamplerTest
>>
>> Results :
>>
>> Failed tests:
>>  ContinuousSamplerParametricTest.testSampling:53->check:127
>> org.apache.commons.math3.distribution.ParetoDistribution@185c0deb
>> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
>> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
>> [0x0f1505c780688cb5L, 33, 192641895])]: Too many failures for sample
>> size = 20000 (3 out of 50 tests failed, chi2=[24.237000000000002,
>> 21.682000000000002, 23.912000000000003]
>>
>>
>>> On Dec 1, 2016, at 6:18 AM, Artem Barger <[hidden email]> wrote:
>>>
>>> My vote: +1
>>>
>>> Best regards,
>>>                     Artem Barger.
>>>
>>> On Thu, Dec 1, 2016 at 2:01 PM, Stian Soiland-Reyes <[hidden email]>
>>> wrote:
>>>
>>>> My vote: +1 (binding)
>>>>
>>>> Looking good!
>>>>
>>>>
>>>> Checked:
>>>>
>>>> +1 commit matches tag (even signed tag, yay!)
>>>> +0 commit matches src (git tag is missing
>>>> "<createChecksum>true</createChecksum>" -- why?)
>>>> +0 src matches staging repo -sources (hard to check as *-src.tar.gz
>>>> was not staged :-( )
>>>> +1 bin JARs matches staging repo hashes
>>>> +1 zip vs tar.gz
>>>> +1 .asc signatures of dist and repo
>>>> +1 md5/sha1 hashes (email's hash filenames says .sha1, but match
>>>> correctly the zip/tar.gz)
>>>> +0 mvn apache-rat:check (exceptions are already excluded for <reporting>)
>>>> +1 no unexpected binaries
>>>> +1 mvn clean install
>>>> +1 .. and afterwards in commons-rng-examples
>>>> +0 binary vs source (binary adds commons-rng-examples-1.0.jar, built
>>>> separately in source)
>>>> +1 RELEASE-NOTES
>>>> +1 LICENSE, NOTICE
>>>> +1 site (minor markdown highlight bug "64 bits" at
>>>> http://home.apache.org/~erans/commons-rng-1.0-RC5-site/userguide/rng.html)
>>>> +1 javadoc
>>>>
>>>> On 30 November 2016 at 00:08, Gilles <[hidden email]> wrote:
>>>>> Hi.
>>>>>
>>>>> This is a [VOTE] for releasing Apache Commons RNG 1.0 (from RC5).
>>>>>
>>>>> Main changes wrt the preceding vote (RC2, on September 16) are:
>>>>> * Modularization
>>>>> * Non-uniform deviates (in module "commons-rng-sampling")
>>>>>
>>>>>
>>>>> Tag name:
>>>>> RNG_1_0_RC5 (signature can be checked from git using 'git tag -v')
>>>>>
>>>>> Tag URL:
>>>>>
>>>>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=commit;h=
>>>> f9de6401e981554c3f44936c2272429e290fdbec
>>>>>
>>>>> Commit ID the tag points at:
>>>>> f9de6401e981554c3f44936c2272429e290fdbec
>>>>>
>>>>> Site:
>>>>> http://home.apache.org/~erans/commons-rng-1.0-RC5-site
>>>>>
>>>>> Distribution files:
>>>>> https://dist.apache.org/repos/dist/dev/commons/rng/
>>>>>
>>>>> Distribution files hashes (SHA1):
>>>>> de2a54518a0ef10ba5a2be1c3b060a441f4466e2  commons-rng-1.0-bin.tar.gz.
>>>> sha1
>>>>> cfcfde1f65dec9c30be1273ff2237d551eb87933  commons-rng-1.0-bin.zip.sha1
>>>>> 6d529de9418314066727a7d5ada88dd87dc0163d  commons-rng-1.0-src.tar.gz.
>>>> sha1
>>>>> 561dd3e5ebf53d60e883d5c04e543f58374c45b6  commons-rng-1.0-src.zip.sha1
>>>>>
>>>>> KEYS file to check signatures:
>>>>> http://www.apache.org/dist/commons/KEYS
>>>>>
>>>>> Maven artifacts:
>>>>> https://repository.apache.org/content/repositories/
>>>> orgapachecommons-1225/
>>>>>
>>>>>
>>>>> [ ] +1 Release it.
>>>>> [ ] +0 Go ahead; I don't care.
>>>>> [ ] -0 There are a few minor glitches: ...
>>>>> [ ] -1 No, do not release it because ...
>>>>>
>>>>> This vote will close in 72 hours, at 2016-12-03T00:00:00Z (this is UTC
>>>>> time).
>>>>> ----------
>>>>>
>>>>>
>>>>> Thanks,
>>>>> Gilles
>>>>>
>>>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC5] Release "Apache Commons RNG" version 1.0

Rob Tompkins
In reply to this post by Gilles Sadowski

> On Dec 1, 2016, at 3:32 PM, Gilles <[hidden email]> wrote:
>
> On Thu, 1 Dec 2016 15:29:17 -0800, Rob Tompkins wrote:
>> Vote: -1 mainly for license,
>
> Which files?
>
>> but there’s the following as well.
>>
>> I just ran “mvn clean test" with java 1.7.0_60 on OS X 10.12.1 and
>> got the following test failure (note that it seems to be
>> intermittent):
>
> Cf. https://issues.apache.org/jira/browse/RNG-30 <https://issues.apache.org/jira/browse/RNG-30>

I don’t know what to do here. On one hand it really feels like our builds should be deterministic, but on the other hand you need to need to exercise the code fully in your unit tests. I’m really at odds with myself, but I think I lean towards determinism.

-Rob

>
> Regards,
> Gilles
>
>> testSampling[22:
>> data=org.apache.commons.math3.distribution.ParetoDistribution@185c0deb
>> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
>> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
>> [0x0f1505c780688cb5L, 33, 192641895])]: deciles=[55.074313383177326,
>> 143.04583109008863, 422.11049795027907, 1472.1250669034735,
>> 6450.716651619402, 39349.60019433535, 404957.85425759235,
>> 1.0824440136808794E7,
>> 2.9776288373121433E9]](org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest)
>> Time elapsed: 2.792 sec  <<< FAILURE!
>> java.lang.AssertionError:
>> org.apache.commons.math3.distribution.ParetoDistribution@185c0deb
>> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
>> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
>> [0x0f1505c780688cb5L, 33, 192641895])]: Too many failures for sample
>> size = 20000 (3 out of 50 tests failed, chi2=[24.237000000000002,
>> 21.682000000000002, 23.912000000000003]
>> at
>> org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest.check(ContinuousSamplerParametricTest.java:127)
>> at
>> org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest.testSampling(ContinuousSamplerParametricTest.java:53)
>>
>> Running
>> org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
>> Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
>> 7.134 sec - in
>> org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
>> Running org.apache.commons.rng.sampling.ListSamplerTest
>> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.034
>> sec - in org.apache.commons.rng.sampling.ListSamplerTest
>> Running org.apache.commons.rng.sampling.PermutationSamplerTest
>> Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
>> 0.014 sec - in org.apache.commons.rng.sampling.PermutationSamplerTest
>>
>> Results :
>>
>> Failed tests:
>>  ContinuousSamplerParametricTest.testSampling:53->check:127
>> org.apache.commons.math3.distribution.ParetoDistribution@185c0deb
>> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
>> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
>> [0x0f1505c780688cb5L, 33, 192641895])]: Too many failures for sample
>> size = 20000 (3 out of 50 tests failed, chi2=[24.237000000000002,
>> 21.682000000000002, 23.912000000000003]
>>
>>
>>> On Dec 1, 2016, at 6:18 AM, Artem Barger <[hidden email]> wrote:
>>>
>>> My vote: +1
>>>
>>> Best regards,
>>>                     Artem Barger.
>>>
>>> On Thu, Dec 1, 2016 at 2:01 PM, Stian Soiland-Reyes <[hidden email]>
>>> wrote:
>>>
>>>> My vote: +1 (binding)
>>>>
>>>> Looking good!
>>>>
>>>>
>>>> Checked:
>>>>
>>>> +1 commit matches tag (even signed tag, yay!)
>>>> +0 commit matches src (git tag is missing
>>>> "<createChecksum>true</createChecksum>" -- why?)
>>>> +0 src matches staging repo -sources (hard to check as *-src.tar.gz
>>>> was not staged :-( )
>>>> +1 bin JARs matches staging repo hashes
>>>> +1 zip vs tar.gz
>>>> +1 .asc signatures of dist and repo
>>>> +1 md5/sha1 hashes (email's hash filenames says .sha1, but match
>>>> correctly the zip/tar.gz)
>>>> +0 mvn apache-rat:check (exceptions are already excluded for <reporting>)
>>>> +1 no unexpected binaries
>>>> +1 mvn clean install
>>>> +1 .. and afterwards in commons-rng-examples
>>>> +0 binary vs source (binary adds commons-rng-examples-1.0.jar, built
>>>> separately in source)
>>>> +1 RELEASE-NOTES
>>>> +1 LICENSE, NOTICE
>>>> +1 site (minor markdown highlight bug "64 bits" at
>>>> http://home.apache.org/~erans/commons-rng-1.0-RC5-site/userguide/rng.html)
>>>> +1 javadoc
>>>>
>>>> On 30 November 2016 at 00:08, Gilles <[hidden email]> wrote:
>>>>> Hi.
>>>>>
>>>>> This is a [VOTE] for releasing Apache Commons RNG 1.0 (from RC5).
>>>>>
>>>>> Main changes wrt the preceding vote (RC2, on September 16) are:
>>>>> * Modularization
>>>>> * Non-uniform deviates (in module "commons-rng-sampling")
>>>>>
>>>>>
>>>>> Tag name:
>>>>> RNG_1_0_RC5 (signature can be checked from git using 'git tag -v')
>>>>>
>>>>> Tag URL:
>>>>>
>>>>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=commit;h=
>>>> f9de6401e981554c3f44936c2272429e290fdbec
>>>>>
>>>>> Commit ID the tag points at:
>>>>> f9de6401e981554c3f44936c2272429e290fdbec
>>>>>
>>>>> Site:
>>>>> http://home.apache.org/~erans/commons-rng-1.0-RC5-site
>>>>>
>>>>> Distribution files:
>>>>> https://dist.apache.org/repos/dist/dev/commons/rng/
>>>>>
>>>>> Distribution files hashes (SHA1):
>>>>> de2a54518a0ef10ba5a2be1c3b060a441f4466e2  commons-rng-1.0-bin.tar.gz.
>>>> sha1
>>>>> cfcfde1f65dec9c30be1273ff2237d551eb87933  commons-rng-1.0-bin.zip.sha1
>>>>> 6d529de9418314066727a7d5ada88dd87dc0163d  commons-rng-1.0-src.tar.gz.
>>>> sha1
>>>>> 561dd3e5ebf53d60e883d5c04e543f58374c45b6  commons-rng-1.0-src.zip.sha1
>>>>>
>>>>> KEYS file to check signatures:
>>>>> http://www.apache.org/dist/commons/KEYS
>>>>>
>>>>> Maven artifacts:
>>>>> https://repository.apache.org/content/repositories/
>>>> orgapachecommons-1225/
>>>>>
>>>>>
>>>>> [ ] +1 Release it.
>>>>> [ ] +0 Go ahead; I don't care.
>>>>> [ ] -0 There are a few minor glitches: ...
>>>>> [ ] -1 No, do not release it because ...
>>>>>
>>>>> This vote will close in 72 hours, at 2016-12-03T00:00:00Z (this is UTC
>>>>> time).
>>>>> ----------
>>>>>
>>>>>
>>>>> Thanks,
>>>>> Gilles
>>>>>
>>>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC5] Release "Apache Commons RNG" version 1.0

Gilles Sadowski
In reply to this post by Rob Tompkins
On Thu, 1 Dec 2016 15:44:50 -0800, Rob Tompkins wrote:

>> On Dec 1, 2016, at 3:32 PM, Gilles <[hidden email]>
>> wrote:
>>
>> On Thu, 1 Dec 2016 15:29:17 -0800, Rob Tompkins wrote:
>>> Vote: -1 mainly for license,
>>
>> Which files?
>
> The LICENSE.txt and NOTICE.txt aren’t in the META-INF directory of
> the main jar artifact for at least rng-core, whereas
>
> http://repo1.maven.org/maven2/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar
>
> <http://repo1.maven.org/maven2/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar>
> does contain those files.

I don't know when in the modularization process, those were dropped!
Oh wait, I think I've spotted the problem.

Is that a blocker?

> Sorry…If you want I can hop in and see if I can get the assembly
> plugin to accommodate for that and include them.

Help always welcome:
   https://issues.apache.org/jira/browse/RNG-23

There is another problem with generating the aggregate artefacts (aka
distribution archives files): the "assembly" plugin did no generate
neither the signature nor the checksum (cf. "dist-archive" module).
Please have a look at that one while I fix the META-INF.

Thanks,
Gilles

P.S. Is everyone happy with having to manually delete one-by-one
      all the distribution archives spuriously uploaded to Nexus
      by the "deploy" target?
      There are 16 files to delete per module!
      In the current case, I have to click 16 x 5 x 3 times to get
      rid of them, for each RC. :-/

>
> -Rob
>
>>
>>> but there’s the following as well.
>>>
>>> I just ran “mvn clean test" with java 1.7.0_60 on OS X 10.12.1 and
>>> got the following test failure (note that it seems to be
>>> intermittent):
>>
>> Cf. https://issues.apache.org/jira/browse/RNG-30
>>
>> Regards,
>> Gilles
>>
>>> testSampling[22:
>>>
>>> data=org.apache.commons.math3.distribution.ParetoDistribution@185c0deb
>>> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
>>> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
>>> [0x0f1505c780688cb5L, 33, 192641895])]:
>>> deciles=[55.074313383177326,
>>> 143.04583109008863, 422.11049795027907, 1472.1250669034735,
>>> 6450.716651619402, 39349.60019433535, 404957.85425759235,
>>> 1.0824440136808794E7,
>>>
>>> 2.9776288373121433E9]](org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest)
>>> Time elapsed: 2.792 sec  <<< FAILURE!
>>> java.lang.AssertionError:
>>> org.apache.commons.math3.distribution.ParetoDistribution@185c0deb
>>> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
>>> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
>>> [0x0f1505c780688cb5L, 33, 192641895])]: Too many failures for
>>> sample
>>> size = 20000 (3 out of 50 tests failed, chi2=[24.237000000000002,
>>> 21.682000000000002, 23.912000000000003]
>>> at
>>>
>>> org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest.check(ContinuousSamplerParametricTest.java:127)
>>> at
>>>
>>> org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest.testSampling(ContinuousSamplerParametricTest.java:53)
>>>
>>> Running
>>>
>>> org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
>>> Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
>>> 7.134 sec - in
>>>
>>> org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
>>> Running org.apache.commons.rng.sampling.ListSamplerTest
>>> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
>>> 0.034
>>> sec - in org.apache.commons.rng.sampling.ListSamplerTest
>>> Running org.apache.commons.rng.sampling.PermutationSamplerTest
>>> Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
>>> 0.014 sec - in
>>> org.apache.commons.rng.sampling.PermutationSamplerTest
>>>
>>> Results :
>>>
>>> Failed tests:
>>>  ContinuousSamplerParametricTest.testSampling:53->check:127
>>> org.apache.commons.math3.distribution.ParetoDistribution@185c0deb
>>> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
>>> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
>>> [0x0f1505c780688cb5L, 33, 192641895])]: Too many failures for
>>> sample
>>> size = 20000 (3 out of 50 tests failed, chi2=[24.237000000000002,
>>> 21.682000000000002, 23.912000000000003]
>>>
>>>
>>>> On Dec 1, 2016, at 6:18 AM, Artem Barger <[hidden email]> wrote:
>>>>
>>>> My vote: +1
>>>>
>>>> Best regards,
>>>>                     Artem Barger.
>>>>
>>>> On Thu, Dec 1, 2016 at 2:01 PM, Stian Soiland-Reyes
>>>> <[hidden email]>
>>>> wrote:
>>>>
>>>>> My vote: +1 (binding)
>>>>>
>>>>> Looking good!
>>>>>
>>>>>
>>>>> Checked:
>>>>>
>>>>> +1 commit matches tag (even signed tag, yay!)
>>>>> +0 commit matches src (git tag is missing
>>>>> "<createChecksum>true</createChecksum>" -- why?)
>>>>> +0 src matches staging repo -sources (hard to check as
>>>>> *-src.tar.gz
>>>>> was not staged :-( )
>>>>> +1 bin JARs matches staging repo hashes
>>>>> +1 zip vs tar.gz
>>>>> +1 .asc signatures of dist and repo
>>>>> +1 md5/sha1 hashes (email's hash filenames says .sha1, but match
>>>>> correctly the zip/tar.gz)
>>>>> +0 mvn apache-rat:check (exceptions are already excluded for
>>>>> <reporting>)
>>>>> +1 no unexpected binaries
>>>>> +1 mvn clean install
>>>>> +1 .. and afterwards in commons-rng-examples
>>>>> +0 binary vs source (binary adds commons-rng-examples-1.0.jar,
>>>>> built
>>>>> separately in source)
>>>>> +1 RELEASE-NOTES
>>>>> +1 LICENSE, NOTICE
>>>>> +1 site (minor markdown highlight bug "64 bits" at
>>>>>
>>>>> http://home.apache.org/~erans/commons-rng-1.0-RC5-site/userguide/rng.html)
>>>>> +1 javadoc
>>>>>
>>>>> On 30 November 2016 at 00:08, Gilles
>>>>> <[hidden email]> wrote:
>>>>>> Hi.
>>>>>>
>>>>>> This is a [VOTE] for releasing Apache Commons RNG 1.0 (from
>>>>>> RC5).
>>>>>>
>>>>>> Main changes wrt the preceding vote (RC2, on September 16) are:
>>>>>> * Modularization
>>>>>> * Non-uniform deviates (in module "commons-rng-sampling")
>>>>>>
>>>>>>
>>>>>> Tag name:
>>>>>> RNG_1_0_RC5 (signature can be checked from git using 'git tag
>>>>>> -v')
>>>>>>
>>>>>> Tag URL:
>>>>>>
>>>>>>
>>>>>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=commit;h=
>>>>> f9de6401e981554c3f44936c2272429e290fdbec
>>>>>>
>>>>>> Commit ID the tag points at:
>>>>>> f9de6401e981554c3f44936c2272429e290fdbec
>>>>>>
>>>>>> Site:
>>>>>> http://home.apache.org/~erans/commons-rng-1.0-RC5-site
>>>>>>
>>>>>> Distribution files:
>>>>>> https://dist.apache.org/repos/dist/dev/commons/rng/
>>>>>>
>>>>>> Distribution files hashes (SHA1):
>>>>>> de2a54518a0ef10ba5a2be1c3b060a441f4466e2  
>>>>>> commons-rng-1.0-bin.tar.gz.
>>>>> sha1
>>>>>> cfcfde1f65dec9c30be1273ff2237d551eb87933  
>>>>>> commons-rng-1.0-bin.zip.sha1
>>>>>> 6d529de9418314066727a7d5ada88dd87dc0163d  
>>>>>> commons-rng-1.0-src.tar.gz.
>>>>> sha1
>>>>>> 561dd3e5ebf53d60e883d5c04e543f58374c45b6  
>>>>>> commons-rng-1.0-src.zip.sha1
>>>>>>
>>>>>> KEYS file to check signatures:
>>>>>> http://www.apache.org/dist/commons/KEYS
>>>>>>
>>>>>> Maven artifacts:
>>>>>> https://repository.apache.org/content/repositories/
>>>>> orgapachecommons-1225/
>>>>>>
>>>>>>
>>>>>> [ ] +1 Release it.
>>>>>> [ ] +0 Go ahead; I don't care.
>>>>>> [ ] -0 There are a few minor glitches: ...
>>>>>> [ ] -1 No, do not release it because ...
>>>>>>
>>>>>> This vote will close in 72 hours, at 2016-12-03T00:00:00Z (this
>>>>>> is UTC
>>>>>> time).
>>>>>> ----------
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Gilles
>>>>>>
>>>>>>
>>
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[RNG] Include LICENCE and NOTICE in META-INF

Gilles Sadowski
On Fri, 02 Dec 2016 01:09:12 +0100, Gilles wrote:

> On Thu, 1 Dec 2016 15:44:50 -0800, Rob Tompkins wrote:
>>> On Dec 1, 2016, at 3:32 PM, Gilles <[hidden email]>
>>> wrote:
>>>
>>> On Thu, 1 Dec 2016 15:29:17 -0800, Rob Tompkins wrote:
>>>> Vote: -1 mainly for license,
>>>
>>> Which files?
>>
>> The LICENSE.txt and NOTICE.txt aren’t in the META-INF directory of
>> the main jar artifact for at least rng-core, whereas
>>
>> http://repo1.maven.org/maven2/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar
>>
>> <http://repo1.maven.org/maven2/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar>
>> does contain those files.
>
> I don't know when in the modularization process, those were dropped!
> Oh wait, I think I've spotted the problem.

Sadly, I haven't.
The settings are in the parent POM (marked as a hack), but obviously
it doesn't work for a modular project.
I've looked at the POM of two modular projects ("weaver" and "vfs");
they seem to deal with that issue in their POM, but in seemingly
very different (and convoluted) ways. :-(

I'll do it more crudely: "cp".
Redundant copies can always be removed next time...

Gilles

> [...]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC5] Release "Apache Commons RNG" version 1.0

Charles Honton
In reply to this post by Gilles Sadowski
Re: P.S. Is everyone happy with having to manually delete one-by-one all the distribution archives spuriously uploaded to Nexus?

Commons Parent 42 has a <attach>false</attach> setting for assembly plugin to prevent zips/gz from being uploaded to Nexus.  
Unfortunately, the last vote for parent 42 was cancelled for this very reason.  (see [VOTE][LAZY] Release Commons Parent POM 42 based on RC1 <http://mail-archives.apache.org/mod_mbox/commons-dev/201612.mbox/%3CB02A39B7-7D68-414C-B596-218A28EC87F9@...%3E>)

regards,
chas


> On Dec 1, 2016, at 4:09 PM, Gilles <[hidden email]> wrote:
>
> On Thu, 1 Dec 2016 15:44:50 -0800, Rob Tompkins wrote:
>>> On Dec 1, 2016, at 3:32 PM, Gilles <[hidden email]> wrote:
>>>
>>> On Thu, 1 Dec 2016 15:29:17 -0800, Rob Tompkins wrote:
>>>> Vote: -1 mainly for license,
>>>
>>> Which files?
>>
>> The LICENSE.txt and NOTICE.txt aren’t in the META-INF directory of
>> the main jar artifact for at least rng-core, whereas
>> http://repo1.maven.org/maven2/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar
>> <http://repo1.maven.org/maven2/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar>
>> does contain those files.
>
> I don't know when in the modularization process, those were dropped!
> Oh wait, I think I've spotted the problem.
>
> Is that a blocker?
>
>> Sorry…If you want I can hop in and see if I can get the assembly
>> plugin to accommodate for that and include them.
>
> Help always welcome:
>  https://issues.apache.org/jira/browse/RNG-23
>
> There is another problem with generating the aggregate artefacts (aka
> distribution archives files): the "assembly" plugin did no generate
> neither the signature nor the checksum (cf. "dist-archive" module).
> Please have a look at that one while I fix the META-INF.
>
> Thanks,
> Gilles
>
> P.S. Is everyone happy with having to manually delete one-by-one
>     all the distribution archives spuriously uploaded to Nexus
>     by the "deploy" target?
>     There are 16 files to delete per module!
>     In the current case, I have to click 16 x 5 x 3 times to get
>     rid of them, for each RC. :-/
>
>>
>> -Rob
>>
>>>
>>>> but there’s the following as well.
>>>>
>>>> I just ran “mvn clean test" with java 1.7.0_60 on OS X 10.12.1 and
>>>> got the following test failure (note that it seems to be
>>>> intermittent):
>>>
>>> Cf. https://issues.apache.org/jira/browse/RNG-30
>>>
>>> Regards,
>>> Gilles
>>>
>>>> testSampling[22:
>>>> data=org.apache.commons.math3.distribution.ParetoDistribution@185c0deb
>>>> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
>>>> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
>>>> [0x0f1505c780688cb5L, 33, 192641895])]: deciles=[55.074313383177326,
>>>> 143.04583109008863, 422.11049795027907, 1472.1250669034735,
>>>> 6450.716651619402, 39349.60019433535, 404957.85425759235,
>>>> 1.0824440136808794E7,
>>>> 2.9776288373121433E9]](org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest)
>>>> Time elapsed: 2.792 sec  <<< FAILURE!
>>>> java.lang.AssertionError:
>>>> org.apache.commons.math3.distribution.ParetoDistribution@185c0deb
>>>> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
>>>> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
>>>> [0x0f1505c780688cb5L, 33, 192641895])]: Too many failures for sample
>>>> size = 20000 (3 out of 50 tests failed, chi2=[24.237000000000002,
>>>> 21.682000000000002, 23.912000000000003]
>>>> at
>>>> org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest.check(ContinuousSamplerParametricTest.java:127)
>>>> at
>>>> org.apache.commons.rng.sampling.distribution.ContinuousSamplerParametricTest.testSampling(ContinuousSamplerParametricTest.java:53)
>>>>
>>>> Running
>>>> org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
>>>> Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
>>>> 7.134 sec - in
>>>> org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
>>>> Running org.apache.commons.rng.sampling.ListSamplerTest
>>>> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.034
>>>> sec - in org.apache.commons.rng.sampling.ListSamplerTest
>>>> Running org.apache.commons.rng.sampling.PermutationSamplerTest
>>>> Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
>>>> 0.014 sec - in org.apache.commons.rng.sampling.PermutationSamplerTest
>>>>
>>>> Results :
>>>>
>>>> Failed tests:
>>>> ContinuousSamplerParametricTest.testSampling:53->check:127
>>>> org.apache.commons.math3.distribution.ParetoDistribution@185c0deb
>>>> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
>>>> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
>>>> [0x0f1505c780688cb5L, 33, 192641895])]: Too many failures for sample
>>>> size = 20000 (3 out of 50 tests failed, chi2=[24.237000000000002,
>>>> 21.682000000000002, 23.912000000000003]
>>>>
>>>>
>>>>> On Dec 1, 2016, at 6:18 AM, Artem Barger <[hidden email]> wrote:
>>>>>
>>>>> My vote: +1
>>>>>
>>>>> Best regards,
>>>>>                    Artem Barger.
>>>>>
>>>>> On Thu, Dec 1, 2016 at 2:01 PM, Stian Soiland-Reyes <[hidden email]>
>>>>> wrote:
>>>>>
>>>>>> My vote: +1 (binding)
>>>>>>
>>>>>> Looking good!
>>>>>>
>>>>>>
>>>>>> Checked:
>>>>>>
>>>>>> +1 commit matches tag (even signed tag, yay!)
>>>>>> +0 commit matches src (git tag is missing
>>>>>> "<createChecksum>true</createChecksum>" -- why?)
>>>>>> +0 src matches staging repo -sources (hard to check as *-src.tar.gz
>>>>>> was not staged :-( )
>>>>>> +1 bin JARs matches staging repo hashes
>>>>>> +1 zip vs tar.gz
>>>>>> +1 .asc signatures of dist and repo
>>>>>> +1 md5/sha1 hashes (email's hash filenames says .sha1, but match
>>>>>> correctly the zip/tar.gz)
>>>>>> +0 mvn apache-rat:check (exceptions are already excluded for <reporting>)
>>>>>> +1 no unexpected binaries
>>>>>> +1 mvn clean install
>>>>>> +1 .. and afterwards in commons-rng-examples
>>>>>> +0 binary vs source (binary adds commons-rng-examples-1.0.jar, built
>>>>>> separately in source)
>>>>>> +1 RELEASE-NOTES
>>>>>> +1 LICENSE, NOTICE
>>>>>> +1 site (minor markdown highlight bug "64 bits" at
>>>>>> http://home.apache.org/~erans/commons-rng-1.0-RC5-site/userguide/rng.html)
>>>>>> +1 javadoc
>>>>>>
>>>>>> On 30 November 2016 at 00:08, Gilles <[hidden email]> wrote:
>>>>>>> Hi.
>>>>>>>
>>>>>>> This is a [VOTE] for releasing Apache Commons RNG 1.0 (from RC5).
>>>>>>>
>>>>>>> Main changes wrt the preceding vote (RC2, on September 16) are:
>>>>>>> * Modularization
>>>>>>> * Non-uniform deviates (in module "commons-rng-sampling")
>>>>>>>
>>>>>>>
>>>>>>> Tag name:
>>>>>>> RNG_1_0_RC5 (signature can be checked from git using 'git tag -v')
>>>>>>>
>>>>>>> Tag URL:
>>>>>>>
>>>>>>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=commit;h=
>>>>>> f9de6401e981554c3f44936c2272429e290fdbec
>>>>>>>
>>>>>>> Commit ID the tag points at:
>>>>>>> f9de6401e981554c3f44936c2272429e290fdbec
>>>>>>>
>>>>>>> Site:
>>>>>>> http://home.apache.org/~erans/commons-rng-1.0-RC5-site
>>>>>>>
>>>>>>> Distribution files:
>>>>>>> https://dist.apache.org/repos/dist/dev/commons/rng/
>>>>>>>
>>>>>>> Distribution files hashes (SHA1):
>>>>>>> de2a54518a0ef10ba5a2be1c3b060a441f4466e2  commons-rng-1.0-bin.tar.gz.
>>>>>> sha1
>>>>>>> cfcfde1f65dec9c30be1273ff2237d551eb87933  commons-rng-1.0-bin.zip.sha1
>>>>>>> 6d529de9418314066727a7d5ada88dd87dc0163d  commons-rng-1.0-src.tar.gz.
>>>>>> sha1
>>>>>>> 561dd3e5ebf53d60e883d5c04e543f58374c45b6  commons-rng-1.0-src.zip.sha1
>>>>>>>
>>>>>>> KEYS file to check signatures:
>>>>>>> http://www.apache.org/dist/commons/KEYS
>>>>>>>
>>>>>>> Maven artifacts:
>>>>>>> https://repository.apache.org/content/repositories/
>>>>>> orgapachecommons-1225/
>>>>>>>
>>>>>>>
>>>>>>> [ ] +1 Release it.
>>>>>>> [ ] +0 Go ahead; I don't care.
>>>>>>> [ ] -0 There are a few minor glitches: ...
>>>>>>> [ ] -1 No, do not release it because ...
>>>>>>>
>>>>>>> This vote will close in 72 hours, at 2016-12-03T00:00:00Z (this is UTC
>>>>>>> time).
>>>>>>> ----------
>>>>>>>
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Gilles
>>>>>>>
>>>>>>>
>>>
>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC5] Release "Apache Commons RNG" version 1.0

garydgregory
I've had to do the manual deletion for MANY releases. Not fun. And yeah it
looks like the POM "fix" to address that breaks other things. Unless there
some special profile I do not know about.

Gary

On Dec 1, 2016 5:54 PM, "Charles Honton" <[hidden email]> wrote:

> Re: P.S. Is everyone happy with having to manually delete one-by-one all
> the distribution archives spuriously uploaded to Nexus?
>
> Commons Parent 42 has a <attach>false</attach> setting for assembly plugin
> to prevent zips/gz from being uploaded to Nexus.
> Unfortunately, the last vote for parent 42 was cancelled for this very
> reason.  (see [VOTE][LAZY] Release Commons Parent POM 42 based on RC1 <
> http://mail-archives.apache.org/mod_mbox/commons-dev/
> 201612.mbox/%[hidden email]%3E>)
>
> regards,
> chas
>
>
> > On Dec 1, 2016, at 4:09 PM, Gilles <[hidden email]> wrote:
> >
> > On Thu, 1 Dec 2016 15:44:50 -0800, Rob Tompkins wrote:
> >>> On Dec 1, 2016, at 3:32 PM, Gilles <[hidden email]>
> wrote:
> >>>
> >>> On Thu, 1 Dec 2016 15:29:17 -0800, Rob Tompkins wrote:
> >>>> Vote: -1 mainly for license,
> >>>
> >>> Which files?
> >>
> >> The LICENSE.txt and NOTICE.txt aren’t in the META-INF directory of
> >> the main jar artifact for at least rng-core, whereas
> >> http://repo1.maven.org/maven2/org/apache/commons/commons-
> lang3/3.5/commons-lang3-3.5.jar
> >> <http://repo1.maven.org/maven2/org/apache/commons/
> commons-lang3/3.5/commons-lang3-3.5.jar>
> >> does contain those files.
> >
> > I don't know when in the modularization process, those were dropped!
> > Oh wait, I think I've spotted the problem.
> >
> > Is that a blocker?
> >
> >> Sorry…If you want I can hop in and see if I can get the assembly
> >> plugin to accommodate for that and include them.
> >
> > Help always welcome:
> >  https://issues.apache.org/jira/browse/RNG-23
> >
> > There is another problem with generating the aggregate artefacts (aka
> > distribution archives files): the "assembly" plugin did no generate
> > neither the signature nor the checksum (cf. "dist-archive" module).
> > Please have a look at that one while I fix the META-INF.
> >
> > Thanks,
> > Gilles
> >
> > P.S. Is everyone happy with having to manually delete one-by-one
> >     all the distribution archives spuriously uploaded to Nexus
> >     by the "deploy" target?
> >     There are 16 files to delete per module!
> >     In the current case, I have to click 16 x 5 x 3 times to get
> >     rid of them, for each RC. :-/
> >
> >>
> >> -Rob
> >>
> >>>
> >>>> but there’s the following as well.
> >>>>
> >>>> I just ran “mvn clean test" with java 1.7.0_60 on OS X 10.12.1 and
> >>>> got the following test failure (note that it seems to be
> >>>> intermittent):
> >>>
> >>> Cf. https://issues.apache.org/jira/browse/RNG-30
> >>>
> >>> Regards,
> >>> Gilles
> >>>
> >>>> testSampling[22:
> >>>> data=org.apache.commons.math3.distribution.
> ParetoDistribution@185c0deb
> >>>> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
> >>>> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
> >>>> [0x0f1505c780688cb5L, 33, 192641895])]: deciles=[55.074313383177326,
> >>>> 143.04583109008863, 422.11049795027907, 1472.1250669034735,
> >>>> 6450.716651619402, 39349.60019433535, 404957.85425759235,
> >>>> 1.0824440136808794E7,
> >>>> 2.9776288373121433E9]](org.apache.commons.rng.sampling.distribution.
> ContinuousSamplerParametricTest)
> >>>> Time elapsed: 2.792 sec  <<< FAILURE!
> >>>> java.lang.AssertionError:
> >>>> org.apache.commons.math3.distribution.ParetoDistribution@185c0deb
> >>>> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
> >>>> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
> >>>> [0x0f1505c780688cb5L, 33, 192641895])]: Too many failures for sample
> >>>> size = 20000 (3 out of 50 tests failed, chi2=[24.237000000000002,
> >>>> 21.682000000000002, 23.912000000000003]
> >>>>    at
> >>>> org.apache.commons.rng.sampling.distribution.
> ContinuousSamplerParametricTest.check(ContinuousSamplerParametricTes
> t.java:127)
> >>>>    at
> >>>> org.apache.commons.rng.sampling.distribution.
> ContinuousSamplerParametricTest.testSampling(
> ContinuousSamplerParametricTest.java:53)
> >>>>
> >>>> Running
> >>>> org.apache.commons.rng.sampling.distribution.
> DiscreteSamplerParametricTest
> >>>> Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
> >>>> 7.134 sec - in
> >>>> org.apache.commons.rng.sampling.distribution.
> DiscreteSamplerParametricTest
> >>>> Running org.apache.commons.rng.sampling.ListSamplerTest
> >>>> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.034
> >>>> sec - in org.apache.commons.rng.sampling.ListSamplerTest
> >>>> Running org.apache.commons.rng.sampling.PermutationSamplerTest
> >>>> Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
> >>>> 0.014 sec - in org.apache.commons.rng.sampling.PermutationSamplerTest
> >>>>
> >>>> Results :
> >>>>
> >>>> Failed tests:
> >>>> ContinuousSamplerParametricTest.testSampling:53->check:127
> >>>> org.apache.commons.math3.distribution.ParetoDistribution@185c0deb
> >>>> (inverse method) [rng=org.apache.commons.rng.core.source64.TwoCmres
> >>>> (Cmres: [0x11eab77f808cf641L, 32, 106120225] + Cmres:
> >>>> [0x0f1505c780688cb5L, 33, 192641895])]: Too many failures for sample
> >>>> size = 20000 (3 out of 50 tests failed, chi2=[24.237000000000002,
> >>>> 21.682000000000002, 23.912000000000003]
> >>>>
> >>>>
> >>>>> On Dec 1, 2016, at 6:18 AM, Artem Barger <[hidden email]> wrote:
> >>>>>
> >>>>> My vote: +1
> >>>>>
> >>>>> Best regards,
> >>>>>                    Artem Barger.
> >>>>>
> >>>>> On Thu, Dec 1, 2016 at 2:01 PM, Stian Soiland-Reyes <
> [hidden email]>
> >>>>> wrote:
> >>>>>
> >>>>>> My vote: +1 (binding)
> >>>>>>
> >>>>>> Looking good!
> >>>>>>
> >>>>>>
> >>>>>> Checked:
> >>>>>>
> >>>>>> +1 commit matches tag (even signed tag, yay!)
> >>>>>> +0 commit matches src (git tag is missing
> >>>>>> "<createChecksum>true</createChecksum>" -- why?)
> >>>>>> +0 src matches staging repo -sources (hard to check as *-src.tar.gz
> >>>>>> was not staged :-( )
> >>>>>> +1 bin JARs matches staging repo hashes
> >>>>>> +1 zip vs tar.gz
> >>>>>> +1 .asc signatures of dist and repo
> >>>>>> +1 md5/sha1 hashes (email's hash filenames says .sha1, but match
> >>>>>> correctly the zip/tar.gz)
> >>>>>> +0 mvn apache-rat:check (exceptions are already excluded for
> <reporting>)
> >>>>>> +1 no unexpected binaries
> >>>>>> +1 mvn clean install
> >>>>>> +1 .. and afterwards in commons-rng-examples
> >>>>>> +0 binary vs source (binary adds commons-rng-examples-1.0.jar, built
> >>>>>> separately in source)
> >>>>>> +1 RELEASE-NOTES
> >>>>>> +1 LICENSE, NOTICE
> >>>>>> +1 site (minor markdown highlight bug "64 bits" at
> >>>>>> http://home.apache.org/~erans/commons-rng-1.0-RC5-site/
> userguide/rng.html)
> >>>>>> +1 javadoc
> >>>>>>
> >>>>>> On 30 November 2016 at 00:08, Gilles <[hidden email]>
> wrote:
> >>>>>>> Hi.
> >>>>>>>
> >>>>>>> This is a [VOTE] for releasing Apache Commons RNG 1.0 (from RC5).
> >>>>>>>
> >>>>>>> Main changes wrt the preceding vote (RC2, on September 16) are:
> >>>>>>> * Modularization
> >>>>>>> * Non-uniform deviates (in module "commons-rng-sampling")
> >>>>>>>
> >>>>>>>
> >>>>>>> Tag name:
> >>>>>>> RNG_1_0_RC5 (signature can be checked from git using 'git tag -v')
> >>>>>>>
> >>>>>>> Tag URL:
> >>>>>>>
> >>>>>>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=
> commit;h=
> >>>>>> f9de6401e981554c3f44936c2272429e290fdbec
> >>>>>>>
> >>>>>>> Commit ID the tag points at:
> >>>>>>> f9de6401e981554c3f44936c2272429e290fdbec
> >>>>>>>
> >>>>>>> Site:
> >>>>>>> http://home.apache.org/~erans/commons-rng-1.0-RC5-site
> >>>>>>>
> >>>>>>> Distribution files:
> >>>>>>> https://dist.apache.org/repos/dist/dev/commons/rng/
> >>>>>>>
> >>>>>>> Distribution files hashes (SHA1):
> >>>>>>> de2a54518a0ef10ba5a2be1c3b060a441f4466e2
> commons-rng-1.0-bin.tar.gz.
> >>>>>> sha1
> >>>>>>> cfcfde1f65dec9c30be1273ff2237d551eb87933
> commons-rng-1.0-bin.zip.sha1
> >>>>>>> 6d529de9418314066727a7d5ada88dd87dc0163d
> commons-rng-1.0-src.tar.gz.
> >>>>>> sha1
> >>>>>>> 561dd3e5ebf53d60e883d5c04e543f58374c45b6
> commons-rng-1.0-src.zip.sha1
> >>>>>>>
> >>>>>>> KEYS file to check signatures:
> >>>>>>> http://www.apache.org/dist/commons/KEYS
> >>>>>>>
> >>>>>>> Maven artifacts:
> >>>>>>> https://repository.apache.org/content/repositories/
> >>>>>> orgapachecommons-1225/
> >>>>>>>
> >>>>>>>
> >>>>>>> [ ] +1 Release it.
> >>>>>>> [ ] +0 Go ahead; I don't care.
> >>>>>>> [ ] -0 There are a few minor glitches: ...
> >>>>>>> [ ] -1 No, do not release it because ...
> >>>>>>>
> >>>>>>> This vote will close in 72 hours, at 2016-12-03T00:00:00Z (this is
> UTC
> >>>>>>> time).
> >>>>>>> ----------
> >>>>>>>
> >>>>>>>
> >>>>>>> Thanks,
> >>>>>>> Gilles
> >>>>>>>
> >>>>>>>
> >>>
> >>>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC5] Release "Apache Commons RNG" version 1.0

Gilles Sadowski
On Thu, 1 Dec 2016 17:56:49 -0800, Gary Gregory wrote:
> I've had to do the manual deletion for MANY releases. Not fun. And
> yeah it
> looks like the POM "fix" to address that breaks other things. Unless
> there
> some special profile I do not know about.

Is it going to work, or, in the next commons-parent RC, do you
intend to remove that "fix" because it breaks other things?

Gilles

>
> Gary
>
> On Dec 1, 2016 5:54 PM, "Charles Honton" <[hidden email]> wrote:
>
>> Re: P.S. Is everyone happy with having to manually delete one-by-one
>> all
>> the distribution archives spuriously uploaded to Nexus?
>>
>> Commons Parent 42 has a <attach>false</attach> setting for assembly
>> plugin
>> to prevent zips/gz from being uploaded to Nexus.
>> Unfortunately, the last vote for parent 42 was cancelled for this
>> very
>> reason.  (see [VOTE][LAZY] Release Commons Parent POM 42 based on
>> RC1 <
>> http://mail-archives.apache.org/mod_mbox/commons-dev/
>> 201612.mbox/%[hidden email]%3E>)
>>
>> regards,
>> chas
>>
>>
>> [...]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[RNG] Intermittent failure of unit tests (Was: [VOTE][RC5] ...)

Gilles Sadowski
In reply to this post by Rob Tompkins
On Thu, 1 Dec 2016 15:59:24 -0800, Rob Tompkins wrote:

>> On Dec 1, 2016, at 3:32 PM, Gilles <[hidden email]>
>> wrote:
>>
>> On Thu, 1 Dec 2016 15:29:17 -0800, Rob Tompkins wrote:
>>> Vote: -1 mainly for license,
>>
>> Which files?
>>
>>> but there’s the following as well.
>>>
>>> I just ran “mvn clean test" with java 1.7.0_60 on OS X 10.12.1 and
>>> got the following test failure (note that it seems to be
>>> intermittent):
>>
>> Cf. https://issues.apache.org/jira/browse/RNG-30 
>> <https://issues.apache.org/jira/browse/RNG-30>
>
> I don’t know what to do here. On one hand it really feels like our
> builds should be deterministic, but on the other hand you need to
> need
> to exercise the code fully in your unit tests. I’m really at odds
> with
> myself, but I think I lean towards determinism.

As with other issues discussed on this list, this one is not going
to be solved (reasonably, I mean) by tallying "preferences".[1]

It is possible that the unit test's assumption is flawed.[2]
Another possiblity is that the strategy for declaring pass/fail is
too crude; see for example, in the user guide, the output of the
"Dieharder" test suite.[3]


Regards,
Gilles

[1] It is easy to select a seed that will make the test deterministic
and
     passing.  But it suppresses behavioral diversity, which in turn
could
     reveal a potential bug.  This case seems to happen in
       https://issues.apache.org/jira/browse/MATH-1361
[2] Hence the request for review in "RNG-30".
[3] AFAIUC, when a test produces a result that is "close" to the
pass/fail
     boundary, it is rerun, until a definite conclusion can be reached.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[CANCEL][VOTE][RC5] Release "Apache Commons RNG" version 1.0

Gilles Sadowski
In reply to this post by Gilles Sadowski
Reason: LICENSE files not included in the JARs.

Regards,
Gilles

P.S. In some way, this is a bug in "commons-parent". Is there a JIRA
      issue-tracking for it?


On Wed, 30 Nov 2016 01:08:03 +0100, Gilles wrote:
> Hi.
>
> This is a [VOTE] for releasing Apache Commons RNG 1.0 (from RC5).
>
> [...]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC5] Release "Apache Commons RNG" version 1.0

jochen-2
In reply to this post by Oliver Heger-3
+1 (Binding)


On Thu, Dec 1, 2016 at 10:14 PM, Oliver Heger
<[hidden email]> wrote:

> Hi,
>
> build works fine with Java 7 and Java 8 on Windows 10. When building
> with Java 1.6 I got a test failure in the Sampling module (see below),
> but it does not seem to be reproducible; probably not blocking.
>
> The artifacts from the binary distribution do not contain the LICENSE
> and NOTICE files. I think this is a blocker for the release.
>
> The site looks good, but I am missing a link for the Javadocs. As a
> minor nit, the RAT report contains unknown licenses in some checksum
> files; maybe some spurious files?
>
> -1 because of the missing license files, sorry.
>
> Oliver
>
> Test failure:
> Failed tests:
>   ContinuousSamplerParametricTest.testSampling:53->check:127
> org.apache.commons.math3.distribution.NormalDistribution@59d2400d
> (inverse method) [rng=org.apache.commons.rng.core.source32.KISSRandom]:
> Too many failures for sample size = 20000 (3 out of 50 tests failed,
> chi2=[26.369, 23.043, 31.568000000000005]
>   ContinuousSamplerParametricTest.testSampling:53->check:127
> Ahrens-Dieter-Marsaglia-Tsang Gamma deviate
> [rng=org.apache.commons.rng.core.source64.XorShift1024Star]: Too many
> failures for sample size = 20000 (3 out of 50 tests failed,
> chi2=[25.784999999999997, 24.829, 22.042000000000005]
>
> Am 30.11.2016 um 01:08 schrieb Gilles:
>> Hi.
>>
>> This is a [VOTE] for releasing Apache Commons RNG 1.0 (from RC5).
>>
>> Main changes wrt the preceding vote (RC2, on September 16) are:
>>   * Modularization
>>   * Non-uniform deviates (in module "commons-rng-sampling")
>>
>>
>> Tag name:
>>   RNG_1_0_RC5 (signature can be checked from git using 'git tag -v')
>>
>> Tag URL:
>>
>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=commit;h=f9de6401e981554c3f44936c2272429e290fdbec
>>
>>
>> Commit ID the tag points at:
>>   f9de6401e981554c3f44936c2272429e290fdbec
>>
>> Site:
>>   http://home.apache.org/~erans/commons-rng-1.0-RC5-site
>>
>> Distribution files:
>>   https://dist.apache.org/repos/dist/dev/commons/rng/
>>
>> Distribution files hashes (SHA1):
>>   de2a54518a0ef10ba5a2be1c3b060a441f4466e2  commons-rng-1.0-bin.tar.gz.sha1
>>   cfcfde1f65dec9c30be1273ff2237d551eb87933  commons-rng-1.0-bin.zip.sha1
>>   6d529de9418314066727a7d5ada88dd87dc0163d  commons-rng-1.0-src.tar.gz.sha1
>>   561dd3e5ebf53d60e883d5c04e543f58374c45b6  commons-rng-1.0-src.zip.sha1
>>
>> KEYS file to check signatures:
>>   http://www.apache.org/dist/commons/KEYS
>>
>> Maven artifacts:
>>   https://repository.apache.org/content/repositories/orgapachecommons-1225/
>>
>>
>> [ ] +1 Release it.
>> [ ] +0 Go ahead; I don't care.
>> [ ] -0 There are a few minor glitches: ...
>> [ ] -1 No, do not release it because ...
>>
>> This vote will close in 72 hours, at 2016-12-03T00:00:00Z (this is UTC
>> time).
>> ----------
>>
>>
>> Thanks,
>> Gilles
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>



--
The next time you hear: "Don't reinvent the wheel!"

http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RC5] Release "Apache Commons RNG" version 1.0

Gilles Sadowski
Hi Jochen.

On Fri, 2 Dec 2016 16:38:31 +0100, Jochen Wiedmann wrote:
> +1 (Binding)

Thank you, but it seems that the missing contents would be against
the Apache rules (although there isn't yet an answer to my question
about it).

I don't know when I can start RC6, but hopefully this issue can be
solved before I attempt it:
  https://issues.apache.org/jira/browse/RNG-31


Regards,
Gilles

> On Thu, Dec 1, 2016 at 10:14 PM, Oliver Heger
> <[hidden email]> wrote:
>> Hi,
>>
>> build works fine with Java 7 and Java 8 on Windows 10. When building
>> with Java 1.6 I got a test failure in the Sampling module (see
>> below),
>> but it does not seem to be reproducible; probably not blocking.
>>
>> The artifacts from the binary distribution do not contain the
>> LICENSE
>> and NOTICE files. I think this is a blocker for the release.
>>
>> The site looks good, but I am missing a link for the Javadocs. As a
>> minor nit, the RAT report contains unknown licenses in some checksum
>> files; maybe some spurious files?
>>
>> -1 because of the missing license files, sorry.
>>
>> Oliver
>>
>> Test failure:
>> Failed tests:
>>   ContinuousSamplerParametricTest.testSampling:53->check:127
>> org.apache.commons.math3.distribution.NormalDistribution@59d2400d
>> (inverse method)
>> [rng=org.apache.commons.rng.core.source32.KISSRandom]:
>> Too many failures for sample size = 20000 (3 out of 50 tests failed,
>> chi2=[26.369, 23.043, 31.568000000000005]
>>   ContinuousSamplerParametricTest.testSampling:53->check:127
>> Ahrens-Dieter-Marsaglia-Tsang Gamma deviate
>> [rng=org.apache.commons.rng.core.source64.XorShift1024Star]: Too
>> many
>> failures for sample size = 20000 (3 out of 50 tests failed,
>> chi2=[25.784999999999997, 24.829, 22.042000000000005]
>>
>> Am 30.11.2016 um 01:08 schrieb Gilles:
>>> Hi.
>>>
>>> This is a [VOTE] for releasing Apache Commons RNG 1.0 (from RC5).
>>>
>>> Main changes wrt the preceding vote (RC2, on September 16) are:
>>>   * Modularization
>>>   * Non-uniform deviates (in module "commons-rng-sampling")
>>>
>>>
>>> Tag name:
>>>   RNG_1_0_RC5 (signature can be checked from git using 'git tag
>>> -v')
>>>
>>> Tag URL:
>>>
>>>
>>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=commit;h=f9de6401e981554c3f44936c2272429e290fdbec
>>>
>>>
>>> Commit ID the tag points at:
>>>   f9de6401e981554c3f44936c2272429e290fdbec
>>>
>>> Site:
>>>   http://home.apache.org/~erans/commons-rng-1.0-RC5-site
>>>
>>> Distribution files:
>>>   https://dist.apache.org/repos/dist/dev/commons/rng/
>>>
>>> Distribution files hashes (SHA1):
>>>   de2a54518a0ef10ba5a2be1c3b060a441f4466e2  
>>> commons-rng-1.0-bin.tar.gz.sha1
>>>   cfcfde1f65dec9c30be1273ff2237d551eb87933  
>>> commons-rng-1.0-bin.zip.sha1
>>>   6d529de9418314066727a7d5ada88dd87dc0163d  
>>> commons-rng-1.0-src.tar.gz.sha1
>>>   561dd3e5ebf53d60e883d5c04e543f58374c45b6  
>>> commons-rng-1.0-src.zip.sha1
>>>
>>> KEYS file to check signatures:
>>>   http://www.apache.org/dist/commons/KEYS
>>>
>>> Maven artifacts:
>>>  
>>> https://repository.apache.org/content/repositories/orgapachecommons-1225/
>>>
>>>
>>> [ ] +1 Release it.
>>> [ ] +0 Go ahead; I don't care.
>>> [ ] -0 There are a few minor glitches: ...
>>> [ ] -1 No, do not release it because ...
>>>
>>> This vote will close in 72 hours, at 2016-12-03T00:00:00Z (this is
>>> UTC
>>> time).
>>> ----------
>>>
>>>
>>> Thanks,
>>> Gilles
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]