[VOTE] Release Apache Commons BCEL 6.0 based on RC6

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Commons BCEL 6.0 based on RC6

Benedikt Ritter-4
Hi,

after some build related problems with RC5, I'd like to call a vote to
release Apache Commons BCEL 6.0 based on RC6. The only changes compared to
RC5 is a fix in the source assembly: It now includes all files necessary to
run a clean build.

BCEL 6.0 RC6 is available for review here:
  https://dist.apache.org/repos/dist/dev/commons/bcel (rev 14065)

The tag is here:
  https://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC6
 (rev 1749388)

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1179/org/apache/bcel/bcel/6.0/

These are the Maven artifacts and their hashes:

bcel-6.0-javadoc.jar
(SHA1: 89cf95656f0f8a93e77100c8d5811f7cd9af866b)
bcel-6.0-sources.jar
(SHA1: 162f96530e8935e8a71a9e6d5497026aa3bdc945)
bcel-6.0-test-sources.jar
(SHA1: 2b07be3a0a4560c9766d3261cd012cf636fe965a)
bcel-6.0-tests.jar
(SHA1: 9e825da46e0cd66f87ccd907a43c4e2ebd15b8d6)
bcel-6.0.jar
(SHA1: 09d0a4c32ba6c3c22f0680f89ceeaf3e677ac659)
bcel-6.0.pom
(SHA1: a5d48ac34909f3a0ac788d37835075be5c2bb9d7)

I have tested this with Java 7 and 8 using Maven 3.3.9 on Mac OS 10.11.5.

Details of changes since 5.2 are in the release notes:
  https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt
  http://home.apache.org/~britter/commons/bcel/6.0-RC6/changes-report.html

Site:
  http://home.apache.org/~britter/commons/bcel/6.0-RC6/
(note some *relative* links are broken and the 6.0 directories are not yet
created - these will be OK once the site is deployed)

Clirr Report (compared to 5.2):
  http://home.apache.org/~britter/commons/bcel/6.0-RC6/clirr-report.html

Note that Clirr reports several errors. These have been discussed on the ML
already and I uploaded the site a while ago giving everybody the
opportunity to raise objections against these changes. These changes are
also explicitly noted in the Release notes.

Furthermore java.io.Serializable has been dropped from all BCEL classes. An
extended Clirr report including this change can be reviewed here:

http://home.apache.org/~britter/commons/bcel/6.0-RC6/bcel5-bcel6-clirr-report.html

We don't consider this to be a problem because we don't see a reason for
users to serialize BCEL classes.

RAT Report:
    http://home.apache.org/~britter/commons/bcel/6.0-RC6/rat-report.html

KEYS:
  https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now,
i.e. sometime after 22:00 CEST 23-June 2016

[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...

We're almost there... :-)
Thanks!
Benedikt
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC6

Andrey Loskutov
Still +1 (for the previous state, if binary isn't changed compared with the previous RC build).

Am 20. Juni 2016 21:36:56 MESZ, schrieb Benedikt Ritter <[hidden email]>:

>Hi,
>
>after some build related problems with RC5, I'd like to call a vote to
>release Apache Commons BCEL 6.0 based on RC6. The only changes compared
>to
>RC5 is a fix in the source assembly: It now includes all files
>necessary to
>run a clean build.
>
>BCEL 6.0 RC6 is available for review here:
>  https://dist.apache.org/repos/dist/dev/commons/bcel (rev 14065)
>
>The tag is here:
> https://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC6
> (rev 1749388)
>
>Maven artifacts are here:
>
>https://repository.apache.org/content/repositories/orgapachecommons-1179/org/apache/bcel/bcel/6.0/
>
>These are the Maven artifacts and their hashes:
>
>bcel-6.0-javadoc.jar
>(SHA1: 89cf95656f0f8a93e77100c8d5811f7cd9af866b)
>bcel-6.0-sources.jar
>(SHA1: 162f96530e8935e8a71a9e6d5497026aa3bdc945)
>bcel-6.0-test-sources.jar
>(SHA1: 2b07be3a0a4560c9766d3261cd012cf636fe965a)
>bcel-6.0-tests.jar
>(SHA1: 9e825da46e0cd66f87ccd907a43c4e2ebd15b8d6)
>bcel-6.0.jar
>(SHA1: 09d0a4c32ba6c3c22f0680f89ceeaf3e677ac659)
>bcel-6.0.pom
>(SHA1: a5d48ac34909f3a0ac788d37835075be5c2bb9d7)
>
>I have tested this with Java 7 and 8 using Maven 3.3.9 on Mac OS
>10.11.5.
>
>Details of changes since 5.2 are in the release notes:
>  https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt
>http://home.apache.org/~britter/commons/bcel/6.0-RC6/changes-report.html
>
>Site:
>  http://home.apache.org/~britter/commons/bcel/6.0-RC6/
>(note some *relative* links are broken and the 6.0 directories are not
>yet
>created - these will be OK once the site is deployed)
>
>Clirr Report (compared to 5.2):
> http://home.apache.org/~britter/commons/bcel/6.0-RC6/clirr-report.html
>
>Note that Clirr reports several errors. These have been discussed on
>the ML
>already and I uploaded the site a while ago giving everybody the
>opportunity to raise objections against these changes. These changes
>are
>also explicitly noted in the Release notes.
>
>Furthermore java.io.Serializable has been dropped from all BCEL
>classes. An
>extended Clirr report including this change can be reviewed here:
>
>http://home.apache.org/~britter/commons/bcel/6.0-RC6/bcel5-bcel6-clirr-report.html
>
>We don't consider this to be a problem because we don't see a reason
>for
>users to serialize BCEL classes.
>
>RAT Report:
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/rat-report.html
>
>KEYS:
>  https://www.apache.org/dist/commons/KEYS
>
>Please review the release candidate and vote.
>This vote will close no sooner that 72 hours from now,
>i.e. sometime after 22:00 CEST 23-June 2016
>
>[ ] +1 Release these artifacts
>[ ] +0 OK, but...
>[ ] -0 OK, but really should fix...
>[ ] -1 I oppose this release because...
>
>We're almost there... :-)
>Thanks!
>Benedikt

--
Kind regards,
Andrey Loskutov

http://google.com/+AndreyLoskutov

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC6

Mark Roberts
In reply to this post by Benedikt Ritter-4
Well I was clearly confused about this release.  It has reverted back to the old class hierarchy in the name of binary compatibility.  I can see now that that was the intention and it makes sense.  However, I cannot test it (and hence vote up or down) as I am certainly not going to edit all my sources back to the 'old' system.

So my question is what is the plan?  This release gets me no closer to a place where I can quit providing my own version of BCEL with our Daikon product.  What is the plan for a release from the active tree with the new class hierarchy?

Thank you,
Mark Roberts


> -----Original Message-----
> From: Benedikt Ritter [mailto:[hidden email]]
> Sent: Monday, June 20, 2016 12:37 PM
> To: Commons Developers List
> Cc: [hidden email]; [hidden email]
> Subject: [VOTE] Release Apache Commons BCEL 6.0 based on RC6
>
> Hi,
>
> after some build related problems with RC5, I'd like to call a vote to release
> Apache Commons BCEL 6.0 based on RC6. The only changes compared to
> RC5 is a fix in the source assembly: It now includes all files necessary to run a
> clean build.
>
> BCEL 6.0 RC6 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/bcel (rev 14065)
>
> The tag is here:
>
> https://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_R
> C6
>  (rev 1749388)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-
> 1179/org/apache/bcel/bcel/6.0/
>
> These are the Maven artifacts and their hashes:
>
> bcel-6.0-javadoc.jar
> (SHA1: 89cf95656f0f8a93e77100c8d5811f7cd9af866b)
> bcel-6.0-sources.jar
> (SHA1: 162f96530e8935e8a71a9e6d5497026aa3bdc945)
> bcel-6.0-test-sources.jar
> (SHA1: 2b07be3a0a4560c9766d3261cd012cf636fe965a)
> bcel-6.0-tests.jar
> (SHA1: 9e825da46e0cd66f87ccd907a43c4e2ebd15b8d6)
> bcel-6.0.jar
> (SHA1: 09d0a4c32ba6c3c22f0680f89ceeaf3e677ac659)
> bcel-6.0.pom
> (SHA1: a5d48ac34909f3a0ac788d37835075be5c2bb9d7)
>
> I have tested this with Java 7 and 8 using Maven 3.3.9 on Mac OS 10.11.5.
>
> Details of changes since 5.2 are in the release notes:
>   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/changes-
> report.html
>
> Site:
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/
> (note some *relative* links are broken and the 6.0 directories are not yet
> created - these will be OK once the site is deployed)
>
> Clirr Report (compared to 5.2):
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/clirr-report.html
>
> Note that Clirr reports several errors. These have been discussed on the ML
> already and I uploaded the site a while ago giving everybody the opportunity
> to raise objections against these changes. These changes are also explicitly
> noted in the Release notes.
>
> Furthermore java.io.Serializable has been dropped from all BCEL classes. An
> extended Clirr report including this change can be reviewed here:
>
> http://home.apache.org/~britter/commons/bcel/6.0-RC6/bcel5-bcel6-clirr-
> report.html
>
> We don't consider this to be a problem because we don't see a reason for
> users to serialize BCEL classes.
>
> RAT Report:
>     http://home.apache.org/~britter/commons/bcel/6.0-RC6/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now, i.e. sometime after
> 22:00 CEST 23-June 2016
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> We're almost there... :-)
> Thanks!
> Benedikt


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC6

Mark Roberts
In reply to this post by Benedikt Ritter-4
Sorry - I'm replying to my own post.  Is there any chance that there is a revision point in the active tree that corresponds exactly to RC6 but without the path changes?  I could do some testing on that.

Probably too much to hope for.

Thanks,
Mark

> -----Original Message-----
> From: Mark Roberts [mailto:[hidden email]]
> Sent: Monday, June 20, 2016 4:12 PM
> To: 'Commons Developers List'
> Cc: '[hidden email]'; '[hidden email]'
> Subject: RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC6
>
> Well I was clearly confused about this release.  It has reverted back to the old
> class hierarchy in the name of binary compatibility.  I can see now that that
> was the intention and it makes sense.  However, I cannot test it (and hence
> vote up or down) as I am certainly not going to edit all my sources back to the
> 'old' system.
>
> So my question is what is the plan?  This release gets me no closer to a place
> where I can quit providing my own version of BCEL with our Daikon product.
> What is the plan for a release from the active tree with the new class
> hierarchy?
>
> Thank you,
> Mark Roberts
>
>
> > -----Original Message-----
> > From: Benedikt Ritter [mailto:[hidden email]]
> > Sent: Monday, June 20, 2016 12:37 PM
> > To: Commons Developers List
> > Cc: [hidden email]; [hidden email]
> > Subject: [VOTE] Release Apache Commons BCEL 6.0 based on RC6
> >
> > Hi,
> >
> > after some build related problems with RC5, I'd like to call a vote to
> > release Apache Commons BCEL 6.0 based on RC6. The only changes
> > compared to
> > RC5 is a fix in the source assembly: It now includes all files
> > necessary to run a clean build.
> >
> > BCEL 6.0 RC6 is available for review here:
> >   https://dist.apache.org/repos/dist/dev/commons/bcel (rev 14065)
> >
> > The tag is here:
> >
> >
> https://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_R
> > C6
> >  (rev 1749388)
> >
> > Maven artifacts are here:
> >
> > https://repository.apache.org/content/repositories/orgapachecommons-
> > 1179/org/apache/bcel/bcel/6.0/
> >
> > These are the Maven artifacts and their hashes:
> >
> > bcel-6.0-javadoc.jar
> > (SHA1: 89cf95656f0f8a93e77100c8d5811f7cd9af866b)
> > bcel-6.0-sources.jar
> > (SHA1: 162f96530e8935e8a71a9e6d5497026aa3bdc945)
> > bcel-6.0-test-sources.jar
> > (SHA1: 2b07be3a0a4560c9766d3261cd012cf636fe965a)
> > bcel-6.0-tests.jar
> > (SHA1: 9e825da46e0cd66f87ccd907a43c4e2ebd15b8d6)
> > bcel-6.0.jar
> > (SHA1: 09d0a4c32ba6c3c22f0680f89ceeaf3e677ac659)
> > bcel-6.0.pom
> > (SHA1: a5d48ac34909f3a0ac788d37835075be5c2bb9d7)
> >
> > I have tested this with Java 7 and 8 using Maven 3.3.9 on Mac OS 10.11.5.
> >
> > Details of changes since 5.2 are in the release notes:
> >   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-
> NOTES.txt
> >   http://home.apache.org/~britter/commons/bcel/6.0-RC6/changes-
> > report.html
> >
> > Site:
> >   http://home.apache.org/~britter/commons/bcel/6.0-RC6/
> > (note some *relative* links are broken and the 6.0 directories are not
> > yet created - these will be OK once the site is deployed)
> >
> > Clirr Report (compared to 5.2):
> >
> > http://home.apache.org/~britter/commons/bcel/6.0-RC6/clirr-report.html
> >
> > Note that Clirr reports several errors. These have been discussed on
> > the ML already and I uploaded the site a while ago giving everybody
> > the opportunity to raise objections against these changes. These
> > changes are also explicitly noted in the Release notes.
> >
> > Furthermore java.io.Serializable has been dropped from all BCEL
> > classes. An extended Clirr report including this change can be reviewed
> here:
> >
> > http://home.apache.org/~britter/commons/bcel/6.0-RC6/bcel5-bcel6-clirr
> > -
> > report.html
> >
> > We don't consider this to be a problem because we don't see a reason
> > for users to serialize BCEL classes.
> >
> > RAT Report:
> >
> > http://home.apache.org/~britter/commons/bcel/6.0-RC6/rat-report.html
> >
> > KEYS:
> >   https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote.
> > This vote will close no sooner that 72 hours from now, i.e. sometime
> > after
> > 22:00 CEST 23-June 2016
> >
> > [ ] +1 Release these artifacts
> > [ ] +0 OK, but...
> > [ ] -0 OK, but really should fix...
> > [ ] -1 I oppose this release because...
> >
> > We're almost there... :-)
> > Thanks!
> > Benedikt


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC6

sebb-2-2
On 21 June 2016 at 00:14, Mark Roberts <[hidden email]> wrote:
> Sorry - I'm replying to my own post.  Is there any chance that there is a revision point in the active tree that corresponds exactly to RC6 but without the path changes?  I could do some testing on that.

I don't think so; there were some subsequent fixes

> Probably too much to hope for.

However, it's pretty easy to use the Maven Shade plugin to produce an
updated version of the jar with the changed package names.

I'll email you a copy of a pom under separate cover.

> Thanks,
> Mark
>
>> -----Original Message-----
>> From: Mark Roberts [mailto:[hidden email]]
>> Sent: Monday, June 20, 2016 4:12 PM
>> To: 'Commons Developers List'
>> Cc: '[hidden email]'; '[hidden email]'
>> Subject: RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC6
>>
>> Well I was clearly confused about this release.  It has reverted back to the old
>> class hierarchy in the name of binary compatibility.  I can see now that that
>> was the intention and it makes sense.  However, I cannot test it (and hence
>> vote up or down) as I am certainly not going to edit all my sources back to the
>> 'old' system.
>>
>> So my question is what is the plan?  This release gets me no closer to a place
>> where I can quit providing my own version of BCEL with our Daikon product.
>> What is the plan for a release from the active tree with the new class
>> hierarchy?
>>
>> Thank you,
>> Mark Roberts
>>
>>
>> > -----Original Message-----
>> > From: Benedikt Ritter [mailto:[hidden email]]
>> > Sent: Monday, June 20, 2016 12:37 PM
>> > To: Commons Developers List
>> > Cc: [hidden email]; [hidden email]
>> > Subject: [VOTE] Release Apache Commons BCEL 6.0 based on RC6
>> >
>> > Hi,
>> >
>> > after some build related problems with RC5, I'd like to call a vote to
>> > release Apache Commons BCEL 6.0 based on RC6. The only changes
>> > compared to
>> > RC5 is a fix in the source assembly: It now includes all files
>> > necessary to run a clean build.
>> >
>> > BCEL 6.0 RC6 is available for review here:
>> >   https://dist.apache.org/repos/dist/dev/commons/bcel (rev 14065)
>> >
>> > The tag is here:
>> >
>> >
>> https://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_R
>> > C6
>> >  (rev 1749388)
>> >
>> > Maven artifacts are here:
>> >
>> > https://repository.apache.org/content/repositories/orgapachecommons-
>> > 1179/org/apache/bcel/bcel/6.0/
>> >
>> > These are the Maven artifacts and their hashes:
>> >
>> > bcel-6.0-javadoc.jar
>> > (SHA1: 89cf95656f0f8a93e77100c8d5811f7cd9af866b)
>> > bcel-6.0-sources.jar
>> > (SHA1: 162f96530e8935e8a71a9e6d5497026aa3bdc945)
>> > bcel-6.0-test-sources.jar
>> > (SHA1: 2b07be3a0a4560c9766d3261cd012cf636fe965a)
>> > bcel-6.0-tests.jar
>> > (SHA1: 9e825da46e0cd66f87ccd907a43c4e2ebd15b8d6)
>> > bcel-6.0.jar
>> > (SHA1: 09d0a4c32ba6c3c22f0680f89ceeaf3e677ac659)
>> > bcel-6.0.pom
>> > (SHA1: a5d48ac34909f3a0ac788d37835075be5c2bb9d7)
>> >
>> > I have tested this with Java 7 and 8 using Maven 3.3.9 on Mac OS 10.11.5.
>> >
>> > Details of changes since 5.2 are in the release notes:
>> >   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-
>> NOTES.txt
>> >   http://home.apache.org/~britter/commons/bcel/6.0-RC6/changes-
>> > report.html
>> >
>> > Site:
>> >   http://home.apache.org/~britter/commons/bcel/6.0-RC6/
>> > (note some *relative* links are broken and the 6.0 directories are not
>> > yet created - these will be OK once the site is deployed)
>> >
>> > Clirr Report (compared to 5.2):
>> >
>> > http://home.apache.org/~britter/commons/bcel/6.0-RC6/clirr-report.html
>> >
>> > Note that Clirr reports several errors. These have been discussed on
>> > the ML already and I uploaded the site a while ago giving everybody
>> > the opportunity to raise objections against these changes. These
>> > changes are also explicitly noted in the Release notes.
>> >
>> > Furthermore java.io.Serializable has been dropped from all BCEL
>> > classes. An extended Clirr report including this change can be reviewed
>> here:
>> >
>> > http://home.apache.org/~britter/commons/bcel/6.0-RC6/bcel5-bcel6-clirr
>> > -
>> > report.html
>> >
>> > We don't consider this to be a problem because we don't see a reason
>> > for users to serialize BCEL classes.
>> >
>> > RAT Report:
>> >
>> > http://home.apache.org/~britter/commons/bcel/6.0-RC6/rat-report.html
>> >
>> > KEYS:
>> >   https://www.apache.org/dist/commons/KEYS
>> >
>> > Please review the release candidate and vote.
>> > This vote will close no sooner that 72 hours from now, i.e. sometime
>> > after
>> > 22:00 CEST 23-June 2016
>> >
>> > [ ] +1 Release these artifacts
>> > [ ] +0 OK, but...
>> > [ ] -0 OK, but really should fix...
>> > [ ] -1 I oppose this release because...
>> >
>> > We're almost there... :-)
>> > Thanks!
>> > Benedikt
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC6

Dave Brosius-2
In reply to this post by Mark Roberts
Doubt it, but you could certainly 'shade
<https://maven.apache.org/plugins/maven-shade-plugin/>' the plugin with
maven to convert all references from the original path to the path
you're expecting.

On 06/20/2016 07:14 PM, Mark Roberts wrote:

> Sorry - I'm replying to my own post.  Is there any chance that there is a revision point in the active tree that corresponds exactly to RC6 but without the path changes?  I could do some testing on that.
>
> Probably too much to hope for.
>
> Thanks,
> Mark
>
>> -----Original Message-----
>> From: Mark Roberts [mailto:[hidden email]]
>> Sent: Monday, June 20, 2016 4:12 PM
>> To: 'Commons Developers List'
>> Cc: '[hidden email]'; '[hidden email]'
>> Subject: RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC6
>>
>> Well I was clearly confused about this release.  It has reverted back to the old
>> class hierarchy in the name of binary compatibility.  I can see now that that
>> was the intention and it makes sense.  However, I cannot test it (and hence
>> vote up or down) as I am certainly not going to edit all my sources back to the
>> 'old' system.
>>
>> So my question is what is the plan?  This release gets me no closer to a place
>> where I can quit providing my own version of BCEL with our Daikon product.
>> What is the plan for a release from the active tree with the new class
>> hierarchy?
>>
>> Thank you,
>> Mark Roberts
>>
>>
>>> -----Original Message-----
>>> From: Benedikt Ritter [mailto:[hidden email]]
>>> Sent: Monday, June 20, 2016 12:37 PM
>>> To: Commons Developers List
>>> Cc: [hidden email]; [hidden email]
>>> Subject: [VOTE] Release Apache Commons BCEL 6.0 based on RC6
>>>
>>> Hi,
>>>
>>> after some build related problems with RC5, I'd like to call a vote to
>>> release Apache Commons BCEL 6.0 based on RC6. The only changes
>>> compared to
>>> RC5 is a fix in the source assembly: It now includes all files
>>> necessary to run a clean build.
>>>
>>> BCEL 6.0 RC6 is available for review here:
>>>    https://dist.apache.org/repos/dist/dev/commons/bcel (rev 14065)
>>>
>>> The tag is here:
>>>
>>>
>> https://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_R
>>> C6
>>>   (rev 1749388)
>>>
>>> Maven artifacts are here:
>>>
>>> https://repository.apache.org/content/repositories/orgapachecommons-
>>> 1179/org/apache/bcel/bcel/6.0/
>>>
>>> These are the Maven artifacts and their hashes:
>>>
>>> bcel-6.0-javadoc.jar
>>> (SHA1: 89cf95656f0f8a93e77100c8d5811f7cd9af866b)
>>> bcel-6.0-sources.jar
>>> (SHA1: 162f96530e8935e8a71a9e6d5497026aa3bdc945)
>>> bcel-6.0-test-sources.jar
>>> (SHA1: 2b07be3a0a4560c9766d3261cd012cf636fe965a)
>>> bcel-6.0-tests.jar
>>> (SHA1: 9e825da46e0cd66f87ccd907a43c4e2ebd15b8d6)
>>> bcel-6.0.jar
>>> (SHA1: 09d0a4c32ba6c3c22f0680f89ceeaf3e677ac659)
>>> bcel-6.0.pom
>>> (SHA1: a5d48ac34909f3a0ac788d37835075be5c2bb9d7)
>>>
>>> I have tested this with Java 7 and 8 using Maven 3.3.9 on Mac OS 10.11.5.
>>>
>>> Details of changes since 5.2 are in the release notes:
>>>    https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-
>> NOTES.txt
>>>    http://home.apache.org/~britter/commons/bcel/6.0-RC6/changes-
>>> report.html
>>>
>>> Site:
>>>    http://home.apache.org/~britter/commons/bcel/6.0-RC6/
>>> (note some *relative* links are broken and the 6.0 directories are not
>>> yet created - these will be OK once the site is deployed)
>>>
>>> Clirr Report (compared to 5.2):
>>>
>>> http://home.apache.org/~britter/commons/bcel/6.0-RC6/clirr-report.html
>>>
>>> Note that Clirr reports several errors. These have been discussed on
>>> the ML already and I uploaded the site a while ago giving everybody
>>> the opportunity to raise objections against these changes. These
>>> changes are also explicitly noted in the Release notes.
>>>
>>> Furthermore java.io.Serializable has been dropped from all BCEL
>>> classes. An extended Clirr report including this change can be reviewed
>> here:
>>> http://home.apache.org/~britter/commons/bcel/6.0-RC6/bcel5-bcel6-clirr
>>> -
>>> report.html
>>>
>>> We don't consider this to be a problem because we don't see a reason
>>> for users to serialize BCEL classes.
>>>
>>> RAT Report:
>>>
>>> http://home.apache.org/~britter/commons/bcel/6.0-RC6/rat-report.html
>>>
>>> KEYS:
>>>    https://www.apache.org/dist/commons/KEYS
>>>
>>> Please review the release candidate and vote.
>>> This vote will close no sooner that 72 hours from now, i.e. sometime
>>> after
>>> 22:00 CEST 23-June 2016
>>>
>>> [ ] +1 Release these artifacts
>>> [ ] +0 OK, but...
>>> [ ] -0 OK, but really should fix...
>>> [ ] -1 I oppose this release because...
>>>
>>> We're almost there... :-)
>>> Thanks!
>>> Benedikt
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC6

Jörg Schaible-5
In reply to this post by sebb-2-2
Hi Sebb,

sebb wrote:

> On 21 June 2016 at 00:14, Mark Roberts <[hidden email]> wrote:
>> Sorry - I'm replying to my own post.  Is there any chance that there is a
>> revision point in the active tree that corresponds exactly to RC6 but
>> without the path changes?  I could do some testing on that.
>
> I don't think so; there were some subsequent fixes
>
>> Probably too much to hope for.
>
> However, it's pretty easy to use the Maven Shade plugin to produce an
> updated version of the jar with the changed package names.
>
> I'll email you a copy of a pom under separate cover.


Coudn't we add a profile to the commons parent for this and use properties
for the variable configuration parts?

Cheers,
Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC6

garydgregory
In reply to this post by Benedikt Ritter-4
[ Ducking behind a stack of crates for the incoming flight of tomatoes ;-) ]

Pardon me for asking since we've been talking about BC forever, but, while
we are not 100% BC and we explain that well, why bother making BC-breaking
changes that appear to be in the non-essential clean up category for what
could be a full BC-break: Removed org.apache.bcel.Constants and
org.apache.bcel.generic.InstructionConstants from the set of implemented
interfaces for some 7 classes.

Since the goal for 6.0 is to be as BC as possible without causing too much
harm for the benefit of supporting Java 7 and 8, why bother actually making
non-essential BC-breaking changes? Or are these changes required?

Thank you,
Gary

On Mon, Jun 20, 2016 at 12:36 PM, Benedikt Ritter <[hidden email]>
wrote:

> Hi,
>
> after some build related problems with RC5, I'd like to call a vote to
> release Apache Commons BCEL 6.0 based on RC6. The only changes compared to
> RC5 is a fix in the source assembly: It now includes all files necessary to
> run a clean build.
>
> BCEL 6.0 RC6 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/bcel (rev 14065)
>
> The tag is here:
>   https://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC6
>  (rev 1749388)
>
> Maven artifacts are here:
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-1179/org/apache/bcel/bcel/6.0/
>
> These are the Maven artifacts and their hashes:
>
> bcel-6.0-javadoc.jar
> (SHA1: 89cf95656f0f8a93e77100c8d5811f7cd9af866b)
> bcel-6.0-sources.jar
> (SHA1: 162f96530e8935e8a71a9e6d5497026aa3bdc945)
> bcel-6.0-test-sources.jar
> (SHA1: 2b07be3a0a4560c9766d3261cd012cf636fe965a)
> bcel-6.0-tests.jar
> (SHA1: 9e825da46e0cd66f87ccd907a43c4e2ebd15b8d6)
> bcel-6.0.jar
> (SHA1: 09d0a4c32ba6c3c22f0680f89ceeaf3e677ac659)
> bcel-6.0.pom
> (SHA1: a5d48ac34909f3a0ac788d37835075be5c2bb9d7)
>
> I have tested this with Java 7 and 8 using Maven 3.3.9 on Mac OS 10.11.5.
>
> Details of changes since 5.2 are in the release notes:
>   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/changes-report.html
>
> Site:
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/
> (note some *relative* links are broken and the 6.0 directories are not yet
> created - these will be OK once the site is deployed)
>
> Clirr Report (compared to 5.2):
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/clirr-report.html
>
> Note that Clirr reports several errors. These have been discussed on the ML
> already and I uploaded the site a while ago giving everybody the
> opportunity to raise objections against these changes. These changes are
> also explicitly noted in the Release notes.
>
> Furthermore java.io.Serializable has been dropped from all BCEL classes. An
> extended Clirr report including this change can be reviewed here:
>
>
> http://home.apache.org/~britter/commons/bcel/6.0-RC6/bcel5-bcel6-clirr-report.html
>
> We don't consider this to be a problem because we don't see a reason for
> users to serialize BCEL classes.
>
> RAT Report:
>     http://home.apache.org/~britter/commons/bcel/6.0-RC6/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now,
> i.e. sometime after 22:00 CEST 23-June 2016
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> We're almost there... :-)
> Thanks!
> Benedikt
>



--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC6

Benedikt Ritter-4
Hi,

Gary Gregory <[hidden email]> schrieb am Di., 21. Juni 2016 um
21:04 Uhr:

> [ Ducking behind a stack of crates for the incoming flight of tomatoes ;-)
> ]
>

It only took about 20 minutes to create RC6, so no tomatoes ;-)


>
> Pardon me for asking since we've been talking about BC forever, but, while
> we are not 100% BC and we explain that well, why bother making BC-breaking
> changes that appear to be in the non-essential clean up category for what
> could be a full BC-break: Removed org.apache.bcel.Constants and
> org.apache.bcel.generic.InstructionConstants from the set of implemented
> interfaces for some 7 classes.
>
> Since the goal for 6.0 is to be as BC as possible without causing too much
> harm for the benefit of supporting Java 7 and 8, why bother actually making
> non-essential BC-breaking changes? Or are these changes required?
>

It took us 10 years to prepare BCEL 6.0 so another RC round won't hurt. Do
you have some cycles to help fixing the issues? I'm in the middle of
preparing a talk I'm about to give next week, so I only have limited time.
But if we join forces... :-)

Anything else you found while reviewing?

Regards,
Benedikt


>
> Thank you,
> Gary
>
> On Mon, Jun 20, 2016 at 12:36 PM, Benedikt Ritter <[hidden email]>
> wrote:
>
> > Hi,
> >
> > after some build related problems with RC5, I'd like to call a vote to
> > release Apache Commons BCEL 6.0 based on RC6. The only changes compared
> to
> > RC5 is a fix in the source assembly: It now includes all files necessary
> to
> > run a clean build.
> >
> > BCEL 6.0 RC6 is available for review here:
> >   https://dist.apache.org/repos/dist/dev/commons/bcel (rev 14065)
> >
> > The tag is here:
> >   https://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC6
> >  (rev 1749388)
> >
> > Maven artifacts are here:
> >
> >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1179/org/apache/bcel/bcel/6.0/
> >
> > These are the Maven artifacts and their hashes:
> >
> > bcel-6.0-javadoc.jar
> > (SHA1: 89cf95656f0f8a93e77100c8d5811f7cd9af866b)
> > bcel-6.0-sources.jar
> > (SHA1: 162f96530e8935e8a71a9e6d5497026aa3bdc945)
> > bcel-6.0-test-sources.jar
> > (SHA1: 2b07be3a0a4560c9766d3261cd012cf636fe965a)
> > bcel-6.0-tests.jar
> > (SHA1: 9e825da46e0cd66f87ccd907a43c4e2ebd15b8d6)
> > bcel-6.0.jar
> > (SHA1: 09d0a4c32ba6c3c22f0680f89ceeaf3e677ac659)
> > bcel-6.0.pom
> > (SHA1: a5d48ac34909f3a0ac788d37835075be5c2bb9d7)
> >
> > I have tested this with Java 7 and 8 using Maven 3.3.9 on Mac OS 10.11.5.
> >
> > Details of changes since 5.2 are in the release notes:
> >   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt
> >
> http://home.apache.org/~britter/commons/bcel/6.0-RC6/changes-report.html
> >
> > Site:
> >   http://home.apache.org/~britter/commons/bcel/6.0-RC6/
> > (note some *relative* links are broken and the 6.0 directories are not
> yet
> > created - these will be OK once the site is deployed)
> >
> > Clirr Report (compared to 5.2):
> >   http://home.apache.org/~britter/commons/bcel/6.0-RC6/clirr-report.html
> >
> > Note that Clirr reports several errors. These have been discussed on the
> ML
> > already and I uploaded the site a while ago giving everybody the
> > opportunity to raise objections against these changes. These changes are
> > also explicitly noted in the Release notes.
> >
> > Furthermore java.io.Serializable has been dropped from all BCEL classes.
> An
> > extended Clirr report including this change can be reviewed here:
> >
> >
> >
> http://home.apache.org/~britter/commons/bcel/6.0-RC6/bcel5-bcel6-clirr-report.html
> >
> > We don't consider this to be a problem because we don't see a reason for
> > users to serialize BCEL classes.
> >
> > RAT Report:
> >     http://home.apache.org/~britter/commons/bcel/6.0-RC6/rat-report.html
> >
> > KEYS:
> >   https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote.
> > This vote will close no sooner that 72 hours from now,
> > i.e. sometime after 22:00 CEST 23-June 2016
> >
> > [ ] +1 Release these artifacts
> > [ ] +0 OK, but...
> > [ ] -0 OK, but really should fix...
> > [ ] -1 I oppose this release because...
> >
> > We're almost there... :-)
> > Thanks!
> > Benedikt
> >
>
>
>
> --
> E-Mail: [hidden email] | [hidden email]
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC6

garydgregory
On Tue, Jun 21, 2016 at 12:17 PM, Benedikt Ritter <[hidden email]>
wrote:

> Hi,
>
> Gary Gregory <[hidden email]> schrieb am Di., 21. Juni 2016 um
> 21:04 Uhr:
>
> > [ Ducking behind a stack of crates for the incoming flight of tomatoes
> ;-)
> > ]
> >
>
> It only took about 20 minutes to create RC6, so no tomatoes ;-)
>
>
> >
> > Pardon me for asking since we've been talking about BC forever, but,
> while
> > we are not 100% BC and we explain that well, why bother making
> BC-breaking
> > changes that appear to be in the non-essential clean up category for what
> > could be a full BC-break: Removed org.apache.bcel.Constants and
> > org.apache.bcel.generic.InstructionConstants from the set of implemented
> > interfaces for some 7 classes.
> >
> > Since the goal for 6.0 is to be as BC as possible without causing too
> much
> > harm for the benefit of supporting Java 7 and 8, why bother actually
> making
> > non-essential BC-breaking changes? Or are these changes required?
> >
>
> It took us 10 years to prepare BCEL 6.0 so another RC round won't hurt. Do
> you have some cycles to help fixing the issues? I'm in the middle of
> preparing a talk I'm about to give next week, so I only have limited time.
> But if we join forces... :-)
>
> Anything else you found while reviewing?
>

MD5, SHA1, ASC are OK. RAT report is OK on your site, BUT a manual RAT
check (mvn apache-rat:check) is not:

Unapproved licenses:

  docs/classfile.mdl
  docs/eps/classfile.fig
  docs/eps/classgen.fig
  docs/eps/classloader.fig
  docs/eps/constantpool.fig
  docs/eps/diagram.fig
  docs/eps/il.fig
  docs/eps/instructions.fig
  docs/eps/javaclass.fig
  docs/eps/jvm.fig
  docs/generic.mdl
  docs/manual.bib
  docs/verifier/chap1.eps
  docs/verifier/classfile.eps
  docs/verifier/conventcfg.eps
  docs/verifier/exframe.eps
  docs/verifier/GUI1.eps
  docs/verifier/GUI2.eps
  docs/verifier/justicecfg.eps
  docs/verifier/VennDiag.eps
  docs/verifier/VerificationAPI.eps
  docs/verifier/V_API_SD.eps
  src/examples/Mini/fac.mini
  src/examples/Mini/fib.mini
  src/examples/Mini/max.mini
  src/examples/Mini/Mini.bnf
  src/examples/Mini/MiniParser$JJCalls
  src/test/resources/Java8Example.java


Sure, we could fix PMD, Findbugs, but that's not worse than before I assume.

I'll what I can do...

Gary


> Regards,
> Benedikt
>
>
> >
> > Thank you,
> > Gary
> >
> > On Mon, Jun 20, 2016 at 12:36 PM, Benedikt Ritter <[hidden email]>
> > wrote:
> >
> > > Hi,
> > >
> > > after some build related problems with RC5, I'd like to call a vote to
> > > release Apache Commons BCEL 6.0 based on RC6. The only changes compared
> > to
> > > RC5 is a fix in the source assembly: It now includes all files
> necessary
> > to
> > > run a clean build.
> > >
> > > BCEL 6.0 RC6 is available for review here:
> > >   https://dist.apache.org/repos/dist/dev/commons/bcel (rev 14065)
> > >
> > > The tag is here:
> > >
> https://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC6
> > >  (rev 1749388)
> > >
> > > Maven artifacts are here:
> > >
> > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1179/org/apache/bcel/bcel/6.0/
> > >
> > > These are the Maven artifacts and their hashes:
> > >
> > > bcel-6.0-javadoc.jar
> > > (SHA1: 89cf95656f0f8a93e77100c8d5811f7cd9af866b)
> > > bcel-6.0-sources.jar
> > > (SHA1: 162f96530e8935e8a71a9e6d5497026aa3bdc945)
> > > bcel-6.0-test-sources.jar
> > > (SHA1: 2b07be3a0a4560c9766d3261cd012cf636fe965a)
> > > bcel-6.0-tests.jar
> > > (SHA1: 9e825da46e0cd66f87ccd907a43c4e2ebd15b8d6)
> > > bcel-6.0.jar
> > > (SHA1: 09d0a4c32ba6c3c22f0680f89ceeaf3e677ac659)
> > > bcel-6.0.pom
> > > (SHA1: a5d48ac34909f3a0ac788d37835075be5c2bb9d7)
> > >
> > > I have tested this with Java 7 and 8 using Maven 3.3.9 on Mac OS
> 10.11.5.
> > >
> > > Details of changes since 5.2 are in the release notes:
> > >
> https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt
> > >
> > http://home.apache.org/~britter/commons/bcel/6.0-RC6/changes-report.html
> > >
> > > Site:
> > >   http://home.apache.org/~britter/commons/bcel/6.0-RC6/
> > > (note some *relative* links are broken and the 6.0 directories are not
> > yet
> > > created - these will be OK once the site is deployed)
> > >
> > > Clirr Report (compared to 5.2):
> > >
> http://home.apache.org/~britter/commons/bcel/6.0-RC6/clirr-report.html
> > >
> > > Note that Clirr reports several errors. These have been discussed on
> the
> > ML
> > > already and I uploaded the site a while ago giving everybody the
> > > opportunity to raise objections against these changes. These changes
> are
> > > also explicitly noted in the Release notes.
> > >
> > > Furthermore java.io.Serializable has been dropped from all BCEL
> classes.
> > An
> > > extended Clirr report including this change can be reviewed here:
> > >
> > >
> > >
> >
> http://home.apache.org/~britter/commons/bcel/6.0-RC6/bcel5-bcel6-clirr-report.html
> > >
> > > We don't consider this to be a problem because we don't see a reason
> for
> > > users to serialize BCEL classes.
> > >
> > > RAT Report:
> > >
> http://home.apache.org/~britter/commons/bcel/6.0-RC6/rat-report.html
> > >
> > > KEYS:
> > >   https://www.apache.org/dist/commons/KEYS
> > >
> > > Please review the release candidate and vote.
> > > This vote will close no sooner that 72 hours from now,
> > > i.e. sometime after 22:00 CEST 23-June 2016
> > >
> > > [ ] +1 Release these artifacts
> > > [ ] +0 OK, but...
> > > [ ] -0 OK, but really should fix...
> > > [ ] -1 I oppose this release because...
> > >
> > > We're almost there... :-)
> > > Thanks!
> > > Benedikt
> > >
> >
> >
> >
> > --
> > E-Mail: [hidden email] | [hidden email]
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
> >
>



--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC6

Mark Roberts
In reply to this post by Benedikt Ritter-4
Thanks to sebb's suggestion of using shade I was able to test RC6.

Unfortunately, I am unable to vote as rev 1747124 breaks Daikon.  (We are required to build with -Werror).  This change is not in the active tree so that's good.  The problem is that  https://issues.apache.org/jira/browse/BCEL-262 is unresolved.  There is a suggested workaround for the deprecation, but it is very awkward:
invoke.getClassName(pool) versus invoke.getReferenceType(pool).getClass().getName()

Thanks,
Mark


> -----Original Message-----
> From: Benedikt Ritter [mailto:[hidden email]]
> Sent: Monday, June 20, 2016 12:37 PM
> To: Commons Developers List
> Cc: [hidden email]; [hidden email]
> Subject: [VOTE] Release Apache Commons BCEL 6.0 based on RC6
>
> Hi,
>
> after some build related problems with RC5, I'd like to call a vote to release
> Apache Commons BCEL 6.0 based on RC6. The only changes compared to
> RC5 is a fix in the source assembly: It now includes all files necessary to run a
> clean build.
>
> BCEL 6.0 RC6 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/bcel (rev 14065)
>
> The tag is here:
>
> https://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_R
> C6
>  (rev 1749388)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-
> 1179/org/apache/bcel/bcel/6.0/
>
> These are the Maven artifacts and their hashes:
>
> bcel-6.0-javadoc.jar
> (SHA1: 89cf95656f0f8a93e77100c8d5811f7cd9af866b)
> bcel-6.0-sources.jar
> (SHA1: 162f96530e8935e8a71a9e6d5497026aa3bdc945)
> bcel-6.0-test-sources.jar
> (SHA1: 2b07be3a0a4560c9766d3261cd012cf636fe965a)
> bcel-6.0-tests.jar
> (SHA1: 9e825da46e0cd66f87ccd907a43c4e2ebd15b8d6)
> bcel-6.0.jar
> (SHA1: 09d0a4c32ba6c3c22f0680f89ceeaf3e677ac659)
> bcel-6.0.pom
> (SHA1: a5d48ac34909f3a0ac788d37835075be5c2bb9d7)
>
> I have tested this with Java 7 and 8 using Maven 3.3.9 on Mac OS 10.11.5.
>
> Details of changes since 5.2 are in the release notes:
>   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/changes-
> report.html
>
> Site:
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/
> (note some *relative* links are broken and the 6.0 directories are not yet
> created - these will be OK once the site is deployed)
>
> Clirr Report (compared to 5.2):
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/clirr-report.html
>
> Note that Clirr reports several errors. These have been discussed on the ML
> already and I uploaded the site a while ago giving everybody the opportunity
> to raise objections against these changes. These changes are also explicitly
> noted in the Release notes.
>
> Furthermore java.io.Serializable has been dropped from all BCEL classes. An
> extended Clirr report including this change can be reviewed here:
>
> http://home.apache.org/~britter/commons/bcel/6.0-RC6/bcel5-bcel6-clirr-
> report.html
>
> We don't consider this to be a problem because we don't see a reason for
> users to serialize BCEL classes.
>
> RAT Report:
>     http://home.apache.org/~britter/commons/bcel/6.0-RC6/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now, i.e. sometime after
> 22:00 CEST 23-June 2016
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> We're almost there... :-)
> Thanks!
> Benedikt


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC6

garydgregory
In reply to this post by garydgregory
On Tue, Jun 21, 2016 at 12:31 PM, Gary Gregory <[hidden email]>
wrote:

> On Tue, Jun 21, 2016 at 12:17 PM, Benedikt Ritter <[hidden email]>
> wrote:
>
>> Hi,
>>
>> Gary Gregory <[hidden email]> schrieb am Di., 21. Juni 2016 um
>> 21:04 Uhr:
>>
>> > [ Ducking behind a stack of crates for the incoming flight of tomatoes
>> ;-)
>> > ]
>> >
>>
>> It only took about 20 minutes to create RC6, so no tomatoes ;-)
>>
>>
>> >
>> > Pardon me for asking since we've been talking about BC forever, but,
>> while
>> > we are not 100% BC and we explain that well, why bother making
>> BC-breaking
>> > changes that appear to be in the non-essential clean up category for
>> what
>> > could be a full BC-break: Removed org.apache.bcel.Constants and
>> > org.apache.bcel.generic.InstructionConstants from the set of implemented
>> > interfaces for some 7 classes.
>> >
>> > Since the goal for 6.0 is to be as BC as possible without causing too
>> much
>> > harm for the benefit of supporting Java 7 and 8, why bother actually
>> making
>> > non-essential BC-breaking changes? Or are these changes required?
>> >
>>
>> It took us 10 years to prepare BCEL 6.0 so another RC round won't hurt. Do
>> you have some cycles to help fixing the issues? I'm in the middle of
>> preparing a talk I'm about to give next week, so I only have limited time.
>> But if we join forces... :-)
>>
>> Anything else you found while reviewing?
>>
>
> MD5, SHA1, ASC are OK. RAT report is OK on your site, BUT a manual RAT
> check (mvn apache-rat:check) is not:
>
> Unapproved licenses:
>
>   docs/classfile.mdl
>   docs/eps/classfile.fig
>   docs/eps/classgen.fig
>   docs/eps/classloader.fig
>   docs/eps/constantpool.fig
>   docs/eps/diagram.fig
>   docs/eps/il.fig
>   docs/eps/instructions.fig
>   docs/eps/javaclass.fig
>   docs/eps/jvm.fig
>   docs/generic.mdl
>   docs/manual.bib
>   docs/verifier/chap1.eps
>   docs/verifier/classfile.eps
>   docs/verifier/conventcfg.eps
>   docs/verifier/exframe.eps
>   docs/verifier/GUI1.eps
>   docs/verifier/GUI2.eps
>   docs/verifier/justicecfg.eps
>   docs/verifier/VennDiag.eps
>   docs/verifier/VerificationAPI.eps
>   docs/verifier/V_API_SD.eps
>   src/examples/Mini/fac.mini
>   src/examples/Mini/fib.mini
>   src/examples/Mini/max.mini
>   src/examples/Mini/Mini.bnf
>   src/examples/Mini/MiniParser$JJCalls
>   src/test/resources/Java8Example.java
>
>
> Sure, we could fix PMD, Findbugs, but that's not worse than before I
> assume.
>
> I'll what I can do...
>

I've tidied up some loos ends and beefed up a test when it runs on Windows.

Gary


>
> Gary
>
>
>> Regards,
>> Benedikt
>>
>>
>> >
>> > Thank you,
>> > Gary
>> >
>> > On Mon, Jun 20, 2016 at 12:36 PM, Benedikt Ritter <[hidden email]>
>> > wrote:
>> >
>> > > Hi,
>> > >
>> > > after some build related problems with RC5, I'd like to call a vote to
>> > > release Apache Commons BCEL 6.0 based on RC6. The only changes
>> compared
>> > to
>> > > RC5 is a fix in the source assembly: It now includes all files
>> necessary
>> > to
>> > > run a clean build.
>> > >
>> > > BCEL 6.0 RC6 is available for review here:
>> > >   https://dist.apache.org/repos/dist/dev/commons/bcel (rev 14065)
>> > >
>> > > The tag is here:
>> > >
>> https://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC6
>> > >  (rev 1749388)
>> > >
>> > > Maven artifacts are here:
>> > >
>> > >
>> > >
>> >
>> https://repository.apache.org/content/repositories/orgapachecommons-1179/org/apache/bcel/bcel/6.0/
>> > >
>> > > These are the Maven artifacts and their hashes:
>> > >
>> > > bcel-6.0-javadoc.jar
>> > > (SHA1: 89cf95656f0f8a93e77100c8d5811f7cd9af866b)
>> > > bcel-6.0-sources.jar
>> > > (SHA1: 162f96530e8935e8a71a9e6d5497026aa3bdc945)
>> > > bcel-6.0-test-sources.jar
>> > > (SHA1: 2b07be3a0a4560c9766d3261cd012cf636fe965a)
>> > > bcel-6.0-tests.jar
>> > > (SHA1: 9e825da46e0cd66f87ccd907a43c4e2ebd15b8d6)
>> > > bcel-6.0.jar
>> > > (SHA1: 09d0a4c32ba6c3c22f0680f89ceeaf3e677ac659)
>> > > bcel-6.0.pom
>> > > (SHA1: a5d48ac34909f3a0ac788d37835075be5c2bb9d7)
>> > >
>> > > I have tested this with Java 7 and 8 using Maven 3.3.9 on Mac OS
>> 10.11.5.
>> > >
>> > > Details of changes since 5.2 are in the release notes:
>> > >
>> https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt
>> > >
>> >
>> http://home.apache.org/~britter/commons/bcel/6.0-RC6/changes-report.html
>> > >
>> > > Site:
>> > >   http://home.apache.org/~britter/commons/bcel/6.0-RC6/
>> > > (note some *relative* links are broken and the 6.0 directories are not
>> > yet
>> > > created - these will be OK once the site is deployed)
>> > >
>> > > Clirr Report (compared to 5.2):
>> > >
>> http://home.apache.org/~britter/commons/bcel/6.0-RC6/clirr-report.html
>> > >
>> > > Note that Clirr reports several errors. These have been discussed on
>> the
>> > ML
>> > > already and I uploaded the site a while ago giving everybody the
>> > > opportunity to raise objections against these changes. These changes
>> are
>> > > also explicitly noted in the Release notes.
>> > >
>> > > Furthermore java.io.Serializable has been dropped from all BCEL
>> classes.
>> > An
>> > > extended Clirr report including this change can be reviewed here:
>> > >
>> > >
>> > >
>> >
>> http://home.apache.org/~britter/commons/bcel/6.0-RC6/bcel5-bcel6-clirr-report.html
>> > >
>> > > We don't consider this to be a problem because we don't see a reason
>> for
>> > > users to serialize BCEL classes.
>> > >
>> > > RAT Report:
>> > >
>> http://home.apache.org/~britter/commons/bcel/6.0-RC6/rat-report.html
>> > >
>> > > KEYS:
>> > >   https://www.apache.org/dist/commons/KEYS
>> > >
>> > > Please review the release candidate and vote.
>> > > This vote will close no sooner that 72 hours from now,
>> > > i.e. sometime after 22:00 CEST 23-June 2016
>> > >
>> > > [ ] +1 Release these artifacts
>> > > [ ] +0 OK, but...
>> > > [ ] -0 OK, but really should fix...
>> > > [ ] -1 I oppose this release because...
>> > >
>> > > We're almost there... :-)
>> > > Thanks!
>> > > Benedikt
>> > >
>> >
>> >
>> >
>> > --
>> > E-Mail: [hidden email] | [hidden email]
>> > Java Persistence with Hibernate, Second Edition
>> > <http://www.manning.com/bauer3/>
>> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> > Spring Batch in Action <http://www.manning.com/templier/>
>> > Blog: http://garygregory.wordpress.com
>> > Home: http://garygregory.com/
>> > Tweet! http://twitter.com/GaryGregory
>> >
>>
>
>
>
> --
> E-Mail: [hidden email] | [hidden email]
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

[CANCEL][VOTE] Release Apache Commons BCEL 6.0 based on RC6

Benedikt Ritter-4
In reply to this post by Benedikt Ritter-4
Hi,

this vote is canceled to pic up the latest changes from trunk. I'll prepare
RC7 tonight. In particular there have been some fixes to restore binary
compatibility to a greater extend.

Benedikt

Benedikt Ritter <[hidden email]> schrieb am Mo., 20. Juni 2016 um
21:36 Uhr:

> Hi,
>
> after some build related problems with RC5, I'd like to call a vote to
> release Apache Commons BCEL 6.0 based on RC6. The only changes compared to
> RC5 is a fix in the source assembly: It now includes all files necessary to
> run a clean build.
>
> BCEL 6.0 RC6 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/bcel (rev 14065)
>
> The tag is here:
>   https://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC6
>  (rev 1749388)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1179/org/apache/bcel/bcel/6.0/
>
> These are the Maven artifacts and their hashes:
>
> bcel-6.0-javadoc.jar
> (SHA1: 89cf95656f0f8a93e77100c8d5811f7cd9af866b)
> bcel-6.0-sources.jar
> (SHA1: 162f96530e8935e8a71a9e6d5497026aa3bdc945)
> bcel-6.0-test-sources.jar
> (SHA1: 2b07be3a0a4560c9766d3261cd012cf636fe965a)
> bcel-6.0-tests.jar
> (SHA1: 9e825da46e0cd66f87ccd907a43c4e2ebd15b8d6)
> bcel-6.0.jar
> (SHA1: 09d0a4c32ba6c3c22f0680f89ceeaf3e677ac659)
> bcel-6.0.pom
> (SHA1: a5d48ac34909f3a0ac788d37835075be5c2bb9d7)
>
> I have tested this with Java 7 and 8 using Maven 3.3.9 on Mac OS 10.11.5.
>
> Details of changes since 5.2 are in the release notes:
>   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/changes-report.html
>
> Site:
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/
> (note some *relative* links are broken and the 6.0 directories are not yet
> created - these will be OK once the site is deployed)
>
> Clirr Report (compared to 5.2):
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/clirr-report.html
>
> Note that Clirr reports several errors. These have been discussed on the
> ML already and I uploaded the site a while ago giving everybody the
> opportunity to raise objections against these changes. These changes are
> also explicitly noted in the Release notes.
>
> Furthermore java.io.Serializable has been dropped from all BCEL classes.
> An extended Clirr report including this change can be reviewed here:
>
> http://home.apache.org/~britter/commons/bcel/6.0-RC6/bcel5-bcel6-clirr-report.html
>
> We don't consider this to be a problem because we don't see a reason for
> users to serialize BCEL classes.
>
> RAT Report:
>     http://home.apache.org/~britter/commons/bcel/6.0-RC6/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now,
> i.e. sometime after 22:00 CEST 23-June 2016
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> We're almost there... :-)
> Thanks!
> Benedikt
>
>
Reply | Threaded
Open this post in threaded view
|

[BCEL] Do we need BCEL-262 for 6.0? (Was: [VOTE] Release Apache Commons BCEL 6.0 based on RC6)

Benedikt Ritter-4
In reply to this post by Mark Roberts
Hi,

as pointed out by Mark Roberts, BCEL-262 is unresolved. Do we need it for
6.0 or can we live with the workaround and fix it for 6.1? It won't take
another 10 years for 6.1, promise! :-)

Benedikt

---------- Forwarded message ---------
From: Mark Roberts <[hidden email]>
Date: Mi., 22. Juni 2016 um 00:37 Uhr
Subject: RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC6
To: Commons Developers List <[hidden email]>


Thanks to sebb's suggestion of using shade I was able to test RC6.

Unfortunately, I am unable to vote as rev 1747124 breaks Daikon.  (We are
required to build with -Werror).  This change is not in the active tree so
that's good.  The problem is that
https://issues.apache.org/jira/browse/BCEL-262 is unresolved.  There is a
suggested workaround for the deprecation, but it is very awkward:
invoke.getClassName(pool) versus
invoke.getReferenceType(pool).getClass().getName()

Thanks,
Mark


> -----Original Message-----
> From: Benedikt Ritter [mailto:[hidden email]]
> Sent: Monday, June 20, 2016 12:37 PM
> To: Commons Developers List
> Cc: [hidden email]; [hidden email]
> Subject: [VOTE] Release Apache Commons BCEL 6.0 based on RC6
>
> Hi,
>
> after some build related problems with RC5, I'd like to call a vote to
release
> Apache Commons BCEL 6.0 based on RC6. The only changes compared to
> RC5 is a fix in the source assembly: It now includes all files necessary
to run a

> clean build.
>
> BCEL 6.0 RC6 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/bcel (rev 14065)
>
> The tag is here:
>
> https://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_R
> C6
>  (rev 1749388)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-
> 1179/org/apache/bcel/bcel/6.0/
>
> These are the Maven artifacts and their hashes:
>
> bcel-6.0-javadoc.jar
> (SHA1: 89cf95656f0f8a93e77100c8d5811f7cd9af866b)
> bcel-6.0-sources.jar
> (SHA1: 162f96530e8935e8a71a9e6d5497026aa3bdc945)
> bcel-6.0-test-sources.jar
> (SHA1: 2b07be3a0a4560c9766d3261cd012cf636fe965a)
> bcel-6.0-tests.jar
> (SHA1: 9e825da46e0cd66f87ccd907a43c4e2ebd15b8d6)
> bcel-6.0.jar
> (SHA1: 09d0a4c32ba6c3c22f0680f89ceeaf3e677ac659)
> bcel-6.0.pom
> (SHA1: a5d48ac34909f3a0ac788d37835075be5c2bb9d7)
>
> I have tested this with Java 7 and 8 using Maven 3.3.9 on Mac OS 10.11.5.
>
> Details of changes since 5.2 are in the release notes:
>   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/changes-
> report.html
>
> Site:
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/
> (note some *relative* links are broken and the 6.0 directories are not yet
> created - these will be OK once the site is deployed)
>
> Clirr Report (compared to 5.2):
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/clirr-report.html
>
> Note that Clirr reports several errors. These have been discussed on the
ML
> already and I uploaded the site a while ago giving everybody the
opportunity
> to raise objections against these changes. These changes are also
explicitly
> noted in the Release notes.
>
> Furthermore java.io.Serializable has been dropped from all BCEL classes.
An

> extended Clirr report including this change can be reviewed here:
>
> http://home.apache.org/~britter/commons/bcel/6.0-RC6/bcel5-bcel6-clirr-
> report.html
>
> We don't consider this to be a problem because we don't see a reason for
> users to serialize BCEL classes.
>
> RAT Report:
>     http://home.apache.org/~britter/commons/bcel/6.0-RC6/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now, i.e. sometime after
> 22:00 CEST 23-June 2016
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> We're almost there... :-)
> Thanks!
> Benedikt


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]
Reply | Threaded
Open this post in threaded view
|

RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC6

Mark Roberts
In reply to this post by Benedikt Ritter-4
First, I must apologize for being a little sloppy in my analysis of the RC.

 As previously noted https://issues.apache.org/jira/browse/BCEL-262 is open and is a problem for Daikon.  However, I just noticed my changes - as applied by r1702349 | sebb | 2015-09-10 16:30:33 -0700 (Thu, 10 Sep 2015) are incomplete.  I have attached a diff file to the issue with the correction to allow arrays as arguments.

I also missed that https://issues.apache.org/jira/browse/BCEL-243 is still open.  This is also a blocker for Daikon.  There is a test case I submitted that looks like it was added, but perhaps not as it should show up as a failure on mvn test.  I do not believe that correction attached to the issue has been accepted.

Hopefully, I have not missed anything else.

Thank you,
Mark
 

> -----Original Message-----
> From: Benedikt Ritter [mailto:[hidden email]]
> Sent: Monday, June 20, 2016 12:37 PM
> To: Commons Developers List
> Cc: [hidden email]; [hidden email]
> Subject: [VOTE] Release Apache Commons BCEL 6.0 based on RC6
>
> Hi,
>
> after some build related problems with RC5, I'd like to call a vote to release
> Apache Commons BCEL 6.0 based on RC6. The only changes compared to
> RC5 is a fix in the source assembly: It now includes all files necessary to run a
> clean build.
>
> BCEL 6.0 RC6 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/bcel (rev 14065)
>
> The tag is here:
>
> https://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_R
> C6
>  (rev 1749388)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-
> 1179/org/apache/bcel/bcel/6.0/
>
> These are the Maven artifacts and their hashes:
>
> bcel-6.0-javadoc.jar
> (SHA1: 89cf95656f0f8a93e77100c8d5811f7cd9af866b)
> bcel-6.0-sources.jar
> (SHA1: 162f96530e8935e8a71a9e6d5497026aa3bdc945)
> bcel-6.0-test-sources.jar
> (SHA1: 2b07be3a0a4560c9766d3261cd012cf636fe965a)
> bcel-6.0-tests.jar
> (SHA1: 9e825da46e0cd66f87ccd907a43c4e2ebd15b8d6)
> bcel-6.0.jar
> (SHA1: 09d0a4c32ba6c3c22f0680f89ceeaf3e677ac659)
> bcel-6.0.pom
> (SHA1: a5d48ac34909f3a0ac788d37835075be5c2bb9d7)
>
> I have tested this with Java 7 and 8 using Maven 3.3.9 on Mac OS 10.11.5.
>
> Details of changes since 5.2 are in the release notes:
>   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/changes-
> report.html
>
> Site:
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/
> (note some *relative* links are broken and the 6.0 directories are not yet
> created - these will be OK once the site is deployed)
>
> Clirr Report (compared to 5.2):
>   http://home.apache.org/~britter/commons/bcel/6.0-RC6/clirr-report.html
>
> Note that Clirr reports several errors. These have been discussed on the ML
> already and I uploaded the site a while ago giving everybody the opportunity
> to raise objections against these changes. These changes are also explicitly
> noted in the Release notes.
>
> Furthermore java.io.Serializable has been dropped from all BCEL classes. An
> extended Clirr report including this change can be reviewed here:
>
> http://home.apache.org/~britter/commons/bcel/6.0-RC6/bcel5-bcel6-clirr-
> report.html
>
> We don't consider this to be a problem because we don't see a reason for
> users to serialize BCEL classes.
>
> RAT Report:
>     http://home.apache.org/~britter/commons/bcel/6.0-RC6/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now, i.e. sometime after
> 22:00 CEST 23-June 2016
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> We're almost there... :-)
> Thanks!
> Benedikt


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]