[VOTE] Release Apache Commons BCEL 6.4.0 based on RC1

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Commons BCEL 6.4.0 based on RC1

Gary Gregory-3
We have fixed quite a few bugs and added some significant enhancements
since Apache Commons BCEL 6.3.1 was released, so I would like to release
Apache Commons BCEL 6.4.0.

Apache Commons BCEL 6.4.0 RC1 is available for review here:
    https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1 (svn
revision 35703)

The Git tag commons-bcel-6.4.0-RC1 commit for this RC is
fa271c5d7ed94dd1d9ef31c52f32d1746d5636dc which you can browse here:

https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=fa271c5d7ed94dd1d9ef31c52f32d1746d5636dc
You may checkout this tag using:
    git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch
commons-bcel-6.4.0-RC1 commons-bcel-6.4.0-RC1

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1464/org/apache/bcel/bcel/6.4.0/

These are the artifacts and their hashes:

#Release SHA-512s
#Sun Sep 08 17:51:35 EDT 2019
bcel-6.4.0-bin.tar.gz=6827729a5c596e173db51d9f602edf8a017778ba4bffb15abb6ebd9250024fec2751d1c97eb7350135bf2bdef039d6d6a5c63c412afc8ce5398c7bf7dd05c2a8
bcel-6.4.0-bin.zip=ff872138be795c42c4e08de511385233a8d754490f9c3eda54f0cc405ab08c83fcccdf0348974840f1f8ff2d54ae08fd09b2cc1bd8a9e0647e550f073c60a00c
bcel-6.4.0-javadoc.jar=3fc4026f833c5198cf7a9dfbcd99d1f565f5f9ea4195068cb1b97ce0b8f095d53c1eb1f9432ea48944519d80749e34ce8221b2f55ddc2bad2f3270604563d31c
bcel-6.4.0-sources.jar=ecae63a05fc1cbf87f648dbe376ce99b59bfffc8d61cdc3fc49773060c9e445ec6b8e0dd79b654b7372efbe295583c00efab593d4bd146dc30c5b91727b4e05f
bcel-6.4.0-src.tar.gz=a3f95c72c2ae7db20042b0a12ec32cf74528ccd4cfc488af4173b8ffb6ddc05a169c47ea17d67af95a965a696417bcd431cba1686f49647a41ce2fdfe1926670
bcel-6.4.0-src.zip=9dc98d3fe9e858ede9930e6eadd2c89fd6b0cb8c430e3f15424fa2bfd10d04bdd70f7b5d75b639d986f302f46fa75e7b8990baa442c87156537d8e2cc84c33c7
bcel-6.4.0-test-sources.jar=ac6e3578d5deba5f27d746d6af55b585fef8d4c43f7a39ea8e46618d71d248c2a44cd00e7beb0d87731373123a0e2a9aacee259d40795a144f8c53d7533de356
bcel-6.4.0-tests.jar=151135c7c8cde667d8c526f12619c624925f77b127d5b754976edf462e6f2abe3fdb057e1295031d58c118a7c95764a2ce09e1ab0f07916c8c23a5d802f621c6

I have tested this with 'mvn -V -Duser.name=%my_apache_id%
-Dcommons.release-plugin.version=%commons.release-plugin.version%
-Ddoclint=none -Prelease -Pjacoco -Ptest-deploy clean package site deploy'
using:

Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117;
2019-08-27T11:06:16-04:00)
Maven home: C:\Java\apache-maven-3.6.2\bin\..
Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_221\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"



Details of changes since 6.3.1 are in the release notes:

https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/RELEASE-NOTES.txt

https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/changes-report.html

Site:

https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/index.html
    (note some *relative* links are broken and the 6.4.0 directories are
not yet created - these will be OK once the site is deployed.)

CLIRR Report (compared to 6.3.1):

https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/clirr-report.html
CLIRR does not know about using Java 8 default methods to provide backward
binary compatibility for new methods, so you can ignore errors here.

JApiCmp Report (compared to 6.3.1):

https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/japicmp.html

RAT Report:

https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/rat-report.html

KEYS:
  https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thank you,

Gary Gregory,
Release Manager (using key 86fdc7e2a11262cb)

For following is intended as a helper and refresher for reviewers.

Validating a release candidate
==============================

These guidelines are NOT complete.

Requirements: Git, Java, Maven.

You can validate a release from a release candidate (RC) tag as follows.

1) Clone and checkout the RC tag

git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch
commons-bcel-6.4.0-RC1 commons-bcel-6.4.0-RC1
cd commons-bcel-6.4.0-RC1

2) Check Apache licenses

This step is not required if the site includes a RAT report page which you
then must check.

mvn apache-rat:check

3) Check binary compatibility

Older components still use Apache Clirr:

This step is not required if the site includes a Clirr report page which
you then must check.

mvn clirr:check

Newer components use JApiCmp with the japicmp Maven Profile:

This step is not required if the site includes a JApiCmp report page which
you then must check.

mvn install -DskipTests -P japicmp japicmp:cmp

4) Build the package

mvn -V clean package

You can record the Maven and Java version produced by -V in your VOTE reply.
To gather OS information from a command line:
Windows: ver
Linux: uname -a

5) Build the site for a single module project

Note: Some plugins require the components to be installed instead of
packaged.

mvn site
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html

6) Build the site for a multi-module project

mvn site
mvn site:stage
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html

-the end-
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons BCEL 6.4.0 based on RC1

Bruno P. Kinoshita-2
 Build passing on jDK 8
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T06:33:14+12:00)
Maven home: /opt/apache-maven-3.5.4
Java version: 1.8.0_222, vendor: Private Build, runtime: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_NZ, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-60-generic", arch: "amd64", family: "unix"
Site reports look OK.

Few notes:

- The changes report simply say 6.4.0 Bug fix release, but I think it should be something else, and leave bug fix for 6.4.1 etc. Probably not a blocker?
- I had a look at a few dist archives (no time to check signatures today). The bcel-6.4.0-src.tar.gz appears to contain a RELEASE-NOTES.txt for 6.4.0-SNAPSHOT? I think this is a blocker for the release?

- The LICENSE.txt included in the dist archives appears to be a file with the Javadoc multiline comment marker around it? Not sure if it causes any issues for any tool that may be using that file. Commons Lang is correctly displayed as AL. Commons Text has a LICENSE.txt that looks fine to me, but is not recognized in GitHub UI. Same for BCEL, though this is probably not that relevant.

I think the RELEASE-NOTES.txt having SNAPSHOT is a blocker, but if not I will change my vote, as the other issues are not really blockers.

  [X] -1 I oppose this release because the above mentioned issue with the RELEASE-NOTES in the dist area.


Thanks!Bruno

    On Monday, 9 September 2019, 10:53:35 am NZST, Gary Gregory <[hidden email]> wrote:  
 
 We have fixed quite a few bugs and added some significant enhancements
since Apache Commons BCEL 6.3.1 was released, so I would like to release
Apache Commons BCEL 6.4.0.

Apache Commons BCEL 6.4.0 RC1 is available for review here:
    https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1 (svn
revision 35703)

The Git tag commons-bcel-6.4.0-RC1 commit for this RC is
fa271c5d7ed94dd1d9ef31c52f32d1746d5636dc which you can browse here:

https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=fa271c5d7ed94dd1d9ef31c52f32d1746d5636dc
You may checkout this tag using:
    git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch
commons-bcel-6.4.0-RC1 commons-bcel-6.4.0-RC1

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1464/org/apache/bcel/bcel/6.4.0/

These are the artifacts and their hashes:

#Release SHA-512s
#Sun Sep 08 17:51:35 EDT 2019
bcel-6.4.0-bin.tar.gz=6827729a5c596e173db51d9f602edf8a017778ba4bffb15abb6ebd9250024fec2751d1c97eb7350135bf2bdef039d6d6a5c63c412afc8ce5398c7bf7dd05c2a8
bcel-6.4.0-bin.zip=ff872138be795c42c4e08de511385233a8d754490f9c3eda54f0cc405ab08c83fcccdf0348974840f1f8ff2d54ae08fd09b2cc1bd8a9e0647e550f073c60a00c
bcel-6.4.0-javadoc.jar=3fc4026f833c5198cf7a9dfbcd99d1f565f5f9ea4195068cb1b97ce0b8f095d53c1eb1f9432ea48944519d80749e34ce8221b2f55ddc2bad2f3270604563d31c
bcel-6.4.0-sources.jar=ecae63a05fc1cbf87f648dbe376ce99b59bfffc8d61cdc3fc49773060c9e445ec6b8e0dd79b654b7372efbe295583c00efab593d4bd146dc30c5b91727b4e05f
bcel-6.4.0-src.tar.gz=a3f95c72c2ae7db20042b0a12ec32cf74528ccd4cfc488af4173b8ffb6ddc05a169c47ea17d67af95a965a696417bcd431cba1686f49647a41ce2fdfe1926670
bcel-6.4.0-src.zip=9dc98d3fe9e858ede9930e6eadd2c89fd6b0cb8c430e3f15424fa2bfd10d04bdd70f7b5d75b639d986f302f46fa75e7b8990baa442c87156537d8e2cc84c33c7
bcel-6.4.0-test-sources.jar=ac6e3578d5deba5f27d746d6af55b585fef8d4c43f7a39ea8e46618d71d248c2a44cd00e7beb0d87731373123a0e2a9aacee259d40795a144f8c53d7533de356
bcel-6.4.0-tests.jar=151135c7c8cde667d8c526f12619c624925f77b127d5b754976edf462e6f2abe3fdb057e1295031d58c118a7c95764a2ce09e1ab0f07916c8c23a5d802f621c6

I have tested this with 'mvn -V -Duser.name=%my_apache_id%
-Dcommons.release-plugin.version=%commons.release-plugin.version%
-Ddoclint=none -Prelease -Pjacoco -Ptest-deploy clean package site deploy'
using:

Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117;
2019-08-27T11:06:16-04:00)
Maven home: C:\Java\apache-maven-3.6.2\bin\..
Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_221\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"



Details of changes since 6.3.1 are in the release notes:

https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/RELEASE-NOTES.txt

https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/changes-report.html

Site:

https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/index.html
    (note some *relative* links are broken and the 6.4.0 directories are
not yet created - these will be OK once the site is deployed.)

CLIRR Report (compared to 6.3.1):

https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/clirr-report.html
CLIRR does not know about using Java 8 default methods to provide backward
binary compatibility for new methods, so you can ignore errors here.

JApiCmp Report (compared to 6.3.1):

https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/japicmp.html

RAT Report:

https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/rat-report.html

KEYS:
  https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thank you,

Gary Gregory,
Release Manager (using key 86fdc7e2a11262cb)

For following is intended as a helper and refresher for reviewers.

Validating a release candidate
==============================

These guidelines are NOT complete.

Requirements: Git, Java, Maven.

You can validate a release from a release candidate (RC) tag as follows.

1) Clone and checkout the RC tag

git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch
commons-bcel-6.4.0-RC1 commons-bcel-6.4.0-RC1
cd commons-bcel-6.4.0-RC1

2) Check Apache licenses

This step is not required if the site includes a RAT report page which you
then must check.

mvn apache-rat:check

3) Check binary compatibility

Older components still use Apache Clirr:

This step is not required if the site includes a Clirr report page which
you then must check.

mvn clirr:check

Newer components use JApiCmp with the japicmp Maven Profile:

This step is not required if the site includes a JApiCmp report page which
you then must check.

mvn install -DskipTests -P japicmp japicmp:cmp

4) Build the package

mvn -V clean package

You can record the Maven and Java version produced by -V in your VOTE reply.
To gather OS information from a command line:
Windows: ver
Linux: uname -a

5) Build the site for a single module project

Note: Some plugins require the components to be installed instead of
packaged.

mvn site
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html

6) Build the site for a multi-module project

mvn site
mvn site:stage
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html

-the end-
 
Reply | Threaded
Open this post in threaded view
|

[CANCEL][VOTE] Release Apache Commons BCEL 6.4.0 based on RC1

garydgregory
I am cancelling this VOTE.
Something got borked. Might as well clean it all up.

Gary

On Mon, Sep 9, 2019 at 2:58 AM Bruno P. Kinoshita <[hidden email]> wrote:

>  Build passing on jDK 8
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-18T06:33:14+12:00)
> Maven home: /opt/apache-maven-3.5.4
> Java version: 1.8.0_222, vendor: Private Build, runtime:
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_NZ, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-60-generic", arch: "amd64", family:
> "unix"
> Site reports look OK.
>
> Few notes:
>
> - The changes report simply say 6.4.0 Bug fix release, but I think it
> should be something else, and leave bug fix for 6.4.1 etc. Probably not a
> blocker?
> - I had a look at a few dist archives (no time to check signatures today).
> The bcel-6.4.0-src.tar.gz appears to contain a RELEASE-NOTES.txt for
> 6.4.0-SNAPSHOT? I think this is a blocker for the release?
>
> - The LICENSE.txt included in the dist archives appears to be a file with
> the Javadoc multiline comment marker around it? Not sure if it causes any
> issues for any tool that may be using that file. Commons Lang is correctly
> displayed as AL. Commons Text has a LICENSE.txt that looks fine to me, but
> is not recognized in GitHub UI. Same for BCEL, though this is probably not
> that relevant.
>
> I think the RELEASE-NOTES.txt having SNAPSHOT is a blocker, but if not I
> will change my vote, as the other issues are not really blockers.
>
>   [X] -1 I oppose this release because the above mentioned issue with the
> RELEASE-NOTES in the dist area.
>
>
> Thanks!Bruno
>
>     On Monday, 9 September 2019, 10:53:35 am NZST, Gary Gregory <
> [hidden email]> wrote:
>
>  We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons BCEL 6.3.1 was released, so I would like to release
> Apache Commons BCEL 6.4.0.
>
> Apache Commons BCEL 6.4.0 RC1 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1 (svn
> revision 35703)
>
> The Git tag commons-bcel-6.4.0-RC1 commit for this RC is
> fa271c5d7ed94dd1d9ef31c52f32d1746d5636dc which you can browse here:
>
>
> https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=fa271c5d7ed94dd1d9ef31c52f32d1746d5636dc
> You may checkout this tag using:
>     git clone https://gitbox.apache.org/repos/asf/commons-bcel.git
> --branch
> commons-bcel-6.4.0-RC1 commons-bcel-6.4.0-RC1
>
> Maven artifacts are here:
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-1464/org/apache/bcel/bcel/6.4.0/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sun Sep 08 17:51:35 EDT 2019
>
> bcel-6.4.0-bin.tar.gz=6827729a5c596e173db51d9f602edf8a017778ba4bffb15abb6ebd9250024fec2751d1c97eb7350135bf2bdef039d6d6a5c63c412afc8ce5398c7bf7dd05c2a8
>
> bcel-6.4.0-bin.zip=ff872138be795c42c4e08de511385233a8d754490f9c3eda54f0cc405ab08c83fcccdf0348974840f1f8ff2d54ae08fd09b2cc1bd8a9e0647e550f073c60a00c
>
> bcel-6.4.0-javadoc.jar=3fc4026f833c5198cf7a9dfbcd99d1f565f5f9ea4195068cb1b97ce0b8f095d53c1eb1f9432ea48944519d80749e34ce8221b2f55ddc2bad2f3270604563d31c
>
> bcel-6.4.0-sources.jar=ecae63a05fc1cbf87f648dbe376ce99b59bfffc8d61cdc3fc49773060c9e445ec6b8e0dd79b654b7372efbe295583c00efab593d4bd146dc30c5b91727b4e05f
>
> bcel-6.4.0-src.tar.gz=a3f95c72c2ae7db20042b0a12ec32cf74528ccd4cfc488af4173b8ffb6ddc05a169c47ea17d67af95a965a696417bcd431cba1686f49647a41ce2fdfe1926670
>
> bcel-6.4.0-src.zip=9dc98d3fe9e858ede9930e6eadd2c89fd6b0cb8c430e3f15424fa2bfd10d04bdd70f7b5d75b639d986f302f46fa75e7b8990baa442c87156537d8e2cc84c33c7
>
> bcel-6.4.0-test-sources.jar=ac6e3578d5deba5f27d746d6af55b585fef8d4c43f7a39ea8e46618d71d248c2a44cd00e7beb0d87731373123a0e2a9aacee259d40795a144f8c53d7533de356
>
> bcel-6.4.0-tests.jar=151135c7c8cde667d8c526f12619c624925f77b127d5b754976edf462e6f2abe3fdb057e1295031d58c118a7c95764a2ce09e1ab0f07916c8c23a5d802f621c6
>
> I have tested this with 'mvn -V -Duser.name=%my_apache_id%
> -Dcommons.release-plugin.version=%commons.release-plugin.version%
> -Ddoclint=none -Prelease -Pjacoco -Ptest-deploy clean package site deploy'
> using:
>
> Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117;
> 2019-08-27T11:06:16-04:00)
> Maven home: C:\Java\apache-maven-3.6.2\bin\..
> Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_221\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
>
>
> Details of changes since 6.3.1 are in the release notes:
>
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/RELEASE-NOTES.txt
>
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/changes-report.html
>
> Site:
>
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/index.html
>     (note some *relative* links are broken and the 6.4.0 directories are
> not yet created - these will be OK once the site is deployed.)
>
> CLIRR Report (compared to 6.3.1):
>
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/clirr-report.html
> CLIRR does not know about using Java 8 default methods to provide backward
> binary compatibility for new methods, so you can ignore errors here.
>
> JApiCmp Report (compared to 6.3.1):
>
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/japicmp.html
>
> RAT Report:
>
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==============================
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch
> commons-bcel-6.4.0-RC1 commons-bcel-6.4.0-RC1
> cd commons-bcel-6.4.0-RC1
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which you
> then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page which
> you then must check.
>
> mvn clirr:check
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page which
> you then must check.
>
> mvn install -DskipTests -P japicmp japicmp:cmp
>
> 4) Build the package
>
> mvn -V clean package
>
> You can record the Maven and Java version produced by -V in your VOTE
> reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a single module project
>
> Note: Some plugins require the components to be installed instead of
> packaged.
>
> mvn site
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> 6) Build the site for a multi-module project
>
> mvn site
> mvn site:stage
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> -the end-
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons BCEL 6.4.0 based on RC1

garydgregory
In reply to this post by Bruno P. Kinoshita-2
Bruno,

Thank you for your review.

I believe I addressed all of your findings in master.

Gary

On Mon, Sep 9, 2019 at 2:58 AM Bruno P. Kinoshita <[hidden email]> wrote:

>  Build passing on jDK 8
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-18T06:33:14+12:00)
> Maven home: /opt/apache-maven-3.5.4
> Java version: 1.8.0_222, vendor: Private Build, runtime:
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_NZ, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-60-generic", arch: "amd64", family:
> "unix"
> Site reports look OK.
>
> Few notes:
>
> - The changes report simply say 6.4.0 Bug fix release, but I think it
> should be something else, and leave bug fix for 6.4.1 etc. Probably not a
> blocker?
> - I had a look at a few dist archives (no time to check signatures today).
> The bcel-6.4.0-src.tar.gz appears to contain a RELEASE-NOTES.txt for
> 6.4.0-SNAPSHOT? I think this is a blocker for the release?
>
> - The LICENSE.txt included in the dist archives appears to be a file with
> the Javadoc multiline comment marker around it? Not sure if it causes any
> issues for any tool that may be using that file. Commons Lang is correctly
> displayed as AL. Commons Text has a LICENSE.txt that looks fine to me, but
> is not recognized in GitHub UI. Same for BCEL, though this is probably not
> that relevant.
>
> I think the RELEASE-NOTES.txt having SNAPSHOT is a blocker, but if not I
> will change my vote, as the other issues are not really blockers.
>
>   [X] -1 I oppose this release because the above mentioned issue with the
> RELEASE-NOTES in the dist area.
>
>
> Thanks!Bruno
>
>     On Monday, 9 September 2019, 10:53:35 am NZST, Gary Gregory <
> [hidden email]> wrote:
>
>  We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons BCEL 6.3.1 was released, so I would like to release
> Apache Commons BCEL 6.4.0.
>
> Apache Commons BCEL 6.4.0 RC1 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1 (svn
> revision 35703)
>
> The Git tag commons-bcel-6.4.0-RC1 commit for this RC is
> fa271c5d7ed94dd1d9ef31c52f32d1746d5636dc which you can browse here:
>
>
> https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=fa271c5d7ed94dd1d9ef31c52f32d1746d5636dc
> You may checkout this tag using:
>     git clone https://gitbox.apache.org/repos/asf/commons-bcel.git
> --branch
> commons-bcel-6.4.0-RC1 commons-bcel-6.4.0-RC1
>
> Maven artifacts are here:
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-1464/org/apache/bcel/bcel/6.4.0/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sun Sep 08 17:51:35 EDT 2019
>
> bcel-6.4.0-bin.tar.gz=6827729a5c596e173db51d9f602edf8a017778ba4bffb15abb6ebd9250024fec2751d1c97eb7350135bf2bdef039d6d6a5c63c412afc8ce5398c7bf7dd05c2a8
>
> bcel-6.4.0-bin.zip=ff872138be795c42c4e08de511385233a8d754490f9c3eda54f0cc405ab08c83fcccdf0348974840f1f8ff2d54ae08fd09b2cc1bd8a9e0647e550f073c60a00c
>
> bcel-6.4.0-javadoc.jar=3fc4026f833c5198cf7a9dfbcd99d1f565f5f9ea4195068cb1b97ce0b8f095d53c1eb1f9432ea48944519d80749e34ce8221b2f55ddc2bad2f3270604563d31c
>
> bcel-6.4.0-sources.jar=ecae63a05fc1cbf87f648dbe376ce99b59bfffc8d61cdc3fc49773060c9e445ec6b8e0dd79b654b7372efbe295583c00efab593d4bd146dc30c5b91727b4e05f
>
> bcel-6.4.0-src.tar.gz=a3f95c72c2ae7db20042b0a12ec32cf74528ccd4cfc488af4173b8ffb6ddc05a169c47ea17d67af95a965a696417bcd431cba1686f49647a41ce2fdfe1926670
>
> bcel-6.4.0-src.zip=9dc98d3fe9e858ede9930e6eadd2c89fd6b0cb8c430e3f15424fa2bfd10d04bdd70f7b5d75b639d986f302f46fa75e7b8990baa442c87156537d8e2cc84c33c7
>
> bcel-6.4.0-test-sources.jar=ac6e3578d5deba5f27d746d6af55b585fef8d4c43f7a39ea8e46618d71d248c2a44cd00e7beb0d87731373123a0e2a9aacee259d40795a144f8c53d7533de356
>
> bcel-6.4.0-tests.jar=151135c7c8cde667d8c526f12619c624925f77b127d5b754976edf462e6f2abe3fdb057e1295031d58c118a7c95764a2ce09e1ab0f07916c8c23a5d802f621c6
>
> I have tested this with 'mvn -V -Duser.name=%my_apache_id%
> -Dcommons.release-plugin.version=%commons.release-plugin.version%
> -Ddoclint=none -Prelease -Pjacoco -Ptest-deploy clean package site deploy'
> using:
>
> Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117;
> 2019-08-27T11:06:16-04:00)
> Maven home: C:\Java\apache-maven-3.6.2\bin\..
> Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_221\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
>
>
> Details of changes since 6.3.1 are in the release notes:
>
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/RELEASE-NOTES.txt
>
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/changes-report.html
>
> Site:
>
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/index.html
>     (note some *relative* links are broken and the 6.4.0 directories are
> not yet created - these will be OK once the site is deployed.)
>
> CLIRR Report (compared to 6.3.1):
>
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/clirr-report.html
> CLIRR does not know about using Java 8 default methods to provide backward
> binary compatibility for new methods, so you can ignore errors here.
>
> JApiCmp Report (compared to 6.3.1):
>
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/japicmp.html
>
> RAT Report:
>
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC1/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==============================
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch
> commons-bcel-6.4.0-RC1 commons-bcel-6.4.0-RC1
> cd commons-bcel-6.4.0-RC1
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which you
> then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page which
> you then must check.
>
> mvn clirr:check
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page which
> you then must check.
>
> mvn install -DskipTests -P japicmp japicmp:cmp
>
> 4) Build the package
>
> mvn -V clean package
>
> You can record the Maven and Java version produced by -V in your VOTE
> reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a single module project
>
> Note: Some plugins require the components to be installed instead of
> packaged.
>
> mvn site
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> 6) Build the site for a multi-module project
>
> mvn site
> mvn site:stage
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> -the end-
>