[VOTE] Release Apache Commons BCEL 6.4.0 based on RC2

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Commons BCEL 6.4.0 based on RC2

Gary Gregory-3
We have fixed quite a few bugs and added some enhancements since Apache
Commons BCEL 6.3.1 was released, so I would like to release Apache Commons
BCEL 6.4.0.

Apache Commons BCEL 6.4.0 RC2 is available for review here:
    https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2 (svn
revision 35956)

The Git tag commons-bcel-6.4.0-RC2 commit for this RC is
bbaf623d750f030d186ed026dc201995145c63ec which you can browse here:

https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=bbaf623d750f030d186ed026dc201995145c63ec
You may checkout this tag using:
    git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch
commons-bcel-6.4.0-RC2 commons-bcel-6.4.0-RC2

Maven artifacts are here:
    https://repository.apache.org/content/repositories/orgapachecommons-1470

These are the artifacts and their hashes:

#Release SHA-512s
#Fri Sep 20 15:18:20 EDT 2019
bcel-6.4.0-bin.tar.gz=adb0907fb538a7c1a6eeb9cffde9769cdc49690e1d74f71b00a1bb59f15fe8ed724199cfb2c53c4416936f38bfb2b1c9b6b82662198449bba3dc66f1ea66bf89
bcel-6.4.0-bin.zip=63e4ab394f517803a823945a9772933ce6e13edcbb4e1453e852b7f769f8dd0289926dc16678e7a2fe3f01f6141fbf1cc2bdd4372127a1ce5292e04347095201
bcel-6.4.0-javadoc.jar=d34cccc064830c51747dacc0ddc321da365e37fe754bb145fb9d00a309e9865c43318d427c0bdc775f125e3686531998666ba247b113a88148b05c634ca9e40a
bcel-6.4.0-sources.jar=f9de34aa59768dcb0b4aaf7c0ffc833302e77e4e01db85816553530d4ba1a6f87778b02bcbc9097fa699069ce85c3d372ec860002dd4c39d9e7093dd31d7771b
bcel-6.4.0-src.tar.gz=998c0b4669739b449d918c2c41d83bdd682375f98ca646fba982d53a4216badb67e4200e945cc4958fe481bcc9a48e1635c7e15a3cb6accd5c27d326289f8b22
bcel-6.4.0-src.zip=7488601f243b1e31644002358ee50889c1dc1dfdc5c19c4c6cda04270cc47ac6b4495e733065bc451b40bcc3bae2130d56314d7bedb3b99fbb5b7b5658c48912
bcel-6.4.0-test-sources.jar=2cfcca5c63986a46952d83df2544e510e6464991a2506d48c2797fdf183df0353fa18c81f25c0e97bf5ddd293a0bab663069e726f727157a9366bf08366f380b
bcel-6.4.0-tests.jar=b2f8f00bd523f36227e2978218ebf8a6d9538288eaa7e9fbabb0609e444f133f2e39fb3d14c4ea7ad3ab09cd61784cea546455ec6b0c88928bff381fffb14fba

I have tested this with

mvn -V -Duser.name=%my_apache_id%
-Dcommons.release-plugin.version=1.7-SNAPSHOT -Ddoclint=none -Prelease
-Ptest-deploy clean package site deploy

using:

Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117;
2019-08-27T11:06:16-04:00)
Maven home: C:\Java\apache-maven-3.6.2\bin\..
Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_221\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Details of changes since 6.3.1 are in the release notes:

https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/RELEASE-NOTES.txt

https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/changes-report.html

Site:

https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/index.html
    (note some *relative* links are broken and the 6.4.0 directories are
not yet created - these will be OK once the site is deployed.)

No CLIRR Report, we use JApiCmp instead:

JApiCmp Report (compared to 6.3.1):

https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/japicmp.html

    Note the addition of default methods to the interface
org.apache.bcel.classfile.Visitor
which provides binary compatibility.

RAT Report:

https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/rat-report.html

KEYS:
  https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thank you,

Gary Gregory,
Release Manager (using key 86fdc7e2a11262cb)

For following is intended as a helper and refresher for reviewers.

Validating a release candidate
==============================

These guidelines are NOT complete.

Requirements: Git, Java, Maven.

You can validate a release from a release candidate (RC) tag as follows.

1) Clone and checkout the RC tag

git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch
commons-bcel-6.4.0-RC2 commons-bcel-6.4.0-RC2
cd commons-bcel-6.4.0-RC2

2) Check Apache licenses

This step is not required if the site includes a RAT report page which you
then must check.

mvn apache-rat:check

3) Check binary compatibility

Older components still use Apache Clirr:

This step is not required if the site includes a Clirr report page which
you then must check.

Newer components use JApiCmp with the japicmp Maven Profile:

This step is not required if the site includes a JApiCmp report page which
you then must check.

mvn install -DskipTests -P japicmp japicmp:cmp

4) Build the package

mvn -V clean package

You can record the Maven and Java version produced by -V in your VOTE reply.
To gather OS information from a command line:
Windows: ver
Linux: uname -a

5) Build the site for a single module project

Note: Some plugins require the components to be installed instead of
packaged.

mvn site
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html

6) Build the site for a multi-module project

mvn site
mvn site:stage
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html

-the end-
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons BCEL 6.4.0 based on RC2

Stian Soiland-Reyes
Gary, thanks for putting together an RC and the thorough description on
how to verify releases! (perhaps some got scared.. we don't need
everyone to test everything though!)

My vote is: +1 (binding)


Checked:

[+] checksums vs *.sha512 vs VOTE email vs maven repo
[+] git tag vs commit
[*] git vs source  (whitespace differences; README.md and CONTRIBUTING.md missing)
[+] .asc pgp signatures
[+] .zip vs .tar.gz
[+] mvn clean install
[+] built target vs binary (all *jar files built, same filenames content)
[+] binary vs maven repo
[+] *.class correct Java class data, version 52.0 (Java 1.8)
[+] source vs -sources.jar
[*] mvn apache-rat:rat  (autogenerated Mini.jj missing ASF header)
[+] LICENSE, NOTICE
[+] RELEASE-NOTES.txt
[+] site
[+] site reports: japicmp (correctly identifies minor version change)
[-] README

README is missing from download, so downstream won't easily know how to
build it with mvn, but I won't block the release over that; just
"mvn" kind of works with the defaultGoal (but needs JAVA_HOME?)

mvn site took quite a long time as it downloads the world (and I am on
hotel WiFi)

Not sure why maven-site-plugin can't invoke javadoc without JAVA_HOME as it's on the PATH

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.8.2:site (default-site) on
project bcel: Error generating maven-javadoc-plugin:3.1.1:javadoc
report: Unable to find javadoc command: The environment variable
JAVA_HOME is not correctly set. -> [Help 1]


(base) stain@biggie:/tmp/RC2/6.4.0-RC2/source/1/bcel-6.4.0-src$ javadoc --version
javadoc 11.0.4


export JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64/
fixes the above


I however get this error from mvn site, which does not block build:

[INFO] Generating "JIRA Report" report   --- maven-changes-plugin:2.12.1:jira-report
[WARNING]
java.lang.NullPointerException
    at org.apache.maven.plugin.jira.RestJiraDownloader.processPriority (RestJiraDownloader.java:392)




Tested with:

(base) stain@biggie:~$ mvn -v
Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T11:41:47-07:00)
Maven home: /home/stain/software/maven
Java version: 11.0.4, vendor: Ubuntu, runtime: /usr/lib/jvm/java-11-openjdk-amd64
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-64-generic", arch: "amd64", family: "unix"

(base) stain@biggie:~$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 18.04.3 LTS
Release: 18.04
Codename: bionic


On Fri, 20 Sep 2019 15:44:54 -0400, Gary Gregory <[hidden email]> wrote:

> We have fixed quite a few bugs and added some enhancements since Apache
> Commons BCEL 6.3.1 was released, so I would like to release Apache Commons
> BCEL 6.4.0.
>
> Apache Commons BCEL 6.4.0 RC2 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2 (svn
> revision 35956)
>
> The Git tag commons-bcel-6.4.0-RC2 commit for this RC is
> bbaf623d750f030d186ed026dc201995145c63ec which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=bbaf623d750f030d186ed026dc201995145c63ec
> You may checkout this tag using:
>     git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch
> commons-bcel-6.4.0-RC2 commons-bcel-6.4.0-RC2
>
> Maven artifacts are here:
>     https://repository.apache.org/content/repositories/orgapachecommons-1470
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Fri Sep 20 15:18:20 EDT 2019
> bcel-6.4.0-bin.tar.gz=adb0907fb538a7c1a6eeb9cffde9769cdc49690e1d74f71b00a1bb59f15fe8ed724199cfb2c53c4416936f38bfb2b1c9b6b82662198449bba3dc66f1ea66bf89
> bcel-6.4.0-bin.zip=63e4ab394f517803a823945a9772933ce6e13edcbb4e1453e852b7f769f8dd0289926dc16678e7a2fe3f01f6141fbf1cc2bdd4372127a1ce5292e04347095201
> bcel-6.4.0-javadoc.jar=d34cccc064830c51747dacc0ddc321da365e37fe754bb145fb9d00a309e9865c43318d427c0bdc775f125e3686531998666ba247b113a88148b05c634ca9e40a
> bcel-6.4.0-sources.jar=f9de34aa59768dcb0b4aaf7c0ffc833302e77e4e01db85816553530d4ba1a6f87778b02bcbc9097fa699069ce85c3d372ec860002dd4c39d9e7093dd31d7771b
> bcel-6.4.0-src.tar.gz=998c0b4669739b449d918c2c41d83bdd682375f98ca646fba982d53a4216badb67e4200e945cc4958fe481bcc9a48e1635c7e15a3cb6accd5c27d326289f8b22
> bcel-6.4.0-src.zip=7488601f243b1e31644002358ee50889c1dc1dfdc5c19c4c6cda04270cc47ac6b4495e733065bc451b40bcc3bae2130d56314d7bedb3b99fbb5b7b5658c48912
> bcel-6.4.0-test-sources.jar=2cfcca5c63986a46952d83df2544e510e6464991a2506d48c2797fdf183df0353fa18c81f25c0e97bf5ddd293a0bab663069e726f727157a9366bf08366f380b
> bcel-6.4.0-tests.jar=b2f8f00bd523f36227e2978218ebf8a6d9538288eaa7e9fbabb0609e444f133f2e39fb3d14c4ea7ad3ab09cd61784cea546455ec6b0c88928bff381fffb14fba
>
> I have tested this with
>
> mvn -V -Duser.name=%my_apache_id%
> -Dcommons.release-plugin.version=1.7-SNAPSHOT -Ddoclint=none -Prelease
> -Ptest-deploy clean package site deploy
>
> using:
>
> Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117;
> 2019-08-27T11:06:16-04:00)
> Maven home: C:\Java\apache-maven-3.6.2\bin\..
> Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_221\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Details of changes since 6.3.1 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/index.html
>     (note some *relative* links are broken and the 6.4.0 directories are
> not yet created - these will be OK once the site is deployed.)
>
> No CLIRR Report, we use JApiCmp instead:
>
> JApiCmp Report (compared to 6.3.1):
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/japicmp.html
>
>     Note the addition of default methods to the interface
> org.apache.bcel.classfile.Visitor
> which provides binary compatibility.
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==============================
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch
> commons-bcel-6.4.0-RC2 commons-bcel-6.4.0-RC2
> cd commons-bcel-6.4.0-RC2
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which you
> then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page which
> you then must check.
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page which
> you then must check.
>
> mvn install -DskipTests -P japicmp japicmp:cmp
>
> 4) Build the package
>
> mvn -V clean package
>
> You can record the Maven and Java version produced by -V in your VOTE reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a single module project
>
> Note: Some plugins require the components to be installed instead of
> packaged.
>
> mvn site
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> 6) Build the site for a multi-module project
>
> mvn site
> mvn site:stage
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> -the end-

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons BCEL 6.4.0 based on RC2

Rob Tompkins
In reply to this post by Gary Gregory-3
+1 (binding)

Built to site with java8 built and tested with java11 (javadoc fails here)

Signatures look good, Site looks good (with a few reports nits: CPD, PMD, Findbugs — small levels of errors; low code coverage 43%)

Many cheers for Gary’s work.

-Rob

> On Sep 20, 2019, at 3:44 PM, Gary Gregory <[hidden email]> wrote:
>
> We have fixed quite a few bugs and added some enhancements since Apache
> Commons BCEL 6.3.1 was released, so I would like to release Apache Commons
> BCEL 6.4.0.
>
> Apache Commons BCEL 6.4.0 RC2 is available for review here:
>    https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2 (svn
> revision 35956)
>
> The Git tag commons-bcel-6.4.0-RC2 commit for this RC is
> bbaf623d750f030d186ed026dc201995145c63ec which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=bbaf623d750f030d186ed026dc201995145c63ec
> You may checkout this tag using:
>    git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch
> commons-bcel-6.4.0-RC2 commons-bcel-6.4.0-RC2
>
> Maven artifacts are here:
>    https://repository.apache.org/content/repositories/orgapachecommons-1470
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Fri Sep 20 15:18:20 EDT 2019
> bcel-6.4.0-bin.tar.gz=adb0907fb538a7c1a6eeb9cffde9769cdc49690e1d74f71b00a1bb59f15fe8ed724199cfb2c53c4416936f38bfb2b1c9b6b82662198449bba3dc66f1ea66bf89
> bcel-6.4.0-bin.zip=63e4ab394f517803a823945a9772933ce6e13edcbb4e1453e852b7f769f8dd0289926dc16678e7a2fe3f01f6141fbf1cc2bdd4372127a1ce5292e04347095201
> bcel-6.4.0-javadoc.jar=d34cccc064830c51747dacc0ddc321da365e37fe754bb145fb9d00a309e9865c43318d427c0bdc775f125e3686531998666ba247b113a88148b05c634ca9e40a
> bcel-6.4.0-sources.jar=f9de34aa59768dcb0b4aaf7c0ffc833302e77e4e01db85816553530d4ba1a6f87778b02bcbc9097fa699069ce85c3d372ec860002dd4c39d9e7093dd31d7771b
> bcel-6.4.0-src.tar.gz=998c0b4669739b449d918c2c41d83bdd682375f98ca646fba982d53a4216badb67e4200e945cc4958fe481bcc9a48e1635c7e15a3cb6accd5c27d326289f8b22
> bcel-6.4.0-src.zip=7488601f243b1e31644002358ee50889c1dc1dfdc5c19c4c6cda04270cc47ac6b4495e733065bc451b40bcc3bae2130d56314d7bedb3b99fbb5b7b5658c48912
> bcel-6.4.0-test-sources.jar=2cfcca5c63986a46952d83df2544e510e6464991a2506d48c2797fdf183df0353fa18c81f25c0e97bf5ddd293a0bab663069e726f727157a9366bf08366f380b
> bcel-6.4.0-tests.jar=b2f8f00bd523f36227e2978218ebf8a6d9538288eaa7e9fbabb0609e444f133f2e39fb3d14c4ea7ad3ab09cd61784cea546455ec6b0c88928bff381fffb14fba
>
> I have tested this with
>
> mvn -V -Duser.name=%my_apache_id%
> -Dcommons.release-plugin.version=1.7-SNAPSHOT -Ddoclint=none -Prelease
> -Ptest-deploy clean package site deploy
>
> using:
>
> Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117;
> 2019-08-27T11:06:16-04:00)
> Maven home: C:\Java\apache-maven-3.6.2\bin\..
> Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_221\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Details of changes since 6.3.1 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/index.html
>    (note some *relative* links are broken and the 6.4.0 directories are
> not yet created - these will be OK once the site is deployed.)
>
> No CLIRR Report, we use JApiCmp instead:
>
> JApiCmp Report (compared to 6.3.1):
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/japicmp.html
>
>    Note the addition of default methods to the interface
> org.apache.bcel.classfile.Visitor
> which provides binary compatibility.
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/rat-report.html
>
> KEYS:
>  https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>  [ ] +1 Release these artifacts
>  [ ] +0 OK, but...
>  [ ] -0 OK, but really should fix...
>  [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==============================
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch
> commons-bcel-6.4.0-RC2 commons-bcel-6.4.0-RC2
> cd commons-bcel-6.4.0-RC2
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which you
> then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page which
> you then must check.
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page which
> you then must check.
>
> mvn install -DskipTests -P japicmp japicmp:cmp
>
> 4) Build the package
>
> mvn -V clean package
>
> You can record the Maven and Java version produced by -V in your VOTE reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a single module project
>
> Note: Some plugins require the components to be installed instead of
> packaged.
>
> mvn site
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> 6) Build the site for a multi-module project
>
> mvn site
> mvn site:stage
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> -the end-


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons BCEL 6.4.0 based on RC2

Gary Gregory-3
In reply to this post by Gary Gregory-3
And my +1.

Gary

On Fri, Sep 20, 2019, 15:44 Gary Gregory <[hidden email]> wrote:

> We have fixed quite a few bugs and added some enhancements since Apache
> Commons BCEL 6.3.1 was released, so I would like to release Apache Commons
> BCEL 6.4.0.
>
> Apache Commons BCEL 6.4.0 RC2 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2 (svn
> revision 35956)
>
> The Git tag commons-bcel-6.4.0-RC2 commit for this RC is
> bbaf623d750f030d186ed026dc201995145c63ec which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=bbaf623d750f030d186ed026dc201995145c63ec
> You may checkout this tag using:
>     git clone https://gitbox.apache.org/repos/asf/commons-bcel.git
> --branch commons-bcel-6.4.0-RC2 commons-bcel-6.4.0-RC2
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1470
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Fri Sep 20 15:18:20 EDT 2019
>
> bcel-6.4.0-bin.tar.gz=adb0907fb538a7c1a6eeb9cffde9769cdc49690e1d74f71b00a1bb59f15fe8ed724199cfb2c53c4416936f38bfb2b1c9b6b82662198449bba3dc66f1ea66bf89
>
> bcel-6.4.0-bin.zip=63e4ab394f517803a823945a9772933ce6e13edcbb4e1453e852b7f769f8dd0289926dc16678e7a2fe3f01f6141fbf1cc2bdd4372127a1ce5292e04347095201
>
> bcel-6.4.0-javadoc.jar=d34cccc064830c51747dacc0ddc321da365e37fe754bb145fb9d00a309e9865c43318d427c0bdc775f125e3686531998666ba247b113a88148b05c634ca9e40a
>
> bcel-6.4.0-sources.jar=f9de34aa59768dcb0b4aaf7c0ffc833302e77e4e01db85816553530d4ba1a6f87778b02bcbc9097fa699069ce85c3d372ec860002dd4c39d9e7093dd31d7771b
>
> bcel-6.4.0-src.tar.gz=998c0b4669739b449d918c2c41d83bdd682375f98ca646fba982d53a4216badb67e4200e945cc4958fe481bcc9a48e1635c7e15a3cb6accd5c27d326289f8b22
>
> bcel-6.4.0-src.zip=7488601f243b1e31644002358ee50889c1dc1dfdc5c19c4c6cda04270cc47ac6b4495e733065bc451b40bcc3bae2130d56314d7bedb3b99fbb5b7b5658c48912
>
> bcel-6.4.0-test-sources.jar=2cfcca5c63986a46952d83df2544e510e6464991a2506d48c2797fdf183df0353fa18c81f25c0e97bf5ddd293a0bab663069e726f727157a9366bf08366f380b
>
> bcel-6.4.0-tests.jar=b2f8f00bd523f36227e2978218ebf8a6d9538288eaa7e9fbabb0609e444f133f2e39fb3d14c4ea7ad3ab09cd61784cea546455ec6b0c88928bff381fffb14fba
>
> I have tested this with
>
> mvn -V -Duser.name=%my_apache_id%
> -Dcommons.release-plugin.version=1.7-SNAPSHOT -Ddoclint=none -Prelease
> -Ptest-deploy clean package site deploy
>
> using:
>
> Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117;
> 2019-08-27T11:06:16-04:00)
> Maven home: C:\Java\apache-maven-3.6.2\bin\..
> Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_221\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Details of changes since 6.3.1 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/index.html
>     (note some *relative* links are broken and the 6.4.0 directories are
> not yet created - these will be OK once the site is deployed.)
>
> No CLIRR Report, we use JApiCmp instead:
>
> JApiCmp Report (compared to 6.3.1):
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/japicmp.html
>
>     Note the addition of default methods to the interface
> org.apache.bcel.classfile.Visitor
> which provides binary compatibility.
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==============================
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch
> commons-bcel-6.4.0-RC2 commons-bcel-6.4.0-RC2
> cd commons-bcel-6.4.0-RC2
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which you
> then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page which
> you then must check.
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page which
> you then must check.
>
> mvn install -DskipTests -P japicmp japicmp:cmp
>
> 4) Build the package
>
> mvn -V clean package
>
> You can record the Maven and Java version produced by -V in your VOTE
> reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a single module project
>
> Note: Some plugins require the components to be installed instead of
> packaged.
>
> mvn site
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> 6) Build the site for a multi-module project
>
> mvn site
> mvn site:stage
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> -the end-
>
Reply | Threaded
Open this post in threaded view
|

[VOTE][RESULT] Release Apache Commons BCEL 6.4.0 based on RC2

garydgregory
In reply to this post by Gary Gregory-3
This vote passes with the following binding votes:

- Stian Soiland-Reyes
- Rob Tompkins
- Gary Gregory

Gary


On Fri, Sep 20, 2019 at 3:44 PM Gary Gregory <[hidden email]> wrote:

> We have fixed quite a few bugs and added some enhancements since Apache
> Commons BCEL 6.3.1 was released, so I would like to release Apache Commons
> BCEL 6.4.0.
>
> Apache Commons BCEL 6.4.0 RC2 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2 (svn
> revision 35956)
>
> The Git tag commons-bcel-6.4.0-RC2 commit for this RC is
> bbaf623d750f030d186ed026dc201995145c63ec which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=bbaf623d750f030d186ed026dc201995145c63ec
> You may checkout this tag using:
>     git clone https://gitbox.apache.org/repos/asf/commons-bcel.git
> --branch commons-bcel-6.4.0-RC2 commons-bcel-6.4.0-RC2
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1470
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Fri Sep 20 15:18:20 EDT 2019
>
> bcel-6.4.0-bin.tar.gz=adb0907fb538a7c1a6eeb9cffde9769cdc49690e1d74f71b00a1bb59f15fe8ed724199cfb2c53c4416936f38bfb2b1c9b6b82662198449bba3dc66f1ea66bf89
>
> bcel-6.4.0-bin.zip=63e4ab394f517803a823945a9772933ce6e13edcbb4e1453e852b7f769f8dd0289926dc16678e7a2fe3f01f6141fbf1cc2bdd4372127a1ce5292e04347095201
>
> bcel-6.4.0-javadoc.jar=d34cccc064830c51747dacc0ddc321da365e37fe754bb145fb9d00a309e9865c43318d427c0bdc775f125e3686531998666ba247b113a88148b05c634ca9e40a
>
> bcel-6.4.0-sources.jar=f9de34aa59768dcb0b4aaf7c0ffc833302e77e4e01db85816553530d4ba1a6f87778b02bcbc9097fa699069ce85c3d372ec860002dd4c39d9e7093dd31d7771b
>
> bcel-6.4.0-src.tar.gz=998c0b4669739b449d918c2c41d83bdd682375f98ca646fba982d53a4216badb67e4200e945cc4958fe481bcc9a48e1635c7e15a3cb6accd5c27d326289f8b22
>
> bcel-6.4.0-src.zip=7488601f243b1e31644002358ee50889c1dc1dfdc5c19c4c6cda04270cc47ac6b4495e733065bc451b40bcc3bae2130d56314d7bedb3b99fbb5b7b5658c48912
>
> bcel-6.4.0-test-sources.jar=2cfcca5c63986a46952d83df2544e510e6464991a2506d48c2797fdf183df0353fa18c81f25c0e97bf5ddd293a0bab663069e726f727157a9366bf08366f380b
>
> bcel-6.4.0-tests.jar=b2f8f00bd523f36227e2978218ebf8a6d9538288eaa7e9fbabb0609e444f133f2e39fb3d14c4ea7ad3ab09cd61784cea546455ec6b0c88928bff381fffb14fba
>
> I have tested this with
>
> mvn -V -Duser.name=%my_apache_id%
> -Dcommons.release-plugin.version=1.7-SNAPSHOT -Ddoclint=none -Prelease
> -Ptest-deploy clean package site deploy
>
> using:
>
> Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117;
> 2019-08-27T11:06:16-04:00)
> Maven home: C:\Java\apache-maven-3.6.2\bin\..
> Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_221\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Details of changes since 6.3.1 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/index.html
>     (note some *relative* links are broken and the 6.4.0 directories are
> not yet created - these will be OK once the site is deployed.)
>
> No CLIRR Report, we use JApiCmp instead:
>
> JApiCmp Report (compared to 6.3.1):
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/japicmp.html
>
>     Note the addition of default methods to the interface
> org.apache.bcel.classfile.Visitor
> which provides binary compatibility.
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==============================
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch
> commons-bcel-6.4.0-RC2 commons-bcel-6.4.0-RC2
> cd commons-bcel-6.4.0-RC2
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which you
> then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page which
> you then must check.
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page which
> you then must check.
>
> mvn install -DskipTests -P japicmp japicmp:cmp
>
> 4) Build the package
>
> mvn -V clean package
>
> You can record the Maven and Java version produced by -V in your VOTE
> reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a single module project
>
> Note: Some plugins require the components to be installed instead of
> packaged.
>
> mvn site
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> 6) Build the site for a multi-module project
>
> mvn site
> mvn site:stage
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> -the end-
>