[VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Phil Steitz
Quite a few bugs have been fixed since DBCP 2.0.1 and a few new
features have been added.  It is time for a 2.1 release.

The release is available for review here:
https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031)

The release was built from this tag:
http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_1_RC1
(r1660242)

Release notes:
https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt

Maven artifacts:
https://repository.apache.org/content/repositories/orgapachecommons-1082

Site:
http://people.apache.org/~psteitz/dbcp/dbcp-2.1-RC1-site/

KEYS:
http://www.apache.org/dist/commons/KEYS

Votes, please.

This vote will close no sooner than 72 hours from now.

[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...

Thanks!

Phil


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

sebb-2-2
For completeness, here are the main Nexus hashes:

/org/apache/commons/commons-dbcp2/2.1/commons-dbcp2-2.1-tests.jar
(SHA1: f4463d624c494746aa01f009f0886012f9601710)
/org/apache/commons/commons-dbcp2/2.1/commons-dbcp2-2.1-sources.jar
(SHA1: 305da0aa5f560ab4c8e3bee855582829c51fb744)
/org/apache/commons/commons-dbcp2/2.1/commons-dbcp2-2.1.jar
(SHA1: e7d02ff005e872cefb7d8d797d7605d6bced0cbc)
/org/apache/commons/commons-dbcp2/2.1/commons-dbcp2-2.1-test-sources.jar
(SHA1: 39ea09152085a80a2a3894534a67a89ebec2da25)
/org/apache/commons/commons-dbcp2/2.1/commons-dbcp2-2.1.pom
(SHA1: 1bc7959577f0c1dc01480998f60494d46e403481)


On 17 February 2015 at 04:04, Phil Steitz <[hidden email]> wrote:

> Quite a few bugs have been fixed since DBCP 2.0.1 and a few new
> features have been added.  It is time for a 2.1 release.
>
> The release is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031)
>
> The release was built from this tag:
> http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_1_RC1
> (r1660242)
>
> Release notes:
> https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt
>
> Maven artifacts:
> https://repository.apache.org/content/repositories/orgapachecommons-1082
>
> Site:
> http://people.apache.org/~psteitz/dbcp/dbcp-2.1-RC1-site/
>
> KEYS:
> http://www.apache.org/dist/commons/KEYS
>
> Votes, please.
>
> This vote will close no sooner than 72 hours from now.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Bruno P. Kinoshita
In reply to this post by Phil Steitz
Hi Phil,
Builds fine with

Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T15:37:52-03:00)Maven home: /opt/apache-maven-3.2.1Java version: 1.7.0_65, vendor: Oracle CorporationJava home: /opt/jdk1.7.0_65/jreDefault locale: en_US, platform encoding: UTF-8OS name: "linux", version: "3.16.0-30-generic", arch: "amd64", family: "unix"
All tests passed. Comparing with http://commons.apache.org/proper/commons-dbcp/findbugs.html, looks like there is a new FindBugs bug:
> org.apache.commons.dbcp2.DelegatingConnection.prepareStatement(String) may return null, but is declared @NonNull

I had a look at the JDK source code at [1] and [2] but couldn't find a @NotNull annotation anywhere. Do you think it would be an issue?
BTW, I couldn't build the project with JDK8
kinow@chuva:~/Desktop/dbcp/source/commons-dbcp2-2.1-src$ mvn clean site -e -XApache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T15:37:52-03:00)Maven home: /opt/apache-maven-3.2.1Java version: 1.8.0_05, vendor: Oracle CorporationJava home: /opt/jdk1.8.0_05/jreDefault locale: en_US, platform encoding: UTF-8OS name: "linux", version: "3.16.0-30-generic", arch: "i386", family: "unix"
I think it fails during the JaCoCo report generation https://gist.github.com/kinow/98851033c3c006154b92, but I haven't investigated the issue and I believe it's not a blocker. +1 not binding
Bruno
[1] http://hg.openjdk.java.net/jdk6/jdk6/jdk/file/c228a234a3f3/src/share/classes/java/sql/Connection.java[2] http://hg.openjdk.java.net/jdk7/jdk7/jdk/file/9b8c96f96a0f/src/share/classes/java/sql/Connection.java
 
      From: Phil Steitz <[hidden email]>
 To: Commons Developers List <[hidden email]>
 Sent: Tuesday, February 17, 2015 2:04 AM
 Subject: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1
   
Quite a few bugs have been fixed since DBCP 2.0.1 and a few new
features have been added.  It is time for a 2.1 release.

The release is available for review here:
https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031)

The release was built from this tag:
http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_1_RC1
(r1660242)

Release notes:
https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt

Maven artifacts:
https://repository.apache.org/content/repositories/orgapachecommons-1082

Site:
http://people.apache.org/~psteitz/dbcp/dbcp-2.1-RC1-site/

KEYS:
http://www.apache.org/dist/commons/KEYS

Votes, please.

This vote will close no sooner than 72 hours from now.

[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...

Thanks!

Phil


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]


   
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Phil Steitz
On 2/17/15 7:38 AM, Bruno P. Kinoshita wrote:
> Hi Phil,
> Builds fine with
>
> Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T15:37:52-03:00)Maven home: /opt/apache-maven-3.2.1Java version: 1.7.0_65, vendor: Oracle CorporationJava home: /opt/jdk1.7.0_65/jreDefault locale: en_US, platform encoding: UTF-8OS name: "linux", version: "3.16.0-30-generic", arch: "amd64", family: "unix"
> All tests passed. Comparing with http://commons.apache.org/proper/commons-dbcp/findbugs.html, looks like there is a new FindBugs bug:
>> org.apache.commons.dbcp2.DelegatingConnection.prepareStatement(String) may return null, but is declared @NonNull

I think this is a false (or at least questionable) positive, due to
new findbugs version.  In any case, not a blocker.
> I had a look at the JDK source code at [1] and [2] but couldn't find a @NotNull annotation anywhere. Do you think it would be an issue?
> BTW, I couldn't build the project with JDK8
> kinow@chuva:~/Desktop/dbcp/source/commons-dbcp2-2.1-src$ mvn clean site -e -XApache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T15:37:52-03:00)Maven home: /opt/apache-maven-3.2.1Java version: 1.8.0_05, vendor: Oracle CorporationJava home: /opt/jdk1.8.0_05/jreDefault locale: en_US, platform encoding: UTF-8OS name: "linux", version: "3.16.0-30-generic", arch: "i386", family: "unix"
> I think it fails during the JaCoCo report generation https://gist.github.com/kinow/98851033c3c006154b92, but I haven't investigated the issue and I believe it's not a blocker. +1 not binding
> Bruno
> [1] http://hg.openjdk.java.net/jdk6/jdk6/jdk/file/c228a234a3f3/src/share/classes/java/sql/Connection.java[2] http://hg.openjdk.java.net/jdk7/jdk7/jdk/file/9b8c96f96a0f/src/share/classes/java/sql/Connection.java

That is just the site build, which is not essential to the release,
IMO, so again not a blocker.

Thanks for reviewing!

Phil

>  
>       From: Phil Steitz <[hidden email]>
>  To: Commons Developers List <[hidden email]>
>  Sent: Tuesday, February 17, 2015 2:04 AM
>  Subject: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1
>    
> Quite a few bugs have been fixed since DBCP 2.0.1 and a few new
> features have been added.  It is time for a 2.1 release.
>
> The release is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031)
>
> The release was built from this tag:
> http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_1_RC1
> (r1660242)
>
> Release notes:
> https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt
>
> Maven artifacts:
> https://repository.apache.org/content/repositories/orgapachecommons-1082
>
> Site:
> http://people.apache.org/~psteitz/dbcp/dbcp-2.1-RC1-site/
>
> KEYS:
> http://www.apache.org/dist/commons/KEYS
>
> Votes, please.
>
> This vote will close no sooner than 72 hours from now.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
>    
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Phil Steitz
In reply to this post by Phil Steitz
Here is my +1

Phil

On 2/16/15 9:04 PM, Phil Steitz wrote:

> Quite a few bugs have been fixed since DBCP 2.0.1 and a few new
> features have been added.  It is time for a 2.1 release.
>
> The release is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031)
>
> The release was built from this tag:
> http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_1_RC1
> (r1660242)
>
> Release notes:
> https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt
>
> Maven artifacts:
> https://repository.apache.org/content/repositories/orgapachecommons-1082
>
> Site:
> http://people.apache.org/~psteitz/dbcp/dbcp-2.1-RC1-site/
>
> KEYS:
> http://www.apache.org/dist/commons/KEYS
>
> Votes, please.
>
> This vote will close no sooner than 72 hours from now.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Oliver Heger-3
In reply to this post by Phil Steitz
Build (both Maven and ant) was successful on Windows 8.1 with JDK 1.7.
Artifacts and site look good.

So here is my +1.

Minor nit: On the site there is currently no entry for the Javadocs of
the new release. I guess it will be added after the release?

Oliver

My exact configuration:
$ mvn -version
Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9;
2014-02-14T18:37:5
2+01:00)
Maven home: c:\data\dev\tools\apache-maven-3.2.1
Java version: 1.7.0_67, vendor: Oracle Corporation
Java home: c:\Program Files\Java\jdk1.7.0_67\jre
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows"

Am 17.02.2015 um 05:04 schrieb Phil Steitz:

> Quite a few bugs have been fixed since DBCP 2.0.1 and a few new
> features have been added.  It is time for a 2.1 release.
>
> The release is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031)
>
> The release was built from this tag:
> http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_1_RC1
> (r1660242)
>
> Release notes:
> https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt
>
> Maven artifacts:
> https://repository.apache.org/content/repositories/orgapachecommons-1082
>
> Site:
> http://people.apache.org/~psteitz/dbcp/dbcp-2.1-RC1-site/
>
> KEYS:
> http://www.apache.org/dist/commons/KEYS
>
> Votes, please.
>
> This vote will close no sooner than 72 hours from now.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Phil Steitz
On 2/17/15 1:59 PM, Oliver Heger wrote:
> Build (both Maven and ant) was successful on Windows 8.1 with JDK 1.7.
> Artifacts and site look good.
>
> So here is my +1.
>
> Minor nit: On the site there is currently no entry for the Javadocs of
> the new release. I guess it will be added after the release?

Right.  Post-release site update will include that.

Thanks for review!

Phil

>
> Oliver
>
> My exact configuration:
> $ mvn -version
> Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9;
> 2014-02-14T18:37:5
> 2+01:00)
> Maven home: c:\data\dev\tools\apache-maven-3.2.1
> Java version: 1.7.0_67, vendor: Oracle Corporation
> Java home: c:\Program Files\Java\jdk1.7.0_67\jre
> Default locale: de_DE, platform encoding: Cp1252
> OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows"
>
> Am 17.02.2015 um 05:04 schrieb Phil Steitz:
>> Quite a few bugs have been fixed since DBCP 2.0.1 and a few new
>> features have been added.  It is time for a 2.1 release.
>>
>> The release is available for review here:
>> https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031)
>>
>> The release was built from this tag:
>> http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_1_RC1
>> (r1660242)
>>
>> Release notes:
>> https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt
>>
>> Maven artifacts:
>> https://repository.apache.org/content/repositories/orgapachecommons-1082
>>
>> Site:
>> http://people.apache.org/~psteitz/dbcp/dbcp-2.1-RC1-site/
>>
>> KEYS:
>> http://www.apache.org/dist/commons/KEYS
>>
>> Votes, please.
>>
>> This vote will close no sooner than 72 hours from now.
>>
>> [ ] +1 Release these artifacts
>> [ ] +0 OK, but...
>> [ ] -0 OK, but really should fix...
>> [ ] -1 I oppose this release because...
>>
>> Thanks!
>>
>> Phil
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Thomas Neidhart
In reply to this post by Phil Steitz
On 02/17/2015 05:04 AM, Phil Steitz wrote:

> Quite a few bugs have been fixed since DBCP 2.0.1 and a few new
> features have been added.  It is time for a 2.1 release.
>
> The release is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031)
>
> The release was built from this tag:
> http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_1_RC1
> (r1660242)
>
> Release notes:
> https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt
>
> Maven artifacts:
> https://repository.apache.org/content/repositories/orgapachecommons-1082
>
> Site:
> http://people.apache.org/~psteitz/dbcp/dbcp-2.1-RC1-site/
>
> KEYS:
> http://www.apache.org/dist/commons/KEYS
>
> Votes, please.
>
> This vote will close no sooner than 72 hours from now.

[x] +1 Release these artifacts

Tested successfully within the following environment:

$ mvn -version
Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
17:22:22+0200)
Maven home: /home/tn/bin/apache-maven-3.1.1
Java version: 1.7.0_75, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-7-openjdk-i386/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.13.0-37-generic", arch: "i386", family: "unix"

One small nit that I found:

while trying to run the examples with the jar I noticed that at least
two of the examples still contain instructions for dbcp 1.x.

I would also update the examples to use a small self-contained,
in-memory database like hsqldb which makes it easier to quickly test it
(I can also update the example code post-release myself).

Thomas

> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Phil Steitz
On 2/17/15 2:29 PM, Thomas Neidhart wrote:

> On 02/17/2015 05:04 AM, Phil Steitz wrote:
>> Quite a few bugs have been fixed since DBCP 2.0.1 and a few new
>> features have been added.  It is time for a 2.1 release.
>>
>> The release is available for review here:
>> https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031)
>>
>> The release was built from this tag:
>> http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_1_RC1
>> (r1660242)
>>
>> Release notes:
>> https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt
>>
>> Maven artifacts:
>> https://repository.apache.org/content/repositories/orgapachecommons-1082
>>
>> Site:
>> http://people.apache.org/~psteitz/dbcp/dbcp-2.1-RC1-site/
>>
>> KEYS:
>> http://www.apache.org/dist/commons/KEYS
>>
>> Votes, please.
>>
>> This vote will close no sooner than 72 hours from now.
> [x] +1 Release these artifacts
>
> Tested successfully within the following environment:
>
> $ mvn -version
> Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
> 17:22:22+0200)
> Maven home: /home/tn/bin/apache-maven-3.1.1
> Java version: 1.7.0_75, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-7-openjdk-i386/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.13.0-37-generic", arch: "i386", family: "unix"
>
> One small nit that I found:
>
> while trying to run the examples with the jar I noticed that at least
> two of the examples still contain instructions for dbcp 1.x.

Drat.  I thought I had fixed them all...
>
> I would also update the examples to use a small self-contained,
> in-memory database like hsqldb which makes it easier to quickly test it
> (I can also update the example code post-release myself).

By all means, have at it!  The examples on the web site are just
sourced directly from svn, so fixes become immediately available.

Thanks!

Phil

>
> Thomas
>
>> [ ] +0 OK, but...
>> [ ] -0 OK, but really should fix...
>> [ ] -1 I oppose this release because...
>>
>> Thanks!
>>
>> Phil
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Thomas Neidhart
hmm, I do not know what I have seen yesterday, but the references to dbcp
2.x and pool 2.3 are already correct.

I have updated the other 2 examples to use an h2 database as already
outlined in the PoolingDataSourceExample.

Thomas

On Wed, Feb 18, 2015 at 1:13 AM, Phil Steitz <[hidden email]> wrote:

> On 2/17/15 2:29 PM, Thomas Neidhart wrote:
> > On 02/17/2015 05:04 AM, Phil Steitz wrote:
> >> Quite a few bugs have been fixed since DBCP 2.0.1 and a few new
> >> features have been added.  It is time for a 2.1 release.
> >>
> >> The release is available for review here:
> >> https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031)
> >>
> >> The release was built from this tag:
> >> http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_1_RC1
> >> (r1660242)
> >>
> >> Release notes:
> >> https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt
> >>
> >> Maven artifacts:
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-1082
> >>
> >> Site:
> >> http://people.apache.org/~psteitz/dbcp/dbcp-2.1-RC1-site/
> >>
> >> KEYS:
> >> http://www.apache.org/dist/commons/KEYS
> >>
> >> Votes, please.
> >>
> >> This vote will close no sooner than 72 hours from now.
> > [x] +1 Release these artifacts
> >
> > Tested successfully within the following environment:
> >
> > $ mvn -version
> > Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
> > 17:22:22+0200)
> > Maven home: /home/tn/bin/apache-maven-3.1.1
> > Java version: 1.7.0_75, vendor: Oracle Corporation
> > Java home: /usr/lib/jvm/java-7-openjdk-i386/jre
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "linux", version: "3.13.0-37-generic", arch: "i386", family:
> "unix"
> >
> > One small nit that I found:
> >
> > while trying to run the examples with the jar I noticed that at least
> > two of the examples still contain instructions for dbcp 1.x.
>
> Drat.  I thought I had fixed them all...
> >
> > I would also update the examples to use a small self-contained,
> > in-memory database like hsqldb which makes it easier to quickly test it
> > (I can also update the example code post-release myself).
>
> By all means, have at it!  The examples on the web site are just
> sourced directly from svn, so fixes become immediately available.
>
> Thanks!
>
> Phil
> >
> > Thomas
> >
> >> [ ] +0 OK, but...
> >> [ ] -0 OK, but really should fix...
> >> [ ] -1 I oppose this release because...
> >>
> >> Thanks!
> >>
> >> Phil
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Emmanuel Bourg-3
In reply to this post by Phil Steitz
Le 17/02/2015 16:50, Phil Steitz a écrit :

> That is just the site build, which is not essential to the release,
> IMO, so again not a blocker.

Not only the site build, I got the same error with a simple 'mvn test'.

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Emmanuel Bourg-3
In reply to this post by Phil Steitz
> [X] +1 Release these artifacts

Tested with OpenJDK 7 on Debian.

The name of the isLogExpiredConnections() method in BasicDataSource and
BasicDataSourceMXBean looks a bit inconsistent with the other methods
returning a boolean. I would have picked getLogExpiredConnections
(similar to the getRemove*, getTest* and getLogAbandoned methods) or
isExpiredConnectionsLogged (similar to
isAccessToUnderlyingConnectionAllowed) instead.

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Phil Steitz
In reply to this post by Thomas Neidhart
On 2/18/15 3:08 AM, Thomas Neidhart wrote:
> hmm, I do not know what I have seen yesterday, but the references to dbcp
> 2.x and pool 2.3 are already correct.
Thanks.  That was driving me crazy.  Could be some funny svn mirror
lag or something if you were hitting them from the web page instead
of looking at the files in the src distro.
> I have updated the other 2 examples to use an h2 database as already
> outlined in the PoolingDataSourceExample.

Thanks!

Phil

>
> Thomas
>
> On Wed, Feb 18, 2015 at 1:13 AM, Phil Steitz <[hidden email]> wrote:
>
>> On 2/17/15 2:29 PM, Thomas Neidhart wrote:
>>> On 02/17/2015 05:04 AM, Phil Steitz wrote:
>>>> Quite a few bugs have been fixed since DBCP 2.0.1 and a few new
>>>> features have been added.  It is time for a 2.1 release.
>>>>
>>>> The release is available for review here:
>>>> https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031)
>>>>
>>>> The release was built from this tag:
>>>> http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_1_RC1
>>>> (r1660242)
>>>>
>>>> Release notes:
>>>> https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt
>>>>
>>>> Maven artifacts:
>>>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1082
>>>> Site:
>>>> http://people.apache.org/~psteitz/dbcp/dbcp-2.1-RC1-site/
>>>>
>>>> KEYS:
>>>> http://www.apache.org/dist/commons/KEYS
>>>>
>>>> Votes, please.
>>>>
>>>> This vote will close no sooner than 72 hours from now.
>>> [x] +1 Release these artifacts
>>>
>>> Tested successfully within the following environment:
>>>
>>> $ mvn -version
>>> Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
>>> 17:22:22+0200)
>>> Maven home: /home/tn/bin/apache-maven-3.1.1
>>> Java version: 1.7.0_75, vendor: Oracle Corporation
>>> Java home: /usr/lib/jvm/java-7-openjdk-i386/jre
>>> Default locale: en_US, platform encoding: UTF-8
>>> OS name: "linux", version: "3.13.0-37-generic", arch: "i386", family:
>> "unix"
>>> One small nit that I found:
>>>
>>> while trying to run the examples with the jar I noticed that at least
>>> two of the examples still contain instructions for dbcp 1.x.
>> Drat.  I thought I had fixed them all...
>>> I would also update the examples to use a small self-contained,
>>> in-memory database like hsqldb which makes it easier to quickly test it
>>> (I can also update the example code post-release myself).
>> By all means, have at it!  The examples on the web site are just
>> sourced directly from svn, so fixes become immediately available.
>>
>> Thanks!
>>
>> Phil
>>> Thomas
>>>
>>>> [ ] +0 OK, but...
>>>> [ ] -0 OK, but really should fix...
>>>> [ ] -1 I oppose this release because...
>>>>
>>>> Thanks!
>>>>
>>>> Phil
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [hidden email]
>>>> For additional commands, e-mail: [hidden email]
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Phil Steitz
In reply to this post by Emmanuel Bourg-3
On 2/18/15 6:30 AM, Emmanuel Bourg wrote:
>> [X] +1 Release these artifacts
> Tested with OpenJDK 7 on Debian.
>
> The name of the isLogExpiredConnections() method in BasicDataSource and
> BasicDataSourceMXBean looks a bit inconsistent with the other methods
> returning a boolean. I would have picked getLogExpiredConnections
> (similar to the getRemove*, getTest* and getLogAbandoned methods) or
> isExpiredConnectionsLogged (similar to
> isAccessToUnderlyingConnectionAllowed) instead.

Good point.  If you or others feel strongly that this is too ugly, I
can change and re-roll.

Any other opinions on this?

Thanks for the review!

Phil
>
> Emmanuel Bourg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Phil Steitz
In reply to this post by Emmanuel Bourg-3
On 2/18/15 5:05 AM, Emmanuel Bourg wrote:
> Le 17/02/2015 16:50, Phil Steitz a écrit :
>
>> That is just the site build, which is not essential to the release,
>> IMO, so again not a blocker.
> Not only the site build, I got the same error with a simple 'mvn test'.

That is not good.  What JDK and OS?

Phil
>
> Emmanuel Bourg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Emmanuel Bourg-3
Le 18/02/2015 14:48, Phil Steitz a écrit :

> That is not good.  What JDK and OS?

That was with OpenJDK 8u40b22 on Debian Jessie.

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Phil Steitz
On 2/18/15 6:52 AM, Emmanuel Bourg wrote:
> Le 18/02/2015 14:48, Phil Steitz a écrit :
>
>> That is not good.  What JDK and OS?
> That was with OpenJDK 8u40b22 on Debian Jessie.

Thanks.  I was just able to replicate.  I need to get rid of the
jacoco nonsense somehow.  Will fix and reroll.

Phil
>
> Emmanuel Bourg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[CANCELLED]: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Phil Steitz
In reply to this post by Phil Steitz
Due to problems with JDK 8 build...

On 2/16/15 9:04 PM, Phil Steitz wrote:

> Quite a few bugs have been fixed since DBCP 2.0.1 and a few new
> features have been added.  It is time for a 2.1 release.
>
> The release is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031)
>
> The release was built from this tag:
> http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_1_RC1
> (r1660242)
>
> Release notes:
> https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt
>
> Maven artifacts:
> https://repository.apache.org/content/repositories/orgapachecommons-1082
>
> Site:
> http://people.apache.org/~psteitz/dbcp/dbcp-2.1-RC1-site/
>
> KEYS:
> http://www.apache.org/dist/commons/KEYS
>
> Votes, please.
>
> This vote will close no sooner than 72 hours from now.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Emmanuel Bourg-3
In reply to this post by Phil Steitz
Le 18/02/2015 14:47, Phil Steitz a écrit :

> Good point.  If you or others feel strongly that this is too ugly, I
> can change and re-roll.
>
> Any other opinions on this?
>
> Thanks for the review!

On the same line I wonder if the isFastFailValidation() method would be
better named isFailFastValidation. I'm under the impression "fail fast"
is more common than "fast fail", but the difference is too subtle for a
non native speaker like me to perceive if it has any significance.

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

Thomas Neidhart
In reply to this post by Phil Steitz
I enabled jacoco a while a go, but if you would prefer cobertura we can
easily change to it.

Thomas

On Wed, Feb 18, 2015 at 2:54 PM, Phil Steitz <[hidden email]> wrote:

> On 2/18/15 6:52 AM, Emmanuel Bourg wrote:
> > Le 18/02/2015 14:48, Phil Steitz a écrit :
> >
> >> That is not good.  What JDK and OS?
> > That was with OpenJDK 8u40b22 on Debian Jessie.
>
> Thanks.  I was just able to replicate.  I need to get rid of the
> jacoco nonsense somehow.  Will fix and reroll.
>
> Phil
> >
> > Emmanuel Bourg
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
12