[VOTE] Release Apache Commons Daemon 1.1.1

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Commons Daemon 1.1.1

Mark Thomas
It has been ~18 months since the last Commons Daemon release. After the
recent flurry of activity, I think we are ready for a release.

Notable changes include:
- Improved JRE/JDK detection to support increased range of both JVM
  versions and vendors.
- Procrun. Change the default service from LocalSystem to
  'NT Authority\LocalService'

The full set of changes is in the changelog

1.1.1 can be obtained from (r34537):
https://dist.apache.org/repos/dist/dev/commons/daemon/

The git tag is:
https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
4319f482e1ff6ea7655e1377120750fd6ecc3810

The Maven Staging repo is:
https://repository.apache.org/content/repositories/orgapachecommons-1441/

The Windows binaries have been signed by the Symantec code signing service.



[ ] Approved - go ahead and release Commons Daemon 1.1.1
[ ] Broken   - do not release because...

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.1.1

garydgregory
This email is missing a few elements based on our release procedures at
https://commons.apache.org/releases/prepare.html

- Hashes to files on dist/dev
- Link to site
- Link to KEYS file
- Link to apache.org instead of github.com for the tag

Gary

On Mon, Jun 17, 2019 at 8:13 AM Mark Thomas <[hidden email]> wrote:

> It has been ~18 months since the last Commons Daemon release. After the
> recent flurry of activity, I think we are ready for a release.
>
> Notable changes include:
> - Improved JRE/JDK detection to support increased range of both JVM
>   versions and vendors.
> - Procrun. Change the default service from LocalSystem to
>   'NT Authority\LocalService'
>
> The full set of changes is in the changelog
>
> 1.1.1 can be obtained from (r34537):
> https://dist.apache.org/repos/dist/dev/commons/daemon/
>
> The git tag is:
> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
> 4319f482e1ff6ea7655e1377120750fd6ecc3810
> <https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_14319f482e1ff6ea7655e1377120750fd6ecc3810>
>
> The Maven Staging repo is:
> https://repository.apache.org/content/repositories/orgapachecommons-1441/
>
> The Windows binaries have been signed by the Symantec code signing service.
>
>
>
> [ ] Approved - go ahead and release Commons Daemon 1.1.1
> [ ] Broken   - do not release because...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.1.1

garydgregory
I am also getting a 404 for the link
https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_14319f482e1ff6ea7655e1377120750fd6ecc3810
which
might be a cut and paste issue or the way Gmail renders this URL.

Gary

On Mon, Jun 17, 2019 at 8:45 AM Gary Gregory <[hidden email]> wrote:

> This email is missing a few elements based on our release procedures at
> https://commons.apache.org/releases/prepare.html
>
> - Hashes to files on dist/dev
> - Link to site
> - Link to KEYS file
> - Link to apache.org instead of github.com for the tag
>
> Gary
>
> On Mon, Jun 17, 2019 at 8:13 AM Mark Thomas <[hidden email]> wrote:
>
>> It has been ~18 months since the last Commons Daemon release. After the
>> recent flurry of activity, I think we are ready for a release.
>>
>> Notable changes include:
>> - Improved JRE/JDK detection to support increased range of both JVM
>>   versions and vendors.
>> - Procrun. Change the default service from LocalSystem to
>>   'NT Authority\LocalService'
>>
>> The full set of changes is in the changelog
>>
>> 1.1.1 can be obtained from (r34537):
>> https://dist.apache.org/repos/dist/dev/commons/daemon/
>>
>> The git tag is:
>> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
>> 4319f482e1ff6ea7655e1377120750fd6ecc3810
>> <https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_14319f482e1ff6ea7655e1377120750fd6ecc3810>
>>
>> The Maven Staging repo is:
>> https://repository.apache.org/content/repositories/orgapachecommons-1441/
>>
>> The Windows binaries have been signed by the Symantec code signing
>> service.
>>
>>
>>
>> [ ] Approved - go ahead and release Commons Daemon 1.1.1
>> [ ] Broken   - do not release because...
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.1.1

garydgregory
In reply to this post by Mark Thomas
The version in the release notes at the top still says "1.1" instead of
"1.1.1".

It seems to me that 1.2 would be more appropriate since we upgraded both
the Java and OS requirements.

Gary

On Mon, Jun 17, 2019, 08:13 Mark Thomas <[hidden email]> wrote:

> It has been ~18 months since the last Commons Daemon release. After the
> recent flurry of activity, I think we are ready for a release.
>
> Notable changes include:
> - Improved JRE/JDK detection to support increased range of both JVM
>   versions and vendors.
> - Procrun. Change the default service from LocalSystem to
>   'NT Authority\LocalService'
>
> The full set of changes is in the changelog
>
> 1.1.1 can be obtained from (r34537):
> https://dist.apache.org/repos/dist/dev/commons/daemon/
>
> The git tag is:
> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
> 4319f482e1ff6ea7655e1377120750fd6ecc3810
> <https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_14319f482e1ff6ea7655e1377120750fd6ecc3810>
>
> The Maven Staging repo is:
> https://repository.apache.org/content/repositories/orgapachecommons-1441/
>
> The Windows binaries have been signed by the Symantec code signing service.
>
>
>
> [ ] Approved - go ahead and release Commons Daemon 1.1.1
> [ ] Broken   - do not release because...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.1.1

Mark Thomas
On 17/06/2019 15:58, Gary Gregory wrote:
> The version in the release notes at the top still says "1.1" instead of
> "1.1.1".

My understanding was they referred to 1.1.x (i.e. all of the 1.1
releases) so the version number was appropriate.

> It seems to me that 1.2 would be more appropriate since we upgraded both
> the Java and OS requirements.

No we didn't. See the changelog. The Java and OS requirements are the
same for 1.1.1 as they are for 1.1.0.

Mark


>
> Gary
>
> On Mon, Jun 17, 2019, 08:13 Mark Thomas <[hidden email]> wrote:
>
>> It has been ~18 months since the last Commons Daemon release. After the
>> recent flurry of activity, I think we are ready for a release.
>>
>> Notable changes include:
>> - Improved JRE/JDK detection to support increased range of both JVM
>>   versions and vendors.
>> - Procrun. Change the default service from LocalSystem to
>>   'NT Authority\LocalService'
>>
>> The full set of changes is in the changelog
>>
>> 1.1.1 can be obtained from (r34537):
>> https://dist.apache.org/repos/dist/dev/commons/daemon/
>>
>> The git tag is:
>> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
>> 4319f482e1ff6ea7655e1377120750fd6ecc3810
>> <https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_14319f482e1ff6ea7655e1377120750fd6ecc3810>
>>
>> The Maven Staging repo is:
>> https://repository.apache.org/content/repositories/orgapachecommons-1441/
>>
>> The Windows binaries have been signed by the Symantec code signing service.
>>
>>
>>
>> [ ] Approved - go ahead and release Commons Daemon 1.1.1
>> [ ] Broken   - do not release because...
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.1.1

garydgregory
In reply to this post by Mark Thomas
Also, while we even discussed PR
https://github.com/apache/commons-daemon/pull/11, it was not merged fir
this RC. I'd like to see an RC2 with it included.

Gary

On Mon, Jun 17, 2019 at 8:13 AM Mark Thomas <[hidden email]> wrote:

> It has been ~18 months since the last Commons Daemon release. After the
> recent flurry of activity, I think we are ready for a release.
>
> Notable changes include:
> - Improved JRE/JDK detection to support increased range of both JVM
>   versions and vendors.
> - Procrun. Change the default service from LocalSystem to
>   'NT Authority\LocalService'
>
> The full set of changes is in the changelog
>
> 1.1.1 can be obtained from (r34537):
> https://dist.apache.org/repos/dist/dev/commons/daemon/
>
> The git tag is:
> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
> 4319f482e1ff6ea7655e1377120750fd6ecc3810
> <https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_14319f482e1ff6ea7655e1377120750fd6ecc3810>
>
> The Maven Staging repo is:
> https://repository.apache.org/content/repositories/orgapachecommons-1441/
>
> The Windows binaries have been signed by the Symantec code signing service.
>
>
>
> [ ] Approved - go ahead and release Commons Daemon 1.1.1
> [ ] Broken   - do not release because...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.1.1

Mark Thomas
On 18/06/2019 14:20, Gary Gregory wrote:
> Also, while we even discussed PR
> https://github.com/apache/commons-daemon/pull/11, it was not merged fir
> this RC. I'd like to see an RC2 with it included.

Looking at this now.

Thinking about version numbers as a result of one of your other posts
there probably is a case for 1.2.0.

Since the 1.1.0 release Windows XP, Vista and Server 2003 have all
fallen out of support. Some of the Procrun changes assume Windows 7 /
Server 2008 SP2 (i.e. only currently supported versions of Windows) as a
minimum.

I think you could make a case for 1.1.1 on the grounds the older OSes
are unsupported but using 1.2.0 makes it cleaner.

The changes from the 1.1.1 tag to 1.2.0 are essentially cosmetic so far
so I'd urge folks to continue to test 1.1.1 and provide feedback.

Mark


>
> Gary
>
> On Mon, Jun 17, 2019 at 8:13 AM Mark Thomas <[hidden email]> wrote:
>
>> It has been ~18 months since the last Commons Daemon release. After the
>> recent flurry of activity, I think we are ready for a release.
>>
>> Notable changes include:
>> - Improved JRE/JDK detection to support increased range of both JVM
>>   versions and vendors.
>> - Procrun. Change the default service from LocalSystem to
>>   'NT Authority\LocalService'
>>
>> The full set of changes is in the changelog
>>
>> 1.1.1 can be obtained from (r34537):
>> https://dist.apache.org/repos/dist/dev/commons/daemon/
>>
>> The git tag is:
>> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
>> 4319f482e1ff6ea7655e1377120750fd6ecc3810
>> <https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_14319f482e1ff6ea7655e1377120750fd6ecc3810>
>>
>> The Maven Staging repo is:
>> https://repository.apache.org/content/repositories/orgapachecommons-1441/
>>
>> The Windows binaries have been signed by the Symantec code signing service.
>>
>>
>>
>> [ ] Approved - go ahead and release Commons Daemon 1.1.1
>> [ ] Broken   - do not release because...
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.1.1

garydgregory
On Tue, Jun 18, 2019 at 11:43 AM Mark Thomas <[hidden email]> wrote:

> On 18/06/2019 14:20, Gary Gregory wrote:
> > Also, while we even discussed PR
> > https://github.com/apache/commons-daemon/pull/11, it was not merged fir
> > this RC. I'd like to see an RC2 with it included.
>
> Looking at this now.
>
> Thinking about version numbers as a result of one of your other posts
> there probably is a case for 1.2.0.
>
> Since the 1.1.0 release Windows XP, Vista and Server 2003 have all
> fallen out of support. Some of the Procrun changes assume Windows 7 /
> Server 2008 SP2 (i.e. only currently supported versions of Windows) as a
> minimum.
>
> I think you could make a case for 1.1.1 on the grounds the older OSes
> are unsupported but using 1.2.0 makes it cleaner.
>
> The changes from the 1.1.1 tag to 1.2.0 are essentially cosmetic so far
> so I'd urge folks to continue to test 1.1.1 and provide feedback.
>

See my previous emails then.

Gary


>
> Mark
>
>
> >
> > Gary
> >
> > On Mon, Jun 17, 2019 at 8:13 AM Mark Thomas <[hidden email]> wrote:
> >
> >> It has been ~18 months since the last Commons Daemon release. After the
> >> recent flurry of activity, I think we are ready for a release.
> >>
> >> Notable changes include:
> >> - Improved JRE/JDK detection to support increased range of both JVM
> >>   versions and vendors.
> >> - Procrun. Change the default service from LocalSystem to
> >>   'NT Authority\LocalService'
> >>
> >> The full set of changes is in the changelog
> >>
> >> 1.1.1 can be obtained from (r34537):
> >> https://dist.apache.org/repos/dist/dev/commons/daemon/
> >>
> >> The git tag is:
> >> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
> >> 4319f482e1ff6ea7655e1377120750fd6ecc3810
> >> <
> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_14319f482e1ff6ea7655e1377120750fd6ecc3810
> >
> >>
> >> The Maven Staging repo is:
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-1441/
> >>
> >> The Windows binaries have been signed by the Symantec code signing
> service.
> >>
> >>
> >>
> >> [ ] Approved - go ahead and release Commons Daemon 1.1.1
> >> [ ] Broken   - do not release because...
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
> >>
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.1.1

Mark Thomas
On 18/06/2019 17:15, Gary Gregory wrote:

> On Tue, Jun 18, 2019 at 11:43 AM Mark Thomas <[hidden email]> wrote:
>
>> On 18/06/2019 14:20, Gary Gregory wrote:
>>> Also, while we even discussed PR
>>> https://github.com/apache/commons-daemon/pull/11, it was not merged fir
>>> this RC. I'd like to see an RC2 with it included.
>>
>> Looking at this now.
>>
>> Thinking about version numbers as a result of one of your other posts
>> there probably is a case for 1.2.0.
>>
>> Since the 1.1.0 release Windows XP, Vista and Server 2003 have all
>> fallen out of support. Some of the Procrun changes assume Windows 7 /
>> Server 2008 SP2 (i.e. only currently supported versions of Windows) as a
>> minimum.
>>
>> I think you could make a case for 1.1.1 on the grounds the older OSes
>> are unsupported but using 1.2.0 makes it cleaner.
>>
>> The changes from the 1.1.1 tag to 1.2.0 are essentially cosmetic so far
>> so I'd urge folks to continue to test 1.1.1 and provide feedback.
>>
>
> See my previous emails then.

Apart from switching 1.2.0 (addressed above) and your PR to modify log
messages (mentioned above and already committed) I don't see any other
feedback for 1.1.1 from you.

What am I missing?

Mark


>
> Gary
>
>
>>
>> Mark
>>
>>
>>>
>>> Gary
>>>
>>> On Mon, Jun 17, 2019 at 8:13 AM Mark Thomas <[hidden email]> wrote:
>>>
>>>> It has been ~18 months since the last Commons Daemon release. After the
>>>> recent flurry of activity, I think we are ready for a release.
>>>>
>>>> Notable changes include:
>>>> - Improved JRE/JDK detection to support increased range of both JVM
>>>>   versions and vendors.
>>>> - Procrun. Change the default service from LocalSystem to
>>>>   'NT Authority\LocalService'
>>>>
>>>> The full set of changes is in the changelog
>>>>
>>>> 1.1.1 can be obtained from (r34537):
>>>> https://dist.apache.org/repos/dist/dev/commons/daemon/
>>>>
>>>> The git tag is:
>>>> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
>>>> 4319f482e1ff6ea7655e1377120750fd6ecc3810
>>>> <
>> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_14319f482e1ff6ea7655e1377120750fd6ecc3810
>>>
>>>>
>>>> The Maven Staging repo is:
>>>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1441/
>>>>
>>>> The Windows binaries have been signed by the Symantec code signing
>> service.
>>>>
>>>>
>>>>
>>>> [ ] Approved - go ahead and release Commons Daemon 1.1.1
>>>> [ ] Broken   - do not release because...
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [hidden email]
>>>> For additional commands, e-mail: [hidden email]
>>>>
>>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.1.1

Rob Tompkins
In reply to this post by Mark Thomas
Will give this a look tonight (US Eastern, 9p). -Rob

> On Jun 17, 2019, at 8:13 AM, Mark Thomas <[hidden email]> wrote:
>
> It has been ~18 months since the last Commons Daemon release. After the
> recent flurry of activity, I think we are ready for a release.
>
> Notable changes include:
> - Improved JRE/JDK detection to support increased range of both JVM
>  versions and vendors.
> - Procrun. Change the default service from LocalSystem to
>  'NT Authority\LocalService'
>
> The full set of changes is in the changelog
>
> 1.1.1 can be obtained from (r34537):
> https://dist.apache.org/repos/dist/dev/commons/daemon/
>
> The git tag is:
> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
> 4319f482e1ff6ea7655e1377120750fd6ecc3810
>
> The Maven Staging repo is:
> https://repository.apache.org/content/repositories/orgapachecommons-1441/
>
> The Windows binaries have been signed by the Symantec code signing service.
>
>
>
> [ ] Approved - go ahead and release Commons Daemon 1.1.1
> [ ] Broken   - do not release because...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.1.1

Rob Tompkins
In reply to this post by Mark Thomas
Build works on java8 with “mvn clean test install site.” On java7 and java11 “mvn clean test” works.

One curiousity, “mvn apache-rat:check” fails with 4 license violations, namely:

        src/native/unix/native/.indent.pro
        src/native/unix/configure
        src/native/unix/support/config.guess
        src/native/unix/support/config.sub

I think aside from these I would likely be a +1. The “.indent.pro” looks to be excludable, the others, being GPL licensed, we may need to add to the NOTICE.txt and then add the Apache 2.0 license header to them? IIRC, we should be able to do something like that

Cheers,
-Rob


> On Jun 17, 2019, at 8:13 AM, Mark Thomas <[hidden email]> wrote:
>
> It has been ~18 months since the last Commons Daemon release. After the
> recent flurry of activity, I think we are ready for a release.
>
> Notable changes include:
> - Improved JRE/JDK detection to support increased range of both JVM
>  versions and vendors.
> - Procrun. Change the default service from LocalSystem to
>  'NT Authority\LocalService'
>
> The full set of changes is in the changelog
>
> 1.1.1 can be obtained from (r34537):
> https://dist.apache.org/repos/dist/dev/commons/daemon/
>
> The git tag is:
> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
> 4319f482e1ff6ea7655e1377120750fd6ecc3810
>
> The Maven Staging repo is:
> https://repository.apache.org/content/repositories/orgapachecommons-1441/
>
> The Windows binaries have been signed by the Symantec code signing service.
>
>
>
> [ ] Approved - go ahead and release Commons Daemon 1.1.1
> [ ] Broken   - do not release because...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.1.1

Mark Thomas
On 19/06/2019 02:04, Rob Tompkins wrote:
> Build works on java8 with “mvn clean test install site.” On java7 and java11 “mvn clean test” works.

Great. Thanks for looking.

> One curiousity, “mvn apache-rat:check” fails with 4 license violations, namely:
>
> src/native/unix/native/.indent.pro
> src/native/unix/configure
> src/native/unix/support/config.guess
> src/native/unix/support/config.sub
>
> I think aside from these I would likely be a +1.

Excellent. Things look to be in pretty good shape.

> The “.indent.pro” looks to be excludable,

It looks similar to checkstyle. It might be possible to add a header as
a comment. I'll take a look. I'll also see what happens if we run indent
against the current code.

> the others, being GPL licensed,

Not exactly.

configure is licensed as:

<quote>
# This configure script is free software; the Free Software Foundation
# gives unlimited permission to copy, distribute and modify it.
</quote>


config.guess and config.sub are GPL v3 or later with an exception namely:

<quote>
# As a special exception to the GNU General Public License, if you
# distribute this file as part of a program that contains a
# configuration script generated by Autoconf, you may include it under
# the same distribution terms that you use for the rest of that
# program.  This Exception is an additional permission under section 7
# of the GNU General Public License, version 3 ("GPLv3").
</quote>

That exception applies in this case so those files are distributed under
the terms of the ALv2.

> we may need to add to the NOTICE.txt

No. Only required notices go in NOTICE and there is no such requirement
for any of these three files.

> and then add the Apache 2.0 license header to them? IIRC, we should be able to do something like that

No. You can't re-license code if you don't own the copyright.

If code is licensed under something other than ALv2 that license needs
to be added to LICENSE. In this case the files are ALv2 licensed so I
don't think adding anything to LICENSE is necessary either.

Legally, I think 1.1.1 is fine.

ASF policy wise, we should try and put a header in .indent.pro but if
the file format doesn't support comments then it would be acceptable to
leave them out.

As an additional check, I looked at how httpd handles the same 3 files
and it includes them in the source as is and does not mention them in
either LICENSE or NOTICE so that reinforces my belief that Commons
Daemon is handling these 3 files correctly.

What we should do is ensure that those 3 files are excluded from RAT.
I'll add that to my TODO list but I won't complain if someone beats me
to it.

Mark


>
> Cheers,
> -Rob
>
>
>> On Jun 17, 2019, at 8:13 AM, Mark Thomas <[hidden email]> wrote:
>>
>> It has been ~18 months since the last Commons Daemon release. After the
>> recent flurry of activity, I think we are ready for a release.
>>
>> Notable changes include:
>> - Improved JRE/JDK detection to support increased range of both JVM
>>  versions and vendors.
>> - Procrun. Change the default service from LocalSystem to
>>  'NT Authority\LocalService'
>>
>> The full set of changes is in the changelog
>>
>> 1.1.1 can be obtained from (r34537):
>> https://dist.apache.org/repos/dist/dev/commons/daemon/
>>
>> The git tag is:
>> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
>> 4319f482e1ff6ea7655e1377120750fd6ecc3810
>>
>> The Maven Staging repo is:
>> https://repository.apache.org/content/repositories/orgapachecommons-1441/
>>
>> The Windows binaries have been signed by the Symantec code signing service.
>>
>>
>>
>> [ ] Approved - go ahead and release Commons Daemon 1.1.1
>> [ ] Broken   - do not release because...
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.1.1

Jonathan Gallimore
In reply to this post by Mark Thomas
This works well in my tests, many thanks for the release.

(non-binding) +1.

Jon

On Mon, Jun 17, 2019 at 1:13 PM Mark Thomas <[hidden email]> wrote:

> It has been ~18 months since the last Commons Daemon release. After the
> recent flurry of activity, I think we are ready for a release.
>
> Notable changes include:
> - Improved JRE/JDK detection to support increased range of both JVM
>   versions and vendors.
> - Procrun. Change the default service from LocalSystem to
>   'NT Authority\LocalService'
>
> The full set of changes is in the changelog
>
> 1.1.1 can be obtained from (r34537):
> https://dist.apache.org/repos/dist/dev/commons/daemon/
>
> The git tag is:
> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
> 4319f482e1ff6ea7655e1377120750fd6ecc3810
> <https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_14319f482e1ff6ea7655e1377120750fd6ecc3810>
>
> The Maven Staging repo is:
> https://repository.apache.org/content/repositories/orgapachecommons-1441/
>
> The Windows binaries have been signed by the Symantec code signing service.
>
>
>
> [ ] Approved - go ahead and release Commons Daemon 1.1.1
> [ ] Broken   - do not release because...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.1.1

Mark Thomas
On 19/06/2019 10:44, Jonathan Gallimore wrote:
> This works well in my tests, many thanks for the release.

Thanks for the confirmation.

Mark

>
> (non-binding) +1.
>
> Jon
>
> On Mon, Jun 17, 2019 at 1:13 PM Mark Thomas <[hidden email]> wrote:
>
>> It has been ~18 months since the last Commons Daemon release. After the
>> recent flurry of activity, I think we are ready for a release.
>>
>> Notable changes include:
>> - Improved JRE/JDK detection to support increased range of both JVM
>>   versions and vendors.
>> - Procrun. Change the default service from LocalSystem to
>>   'NT Authority\LocalService'
>>
>> The full set of changes is in the changelog
>>
>> 1.1.1 can be obtained from (r34537):
>> https://dist.apache.org/repos/dist/dev/commons/daemon/
>>
>> The git tag is:
>> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
>> 4319f482e1ff6ea7655e1377120750fd6ecc3810
>> <https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_14319f482e1ff6ea7655e1377120750fd6ecc3810>
>>
>> The Maven Staging repo is:
>> https://repository.apache.org/content/repositories/orgapachecommons-1441/
>>
>> The Windows binaries have been signed by the Symantec code signing service.
>>
>>
>>
>> [ ] Approved - go ahead and release Commons Daemon 1.1.1
>> [ ] Broken   - do not release because...
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.1.1

garydgregory
I do not understand the lack of reply to my requests to follow our release
process:

- Hashes to files on dist/dev
- Link to site
- Link to KEYS file
- Link to apache.org instead of github.com for the tag

Gary

On Wed, Jun 19, 2019 at 6:30 AM Mark Thomas <[hidden email]> wrote:

> On 19/06/2019 10:44, Jonathan Gallimore wrote:
> > This works well in my tests, many thanks for the release.
>
> Thanks for the confirmation.
>
> Mark
>
> >
> > (non-binding) +1.
> >
> > Jon
> >
> > On Mon, Jun 17, 2019 at 1:13 PM Mark Thomas <[hidden email]> wrote:
> >
> >> It has been ~18 months since the last Commons Daemon release. After the
> >> recent flurry of activity, I think we are ready for a release.
> >>
> >> Notable changes include:
> >> - Improved JRE/JDK detection to support increased range of both JVM
> >>   versions and vendors.
> >> - Procrun. Change the default service from LocalSystem to
> >>   'NT Authority\LocalService'
> >>
> >> The full set of changes is in the changelog
> >>
> >> 1.1.1 can be obtained from (r34537):
> >> https://dist.apache.org/repos/dist/dev/commons/daemon/
> >>
> >> The git tag is:
> >> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
> >> 4319f482e1ff6ea7655e1377120750fd6ecc3810
> >> <
> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_14319f482e1ff6ea7655e1377120750fd6ecc3810
> >
> >>
> >> The Maven Staging repo is:
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-1441/
> >>
> >> The Windows binaries have been signed by the Symantec code signing
> service.
> >>
> >>
> >>
> >> [ ] Approved - go ahead and release Commons Daemon 1.1.1
> >> [ ] Broken   - do not release because...
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
> >>
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

[CANCEL][VOTE] Release Apache Commons Daemon 1.1.1

Mark Thomas
In reply to this post by Mark Thomas
Given the discussions around 1.1.1 vs 1.2.0 I'm cancelling this release
vote.

I'll start preparing for a 1.2.0 RC now (I think things are pretty much
there but a final check won't hurt) with a view to tagging sometime
between late tomorrow and early next week.

If anyone has any objections to this plan then please speak up in the
next 24 hours.

Mark


On 17/06/2019 13:13, Mark Thomas wrote:

> It has been ~18 months since the last Commons Daemon release. After the
> recent flurry of activity, I think we are ready for a release.
>
> Notable changes include:
> - Improved JRE/JDK detection to support increased range of both JVM
>   versions and vendors.
> - Procrun. Change the default service from LocalSystem to
>   'NT Authority\LocalService'
>
> The full set of changes is in the changelog
>
> 1.1.1 can be obtained from (r34537):
> https://dist.apache.org/repos/dist/dev/commons/daemon/
>
> The git tag is:
> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
> 4319f482e1ff6ea7655e1377120750fd6ecc3810
>
> The Maven Staging repo is:
> https://repository.apache.org/content/repositories/orgapachecommons-1441/
>
> The Windows binaries have been signed by the Symantec code signing service.
>
>
>
> [ ] Approved - go ahead and release Commons Daemon 1.1.1
> [ ] Broken   - do not release because...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.1.1

Mark Thomas-21
In reply to this post by garydgregory
On 20/06/2019 13:34, Gary Gregory wrote:
> I do not understand the lack of reply to my requests to follow our release
> process:
>
> - Hashes to files on dist/dev

Not necessary.
The revision number for the dist repo is sufficient for traceability.

> - Link to site

Not part of the release.

> - Link to KEYS file

Not part of the release.
That said, it is trivial to include the link. I'll try and remember to
do that for 1.2.0.

> - Link to apache.org instead of github.com for the tag

Not necessary. The hash is sufficient.
That said, it is trivial to reference gitbox.a.o rather than GitHub.
I'll try and remember to do that for 1.2.0.

For a longer response, see the Daemon 1.1.0 vote thread.

Mark


>
> Gary
>
> On Wed, Jun 19, 2019 at 6:30 AM Mark Thomas <[hidden email]> wrote:
>
>> On 19/06/2019 10:44, Jonathan Gallimore wrote:
>>> This works well in my tests, many thanks for the release.
>>
>> Thanks for the confirmation.
>>
>> Mark
>>
>>>
>>> (non-binding) +1.
>>>
>>> Jon
>>>
>>> On Mon, Jun 17, 2019 at 1:13 PM Mark Thomas <[hidden email]> wrote:
>>>
>>>> It has been ~18 months since the last Commons Daemon release. After the
>>>> recent flurry of activity, I think we are ready for a release.
>>>>
>>>> Notable changes include:
>>>> - Improved JRE/JDK detection to support increased range of both JVM
>>>>   versions and vendors.
>>>> - Procrun. Change the default service from LocalSystem to
>>>>   'NT Authority\LocalService'
>>>>
>>>> The full set of changes is in the changelog
>>>>
>>>> 1.1.1 can be obtained from (r34537):
>>>> https://dist.apache.org/repos/dist/dev/commons/daemon/
>>>>
>>>> The git tag is:
>>>> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
>>>> 4319f482e1ff6ea7655e1377120750fd6ecc3810
>>>> <
>> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_14319f482e1ff6ea7655e1377120750fd6ecc3810
>>>
>>>>
>>>> The Maven Staging repo is:
>>>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1441/
>>>>
>>>> The Windows binaries have been signed by the Symantec code signing
>> service.
>>>>
>>>>
>>>>
>>>> [ ] Approved - go ahead and release Commons Daemon 1.1.1
>>>> [ ] Broken   - do not release because...
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [hidden email]
>>>> For additional commands, e-mail: [hidden email]
>>>>
>>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]