[VOTE] Release Apache Commons Daemon 1.2.0 RC2

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Commons Daemon 1.2.0 RC2

Mark Thomas
It has been ~18 months since the last Commons Daemon release. After the
recent flurry of activity and a couple of failed RCs, it is time for
another release vote.

Notable changes since 1.1.0 include:
- Improved JRE/JDK detection to support increased range of both JVM
  versions and vendors.
- Procrun. Minimum target platform for Windows binaries is now Windows 7
- Procrun. Change the default service from LocalSystem to
  'NT Authority\LocalService'

The full set of changes is in the changelog

1.2.0 RC2 can be obtained from (r34680):
https://dist.apache.org/repos/dist/dev/commons/daemon/

The git tag is:
Tag: COMMONS_DAEMON_1_2_0_RC2
URL:
https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=d88fd9100c1110fa51b7c7a08e3e7efd0e58227b
Hash:  d88fd9100c1110fa51b7c7a08e3e7efd0e58227b

The Maven Staging repo is:
https://repository.apache.org/content/repositories/orgapachecommons-1443/

The Windows binaries have been signed by the Symantec code signing service.

Files signed with my preferred key:
http://people.apache.org/~markt/
KEYS file is standard Apache Commons keys file:
http://www.apache.org/dist/commons/KEYS


[ ] Approved - go ahead and release Commons Daemon 1.2.0 RC2 as 1.2.0
[ ] Broken   - do not release because...

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.2.0 RC2

garydgregory
+1

TODO later: Update RNs since the POM uses version "1.2.0" and the release
notes use "1.2".

TODO later: src\native\windows\README should have a file extension since on
Windows text files without extensions are not customary.

TODO later: Fix Javadocs for Java 11 with 'mvn -V clean install site'
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
project commons-daemon: Error generating maven-javadoc-plugin:3.1.0:javadoc
report:
[ERROR] Exit code: 1 -
C:\temp\rc\commons-daemon\src\main\java\org\apache\commons\daemon\DaemonPermission.java:38:
error: attribute not supported in HTML5: width
[ERROR]  * <table width="100%" border="1">

Java 8 OK with:
- 'mvn apache-rat:check',
- 'mvn clirr:check'.
- 'mvn -V clean install site',

Java 11 OK with 'mvn -V clean install'

I was able to run 'nmake CPU=X86' (NMake Version 14.21.27702.2) on Windows
10.0.16299.1087 for both Windows apps. There is no 'SetEnv' script in my VS
install so 'nmake CPU=X64' failed. Our README needs a bit of updating.

Did you use the antique versions mentioned in the README? If not, please
update the file for future reference.

Java versions mentioned above:

Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
2019-04-04T15:00:29-04:00)
Maven home: C:\Java\apache-maven-3.6.1\bin\..
Java version: 11.0.3, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk-11.0.3
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
2019-04-04T15:00:29-04:00)
Maven home: C:\Java\apache-maven-3.6.1\bin\..
Java version: 1.8.0_212, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_212\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Gary





On Fri, Jun 28, 2019 at 10:21 AM Mark Thomas <[hidden email]> wrote:

> It has been ~18 months since the last Commons Daemon release. After the
> recent flurry of activity and a couple of failed RCs, it is time for
> another release vote.
>
> Notable changes since 1.1.0 include:
> - Improved JRE/JDK detection to support increased range of both JVM
>   versions and vendors.
> - Procrun. Minimum target platform for Windows binaries is now Windows 7
> - Procrun. Change the default service from LocalSystem to
>   'NT Authority\LocalService'
>
> The full set of changes is in the changelog
>
> 1.2.0 RC2 can be obtained from (r34680):
> https://dist.apache.org/repos/dist/dev/commons/daemon/
>
> The git tag is:
> Tag: COMMONS_DAEMON_1_2_0_RC2
> URL:
>
> https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=d88fd9100c1110fa51b7c7a08e3e7efd0e58227b
> Hash:  d88fd9100c1110fa51b7c7a08e3e7efd0e58227b
>
> The Maven Staging repo is:
> https://repository.apache.org/content/repositories/orgapachecommons-1443/
>
> The Windows binaries have been signed by the Symantec code signing service.
>
> Files signed with my preferred key:
> http://people.apache.org/~markt/
> KEYS file is standard Apache Commons keys file:
> http://www.apache.org/dist/commons/KEYS
>
>
> [ ] Approved - go ahead and release Commons Daemon 1.2.0 RC2 as 1.2.0
> [ ] Broken   - do not release because...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.2.0 RC2

Mark Thomas
On 28/06/2019 15:49, Gary Gregory wrote:
> +1
>
> TODO later: Update RNs since the POM uses version "1.2.0" and the release
> notes use "1.2".

That is by design. The release notes are intended for the entire 1.2.x
release stream. This is how Daemon has done it in the past.

Do we want to switch to point release specific notes, change the version
in the release notes to 1.2.x or something else?

> TODO later: src\native\windows\README should have a file extension since on
> Windows text files without extensions are not customary.

I'll get that done now and I'll check for any other extension-less files
too.

> TODO later: Fix Javadocs for Java 11 with 'mvn -V clean install site'
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project commons-daemon: Error generating maven-javadoc-plugin:3.1.0:javadoc
> report:
> [ERROR] Exit code: 1 -
> C:\temp\rc\commons-daemon\src\main\java\org\apache\commons\daemon\DaemonPermission.java:38:
> error: attribute not supported in HTML5: width
> [ERROR]  * <table width="100%" border="1">

Fixed (locally - I'll commit shortly). I was surprised that was the only
issue.

> Java 8 OK with:
> - 'mvn apache-rat:check',
> - 'mvn clirr:check'.
> - 'mvn -V clean install site',
>
> Java 11 OK with 'mvn -V clean install'
>
> I was able to run 'nmake CPU=X86' (NMake Version 14.21.27702.2) on Windows
> 10.0.16299.1087 for both Windows apps. There is no 'SetEnv' script in my VS
> install so 'nmake CPU=X64' failed. Our README needs a bit of updating.

More than a bit :)

> Did you use the antique versions mentioned in the README? If not, please
> update the file for future reference.

I'll update the release build instructions. It should be possible to
build with recent Visual Studio versions too. If someone familiar with
that tool can add instructions for Visual Studio that would be helpful.

> Java versions mentioned above:
>
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> 2019-04-04T15:00:29-04:00)
> Maven home: C:\Java\apache-maven-3.6.1\bin\..
> Java version: 11.0.3, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk-11.0.3
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> 2019-04-04T15:00:29-04:00)
> Maven home: C:\Java\apache-maven-3.6.1\bin\..
> Java version: 1.8.0_212, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_212\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Gary

Many thanks.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.2.0 RC2

garydgregory
On Fri, Jun 28, 2019 at 11:37 AM Mark Thomas <[hidden email]> wrote:

> On 28/06/2019 15:49, Gary Gregory wrote:
> > +1
> >
> > TODO later: Update RNs since the POM uses version "1.2.0" and the release
> > notes use "1.2".
>
> That is by design. The release notes are intended for the entire 1.2.x
> release stream. This is how Daemon has done it in the past.
>

I'm not fan of that style. I like the file to contain all the RNs for all
versions, so that when I update from 1.x to 1.x+5 I can see all that's
changed at each step. That's what I've been doing in other components in
Commons.

2c,
Gary


>
> Do we want to switch to point release specific notes, change the version
> in the release notes to 1.2.x or something else?
>
> > TODO later: src\native\windows\README should have a file extension since
> on
> > Windows text files without extensions are not customary.
>
> I'll get that done now and I'll check for any other extension-less files
> too.
>
> > TODO later: Fix Javadocs for Java 11 with 'mvn -V clean install site'
> > [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> > project commons-daemon: Error generating
> maven-javadoc-plugin:3.1.0:javadoc
> > report:
> > [ERROR] Exit code: 1 -
> >
> C:\temp\rc\commons-daemon\src\main\java\org\apache\commons\daemon\DaemonPermission.java:38:
> > error: attribute not supported in HTML5: width
> > [ERROR]  * <table width="100%" border="1">
>
> Fixed (locally - I'll commit shortly). I was surprised that was the only
> issue.
>
> > Java 8 OK with:
> > - 'mvn apache-rat:check',
> > - 'mvn clirr:check'.
> > - 'mvn -V clean install site',
> >
> > Java 11 OK with 'mvn -V clean install'
> >
> > I was able to run 'nmake CPU=X86' (NMake Version 14.21.27702.2) on
> Windows
> > 10.0.16299.1087 for both Windows apps. There is no 'SetEnv' script in my
> VS
> > install so 'nmake CPU=X64' failed. Our README needs a bit of updating.
>
> More than a bit :)
>
> > Did you use the antique versions mentioned in the README? If not, please
> > update the file for future reference.
>
> I'll update the release build instructions. It should be possible to
> build with recent Visual Studio versions too. If someone familiar with
> that tool can add instructions for Visual Studio that would be helpful.
>
> > Java versions mentioned above:
> >
> > Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> > 2019-04-04T15:00:29-04:00)
> > Maven home: C:\Java\apache-maven-3.6.1\bin\..
> > Java version: 11.0.3, vendor: Oracle Corporation, runtime: C:\Program
> > Files\Java\jdk-11.0.3
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> >
> > Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> > 2019-04-04T15:00:29-04:00)
> > Maven home: C:\Java\apache-maven-3.6.1\bin\..
> > Java version: 1.8.0_212, vendor: Oracle Corporation, runtime: C:\Program
> > Files\Java\jdk1.8.0_212\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> >
> > Gary
>
> Many thanks.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.2.0 RC2

Mark Thomas
In reply to this post by Mark Thomas
On 28/06/2019 15:20, Mark Thomas wrote:

<snip/>

> [X] Approved - go ahead and release Commons Daemon 1.2.0 RC2 as 1.2.0
> [ ] Broken   - do not release because...

Tested with Tomcat 9.0.x build process and the resulting Windows installer.

There were (expected) file permission issues due to the change in the
default user. Otherwise all good. The service ran without issues.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.2.0 RC2

Rob Tompkins
In reply to this post by Mark Thomas
+1, reports good, signatures good, agree with Gary on builds.

-Rob

> On Jun 28, 2019, at 10:20 AM, Mark Thomas <[hidden email]> wrote:
>
> It has been ~18 months since the last Commons Daemon release. After the
> recent flurry of activity and a couple of failed RCs, it is time for
> another release vote.
>
> Notable changes since 1.1.0 include:
> - Improved JRE/JDK detection to support increased range of both JVM
>  versions and vendors.
> - Procrun. Minimum target platform for Windows binaries is now Windows 7
> - Procrun. Change the default service from LocalSystem to
>  'NT Authority\LocalService'
>
> The full set of changes is in the changelog
>
> 1.2.0 RC2 can be obtained from (r34680):
> https://dist.apache.org/repos/dist/dev/commons/daemon/
>
> The git tag is:
> Tag: COMMONS_DAEMON_1_2_0_RC2
> URL:
> https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=d88fd9100c1110fa51b7c7a08e3e7efd0e58227b
> Hash:  d88fd9100c1110fa51b7c7a08e3e7efd0e58227b
>
> The Maven Staging repo is:
> https://repository.apache.org/content/repositories/orgapachecommons-1443/
>
> The Windows binaries have been signed by the Symantec code signing service.
>
> Files signed with my preferred key:
> http://people.apache.org/~markt/
> KEYS file is standard Apache Commons keys file:
> http://www.apache.org/dist/commons/KEYS
>
>
> [ ] Approved - go ahead and release Commons Daemon 1.2.0 RC2 as 1.2.0
> [ ] Broken   - do not release because...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.2.0 RC2

Jonathan Gallimore
In reply to this post by Mark Thomas
+1, thanks for the release!

Jon

On Fri, Jun 28, 2019 at 3:21 PM Mark Thomas <[hidden email]> wrote:

> It has been ~18 months since the last Commons Daemon release. After the
> recent flurry of activity and a couple of failed RCs, it is time for
> another release vote.
>
> Notable changes since 1.1.0 include:
> - Improved JRE/JDK detection to support increased range of both JVM
>   versions and vendors.
> - Procrun. Minimum target platform for Windows binaries is now Windows 7
> - Procrun. Change the default service from LocalSystem to
>   'NT Authority\LocalService'
>
> The full set of changes is in the changelog
>
> 1.2.0 RC2 can be obtained from (r34680):
> https://dist.apache.org/repos/dist/dev/commons/daemon/
>
> The git tag is:
> Tag: COMMONS_DAEMON_1_2_0_RC2
> URL:
>
> https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=d88fd9100c1110fa51b7c7a08e3e7efd0e58227b
> Hash:  d88fd9100c1110fa51b7c7a08e3e7efd0e58227b
>
> The Maven Staging repo is:
> https://repository.apache.org/content/repositories/orgapachecommons-1443/
>
> The Windows binaries have been signed by the Symantec code signing service.
>
> Files signed with my preferred key:
> http://people.apache.org/~markt/
> KEYS file is standard Apache Commons keys file:
> http://www.apache.org/dist/commons/KEYS
>
>
> [ ] Approved - go ahead and release Commons Daemon 1.2.0 RC2 as 1.2.0
> [ ] Broken   - do not release because...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Daemon 1.2.0 RC2

Stian Soiland-Reyes
In reply to this post by Mark Thomas
My vote: +1 (binding)

Verified:
  +1 sha512 sha256
  +1 asc / KEYS
  +1 src zip vs tar.gz
  +1 bin zip vs tar.gz vs jar
  +1 src vs git  (missing in src: README.md CONTRIBUTING.md;
             whitespace differences in commons-daemon-1.2.0-native-src)
  +1 mvn repo vs dist
  +1 mvn apache-rat:check
  +1 No unexpected binaries in src (bmp, rtf, ico)
  +1 LICENSE NOTICE
  +0 GPL code in src/native/unix/support/config.*
     (permitted w/ autoconf exception)
  +1 mvn clean install
  -1 commons-daemon-1.2.0-native-src/unix/INSTALL.txt outdated
  +1 ./configure ; make  (tested just ./jsvc --help )


Tested with Ubuntu 18.04 TLS

$ mvn -v
Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T19:41:47+01:00)
Maven home: /home/stain/software/maven
Java version: 11.0.3, vendor: Oracle Corporation, runtime: /usr/lib/jvm/java-11-openjdk-amd64
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-52-generic", arch: "amd64", family: "unix"

I did not test building or running the Windows part.


commons-daemon-1.2.0-native-src/unix is outdated as it claims you only
need to run "sh support/buildconf.sh" if building from SVN. We are using
git, and I still had to run it when building from dist/sources




On Fri, 28 Jun 2019 15:20:56 +0100, Mark Thomas <[hidden email]> wrote:

> It has been ~18 months since the last Commons Daemon release. After the
> recent flurry of activity and a couple of failed RCs, it is time for
> another release vote.
>
> Notable changes since 1.1.0 include:
> - Improved JRE/JDK detection to support increased range of both JVM
>   versions and vendors.
> - Procrun. Minimum target platform for Windows binaries is now Windows 7
> - Procrun. Change the default service from LocalSystem to
>   'NT Authority\LocalService'
>
> The full set of changes is in the changelog
>
> 1.2.0 RC2 can be obtained from (r34680):
> https://dist.apache.org/repos/dist/dev/commons/daemon/
>
> The git tag is:
> Tag: COMMONS_DAEMON_1_2_0_RC2
> URL:
> https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=d88fd9100c1110fa51b7c7a08e3e7efd0e58227b
> Hash:  d88fd9100c1110fa51b7c7a08e3e7efd0e58227b
>
> The Maven Staging repo is:
> https://repository.apache.org/content/repositories/orgapachecommons-1443/
>
> The Windows binaries have been signed by the Symantec code signing service.
>
> Files signed with my preferred key:
> http://people.apache.org/~markt/
> KEYS file is standard Apache Commons keys file:
> http://www.apache.org/dist/commons/KEYS
>
>
> [ ] Approved - go ahead and release Commons Daemon 1.2.0 RC2 as 1.2.0
> [ ] Broken   - do not release because...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE][RESULT] Release Apache Commons Daemon 1.2.0 RC2

Mark Thomas
In reply to this post by Mark Thomas
The following votes were cast:

Binding:
+1: ggregory, markt, chtompki, stain

Non-binding:
+1: Jonathan Gallimore

No other votes were cast.

The vote therefore passes.

Thanks to everyone who contributed to this release.

Mark


On 28/06/2019 15:20, Mark Thomas wrote:

> It has been ~18 months since the last Commons Daemon release. After the
> recent flurry of activity and a couple of failed RCs, it is time for
> another release vote.
>
> Notable changes since 1.1.0 include:
> - Improved JRE/JDK detection to support increased range of both JVM
>   versions and vendors.
> - Procrun. Minimum target platform for Windows binaries is now Windows 7
> - Procrun. Change the default service from LocalSystem to
>   'NT Authority\LocalService'
>
> The full set of changes is in the changelog
>
> 1.2.0 RC2 can be obtained from (r34680):
> https://dist.apache.org/repos/dist/dev/commons/daemon/
>
> The git tag is:
> Tag: COMMONS_DAEMON_1_2_0_RC2
> URL:
> https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=d88fd9100c1110fa51b7c7a08e3e7efd0e58227b
> Hash:  d88fd9100c1110fa51b7c7a08e3e7efd0e58227b
>
> The Maven Staging repo is:
> https://repository.apache.org/content/repositories/orgapachecommons-1443/
>
> The Windows binaries have been signed by the Symantec code signing service.
>
> Files signed with my preferred key:
> http://people.apache.org/~markt/
> KEYS file is standard Apache Commons keys file:
> http://www.apache.org/dist/commons/KEYS
>
>
> [ ] Approved - go ahead and release Commons Daemon 1.2.0 RC2 as 1.2.0
> [ ] Broken   - do not release because...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]