[VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

classic Classic list List threaded Threaded
25 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Thomas Vandahl
I would like to beta-release the [jcs] component.

Apache Commons JCS 2.0-beta-2 RC1 is available for review at:
  https://dist.apache.org/repos/dist/dev/commons/jcs/ (r16621).

Maven artifacts are at:
  https://repository.apache.org/content/repositories/orgapachecommons-1211 .

The Subversion tag is:

https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.0-beta-2
 (r1766068).

The release notes are at:

https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.0-beta-2/RELEASE-NOTES.txt
(r1766068).

Please review the release candidate and vote.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Please be lenient with me as this is my first Commons release attempt.

Bye, Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Benedikt Ritter-4
Hello Thomas,

The build works with Java 8 and Maven 3.3.9.

But the md5 and SHA1 files are missing in the dist area.

-1

Benedikt

Thomas Vandahl <[hidden email]> schrieb am Fr., 21. Okt. 2016 um 19:42 Uhr:

> I would like to beta-release the [jcs] component.
>
> Apache Commons JCS 2.0-beta-2 RC1 is available for review at:
>   https://dist.apache.org/repos/dist/dev/commons/jcs/ (r16621).
>
> Maven artifacts are at:
>   https://repository.apache.org/content/repositories/orgapachecommons-1211
> .
>
> The Subversion tag is:
>
>
> https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.0-beta-2
>  (r1766068).
>
> The release notes are at:
>
>
> https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.0-beta-2/RELEASE-NOTES.txt
> (r1766068).
>
> Please review the release candidate and vote.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Please be lenient with me as this is my first Commons release attempt.
>
> Bye, Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Thomas Vandahl
Hi Benedikt,

On 23.10.16 10:51, Benedikt Ritter wrote:
> Hello Thomas,
>
> The build works with Java 8 and Maven 3.3.9.
>
> But the md5 and SHA1 files are missing in the dist area.
>
> -1
>

I thought the signatures were sufficient. I added the check sums with
r16631. Please check again.

Bye, Thomas.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Benedikt Ritter-4
Hello Thomas

Thomas Vandahl <[hidden email]> schrieb am So., 23. Okt. 2016 um 12:16 Uhr:

> Hi Benedikt,
>
> On 23.10.16 10:51, Benedikt Ritter wrote:
> > Hello Thomas,
> >
> > The build works with Java 8 and Maven 3.3.9.
> >
> > But the md5 and SHA1 files are missing in the dist area.
> >
> > -1
> >
>
> I thought the signatures were sufficient. I added the check sums with
> r16631. Please check again.
>

Sorry, if that has been decided, I must have missed it. I'll take another
look tonight.

Regards,
Benedikt


>
> Bye, Thomas.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Romain Manni-Bucau
+1, thanks Thomas

Side note: the tck module has been deactivated cause of packaging=pom but
ran it manually and all tests passed so not an issue for the release since
we don't care of this artifact distribution, just here as a runner.


Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com> | JavaEE Factory
<https://javaeefactory-rmannibucau.rhcloud.com>

2016-10-24 8:34 GMT+02:00 Benedikt Ritter <[hidden email]>:

> Hello Thomas
>
> Thomas Vandahl <[hidden email]> schrieb am So., 23. Okt. 2016 um 12:16 Uhr:
>
> > Hi Benedikt,
> >
> > On 23.10.16 10:51, Benedikt Ritter wrote:
> > > Hello Thomas,
> > >
> > > The build works with Java 8 and Maven 3.3.9.
> > >
> > > But the md5 and SHA1 files are missing in the dist area.
> > >
> > > -1
> > >
> >
> > I thought the signatures were sufficient. I added the check sums with
> > r16631. Please check again.
> >
>
> Sorry, if that has been decided, I must have missed it. I'll take another
> look tonight.
>
> Regards,
> Benedikt
>
>
> >
> > Bye, Thomas.
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Johannes Weberhofer
In reply to this post by Thomas Vandahl


Am 21.10.2016 um 19:42 schrieb Thomas Vandahl:

> I would like to beta-release the [jcs] component.
>
> Apache Commons JCS 2.0-beta-2 RC1 is available for review at:
>   https://dist.apache.org/repos/dist/dev/commons/jcs/ (r16621).
>
> Maven artifacts are at:
>   https://repository.apache.org/content/repositories/orgapachecommons-1211 .
>
> The Subversion tag is:
>
> https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.0-beta-2
>  (r1766068).
>
> The release notes are at:
>
> https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.0-beta-2/RELEASE-NOTES.txt
> (r1766068).
>
> Please review the release candidate and vote.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Please be lenient with me as this is my first Commons release attempt.
>
> Bye, Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

Dear Thomas,

thanks for releasing that version! Compared to former builds the tests are much faster (When I remember right, it took me more than 10 minutes to create a package before). This is a non-binding +1!

I have replaced a beta1 version by this version in a testing software it runs without any issues so far.

Best regard,
Johannes


Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
Maven home: /opt/apache-maven
Java version: 1.8.0_101, vendor: Oracle Corporation
Java home: /usr/lib64/jvm/java-1.8.0-openjdk-1.8.0/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "linux", version: "4.8.2-3.g5e4310e-default", arch: "amd64", family: "unix"

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Commons JCS ................................. SUCCESS [ 25.442 s]
[INFO] Apache Commons JCS :: Core ......................... SUCCESS [03:49 min]
[INFO] Apache Commons JCS :: JCache ....................... SUCCESS [  2.810 s]
[INFO] Apache Commons JCS :: JCache TCK ................... SUCCESS [  2.437 s]
[INFO] Apache Commons JCS :: JCache Extras ................ SUCCESS [  7.353 s]
[INFO] Apache Commons JCS :: JCache OpenJPA ............... SUCCESS [  3.318 s]
[INFO] Apache Commons JCS :: Distribution ................. SUCCESS [  0.218 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 04:31 min
[INFO] Finished at: 2016-10-24T12:24:41+02:00
[INFO] Final Memory: 58M/489M
[INFO] ------------------------------------------------------------------------



--
Johannes Weberhofer
Weberhofer GmbH, Austria, Vienna

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

sebb-2-2
In reply to this post by Benedikt Ritter-4
On 24 October 2016 at 07:34, Benedikt Ritter <[hidden email]> wrote:

> Hello Thomas
>
> Thomas Vandahl <[hidden email]> schrieb am So., 23. Okt. 2016 um 12:16 Uhr:
>
>> Hi Benedikt,
>>
>> On 23.10.16 10:51, Benedikt Ritter wrote:
>> > Hello Thomas,
>> >
>> > The build works with Java 8 and Maven 3.3.9.
>> >
>> > But the md5 and SHA1 files are missing in the dist area.
>> >
>> > -1
>> >
>>
>> I thought the signatures were sufficient. I added the check sums with
>> r16631. Please check again.
>>
>
> Sorry, if that has been decided, I must have missed it.

An MD5 hash is still required as well as the sig, see:

http://www.apache.org/dev/release-signing.html#basic-facts


> I'll take another
> look tonight.
>
> Regards,
> Benedikt
>
>
>>
>> Bye, Thomas.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Mark Struberg-2
In reply to this post by Johannes Weberhofer
+1

LieGrue,
strub


> Am 24.10.2016 um 14:36 schrieb Johannes Weberhofer <[hidden email]>:
>
>
>
> Am 21.10.2016 um 19:42 schrieb Thomas Vandahl:
>> I would like to beta-release the [jcs] component.
>>
>> Apache Commons JCS 2.0-beta-2 RC1 is available for review at:
>>  https://dist.apache.org/repos/dist/dev/commons/jcs/ (r16621).
>>
>> Maven artifacts are at:
>>  https://repository.apache.org/content/repositories/orgapachecommons-1211 .
>>
>> The Subversion tag is:
>>
>> https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.0-beta-2
>> (r1766068).
>>
>> The release notes are at:
>>
>> https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.0-beta-2/RELEASE-NOTES.txt
>> (r1766068).
>>
>> Please review the release candidate and vote.
>>
>>  [ ] +1 Release these artifacts
>>  [ ] +0 OK, but...
>>  [ ] -0 OK, but really should fix...
>>  [ ] -1 I oppose this release because...
>>
>> Please be lenient with me as this is my first Commons release attempt.
>>
>> Bye, Thomas
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> Dear Thomas,
>
> thanks for releasing that version! Compared to former builds the tests are much faster (When I remember right, it took me more than 10 minutes to create a package before). This is a non-binding +1!
>
> I have replaced a beta1 version by this version in a testing software it runs without any issues so far.
>
> Best regard,
> Johannes
>
>
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
> Maven home: /opt/apache-maven
> Java version: 1.8.0_101, vendor: Oracle Corporation
> Java home: /usr/lib64/jvm/java-1.8.0-openjdk-1.8.0/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux", version: "4.8.2-3.g5e4310e-default", arch: "amd64", family: "unix"
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Commons JCS ................................. SUCCESS [ 25.442 s]
> [INFO] Apache Commons JCS :: Core ......................... SUCCESS [03:49 min]
> [INFO] Apache Commons JCS :: JCache ....................... SUCCESS [  2.810 s]
> [INFO] Apache Commons JCS :: JCache TCK ................... SUCCESS [  2.437 s]
> [INFO] Apache Commons JCS :: JCache Extras ................ SUCCESS [  7.353 s]
> [INFO] Apache Commons JCS :: JCache OpenJPA ............... SUCCESS [  3.318 s]
> [INFO] Apache Commons JCS :: Distribution ................. SUCCESS [  0.218 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 04:31 min
> [INFO] Finished at: 2016-10-24T12:24:41+02:00
> [INFO] Final Memory: 58M/489M
> [INFO] ------------------------------------------------------------------------
>
>
>
> --
> Johannes Weberhofer
> Weberhofer GmbH, Austria, Vienna
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Thomas Vandahl
In reply to this post by Thomas Vandahl
On 21.10.16 19:42, Thomas Vandahl wrote:
>   [X] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...

My own vote.

Bye, Thomas


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Thomas Vandahl
In reply to this post by Romain Manni-Bucau
Hi Romain,

On 24.10.16 12:44, Romain Manni-Bucau wrote:
> +1, thanks Thomas
>
> Side note: the tck module has been deactivated cause of packaging=pom but
> ran it manually and all tests passed so not an issue for the release since
> we don't care of this artifact distribution, just here as a runner.

The build failed with the default packaging at some point with the
message "no primary artifact", so I decided to change it to POM. I'll
see how this can be fixed later.

Bye, Thomas



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Romain Manni-Bucau
2016-10-24 21:03 GMT+02:00 Thomas Vandahl <[hidden email]>:

> Hi Romain,
>
> On 24.10.16 12:44, Romain Manni-Bucau wrote:
> > +1, thanks Thomas
> >
> > Side note: the tck module has been deactivated cause of packaging=pom but
> > ran it manually and all tests passed so not an issue for the release
> since
> > we don't care of this artifact distribution, just here as a runner.
>
> The build failed with the default packaging at some point with the
> message "no primary artifact", so I decided to change it to POM. I'll
> see how this can be fixed later.
>
>
No problem, works for me so maybe linked to release profile. Happy to help
if you struggle with it too much.


> Bye, Thomas
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Thomas Vandahl
In reply to this post by Benedikt Ritter-4
Hi Benedikt,

On 24.10.16 08:34, Benedikt Ritter wrote:
> Sorry, if that has been decided, I must have missed it. I'll take another
> look tonight.

Could you please reconsider your vote? I fixed the check sums so give it
one more chance!

Bye, Thomas




---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Oliver Heger-3
In reply to this post by Thomas Vandahl
Hi,

when building on Windows 10 with Java 1.6 I get the error below. The
build with Java 1.8 is successful.

On the distributions, I found some problems:
- Both the source and the binary distribution deflate in the same
folder. Typically, different folders are used.
- The binary distribution does not only contain the jars but also all
hashes and checksums. I don't think that they are required.

Is a site available for review?

One question regarding the beta status of the release: Are the artifacts
going to be deployed to Maven central? Then there should be a special
handling of breaking changes (special maven coordinates and package
names indicating beta status). Otherwise, it would be good if the
release notes contained a corresponding hint.

Oliver

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test
(default-test) on project commons-jcs-jcache-extras: Execution
default-test of goal
org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: There
was an error in the forked process
[ERROR] java.lang.UnsupportedClassVersionError:
org/apache/catalina/startup/Tomcat : Unsupported major.minor version 51.0
[ERROR] at java.lang.ClassLoader.defineClass1(Native Method)
[ERROR] at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
[ERROR] at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
[ERROR] at
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141)
[ERROR] at java.net.URLClassLoader.defineClass(URLClassLoader.java:283)
[ERROR] at java.net.URLClassLoader.access$000(URLClassLoader.java:58)
[ERROR] at java.net.URLClassLoader$1.run(URLClassLoader.java:197)
[ERROR] at java.security.AccessController.doPrivileged(Native Method)
[ERROR] at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
[ERROR] at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
[ERROR] at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
[ERROR] at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
[ERROR] at java.lang.Class.getDeclaredMethods0(Native Method)
[ERROR] at java.lang.Class.privateGetDeclaredMethods(Class.java:2436)
[ERROR] at java.lang.Class.getDeclaredMethods(Class.java:1793)
[ERROR] at
org.apache.maven.surefire.common.junit4.JUnit4TestChecker.checkforTestAnnotatedMethod(JUnit4TestChecker.java:91)
[ERROR] at
org.apache.maven.surefire.common.junit4.JUnit4TestChecker.lookForTestAnnotatedMethods(JUnit4TestChecker.java:80)
[ERROR] at
org.apache.maven.surefire.common.junit4.JUnit4TestChecker.isValidJUnit4Test(JUnit4TestChecker.java:72)
[ERROR] at
org.apache.maven.surefire.common.junit4.JUnit4TestChecker.accept(JUnit4TestChecker.java:52)
[ERROR] at
org.apache.maven.surefire.util.DefaultScanResult.applyFilter(DefaultScanResult.java:98)
[ERROR] at
org.apache.maven.surefire.junit4.JUnit4Provider.scanClassPath(JUnit4Provider.java:311)
[ERROR] at
org.apache.maven.surefire.junit4.JUnit4Provider.setTestsToRun(JUnit4Provider.java:191)
[ERROR] at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:134)
[ERROR] at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290)
[ERROR] at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242)
[ERROR] at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the
-e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions,
please read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the
command
[ERROR]   mvn <goals> -rf :commons-jcs-jcache-extras


Am 21.10.2016 um 19:42 schrieb Thomas Vandahl:

> I would like to beta-release the [jcs] component.
>
> Apache Commons JCS 2.0-beta-2 RC1 is available for review at:
>   https://dist.apache.org/repos/dist/dev/commons/jcs/ (r16621).
>
> Maven artifacts are at:
>   https://repository.apache.org/content/repositories/orgapachecommons-1211 .
>
> The Subversion tag is:
>
> https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.0-beta-2
>  (r1766068).
>
> The release notes are at:
>
> https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.0-beta-2/RELEASE-NOTES.txt
> (r1766068).
>
> Please review the release candidate and vote.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Please be lenient with me as this is my first Commons release attempt.
>
> Bye, Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

sebb-2-2
In reply to this post by Thomas Vandahl
On 25 October 2016 at 20:06, Thomas Vandahl <[hidden email]> wrote:
> Hi Benedikt,
>
> On 24.10.16 08:34, Benedikt Ritter wrote:
>> Sorry, if that has been decided, I must have missed it. I'll take another
>> look tonight.
>
> Could you please reconsider your vote? I fixed the check sums so give it
> one more chance!

Reminder: releases cannot be vetoed [1]
They pass if there are at least 3 +1 and more +1 than -1.

However the RM should always take note of any -1 votes.
It would be better if the -1 were formally withdrawn, but IMO that's
not strictly necessary since you have addressed the issue.

However I have just noticed that the dist folder also contains a copy
of the site:

commons-jcs-site-2.0-beta-2.tar.gz

That does not belong on the ASF mirrors and should be removed before
publication.

[1] http://www.apache.org/foundation/voting.html#ReleaseVotes

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Benedikt Ritter-4
Hello Sebastian,

sebb <[hidden email]> schrieb am Mi., 26. Okt. 2016 um 00:25 Uhr:

> On 25 October 2016 at 20:06, Thomas Vandahl <[hidden email]> wrote:
> > Hi Benedikt,
> >
> > On 24.10.16 08:34, Benedikt Ritter wrote:
> >> Sorry, if that has been decided, I must have missed it. I'll take
> another
> >> look tonight.
> >
> > Could you please reconsider your vote? I fixed the check sums so give it
> > one more chance!
>
> Reminder: releases cannot be vetoed [1]
> They pass if there are at least 3 +1 and more +1 than -1.
>
> However the RM should always take note of any -1 votes.
> It would be better if the -1 were formally withdrawn, but IMO that's
> not strictly necessary since you have addressed the issue.
>
> However I have just noticed that the dist folder also contains a copy
> of the site:
>
> commons-jcs-site-2.0-beta-2.tar.gz
>
> That does not belong on the ASF mirrors and should be removed before
> publication.
>

You tend to join into discussions about RCs but I seldom see you cast a
vote. What is your assessment of this RC?

BR,
Benedikt


>
> [1] http://www.apache.org/foundation/voting.html#ReleaseVotes
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Benedikt Ritter-4
In reply to this post by Thomas Vandahl
Hello Thomas,

Thomas Vandahl <[hidden email]> schrieb am Di., 25. Okt. 2016 um 21:06 Uhr:

> Hi Benedikt,
>
> On 24.10.16 08:34, Benedikt Ritter wrote:
> > Sorry, if that has been decided, I must have missed it. I'll take another
> > look tonight.
>
> Could you please reconsider your vote? I fixed the check sums so give it
> one more chance!
>

I'm taking a look right now. Sorry for the delay.

Benedikt


>
> Bye, Thomas
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Thomas Vandahl
In reply to this post by sebb-2-2
> Am 26.10.2016 um 00:19 schrieb sebb <[hidden email]>:
> Reminder: releases cannot be vetoed [1]
> They pass if there are at least 3 +1 and more +1 than -1.
>
You're technically right, however -1 votes tend to keep others from voting.

We could need your vote, too.  

> However I have just noticed that the dist folder also contains a copy
> of the site:
>
> commons-jcs-site-2.0-beta-2.tar.gz
>
> That does not belong on the ASF mirrors and should be removed before
> publication.
Those files used to be provided on people.a.o and I didn't know where to put them now. Then I saw the location dev/dist which seemed to be the perfect place for artifacts to be voted on.

Is it really necessary that this area is an exact copy of the actual dist directory? Where can I find some docs about this? I never intended to leave it at that.

Bye, Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Thomas Vandahl
In reply to this post by Oliver Heger-3
Am 25.10.2016 um 21:38 schrieb Oliver Heger <[hidden email]>:
> when building on Windows 10 with Java 1.6 I get the error below. The
> build with Java 1.8 is successful.
>
> On the distributions, I found some problems:
> - Both the source and the binary distribution deflate in the same
> folder. Typically, different folders are used.
They should not overwrite anything important, though.

> - The binary distribution does not only contain the jars but also all
> hashes and checksums. I don't think that they are required.
Yes, this happens when the assembly plugin builds from modules. I found this a good idea, actually. Don't you?
>
> Is a site available for review?
The site is available as tar.gz in the dist area.
>
> One question regarding the beta status of the release: Are the artifacts
> going to be deployed to Maven central?
Yes.

> Then there should be a special
> handling of breaking changes (special maven coordinates and package
> names indicating beta status). Otherwise, it would be good if the
> release notes contained a corresponding hint.
Ok. What would be required? We didn't do anything like that when releasing beta-1.

> [ERROR] Failed to execute goal

This looks like a dependency is compiled with 1.7. I'll look into it.

Bye, Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Benedikt Ritter-4
In reply to this post by Thomas Vandahl
Hello Thomas,

Thomas Vandahl <[hidden email]> schrieb am Fr., 21. Okt. 2016 um 19:42 Uhr:

> I would like to beta-release the [jcs] component.
>
> Apache Commons JCS 2.0-beta-2 RC1 is available for review at:
>   https://dist.apache.org/repos/dist/dev/commons/jcs/ (r16621).
>
> Maven artifacts are at:
>   https://repository.apache.org/content/repositories/orgapachecommons-1211
> .
>
> The Subversion tag is:
>
>
> https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.0-beta-2
>  (r1766068).
>
> The release notes are at:
>
>
> https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.0-beta-2/RELEASE-NOTES.txt
> (r1766068).
>
> Please review the release candidate and vote.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Please be lenient with me as this is my first Commons release attempt.
>

Thank you for preparing your first RC for commons. Here is my assessment:

- signs and hashes look good
- builds from sources Java 7 + Java 8 on Maven 3.3.9 on Mac OS 10.11.6
- build fails with Java 6 with Maven 3.2.5, here is the build log [1]. It
looks like the tomcat dependency used in the extras module requires Java 7.
- Where is the RC website?
- release notes looks good (although release notes don't need a license
header)
- the maven repository contains the src and binary archives. We usually
remove them from the staging area before closing the staging repo. Not a
problem for me.

I have discovered one problem. The release tag and the source archive have
differing contents:

> diff -wqr commons-jcs-dist-2.0-beta-2 TAG
Only in TAG: .gitignore
Only in TAG: .svn
Only in commons-jcs-dist-2.0-beta-2/: LICENSE
Only in TAG: LICENSE.txt
Only in commons-jcs-dist-2.0-beta-2/: NOTICE
Only in TAG: NOTICE.txt
Only in TAG: auxiliary-builds
Only in TAG: checkstyle.xml
Only in commons-jcs-dist-2.0-beta-2/commons-jcs-jcache-extras: tomcat.0
Only in commons-jcs-dist-2.0-beta-2/commons-jcs-jcache-openjpa: derby.log
Only in TAG: commons-jcs-sandbox
Only in TAG: init-git-svn.sh
Only in TAG: jcache-fast.sh
Only in TAG: maven-eclipse-codestyle.xml

To me it looks like the assembly build is missing some entries for build
files and shell scripts. Further more it seems like some temp files have
been included in the source release: tomcat.0 and derby.log. I'm not sure
about the NOTICE and LICENSE files. It looks like they have just been
relocated in the source release. Nevertheless, I think the missing build
files and the temp files need to be fixed in the source release.

For this reason and the build failure on Java 6:

-1

Please don't be discouraged by this. Remember that I had to create like 20
RCs for BCEL 6.0. But in the end we managed to release that thing :-)

Regards and thank you!
Benedikt

[1] https://paste.apache.org/41di


>
> Bye, Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

Romain Manni-Bucau
2016-10-26 21:35 GMT+02:00 Benedikt Ritter <[hidden email]>:

> Hello Thomas,
>
> Thomas Vandahl <[hidden email]> schrieb am Fr., 21. Okt. 2016 um 19:42 Uhr:
>
> > I would like to beta-release the [jcs] component.
> >
> > Apache Commons JCS 2.0-beta-2 RC1 is available for review at:
> >   https://dist.apache.org/repos/dist/dev/commons/jcs/ (r16621).
> >
> > Maven artifacts are at:
> >   https://repository.apache.org/content/repositories/
> orgapachecommons-1211
> > .
> >
> > The Subversion tag is:
> >
> >
> > https://svn.apache.org/repos/asf/commons/proper/jcs/tags/
> commons-jcs-2.0-beta-2
> >  (r1766068).
> >
> > The release notes are at:
> >
> >
> > https://svn.apache.org/repos/asf/commons/proper/jcs/tags/
> commons-jcs-2.0-beta-2/RELEASE-NOTES.txt
> > (r1766068).
> >
> > Please review the release candidate and vote.
> >
> >   [ ] +1 Release these artifacts
> >   [ ] +0 OK, but...
> >   [ ] -0 OK, but really should fix...
> >   [ ] -1 I oppose this release because...
> >
> > Please be lenient with me as this is my first Commons release attempt.
> >
>
> Thank you for preparing your first RC for commons. Here is my assessment:
>
> - signs and hashes look good
> - builds from sources Java 7 + Java 8 on Maven 3.3.9 on Mac OS 10.11.6
> - build fails with Java 6 with Maven 3.2.5, here is the build log [1]. It
> looks like the tomcat dependency used in the extras module requires Java 7.
>

Yes Tomcat requires Java 7 - as well as jcache strictly speaking.

Doesn't look like a blocker since the build already requires to build with
java >= 7.


> - Where is the RC website?
> - release notes looks good (although release notes don't need a license
> header)
> - the maven repository contains the src and binary archives. We usually
> remove them from the staging area before closing the staging repo. Not a
> problem for me.
>
> I have discovered one problem. The release tag and the source archive have
> differing contents:
>
> > diff -wqr commons-jcs-dist-2.0-beta-2 TAG
> Only in TAG: .gitignore
> Only in TAG: .svn
> Only in commons-jcs-dist-2.0-beta-2/: LICENSE
> Only in TAG: LICENSE.txt
> Only in commons-jcs-dist-2.0-beta-2/: NOTICE
> Only in TAG: NOTICE.txt
> Only in TAG: auxiliary-builds
> Only in TAG: checkstyle.xml
> Only in commons-jcs-dist-2.0-beta-2/commons-jcs-jcache-extras: tomcat.0
> Only in commons-jcs-dist-2.0-beta-2/commons-jcs-jcache-openjpa: derby.log
> Only in TAG: commons-jcs-sandbox
> Only in TAG: init-git-svn.sh
> Only in TAG: jcache-fast.sh
> Only in TAG: maven-eclipse-codestyle.xml
>
> To me it looks like the assembly build is missing some entries for build
> files and shell scripts. Further more it seems like some temp files have
> been included in the source release: tomcat.0 and derby.log. I'm not sure
> about the NOTICE and LICENSE files. It looks like they have just been
> relocated in the source release. Nevertheless, I think the missing build
> files and the temp files need to be fixed in the source release.
>
> For this reason and the build failure on Java 6:
>
> -1
>
> Please don't be discouraged by this. Remember that I had to create like 20
> RCs for BCEL 6.0. But in the end we managed to release that thing :-)
>
> Regards and thank you!
> Benedikt
>
> [1] https://paste.apache.org/41di
>
>
> >
> > Bye, Thomas
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >
>
12