[VOTE] Release Apache Commons JCS 2.2.1 based on RC4

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Commons JCS 2.2.1 based on RC4

Thomas Vandahl
I would like to make another attempt to release Apache Commons JCS 2.2.1
(a bugfix release)

Apache Commons JCS 2.2.1 RC4 is available for review here:

https://dist.apache.org/repos/dist/dev/commons/jcs/ (svn revision 28918)

The SVN tag commons-jcs-2.2.1-RC4 commit for this RC4 is here:

https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.2.1-RC4
(r1838700)

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1373

I have built and tested this using:

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T20:33:14+02:00)
Maven home: /Users/thomas/Dev/apache-maven-3.5.4
Java version: 1.8.0_144, vendor: Oracle Corporation, runtime:
/Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac"

Details of changes since 2.2 are in the release notes:

https://dist.apache.org/repos/dist/dev/commons/jcs/RELEASE-NOTES.txt

https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/changes-report.html

Site:
https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/

CLIRR Report (compared to 2.2):

https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/commons-jcs-core/clirr-report.html

RAT Report:

https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/commons-jcs-core/rat-report.html

KEYS:
https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Bye, Thomas.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.2.1 based on RC4

Thomas Vandahl
On 23.08.18 17:32, Thomas Vandahl wrote:
> I would like to make another attempt to release Apache Commons JCS 2.2.1
> (a bugfix release)
>
> Apache Commons JCS 2.2.1 RC4 is available for review here:

>   [X] +1 Release these artifacts

Bye, Thomas


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.2.1 based on RC4

Romain Manni-Bucau
+1, thanks

Le jeu. 23 août 2018 20:07, Thomas Vandahl <[hidden email]> a écrit :

> On 23.08.18 17:32, Thomas Vandahl wrote:
> > I would like to make another attempt to release Apache Commons JCS 2.2.1
> > (a bugfix release)
> >
> > Apache Commons JCS 2.2.1 RC4 is available for review here:
>
> >   [X] +1 Release these artifacts
>
> Bye, Thomas
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.2.1 based on RC4

Benedikt Ritter-4
In reply to this post by Thomas Vandahl
Hi,

- sigs and hashes are good
- builds fine with maven 3.5.4 from src distribution
- website looks good
- release notes look good
- there are some differences between the src distribution and release tag:

~/w/a/r/r/t/jcs git:(upstream ⚡ master) > diff -r commons-jcs-2.2.1-RC4/
commons-jcs-2.2.1-src
Only in commons-jcs-2.2.1-RC4/: .gitignore
Only in commons-jcs-2.2.1-RC4/: .svn
Only in commons-jcs-2.2.1-RC4/: .travis.yml
Only in commons-jcs-2.2.1-src: LICENSE
Only in commons-jcs-2.2.1-RC4/: LICENSE.txt
Only in commons-jcs-2.2.1-src: NOTICE
Only in commons-jcs-2.2.1-RC4/: NOTICE.txt
Only in commons-jcs-2.2.1-RC4/: auxiliary-builds
Only in commons-jcs-2.2.1-RC4/: checkstyle.xml
Only in commons-jcs-2.2.1-RC4/: commons-jcs-sandbox
Only in commons-jcs-2.2.1-RC4/: init-git-svn.sh
Only in commons-jcs-2.2.1-RC4/: jcache-fast.sh
Only in commons-jcs-2.2.1-RC4/: maven-eclipse-codestyle.xml

This should be fixed for the next release.

+1

Regards,
Benedikt

Am Do., 23. Aug. 2018 um 17:32 Uhr schrieb Thomas Vandahl <[hidden email]>:

> I would like to make another attempt to release Apache Commons JCS 2.2.1
> (a bugfix release)
>
> Apache Commons JCS 2.2.1 RC4 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/ (svn revision 28918)
>
> The SVN tag commons-jcs-2.2.1-RC4 commit for this RC4 is here:
>
>
> https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.2.1-RC4
> (r1838700
> <https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.2.1-RC4(r1838700>
> )
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1373
>
> I have built and tested this using:
>
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T20:33:14+02:00)
> Maven home: /Users/thomas/Dev/apache-maven-3.5.4
> Java version: 1.8.0_144, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac"
>
> Details of changes since 2.2 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/RELEASE-NOTES.txt
>
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/changes-report.html
>
> Site:
> https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/
>
> CLIRR Report (compared to 2.2):
>
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/commons-jcs-core/clirr-report.html
>
> RAT Report:
>
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/commons-jcs-core/rat-report.html
>
> KEYS:
> https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Bye, Thomas.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.2.1 based on RC4

sebb-2-2
On 27 August 2018 at 17:12, Benedikt Ritter <[hidden email]> wrote:

> Hi,
>
> - sigs and hashes are good
> - builds fine with maven 3.5.4 from src distribution
> - website looks good
> - release notes look good
> - there are some differences between the src distribution and release tag:
>
> ~/w/a/r/r/t/jcs git:(upstream ⚡ master) > diff -r commons-jcs-2.2.1-RC4/
> commons-jcs-2.2.1-src
> Only in commons-jcs-2.2.1-RC4/: .gitignore
> Only in commons-jcs-2.2.1-RC4/: .svn

I don't think that can be fixed.

> Only in commons-jcs-2.2.1-RC4/: .travis.yml
> Only in commons-jcs-2.2.1-src: LICENSE
> Only in commons-jcs-2.2.1-RC4/: LICENSE.txt
> Only in commons-jcs-2.2.1-src: NOTICE
> Only in commons-jcs-2.2.1-RC4/: NOTICE.txt
> Only in commons-jcs-2.2.1-RC4/: auxiliary-builds
> Only in commons-jcs-2.2.1-RC4/: checkstyle.xml
> Only in commons-jcs-2.2.1-RC4/: commons-jcs-sandbox
> Only in commons-jcs-2.2.1-RC4/: init-git-svn.sh
> Only in commons-jcs-2.2.1-RC4/: jcache-fast.sh
> Only in commons-jcs-2.2.1-RC4/: maven-eclipse-codestyle.xml
>
> This should be fixed for the next release.

I agree the rest should be fixed.

> +1
>
> Regards,
> Benedikt
>
> Am Do., 23. Aug. 2018 um 17:32 Uhr schrieb Thomas Vandahl <[hidden email]>:
>
>> I would like to make another attempt to release Apache Commons JCS 2.2.1
>> (a bugfix release)
>>
>> Apache Commons JCS 2.2.1 RC4 is available for review here:
>>
>> https://dist.apache.org/repos/dist/dev/commons/jcs/ (svn revision 28918)
>>
>> The SVN tag commons-jcs-2.2.1-RC4 commit for this RC4 is here:
>>
>>
>> https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.2.1-RC4
>> (r1838700
>> <https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.2.1-RC4(r1838700>
>> )
>>
>> Maven artifacts are here:
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1373
>>
>> I have built and tested this using:
>>
>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
>> 2018-06-17T20:33:14+02:00)
>> Maven home: /Users/thomas/Dev/apache-maven-3.5.4
>> Java version: 1.8.0_144, vendor: Oracle Corporation, runtime:
>> /Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/jre
>> Default locale: de_DE, platform encoding: UTF-8
>> OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac"
>>
>> Details of changes since 2.2 are in the release notes:
>>
>> https://dist.apache.org/repos/dist/dev/commons/jcs/RELEASE-NOTES.txt
>>
>>
>> https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/changes-report.html
>>
>> Site:
>> https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/
>>
>> CLIRR Report (compared to 2.2):
>>
>>
>> https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/commons-jcs-core/clirr-report.html
>>
>> RAT Report:
>>
>>
>> https://dist.apache.org/repos/dist/dev/commons/jcs/site-2.2.1-RC4/commons-jcs-core/rat-report.html
>>
>> KEYS:
>> https://www.apache.org/dist/commons/KEYS
>>
>> Please review the release candidate and vote.
>>
>>   [ ] +1 Release these artifacts
>>   [ ] +0 OK, but...
>>   [ ] -0 OK, but really should fix...
>>   [ ] -1 I oppose this release because...
>>
>> Bye, Thomas.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.2.1 based on RC4

Thomas Vandahl
In reply to this post by Thomas Vandahl
On 23.08.18 17:32, Thomas Vandahl wrote:
> I would like to make another attempt to release Apache Commons JCS 2.2.1
> (a bugfix release)
>
> Apache Commons JCS 2.2.1 RC4 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/ (svn revision 28918)

Could I please ask for one more review?

Bye, Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.2.1 based on RC4

Bruno P. Kinoshita-3

+1


Build passing successfully on

Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T20:58:13+13:00)
Maven home: /opt/apache-maven-3.5.2
Java version: 1.8.0_172, vendor: Oracle Corporation
Java home: /opt/jdk1.8.0_172/jre
Default locale: en_NZ, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-33-generic", arch: "amd64", family: "unix"


Minor issues in some reports, but I think they are not blockers.


Parent module's RAT report contains

1 Unknown Licenses

*****************************************************

Files with unapproved licenses:

src/scripts/zipcodes.txt

Probably we just need to add an exclusion in RAT plugin configuration.

The JCS Cache module's report has a few FindBugs issues introduced in this release, but looks like it's just related to exposing arrays in some methods. A few ununsed imports as well in PMD.

The JCS Extras module's RAT report contains

1 Unknown Licenses

*****************************************************

Files with unapproved licenses:

/home/kinow/Development/java/apache/commons-jcs-2.2.1-RC4/commons-jcs-jcache-extras/src/main/resources/META-INF/services/javax.enterprise.inject.spi.Extension


The current website has a similar warning (just different folder structure). But I believe it's just a minor issue caused by some command during the release.

Ditto the above about RAT for the JCS OpenJPA module

1 Unknown Licenses

*****************************************************

Files with unapproved licenses:

/home/kinow/Development/java/apache/commons-jcs-2.2.1-RC4/commons-jcs-jcache-openjpa/derby.log

The jcs-dist module appears in the website menu, and right now gives a 404. It doesn't appear to generate a target/site folder, so maybe in the future we can exclude it from the site menu, to prevent the 404.


Cheers
Bruno

________________________________
From: Thomas Vandahl <[hidden email]>
To: Commons Developers List <[hidden email]>
Sent: Thursday, 6 September 2018 5:06 AM
Subject: Re: [VOTE] Release Apache Commons JCS 2.2.1 based on RC4



On 23.08.18 17:32, Thomas Vandahl wrote:
> I would like to make another attempt to release Apache Commons JCS 2.2.1
> (a bugfix release)
>
> Apache Commons JCS 2.2.1 RC4 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/ (svn revision 28918)

Could I please ask for one more review?


Bye, Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.2.1 based on RC4

Thomas Vandahl
In reply to this post by Benedikt Ritter-4
On 27.08.18 18:12, Benedikt Ritter wrote:

> ~/w/a/r/r/t/jcs git:(upstream ⚡ master) > diff -r commons-jcs-2.2.1-RC4/
> commons-jcs-2.2.1-src
> Only in commons-jcs-2.2.1-RC4/: .gitignore
> Only in commons-jcs-2.2.1-RC4/: .svn
> Only in commons-jcs-2.2.1-RC4/: .travis.yml
> Only in commons-jcs-2.2.1-src: LICENSE
> Only in commons-jcs-2.2.1-RC4/: LICENSE.txt
> Only in commons-jcs-2.2.1-src: NOTICE
> Only in commons-jcs-2.2.1-RC4/: NOTICE.txt
> Only in commons-jcs-2.2.1-RC4/: auxiliary-builds
> Only in commons-jcs-2.2.1-RC4/: checkstyle.xml
> Only in commons-jcs-2.2.1-RC4/: commons-jcs-sandbox
> Only in commons-jcs-2.2.1-RC4/: init-git-svn.sh
> Only in commons-jcs-2.2.1-RC4/: jcache-fast.sh
> Only in commons-jcs-2.2.1-RC4/: maven-eclipse-codestyle.xml
>
> This should be fixed for the next release.

Is it absolutely necessary that the tag contains the exact same files as
the distribution or would it be sufficient that the tag is able to
*build* the identical distribution? That has always been my interpretation.

Bye, Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.2.1 based on RC4

sebb-2-2
On 6 September 2018 at 17:24, Thomas Vandahl <[hidden email]> wrote:

> On 27.08.18 18:12, Benedikt Ritter wrote:
>> ~/w/a/r/r/t/jcs git:(upstream ⚡ master) > diff -r commons-jcs-2.2.1-RC4/
>> commons-jcs-2.2.1-src
>> Only in commons-jcs-2.2.1-RC4/: .gitignore
>> Only in commons-jcs-2.2.1-RC4/: .svn
>> Only in commons-jcs-2.2.1-RC4/: .travis.yml
>> Only in commons-jcs-2.2.1-src: LICENSE
>> Only in commons-jcs-2.2.1-RC4/: LICENSE.txt
>> Only in commons-jcs-2.2.1-src: NOTICE
>> Only in commons-jcs-2.2.1-RC4/: NOTICE.txt
>> Only in commons-jcs-2.2.1-RC4/: auxiliary-builds
>> Only in commons-jcs-2.2.1-RC4/: checkstyle.xml
>> Only in commons-jcs-2.2.1-RC4/: commons-jcs-sandbox
>> Only in commons-jcs-2.2.1-RC4/: init-git-svn.sh
>> Only in commons-jcs-2.2.1-RC4/: jcache-fast.sh
>> Only in commons-jcs-2.2.1-RC4/: maven-eclipse-codestyle.xml
>>
>> This should be fixed for the next release.
>
> Is it absolutely necessary that the tag contains the exact same files as
> the distribution or would it be sufficient that the tag is able to
> *build* the identical distribution? That has always been my interpretation.

Reviewers need to be able to account for any discrepancies between the
contents to ensure that:
- the dist does not contain spurious files
- the dist is not lacking any required files.

The source distribution also has to be able to build itself.

If the tag contains files that are not in the distribution, why are
they present at all?
If they are needed, why are they not in the distribution?

Lots of discrepancies means lots of checking.

> Bye, Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[RESULT][VOTE] Release Apache Commons JCS 2.2.1 based on RC4

Thomas Vandahl
In reply to this post by Thomas Vandahl
On 8/23/18 5:32 PM, Thomas Vandahl wrote:
> I would like to make another attempt to release Apache Commons JCS 2.2.1
> (a bugfix release)
>
> Apache Commons JCS 2.2.1 RC4 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/ (svn revision 28918)

Time to wrap up. The following votes were cast (in order of appearance):

Thomas Vandahl: +1
Romain Manni-Bucau: +1 (non binding)
Benedikt Ritter: +1
Bruno P. Kinoshita: +1

The vote has passed. Thanks to all the voters!

I'll proceed with the release procedure.

Bye, Thomas.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons JCS 2.2.1 based on RC4

Thomas Vandahl
In reply to this post by sebb-2-2
On 9/7/18 2:11 PM, sebb wrote:
> If the tag contains files that are not in the distribution, why are
> they present at all?

Because they are experimental code, for example. Not ready for prime time.

> If they are needed, why are they not in the distribution?

They are not needed, at least not now.

> Lots of discrepancies means lots of checking.

Yes, I understand that. The clean way to handle this would probably be
to create a release branch, tidy that up and release from there.

Bye, Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]