[VOTE] Release Apache Commons Lang 3.4 based on RC1

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Commons Lang 3.4 based on RC1

Benedikt Ritter-4
Hi all,

We have fixed quite a few bugs and added some significant enhancements
since Commons Lang 3.3.2 was released, so I would like to release Commons
Lang 3.4.

Commons Lang 3.4 RC1 is available for review here:
  https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision 8466)

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1085/org/apache/commons/commons-lang3/3.4/


Details of changes since 3.3.2 are in the release notes:
  https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
  http://people.apache.org/~britter/lang-3.4-RC1/changes-report.html

I have tested this with JDK 1.6, 1.7, 1.8 and 1.9 EA using maven 3. Note
that the site build doesn't work with Java 8 and 9 due to problems with
Clirr (clirr doesn't work with Java 8+).

The tag is here:
  http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_4_RC1/
(svn 1669797)

Site:
  http://people.apache.org/~britter/lang-3.4-RC1/
  (note some *relative* links are broken and the 3.4 directories are not
yet created - these will be OK once the site is deployed)

Clirr Report (compared to 3.3.2):
  http://people.apache.org/~britter/lang-3.4-RC1/clirr-report.html

RAT Report:
  http://people.apache.org/~britter/lang-3.4-RC1/rat-report.html

KEYS:
  https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote. This vote will close no
sooner that 72 hours from now, i.e. after 17:30 CET 31-March 2015

[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...

Thanks!
Benedikt


--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

garydgregory
On Sat, Mar 28, 2015 at 9:31 AM, Benedikt Ritter <[hidden email]> wrote:

> Hi all,
>
> We have fixed quite a few bugs and added some significant enhancements
> since Commons Lang 3.3.2 was released, so I would like to release Commons
> Lang 3.4.
>
> Commons Lang 3.4 RC1 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision 8466)
>

I do not see src.zip and bin.zip files there. Are they in the middle of
being uploaded?

Gary


>
> Maven artifacts are here:
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-1085/org/apache/commons/commons-lang3/3.4/
>
>
> Details of changes since 3.3.2 are in the release notes:
>   https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
>   http://people.apache.org/~britter/lang-3.4-RC1/changes-report.html
>
> I have tested this with JDK 1.6, 1.7, 1.8 and 1.9 EA using maven 3. Note
> that the site build doesn't work with Java 8 and 9 due to problems with
> Clirr (clirr doesn't work with Java 8+).
>
> The tag is here:
>   http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_4_RC1/
> (svn 1669797)
>
> Site:
>   http://people.apache.org/~britter/lang-3.4-RC1/
>   (note some *relative* links are broken and the 3.4 directories are not
> yet created - these will be OK once the site is deployed)
>
> Clirr Report (compared to 3.3.2):
>   http://people.apache.org/~britter/lang-3.4-RC1/clirr-report.html
>
> RAT Report:
>   http://people.apache.org/~britter/lang-3.4-RC1/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote. This vote will close no
> sooner that 72 hours from now, i.e. after 17:30 CET 31-March 2015
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
> Benedikt
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>



--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

Benedikt Ritter-4
2015-03-28 17:52 GMT+01:00 Gary Gregory <[hidden email]>:

> On Sat, Mar 28, 2015 at 9:31 AM, Benedikt Ritter <[hidden email]>
> wrote:
>
> > Hi all,
> >
> > We have fixed quite a few bugs and added some significant enhancements
> > since Commons Lang 3.3.2 was released, so I would like to release Commons
> > Lang 3.4.
> >
> > Commons Lang 3.4 RC1 is available for review here:
> >   https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision
> 8466)
> >
>
> I do not see src.zip and bin.zip files there. Are they in the middle of
> being uploaded?
>

Oh crap! No, the regex I used to copy the binaries from my local maven repo
to the checked out dist area was too greedy. I've added them in r8467

Thank you!


>
> Gary
>
>
> >
> > Maven artifacts are here:
> >
> >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1085/org/apache/commons/commons-lang3/3.4/
> >
> >
> > Details of changes since 3.3.2 are in the release notes:
> >   https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
> >   http://people.apache.org/~britter/lang-3.4-RC1/changes-report.html
> >
> > I have tested this with JDK 1.6, 1.7, 1.8 and 1.9 EA using maven 3. Note
> > that the site build doesn't work with Java 8 and 9 due to problems with
> > Clirr (clirr doesn't work with Java 8+).
> >
> > The tag is here:
> >   http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_4_RC1/
> > (svn 1669797)
> >
> > Site:
> >   http://people.apache.org/~britter/lang-3.4-RC1/
> >   (note some *relative* links are broken and the 3.4 directories are not
> > yet created - these will be OK once the site is deployed)
> >
> > Clirr Report (compared to 3.3.2):
> >   http://people.apache.org/~britter/lang-3.4-RC1/clirr-report.html
> >
> > RAT Report:
> >   http://people.apache.org/~britter/lang-3.4-RC1/rat-report.html
> >
> > KEYS:
> >   https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote. This vote will close no
> > sooner that 72 hours from now, i.e. after 17:30 CET 31-March 2015
> >
> > [ ] +1 Release these artifacts
> > [ ] +0 OK, but...
> > [ ] -0 OK, but really should fix...
> > [ ] -1 I oppose this release because...
> >
> > Thanks!
> > Benedikt
> >
> >
> > --
> > http://people.apache.org/~britter/
> > http://www.systemoutprintln.de/
> > http://twitter.com/BenediktRitter
> > http://github.com/britter
> >
>
>
>
> --
> E-Mail: [hidden email] | [hidden email]
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

garydgregory
In reply to this post by Benedikt Ritter-4
With the src zip, I run 'mvn clean site' and it works but I get two stack
dumps due to slf4j being out of sync:

[INFO] Falling back to RSS for issue download: This JIRA server does not
support version 2 of the REST API, which maven-changes-plugin requires.
[WARN] An issue has occurred with maven-changes-plugin:2.11:jira-report,
skipping LinkageError
org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;Ljava/lang/Throwable;)V,
please report an issue to M
aven dev team.
java.lang.NoSuchMethodError:
org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;Ljava/lang/Throwable;)V
        at
org.apache.commons.logging.impl.SLF4JLocationAwareLog.trace(SLF4JLocationAwareLog.java:99)
        at
org.apache.commons.httpclient.methods.GetMethod.<init>(GetMethod.java:89)
        at
org.apache.maven.plugin.jira.ClassicJiraDownloader.download(ClassicJiraDownloader.java:362)
        at
org.apache.maven.plugin.jira.ClassicJiraDownloader.doExecute(ClassicJiraDownloader.java:122)
        at
org.apache.maven.plugin.jira.AdaptiveJiraDownloader.doExecute(AdaptiveJiraDownloader.java:54)
        at
org.apache.maven.plugin.jira.JiraMojo.executeReport(JiraMojo.java:372)
        at
org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:255)
        at
org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument(ReportDocumentRenderer.java:224)
        at
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:311)
        at
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:129)
        at
org.apache.maven.plugins.site.render.SiteMojo.renderLocale(SiteMojo.java:182)
        at
org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:141)
        at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
        at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
        at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
        at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
        at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:862)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:286)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:197)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
[INFO] Generating "JavaDocs" report             ---
maven-javadoc-plugin:2.10.1:javadoc

and:

[INFO] Generating "Checkstyle" report           ---
maven-checkstyle-plugin:2.15:checkstyle
[WARN] An issue has occurred with maven-checkstyle-plugin:2.15:checkstyle,
skipping LinkageError
org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;Ljava/lang/Throwable;)V,
please report an issue to
 Maven dev team.
java.lang.NoSuchMethodError:
org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;Ljava/lang/Throwable;)V
        at
org.apache.commons.logging.impl.SLF4JLocationAwareLog.trace(SLF4JLocationAwareLog.java:99)
        at
org.apache.commons.beanutils.BeanUtilsBean.copyProperty(BeanUtilsBean.java:443)
        at
com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:149)
        at
org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle(DefaultCheckstyleExecutor.java:219)
        at
org.apache.maven.plugin.checkstyle.AbstractCheckstyleReport.executeReport(AbstractCheckstyleReport.java:473)
        at
org.apache.maven.plugin.checkstyle.CheckstyleReport.executeReport(CheckstyleReport.java:155)
        at
org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:255)
        at
org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument(ReportDocumentRenderer.java:224)
        at
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:311)
        at
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:129)
        at
org.apache.maven.plugins.site.render.SiteMojo.renderLocale(SiteMojo.java:182)
        at
org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:141)
        at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
        at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
        at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
        at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
        at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:862)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:286)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:197)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
[INFO] Generating "FindBugs" report             ---
findbugs-maven-plugin:3.0.0:findbugs
[INFO] Locale is en
[INFO] Fork Value is true
     [java] Warnings generated: 10
[INFO] Done FindBugs Analysis....
[warn] [XHTML Sink] Modified invalid anchor name:
'org.apache.commons.lang3.time.FormatCache$MultipartKey' to
'org.apache.commons.lang3.time.FormatCacheMultipartKey'
[INFO] Generating "PMD" report                  --- maven-pmd-plugin:3.4:pmd
[INFO] Generating "CPD" report                  --- maven-pmd-plugin:3.4:cpd
[INFO] Generating "Tag List" report             ---
taglist-maven-plugin:2.4:taglist
[INFO] Generating "JavaNCSS Report" report      ---
javancss-maven-plugin:2.1:report
[INFO] Running JavaNCSS 33.54
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS

I run:

Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c;
2015-03-13T13:10:27-07:00)
Maven home: C:\Java\apache-maven-3.3.1
Java version: 1.7.0_75, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_75\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"

Gary

On Sat, Mar 28, 2015 at 9:31 AM, Benedikt Ritter <[hidden email]> wrote:

> Hi all,
>
> We have fixed quite a few bugs and added some significant enhancements
> since Commons Lang 3.3.2 was released, so I would like to release Commons
> Lang 3.4.
>
> Commons Lang 3.4 RC1 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision 8466)
>
> Maven artifacts are here:
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-1085/org/apache/commons/commons-lang3/3.4/
>
>
> Details of changes since 3.3.2 are in the release notes:
>   https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
>   http://people.apache.org/~britter/lang-3.4-RC1/changes-report.html
>
> I have tested this with JDK 1.6, 1.7, 1.8 and 1.9 EA using maven 3. Note
> that the site build doesn't work with Java 8 and 9 due to problems with
> Clirr (clirr doesn't work with Java 8+).
>
> The tag is here:
>   http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_4_RC1/
> (svn 1669797)
>
> Site:
>   http://people.apache.org/~britter/lang-3.4-RC1/
>   (note some *relative* links are broken and the 3.4 directories are not
> yet created - these will be OK once the site is deployed)
>
> Clirr Report (compared to 3.3.2):
>   http://people.apache.org/~britter/lang-3.4-RC1/clirr-report.html
>
> RAT Report:
>   http://people.apache.org/~britter/lang-3.4-RC1/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote. This vote will close no
> sooner that 72 hours from now, i.e. after 17:30 CET 31-March 2015
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
> Benedikt
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>



--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

garydgregory
In reply to this post by Benedikt Ritter-4
oh, and that means that no Jira changes report and no Checkstyle report is
generated.

So that's not so good because I cannot create the same site the RM did.

Gary

On Sat, Mar 28, 2015 at 10:16 AM, Benedikt Ritter <[hidden email]>
wrote:

> 2015-03-28 17:52 GMT+01:00 Gary Gregory <[hidden email]>:
>
> > On Sat, Mar 28, 2015 at 9:31 AM, Benedikt Ritter <[hidden email]>
> > wrote:
> >
> > > Hi all,
> > >
> > > We have fixed quite a few bugs and added some significant enhancements
> > > since Commons Lang 3.3.2 was released, so I would like to release
> Commons
> > > Lang 3.4.
> > >
> > > Commons Lang 3.4 RC1 is available for review here:
> > >   https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision
> > 8466)
> > >
> >
> > I do not see src.zip and bin.zip files there. Are they in the middle of
> > being uploaded?
> >
>
> Oh crap! No, the regex I used to copy the binaries from my local maven repo
> to the checked out dist area was too greedy. I've added them in r8467
>
> Thank you!
>
>
> >
> > Gary
> >
> >
> > >
> > > Maven artifacts are here:
> > >
> > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1085/org/apache/commons/commons-lang3/3.4/
> > >
> > >
> > > Details of changes since 3.3.2 are in the release notes:
> > >
> https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
> > >   http://people.apache.org/~britter/lang-3.4-RC1/changes-report.html
> > >
> > > I have tested this with JDK 1.6, 1.7, 1.8 and 1.9 EA using maven 3.
> Note
> > > that the site build doesn't work with Java 8 and 9 due to problems with
> > > Clirr (clirr doesn't work with Java 8+).
> > >
> > > The tag is here:
> > >
> http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_4_RC1/
> > > (svn 1669797)
> > >
> > > Site:
> > >   http://people.apache.org/~britter/lang-3.4-RC1/
> > >   (note some *relative* links are broken and the 3.4 directories are
> not
> > > yet created - these will be OK once the site is deployed)
> > >
> > > Clirr Report (compared to 3.3.2):
> > >   http://people.apache.org/~britter/lang-3.4-RC1/clirr-report.html
> > >
> > > RAT Report:
> > >   http://people.apache.org/~britter/lang-3.4-RC1/rat-report.html
> > >
> > > KEYS:
> > >   https://www.apache.org/dist/commons/KEYS
> > >
> > > Please review the release candidate and vote. This vote will close no
> > > sooner that 72 hours from now, i.e. after 17:30 CET 31-March 2015
> > >
> > > [ ] +1 Release these artifacts
> > > [ ] +0 OK, but...
> > > [ ] -0 OK, but really should fix...
> > > [ ] -1 I oppose this release because...
> > >
> > > Thanks!
> > > Benedikt
> > >
> > >
> > > --
> > > http://people.apache.org/~britter/
> > > http://www.systemoutprintln.de/
> > > http://twitter.com/BenediktRitter
> > > http://github.com/britter
> > >
> >
> >
> >
> > --
> > E-Mail: [hidden email] | [hidden email]
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
> >
>
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>



--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

Jörg Schaible
In reply to this post by garydgregory
Gary Gregory wrote:

[snip]
 
> Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c;
> 2015-03-13T13:10:27-07:00)
> Maven home: C:\Java\apache-maven-3.3.1
> Java version: 1.7.0_75, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_75\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"

Use Maven 3.2.x ... ;-)

Known problem with M 3.3.1

Cheers,
Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

garydgregory
In reply to this post by Benedikt Ritter-4
+1

MD5, SHA1, ASC Ok.

Site builds Ok with:

Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1;
2014-12-14T09:29:23-08:00)
Maven home: C:\Java\apache-maven-3.2.5
Java version: 1.7.0_75, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_75\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"

but not:

Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c;
2015-03-13T13:10:27-07:00)Maven home: C:\Java\apache-maven-3.3.1
Java version: 1.7.0_75, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_75\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"

due to a slf4j version problem in the JIRA report and Checkstyle report.

Gary

On Sat, Mar 28, 2015 at 9:31 AM, Benedikt Ritter <[hidden email]> wrote:

> Hi all,
>
> We have fixed quite a few bugs and added some significant enhancements
> since Commons Lang 3.3.2 was released, so I would like to release Commons
> Lang 3.4.
>
> Commons Lang 3.4 RC1 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision 8466)
>
> Maven artifacts are here:
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-1085/org/apache/commons/commons-lang3/3.4/
>
>
> Details of changes since 3.3.2 are in the release notes:
>   https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
>   http://people.apache.org/~britter/lang-3.4-RC1/changes-report.html
>
> I have tested this with JDK 1.6, 1.7, 1.8 and 1.9 EA using maven 3. Note
> that the site build doesn't work with Java 8 and 9 due to problems with
> Clirr (clirr doesn't work with Java 8+).
>
> The tag is here:
>   http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_4_RC1/
> (svn 1669797)
>
> Site:
>   http://people.apache.org/~britter/lang-3.4-RC1/
>   (note some *relative* links are broken and the 3.4 directories are not
> yet created - these will be OK once the site is deployed)
>
> Clirr Report (compared to 3.3.2):
>   http://people.apache.org/~britter/lang-3.4-RC1/clirr-report.html
>
> RAT Report:
>   http://people.apache.org/~britter/lang-3.4-RC1/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote. This vote will close no
> sooner that 72 hours from now, i.e. after 17:30 CET 31-March 2015
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
> Benedikt
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>



--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

Sergio Fernández
In reply to this post by Benedikt Ritter-4
+1 (non-binding)

So far I checked: signatures and digests, NOTICE and LICENSE files,
clean build (debian linux 64 bits, java 1.8.0_25).

On 28/03/15 18:16, Benedikt Ritter wrote:

> 2015-03-28 17:52 GMT+01:00 Gary Gregory <[hidden email]>:
>
>> On Sat, Mar 28, 2015 at 9:31 AM, Benedikt Ritter <[hidden email]>
>> wrote:
>>
>>> Hi all,
>>>
>>> We have fixed quite a few bugs and added some significant enhancements
>>> since Commons Lang 3.3.2 was released, so I would like to release Commons
>>> Lang 3.4.
>>>
>>> Commons Lang 3.4 RC1 is available for review here:
>>>    https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision
>> 8466)
>>>
>>
>> I do not see src.zip and bin.zip files there. Are they in the middle of
>> being uploaded?
>>
>
> Oh crap! No, the regex I used to copy the binaries from my local maven repo
> to the checked out dist area was too greedy. I've added them in r8467
>
> Thank you!
>
>
>>
>> Gary
>>
>>
>>>
>>> Maven artifacts are here:
>>>
>>>
>>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1085/org/apache/commons/commons-lang3/3.4/
>>>
>>>
>>> Details of changes since 3.3.2 are in the release notes:
>>>    https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
>>>    http://people.apache.org/~britter/lang-3.4-RC1/changes-report.html
>>>
>>> I have tested this with JDK 1.6, 1.7, 1.8 and 1.9 EA using maven 3. Note
>>> that the site build doesn't work with Java 8 and 9 due to problems with
>>> Clirr (clirr doesn't work with Java 8+).
>>>
>>> The tag is here:
>>>    http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_4_RC1/
>>> (svn 1669797)
>>>
>>> Site:
>>>    http://people.apache.org/~britter/lang-3.4-RC1/
>>>    (note some *relative* links are broken and the 3.4 directories are not
>>> yet created - these will be OK once the site is deployed)
>>>
>>> Clirr Report (compared to 3.3.2):
>>>    http://people.apache.org/~britter/lang-3.4-RC1/clirr-report.html
>>>
>>> RAT Report:
>>>    http://people.apache.org/~britter/lang-3.4-RC1/rat-report.html
>>>
>>> KEYS:
>>>    https://www.apache.org/dist/commons/KEYS
>>>
>>> Please review the release candidate and vote. This vote will close no
>>> sooner that 72 hours from now, i.e. after 17:30 CET 31-March 2015
>>>
>>> [ ] +1 Release these artifacts
>>> [ ] +0 OK, but...
>>> [ ] -0 OK, but really should fix...
>>> [ ] -1 I oppose this release because...
>>>
>>> Thanks!
>>> Benedikt
>>>
>>>
>>> --
>>> http://people.apache.org/~britter/
>>> http://www.systemoutprintln.de/
>>> http://twitter.com/BenediktRitter
>>> http://github.com/britter
>>>
>>
>>
>>
>> --
>> E-Mail: [hidden email] | [hidden email]
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>

--
Sergio Fernández
Partner Technology Manager
Redlink GmbH
m: +43 660 2747 925
e: [hidden email]
w: http://redlink.co

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

Bruno P. Kinoshita
In reply to this post by Benedikt Ritter-4
Hi,

+0 non binding,

Build works fine with Java 7 and Maven 3.2

Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T15:29:23-02:00)
Maven home: /opt/apache-maven-3.2.5
Java version: 1.7.0_76, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-7-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.16.0-33-generic", arch: "amd64", family: "unix"

The following test failed though:

org.apache.commons.lang3.time.FastDateFormat_ParserTest:
java.lang.AssertionError: ms_MY Sat Feb 10 01:53:32 BRT 1900 GGGG/yyyy/MMMM/dddd/hhhh/mmmm/ss/aaaa/EEEE/ZZZZ America/New_York expected:<Sat Feb 10 01:53:32 BRT 1900> but was:<Sat Feb 10 01:53:04 BRT 1900>

Build fails with Java 8 and Maven 3.2. Same test fails.

Failed tests:
  FastDateFormat_ParserTest>FastDateParserTest.testParses:250->FastDateParserTest.validateSdfFormatFdpParseEquality:227  Sat Feb 10 01:53:32 BRT 1900 GGGG/yyyy/MMMM/dddd/hhhh/mmmm/ss/aaaa/EEEE/ZZZZ America/New_York expected:<Sat Feb 10 01:53:32 BRT 1900> but was:<Sat Feb 10 01:53:04 BRT 1900>

Complete log available at:

Used the following command to build the project: MAVEN_OPTS="-Xmx2048m -XX:MaxPermSize=128m" JAVA_HOME=/usr/lib/jvm/java-{7,8}-oracle/ mvn clean site:site -e -X
The Java 8 build error might be something in my Maven repository. Will try building it again in Java 8 and investigate the issue later. My time zone is set to America/Sao_Paulo, GMT -3, and I suspect that that failing test is in someway related to my time zone.

CheersBruno

      From: Benedikt Ritter <[hidden email]>
 To: Commons Developers List <[hidden email]>
 Sent: Saturday, March 28, 2015 1:31 PM
 Subject: [VOTE] Release Apache Commons Lang 3.4 based on RC1
   
Hi all,

We have fixed quite a few bugs and added some significant enhancements
since Commons Lang 3.3.2 was released, so I would like to release Commons
Lang 3.4.

Commons Lang 3.4 RC1 is available for review here:
  https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision 8466)

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1085/org/apache/commons/commons-lang3/3.4/


Details of changes since 3.3.2 are in the release notes:
  https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
  http://people.apache.org/~britter/lang-3.4-RC1/changes-report.html

I have tested this with JDK 1.6, 1.7, 1.8 and 1.9 EA using maven 3. Note
that the site build doesn't work with Java 8 and 9 due to problems with
Clirr (clirr doesn't work with Java 8+).

The tag is here:
  http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_4_RC1/
(svn 1669797)

Site:
  http://people.apache.org/~britter/lang-3.4-RC1/
  (note some *relative* links are broken and the 3.4 directories are not
yet created - these will be OK once the site is deployed)

Clirr Report (compared to 3.3.2):
  http://people.apache.org/~britter/lang-3.4-RC1/clirr-report.html

RAT Report:
  http://people.apache.org/~britter/lang-3.4-RC1/rat-report.html

KEYS:
  https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote. This vote will close no
sooner that 72 hours from now, i.e. after 17:30 CET 31-March 2015

[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...

Thanks!
Benedikt


--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter


   
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

Bruno P. Kinoshita
> Complete log available at:
Sorry, forgot to include the log for the Java 8 build: https://paste.apache.org/aBg0

Unfortunately I couldn't paste the complete log without my browser crashing.

Cheers,Bruno

 
      From: Bruno P. Kinoshita <[hidden email]>
 To: Commons Developers List <[hidden email]>
 Sent: Sunday, March 29, 2015 2:50 PM
 Subject: Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1
   
Hi,

+0 non binding,

Build works fine with Java 7 and Maven 3.2

Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T15:29:23-02:00)
Maven home: /opt/apache-maven-3.2.5
Java version: 1.7.0_76, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-7-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.16.0-33-generic", arch: "amd64", family: "unix"

The following test failed though:

org.apache.commons.lang3.time.FastDateFormat_ParserTest:
java.lang.AssertionError: ms_MY Sat Feb 10 01:53:32 BRT 1900 GGGG/yyyy/MMMM/dddd/hhhh/mmmm/ss/aaaa/EEEE/ZZZZ America/New_York expected:<Sat Feb 10 01:53:32 BRT 1900> but was:<Sat Feb 10 01:53:04 BRT 1900>

Build fails with Java 8 and Maven 3.2. Same test fails.

Failed tests:
  FastDateFormat_ParserTest>FastDateParserTest.testParses:250->FastDateParserTest.validateSdfFormatFdpParseEquality:227  Sat Feb 10 01:53:32 BRT 1900 GGGG/yyyy/MMMM/dddd/hhhh/mmmm/ss/aaaa/EEEE/ZZZZ America/New_York expected:<Sat Feb 10 01:53:32 BRT 1900> but was:<Sat Feb 10 01:53:04 BRT 1900>

Complete log available at:

Used the following command to build the project: MAVEN_OPTS="-Xmx2048m -XX:MaxPermSize=128m" JAVA_HOME=/usr/lib/jvm/java-{7,8}-oracle/ mvn clean site:site -e -X
The Java 8 build error might be something in my Maven repository. Will try building it again in Java 8 and investigate the issue later. My time zone is set to America/Sao_Paulo, GMT -3, and I suspect that that failing test is in someway related to my time zone.

CheersBruno



      From: Benedikt Ritter <[hidden email]>
 To: Commons Developers List <[hidden email]>
 Sent: Saturday, March 28, 2015 1:31 PM
 Subject: [VOTE] Release Apache Commons Lang 3.4 based on RC1
   
Hi all,

We have fixed quite a few bugs and added some significant enhancements
since Commons Lang 3.3.2 was released, so I would like to release Commons
Lang 3.4.

Commons Lang 3.4 RC1 is available for review here:
  https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision 8466)

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1085/org/apache/commons/commons-lang3/3.4/


Details of changes since 3.3.2 are in the release notes:
  https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
  http://people.apache.org/~britter/lang-3.4-RC1/changes-report.html

I have tested this with JDK 1.6, 1.7, 1.8 and 1.9 EA using maven 3. Note
that the site build doesn't work with Java 8 and 9 due to problems with
Clirr (clirr doesn't work with Java 8+).

The tag is here:
  http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_4_RC1/
(svn 1669797)

Site:
  http://people.apache.org/~britter/lang-3.4-RC1/
  (note some *relative* links are broken and the 3.4 directories are not
yet created - these will be OK once the site is deployed)

Clirr Report (compared to 3.3.2):
  http://people.apache.org/~britter/lang-3.4-RC1/clirr-report.html

RAT Report:
  http://people.apache.org/~britter/lang-3.4-RC1/rat-report.html

KEYS:
  https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote. This vote will close no
sooner that 72 hours from now, i.e. after 17:30 CET 31-March 2015

[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...

Thanks!
Benedikt


--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter


   
 

   
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

Benedikt Ritter-3
Oh my god, I hate the time package so much... :)

B

Send from my mobile device

Am 29.03.2015 um 20:00 schrieb Bruno P. Kinoshita <[hidden email]>:

>> Complete log available at:
> Sorry, forgot to include the log for the Java 8 build: https://paste.apache.org/aBg0
>
> Unfortunately I couldn't paste the complete log without my browser crashing.
>
> Cheers,Bruno
>
>
>      From: Bruno P. Kinoshita <[hidden email]>
> To: Commons Developers List <[hidden email]>
> Sent: Sunday, March 29, 2015 2:50 PM
> Subject: Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1
>
> Hi,
>
> +0 non binding,
>
> Build works fine with Java 7 and Maven 3.2
>
> Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T15:29:23-02:00)
> Maven home: /opt/apache-maven-3.2.5
> Java version: 1.7.0_76, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-7-oracle/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.16.0-33-generic", arch: "amd64", family: "unix"
>
> The following test failed though:
>
> org.apache.commons.lang3.time.FastDateFormat_ParserTest:
> java.lang.AssertionError: ms_MY Sat Feb 10 01:53:32 BRT 1900 GGGG/yyyy/MMMM/dddd/hhhh/mmmm/ss/aaaa/EEEE/ZZZZ America/New_York expected:<Sat Feb 10 01:53:32 BRT 1900> but was:<Sat Feb 10 01:53:04 BRT 1900>
>
> Build fails with Java 8 and Maven 3.2. Same test fails.
>
> Failed tests:
>   FastDateFormat_ParserTest>FastDateParserTest.testParses:250->FastDateParserTest.validateSdfFormatFdpParseEquality:227  Sat Feb 10 01:53:32 BRT 1900 GGGG/yyyy/MMMM/dddd/hhhh/mmmm/ss/aaaa/EEEE/ZZZZ America/New_York expected:<Sat Feb 10 01:53:32 BRT 1900> but was:<Sat Feb 10 01:53:04 BRT 1900>
>
> Complete log available at:
>
> Used the following command to build the project: MAVEN_OPTS="-Xmx2048m -XX:MaxPermSize=128m" JAVA_HOME=/usr/lib/jvm/java-{7,8}-oracle/ mvn clean site:site -e -X
> The Java 8 build error might be something in my Maven repository. Will try building it again in Java 8 and investigate the issue later. My time zone is set to America/Sao_Paulo, GMT -3, and I suspect that that failing test is in someway related to my time zone.
>
> CheersBruno
>
>
>
>      From: Benedikt Ritter <[hidden email]>
> To: Commons Developers List <[hidden email]>
> Sent: Saturday, March 28, 2015 1:31 PM
> Subject: [VOTE] Release Apache Commons Lang 3.4 based on RC1
>
> Hi all,
>
> We have fixed quite a few bugs and added some significant enhancements
> since Commons Lang 3.3.2 was released, so I would like to release Commons
> Lang 3.4.
>
> Commons Lang 3.4 RC1 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision 8466)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1085/org/apache/commons/commons-lang3/3.4/
>
>
> Details of changes since 3.3.2 are in the release notes:
>   https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
>   http://people.apache.org/~britter/lang-3.4-RC1/changes-report.html
>
> I have tested this with JDK 1.6, 1.7, 1.8 and 1.9 EA using maven 3. Note
> that the site build doesn't work with Java 8 and 9 due to problems with
> Clirr (clirr doesn't work with Java 8+).
>
> The tag is here:
>   http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_4_RC1/
> (svn 1669797)
>
> Site:
>   http://people.apache.org/~britter/lang-3.4-RC1/
>   (note some *relative* links are broken and the 3.4 directories are not
> yet created - these will be OK once the site is deployed)
>
> Clirr Report (compared to 3.3.2):
>   http://people.apache.org/~britter/lang-3.4-RC1/clirr-report.html
>
> RAT Report:
>   http://people.apache.org/~britter/lang-3.4-RC1/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote. This vote will close no
> sooner that 72 hours from now, i.e. after 17:30 CET 31-March 2015
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
> Benedikt
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>
>
>
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

Oliver Heger-3
In reply to this post by Benedikt Ritter-4
Hi,

Maven build was successful on Windows 8.1 with Java 1.6 and 1.7.
Artifacts and site look good.

Nits/questions:
- The surefire report says that 97 tests are skipped. This seems to be a
large number.
- Clirr has a warning about a changed constant. Does this have to be
mentioned in release notes?
- The ant build does not seem to work. With an adapted build.properties
file I get compile errors like the one below. The referenced hamcrest
library indeed does not have a class org.hamcrest.Matchers.

    [javac]
C:\data\dev\projects\OpenSource\lang\commons-lang3-3.4-src\src\test\
java\org\apache\commons\lang3\reflect\MethodUtilsTest.java:19: error:
cannot fin
d symbol
    [javac] import static org.hamcrest.Matchers.hasItemInArray;
    [javac]                           ^
    [javac]   symbol:   class Matchers
    [javac]   location: package org.hamcrest

This is not blocking, so +1 for this release.

Oliver

Am 28.03.2015 um 17:31 schrieb Benedikt Ritter:

> Hi all,
>
> We have fixed quite a few bugs and added some significant enhancements
> since Commons Lang 3.3.2 was released, so I would like to release Commons
> Lang 3.4.
>
> Commons Lang 3.4 RC1 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision 8466)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1085/org/apache/commons/commons-lang3/3.4/
>
>
> Details of changes since 3.3.2 are in the release notes:
>   https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
>   http://people.apache.org/~britter/lang-3.4-RC1/changes-report.html
>
> I have tested this with JDK 1.6, 1.7, 1.8 and 1.9 EA using maven 3. Note
> that the site build doesn't work with Java 8 and 9 due to problems with
> Clirr (clirr doesn't work with Java 8+).
>
> The tag is here:
>   http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_4_RC1/
> (svn 1669797)
>
> Site:
>   http://people.apache.org/~britter/lang-3.4-RC1/
>   (note some *relative* links are broken and the 3.4 directories are not
> yet created - these will be OK once the site is deployed)
>
> Clirr Report (compared to 3.3.2):
>   http://people.apache.org/~britter/lang-3.4-RC1/clirr-report.html
>
> RAT Report:
>   http://people.apache.org/~britter/lang-3.4-RC1/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote. This vote will close no
> sooner that 72 hours from now, i.e. after 17:30 CET 31-March 2015
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
> Benedikt
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC1

Jörg Schaible
In reply to this post by Benedikt Ritter-4
Benedikt Ritter wrote:

> Hi all,
>
> We have fixed quite a few bugs and added some significant enhancements
> since Commons Lang 3.3.2 was released, so I would like to release Commons
> Lang 3.4.
>
> Commons Lang 3.4 RC1 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/lang/ (svn revision 8466)
>
> Maven artifacts are here:
>
>
https://repository.apache.org/content/repositories/orgapachecommons-1085/org/apache/commons/commons-lang3/3.4/

>
>
> Details of changes since 3.3.2 are in the release notes:
>   https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt
>   http://people.apache.org/~britter/lang-3.4-RC1/changes-report.html
>
> I have tested this with JDK 1.6, 1.7, 1.8 and 1.9 EA using maven 3. Note
> that the site build doesn't work with Java 8 and 9 due to problems with
> Clirr (clirr doesn't work with Java 8+).
>
> The tag is here:
>   http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_4_RC1/
> (svn 1669797)
>
> Site:
>   http://people.apache.org/~britter/lang-3.4-RC1/
>   (note some *relative* links are broken and the 3.4 directories are not
> yet created - these will be OK once the site is deployed)
>
> Clirr Report (compared to 3.3.2):
>   http://people.apache.org/~britter/lang-3.4-RC1/clirr-report.html
>
> RAT Report:
>   http://people.apache.org/~britter/lang-3.4-RC1/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote. This vote will close no
> sooner that 72 hours from now, i.e. after 17:30 CET 31-March 2015
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...

+1

builds for my compiler zoo

- Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]