[VOTE] Release Apache Commons Weaver 1.2 based on RC2

classic Classic list List threaded Threaded
18 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Commons Weaver 1.2 based on RC2

Matt Benson-3
I would like to release the [weaver] component.

Apache Commons Weaver 1.2 RC2 is available for review at:
  https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994).

Maven artifacts are at:
  https://repository.apache.org/content/repositories/orgapachecommons-1141 .

Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.

The Subversion tag is:
  http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
(r1726007).

Site (note some links may be broken; this will be fixed when the site
is deployed):
  http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html

RAT Report:
  http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html

Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
  http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
  http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
  http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
  http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
  http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
  http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html

Keys: https://dist.apache.org/repos/dist/release/commons/KEYS

Please review the release candidate and vote.
  This vote will close no sooner than 72 hours from now, i.e. after
1900UTC 24-January 2016

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

  Thanks!

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

Romain Manni-Bucau
+1, thanks Matt!


Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com>

2016-01-21 19:39 GMT+01:00 Matt Benson <[hidden email]>:

> I would like to release the [weaver] component.
>
> Apache Commons Weaver 1.2 RC2 is available for review at:
>   https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994).
>
> Maven artifacts are at:
>   https://repository.apache.org/content/repositories/orgapachecommons-1141
> .
>
> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.
>
> The Subversion tag is:
>   http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
> (r1726007).
>
> Site (note some links may be broken; this will be fixed when the site
> is deployed):
>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html
>
> RAT Report:
>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html
>
> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html
>
> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
>
> Please review the release candidate and vote.
>   This vote will close no sooner than 72 hours from now, i.e. after
> 1900UTC 24-January 2016
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
>   Thanks!
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

Luc Maisonobe-2
Le 2016-01-22 08:47, Romain Manni-Bucau a écrit :

> +1, thanks Matt!
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <http://rmannibucau.wordpress.com> | Github
> <https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com>
>
> 2016-01-21 19:39 GMT+01:00 Matt Benson <[hidden email]>:
>
>> I would like to release the [weaver] component.
>>
>> Apache Commons Weaver 1.2 RC2 is available for review at:
>>   https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994).
>>
>> Maven artifacts are at:
>>  
>> https://repository.apache.org/content/repositories/orgapachecommons-1141
>> .
>>
>> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.
>>
>> The Subversion tag is:
>>   http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
>> (r1726007).
>>
>> Site (note some links may be broken; this will be fixed when the site
>> is deployed):
>>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html
>>
>> RAT Report:
>>  
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html
>>
>> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
>>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
>>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
>>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
>>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
>>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
>>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html
>>
>> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
>>
>> Please review the release candidate and vote.
>>   This vote will close no sooner than 72 hours from now, i.e. after
>> 1900UTC 24-January 2016
>>
>>   [X] +1 Release these artifacts

Slight difficulty in building from sources, due to the interdependency,
but this is propermy explained in the BUILDING.txt file, so a "mvn
install"
rather than my traditional "mvn clean compile site" was sufficient. So
this is OK to me.

best regards,
Luc

>>   [ ] +0 OK, but...
>>   [ ] -0 OK, but really should fix...
>>   [ ] -1 I oppose this release because...
>>
>>   Thanks!
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

Phil Steitz
In reply to this post by Matt Benson-3
Sigs, hashes, release contents look good.
ASM attribution is there, I assume in the right places.
Jar contents look clean, though I did not run tests against release
jars.
Tests run clean on
Ubuntu Oracle 1.6.0_43
OSX Oracle 1.8.0_45, 1.7.0_71

+1

Phil


On 1/21/16 11:39 AM, Matt Benson wrote:

> I would like to release the [weaver] component.
>
> Apache Commons Weaver 1.2 RC2 is available for review at:
>   https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994).
>
> Maven artifacts are at:
>   https://repository.apache.org/content/repositories/orgapachecommons-1141 .
>
> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.
>
> The Subversion tag is:
>   http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
> (r1726007).
>
> Site (note some links may be broken; this will be fixed when the site
> is deployed):
>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html
>
> RAT Report:
>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html
>
> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html
>
> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
>
> Please review the release candidate and vote.
>   This vote will close no sooner than 72 hours from now, i.e. after
> 1900UTC 24-January 2016
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
>   Thanks!
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

Olivier Lamy
In reply to this post by Matt Benson-3
+1

On 22 January 2016 at 05:39, Matt Benson <[hidden email]> wrote:

> I would like to release the [weaver] component.
>
> Apache Commons Weaver 1.2 RC2 is available for review at:
>   https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994).
>
> Maven artifacts are at:
>   https://repository.apache.org/content/repositories/orgapachecommons-1141
> .
>
> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.
>
> The Subversion tag is:
>   http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
> (r1726007).
>
> Site (note some links may be broken; this will be fixed when the site
> is deployed):
>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html
>
> RAT Report:
>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html
>
> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html
>
> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
>
> Please review the release candidate and vote.
>   This vote will close no sooner than 72 hours from now, i.e. after
> 1900UTC 24-January 2016
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
>   Thanks!
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

garydgregory
In reply to this post by Matt Benson-3
Not a blocker but kind of silly:

Unapproved licenses:

  LICENSE-asm5.0.4.txt


This file should be excluded.

Gary


On Thu, Jan 21, 2016 at 10:39 AM, Matt Benson <[hidden email]> wrote:

> I would like to release the [weaver] component.
>
> Apache Commons Weaver 1.2 RC2 is available for review at:
>   https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994).
>
> Maven artifacts are at:
>   https://repository.apache.org/content/repositories/orgapachecommons-1141
> .
>
> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.
>
> The Subversion tag is:
>   http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
> (r1726007).
>
> Site (note some links may be broken; this will be fixed when the site
> is deployed):
>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html
>
> RAT Report:
>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html
>
> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html
>
> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
>
> Please review the release candidate and vote.
>   This vote will close no sooner than 72 hours from now, i.e. after
> 1900UTC 24-January 2016
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
>   Thanks!
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

garydgregory
In reply to this post by Matt Benson-3
Antlib's Clirr report has a lot of errors:
https://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/clirr-report.html

This is not documented in the release notes.

Gary

On Thu, Jan 21, 2016 at 10:39 AM, Matt Benson <[hidden email]> wrote:

> I would like to release the [weaver] component.
>
> Apache Commons Weaver 1.2 RC2 is available for review at:
>   https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994).
>
> Maven artifacts are at:
>   https://repository.apache.org/content/repositories/orgapachecommons-1141
> .
>
> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.
>
> The Subversion tag is:
>   http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
> (r1726007).
>
> Site (note some links may be broken; this will be fixed when the site
> is deployed):
>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html
>
> RAT Report:
>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html
>
> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html
>
> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
>
> Please review the release candidate and vote.
>   This vote will close no sooner than 72 hours from now, i.e. after
> 1900UTC 24-January 2016
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
>   Thanks!
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

garydgregory
On Sun, Jan 24, 2016 at 7:36 PM, Gary Gregory <[hidden email]>
wrote:

> Antlib's Clirr report has a lot of errors:
> https://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/clirr-report.html
>
> This is not documented in the release notes.
>

I am not -1'ing this but it needs an explanation.

Gary


>
> Gary
>
> On Thu, Jan 21, 2016 at 10:39 AM, Matt Benson <[hidden email]> wrote:
>
>> I would like to release the [weaver] component.
>>
>> Apache Commons Weaver 1.2 RC2 is available for review at:
>>   https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994).
>>
>> Maven artifacts are at:
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1141
>> .
>>
>> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.
>>
>> The Subversion tag is:
>>   http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
>> (r1726007
>> <http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/(r1726007>
>> ).
>>
>> Site (note some links may be broken; this will be fixed when the site
>> is deployed):
>>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html
>>
>> RAT Report:
>>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html
>>
>> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
>>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
>>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
>>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
>>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
>>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
>>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html
>>
>> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
>>
>> Please review the release candidate and vote.
>>   This vote will close no sooner than 72 hours from now, i.e. after
>> 1900UTC 24-January 2016
>>
>>   [ ] +1 Release these artifacts
>>   [ ] +0 OK, but...
>>   [ ] -0 OK, but really should fix...
>>   [ ] -1 I oppose this release because...
>>
>>   Thanks!
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>
>
> --
> E-Mail: [hidden email] | [hidden email]
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

Matt Benson-3
On Sun, Jan 24, 2016 at 9:37 PM, Gary Gregory <[hidden email]> wrote:

> On Sun, Jan 24, 2016 at 7:36 PM, Gary Gregory <[hidden email]>
> wrote:
>
>> Antlib's Clirr report has a lot of errors:
>> https://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/clirr-report.html
>>
>> This is not documented in the release notes.
>>
>
> I am not -1'ing this but it needs an explanation.

Thanks for catching this. However, I am at a loss except to say that,
largely, these results are incorrect. The various classes belonging to
the org.apache.tools.* namespace  are Ant classes that were
accidentally shaded in with the 1.1 release (Ant artifacts had to be
promoted to compile scope so that clirr could even run), so their
removal was deliberate--I'm sure I don't need to explain why our
Antlib shouldn't bundle Ant's own classes. Several more claimed
removals are of classes that were shaded in from commons-lang3 and
Geronimo's xbean-finder libraries. I expect that these are incorrect
anyway, but as they don't truly constitute part of the public API of
the Antlib I would argue that they are immaterial here as long as the
integration tests succeed, which they do. The remaining claimed
removals are of classes shaded from the commons-weaver-processor
artifact; I have verified that all the classes named remain in the jar
so I have no idea why the report would generate false positives.

With that information in hand, where do you now stand on this, Gary?

Matt

>
> Gary
>
>
>>
>> Gary
>>
>> On Thu, Jan 21, 2016 at 10:39 AM, Matt Benson <[hidden email]> wrote:
>>
>>> I would like to release the [weaver] component.
>>>
>>> Apache Commons Weaver 1.2 RC2 is available for review at:
>>>   https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994).
>>>
>>> Maven artifacts are at:
>>>
>>> https://repository.apache.org/content/repositories/orgapachecommons-1141
>>> .
>>>
>>> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.
>>>
>>> The Subversion tag is:
>>>   http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
>>> (r1726007
>>> <http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/(r1726007>
>>> ).
>>>
>>> Site (note some links may be broken; this will be fixed when the site
>>> is deployed):
>>>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html
>>>
>>> RAT Report:
>>>
>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html
>>>
>>> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
>>>
>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
>>>
>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
>>>
>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
>>>
>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
>>>
>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
>>>
>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html
>>>
>>> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
>>>
>>> Please review the release candidate and vote.
>>>   This vote will close no sooner than 72 hours from now, i.e. after
>>> 1900UTC 24-January 2016
>>>
>>>   [ ] +1 Release these artifacts
>>>   [ ] +0 OK, but...
>>>   [ ] -0 OK, but really should fix...
>>>   [ ] -1 I oppose this release because...
>>>
>>>   Thanks!
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>>
>>
>>
>> --
>> E-Mail: [hidden email] | [hidden email]
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> E-Mail: [hidden email] | [hidden email]
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

sebb-2-2
On 25 January 2016 at 15:47, Matt Benson <[hidden email]> wrote:

> On Sun, Jan 24, 2016 at 9:37 PM, Gary Gregory <[hidden email]> wrote:
>> On Sun, Jan 24, 2016 at 7:36 PM, Gary Gregory <[hidden email]>
>> wrote:
>>
>>> Antlib's Clirr report has a lot of errors:
>>> https://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/clirr-report.html
>>>
>>> This is not documented in the release notes.
>>>
>>
>> I am not -1'ing this but it needs an explanation.
>
> Thanks for catching this. However, I am at a loss except to say that,
> largely, these results are incorrect. The various classes belonging to
> the org.apache.tools.* namespace  are Ant classes that were
> accidentally shaded in with the 1.1 release (Ant artifacts had to be
> promoted to compile scope so that clirr could even run), so their
> removal was deliberate--I'm sure I don't need to explain why our
> Antlib shouldn't bundle Ant's own classes. Several more claimed
> removals are of classes that were shaded in from commons-lang3 and
> Geronimo's xbean-finder libraries. I expect that these are incorrect
> anyway, but as they don't truly constitute part of the public API of
> the Antlib I would argue that they are immaterial here as long as the
> integration tests succeed, which they do. The remaining claimed
> removals are of classes shaded from the commons-weaver-processor
> artifact; I have verified that all the classes named remain in the jar
> so I have no idea why the report would generate false positives.
>
> With that information in hand, where do you now stand on this, Gary?

The information is now at hand in this e-mail thread.

However if the Clirr report is published without correction, that
won't help people who come across the Clirr report.

The release notes is one place to document the issue; there may be others.

> Matt
>
>>
>> Gary
>>
>>
>>>
>>> Gary
>>>
>>> On Thu, Jan 21, 2016 at 10:39 AM, Matt Benson <[hidden email]> wrote:
>>>
>>>> I would like to release the [weaver] component.
>>>>
>>>> Apache Commons Weaver 1.2 RC2 is available for review at:
>>>>   https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994).
>>>>
>>>> Maven artifacts are at:
>>>>
>>>> https://repository.apache.org/content/repositories/orgapachecommons-1141
>>>> .
>>>>
>>>> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.
>>>>
>>>> The Subversion tag is:
>>>>   http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
>>>> (r1726007
>>>> <http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/(r1726007>
>>>> ).
>>>>
>>>> Site (note some links may be broken; this will be fixed when the site
>>>> is deployed):
>>>>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html
>>>>
>>>> RAT Report:
>>>>
>>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html
>>>>
>>>> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
>>>>
>>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
>>>>
>>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
>>>>
>>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
>>>>
>>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
>>>>
>>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
>>>>
>>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html
>>>>
>>>> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
>>>>
>>>> Please review the release candidate and vote.
>>>>   This vote will close no sooner than 72 hours from now, i.e. after
>>>> 1900UTC 24-January 2016
>>>>
>>>>   [ ] +1 Release these artifacts
>>>>   [ ] +0 OK, but...
>>>>   [ ] -0 OK, but really should fix...
>>>>   [ ] -1 I oppose this release because...
>>>>
>>>>   Thanks!
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [hidden email]
>>>> For additional commands, e-mail: [hidden email]
>>>>
>>>>
>>>
>>>
>>> --
>>> E-Mail: [hidden email] | [hidden email]
>>> Java Persistence with Hibernate, Second Edition
>>> <http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>>
>>
>> --
>> E-Mail: [hidden email] | [hidden email]
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

garydgregory
In reply to this post by Matt Benson-3
On Mon, Jan 25, 2016 at 7:47 AM, Matt Benson <[hidden email]> wrote:
>
> On Sun, Jan 24, 2016 at 9:37 PM, Gary Gregory <[hidden email]>
wrote:
> > On Sun, Jan 24, 2016 at 7:36 PM, Gary Gregory <[hidden email]>
> > wrote:
> >
> >> Antlib's Clirr report has a lot of errors:
> >>
https://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/clirr-report.html

> >>
> >> This is not documented in the release notes.
> >>
> >
> > I am not -1'ing this but it needs an explanation.
>
> Thanks for catching this. However, I am at a loss except to say that,
> largely, these results are incorrect. The various classes belonging to
> the org.apache.tools.* namespace  are Ant classes that were
> accidentally shaded in with the 1.1 release (Ant artifacts had to be
> promoted to compile scope so that clirr could even run), so their
> removal was deliberate--I'm sure I don't need to explain why our
> Antlib shouldn't bundle Ant's own classes. Several more claimed
> removals are of classes that were shaded in from commons-lang3 and
> Geronimo's xbean-finder libraries. I expect that these are incorrect
> anyway, but as they don't truly constitute part of the public API of
> the Antlib I would argue that they are immaterial here as long as the
> integration tests succeed, which they do. The remaining claimed
> removals are of classes shaded from the commons-weaver-processor
> artifact; I have verified that all the classes named remain in the jar
> so I have no idea why the report would generate false positives.
>
> With that information in hand, where do you now stand on this, Gary?

This needs to be explained clearly in the release notes. Like Sebb said,
there might be other places to document this as well.

Gary

>
>
> Matt
>
> >
> > Gary
> >
> >
> >>
> >> Gary
> >>
> >> On Thu, Jan 21, 2016 at 10:39 AM, Matt Benson <[hidden email]>
wrote:
> >>
> >>> I would like to release the [weaver] component.
> >>>
> >>> Apache Commons Weaver 1.2 RC2 is available for review at:
> >>>   https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994).
> >>>
> >>> Maven artifacts are at:
> >>>
> >>>
https://repository.apache.org/content/repositories/orgapachecommons-1141
> >>> .
> >>>
> >>> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.
> >>>
> >>> The Subversion tag is:
> >>>   http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
> >>> (r1726007
> >>> <
http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/(r1726007

>
> >>> ).
> >>>
> >>> Site (note some links may be broken; this will be fixed when the site
> >>> is deployed):
> >>>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html
> >>>
> >>> RAT Report:
> >>>
> >>>
http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html
> >>>
> >>> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
> >>>
> >>>
http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
> >>>
> >>>
http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
> >>>
> >>>
http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
> >>>
> >>>
http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
> >>>
> >>>
http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
> >>>
> >>>
http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html

> >>>
> >>> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
> >>>
> >>> Please review the release candidate and vote.
> >>>   This vote will close no sooner than 72 hours from now, i.e. after
> >>> 1900UTC 24-January 2016
> >>>
> >>>   [ ] +1 Release these artifacts
> >>>   [ ] +0 OK, but...
> >>>   [ ] -0 OK, but really should fix...
> >>>   [ ] -1 I oppose this release because...
> >>>
> >>>   Thanks!
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: [hidden email]
> >>> For additional commands, e-mail: [hidden email]
> >>>
> >>>
> >>
> >>
> >> --
> >> E-Mail: [hidden email] | [hidden email]
> >> Java Persistence with Hibernate, Second Edition
> >> <http://www.manning.com/bauer3/>
> >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> >> Spring Batch in Action <http://www.manning.com/templier/>
> >> Blog: http://garygregory.wordpress.com
> >> Home: http://garygregory.com/
> >> Tweet! http://twitter.com/GaryGregory
> >>
> >
> >
> >
> > --
> > E-Mail: [hidden email] | [hidden email]
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
JUnit in Action, Second Edition
Spring Batch in Action
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

Phil Steitz
On 1/25/16 1:30 PM, Gary Gregory wrote:

> On Mon, Jan 25, 2016 at 7:47 AM, Matt Benson <[hidden email]> wrote:
>> On Sun, Jan 24, 2016 at 9:37 PM, Gary Gregory <[hidden email]>
> wrote:
>>> On Sun, Jan 24, 2016 at 7:36 PM, Gary Gregory <[hidden email]>
>>> wrote:
>>>
>>>> Antlib's Clirr report has a lot of errors:
>>>>
> https://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/clirr-report.html
>>>> This is not documented in the release notes.
>>>>
>>> I am not -1'ing this but it needs an explanation.
>> Thanks for catching this. However, I am at a loss except to say that,
>> largely, these results are incorrect. The various classes belonging to
>> the org.apache.tools.* namespace  are Ant classes that were
>> accidentally shaded in with the 1.1 release (Ant artifacts had to be
>> promoted to compile scope so that clirr could even run), so their
>> removal was deliberate--I'm sure I don't need to explain why our
>> Antlib shouldn't bundle Ant's own classes. Several more claimed
>> removals are of classes that were shaded in from commons-lang3 and
>> Geronimo's xbean-finder libraries. I expect that these are incorrect
>> anyway, but as they don't truly constitute part of the public API of
>> the Antlib I would argue that they are immaterial here as long as the
>> integration tests succeed, which they do. The remaining claimed
>> removals are of classes shaded from the commons-weaver-processor
>> artifact; I have verified that all the classes named remain in the jar
>> so I have no idea why the report would generate false positives.
>>
>> With that information in hand, where do you now stand on this, Gary?
> This needs to be explained clearly in the release notes. Like Sebb said,
> there might be other places to document this as well.

I don't see the site bundled with the release, unless I am missing
it somewhere.  We release software, not websites.  I see no reason
to clutter the release notes about false positives in maven reports
not included with the release.  I would say fix whatever it is
before republishing the site and move on.

Phil

>
> Gary
>
>>
>> Matt
>>
>>> Gary
>>>
>>>
>>>> Gary
>>>>
>>>> On Thu, Jan 21, 2016 at 10:39 AM, Matt Benson <[hidden email]>
> wrote:
>>>>> I would like to release the [weaver] component.
>>>>>
>>>>> Apache Commons Weaver 1.2 RC2 is available for review at:
>>>>>   https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994).
>>>>>
>>>>> Maven artifacts are at:
>>>>>
>>>>>
> https://repository.apache.org/content/repositories/orgapachecommons-1141
>>>>> .
>>>>>
>>>>> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.
>>>>>
>>>>> The Subversion tag is:
>>>>>   http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
>>>>> (r1726007
>>>>> <
> http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/(r1726007
>>>>> ).
>>>>>
>>>>> Site (note some links may be broken; this will be fixed when the site
>>>>> is deployed):
>>>>>   http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html
>>>>>
>>>>> RAT Report:
>>>>>
>>>>>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html
>>>>> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
>>>>>
>>>>>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
>>>>>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
>>>>>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
>>>>>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
>>>>>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
>>>>>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html
>>>>> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
>>>>>
>>>>> Please review the release candidate and vote.
>>>>>   This vote will close no sooner than 72 hours from now, i.e. after
>>>>> 1900UTC 24-January 2016
>>>>>
>>>>>   [ ] +1 Release these artifacts
>>>>>   [ ] +0 OK, but...
>>>>>   [ ] -0 OK, but really should fix...
>>>>>   [ ] -1 I oppose this release because...
>>>>>
>>>>>   Thanks!
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: [hidden email]
>>>>> For additional commands, e-mail: [hidden email]
>>>>>
>>>>>
>>>>
>>>> --
>>>> E-Mail: [hidden email] | [hidden email]
>>>> Java Persistence with Hibernate, Second Edition
>>>> <http://www.manning.com/bauer3/>
>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>
>>>
>>> --
>>> E-Mail: [hidden email] | [hidden email]
>>> Java Persistence with Hibernate, Second Edition
>>> <http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

Romain Manni-Bucau
+1, weaver is for now mainly an internal for other asf projects - which are
BTW blocked by this vote - and the binaries are fine. The site can be fixed
anyway when pushed to no reason to hold this release.


Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com>

2016-01-25 23:19 GMT+01:00 Phil Steitz <[hidden email]>:

> On 1/25/16 1:30 PM, Gary Gregory wrote:
> > On Mon, Jan 25, 2016 at 7:47 AM, Matt Benson <[hidden email]> wrote:
> >> On Sun, Jan 24, 2016 at 9:37 PM, Gary Gregory <[hidden email]>
> > wrote:
> >>> On Sun, Jan 24, 2016 at 7:36 PM, Gary Gregory <[hidden email]>
> >>> wrote:
> >>>
> >>>> Antlib's Clirr report has a lot of errors:
> >>>>
> >
> https://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/clirr-report.html
> >>>> This is not documented in the release notes.
> >>>>
> >>> I am not -1'ing this but it needs an explanation.
> >> Thanks for catching this. However, I am at a loss except to say that,
> >> largely, these results are incorrect. The various classes belonging to
> >> the org.apache.tools.* namespace  are Ant classes that were
> >> accidentally shaded in with the 1.1 release (Ant artifacts had to be
> >> promoted to compile scope so that clirr could even run), so their
> >> removal was deliberate--I'm sure I don't need to explain why our
> >> Antlib shouldn't bundle Ant's own classes. Several more claimed
> >> removals are of classes that were shaded in from commons-lang3 and
> >> Geronimo's xbean-finder libraries. I expect that these are incorrect
> >> anyway, but as they don't truly constitute part of the public API of
> >> the Antlib I would argue that they are immaterial here as long as the
> >> integration tests succeed, which they do. The remaining claimed
> >> removals are of classes shaded from the commons-weaver-processor
> >> artifact; I have verified that all the classes named remain in the jar
> >> so I have no idea why the report would generate false positives.
> >>
> >> With that information in hand, where do you now stand on this, Gary?
> > This needs to be explained clearly in the release notes. Like Sebb said,
> > there might be other places to document this as well.
>
> I don't see the site bundled with the release, unless I am missing
> it somewhere.  We release software, not websites.  I see no reason
> to clutter the release notes about false positives in maven reports
> not included with the release.  I would say fix whatever it is
> before republishing the site and move on.
>
> Phil
> >
> > Gary
> >
> >>
> >> Matt
> >>
> >>> Gary
> >>>
> >>>
> >>>> Gary
> >>>>
> >>>> On Thu, Jan 21, 2016 at 10:39 AM, Matt Benson <[hidden email]>
> > wrote:
> >>>>> I would like to release the [weaver] component.
> >>>>>
> >>>>> Apache Commons Weaver 1.2 RC2 is available for review at:
> >>>>>   https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994).
> >>>>>
> >>>>> Maven artifacts are at:
> >>>>>
> >>>>>
> > https://repository.apache.org/content/repositories/orgapachecommons-1141
> >>>>> .
> >>>>>
> >>>>> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.
> >>>>>
> >>>>> The Subversion tag is:
> >>>>>
> http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
> >>>>> (r1726007
> >>>>> <
> >
> http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/(r1726007
> >>>>> ).
> >>>>>
> >>>>> Site (note some links may be broken; this will be fixed when the site
> >>>>> is deployed):
> >>>>>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html
> >>>>>
> >>>>> RAT Report:
> >>>>>
> >>>>>
> > http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html
> >>>>> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
> >>>>>
> >>>>>
> >
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
> >>>>>
> >
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
> >>>>>
> >
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
> >>>>>
> >
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
> >>>>>
> >
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
> >>>>>
> >
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html
> >>>>> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
> >>>>>
> >>>>> Please review the release candidate and vote.
> >>>>>   This vote will close no sooner than 72 hours from now, i.e. after
> >>>>> 1900UTC 24-January 2016
> >>>>>
> >>>>>   [ ] +1 Release these artifacts
> >>>>>   [ ] +0 OK, but...
> >>>>>   [ ] -0 OK, but really should fix...
> >>>>>   [ ] -1 I oppose this release because...
> >>>>>
> >>>>>   Thanks!
> >>>>>
> >>>>> ---------------------------------------------------------------------
> >>>>> To unsubscribe, e-mail: [hidden email]
> >>>>> For additional commands, e-mail: [hidden email]
> >>>>>
> >>>>>
> >>>>
> >>>> --
> >>>> E-Mail: [hidden email] | [hidden email]
> >>>> Java Persistence with Hibernate, Second Edition
> >>>> <http://www.manning.com/bauer3/>
> >>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> >>>> Spring Batch in Action <http://www.manning.com/templier/>
> >>>> Blog: http://garygregory.wordpress.com
> >>>> Home: http://garygregory.com/
> >>>> Tweet! http://twitter.com/GaryGregory
> >>>>
> >>>
> >>>
> >>> --
> >>> E-Mail: [hidden email] | [hidden email]
> >>> Java Persistence with Hibernate, Second Edition
> >>> <http://www.manning.com/bauer3/>
> >>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> >>> Spring Batch in Action <http://www.manning.com/templier/>
> >>> Blog: http://garygregory.wordpress.com
> >>> Home: http://garygregory.com/
> >>> Tweet! http://twitter.com/GaryGregory
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

garydgregory
But the binaries are not BC. Even if that was a silly mistake, the release
notes must note the break in BC.

Gary

On Mon, Jan 25, 2016 at 2:24 PM, Romain Manni-Bucau <[hidden email]>
wrote:

> +1, weaver is for now mainly an internal for other asf projects - which are
> BTW blocked by this vote - and the binaries are fine. The site can be fixed
> anyway when pushed to no reason to hold this release.
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com>
>
> 2016-01-25 23:19 GMT+01:00 Phil Steitz <[hidden email]>:
>
> > On 1/25/16 1:30 PM, Gary Gregory wrote:
> > > On Mon, Jan 25, 2016 at 7:47 AM, Matt Benson <[hidden email]>
> wrote:
> > >> On Sun, Jan 24, 2016 at 9:37 PM, Gary Gregory <[hidden email]
> >
> > > wrote:
> > >>> On Sun, Jan 24, 2016 at 7:36 PM, Gary Gregory <
> [hidden email]>
> > >>> wrote:
> > >>>
> > >>>> Antlib's Clirr report has a lot of errors:
> > >>>>
> > >
> >
> https://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/clirr-report.html
> > >>>> This is not documented in the release notes.
> > >>>>
> > >>> I am not -1'ing this but it needs an explanation.
> > >> Thanks for catching this. However, I am at a loss except to say that,
> > >> largely, these results are incorrect. The various classes belonging to
> > >> the org.apache.tools.* namespace  are Ant classes that were
> > >> accidentally shaded in with the 1.1 release (Ant artifacts had to be
> > >> promoted to compile scope so that clirr could even run), so their
> > >> removal was deliberate--I'm sure I don't need to explain why our
> > >> Antlib shouldn't bundle Ant's own classes. Several more claimed
> > >> removals are of classes that were shaded in from commons-lang3 and
> > >> Geronimo's xbean-finder libraries. I expect that these are incorrect
> > >> anyway, but as they don't truly constitute part of the public API of
> > >> the Antlib I would argue that they are immaterial here as long as the
> > >> integration tests succeed, which they do. The remaining claimed
> > >> removals are of classes shaded from the commons-weaver-processor
> > >> artifact; I have verified that all the classes named remain in the jar
> > >> so I have no idea why the report would generate false positives.
> > >>
> > >> With that information in hand, where do you now stand on this, Gary?
> > > This needs to be explained clearly in the release notes. Like Sebb
> said,
> > > there might be other places to document this as well.
> >
> > I don't see the site bundled with the release, unless I am missing
> > it somewhere.  We release software, not websites.  I see no reason
> > to clutter the release notes about false positives in maven reports
> > not included with the release.  I would say fix whatever it is
> > before republishing the site and move on.
> >
> > Phil
> > >
> > > Gary
> > >
> > >>
> > >> Matt
> > >>
> > >>> Gary
> > >>>
> > >>>
> > >>>> Gary
> > >>>>
> > >>>> On Thu, Jan 21, 2016 at 10:39 AM, Matt Benson <[hidden email]>
> > > wrote:
> > >>>>> I would like to release the [weaver] component.
> > >>>>>
> > >>>>> Apache Commons Weaver 1.2 RC2 is available for review at:
> > >>>>>   https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994).
> > >>>>>
> > >>>>> Maven artifacts are at:
> > >>>>>
> > >>>>>
> > >
> https://repository.apache.org/content/repositories/orgapachecommons-1141
> > >>>>> .
> > >>>>>
> > >>>>> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.
> > >>>>>
> > >>>>> The Subversion tag is:
> > >>>>>
> > http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
> > >>>>> (r1726007
> > >>>>> <
> > >
> >
> http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/(r1726007
> > >>>>> ).
> > >>>>>
> > >>>>> Site (note some links may be broken; this will be fixed when the
> site
> > >>>>> is deployed):
> > >>>>>
> > http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html
> > >>>>>
> > >>>>> RAT Report:
> > >>>>>
> > >>>>>
> > >
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html
> > >>>>> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
> > >>>>>
> > >>>>>
> > >
> >
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
> > >>>>>
> > >
> >
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
> > >>>>>
> > >
> >
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
> > >>>>>
> > >
> >
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
> > >>>>>
> > >
> >
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
> > >>>>>
> > >
> >
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html
> > >>>>> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
> > >>>>>
> > >>>>> Please review the release candidate and vote.
> > >>>>>   This vote will close no sooner than 72 hours from now, i.e. after
> > >>>>> 1900UTC 24-January 2016
> > >>>>>
> > >>>>>   [ ] +1 Release these artifacts
> > >>>>>   [ ] +0 OK, but...
> > >>>>>   [ ] -0 OK, but really should fix...
> > >>>>>   [ ] -1 I oppose this release because...
> > >>>>>
> > >>>>>   Thanks!
> > >>>>>
> > >>>>>
> ---------------------------------------------------------------------
> > >>>>> To unsubscribe, e-mail: [hidden email]
> > >>>>> For additional commands, e-mail: [hidden email]
> > >>>>>
> > >>>>>
> > >>>>
> > >>>> --
> > >>>> E-Mail: [hidden email] | [hidden email]
> > >>>> Java Persistence with Hibernate, Second Edition
> > >>>> <http://www.manning.com/bauer3/>
> > >>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > >>>> Spring Batch in Action <http://www.manning.com/templier/>
> > >>>> Blog: http://garygregory.wordpress.com
> > >>>> Home: http://garygregory.com/
> > >>>> Tweet! http://twitter.com/GaryGregory
> > >>>>
> > >>>
> > >>>
> > >>> --
> > >>> E-Mail: [hidden email] | [hidden email]
> > >>> Java Persistence with Hibernate, Second Edition
> > >>> <http://www.manning.com/bauer3/>
> > >>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > >>> Spring Batch in Action <http://www.manning.com/templier/>
> > >>> Blog: http://garygregory.wordpress.com
> > >>> Home: http://garygregory.com/
> > >>> Tweet! http://twitter.com/GaryGregory
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: [hidden email]
> > >> For additional commands, e-mail: [hidden email]
> > >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >
>



--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

Phil Steitz
On 1/25/16 3:57 PM, Gary Gregory wrote:
> But the binaries are not BC. Even if that was a silly mistake, the release
> notes must note the break in BC.

I may have misunderstood what Matt said, but IIUC there is no actual
BC break.  Could any applications break as a result of what Clirr is
reporting?

Phil

>
> Gary
>
> On Mon, Jan 25, 2016 at 2:24 PM, Romain Manni-Bucau <[hidden email]>
> wrote:
>
>> +1, weaver is for now mainly an internal for other asf projects - which are
>> BTW blocked by this vote - and the binaries are fine. The site can be fixed
>> anyway when pushed to no reason to hold this release.
>>
>>
>> Romain Manni-Bucau
>> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>> <http://rmannibucau.wordpress.com> | Github <
>> https://github.com/rmannibucau> |
>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
>> <http://www.tomitribe.com>
>>
>> 2016-01-25 23:19 GMT+01:00 Phil Steitz <[hidden email]>:
>>
>>> On 1/25/16 1:30 PM, Gary Gregory wrote:
>>>> On Mon, Jan 25, 2016 at 7:47 AM, Matt Benson <[hidden email]>
>> wrote:
>>>>> On Sun, Jan 24, 2016 at 9:37 PM, Gary Gregory <[hidden email]
>>>> wrote:
>>>>>> On Sun, Jan 24, 2016 at 7:36 PM, Gary Gregory <
>> [hidden email]>
>>>>>> wrote:
>>>>>>
>>>>>>> Antlib's Clirr report has a lot of errors:
>>>>>>>
>> https://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/clirr-report.html
>>>>>>> This is not documented in the release notes.
>>>>>>>
>>>>>> I am not -1'ing this but it needs an explanation.
>>>>> Thanks for catching this. However, I am at a loss except to say that,
>>>>> largely, these results are incorrect. The various classes belonging to
>>>>> the org.apache.tools.* namespace  are Ant classes that were
>>>>> accidentally shaded in with the 1.1 release (Ant artifacts had to be
>>>>> promoted to compile scope so that clirr could even run), so their
>>>>> removal was deliberate--I'm sure I don't need to explain why our
>>>>> Antlib shouldn't bundle Ant's own classes. Several more claimed
>>>>> removals are of classes that were shaded in from commons-lang3 and
>>>>> Geronimo's xbean-finder libraries. I expect that these are incorrect
>>>>> anyway, but as they don't truly constitute part of the public API of
>>>>> the Antlib I would argue that they are immaterial here as long as the
>>>>> integration tests succeed, which they do. The remaining claimed
>>>>> removals are of classes shaded from the commons-weaver-processor
>>>>> artifact; I have verified that all the classes named remain in the jar
>>>>> so I have no idea why the report would generate false positives.
>>>>>
>>>>> With that information in hand, where do you now stand on this, Gary?
>>>> This needs to be explained clearly in the release notes. Like Sebb
>> said,
>>>> there might be other places to document this as well.
>>> I don't see the site bundled with the release, unless I am missing
>>> it somewhere.  We release software, not websites.  I see no reason
>>> to clutter the release notes about false positives in maven reports
>>> not included with the release.  I would say fix whatever it is
>>> before republishing the site and move on.
>>>
>>> Phil
>>>> Gary
>>>>
>>>>> Matt
>>>>>
>>>>>> Gary
>>>>>>
>>>>>>
>>>>>>> Gary
>>>>>>>
>>>>>>> On Thu, Jan 21, 2016 at 10:39 AM, Matt Benson <[hidden email]>
>>>> wrote:
>>>>>>>> I would like to release the [weaver] component.
>>>>>>>>
>>>>>>>> Apache Commons Weaver 1.2 RC2 is available for review at:
>>>>>>>>   https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994).
>>>>>>>>
>>>>>>>> Maven artifacts are at:
>>>>>>>>
>>>>>>>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1141
>>>>>>>> .
>>>>>>>>
>>>>>>>> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.
>>>>>>>>
>>>>>>>> The Subversion tag is:
>>>>>>>>
>>> http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
>>>>>>>> (r1726007
>>>>>>>> <
>> http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/(r1726007
>>>>>>>> ).
>>>>>>>>
>>>>>>>> Site (note some links may be broken; this will be fixed when the
>> site
>>>>>>>> is deployed):
>>>>>>>>
>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html
>>>>>>>> RAT Report:
>>>>>>>>
>>>>>>>>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html
>>>>>>>> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
>>>>>>>>
>>>>>>>>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html
>>>>>>>> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
>>>>>>>>
>>>>>>>> Please review the release candidate and vote.
>>>>>>>>   This vote will close no sooner than 72 hours from now, i.e. after
>>>>>>>> 1900UTC 24-January 2016
>>>>>>>>
>>>>>>>>   [ ] +1 Release these artifacts
>>>>>>>>   [ ] +0 OK, but...
>>>>>>>>   [ ] -0 OK, but really should fix...
>>>>>>>>   [ ] -1 I oppose this release because...
>>>>>>>>
>>>>>>>>   Thanks!
>>>>>>>>
>>>>>>>>
>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: [hidden email]
>>>>>>>> For additional commands, e-mail: [hidden email]
>>>>>>>>
>>>>>>>>
>>>>>>> --
>>>>>>> E-Mail: [hidden email] | [hidden email]
>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>> <http://www.manning.com/bauer3/>
>>>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>> Home: http://garygregory.com/
>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>>
>>>>>>
>>>>>> --
>>>>>> E-Mail: [hidden email] | [hidden email]
>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>> <http://www.manning.com/bauer3/>
>>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>>> Blog: http://garygregory.wordpress.com
>>>>>> Home: http://garygregory.com/
>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: [hidden email]
>>>>> For additional commands, e-mail: [hidden email]
>>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>>
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

garydgregory
Did I misread that the 1.1 jar included shaded code from other jars?

Gary

On Mon, Jan 25, 2016 at 3:02 PM, Phil Steitz <[hidden email]> wrote:

> On 1/25/16 3:57 PM, Gary Gregory wrote:
> > But the binaries are not BC. Even if that was a silly mistake, the
> release
> > notes must note the break in BC.
>
> I may have misunderstood what Matt said, but IIUC there is no actual
> BC break.  Could any applications break as a result of what Clirr is
> reporting?
>
> Phil
> >
> > Gary
> >
> > On Mon, Jan 25, 2016 at 2:24 PM, Romain Manni-Bucau <
> [hidden email]>
> > wrote:
> >
> >> +1, weaver is for now mainly an internal for other asf projects - which
> are
> >> BTW blocked by this vote - and the binaries are fine. The site can be
> fixed
> >> anyway when pushed to no reason to hold this release.
> >>
> >>
> >> Romain Manni-Bucau
> >> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> >> <http://rmannibucau.wordpress.com> | Github <
> >> https://github.com/rmannibucau> |
> >> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> >> <http://www.tomitribe.com>
> >>
> >> 2016-01-25 23:19 GMT+01:00 Phil Steitz <[hidden email]>:
> >>
> >>> On 1/25/16 1:30 PM, Gary Gregory wrote:
> >>>> On Mon, Jan 25, 2016 at 7:47 AM, Matt Benson <[hidden email]>
> >> wrote:
> >>>>> On Sun, Jan 24, 2016 at 9:37 PM, Gary Gregory <
> [hidden email]
> >>>> wrote:
> >>>>>> On Sun, Jan 24, 2016 at 7:36 PM, Gary Gregory <
> >> [hidden email]>
> >>>>>> wrote:
> >>>>>>
> >>>>>>> Antlib's Clirr report has a lot of errors:
> >>>>>>>
> >>
> https://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/clirr-report.html
> >>>>>>> This is not documented in the release notes.
> >>>>>>>
> >>>>>> I am not -1'ing this but it needs an explanation.
> >>>>> Thanks for catching this. However, I am at a loss except to say that,
> >>>>> largely, these results are incorrect. The various classes belonging
> to
> >>>>> the org.apache.tools.* namespace  are Ant classes that were
> >>>>> accidentally shaded in with the 1.1 release (Ant artifacts had to be
> >>>>> promoted to compile scope so that clirr could even run), so their
> >>>>> removal was deliberate--I'm sure I don't need to explain why our
> >>>>> Antlib shouldn't bundle Ant's own classes. Several more claimed
> >>>>> removals are of classes that were shaded in from commons-lang3 and
> >>>>> Geronimo's xbean-finder libraries. I expect that these are incorrect
> >>>>> anyway, but as they don't truly constitute part of the public API of
> >>>>> the Antlib I would argue that they are immaterial here as long as the
> >>>>> integration tests succeed, which they do. The remaining claimed
> >>>>> removals are of classes shaded from the commons-weaver-processor
> >>>>> artifact; I have verified that all the classes named remain in the
> jar
> >>>>> so I have no idea why the report would generate false positives.
> >>>>>
> >>>>> With that information in hand, where do you now stand on this, Gary?
> >>>> This needs to be explained clearly in the release notes. Like Sebb
> >> said,
> >>>> there might be other places to document this as well.
> >>> I don't see the site bundled with the release, unless I am missing
> >>> it somewhere.  We release software, not websites.  I see no reason
> >>> to clutter the release notes about false positives in maven reports
> >>> not included with the release.  I would say fix whatever it is
> >>> before republishing the site and move on.
> >>>
> >>> Phil
> >>>> Gary
> >>>>
> >>>>> Matt
> >>>>>
> >>>>>> Gary
> >>>>>>
> >>>>>>
> >>>>>>> Gary
> >>>>>>>
> >>>>>>> On Thu, Jan 21, 2016 at 10:39 AM, Matt Benson <[hidden email]>
> >>>> wrote:
> >>>>>>>> I would like to release the [weaver] component.
> >>>>>>>>
> >>>>>>>> Apache Commons Weaver 1.2 RC2 is available for review at:
> >>>>>>>>   https://dist.apache.org/repos/dist/dev/commons/weaver/
> (r11994).
> >>>>>>>>
> >>>>>>>> Maven artifacts are at:
> >>>>>>>>
> >>>>>>>>
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-1141
> >>>>>>>> .
> >>>>>>>>
> >>>>>>>> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.
> >>>>>>>>
> >>>>>>>> The Subversion tag is:
> >>>>>>>>
> >>> http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
> >>>>>>>> (r1726007
> >>>>>>>> <
> >>
> http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/(r1726007
> >>>>>>>> ).
> >>>>>>>>
> >>>>>>>> Site (note some links may be broken; this will be fixed when the
> >> site
> >>>>>>>> is deployed):
> >>>>>>>>
> >>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html
> >>>>>>>> RAT Report:
> >>>>>>>>
> >>>>>>>>
> >>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html
> >>>>>>>> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
> >>>>>>>>
> >>>>>>>>
> >>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
> >>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
> >>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
> >>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
> >>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
> >>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html
> >>>>>>>> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
> >>>>>>>>
> >>>>>>>> Please review the release candidate and vote.
> >>>>>>>>   This vote will close no sooner than 72 hours from now, i.e.
> after
> >>>>>>>> 1900UTC 24-January 2016
> >>>>>>>>
> >>>>>>>>   [ ] +1 Release these artifacts
> >>>>>>>>   [ ] +0 OK, but...
> >>>>>>>>   [ ] -0 OK, but really should fix...
> >>>>>>>>   [ ] -1 I oppose this release because...
> >>>>>>>>
> >>>>>>>>   Thanks!
> >>>>>>>>
> >>>>>>>>
> >> ---------------------------------------------------------------------
> >>>>>>>> To unsubscribe, e-mail: [hidden email]
> >>>>>>>> For additional commands, e-mail: [hidden email]
> >>>>>>>>
> >>>>>>>>
> >>>>>>> --
> >>>>>>> E-Mail: [hidden email] | [hidden email]
> >>>>>>> Java Persistence with Hibernate, Second Edition
> >>>>>>> <http://www.manning.com/bauer3/>
> >>>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> >>>>>>> Spring Batch in Action <http://www.manning.com/templier/>
> >>>>>>> Blog: http://garygregory.wordpress.com
> >>>>>>> Home: http://garygregory.com/
> >>>>>>> Tweet! http://twitter.com/GaryGregory
> >>>>>>>
> >>>>>>
> >>>>>> --
> >>>>>> E-Mail: [hidden email] | [hidden email]
> >>>>>> Java Persistence with Hibernate, Second Edition
> >>>>>> <http://www.manning.com/bauer3/>
> >>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> >>>>>> Spring Batch in Action <http://www.manning.com/templier/>
> >>>>>> Blog: http://garygregory.wordpress.com
> >>>>>> Home: http://garygregory.com/
> >>>>>> Tweet! http://twitter.com/GaryGregory
> >>>>> ---------------------------------------------------------------------
> >>>>> To unsubscribe, e-mail: [hidden email]
> >>>>> For additional commands, e-mail: [hidden email]
> >>>>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: [hidden email]
> >>> For additional commands, e-mail: [hidden email]
> >>>
> >>>
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

Matt Benson-3
In practice it is most likely that a user of the 1.1 version of the
Antlib (firstly, doesn't exist, but if they did) would see no effect
because Ant's own classes are loaded in the parent CL of the Antlib's
CL, therefore the Ant classes, correctly, would not be used. While the
jar is technically not BC, there was never any intent for those
classes to be included (this only happened because the clirr report
wasn't smart enough to handle provided dependencies and therefore
couldn't be run to compare 1.1 to 1.0). The only way there could be a
problem is if the user ran the entire Ant process from the 1.1
cw-antlib jar, which would take some doing, and which certainly should
not IMO be considered a supported use case. And since the release
process is so onerous, I don't think we really have to worry about any
newer Commons component picking up enough traction for any changes to
affect any users of any type, ever. :P However, since releases cannot
be vetoed and Phil and Romain have made viable suggestions as to how
to handle this, my inclination is to conclude this vote as having
passed.

Matt

On Mon, Jan 25, 2016 at 5:08 PM, Gary Gregory <[hidden email]> wrote:

> Did I misread that the 1.1 jar included shaded code from other jars?
>
> Gary
>
> On Mon, Jan 25, 2016 at 3:02 PM, Phil Steitz <[hidden email]> wrote:
>
>> On 1/25/16 3:57 PM, Gary Gregory wrote:
>> > But the binaries are not BC. Even if that was a silly mistake, the
>> release
>> > notes must note the break in BC.
>>
>> I may have misunderstood what Matt said, but IIUC there is no actual
>> BC break.  Could any applications break as a result of what Clirr is
>> reporting?
>>
>> Phil
>> >
>> > Gary
>> >
>> > On Mon, Jan 25, 2016 at 2:24 PM, Romain Manni-Bucau <
>> [hidden email]>
>> > wrote:
>> >
>> >> +1, weaver is for now mainly an internal for other asf projects - which
>> are
>> >> BTW blocked by this vote - and the binaries are fine. The site can be
>> fixed
>> >> anyway when pushed to no reason to hold this release.
>> >>
>> >>
>> >> Romain Manni-Bucau
>> >> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>> >> <http://rmannibucau.wordpress.com> | Github <
>> >> https://github.com/rmannibucau> |
>> >> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
>> >> <http://www.tomitribe.com>
>> >>
>> >> 2016-01-25 23:19 GMT+01:00 Phil Steitz <[hidden email]>:
>> >>
>> >>> On 1/25/16 1:30 PM, Gary Gregory wrote:
>> >>>> On Mon, Jan 25, 2016 at 7:47 AM, Matt Benson <[hidden email]>
>> >> wrote:
>> >>>>> On Sun, Jan 24, 2016 at 9:37 PM, Gary Gregory <
>> [hidden email]
>> >>>> wrote:
>> >>>>>> On Sun, Jan 24, 2016 at 7:36 PM, Gary Gregory <
>> >> [hidden email]>
>> >>>>>> wrote:
>> >>>>>>
>> >>>>>>> Antlib's Clirr report has a lot of errors:
>> >>>>>>>
>> >>
>> https://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/clirr-report.html
>> >>>>>>> This is not documented in the release notes.
>> >>>>>>>
>> >>>>>> I am not -1'ing this but it needs an explanation.
>> >>>>> Thanks for catching this. However, I am at a loss except to say that,
>> >>>>> largely, these results are incorrect. The various classes belonging
>> to
>> >>>>> the org.apache.tools.* namespace  are Ant classes that were
>> >>>>> accidentally shaded in with the 1.1 release (Ant artifacts had to be
>> >>>>> promoted to compile scope so that clirr could even run), so their
>> >>>>> removal was deliberate--I'm sure I don't need to explain why our
>> >>>>> Antlib shouldn't bundle Ant's own classes. Several more claimed
>> >>>>> removals are of classes that were shaded in from commons-lang3 and
>> >>>>> Geronimo's xbean-finder libraries. I expect that these are incorrect
>> >>>>> anyway, but as they don't truly constitute part of the public API of
>> >>>>> the Antlib I would argue that they are immaterial here as long as the
>> >>>>> integration tests succeed, which they do. The remaining claimed
>> >>>>> removals are of classes shaded from the commons-weaver-processor
>> >>>>> artifact; I have verified that all the classes named remain in the
>> jar
>> >>>>> so I have no idea why the report would generate false positives.
>> >>>>>
>> >>>>> With that information in hand, where do you now stand on this, Gary?
>> >>>> This needs to be explained clearly in the release notes. Like Sebb
>> >> said,
>> >>>> there might be other places to document this as well.
>> >>> I don't see the site bundled with the release, unless I am missing
>> >>> it somewhere.  We release software, not websites.  I see no reason
>> >>> to clutter the release notes about false positives in maven reports
>> >>> not included with the release.  I would say fix whatever it is
>> >>> before republishing the site and move on.
>> >>>
>> >>> Phil
>> >>>> Gary
>> >>>>
>> >>>>> Matt
>> >>>>>
>> >>>>>> Gary
>> >>>>>>
>> >>>>>>
>> >>>>>>> Gary
>> >>>>>>>
>> >>>>>>> On Thu, Jan 21, 2016 at 10:39 AM, Matt Benson <[hidden email]>
>> >>>> wrote:
>> >>>>>>>> I would like to release the [weaver] component.
>> >>>>>>>>
>> >>>>>>>> Apache Commons Weaver 1.2 RC2 is available for review at:
>> >>>>>>>>   https://dist.apache.org/repos/dist/dev/commons/weaver/
>> (r11994).
>> >>>>>>>>
>> >>>>>>>> Maven artifacts are at:
>> >>>>>>>>
>> >>>>>>>>
>> >>
>> https://repository.apache.org/content/repositories/orgapachecommons-1141
>> >>>>>>>> .
>> >>>>>>>>
>> >>>>>>>> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.
>> >>>>>>>>
>> >>>>>>>> The Subversion tag is:
>> >>>>>>>>
>> >>> http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
>> >>>>>>>> (r1726007
>> >>>>>>>> <
>> >>
>> http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/(r1726007
>> >>>>>>>> ).
>> >>>>>>>>
>> >>>>>>>> Site (note some links may be broken; this will be fixed when the
>> >> site
>> >>>>>>>> is deployed):
>> >>>>>>>>
>> >>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html
>> >>>>>>>> RAT Report:
>> >>>>>>>>
>> >>>>>>>>
>> >>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html
>> >>>>>>>> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
>> >>>>>>>>
>> >>>>>>>>
>> >>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
>> >>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
>> >>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
>> >>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
>> >>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
>> >>
>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html
>> >>>>>>>> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
>> >>>>>>>>
>> >>>>>>>> Please review the release candidate and vote.
>> >>>>>>>>   This vote will close no sooner than 72 hours from now, i.e.
>> after
>> >>>>>>>> 1900UTC 24-January 2016
>> >>>>>>>>
>> >>>>>>>>   [ ] +1 Release these artifacts
>> >>>>>>>>   [ ] +0 OK, but...
>> >>>>>>>>   [ ] -0 OK, but really should fix...
>> >>>>>>>>   [ ] -1 I oppose this release because...
>> >>>>>>>>
>> >>>>>>>>   Thanks!
>> >>>>>>>>
>> >>>>>>>>
>> >> ---------------------------------------------------------------------
>> >>>>>>>> To unsubscribe, e-mail: [hidden email]
>> >>>>>>>> For additional commands, e-mail: [hidden email]
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>> --
>> >>>>>>> E-Mail: [hidden email] | [hidden email]
>> >>>>>>> Java Persistence with Hibernate, Second Edition
>> >>>>>>> <http://www.manning.com/bauer3/>
>> >>>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> >>>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>> >>>>>>> Blog: http://garygregory.wordpress.com
>> >>>>>>> Home: http://garygregory.com/
>> >>>>>>> Tweet! http://twitter.com/GaryGregory
>> >>>>>>>
>> >>>>>>
>> >>>>>> --
>> >>>>>> E-Mail: [hidden email] | [hidden email]
>> >>>>>> Java Persistence with Hibernate, Second Edition
>> >>>>>> <http://www.manning.com/bauer3/>
>> >>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> >>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>> >>>>>> Blog: http://garygregory.wordpress.com
>> >>>>>> Home: http://garygregory.com/
>> >>>>>> Tweet! http://twitter.com/GaryGregory
>> >>>>> ---------------------------------------------------------------------
>> >>>>> To unsubscribe, e-mail: [hidden email]
>> >>>>> For additional commands, e-mail: [hidden email]
>> >>>>>
>> >>>
>> >>> ---------------------------------------------------------------------
>> >>> To unsubscribe, e-mail: [hidden email]
>> >>> For additional commands, e-mail: [hidden email]
>> >>>
>> >>>
>> >
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>
>
> --
> E-Mail: [hidden email] | [hidden email]
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC2

garydgregory
On Mon, Jan 25, 2016 at 3:37 PM, Matt Benson <[hidden email]> wrote:

> In practice it is most likely that a user of the 1.1 version of the
> Antlib (firstly, doesn't exist, but if they did) would see no effect
> because Ant's own classes are loaded in the parent CL of the Antlib's
> CL, therefore the Ant classes, correctly, would not be used. While the
> jar is technically not BC, there was never any intent for those
> classes to be included (this only happened because the clirr report
> wasn't smart enough to handle provided dependencies and therefore
> couldn't be run to compare 1.1 to 1.0). The only way there could be a
> problem is if the user ran the entire Ant process from the 1.1
> cw-antlib jar, which would take some doing, and which certainly should
> not IMO be considered a supported use case. And since the release
> process is so onerous, I don't think we really have to worry about any
> newer Commons component picking up enough traction for any changes to
> affect any users of any type, ever. :P However, since releases cannot
> be vetoed and Phil and Romain have made viable suggestions as to how
> to handle this, my inclination is to conclude this vote as having
> passed.
>

This is all great information. If I were RM, I would update the release
notes (and the site where appropriate) and re-spin the RC.

Gary


>
> Matt
>
> On Mon, Jan 25, 2016 at 5:08 PM, Gary Gregory <[hidden email]>
> wrote:
> > Did I misread that the 1.1 jar included shaded code from other jars?
> >
> > Gary
> >
> > On Mon, Jan 25, 2016 at 3:02 PM, Phil Steitz <[hidden email]>
> wrote:
> >
> >> On 1/25/16 3:57 PM, Gary Gregory wrote:
> >> > But the binaries are not BC. Even if that was a silly mistake, the
> >> release
> >> > notes must note the break in BC.
> >>
> >> I may have misunderstood what Matt said, but IIUC there is no actual
> >> BC break.  Could any applications break as a result of what Clirr is
> >> reporting?
> >>
> >> Phil
> >> >
> >> > Gary
> >> >
> >> > On Mon, Jan 25, 2016 at 2:24 PM, Romain Manni-Bucau <
> >> [hidden email]>
> >> > wrote:
> >> >
> >> >> +1, weaver is for now mainly an internal for other asf projects -
> which
> >> are
> >> >> BTW blocked by this vote - and the binaries are fine. The site can be
> >> fixed
> >> >> anyway when pushed to no reason to hold this release.
> >> >>
> >> >>
> >> >> Romain Manni-Bucau
> >> >> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> >> >> <http://rmannibucau.wordpress.com> | Github <
> >> >> https://github.com/rmannibucau> |
> >> >> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> >> >> <http://www.tomitribe.com>
> >> >>
> >> >> 2016-01-25 23:19 GMT+01:00 Phil Steitz <[hidden email]>:
> >> >>
> >> >>> On 1/25/16 1:30 PM, Gary Gregory wrote:
> >> >>>> On Mon, Jan 25, 2016 at 7:47 AM, Matt Benson <[hidden email]>
> >> >> wrote:
> >> >>>>> On Sun, Jan 24, 2016 at 9:37 PM, Gary Gregory <
> >> [hidden email]
> >> >>>> wrote:
> >> >>>>>> On Sun, Jan 24, 2016 at 7:36 PM, Gary Gregory <
> >> >> [hidden email]>
> >> >>>>>> wrote:
> >> >>>>>>
> >> >>>>>>> Antlib's Clirr report has a lot of errors:
> >> >>>>>>>
> >> >>
> >>
> https://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/clirr-report.html
> >> >>>>>>> This is not documented in the release notes.
> >> >>>>>>>
> >> >>>>>> I am not -1'ing this but it needs an explanation.
> >> >>>>> Thanks for catching this. However, I am at a loss except to say
> that,
> >> >>>>> largely, these results are incorrect. The various classes
> belonging
> >> to
> >> >>>>> the org.apache.tools.* namespace  are Ant classes that were
> >> >>>>> accidentally shaded in with the 1.1 release (Ant artifacts had to
> be
> >> >>>>> promoted to compile scope so that clirr could even run), so their
> >> >>>>> removal was deliberate--I'm sure I don't need to explain why our
> >> >>>>> Antlib shouldn't bundle Ant's own classes. Several more claimed
> >> >>>>> removals are of classes that were shaded in from commons-lang3 and
> >> >>>>> Geronimo's xbean-finder libraries. I expect that these are
> incorrect
> >> >>>>> anyway, but as they don't truly constitute part of the public API
> of
> >> >>>>> the Antlib I would argue that they are immaterial here as long as
> the
> >> >>>>> integration tests succeed, which they do. The remaining claimed
> >> >>>>> removals are of classes shaded from the commons-weaver-processor
> >> >>>>> artifact; I have verified that all the classes named remain in the
> >> jar
> >> >>>>> so I have no idea why the report would generate false positives.
> >> >>>>>
> >> >>>>> With that information in hand, where do you now stand on this,
> Gary?
> >> >>>> This needs to be explained clearly in the release notes. Like Sebb
> >> >> said,
> >> >>>> there might be other places to document this as well.
> >> >>> I don't see the site bundled with the release, unless I am missing
> >> >>> it somewhere.  We release software, not websites.  I see no reason
> >> >>> to clutter the release notes about false positives in maven reports
> >> >>> not included with the release.  I would say fix whatever it is
> >> >>> before republishing the site and move on.
> >> >>>
> >> >>> Phil
> >> >>>> Gary
> >> >>>>
> >> >>>>> Matt
> >> >>>>>
> >> >>>>>> Gary
> >> >>>>>>
> >> >>>>>>
> >> >>>>>>> Gary
> >> >>>>>>>
> >> >>>>>>> On Thu, Jan 21, 2016 at 10:39 AM, Matt Benson <
> [hidden email]>
> >> >>>> wrote:
> >> >>>>>>>> I would like to release the [weaver] component.
> >> >>>>>>>>
> >> >>>>>>>> Apache Commons Weaver 1.2 RC2 is available for review at:
> >> >>>>>>>>   https://dist.apache.org/repos/dist/dev/commons/weaver/
> >> (r11994).
> >> >>>>>>>>
> >> >>>>>>>> Maven artifacts are at:
> >> >>>>>>>>
> >> >>>>>>>>
> >> >>
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-1141
> >> >>>>>>>> .
> >> >>>>>>>>
> >> >>>>>>>> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7.
> >> >>>>>>>>
> >> >>>>>>>> The Subversion tag is:
> >> >>>>>>>>
> >> >>> http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/
> >> >>>>>>>> (r1726007
> >> >>>>>>>> <
> >> >>
> >>
> http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/(r1726007
> >> >>>>>>>> ).
> >> >>>>>>>>
> >> >>>>>>>> Site (note some links may be broken; this will be fixed when
> the
> >> >> site
> >> >>>>>>>> is deployed):
> >> >>>>>>>>
> >> >>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html
> >> >>>>>>>> RAT Report:
> >> >>>>>>>>
> >> >>>>>>>>
> >> >>
> >>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html
> >> >>>>>>>> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs):
> >> >>>>>>>>
> >> >>>>>>>>
> >> >>
> >>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html
> >> >>
> >>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html
> >> >>
> >>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html
> >> >>
> >>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html
> >> >>
> >>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html
> >> >>
> >>
> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html
> >> >>>>>>>> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
> >> >>>>>>>>
> >> >>>>>>>> Please review the release candidate and vote.
> >> >>>>>>>>   This vote will close no sooner than 72 hours from now, i.e.
> >> after
> >> >>>>>>>> 1900UTC 24-January 2016
> >> >>>>>>>>
> >> >>>>>>>>   [ ] +1 Release these artifacts
> >> >>>>>>>>   [ ] +0 OK, but...
> >> >>>>>>>>   [ ] -0 OK, but really should fix...
> >> >>>>>>>>   [ ] -1 I oppose this release because...
> >> >>>>>>>>
> >> >>>>>>>>   Thanks!
> >> >>>>>>>>
> >> >>>>>>>>
> >> >> ---------------------------------------------------------------------
> >> >>>>>>>> To unsubscribe, e-mail: [hidden email]
> >> >>>>>>>> For additional commands, e-mail: [hidden email]
> >> >>>>>>>>
> >> >>>>>>>>
> >> >>>>>>> --
> >> >>>>>>> E-Mail: [hidden email] | [hidden email]
> >> >>>>>>> Java Persistence with Hibernate, Second Edition
> >> >>>>>>> <http://www.manning.com/bauer3/>
> >> >>>>>>> JUnit in Action, Second Edition <
> http://www.manning.com/tahchiev/>
> >> >>>>>>> Spring Batch in Action <http://www.manning.com/templier/>
> >> >>>>>>> Blog: http://garygregory.wordpress.com
> >> >>>>>>> Home: http://garygregory.com/
> >> >>>>>>> Tweet! http://twitter.com/GaryGregory
> >> >>>>>>>
> >> >>>>>>
> >> >>>>>> --
> >> >>>>>> E-Mail: [hidden email] | [hidden email]
> >> >>>>>> Java Persistence with Hibernate, Second Edition
> >> >>>>>> <http://www.manning.com/bauer3/>
> >> >>>>>> JUnit in Action, Second Edition <
> http://www.manning.com/tahchiev/>
> >> >>>>>> Spring Batch in Action <http://www.manning.com/templier/>
> >> >>>>>> Blog: http://garygregory.wordpress.com
> >> >>>>>> Home: http://garygregory.com/
> >> >>>>>> Tweet! http://twitter.com/GaryGregory
> >> >>>>>
> ---------------------------------------------------------------------
> >> >>>>> To unsubscribe, e-mail: [hidden email]
> >> >>>>> For additional commands, e-mail: [hidden email]
> >> >>>>>
> >> >>>
> >> >>>
> ---------------------------------------------------------------------
> >> >>> To unsubscribe, e-mail: [hidden email]
> >> >>> For additional commands, e-mail: [hidden email]
> >> >>>
> >> >>>
> >> >
> >> >
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
> >>
> >
> >
> > --
> > E-Mail: [hidden email] | [hidden email]
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory