[VOTE] Release BCEL 6.0 based on RC3

classic Classic list List threaded Threaded
67 messages Options
1234
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release BCEL 6.0 based on RC3

Emmanuel Bourg-3
Hi all,

The third release candidate of BCEL is ready to pass under your scrutiny.

Tag:
http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC3/
(r1627908)

Release notes:
http://people.apache.org/~ebourg/bcel/RELEASE-NOTES.txt

Distribution files:
http://people.apache.org/~ebourg/bcel/

Checksums (sha1):
6f1d11224b7cea98ffbffa25d69d759fcd47421c  bcel-6.0-bin.tar.gz
425729b886f72481bdbfc7e8ca108f20c00e67ef  bcel-6.0-bin.zip
89e171be63df397d23ea746f9845cf3087e8467e  bcel-6.0-src.tar.gz
a03c2e605b8eb997b5d023d6a7d6aa54fbf3600e  bcel-6.0-src.zip

Site:
http://people.apache.org/~ebourg/bcel/site/

Javadoc:
http://people.apache.org/~ebourg/bcel/site/apidocs/

Maven artifacts:
https://repository.apache.org/content/repositories/orgapachecommons-1047/org/apache/bcel/bcel/6.0/


Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thank you for your reviews,

Emmanuel Bourg



signature.asc (851 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

Oliver Heger-3
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Build works fine with Java 1.5 and 1.7 on Windows 8.1. Artifacts look
good. The site shows that the code base probably needs some work to
improve quality, but this does not block the release.

Nits:
- - The NOTICE file states the wrong copyright year.
- - The distribution files of other Commons components start with the
commons- prefix. This is not the case here.

I am not sure how problematic the wrong copyright year is, also from a
legal PoV. This prevents me from voting +1; everything else is not
blocking.

Oliver

Am 27.09.2014 um 09:50 schrieb Emmanuel Bourg:
> Hi all,
>
> The third release candidate of BCEL is ready to pass under your
> scrutiny.
>
> Tag:
> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC3/
>
>
(r1627908)

>
> Release notes:
> http://people.apache.org/~ebourg/bcel/RELEASE-NOTES.txt
>
> Distribution files: http://people.apache.org/~ebourg/bcel/
>
> Checksums (sha1): 6f1d11224b7cea98ffbffa25d69d759fcd47421c
> bcel-6.0-bin.tar.gz 425729b886f72481bdbfc7e8ca108f20c00e67ef
> bcel-6.0-bin.zip 89e171be63df397d23ea746f9845cf3087e8467e
> bcel-6.0-src.tar.gz a03c2e605b8eb997b5d023d6a7d6aa54fbf3600e
> bcel-6.0-src.zip
>
> Site: http://people.apache.org/~ebourg/bcel/site/
>
> Javadoc: http://people.apache.org/~ebourg/bcel/site/apidocs/
>
> Maven artifacts:
> https://repository.apache.org/content/repositories/orgapachecommons-1047/org/apache/bcel/bcel/6.0/
>
>
>
> Please review the release candidate and vote. This vote will close
> no sooner that 72 hours from now.
>
> [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but
> really should fix... [ ] -1 I oppose this release because...
>
> Thank you for your reviews,
>
> Emmanuel Bourg
>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)

iQEcBAEBAgAGBQJUJsAyAAoJEDgk3dGBGEE4j18IALlBJsgK9Kf0APSQdst8Idui
65zuBrApxqy/dpxT51m8egk8zWasG+PIu686jAjcs9Hwj23STtHKX0DXKnQVCw6Q
mrsnnxHZZ4BHRFp8PUeu6kKz+KuTOVmJmoHBg+DusbHkxCD07bIFxHx81v200tbG
UHOSE/+tdSo7urOC98YTMZ1Ikg+zonRG2GTE1PWgNXsS+E/wM/U0y3MFkEEUginV
FGWscZgflUcBJkME9J5trvDM14khFQi6OmpZKNk4Ld54N6NmoM15Tq4nsDWSKhNX
050R4Cg1W2onmZLlBy/Vox3owTvM9B+jh3hn7CmlNpSVH88dG3A+FcB6QFSXGf4=
=lDGf
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

Emmanuel Bourg-3
Le 27/09/2014 15:48, Oliver Heger a écrit :

> - The distribution files of other Commons components start with the
> commons- prefix. This is not the case here.

Because BCEL wasn't a Commons project and still distributed under it's
own org.apache.bcel groupId


> I am not sure how problematic the wrong copyright year is, also from a
> legal PoV. This prevents me from voting +1; everything else is not
> blocking.

I guess that may mislead someone into thinking the copyright will expire
2 years before it actually should. We are talking about the life time of
the authors + 50 or 70 years depending the country. I don't think that
really matters.

Emmanuel Bourg

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

garydgregory
In reply to this post by Emmanuel Bourg-3
I fixed the notice file in svn.

Gary

<div>-------- Original message --------</div><div>From: Oliver Heger <[hidden email]> </div><div>Date:09/27/2014  09:48  (GMT-05:00) </div><div>To: Commons Developers List <[hidden email]> </div><div>Subject: Re: [VOTE] Release BCEL 6.0 based on RC3 </div><div>
</div>-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Build works fine with Java 1.5 and 1.7 on Windows 8.1. Artifacts look
good. The site shows that the code base probably needs some work to
improve quality, but this does not block the release.

Nits:
- - The NOTICE file states the wrong copyright year.
- - The distribution files of other Commons components start with the
commons- prefix. This is not the case here.

I am not sure how problematic the wrong copyright year is, also from a
legal PoV. This prevents me from voting +1; everything else is not
blocking.

Oliver

Am 27.09.2014 um 09:50 schrieb Emmanuel Bourg:
> Hi all,
>
> The third release candidate of BCEL is ready to pass under your
> scrutiny.
>
> Tag:
> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC3/
>
>
(r1627908)

>
> Release notes:
> http://people.apache.org/~ebourg/bcel/RELEASE-NOTES.txt
>
> Distribution files: http://people.apache.org/~ebourg/bcel/
>
> Checksums (sha1): 6f1d11224b7cea98ffbffa25d69d759fcd47421c
> bcel-6.0-bin.tar.gz 425729b886f72481bdbfc7e8ca108f20c00e67ef
> bcel-6.0-bin.zip 89e171be63df397d23ea746f9845cf3087e8467e
> bcel-6.0-src.tar.gz a03c2e605b8eb997b5d023d6a7d6aa54fbf3600e
> bcel-6.0-src.zip
>
> Site: http://people.apache.org/~ebourg/bcel/site/
>
> Javadoc: http://people.apache.org/~ebourg/bcel/site/apidocs/
>
> Maven artifacts:
> https://repository.apache.org/content/repositories/orgapachecommons-1047/org/apache/bcel/bcel/6.0/
>
>
>
> Please review the release candidate and vote. This vote will close
> no sooner that 72 hours from now.
>
> [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but
> really should fix... [ ] -1 I oppose this release because...
>
> Thank you for your reviews,
>
> Emmanuel Bourg
>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)

iQEcBAEBAgAGBQJUJsAyAAoJEDgk3dGBGEE4j18IALlBJsgK9Kf0APSQdst8Idui
65zuBrApxqy/dpxT51m8egk8zWasG+PIu686jAjcs9Hwj23STtHKX0DXKnQVCw6Q
mrsnnxHZZ4BHRFp8PUeu6kKz+KuTOVmJmoHBg+DusbHkxCD07bIFxHx81v200tbG
UHOSE/+tdSo7urOC98YTMZ1Ikg+zonRG2GTE1PWgNXsS+E/wM/U0y3MFkEEUginV
FGWscZgflUcBJkME9J5trvDM14khFQi6OmpZKNk4Ld54N6NmoM15Tq4nsDWSKhNX
050R4Cg1W2onmZLlBy/Vox3owTvM9B+jh3hn7CmlNpSVH88dG3A+FcB6QFSXGf4=
=lDGf
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

Oliver Heger-3
Hi Gary,

can you confirm that a wrong copyright date is not a blocker for a
release? If so, I vote +1.

Oliver

Am 27.09.2014 um 21:27 schrieb Gary Gregory:

> I fixed the notice file in svn.
>
> Gary
>
> <div>-------- Original message --------</div><div>From: Oliver Heger <[hidden email]> </div><div>Date:09/27/2014  09:48  (GMT-05:00) </div><div>To: Commons Developers List <[hidden email]> </div><div>Subject: Re: [VOTE] Release BCEL 6.0 based on RC3 </div><div>
> </div>-----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Build works fine with Java 1.5 and 1.7 on Windows 8.1. Artifacts look
> good. The site shows that the code base probably needs some work to
> improve quality, but this does not block the release.
>
> Nits:
> - - The NOTICE file states the wrong copyright year.
> - - The distribution files of other Commons components start with the
> commons- prefix. This is not the case here.
>
> I am not sure how problematic the wrong copyright year is, also from a
> legal PoV. This prevents me from voting +1; everything else is not
> blocking.
>
> Oliver
>
> Am 27.09.2014 um 09:50 schrieb Emmanuel Bourg:
>> Hi all,
>>
>> The third release candidate of BCEL is ready to pass under your
>> scrutiny.
>>
>> Tag:
>> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC3/
>>
>>
> (r1627908)
>>
>> Release notes:
>> http://people.apache.org/~ebourg/bcel/RELEASE-NOTES.txt
>>
>> Distribution files: http://people.apache.org/~ebourg/bcel/
>>
>> Checksums (sha1): 6f1d11224b7cea98ffbffa25d69d759fcd47421c
>> bcel-6.0-bin.tar.gz 425729b886f72481bdbfc7e8ca108f20c00e67ef
>> bcel-6.0-bin.zip 89e171be63df397d23ea746f9845cf3087e8467e
>> bcel-6.0-src.tar.gz a03c2e605b8eb997b5d023d6a7d6aa54fbf3600e
>> bcel-6.0-src.zip
>>
>> Site: http://people.apache.org/~ebourg/bcel/site/
>>
>> Javadoc: http://people.apache.org/~ebourg/bcel/site/apidocs/
>>
>> Maven artifacts:
>> https://repository.apache.org/content/repositories/orgapachecommons-1047/org/apache/bcel/bcel/6.0/
>>
>>
>>
>> Please review the release candidate and vote. This vote will close
>> no sooner that 72 hours from now.
>>
>> [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but
>> really should fix... [ ] -1 I oppose this release because...
>>
>> Thank you for your reviews,
>>
>> Emmanuel Bourg
>>
>>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.22 (MingW32)
>
> iQEcBAEBAgAGBQJUJsAyAAoJEDgk3dGBGEE4j18IALlBJsgK9Kf0APSQdst8Idui
> 65zuBrApxqy/dpxT51m8egk8zWasG+PIu686jAjcs9Hwj23STtHKX0DXKnQVCw6Q
> mrsnnxHZZ4BHRFp8PUeu6kKz+KuTOVmJmoHBg+DusbHkxCD07bIFxHx81v200tbG
> UHOSE/+tdSo7urOC98YTMZ1Ikg+zonRG2GTE1PWgNXsS+E/wM/U0y3MFkEEUginV
> FGWscZgflUcBJkME9J5trvDM14khFQi6OmpZKNk4Ld54N6NmoM15Tq4nsDWSKhNX
> 050R4Cg1W2onmZLlBy/Vox3owTvM9B+jh3hn7CmlNpSVH88dG3A+FcB6QFSXGf4=
> =lDGf
> -----END PGP SIGNATURE-----
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

garydgregory
Since IANAL, I'll abstain from opining, I think asking @legal would be the
safest bet; OTOH, rolling another RC keeps @legal out of the loop and is
simple.

I realize that rolling RC after RC is a pain and that our release process
is not friction free, but it's what we've got for now.

Gary

On Sat, Sep 27, 2014 at 3:30 PM, Oliver Heger <[hidden email]>
wrote:

> Hi Gary,
>
> can you confirm that a wrong copyright date is not a blocker for a
> release? If so, I vote +1.
>
> Oliver
>
> Am 27.09.2014 um 21:27 schrieb Gary Gregory:
> > I fixed the notice file in svn.
> >
> > Gary
> >
> > <div>-------- Original message --------</div><div>From: Oliver Heger <
> [hidden email]> </div><div>Date:09/27/2014  09:48
> (GMT-05:00) </div><div>To: Commons Developers List <[hidden email]>
> </div><div>Subject: Re: [VOTE] Release BCEL 6.0 based on RC3 </div><div>
> > </div>-----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Build works fine with Java 1.5 and 1.7 on Windows 8.1. Artifacts look
> > good. The site shows that the code base probably needs some work to
> > improve quality, but this does not block the release.
> >
> > Nits:
> > - - The NOTICE file states the wrong copyright year.
> > - - The distribution files of other Commons components start with the
> > commons- prefix. This is not the case here.
> >
> > I am not sure how problematic the wrong copyright year is, also from a
> > legal PoV. This prevents me from voting +1; everything else is not
> > blocking.
> >
> > Oliver
> >
> > Am 27.09.2014 um 09:50 schrieb Emmanuel Bourg:
> >> Hi all,
> >>
> >> The third release candidate of BCEL is ready to pass under your
> >> scrutiny.
> >>
> >> Tag:
> >> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC3/
> >>
> >>
> > (r1627908)
> >>
> >> Release notes:
> >> http://people.apache.org/~ebourg/bcel/RELEASE-NOTES.txt
> >>
> >> Distribution files: http://people.apache.org/~ebourg/bcel/
> >>
> >> Checksums (sha1): 6f1d11224b7cea98ffbffa25d69d759fcd47421c
> >> bcel-6.0-bin.tar.gz 425729b886f72481bdbfc7e8ca108f20c00e67ef
> >> bcel-6.0-bin.zip 89e171be63df397d23ea746f9845cf3087e8467e
> >> bcel-6.0-src.tar.gz a03c2e605b8eb997b5d023d6a7d6aa54fbf3600e
> >> bcel-6.0-src.zip
> >>
> >> Site: http://people.apache.org/~ebourg/bcel/site/
> >>
> >> Javadoc: http://people.apache.org/~ebourg/bcel/site/apidocs/
> >>
> >> Maven artifacts:
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-1047/org/apache/bcel/bcel/6.0/
> >>
> >>
> >>
> >> Please review the release candidate and vote. This vote will close
> >> no sooner that 72 hours from now.
> >>
> >> [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but
> >> really should fix... [ ] -1 I oppose this release because...
> >>
> >> Thank you for your reviews,
> >>
> >> Emmanuel Bourg
> >>
> >>
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v2.0.22 (MingW32)
> >
> > iQEcBAEBAgAGBQJUJsAyAAoJEDgk3dGBGEE4j18IALlBJsgK9Kf0APSQdst8Idui
> > 65zuBrApxqy/dpxT51m8egk8zWasG+PIu686jAjcs9Hwj23STtHKX0DXKnQVCw6Q
> > mrsnnxHZZ4BHRFp8PUeu6kKz+KuTOVmJmoHBg+DusbHkxCD07bIFxHx81v200tbG
> > UHOSE/+tdSo7urOC98YTMZ1Ikg+zonRG2GTE1PWgNXsS+E/wM/U0y3MFkEEUginV
> > FGWscZgflUcBJkME9J5trvDM14khFQi6OmpZKNk4Ld54N6NmoM15Tq4nsDWSKhNX
> > 050R4Cg1W2onmZLlBy/Vox3owTvM9B+jh3hn7CmlNpSVH88dG3A+FcB6QFSXGf4=
> > =lDGf
> > -----END PGP SIGNATURE-----
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

Konstantin Kolinko
In reply to this post by Emmanuel Bourg-3
2014-09-27 11:50 GMT+04:00 Emmanuel Bourg <[hidden email]>:

> Hi all,
>
> The third release candidate of BCEL is ready to pass under your scrutiny.
>
> Tag:
> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC3/
> (r1627908)
>
> Release notes:
> http://people.apache.org/~ebourg/bcel/RELEASE-NOTES.txt
>
> Distribution files:
> http://people.apache.org/~ebourg/bcel/
>
> Checksums (sha1):
> 6f1d11224b7cea98ffbffa25d69d759fcd47421c  bcel-6.0-bin.tar.gz
> 425729b886f72481bdbfc7e8ca108f20c00e67ef  bcel-6.0-bin.zip
> 89e171be63df397d23ea746f9845cf3087e8467e  bcel-6.0-src.tar.gz
> a03c2e605b8eb997b5d023d6a7d6aa54fbf3600e  bcel-6.0-src.zip
>
> Site:
> http://people.apache.org/~ebourg/bcel/site/
>
> Javadoc:
> http://people.apache.org/~ebourg/bcel/site/apidocs/
>
> Maven artifacts:
> https://repository.apache.org/content/repositories/orgapachecommons-1047/org/apache/bcel/bcel/6.0/
>

Hi!

I was reviewing the Clirr report and noted new methods that introduced
caching into classfile.ConstantUtf8  class,
such as methods ConstantUtf8.getCachedInstance()


The code originates from the following commit and JIRA issue:

http://svn.apache.org/r1481383
https://issues.apache.org/jira/browse/BCEL-163

I have the following concerns:

1) Someone was testing Tomcat usage of BCEL and found that using this
caching did not improve performance, but reduced it for our use case.
It was reported in the following Bugzilla issue:

https://issues.apache.org/bugzilla/show_bug.cgi?id=56940

2) Configuration of this cache depends on reading System properties such as

final static boolean BCEL_DONT_CACHE = Boolean.getBoolean("bcel.dontCache");

It is a bit odd to me to configure a library via system properties.

At least there could be a static setter for that flag, or a static
setter for a cache instance / a factory class.

3) RELEASE-NOTES.txt describes this change as

[BCEL-163] Incorporate patch file from Findbugs

which does not say much about this change.

Actually this change introduced caching for ConstantUtf8 and
ObjectType instances.


My experience with BCEL comes from Apache Tomcat. Tomcat uses a copy
of BCEL code. It is used to perform scanning for class-level
annotations across class files. During profiling and refactoring
several weeks ago a lot of code that is not needed for our use case
was removed from our copy. The caching code was one of them.


Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

sebb-2-2
In reply to this post by Emmanuel Bourg-3
On 27 September 2014 08:50, Emmanuel Bourg <[hidden email]> wrote:

> Hi all,
>
> The third release candidate of BCEL is ready to pass under your scrutiny.
>
> Tag:
> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC3/
> (r1627908)
>
> Release notes:
> http://people.apache.org/~ebourg/bcel/RELEASE-NOTES.txt
>
> Distribution files:
> http://people.apache.org/~ebourg/bcel/

-1 hashes are missing from the directory

Link to KEYS file is needed in the vote e-mail thread

> Checksums (sha1):
> 6f1d11224b7cea98ffbffa25d69d759fcd47421c  bcel-6.0-bin.tar.gz
> 425729b886f72481bdbfc7e8ca108f20c00e67ef  bcel-6.0-bin.zip
> 89e171be63df397d23ea746f9845cf3087e8467e  bcel-6.0-src.tar.gz
> a03c2e605b8eb997b5d023d6a7d6aa54fbf3600e  bcel-6.0-src.zip
>
> Site:
> http://people.apache.org/~ebourg/bcel/site/
>
> Javadoc:
> http://people.apache.org/~ebourg/bcel/site/apidocs/
>
> Maven artifacts:
> https://repository.apache.org/content/repositories/orgapachecommons-1047/org/apache/bcel/bcel/6.0/
>
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you for your reviews,
>
> Emmanuel Bourg
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

Emmanuel Bourg-3
Le 28/09/2014 02:36, sebb a écrit :

> -1 hashes are missing from the directory

The directory contains the PGP signatures, that's even better.

> Link to KEYS file is needed in the vote e-mail thread

As usual that's the KEYS file of the Apache Commons project, no need to
repeat it in every vote for a Commons component.

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

sebb-2-2
On 28 September 2014 07:53, Emmanuel Bourg <[hidden email]> wrote:
> Le 28/09/2014 02:36, sebb a écrit :
>
>> -1 hashes are missing from the directory
>
> The directory contains the PGP signatures, that's even better.

Sigs are necessary but not sufficient - the published artifacts must
also have at least one hash.
 aroun
>> Link to KEYS file is needed in the vote e-mail thread
>
> As usual that's the KEYS file of the Apache Commons project, no need to
> repeat it in every vote for a Commons component.

The point is to ensure that reviewers have all the information they
need without having to search for it.
This is an open source project; we should make it possible for anyone
following the dev list to review the RC.

> Emmanuel Bourg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

Emmanuel Bourg-3
Le 28/09/2014 14:58, sebb a écrit :

> Sigs are necessary but not sufficient - the published artifacts must
> also have at least one hash.

I added the hashes.

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

Emmanuel Bourg-3
In reply to this post by Konstantin Kolinko
Hi Konstantin,

Thank you very much for the feedback.

> I have the following concerns:
>
> 1) Someone was testing Tomcat usage of BCEL and found that using this
> caching did not improve performance, but reduced it for our use case.
> It was reported in the following Bugzilla issue:
>
> https://issues.apache.org/bugzilla/show_bug.cgi?id=56940

Do you have more details on the size of the jars used to measure the
performance? Did the test let enough time for the JIT to kick in?


> 2) Configuration of this cache depends on reading System properties such as
>
> final static boolean BCEL_DONT_CACHE = Boolean.getBoolean("bcel.dontCache");
>
> It is a bit odd to me to configure a library via system properties.
>
> At least there could be a static setter for that flag, or a static
> setter for a cache instance / a factory class.

I agree, a system property was probably good for Findbugs if it forks
its own VM, but not for a general purpose library.


> 3) RELEASE-NOTES.txt describes this change as
>
> [BCEL-163] Incorporate patch file from Findbugs
>
> which does not say much about this change.
>
> Actually this change introduced caching for ConstantUtf8 and
> ObjectType instances.

I'll update it if I roll a new RC.

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

Konstantin Kolinko
2014-09-30 14:50 GMT+04:00 Emmanuel Bourg <[hidden email]>:

> Hi Konstantin,
>
> Thank you very much for the feedback.
>
>> I have the following concerns:
>>
>> 1) Someone was testing Tomcat usage of BCEL and found that using this
>> caching did not improve performance, but reduced it for our use case.
>> It was reported in the following Bugzilla issue:
>>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=56940
>
> Do you have more details on the size of the jars used to measure the
> performance? Did the test let enough time for the JIT to kick in?

It was Mark Thomas who did the testing. Maybe he will add something to
the discussion.

AFAIK jars from JIRA web application were used for the test. From
comment on commit that removed the cache, the difference was 10-15%,
for our copy of BCEL that already had other optimizations (code
removal) applied:

http://svn.apache.org/r1624476

The test code:
http://svn.apache.org/viewvc/tomcat/tc8.0.x/tags/TOMCAT_8_0_14/test/org/apache/tomcat/util/bcel/TesterPerformance.java?view=markup


>> 2) Configuration of this cache depends on reading System properties such as
>>
>> final static boolean BCEL_DONT_CACHE = Boolean.getBoolean("bcel.dontCache");
>>
>> It is a bit odd to me to configure a library via system properties.
>>
>> At least there could be a static setter for that flag, or a static
>> setter for a cache instance / a factory class.
>
> I agree, a system property was probably good for Findbugs if it forks
> its own VM, but not for a general purpose library.
>


Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

Emmanuel Bourg-3
Le 30/09/2014 14:15, Konstantin Kolinko a écrit :

> AFAIK jars from JIRA web application were used for the test. From
> comment on commit that removed the cache, the difference was 10-15%,
> for our copy of BCEL that already had other optimizations (code
> removal) applied:

I ran the PerformanceTest class applied on the rt.jar file from Java 8.
For ClassParser.parse() I get 1300ms when the cache is enabled, and
820ms without (~37% faster). Using a HashMap instead of a LinkedHashMap
is slightly faster (1200ms) but the cache entries are no longer evicted
automatically.

On the memory side, the benefit of the cache was more perceptible.
Parsing rt.jar created ~10MB of ConstantUtf8 instances with the cache
enabled, and 27MB without. At the end the cache retained 20000 instances
for a total of ~450KB and there is no way to clear it.

If nobody object I'll remove this cache, the impact on the performance
is too important to enable it by default, and the static state smells
like a quick and dirty implementation. This feature could return as a
pluggable cache if someone wants to provide a patch.

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

Emmanuel Bourg-3
Le 07/10/2014 11:26, Emmanuel Bourg a écrit :

> If nobody object I'll remove this cache, the impact on the performance
> is too important to enable it by default, and the static state smells
> like a quick and dirty implementation. This feature could return as a
> pluggable cache if someone wants to provide a patch.

I looked at the cache in ObjectType, this one keeps only 200 instances.
When parsing rt.jar it saved 92% of the ObjectType instances and ~13MB
of memory. The overhead was about 7% (820ms instead of 767ms).

I wonder if this one is worth keeping.

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

garydgregory
On Tue, Oct 7, 2014 at 7:48 AM, Emmanuel Bourg <[hidden email]> wrote:

> Le 07/10/2014 11:26, Emmanuel Bourg a écrit :
>
> > If nobody object I'll remove this cache, the impact on the performance
> > is too important to enable it by default, and the static state smells
> > like a quick and dirty implementation. This feature could return as a
> > pluggable cache if someone wants to provide a patch.
>
> I looked at the cache in ObjectType, this one keeps only 200 instances.
> When parsing rt.jar it saved 92% of the ObjectType instances and ~13MB
> of memory. The overhead was about 7% (820ms instead of 767ms).
>
> I wonder if this one is worth keeping.
>

Can you flush it? Can you disable it?

Gary

>
> Emmanuel Bourg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

Emmanuel Bourg-3
Le 07/10/2014 13:51, Gary Gregory a écrit :

> Can you flush it? Can you disable it?

No, but the size retained is reasonable.

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

garydgregory
Adding a clear method seems reasonable for app that are "long" running.

Gary

On Tue, Oct 7, 2014 at 8:00 AM, Emmanuel Bourg <[hidden email]> wrote:

> Le 07/10/2014 13:51, Gary Gregory a écrit :
>
> > Can you flush it? Can you disable it?
>
> No, but the size retained is reasonable.
>
> Emmanuel Bourg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

Jörg Schaible
In reply to this post by Emmanuel Bourg-3

+1

builds from source-tarball with my complete compiler zoo

Emmanuel Bourg wrote:

> Hi all,
>
> The third release candidate of BCEL is ready to pass under your scrutiny.
>
> Tag:
> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC3/
> (r1627908)
>
> Release notes:
> http://people.apache.org/~ebourg/bcel/RELEASE-NOTES.txt
>
> Distribution files:
> http://people.apache.org/~ebourg/bcel/
>
> Checksums (sha1):
> 6f1d11224b7cea98ffbffa25d69d759fcd47421c  bcel-6.0-bin.tar.gz
> 425729b886f72481bdbfc7e8ca108f20c00e67ef  bcel-6.0-bin.zip
> 89e171be63df397d23ea746f9845cf3087e8467e  bcel-6.0-src.tar.gz
> a03c2e605b8eb997b5d023d6a7d6aa54fbf3600e  bcel-6.0-src.zip
>
> Site:
> http://people.apache.org/~ebourg/bcel/site/
>
> Javadoc:
> http://people.apache.org/~ebourg/bcel/site/apidocs/
>
> Maven artifacts:
>
https://repository.apache.org/content/repositories/orgapachecommons-1047/org/apache/bcel/bcel/6.0/

>
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you for your reviews,
>
> Emmanuel Bourg



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release BCEL 6.0 based on RC3

Dave Brosius-2
+1
On 10/08/2014 01:54 PM, Jörg Schaible wrote:

> +1
>
> builds from source-tarball with my complete compiler zoo
>
> Emmanuel Bourg wrote:
>
>> Hi all,
>>
>> The third release candidate of BCEL is ready to pass under your scrutiny.
>>
>> Tag:
>> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC3/
>> (r1627908)
>>
>> Release notes:
>> http://people.apache.org/~ebourg/bcel/RELEASE-NOTES.txt
>>
>> Distribution files:
>> http://people.apache.org/~ebourg/bcel/
>>
>> Checksums (sha1):
>> 6f1d11224b7cea98ffbffa25d69d759fcd47421c  bcel-6.0-bin.tar.gz
>> 425729b886f72481bdbfc7e8ca108f20c00e67ef  bcel-6.0-bin.zip
>> 89e171be63df397d23ea746f9845cf3087e8467e  bcel-6.0-src.tar.gz
>> a03c2e605b8eb997b5d023d6a7d6aa54fbf3600e  bcel-6.0-src.zip
>>
>> Site:
>> http://people.apache.org/~ebourg/bcel/site/
>>
>> Javadoc:
>> http://people.apache.org/~ebourg/bcel/site/apidocs/
>>
>> Maven artifacts:
>>
> https://repository.apache.org/content/repositories/orgapachecommons-1047/org/apache/bcel/bcel/6.0/
>>
>> Please review the release candidate and vote.
>> This vote will close no sooner that 72 hours from now.
>>
>>    [ ] +1 Release these artifacts
>>    [ ] +0 OK, but...
>>    [ ] -0 OK, but really should fix...
>>    [ ] -1 I oppose this release because...
>>
>> Thank you for your reviews,
>>
>> Emmanuel Bourg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

1234