[VOTE] Release CRYPTO 1.0.0 based on RC1

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release CRYPTO 1.0.0 based on RC1

Sun, Dapeng
Hi all,



Apache Commons CRYPTO was established at May 9, 2016, There are presently numbers of resolved issues fix in CRYPTO. We also fix the legal issue.



Apache Commons CRYPTO 1.0.0 is available for review here:

https://dist.apache.org/repos/dist/dev/commons/crypto

(rev 14538)



The tag is here:

https://git-wip-us.apache.org/repos/asf?p=commons-crypto.git;a=tag;h=refs/tags/CRYPTO-1.0.0-RC1

(commit 782ca06a1f9a292756fbad9eb9841e685cd34af1)



Maven artifacts:



https://repository.apache.org/content/repositories/orgapachecommons-1191/org/apache/commons/commons-crypto/1.0.0/



I've tested with Java 7 & 8 using Maven 3.0.5 on Mac OS 64bits/Linux 64&32bits/Windows 64&32 bits



Details of changes are in the release notes:

https://dist.apache.org/repos/dist/dev/commons/crypto/RELEASE-NOTES.txt

http://home.apache.org/~sdp/crypto-1.0.0-rc1/changes-report.html



Site:

  http://home.apache.org/~sdp/crypto-1.0.0-rc1/

(note some links are broken, these will be OK once the site is deployed)



Clirr Report:

Not generating Clirr report as there is no previous version of the library to compare against.



RAT Report:

  http://home.apache.org/~sdp/crypto-1.0.0-rc1/rat-report.html



KEYS:

  https://www.apache.org/dist/commons/KEYS



Please review the release candidate and vote. This vote will close no sooner than 72 hours from now, i.e. sometime after 13:00 CST 29-July 2016



[ ] +1 Release these artifacts

[ ] +0 OK, but...

[ ] -0 OK, but really should fix...

[ ] -1 I oppose this release because...



Thanks & Regards

Dapeng

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release CRYPTO 1.0.0 based on RC1

Benedikt Ritter-4
Hello Dapeng,

first of all: Great work moving Crypto to Apache Commons and creating your
first release candidate for the Apache Commons Project. I'm very happy to
see this happening and I hope you and the other former Chimera developers
are still happy with moving the code to Commons.

Here is my review of this RC:

- Release notes look good. Minor nit: they don't mention the minimum
required Java version.
- BUILDING.txt is very descriptive, good work
- Website looks good
- signs and hashes are good

I've tried the build with:

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T17:41:47+01:00)
Maven home: /usr/local/Cellar/maven/3.3.9/libexec
Java version: 1.7.0_79, vendor: Oracle Corporation
Java home:
/Library/Java/JavaVirtualMachines/jdk1.7.0_79.jdk/Contents/Home/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac"

I get an error:

JceCipherTest.checkJceUnlimitedStrength:44 Testing requires support for an
AES key length of 256, but the detected maximum key length is 128.  This
may indicate that the test environment is missing the JCE Unlimited
Strength Jurisdiction Policy Files.

I have installed the necessary files, but it doesn't work. I suspect that
there's something wrong with my JDK installation.

I've tried building with:

Java HotSpot(TM) 64-Bit Server VM warning: ignoring option
MaxPermSize=128m; support was removed in 8.0
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T17:41:47+01:00)
Maven home: /usr/local/Cellar/maven/3.3.9/libexec
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home:
/Library/Java/JavaVirtualMachines/jdk1.8.0_91.jdk/Contents/Home/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac"

And it works perfectly fine.

Since the build failure is probably related to my environment:

+1

Regards,
Benedikt

Sun, Dapeng <[hidden email]> schrieb am Di., 26. Juli 2016 um
05:25 Uhr:

> Hi all,
>
>
>
> Apache Commons CRYPTO was established at May 9, 2016, There are presently
> numbers of resolved issues fix in CRYPTO. We also fix the legal issue.
>
>
>
> Apache Commons CRYPTO 1.0.0 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/crypto
>
> (rev 14538)
>
>
>
> The tag is here:
>
>
> https://git-wip-us.apache.org/repos/asf?p=commons-crypto.git;a=tag;h=refs/tags/CRYPTO-1.0.0-RC1
>
> (commit 782ca06a1f9a292756fbad9eb9841e685cd34af1)
>
>
>
> Maven artifacts:
>
>
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-1191/org/apache/commons/commons-crypto/1.0.0/
>
>
>
> I've tested with Java 7 & 8 using Maven 3.0.5 on Mac OS 64bits/Linux
> 64&32bits/Windows 64&32 bits
>
>
>
> Details of changes are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/crypto/RELEASE-NOTES.txt
>
> http://home.apache.org/~sdp/crypto-1.0.0-rc1/changes-report.html
>
>
>
> Site:
>
>   http://home.apache.org/~sdp/crypto-1.0.0-rc1/
>
> (note some links are broken, these will be OK once the site is deployed)
>
>
>
> Clirr Report:
>
> Not generating Clirr report as there is no previous version of the library
> to compare against.
>
>
>
> RAT Report:
>
>   http://home.apache.org/~sdp/crypto-1.0.0-rc1/rat-report.html
>
>
>
> KEYS:
>
>   https://www.apache.org/dist/commons/KEYS
>
>
>
> Please review the release candidate and vote. This vote will close no
> sooner than 72 hours from now, i.e. sometime after 13:00 CST 29-July 2016
>
>
>
> [ ] +1 Release these artifacts
>
> [ ] +0 OK, but...
>
> [ ] -0 OK, but really should fix...
>
> [ ] -1 I oppose this release because...
>
>
>
> Thanks & Regards
>
> Dapeng
>
>
Reply | Threaded
Open this post in threaded view
|

RE: [VOTE] Release CRYPTO 1.0.0 based on RC1

Sun, Dapeng
Thank Benedikt for the detailed report.

>>JceCipherTest.checkJceUnlimitedStrength:44 Testing requires support for an AES key length of 256, but the detected maximum key length is 128.  This may indicate that the test environment is missing the JCE Unlimited Strength Jurisdiction Policy Files.
Yes, the failure is caused by missing JCE Unlimited Strength Jurisdiction Policy Files. Installed JCE Unlimited Strength Jurisdiction Policy Files according BUILDING.txt would fix it.

>> Release notes look good. Minor nit: they don't mention the minimum required Java version.
Thank you for pointing it out. I will pay attention on next time.

Thanks,
Dapeng

-----Original Message-----
From: Benedikt Ritter [mailto:[hidden email]]
Sent: Thursday, July 28, 2016 2:14 AM
To: Commons Developers List
Subject: Re: [VOTE] Release CRYPTO 1.0.0 based on RC1

Hello Dapeng,

first of all: Great work moving Crypto to Apache Commons and creating your first release candidate for the Apache Commons Project. I'm very happy to see this happening and I hope you and the other former Chimera developers are still happy with moving the code to Commons.

Here is my review of this RC:

- Release notes look good. Minor nit: they don't mention the minimum required Java version.
- BUILDING.txt is very descriptive, good work
- Website looks good
- signs and hashes are good

I've tried the build with:

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T17:41:47+01:00)
Maven home: /usr/local/Cellar/maven/3.3.9/libexec
Java version: 1.7.0_79, vendor: Oracle Corporation Java home:
/Library/Java/JavaVirtualMachines/jdk1.7.0_79.jdk/Contents/Home/jre
Default locale: de_DE, platform encoding: UTF-8 OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac"

I get an error:

JceCipherTest.checkJceUnlimitedStrength:44 Testing requires support for an AES key length of 256, but the detected maximum key length is 128.  This may indicate that the test environment is missing the JCE Unlimited Strength Jurisdiction Policy Files.

I have installed the necessary files, but it doesn't work. I suspect that there's something wrong with my JDK installation.

I've tried building with:

Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=128m; support was removed in 8.0 Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T17:41:47+01:00)
Maven home: /usr/local/Cellar/maven/3.3.9/libexec
Java version: 1.8.0_91, vendor: Oracle Corporation Java home:
/Library/Java/JavaVirtualMachines/jdk1.8.0_91.jdk/Contents/Home/jre
Default locale: de_DE, platform encoding: UTF-8 OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac"

And it works perfectly fine.

Since the build failure is probably related to my environment:

+1

Regards,
Benedikt

Sun, Dapeng <[hidden email]> schrieb am Di., 26. Juli 2016 um
05:25 Uhr:

> Hi all,
>
>
>
> Apache Commons CRYPTO was established at May 9, 2016, There are
> presently numbers of resolved issues fix in CRYPTO. We also fix the legal issue.
>
>
>
> Apache Commons CRYPTO 1.0.0 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/crypto
>
> (rev 14538)
>
>
>
> The tag is here:
>
>
> https://git-wip-us.apache.org/repos/asf?p=commons-crypto.git;a=tag;h=r
> efs/tags/CRYPTO-1.0.0-RC1
>
> (commit 782ca06a1f9a292756fbad9eb9841e685cd34af1)
>
>
>
> Maven artifacts:
>
>
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-11
> 91/org/apache/commons/commons-crypto/1.0.0/
>
>
>
> I've tested with Java 7 & 8 using Maven 3.0.5 on Mac OS 64bits/Linux
> 64&32bits/Windows 64&32 bits
>
>
>
> Details of changes are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/crypto/RELEASE-NOTES.tx
> t
>
> http://home.apache.org/~sdp/crypto-1.0.0-rc1/changes-report.html
>
>
>
> Site:
>
>   http://home.apache.org/~sdp/crypto-1.0.0-rc1/
>
> (note some links are broken, these will be OK once the site is
> deployed)
>
>
>
> Clirr Report:
>
> Not generating Clirr report as there is no previous version of the
> library to compare against.
>
>
>
> RAT Report:
>
>   http://home.apache.org/~sdp/crypto-1.0.0-rc1/rat-report.html
>
>
>
> KEYS:
>
>   https://www.apache.org/dist/commons/KEYS
>
>
>
> Please review the release candidate and vote. This vote will close no
> sooner than 72 hours from now, i.e. sometime after 13:00 CST 29-July
> 2016
>
>
>
> [ ] +1 Release these artifacts
>
> [ ] +0 OK, but...
>
> [ ] -0 OK, but really should fix...
>
> [ ] -1 I oppose this release because...
>
>
>
> Thanks & Regards
>
> Dapeng
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release CRYPTO 1.0.0 based on RC1

Jörg Schaible
In reply to this post by Sun, Dapeng
Hi,

I am building crypto with my compiler zoo on Gentoo Linux with OpenSSL 1.02h
installed. Even compiling with Java 9 works, tests fail only because of a
missing jce.

Running the tests I get always those two warnings:

==================== %< ======================
Running org.apache.commons.crypto.NativeCodeLoaderTest
** WARN: Native (JNI) code was not loaded: java.lang.UnsatisfiedLinkError:
/tmp/commons-crypto-9c688d6a-fc55-4a35-9d78-79cedd4ad842-libcommons-
crypto.so: /tmp/commons-crypto-9c688d6a-fc55-4a35-9d78-79cedd4ad842-
libcommons-crypto.so: failed to map segment from shared object
Tests run: 5, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 0.008 sec -
in org.apache.commons.crypto.NativeCodeLoaderTest
Running org.apache.commons.crypto.jna.OpenSslNativeJnaTest
** WARN: JNA could not be enabled:
/tmp/jna--1154654109/jna4836274946397519400.tmp:
/tmp/jna--1154654109/jna4836274946397519400.tmp: failed to map segment from
shared object
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in
org.apache.commons.crypto.jna.OpenSslNativeJnaTest
==================== %< ======================

The build of the shared library produces additional warnings for OpenJDK 7
(and OpenJDK 8 produces same warning):
==================== %< ======================
[INFO] --- maven-antrun-plugin:1.8:run (make) @ commons-crypto ---
[INFO] Executing tasks

make:
     [exec] "/home/joehni/.gentoo/java-config-2/current-user-vm/bin/javah" -
force -classpath target/classes -o target/jni-
classes/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.h
org.apache.commons.crypto.random.OpenSslCryptoRandomNative
     [exec] gcc -Ilib/inc_linux -I/home/joehni/.gentoo/java-
config-2/current-user-vm/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden
-m64 -Ilib/include -I/usr/include -
I"src/main/native/org/apache/commons/crypto/" -I"/home/joehni/.gentoo/java-
config-2/current-user-vm/include/linux" -I"target/jni-
classes/org/apache/commons/crypto/cipher" -I"target/jni-
classes/org/apache/commons/crypto/random" -c
src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c
-o target/commons-crypto-1.0.0-Linux-x86_64/OpenSslCryptoRandomNative.o
     [exec] In file included from
src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c:19:0:
     [exec]
src/main/native/org/apache/commons/crypto/random/org_apache_commons_crypto_random.h:24:0:
warning: "UNUSED" redefined
     [exec]  #define UNUSED(x) ((void)(x))
     [exec]  ^
     [exec] In file included from /home/joehni/.gentoo/java-
config-2/current-user-vm/include/jni.h:45:0,
     [exec]                  from
src/main/native/org/apache/commons/crypto/org_apache_commons_crypto.h:71,
     [exec]                  from
src/main/native/org/apache/commons/crypto/random/org_apache_commons_crypto_random.h:22,
     [exec]                  from
src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c:19:
     [exec] /home/joehni/.gentoo/java-config-2/current-user-
vm/include/linux/jni_md.h:40:0: note: this is the location of the previous
definition
     [exec]    #define UNUSED(x) UNUSED_ ## x __attribute__((__unused__))
     [exec]  ^
     [exec] "/home/joehni/.gentoo/java-config-2/current-user-vm/bin/javah" -
force -classpath target/classes -o target/jni-
classes/org/apache/commons/crypto/cipher/OpenSslNative.h
org.apache.commons.crypto.cipher.OpenSslNative
     [exec] gcc -Ilib/inc_linux -I/home/joehni/.gentoo/java-
config-2/current-user-vm/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden
-m64 -Ilib/include -I/usr/include -
I"src/main/native/org/apache/commons/crypto/" -I"/home/joehni/.gentoo/java-
config-2/current-user-vm/include/linux" -I"target/jni-
classes/org/apache/commons/crypto/cipher" -I"target/jni-
classes/org/apache/commons/crypto/random" -c
src/main/native/org/apache/commons/crypto/cipher/OpenSslNative.c -o
target/commons-crypto-1.0.0-Linux-x86_64/OpenSslNative.o
     [exec] "/home/joehni/.gentoo/java-config-2/current-user-vm/bin/javah" -
force -classpath target/classes -o target/jni-
classes/org/apache/commons/crypto/OpenSslInfoNative.h
org.apache.commons.crypto.OpenSslInfoNative
     [exec] gcc -Ilib/inc_linux -I/home/joehni/.gentoo/java-
config-2/current-user-vm/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden
-m64 -Ilib/include -I/usr/include -
I"src/main/native/org/apache/commons/crypto/" -I"/home/joehni/.gentoo/java-
config-2/current-user-vm/include/linux" -I"target/jni-
classes/org/apache/commons/crypto/cipher" -I"target/jni-
classes/org/apache/commons/crypto/random" -DVERSION='"1.0.0"' -
DPROJECT_NAME='"Apache Commons Crypto"' -I"target/jni-
classes/org/apache/commons/crypto" -c
src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c -o
target/commons-crypto-1.0.0-Linux-x86_64/OpenSslInfoNative.o
     [exec] g++ -Ilib/inc_linux -I/home/joehni/.gentoo/java-
config-2/current-user-vm/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden
-m64 -Ilib/include  -I/usr/include -I"/home/joehni/.gentoo/java-
config-2/current-user-vm/include/linux" -I"target/jni-
classes/org/apache/commons/crypto/cipher" -I"target/jni-
classes/org/apache/commons/crypto/random" -o target/commons-crypto-1.0.0-
Linux-x86_64/libcommons-crypto.so target/commons-crypto-1.0.0-Linux-
x86_64/OpenSslCryptoRandomNative.o target/commons-crypto-1.0.0-Linux-
x86_64/OpenSslNative.o target/commons-crypto-1.0.0-Linux-
x86_64/OpenSslInfoNative.o -shared -static-libgcc -static-libstdc++
     [exec] strip target/commons-crypto-1.0.0-Linux-x86_64/libcommons-
crypto.so
     [exec] cp target/commons-crypto-1.0.0-Linux-x86_64/libcommons-crypto.so
target/classes/org/apache/commons/crypto/native/Linux/x86_64/libcommons-
crypto.so
     [exec] cp target/commons-crypto-1.0.0-Linux-x86_64/libcommons-crypto.so
target/classes/org/apache/commons/crypto/native/Linux/x86_64/libcommons-
crypto.so
==================== %< ======================
$ java -version
java version "1.7.0_101"
OpenJDK Runtime Environment (IcedTea 2.6.6) (Gentoo icedtea-7.2.6.6)
OpenJDK 64-Bit Server VM (build 24.95-b01, mixed mode)
==================== %< ======================


However, the build first fails and then hangs in a unit test when building
with IBM JDK 7:
==================== %< ======================
[...]
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.commons.crypto.stream.CtrCryptoStreamTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.129 sec -
in org.apache.commons.crypto.stream.CtrCryptoStreamTest
Running org.apache.commons.crypto.stream.CtrNoPaddingCipherStreamTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.05 sec -
in org.apache.commons.crypto.stream.CtrNoPaddingCipherStreamTest
Running org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest
Tests run: 2, Failures: 0, Errors: 1, Skipped: 1, Time elapsed: 0.068 sec
<<< FAILURE! - in
org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest
doTestJCE(org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest)  
Time elapsed: 0.057 sec  <<< ERROR!
java.nio.BufferUnderflowException
        at
org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest.testPositionedReadLoop(PositionedCryptoInputStreamTest.java:226)
        at
org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest.doPositionedReadTests(PositionedCryptoInputStreamTest.java:154)
        at
org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest.testCipher(PositionedCryptoInputStreamTest.java:107)
        at
org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest.doTestJCE(PositionedCryptoInputStreamTest.java:97)

Running org.apache.commons.crypto.stream.CbcNoPaddingCipherStreamTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.115 sec -
in org.apache.commons.crypto.stream.CbcNoPaddingCipherStreamTest
Running org.apache.commons.crypto.stream.CbcPkcs5PaddingCipherStreamTest
^C
==================== %< ======================
$ java -version
java version "1.7.0"
Java(TM) SE Runtime Environment (build pxa6470sr5-20130619_01(SR5))
IBM J9 VM (build 2.6, JRE 1.7.0 Linux amd64-64 Compressed References
20130617_152572 (JIT enabled, AOT enabled)
J9VM - R26_Java726_SR5_20130617_1436_B152572
JIT  - r11.b04_20130528_38954ifx1
GC   - R26_Java726_SR5_20130617_1436_B152572_CMPRSS
J9CL - 20130617_152572)
JCL - 20130616_01 based on Oracle 7u25-b12
==================== %< ======================

Cheers,
Jörg



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release CRYPTO 1.0.0 based on RC1

Hendrik Dev
In reply to this post by Sun, Dapeng
+1

On Tue, Jul 26, 2016 at 5:25 AM, Sun, Dapeng <[hidden email]> wrote:

> Hi all,
>
>
>
> Apache Commons CRYPTO was established at May 9, 2016, There are presently numbers of resolved issues fix in CRYPTO. We also fix the legal issue.
>
>
>
> Apache Commons CRYPTO 1.0.0 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/crypto
>
> (rev 14538)
>
>
>
> The tag is here:
>
> https://git-wip-us.apache.org/repos/asf?p=commons-crypto.git;a=tag;h=refs/tags/CRYPTO-1.0.0-RC1
>
> (commit 782ca06a1f9a292756fbad9eb9841e685cd34af1)
>
>
>
> Maven artifacts:
>
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-1191/org/apache/commons/commons-crypto/1.0.0/
>
>
>
> I've tested with Java 7 & 8 using Maven 3.0.5 on Mac OS 64bits/Linux 64&32bits/Windows 64&32 bits
>
>
>
> Details of changes are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/crypto/RELEASE-NOTES.txt
>
> http://home.apache.org/~sdp/crypto-1.0.0-rc1/changes-report.html
>
>
>
> Site:
>
>   http://home.apache.org/~sdp/crypto-1.0.0-rc1/
>
> (note some links are broken, these will be OK once the site is deployed)
>
>
>
> Clirr Report:
>
> Not generating Clirr report as there is no previous version of the library to compare against.
>
>
>
> RAT Report:
>
>   http://home.apache.org/~sdp/crypto-1.0.0-rc1/rat-report.html
>
>
>
> KEYS:
>
>   https://www.apache.org/dist/commons/KEYS
>
>
>
> Please review the release candidate and vote. This vote will close no sooner than 72 hours from now, i.e. sometime after 13:00 CST 29-July 2016
>
>
>
> [ ] +1 Release these artifacts
>
> [ ] +0 OK, but...
>
> [ ] -0 OK, but really should fix...
>
> [ ] -1 I oppose this release because...
>
>
>
> Thanks & Regards
>
> Dapeng
>



--
Hendrik Saly (salyh, hendrikdev22)
@hendrikdev22
PGP: 0x22D7F6EC

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

RE: [VOTE] Release CRYPTO 1.0.0 based on RC1

Ke, Xianda
In reply to this post by Jörg Schaible
Hi Jörg,

I guess that the two warnings were caused by the permission of java.io.tmpdir (/tmp ).
Crypto extracts *.so to java.io.tmpdir(or commons-crypto.tempdir).  
Try adding exec permission.

Regards,
Xianda

-----Original Message-----
From: Jörg Schaible [mailto:[hidden email]]
Sent: Friday, July 29, 2016 5:04 AM
To: [hidden email]
Subject: Re: [VOTE] Release CRYPTO 1.0.0 based on RC1

Hi,

I am building crypto with my compiler zoo on Gentoo Linux with OpenSSL 1.02h installed. Even compiling with Java 9 works, tests fail only because of a missing jce.

Running the tests I get always those two warnings:

==================== %< ====================== Running org.apache.commons.crypto.NativeCodeLoaderTest
** WARN: Native (JNI) code was not loaded: java.lang.UnsatisfiedLinkError:
/tmp/commons-crypto-9c688d6a-fc55-4a35-9d78-79cedd4ad842-libcommons-
crypto.so: /tmp/commons-crypto-9c688d6a-fc55-4a35-9d78-79cedd4ad842-
libcommons-crypto.so: failed to map segment from shared object Tests run: 5, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 0.008 sec - in org.apache.commons.crypto.NativeCodeLoaderTest
Running org.apache.commons.crypto.jna.OpenSslNativeJnaTest
** WARN: JNA could not be enabled:
/tmp/jna--1154654109/jna4836274946397519400.tmp:
/tmp/jna--1154654109/jna4836274946397519400.tmp: failed to map segment from shared object Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.apache.commons.crypto.jna.OpenSslNativeJnaTest
==================== %< ======================

The build of the shared library produces additional warnings for OpenJDK 7 (and OpenJDK 8 produces same warning):
==================== %< ====================== [INFO] --- maven-antrun-plugin:1.8:run (make) @ commons-crypto --- [INFO] Executing tasks

make:
     [exec] "/home/joehni/.gentoo/java-config-2/current-user-vm/bin/javah" - force -classpath target/classes -o target/jni- classes/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.h
org.apache.commons.crypto.random.OpenSslCryptoRandomNative
     [exec] gcc -Ilib/inc_linux -I/home/joehni/.gentoo/java- config-2/current-user-vm/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden
-m64 -Ilib/include -I/usr/include -
I"src/main/native/org/apache/commons/crypto/" -I"/home/joehni/.gentoo/java- config-2/current-user-vm/include/linux" -I"target/jni- classes/org/apache/commons/crypto/cipher" -I"target/jni- classes/org/apache/commons/crypto/random" -c src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c
-o target/commons-crypto-1.0.0-Linux-x86_64/OpenSslCryptoRandomNative.o
     [exec] In file included from
src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c:19:0:
     [exec]
src/main/native/org/apache/commons/crypto/random/org_apache_commons_crypto_random.h:24:0:
warning: "UNUSED" redefined
     [exec]  #define UNUSED(x) ((void)(x))
     [exec]  ^
     [exec] In file included from /home/joehni/.gentoo/java- config-2/current-user-vm/include/jni.h:45:0,
     [exec]                  from
src/main/native/org/apache/commons/crypto/org_apache_commons_crypto.h:71,
     [exec]                  from
src/main/native/org/apache/commons/crypto/random/org_apache_commons_crypto_random.h:22,
     [exec]                  from
src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c:19:
     [exec] /home/joehni/.gentoo/java-config-2/current-user-
vm/include/linux/jni_md.h:40:0: note: this is the location of the previous definition
     [exec]    #define UNUSED(x) UNUSED_ ## x __attribute__((__unused__))
     [exec]  ^
     [exec] "/home/joehni/.gentoo/java-config-2/current-user-vm/bin/javah" - force -classpath target/classes -o target/jni- classes/org/apache/commons/crypto/cipher/OpenSslNative.h
org.apache.commons.crypto.cipher.OpenSslNative
     [exec] gcc -Ilib/inc_linux -I/home/joehni/.gentoo/java- config-2/current-user-vm/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden
-m64 -Ilib/include -I/usr/include -
I"src/main/native/org/apache/commons/crypto/" -I"/home/joehni/.gentoo/java- config-2/current-user-vm/include/linux" -I"target/jni- classes/org/apache/commons/crypto/cipher" -I"target/jni- classes/org/apache/commons/crypto/random" -c src/main/native/org/apache/commons/crypto/cipher/OpenSslNative.c -o target/commons-crypto-1.0.0-Linux-x86_64/OpenSslNative.o
     [exec] "/home/joehni/.gentoo/java-config-2/current-user-vm/bin/javah" - force -classpath target/classes -o target/jni- classes/org/apache/commons/crypto/OpenSslInfoNative.h
org.apache.commons.crypto.OpenSslInfoNative
     [exec] gcc -Ilib/inc_linux -I/home/joehni/.gentoo/java- config-2/current-user-vm/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden
-m64 -Ilib/include -I/usr/include -
I"src/main/native/org/apache/commons/crypto/" -I"/home/joehni/.gentoo/java- config-2/current-user-vm/include/linux" -I"target/jni- classes/org/apache/commons/crypto/cipher" -I"target/jni- classes/org/apache/commons/crypto/random" -DVERSION='"1.0.0"' - DPROJECT_NAME='"Apache Commons Crypto"' -I"target/jni- classes/org/apache/commons/crypto" -c src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c -o target/commons-crypto-1.0.0-Linux-x86_64/OpenSslInfoNative.o
     [exec] g++ -Ilib/inc_linux -I/home/joehni/.gentoo/java- config-2/current-user-vm/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden
-m64 -Ilib/include  -I/usr/include -I"/home/joehni/.gentoo/java- config-2/current-user-vm/include/linux" -I"target/jni- classes/org/apache/commons/crypto/cipher" -I"target/jni- classes/org/apache/commons/crypto/random" -o target/commons-crypto-1.0.0- Linux-x86_64/libcommons-crypto.so target/commons-crypto-1.0.0-Linux-
x86_64/OpenSslCryptoRandomNative.o target/commons-crypto-1.0.0-Linux-
x86_64/OpenSslNative.o target/commons-crypto-1.0.0-Linux-
x86_64/OpenSslInfoNative.o -shared -static-libgcc -static-libstdc++
     [exec] strip target/commons-crypto-1.0.0-Linux-x86_64/libcommons-
crypto.so
     [exec] cp target/commons-crypto-1.0.0-Linux-x86_64/libcommons-crypto.so
target/classes/org/apache/commons/crypto/native/Linux/x86_64/libcommons-
crypto.so
     [exec] cp target/commons-crypto-1.0.0-Linux-x86_64/libcommons-crypto.so
target/classes/org/apache/commons/crypto/native/Linux/x86_64/libcommons-
crypto.so
==================== %< ====================== $ java -version java version "1.7.0_101"
OpenJDK Runtime Environment (IcedTea 2.6.6) (Gentoo icedtea-7.2.6.6) OpenJDK 64-Bit Server VM (build 24.95-b01, mixed mode) ==================== %< ======================


However, the build first fails and then hangs in a unit test when building with IBM JDK 7:
==================== %< ====================== [...]
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.commons.crypto.stream.CtrCryptoStreamTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.129 sec - in org.apache.commons.crypto.stream.CtrCryptoStreamTest
Running org.apache.commons.crypto.stream.CtrNoPaddingCipherStreamTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.05 sec - in org.apache.commons.crypto.stream.CtrNoPaddingCipherStreamTest
Running org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest
Tests run: 2, Failures: 0, Errors: 1, Skipped: 1, Time elapsed: 0.068 sec <<< FAILURE! - in org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest
doTestJCE(org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest)
Time elapsed: 0.057 sec  <<< ERROR!
java.nio.BufferUnderflowException
        at
org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest.testPositionedReadLoop(PositionedCryptoInputStreamTest.java:226)
        at
org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest.doPositionedReadTests(PositionedCryptoInputStreamTest.java:154)
        at
org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest.testCipher(PositionedCryptoInputStreamTest.java:107)
        at
org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest.doTestJCE(PositionedCryptoInputStreamTest.java:97)

Running org.apache.commons.crypto.stream.CbcNoPaddingCipherStreamTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.115 sec - in org.apache.commons.crypto.stream.CbcNoPaddingCipherStreamTest
Running org.apache.commons.crypto.stream.CbcPkcs5PaddingCipherStreamTest
^C
==================== %< ====================== $ java -version java version "1.7.0"
Java(TM) SE Runtime Environment (build pxa6470sr5-20130619_01(SR5)) IBM J9 VM (build 2.6, JRE 1.7.0 Linux amd64-64 Compressed References
20130617_152572 (JIT enabled, AOT enabled) J9VM - R26_Java726_SR5_20130617_1436_B152572
JIT  - r11.b04_20130528_38954ifx1
GC   - R26_Java726_SR5_20130617_1436_B152572_CMPRSS
J9CL - 20130617_152572)
JCL - 20130616_01 based on Oracle 7u25-b12 ==================== %< ======================

Cheers,
Jörg



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]
Reply | Threaded
Open this post in threaded view
|

RE: [VOTE] Release CRYPTO 1.0.0 based on RC1

Sun, Dapeng
In reply to this post by Jörg Schaible
Thank Jörg for the testing.

>>I am building crypto with my compiler zoo on Gentoo Linux with OpenSSL 1.02h installed.
I don't have environment with Gentoo Linux, I just tested the library with OpenJDK on pure Ubuntu OS: OpenJDK 7 on Ubuntu 14.04 and OpenJDK 8 on Ubuntu 16.04, All of them are passed:

Here are the steps for the pure Ubuntu OS
1. Install essential tools
apt-get update
apt-get install openjdk-7-jdk (on 14.04)/ apt-get install openjdk-8-jdk (on 16.04)
apt-get install make gcc g++ git

2.Install Openssl development tools
apt-get install libssl-dev

3.Set maven and JAVA_HOME

4.git clone the source code and run "mvn clean test"

Here are the version for the two environment
For Ubuntu 16.04
Java version is
openjdk version "1.8.0_91"
OpenJDK Runtime Environment (build 1.8.0_91-8u91-b14-3ubuntu1~16.04.1-b14)
OpenJDK 64-Bit Server VM (build 25.91-b14, mixed mode)

Openssl version is
OpenSSL 1.0.2g-fips  1 Mar 2016

For Ubuntu 14.04
Java version is
java version "1.7.0_101"
OpenJDK Runtime Environment (IcedTea 2.6.6) (7u101-2.6.6-0ubuntu0.14.04.1) OpenJDK 64-Bit Server VM (build 24.95-b01, mixed mode)

Openssl version is
OpenSSL 1.0.1f 6 Jan 2014

Is your Openssl got from OS repo, if you compiled it yourself, do you add "shared" to you config args before make?

>> However, the build first fails and then hangs in a unit test when building with IBM JDK 7

About building CRYPTO on IBM JDK, I wonder if we should support it, because even for different minor versions of IBM JDK 7, the JNI header files may be changed, the change would be cause some weird failures at native. But the binary would be right, I have test the RC1 on latest IBM JDK 7 from their official website, all the tests are okay.

About the build fails, I did't encounter it before, if it is the same environment with openjdk, I think we can fix the Openssl shade issue first, if we encounter it again, we can run the pure unit tests, I uploaded them to my personal repo: https://github.com/sundapeng/TCRYPTO.git, could you help verify it in your environment?( The cached files in maven should be cleaned before test, for example: rm ~/.m2/repository/org/apache/commons/commons-crypto/ -rf).

About the test hang, if the hanging UT is the test for JavaSecureRandom, it should be an issue about SecureRandom in JDK. https://bugs.openjdk.java.net/browse/JDK-6577564


Here is the IBM JDK in my environment:
java version "1.7.0"
Java(TM) SE Runtime Environment (build pxa6470_27sr3fp40-20160422_01(SR3 FP40))
IBM J9 VM (build 2.7, JRE 1.7.0 Linux amd64-64 Compressed References 20160406_298393 (JIT enabled, AOT enabled)
J9VM - R27_Java727_SR3_20160406_0942_B298393
JIT  - tr.r13.java_20160328_114186
GC   - R27_Java727_SR3_20160406_0942_B298393_CMPRSS
J9CL - 20160406_298393)
JCL - 20160421_01 based on Oracle jdk7u101-b14


Regards
Dapeng

-----Original Message-----
From: Jörg Schaible [mailto:[hidden email]]
Sent: Friday, July 29, 2016 5:04 AM
To: [hidden email]
Subject: Re: [VOTE] Release CRYPTO 1.0.0 based on RC1

Hi,

I am building crypto with my compiler zoo on Gentoo Linux with OpenSSL 1.02h installed. Even compiling with Java 9 works, tests fail only because of a missing jce.

Running the tests I get always those two warnings:

==================== %< ====================== Running org.apache.commons.crypto.NativeCodeLoaderTest
** WARN: Native (JNI) code was not loaded: java.lang.UnsatisfiedLinkError:
/tmp/commons-crypto-9c688d6a-fc55-4a35-9d78-79cedd4ad842-libcommons-
crypto.so: /tmp/commons-crypto-9c688d6a-fc55-4a35-9d78-79cedd4ad842-
libcommons-crypto.so: failed to map segment from shared object Tests run: 5, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 0.008 sec - in org.apache.commons.crypto.NativeCodeLoaderTest
Running org.apache.commons.crypto.jna.OpenSslNativeJnaTest
** WARN: JNA could not be enabled:
/tmp/jna--1154654109/jna4836274946397519400.tmp:
/tmp/jna--1154654109/jna4836274946397519400.tmp: failed to map segment from shared object Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.apache.commons.crypto.jna.OpenSslNativeJnaTest
==================== %< ======================

The build of the shared library produces additional warnings for OpenJDK 7 (and OpenJDK 8 produces same warning):
==================== %< ====================== [INFO] --- maven-antrun-plugin:1.8:run (make) @ commons-crypto --- [INFO] Executing tasks

make:
     [exec] "/home/joehni/.gentoo/java-config-2/current-user-vm/bin/javah" - force -classpath target/classes -o target/jni- classes/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.h
org.apache.commons.crypto.random.OpenSslCryptoRandomNative
     [exec] gcc -Ilib/inc_linux -I/home/joehni/.gentoo/java- config-2/current-user-vm/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden
-m64 -Ilib/include -I/usr/include -
I"src/main/native/org/apache/commons/crypto/" -I"/home/joehni/.gentoo/java- config-2/current-user-vm/include/linux" -I"target/jni- classes/org/apache/commons/crypto/cipher" -I"target/jni- classes/org/apache/commons/crypto/random" -c src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c
-o target/commons-crypto-1.0.0-Linux-x86_64/OpenSslCryptoRandomNative.o
     [exec] In file included from
src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c:19:0:
     [exec]
src/main/native/org/apache/commons/crypto/random/org_apache_commons_crypto_random.h:24:0:
warning: "UNUSED" redefined
     [exec]  #define UNUSED(x) ((void)(x))
     [exec]  ^
     [exec] In file included from /home/joehni/.gentoo/java- config-2/current-user-vm/include/jni.h:45:0,
     [exec]                  from
src/main/native/org/apache/commons/crypto/org_apache_commons_crypto.h:71,
     [exec]                  from
src/main/native/org/apache/commons/crypto/random/org_apache_commons_crypto_random.h:22,
     [exec]                  from
src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c:19:
     [exec] /home/joehni/.gentoo/java-config-2/current-user-
vm/include/linux/jni_md.h:40:0: note: this is the location of the previous definition
     [exec]    #define UNUSED(x) UNUSED_ ## x __attribute__((__unused__))
     [exec]  ^
     [exec] "/home/joehni/.gentoo/java-config-2/current-user-vm/bin/javah" - force -classpath target/classes -o target/jni- classes/org/apache/commons/crypto/cipher/OpenSslNative.h
org.apache.commons.crypto.cipher.OpenSslNative
     [exec] gcc -Ilib/inc_linux -I/home/joehni/.gentoo/java- config-2/current-user-vm/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden
-m64 -Ilib/include -I/usr/include -
I"src/main/native/org/apache/commons/crypto/" -I"/home/joehni/.gentoo/java- config-2/current-user-vm/include/linux" -I"target/jni- classes/org/apache/commons/crypto/cipher" -I"target/jni- classes/org/apache/commons/crypto/random" -c src/main/native/org/apache/commons/crypto/cipher/OpenSslNative.c -o target/commons-crypto-1.0.0-Linux-x86_64/OpenSslNative.o
     [exec] "/home/joehni/.gentoo/java-config-2/current-user-vm/bin/javah" - force -classpath target/classes -o target/jni- classes/org/apache/commons/crypto/OpenSslInfoNative.h
org.apache.commons.crypto.OpenSslInfoNative
     [exec] gcc -Ilib/inc_linux -I/home/joehni/.gentoo/java- config-2/current-user-vm/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden
-m64 -Ilib/include -I/usr/include -
I"src/main/native/org/apache/commons/crypto/" -I"/home/joehni/.gentoo/java- config-2/current-user-vm/include/linux" -I"target/jni- classes/org/apache/commons/crypto/cipher" -I"target/jni- classes/org/apache/commons/crypto/random" -DVERSION='"1.0.0"' - DPROJECT_NAME='"Apache Commons Crypto"' -I"target/jni- classes/org/apache/commons/crypto" -c src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c -o target/commons-crypto-1.0.0-Linux-x86_64/OpenSslInfoNative.o
     [exec] g++ -Ilib/inc_linux -I/home/joehni/.gentoo/java- config-2/current-user-vm/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden
-m64 -Ilib/include  -I/usr/include -I"/home/joehni/.gentoo/java- config-2/current-user-vm/include/linux" -I"target/jni- classes/org/apache/commons/crypto/cipher" -I"target/jni- classes/org/apache/commons/crypto/random" -o target/commons-crypto-1.0.0- Linux-x86_64/libcommons-crypto.so target/commons-crypto-1.0.0-Linux-
x86_64/OpenSslCryptoRandomNative.o target/commons-crypto-1.0.0-Linux-
x86_64/OpenSslNative.o target/commons-crypto-1.0.0-Linux-
x86_64/OpenSslInfoNative.o -shared -static-libgcc -static-libstdc++
     [exec] strip target/commons-crypto-1.0.0-Linux-x86_64/libcommons-
crypto.so
     [exec] cp target/commons-crypto-1.0.0-Linux-x86_64/libcommons-crypto.so
target/classes/org/apache/commons/crypto/native/Linux/x86_64/libcommons-
crypto.so
     [exec] cp target/commons-crypto-1.0.0-Linux-x86_64/libcommons-crypto.so
target/classes/org/apache/commons/crypto/native/Linux/x86_64/libcommons-
crypto.so
==================== %< ====================== $ java -version java version "1.7.0_101"
OpenJDK Runtime Environment (IcedTea 2.6.6) (Gentoo icedtea-7.2.6.6) OpenJDK 64-Bit Server VM (build 24.95-b01, mixed mode) ==================== %< ======================


However, the build first fails and then hangs in a unit test when building with IBM JDK 7:
==================== %< ====================== [...]
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.commons.crypto.stream.CtrCryptoStreamTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.129 sec - in org.apache.commons.crypto.stream.CtrCryptoStreamTest
Running org.apache.commons.crypto.stream.CtrNoPaddingCipherStreamTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.05 sec - in org.apache.commons.crypto.stream.CtrNoPaddingCipherStreamTest
Running org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest
Tests run: 2, Failures: 0, Errors: 1, Skipped: 1, Time elapsed: 0.068 sec <<< FAILURE! - in org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest
doTestJCE(org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest)
Time elapsed: 0.057 sec  <<< ERROR!
java.nio.BufferUnderflowException
        at
org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest.testPositionedReadLoop(PositionedCryptoInputStreamTest.java:226)
        at
org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest.doPositionedReadTests(PositionedCryptoInputStreamTest.java:154)
        at
org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest.testCipher(PositionedCryptoInputStreamTest.java:107)
        at
org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest.doTestJCE(PositionedCryptoInputStreamTest.java:97)

Running org.apache.commons.crypto.stream.CbcNoPaddingCipherStreamTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.115 sec - in org.apache.commons.crypto.stream.CbcNoPaddingCipherStreamTest
Running org.apache.commons.crypto.stream.CbcPkcs5PaddingCipherStreamTest
^C
==================== %< ====================== $ java -version java version "1.7.0"
Java(TM) SE Runtime Environment (build pxa6470sr5-20130619_01(SR5)) IBM J9 VM (build 2.6, JRE 1.7.0 Linux amd64-64 Compressed References
20130617_152572 (JIT enabled, AOT enabled) J9VM - R26_Java726_SR5_20130617_1436_B152572
JIT  - r11.b04_20130528_38954ifx1
GC   - R26_Java726_SR5_20130617_1436_B152572_CMPRSS
J9CL - 20130617_152572)
JCL - 20130616_01 based on Oracle 7u25-b12 ==================== %< ======================

Cheers,
Jörg



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]
Reply | Threaded
Open this post in threaded view
|

RE: [VOTE] Release CRYPTO 1.0.0 based on RC1

Jörg Schaible
In reply to this post by Ke, Xianda
Hi Xianda,

Ke, Xianda wrote:

> Hi Jörg,
>
> I guess that the two warnings were caused by the permission of
> java.io.tmpdir (/tmp ). Crypto extracts *.so to java.io.tmpdir(or
> commons-crypto.tempdir). Try adding exec permission.

That's it! Running

 mvn clean package -Djava.io.tmpdir=$HOME/tmp

did the trick. Setting commons-crypto.tempdir the same way did not work.

Cheers,
Jörg

>
> Regards,
> Xianda
>
> -----Original Message-----
> From: Jörg Schaible [mailto:[hidden email]]
> Sent: Friday, July 29, 2016 5:04 AM
> To: [hidden email]
> Subject: Re: [VOTE] Release CRYPTO 1.0.0 based on RC1
>
> Hi,
>
> I am building crypto with my compiler zoo on Gentoo Linux with OpenSSL
> 1.02h installed. Even compiling with Java 9 works, tests fail only because
> of a missing jce.
>
> Running the tests I get always those two warnings:
>
> ==================== %< ====================== Running
> org.apache.commons.crypto.NativeCodeLoaderTest ** WARN: Native (JNI) code
> was not loaded: java.lang.UnsatisfiedLinkError:
> /tmp/commons-crypto-9c688d6a-fc55-4a35-9d78-79cedd4ad842-libcommons-
> crypto.so: /tmp/commons-crypto-9c688d6a-fc55-4a35-9d78-79cedd4ad842-
> libcommons-crypto.so: failed to map segment from shared object Tests run:
> 5, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 0.008 sec - in
> org.apache.commons.crypto.NativeCodeLoaderTest Running
> org.apache.commons.crypto.jna.OpenSslNativeJnaTest ** WARN: JNA could not
> be enabled: /tmp/jna--1154654109/jna4836274946397519400.tmp:
> /tmp/jna--1154654109/jna4836274946397519400.tmp: failed to map segment
> from shared object Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time
> elapsed: 0 sec - in org.apache.commons.crypto.jna.OpenSslNativeJnaTest
> ==================== %< ======================
>
> The build of the shared library produces additional warnings for OpenJDK 7
> (and OpenJDK 8 produces same warning): ==================== %<
> ====================== [INFO] --- maven-antrun-plugin:1.8:run (make) @
> commons-crypto --- [INFO] Executing tasks
>
> make:
>      [exec] "/home/joehni/.gentoo/java-config-2/current-user-vm/bin/javah"
>      [- force -classpath target/classes -o target/jni-
>      [classes/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.h
> org.apache.commons.crypto.random.OpenSslCryptoRandomNative
>      [exec] gcc -Ilib/inc_linux -I/home/joehni/.gentoo/java-
>      [config-2/current-user-vm/include -Ilib/inc_mac -O2 -fPIC
>      [-fvisibility=hidden
> -m64 -Ilib/include -I/usr/include -
> I"src/main/native/org/apache/commons/crypto/"
> -I"/home/joehni/.gentoo/java- config-2/current-user-vm/include/linux"
> -I"target/jni- classes/org/apache/commons/crypto/cipher" -I"target/jni-
> classes/org/apache/commons/crypto/random" -c
>
src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c
> -o target/commons-crypto-1.0.0-Linux-x86_64/OpenSslCryptoRandomNative.o
>      [exec] In file included from
>
src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c:19:0:
>      [exec]
>
src/main/native/org/apache/commons/crypto/random/org_apache_commons_crypto_random.h:24:0:
> warning: "UNUSED" redefined
>      [exec]  #define UNUSED(x) ((void)(x))
>      [exec]  ^
>      [exec] In file included from /home/joehni/.gentoo/java-
>      [config-2/current-user-vm/include/jni.h:45:0,
>      [exec]                  from
> src/main/native/org/apache/commons/crypto/org_apache_commons_crypto.h:71,
>      [exec]                  from
>
src/main/native/org/apache/commons/crypto/random/org_apache_commons_crypto_random.h:22,
>      [exec]                  from
>
src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c:19:

>      [exec] /home/joehni/.gentoo/java-config-2/current-user-
> vm/include/linux/jni_md.h:40:0: note: this is the location of the previous
> definition
>      [exec]    #define UNUSED(x) UNUSED_ ## x __attribute__((__unused__))
>      [exec]  ^
>      [exec] "/home/joehni/.gentoo/java-config-2/current-user-vm/bin/javah"
>      [- force -classpath target/classes -o target/jni-
>      [classes/org/apache/commons/crypto/cipher/OpenSslNative.h
> org.apache.commons.crypto.cipher.OpenSslNative
>      [exec] gcc -Ilib/inc_linux -I/home/joehni/.gentoo/java-
>      [config-2/current-user-vm/include -Ilib/inc_mac -O2 -fPIC
>      [-fvisibility=hidden
> -m64 -Ilib/include -I/usr/include -
> I"src/main/native/org/apache/commons/crypto/"
> -I"/home/joehni/.gentoo/java- config-2/current-user-vm/include/linux"
> -I"target/jni- classes/org/apache/commons/crypto/cipher" -I"target/jni-
> classes/org/apache/commons/crypto/random" -c
> src/main/native/org/apache/commons/crypto/cipher/OpenSslNative.c -o
> target/commons-crypto-1.0.0-Linux-x86_64/OpenSslNative.o
>      [exec] "/home/joehni/.gentoo/java-config-2/current-user-vm/bin/javah"
>      [- force -classpath target/classes -o target/jni-
>      [classes/org/apache/commons/crypto/OpenSslInfoNative.h
> org.apache.commons.crypto.OpenSslInfoNative
>      [exec] gcc -Ilib/inc_linux -I/home/joehni/.gentoo/java-
>      [config-2/current-user-vm/include -Ilib/inc_mac -O2 -fPIC
>      [-fvisibility=hidden
> -m64 -Ilib/include -I/usr/include -
> I"src/main/native/org/apache/commons/crypto/"
> -I"/home/joehni/.gentoo/java- config-2/current-user-vm/include/linux"
> -I"target/jni- classes/org/apache/commons/crypto/cipher" -I"target/jni-
> classes/org/apache/commons/crypto/random" -DVERSION='"1.0.0"' -
> DPROJECT_NAME='"Apache Commons Crypto"' -I"target/jni-
> classes/org/apache/commons/crypto" -c
> src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c -o
> target/commons-crypto-1.0.0-Linux-x86_64/OpenSslInfoNative.o
>      [exec] g++ -Ilib/inc_linux -I/home/joehni/.gentoo/java-
>      [config-2/current-user-vm/include -Ilib/inc_mac -O2 -fPIC
>      [-fvisibility=hidden
> -m64 -Ilib/include  -I/usr/include -I"/home/joehni/.gentoo/java-
> config-2/current-user-vm/include/linux" -I"target/jni-
> classes/org/apache/commons/crypto/cipher" -I"target/jni-
> classes/org/apache/commons/crypto/random" -o target/commons-crypto-1.0.0-
> Linux-x86_64/libcommons-crypto.so target/commons-crypto-1.0.0-Linux-
> x86_64/OpenSslCryptoRandomNative.o target/commons-crypto-1.0.0-Linux-
> x86_64/OpenSslNative.o target/commons-crypto-1.0.0-Linux-
> x86_64/OpenSslInfoNative.o -shared -static-libgcc -static-libstdc++
>      [exec] strip target/commons-crypto-1.0.0-Linux-x86_64/libcommons-
> crypto.so
>      [exec] cp
>      [target/commons-crypto-1.0.0-Linux-x86_64/libcommons-crypto.so
> target/classes/org/apache/commons/crypto/native/Linux/x86_64/libcommons-
> crypto.so
>      [exec] cp
>      [target/commons-crypto-1.0.0-Linux-x86_64/libcommons-crypto.so
> target/classes/org/apache/commons/crypto/native/Linux/x86_64/libcommons-
> crypto.so
> ==================== %< ====================== $ java -version java
> version "1.7.0_101" OpenJDK Runtime Environment (IcedTea 2.6.6) (Gentoo
> icedtea-7.2.6.6) OpenJDK 64-Bit Server VM (build 24.95-b01, mixed mode)
> ==================== %< ======================
>
>
> However, the build first fails and then hangs in a unit test when building
> with IBM JDK 7: ==================== %< ====================== [...]
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running org.apache.commons.crypto.stream.CtrCryptoStreamTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.129 sec
> - in org.apache.commons.crypto.stream.CtrCryptoStreamTest Running
> org.apache.commons.crypto.stream.CtrNoPaddingCipherStreamTest Tests run:
> 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.05 sec - in
> org.apache.commons.crypto.stream.CtrNoPaddingCipherStreamTest Running
> org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest Tests
> run: 2, Failures: 0, Errors: 1, Skipped: 1, Time elapsed: 0.068 sec <<<
> FAILURE! - in
> org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest
>
doTestJCE(org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest)
> Time elapsed: 0.057 sec  <<< ERROR!
> java.nio.BufferUnderflowException
>         at
>
org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest.testPositionedReadLoop(PositionedCryptoInputStreamTest.java:226)
>         at
>
org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest.doPositionedReadTests(PositionedCryptoInputStreamTest.java:154)
>         at
>
org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest.testCipher(PositionedCryptoInputStreamTest.java:107)
>         at
>
org.apache.commons.crypto.stream.PositionedCryptoInputStreamTest.doTestJCE(PositionedCryptoInputStreamTest.java:97)

>
> Running org.apache.commons.crypto.stream.CbcNoPaddingCipherStreamTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.115 sec
> - in org.apache.commons.crypto.stream.CbcNoPaddingCipherStreamTest Running
> org.apache.commons.crypto.stream.CbcPkcs5PaddingCipherStreamTest ^C
> ==================== %< ====================== $ java -version java
> version "1.7.0" Java(TM) SE Runtime Environment (build
> pxa6470sr5-20130619_01(SR5)) IBM J9 VM (build 2.6, JRE 1.7.0 Linux
> amd64-64 Compressed References 20130617_152572 (JIT enabled, AOT enabled)
> J9VM - R26_Java726_SR5_20130617_1436_B152572
> JIT  - r11.b04_20130528_38954ifx1
> GC   - R26_Java726_SR5_20130617_1436_B152572_CMPRSS
> J9CL - 20130617_152572)
> JCL - 20130616_01 based on Oracle 7u25-b12 ==================== %<
> ======================
>
> Cheers,
> Jörg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

RE: [VOTE] Release CRYPTO 1.0.0 based on RC1

Jörg Schaible
In reply to this post by Sun, Dapeng
Sun, Dapeng wrote:

> Thank Jörg for the testing.
>
>>>I am building crypto with my compiler zoo on Gentoo Linux with OpenSSL
>>>1.02h installed.
> I don't have environment with Gentoo Linux, I just tested the library with
> OpenJDK on pure Ubuntu OS: OpenJDK 7 on Ubuntu 14.04 and OpenJDK 8 on
> Ubuntu 16.04, All of them are passed:

As Xianda found out, my /tmp is missing the exec permission. So the behavior
was quite normal.

[snip]

>>> However, the build first fails and then hangs in a unit test when
>>> building with IBM JDK 7
>
> About building CRYPTO on IBM JDK, I wonder if we should support it,
> because even for different minor versions of IBM JDK 7, the JNI header
> files may be changed, the change would be cause some weird failures at
> native. But the binary would be right, I have test the RC1 on latest IBM
> JDK 7 from their official website, all the tests are okay.
>
> About the build fails, I did't encounter it before, if it is the same
> environment with openjdk, I think we can fix the Openssl shade issue
> first, if we encounter it again, we can run the pure unit tests, I
> uploaded them to my personal repo:
> https://github.com/sundapeng/TCRYPTO.git, could you help verify it in your
> environment?( The cached files in maven should be cleaned before test, for
> example: rm ~/.m2/repository/org/apache/commons/commons-crypto/ -rf).
>
> About the test hang, if the hanging UT is the test for JavaSecureRandom,
> it should be an issue about SecureRandom in JDK.
> https://bugs.openjdk.java.net/browse/JDK-6577564
>
>
> Here is the IBM JDK in my environment:
> java version "1.7.0"
> Java(TM) SE Runtime Environment (build pxa6470_27sr3fp40-20160422_01(SR3
> FP40)) IBM J9 VM (build 2.7, JRE 1.7.0 Linux amd64-64 Compressed
> References 20160406_298393 (JIT enabled, AOT enabled) J9VM -
> R27_Java727_SR3_20160406_0942_B298393
> JIT  - tr.r13.java_20160328_114186
> GC   - R27_Java727_SR3_20160406_0942_B298393_CMPRSS
> J9CL - 20160406_298393)
> JCL - 20160421_01 based on Oracle jdk7u101-b14

Well, it seems my version is rather old now, I should update it anyway. If
it works at least for you, it's also fine for me, since normally nobody
tests on IBM JDK ;-)

Therefore: +1, release it

Cheers,
Jörg



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release CRYPTO 1.0.0 based on RC1

Benedikt Ritter-4
We only have two binding votes. PMCs please review this RC and vote! :-)

Jörg Schaible <[hidden email]> schrieb am Fr., 29. Juli 2016 um
21:14:

> Sun, Dapeng wrote:
>
> > Thank Jörg for the testing.
> >
> >>>I am building crypto with my compiler zoo on Gentoo Linux with OpenSSL
> >>>1.02h installed.
> > I don't have environment with Gentoo Linux, I just tested the library
> with
> > OpenJDK on pure Ubuntu OS: OpenJDK 7 on Ubuntu 14.04 and OpenJDK 8 on
> > Ubuntu 16.04, All of them are passed:
>
> As Xianda found out, my /tmp is missing the exec permission. So the
> behavior
> was quite normal.
>
> [snip]
>
> >>> However, the build first fails and then hangs in a unit test when
> >>> building with IBM JDK 7
> >
> > About building CRYPTO on IBM JDK, I wonder if we should support it,
> > because even for different minor versions of IBM JDK 7, the JNI header
> > files may be changed, the change would be cause some weird failures at
> > native. But the binary would be right, I have test the RC1 on latest IBM
> > JDK 7 from their official website, all the tests are okay.
> >
> > About the build fails, I did't encounter it before, if it is the same
> > environment with openjdk, I think we can fix the Openssl shade issue
> > first, if we encounter it again, we can run the pure unit tests, I
> > uploaded them to my personal repo:
> > https://github.com/sundapeng/TCRYPTO.git, could you help verify it in
> your
> > environment?( The cached files in maven should be cleaned before test,
> for
> > example: rm ~/.m2/repository/org/apache/commons/commons-crypto/ -rf).
> >
> > About the test hang, if the hanging UT is the test for JavaSecureRandom,
> > it should be an issue about SecureRandom in JDK.
> > https://bugs.openjdk.java.net/browse/JDK-6577564
> >
> >
> > Here is the IBM JDK in my environment:
> > java version "1.7.0"
> > Java(TM) SE Runtime Environment (build pxa6470_27sr3fp40-20160422_01(SR3
> > FP40)) IBM J9 VM (build 2.7, JRE 1.7.0 Linux amd64-64 Compressed
> > References 20160406_298393 (JIT enabled, AOT enabled) J9VM -
> > R27_Java727_SR3_20160406_0942_B298393
> > JIT  - tr.r13.java_20160328_114186
> > GC   - R27_Java727_SR3_20160406_0942_B298393_CMPRSS
> > J9CL - 20160406_298393)
> > JCL - 20160421_01 based on Oracle jdk7u101-b14
>
> Well, it seems my version is rather old now, I should update it anyway. If
> it works at least for you, it's also fine for me, since normally nobody
> tests on IBM JDK ;-)
>
> Therefore: +1, release it
>
> Cheers,
> Jörg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release CRYPTO 1.0.0 based on RC1

Marcelo Vanzin
In reply to this post by Sun, Dapeng
+1

Verified signatures and checksums, all ok. Builds and passes unit
tests locally after installing the unlimited strength policy files.

On Mon, Jul 25, 2016 at 8:25 PM, Sun, Dapeng <[hidden email]> wrote:

> Hi all,
>
>
>
> Apache Commons CRYPTO was established at May 9, 2016, There are presently numbers of resolved issues fix in CRYPTO. We also fix the legal issue.
>
>
>
> Apache Commons CRYPTO 1.0.0 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/crypto
>
> (rev 14538)
>
>
>
> The tag is here:
>
> https://git-wip-us.apache.org/repos/asf?p=commons-crypto.git;a=tag;h=refs/tags/CRYPTO-1.0.0-RC1
>
> (commit 782ca06a1f9a292756fbad9eb9841e685cd34af1)
>
>
>
> Maven artifacts:
>
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-1191/org/apache/commons/commons-crypto/1.0.0/
>
>
>
> I've tested with Java 7 & 8 using Maven 3.0.5 on Mac OS 64bits/Linux 64&32bits/Windows 64&32 bits
>
>
>
> Details of changes are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/crypto/RELEASE-NOTES.txt
>
> http://home.apache.org/~sdp/crypto-1.0.0-rc1/changes-report.html
>
>
>
> Site:
>
>   http://home.apache.org/~sdp/crypto-1.0.0-rc1/
>
> (note some links are broken, these will be OK once the site is deployed)
>
>
>
> Clirr Report:
>
> Not generating Clirr report as there is no previous version of the library to compare against.
>
>
>
> RAT Report:
>
>   http://home.apache.org/~sdp/crypto-1.0.0-rc1/rat-report.html
>
>
>
> KEYS:
>
>   https://www.apache.org/dist/commons/KEYS
>
>
>
> Please review the release candidate and vote. This vote will close no sooner than 72 hours from now, i.e. sometime after 13:00 CST 29-July 2016
>
>
>
> [ ] +1 Release these artifacts
>
> [ ] +0 OK, but...
>
> [ ] -0 OK, but really should fix...
>
> [ ] -1 I oppose this release because...
>
>
>
> Thanks & Regards
>
> Dapeng
>



--
Marcelo

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release CRYPTO 1.0.0 based on RC1

jochen-2
In reply to this post by Benedikt Ritter-4
A bit late, but here's my +1-


On Wed, Jul 27, 2016 at 8:13 PM, Benedikt Ritter <[hidden email]> wrote:

> Hello Dapeng,
>
> first of all: Great work moving Crypto to Apache Commons and creating your
> first release candidate for the Apache Commons Project. I'm very happy to
> see this happening and I hope you and the other former Chimera developers
> are still happy with moving the code to Commons.
>
> Here is my review of this RC:
>
> - Release notes look good. Minor nit: they don't mention the minimum
> required Java version.
> - BUILDING.txt is very descriptive, good work
> - Website looks good
> - signs and hashes are good
>
> I've tried the build with:
>
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T17:41:47+01:00)
> Maven home: /usr/local/Cellar/maven/3.3.9/libexec
> Java version: 1.7.0_79, vendor: Oracle Corporation
> Java home:
> /Library/Java/JavaVirtualMachines/jdk1.7.0_79.jdk/Contents/Home/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac"
>
> I get an error:
>
> JceCipherTest.checkJceUnlimitedStrength:44 Testing requires support for an
> AES key length of 256, but the detected maximum key length is 128.  This
> may indicate that the test environment is missing the JCE Unlimited
> Strength Jurisdiction Policy Files.
>
> I have installed the necessary files, but it doesn't work. I suspect that
> there's something wrong with my JDK installation.
>
> I've tried building with:
>
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option
> MaxPermSize=128m; support was removed in 8.0
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T17:41:47+01:00)
> Maven home: /usr/local/Cellar/maven/3.3.9/libexec
> Java version: 1.8.0_91, vendor: Oracle Corporation
> Java home:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_91.jdk/Contents/Home/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac"
>
> And it works perfectly fine.
>
> Since the build failure is probably related to my environment:
>
> +1
>
> Regards,
> Benedikt
>
> Sun, Dapeng <[hidden email]> schrieb am Di., 26. Juli 2016 um
> 05:25 Uhr:
>
>> Hi all,
>>
>>
>>
>> Apache Commons CRYPTO was established at May 9, 2016, There are presently
>> numbers of resolved issues fix in CRYPTO. We also fix the legal issue.
>>
>>
>>
>> Apache Commons CRYPTO 1.0.0 is available for review here:
>>
>> https://dist.apache.org/repos/dist/dev/commons/crypto
>>
>> (rev 14538)
>>
>>
>>
>> The tag is here:
>>
>>
>> https://git-wip-us.apache.org/repos/asf?p=commons-crypto.git;a=tag;h=refs/tags/CRYPTO-1.0.0-RC1
>>
>> (commit 782ca06a1f9a292756fbad9eb9841e685cd34af1)
>>
>>
>>
>> Maven artifacts:
>>
>>
>>
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1191/org/apache/commons/commons-crypto/1.0.0/
>>
>>
>>
>> I've tested with Java 7 & 8 using Maven 3.0.5 on Mac OS 64bits/Linux
>> 64&32bits/Windows 64&32 bits
>>
>>
>>
>> Details of changes are in the release notes:
>>
>> https://dist.apache.org/repos/dist/dev/commons/crypto/RELEASE-NOTES.txt
>>
>> http://home.apache.org/~sdp/crypto-1.0.0-rc1/changes-report.html
>>
>>
>>
>> Site:
>>
>>   http://home.apache.org/~sdp/crypto-1.0.0-rc1/
>>
>> (note some links are broken, these will be OK once the site is deployed)
>>
>>
>>
>> Clirr Report:
>>
>> Not generating Clirr report as there is no previous version of the library
>> to compare against.
>>
>>
>>
>> RAT Report:
>>
>>   http://home.apache.org/~sdp/crypto-1.0.0-rc1/rat-report.html
>>
>>
>>
>> KEYS:
>>
>>   https://www.apache.org/dist/commons/KEYS
>>
>>
>>
>> Please review the release candidate and vote. This vote will close no
>> sooner than 72 hours from now, i.e. sometime after 13:00 CST 29-July 2016
>>
>>
>>
>> [ ] +1 Release these artifacts
>>
>> [ ] +0 OK, but...
>>
>> [ ] -0 OK, but really should fix...
>>
>> [ ] -1 I oppose this release because...
>>
>>
>>
>> Thanks & Regards
>>
>> Dapeng
>>
>>



--
The next time you hear: "Don't reinvent the wheel!"

http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

RE: [VOTE] Release CRYPTO 1.0.0 based on RC1

Ke, Xianda
In reply to this post by Sun, Dapeng
+1 (non-binding)
Verified locally, UT passed.

Regards,
Xianda

-----Original Message-----
From: Sun, Dapeng [mailto:[hidden email]]
Sent: Tuesday, July 26, 2016 11:25 AM
To: Commons Developers List
Subject: [VOTE] Release CRYPTO 1.0.0 based on RC1

Hi all,



Apache Commons CRYPTO was established at May 9, 2016, There are presently numbers of resolved issues fix in CRYPTO. We also fix the legal issue.



Apache Commons CRYPTO 1.0.0 is available for review here:

https://dist.apache.org/repos/dist/dev/commons/crypto

(rev 14538)



The tag is here:

https://git-wip-us.apache.org/repos/asf?p=commons-crypto.git;a=tag;h=refs/tags/CRYPTO-1.0.0-RC1

(commit 782ca06a1f9a292756fbad9eb9841e685cd34af1)



Maven artifacts:



https://repository.apache.org/content/repositories/orgapachecommons-1191/org/apache/commons/commons-crypto/1.0.0/



I've tested with Java 7 & 8 using Maven 3.0.5 on Mac OS 64bits/Linux 64&32bits/Windows 64&32 bits



Details of changes are in the release notes:

https://dist.apache.org/repos/dist/dev/commons/crypto/RELEASE-NOTES.txt

http://home.apache.org/~sdp/crypto-1.0.0-rc1/changes-report.html



Site:

  http://home.apache.org/~sdp/crypto-1.0.0-rc1/

(note some links are broken, these will be OK once the site is deployed)



Clirr Report:

Not generating Clirr report as there is no previous version of the library to compare against.



RAT Report:

  http://home.apache.org/~sdp/crypto-1.0.0-rc1/rat-report.html



KEYS:

  https://www.apache.org/dist/commons/KEYS



Please review the release candidate and vote. This vote will close no sooner than 72 hours from now, i.e. sometime after 13:00 CST 29-July 2016



[ ] +1 Release these artifacts

[ ] +0 OK, but...

[ ] -0 OK, but really should fix...

[ ] -1 I oppose this release because...



Thanks & Regards

Dapeng


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release CRYPTO 1.0.0 based on RC1

garydgregory
In reply to this post by Sun, Dapeng
I know the VOTE is closed but I wanted to note that I was able to build
with :

Apache Maven 3.3.9
Maven home: /usr/share/maven
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-i386/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-28-generic", arch: "i386", family: "unix"

Linux ggregory-VirtualBox 4.4.0-28-generic #47-Ubuntu SMP Fri Jun 24
10:08:35 UTC 2016 i686 i686 i686 GNU/Linux

BUT

the resulting jar only contains the ONE native libraries.

Where are the instructions to actually build the same jar contained in the
bin-zip with ALL of the native libraries for Windows, Mac, and Linux?

Gary

On Mon, Jul 25, 2016 at 8:25 PM, Sun, Dapeng <[hidden email]> wrote:

> Hi all,
>
>
>
> Apache Commons CRYPTO was established at May 9, 2016, There are presently
> numbers of resolved issues fix in CRYPTO. We also fix the legal issue.
>
>
>
> Apache Commons CRYPTO 1.0.0 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/crypto
>
> (rev 14538)
>
>
>
> The tag is here:
>
>
> https://git-wip-us.apache.org/repos/asf?p=commons-crypto.git;a=tag;h=refs/tags/CRYPTO-1.0.0-RC1
>
> (commit 782ca06a1f9a292756fbad9eb9841e685cd34af1)
>
>
>
> Maven artifacts:
>
>
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-1191/org/apache/commons/commons-crypto/1.0.0/
>
>
>
> I've tested with Java 7 & 8 using Maven 3.0.5 on Mac OS 64bits/Linux
> 64&32bits/Windows 64&32 bits
>
>
>
> Details of changes are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/crypto/RELEASE-NOTES.txt
>
> http://home.apache.org/~sdp/crypto-1.0.0-rc1/changes-report.html
>
>
>
> Site:
>
>   http://home.apache.org/~sdp/crypto-1.0.0-rc1/
>
> (note some links are broken, these will be OK once the site is deployed)
>
>
>
> Clirr Report:
>
> Not generating Clirr report as there is no previous version of the library
> to compare against.
>
>
>
> RAT Report:
>
>   http://home.apache.org/~sdp/crypto-1.0.0-rc1/rat-report.html
>
>
>
> KEYS:
>
>   https://www.apache.org/dist/commons/KEYS
>
>
>
> Please review the release candidate and vote. This vote will close no
> sooner than 72 hours from now, i.e. sometime after 13:00 CST 29-July 2016
>
>
>
> [ ] +1 Release these artifacts
>
> [ ] +0 OK, but...
>
> [ ] -0 OK, but really should fix...
>
> [ ] -1 I oppose this release because...
>
>
>
> Thanks & Regards
>
> Dapeng
>
>


--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

RE: [VOTE] Release CRYPTO 1.0.0 based on RC1

Sun, Dapeng
Hi Gary,

>>Where are the instructions to actually build the same jar contained in the bin-zip with ALL of the native libraries for Windows, Mac, and Linux?
Thank you for your comments. I will add a wiki for it.

According the previous discussion, I copied the native binary files complied by different platforms, and put them into target folder. Then all the native files would be packaged into one jar.


-----Original Message-----
From: Gary Gregory [mailto:[hidden email]]
Sent: Tuesday, August 02, 2016 11:31 PM
To: Commons Developers List <[hidden email]>
Subject: Re: [VOTE] Release CRYPTO 1.0.0 based on RC1

I know the VOTE is closed but I wanted to note that I was able to build with :

Apache Maven 3.3.9
Maven home: /usr/share/maven
Java version: 1.8.0_91, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-8-openjdk-i386/jre
Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "4.4.0-28-generic", arch: "i386", family: "unix"

Linux ggregory-VirtualBox 4.4.0-28-generic #47-Ubuntu SMP Fri Jun 24
10:08:35 UTC 2016 i686 i686 i686 GNU/Linux

BUT

the resulting jar only contains the ONE native libraries.

Where are the instructions to actually build the same jar contained in the bin-zip with ALL of the native libraries for Windows, Mac, and Linux?

Gary

On Mon, Jul 25, 2016 at 8:25 PM, Sun, Dapeng <[hidden email]> wrote:

> Hi all,
>
>
>
> Apache Commons CRYPTO was established at May 9, 2016, There are
> presently numbers of resolved issues fix in CRYPTO. We also fix the legal issue.
>
>
>
> Apache Commons CRYPTO 1.0.0 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/crypto
>
> (rev 14538)
>
>
>
> The tag is here:
>
>
> https://git-wip-us.apache.org/repos/asf?p=commons-crypto.git;a=tag;h=r
> efs/tags/CRYPTO-1.0.0-RC1
>
> (commit 782ca06a1f9a292756fbad9eb9841e685cd34af1)
>
>
>
> Maven artifacts:
>
>
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-11
> 91/org/apache/commons/commons-crypto/1.0.0/
>
>
>
> I've tested with Java 7 & 8 using Maven 3.0.5 on Mac OS 64bits/Linux
> 64&32bits/Windows 64&32 bits
>
>
>
> Details of changes are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/crypto/RELEASE-NOTES.tx
> t
>
> http://home.apache.org/~sdp/crypto-1.0.0-rc1/changes-report.html
>
>
>
> Site:
>
>   http://home.apache.org/~sdp/crypto-1.0.0-rc1/
>
> (note some links are broken, these will be OK once the site is
> deployed)
>
>
>
> Clirr Report:
>
> Not generating Clirr report as there is no previous version of the
> library to compare against.
>
>
>
> RAT Report:
>
>   http://home.apache.org/~sdp/crypto-1.0.0-rc1/rat-report.html
>
>
>
> KEYS:
>
>   https://www.apache.org/dist/commons/KEYS
>
>
>
> Please review the release candidate and vote. This vote will close no
> sooner than 72 hours from now, i.e. sometime after 13:00 CST 29-July
> 2016
>
>
>
> [ ] +1 Release these artifacts
>
> [ ] +0 OK, but...
>
> [ ] -0 OK, but really should fix...
>
> [ ] -1 I oppose this release because...
>
>
>
> Thanks & Regards
>
> Dapeng
>
>


--
E-Mail: [hidden email] | [hidden email] Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release CRYPTO 1.0.0 based on RC1

garydgregory
On Tue, Aug 2, 2016 at 7:19 PM, Sun, Dapeng <[hidden email]> wrote:

> Hi Gary,
>
> >>Where are the instructions to actually build the same jar contained in
> the bin-zip with ALL of the native libraries for Windows, Mac, and Linux?
> Thank you for your comments. I will add a wiki for it.
>
> According the previous discussion, I copied the native binary files
> complied by different platforms, and put them into target folder. Then all
> the native files would be packaged into one jar.
>

Ah, yes, of course. Thank you for the reminder!.

It would be neat if we could get Jenkins to do that for us!

Gary


>
> -----Original Message-----
> From: Gary Gregory [mailto:[hidden email]]
> Sent: Tuesday, August 02, 2016 11:31 PM
> To: Commons Developers List <[hidden email]>
> Subject: Re: [VOTE] Release CRYPTO 1.0.0 based on RC1
>
> I know the VOTE is closed but I wanted to note that I was able to build
> with :
>
> Apache Maven 3.3.9
> Maven home: /usr/share/maven
> Java version: 1.8.0_91, vendor: Oracle Corporation Java home:
> /usr/lib/jvm/java-8-openjdk-i386/jre
> Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version:
> "4.4.0-28-generic", arch: "i386", family: "unix"
>
> Linux ggregory-VirtualBox 4.4.0-28-generic #47-Ubuntu SMP Fri Jun 24
> 10:08:35 UTC 2016 i686 i686 i686 GNU/Linux
>
> BUT
>
> the resulting jar only contains the ONE native libraries.
>
> Where are the instructions to actually build the same jar contained in the
> bin-zip with ALL of the native libraries for Windows, Mac, and Linux?
>
> Gary
>
> On Mon, Jul 25, 2016 at 8:25 PM, Sun, Dapeng <[hidden email]> wrote:
>
> > Hi all,
> >
> >
> >
> > Apache Commons CRYPTO was established at May 9, 2016, There are
> > presently numbers of resolved issues fix in CRYPTO. We also fix the
> legal issue.
> >
> >
> >
> > Apache Commons CRYPTO 1.0.0 is available for review here:
> >
> > https://dist.apache.org/repos/dist/dev/commons/crypto
> >
> > (rev 14538)
> >
> >
> >
> > The tag is here:
> >
> >
> > https://git-wip-us.apache.org/repos/asf?p=commons-crypto.git;a=tag;h=r
> > efs/tags/CRYPTO-1.0.0-RC1
> >
> > (commit 782ca06a1f9a292756fbad9eb9841e685cd34af1)
> >
> >
> >
> > Maven artifacts:
> >
> >
> >
> >
> > https://repository.apache.org/content/repositories/orgapachecommons-11
> > 91/org/apache/commons/commons-crypto/1.0.0/
> >
> >
> >
> > I've tested with Java 7 & 8 using Maven 3.0.5 on Mac OS 64bits/Linux
> > 64&32bits/Windows 64&32 bits
> >
> >
> >
> > Details of changes are in the release notes:
> >
> > https://dist.apache.org/repos/dist/dev/commons/crypto/RELEASE-NOTES.tx
> > t
> >
> > http://home.apache.org/~sdp/crypto-1.0.0-rc1/changes-report.html
> >
> >
> >
> > Site:
> >
> >   http://home.apache.org/~sdp/crypto-1.0.0-rc1/
> >
> > (note some links are broken, these will be OK once the site is
> > deployed)
> >
> >
> >
> > Clirr Report:
> >
> > Not generating Clirr report as there is no previous version of the
> > library to compare against.
> >
> >
> >
> > RAT Report:
> >
> >   http://home.apache.org/~sdp/crypto-1.0.0-rc1/rat-report.html
> >
> >
> >
> > KEYS:
> >
> >   https://www.apache.org/dist/commons/KEYS
> >
> >
> >
> > Please review the release candidate and vote. This vote will close no
> > sooner than 72 hours from now, i.e. sometime after 13:00 CST 29-July
> > 2016
> >
> >
> >
> > [ ] +1 Release these artifacts
> >
> > [ ] +0 OK, but...
> >
> > [ ] -0 OK, but really should fix...
> >
> > [ ] -1 I oppose this release because...
> >
> >
> >
> > Thanks & Regards
> >
> > Dapeng
> >
> >
>
>
> --
> E-Mail: [hidden email] | [hidden email] Java Persistence
> with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in
> Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>



--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

RE: [VOTE] Release CRYPTO 1.0.0 based on RC1

Sun, Dapeng
>> It would be neat if we could get Jenkins to do that for us!

Thank you for your suggestion, I will do some investigation about it.

-----Original Message-----
From: Gary Gregory [mailto:[hidden email]]
Sent: Wednesday, August 03, 2016 10:22 AM
To: Commons Developers List <[hidden email]>
Subject: Re: [VOTE] Release CRYPTO 1.0.0 based on RC1

On Tue, Aug 2, 2016 at 7:19 PM, Sun, Dapeng <[hidden email]> wrote:

> Hi Gary,
>
> >>Where are the instructions to actually build the same jar contained
> >>in
> the bin-zip with ALL of the native libraries for Windows, Mac, and Linux?
> Thank you for your comments. I will add a wiki for it.
>
> According the previous discussion, I copied the native binary files
> complied by different platforms, and put them into target folder. Then
> all the native files would be packaged into one jar.
>

Ah, yes, of course. Thank you for the reminder!.

It would be neat if we could get Jenkins to do that for us!

Gary


>
> -----Original Message-----
> From: Gary Gregory [mailto:[hidden email]]
> Sent: Tuesday, August 02, 2016 11:31 PM
> To: Commons Developers List <[hidden email]>
> Subject: Re: [VOTE] Release CRYPTO 1.0.0 based on RC1
>
> I know the VOTE is closed but I wanted to note that I was able to
> build with :
>
> Apache Maven 3.3.9
> Maven home: /usr/share/maven
> Java version: 1.8.0_91, vendor: Oracle Corporation Java home:
> /usr/lib/jvm/java-8-openjdk-i386/jre
> Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version:
> "4.4.0-28-generic", arch: "i386", family: "unix"
>
> Linux ggregory-VirtualBox 4.4.0-28-generic #47-Ubuntu SMP Fri Jun 24
> 10:08:35 UTC 2016 i686 i686 i686 GNU/Linux
>
> BUT
>
> the resulting jar only contains the ONE native libraries.
>
> Where are the instructions to actually build the same jar contained in
> the bin-zip with ALL of the native libraries for Windows, Mac, and Linux?
>
> Gary
>
> On Mon, Jul 25, 2016 at 8:25 PM, Sun, Dapeng <[hidden email]> wrote:
>
> > Hi all,
> >
> >
> >
> > Apache Commons CRYPTO was established at May 9, 2016, There are
> > presently numbers of resolved issues fix in CRYPTO. We also fix the
> legal issue.
> >
> >
> >
> > Apache Commons CRYPTO 1.0.0 is available for review here:
> >
> > https://dist.apache.org/repos/dist/dev/commons/crypto
> >
> > (rev 14538)
> >
> >
> >
> > The tag is here:
> >
> >
> > https://git-wip-us.apache.org/repos/asf?p=commons-crypto.git;a=tag;h
> > =r
> > efs/tags/CRYPTO-1.0.0-RC1
> >
> > (commit 782ca06a1f9a292756fbad9eb9841e685cd34af1)
> >
> >
> >
> > Maven artifacts:
> >
> >
> >
> >
> > https://repository.apache.org/content/repositories/orgapachecommons-
> > 11 91/org/apache/commons/commons-crypto/1.0.0/
> >
> >
> >
> > I've tested with Java 7 & 8 using Maven 3.0.5 on Mac OS 64bits/Linux
> > 64&32bits/Windows 64&32 bits
> >
> >
> >
> > Details of changes are in the release notes:
> >
> > https://dist.apache.org/repos/dist/dev/commons/crypto/RELEASE-NOTES.
> > tx
> > t
> >
> > http://home.apache.org/~sdp/crypto-1.0.0-rc1/changes-report.html
> >
> >
> >
> > Site:
> >
> >   http://home.apache.org/~sdp/crypto-1.0.0-rc1/
> >
> > (note some links are broken, these will be OK once the site is
> > deployed)
> >
> >
> >
> > Clirr Report:
> >
> > Not generating Clirr report as there is no previous version of the
> > library to compare against.
> >
> >
> >
> > RAT Report:
> >
> >   http://home.apache.org/~sdp/crypto-1.0.0-rc1/rat-report.html
> >
> >
> >
> > KEYS:
> >
> >   https://www.apache.org/dist/commons/KEYS
> >
> >
> >
> > Please review the release candidate and vote. This vote will close
> > no sooner than 72 hours from now, i.e. sometime after 13:00 CST
> > 29-July
> > 2016
> >
> >
> >
> > [ ] +1 Release these artifacts
> >
> > [ ] +0 OK, but...
> >
> > [ ] -0 OK, but really should fix...
> >
> > [ ] -1 I oppose this release because...
> >
> >
> >
> > Thanks & Regards
> >
> > Dapeng
> >
> >
>
>
> --
> E-Mail: [hidden email] | [hidden email] Java Persistence
> with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit
> in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>



--
E-Mail: [hidden email] | [hidden email] Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]