[VOTE] Release Commons Compress 1.16 based on RC1

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Commons Compress 1.16 based on RC1

Stefan Bodewig
As indicated I think it is time to get Compress 1.16 out.

Compress 1.16 RC1 is available for review here:
    https://dist.apache.org/repos/dist/dev/commons/compress/ (svn revision 24646)

The tag is here:
    https://git-wip-us.apache.org/repos/asf?p=commons-compress.git;a=tag;h=ead7ce22ad9aae1d099bb920a5bd6968a62177ad

Maven artifacts are here:
    https://repository.apache.org/content/repositories/orgapachecommons-1303/org/apache/commons/commons-compress/1.16/

These are the Maven artifacts and their sha256 hashes

24aecd2a5223cf38fa438c789eb150bf87808dde225c9f199025af3a3bf5f2a8  commons-compress-1.16.jar
a7e719e734e28c2b05ad97cde17491d76ed2f82bfdaa3445d2ab0a5108494fc5  commons-compress-1.16-javadoc.jar
2f6f535dbad8d3929204608d0c6bf81bd0f94782aa2df89129e3ca10d7f54943  commons-compress-1.16.pom
1472aca5ea66fe67c4dcde1a90667a3b0908b0f4ae56b55ef02f0b31f0709c82  commons-compress-1.16-sources.jar
6381b09dfff184da2454b5590b94807604e5d7ee72af6eea6573d3b8af518a78  commons-compress-1.16-tests.jar
d963a9cc8e314de0aabc3d7adccf4bc8449223b50b97722a9c17c7bb34117677  commons-compress-1.16-test-sources.jar

I have tested this with JDK 8 ... using Maven 3

Details of changes since 1.15 are in the release notes:
    https://dist.apache.org/repos/dist/dev/commons/compress/RELEASE-NOTES.txt
    https://stefan.samaflost.de/staging/commons-compress-1.16/changes-report.html

Site:
    https://stefan.samaflost.de/staging/commons-compress-1.16/

As usual when I cut a release this is not the site I'm going to
publish. I'll publish a fresh site from master once the release date
is known.

The download link and the link to the 1.16 javadocs are not expected
to work.

japicmp Report (compared to 1.15):
    https://stefan.samaflost.de/staging/commons-compress-1.16/japicmp.html

Note that japicmp reports a source incompatible change to
LZ77Compressor.Block that I consider OK as the class is only used
internally and nobody is supposed to create subclasses outside of
Commons Compress.

RAT Report:
    https://stefan.samaflost.de/staging/commons-compress-1.16/rat-report.html

KEYS:
  https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now,
i.e. sometime after 19:00 UTC 05-March 2018

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thanks!

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Compress 1.16 based on RC1

garydgregory
+1

From src zip file: ASC, MD5, SHA1, SHA512 OK.

RAT check OK.

CLIRR check fails as noted:

[ERROR] 7013:
org.apache.commons.compress.compressors.lz77support.LZ77Compressor$Block:
Abstract method 'public
org.apache.commons.compress.compressors.lz77support.LZ77Compressor$Block$BlockType
getType()' has been added

" LZ77Compressor.Block that I consider OK as the class is only used
internally and nobody is supposed to create subclasses outside of
Commons Compress."

Can you Javadoc this for future releases then?

Did you consider using Rob's new Commons release plugin?

Tested 'mvn clean site' with:

Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
2017-10-18T01:58:13-06:00)
Maven home: C:\Java\apache-maven-3.5.2\bin\..
Java version: 1.8.0_162, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_162\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Fails:

[INFO] Generating "japicmp" report       ---
japicmp-maven-plugin:0.11.0:cmp-report
[debug] No packaging support defined, no filtering
[debug] Searching for versions in versionRange: (,1.16)
[debug] Parameter <oldVersionPattern> not configured, i.e. no version
filtered.
[warn] No new version specified and file
'C:\temp\rc\commons-compress-1.16-src\target\classes' of artifact could not
be opened as jar archive:
C:\temp\rc\commons-compress-1.16-src\target\classes (Access is denied)

java.io.FileNotFoundException:
C:\temp\rc\commons-compress-1.16-src\target\classes (Access is denied)
        at java.util.zip.ZipFile.open(Native Method)
        at java.util.zip.ZipFile.<init>(ZipFile.java:225)
        at java.util.zip.ZipFile.<init>(ZipFile.java:155)
        at java.util.jar.JarFile.<init>(JarFile.java:166)
        at java.util.jar.JarFile.<init>(JarFile.java:130)
        at
japicmp.maven.JApiCmpMojo.populateArchivesListsFromParameters(JApiCmpMojo.java:341)
        at japicmp.maven.JApiCmpMojo.getOptions(JApiCmpMojo.java:704)
        at
japicmp.maven.JApiCmpMojo.executeWithParameters(JApiCmpMojo.java:136)
        at japicmp.maven.JApiCmpReport.executeReport(JApiCmpReport.java:71)
        at
org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:255)
        at
org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument(ReportDocumentRenderer.java:230)
        at
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:349)
        at
org.apache.maven.plugins.site.render.SiteMojo.renderLocale(SiteMojo.java:184)
        at
org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:133)
        at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
        at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
        at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
        at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
        at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:955)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:290)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:194)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)

[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:45 min
[INFO] Finished at: 2018-02-02T15:23:59-07:00
[INFO] Final Memory: 76M/881M
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.7:site (default-site) on
project commons-compress: Error generating
japicmp-maven-plugin:0.11.0:cmp-report report: Failed to generate report:
Please provide at least one resolvable new version using one of the
configuration elements <newVersion/> or <newVersions/>. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions,
please read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

But 'mvn clean package' is OK using:

Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
2017-10-18T01:58:13-06:00)
Maven home: C:\Java\apache-maven-3.5.2\bin\..
Java version: 1.7.0_80, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_80\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows"

Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
2017-10-18T01:58:13-06:00)
Maven home: C:\Java\apache-maven-3.5.2\bin\..
Java version: 1.8.0_162, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_162\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
2017-10-18T01:58:13-06:00)
Maven home: C:\Java\apache-maven-3.5.2\bin\..
Java version: 9.0.4, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk-9.0.4
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Fails on Java 10 due to a Sufire issue:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test (default-test)
on project commons-compress: Execution default-test of goal
org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test failed.:
NullPointerException -> [Help 1]

Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
2017-10-18T01:58:13-06:00)
Maven home: C:\Java\apache-maven-3.5.2\bin\..
Java version: 10-ea, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk-10
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Gary



On Fri, Feb 2, 2018 at 11:14 AM, Stefan Bodewig <[hidden email]> wrote:

> As indicated I think it is time to get Compress 1.16 out.
>
> Compress 1.16 RC1 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/compress/ (svn
> revision 24646)
>
> The tag is here:
>     https://git-wip-us.apache.org/repos/asf?p=commons-compress.
> git;a=tag;h=ead7ce22ad9aae1d099bb920a5bd6968a62177ad
>
> Maven artifacts are here:
>     https://repository.apache.org/content/repositories/
> orgapachecommons-1303/org/apache/commons/commons-compress/1.16/
>
> These are the Maven artifacts and their sha256 hashes
>
> 24aecd2a5223cf38fa438c789eb150bf87808dde225c9f199025af3a3bf5f2a8
> commons-compress-1.16.jar
> a7e719e734e28c2b05ad97cde17491d76ed2f82bfdaa3445d2ab0a5108494fc5
> commons-compress-1.16-javadoc.jar
> 2f6f535dbad8d3929204608d0c6bf81bd0f94782aa2df89129e3ca10d7f54943
> commons-compress-1.16.pom
> 1472aca5ea66fe67c4dcde1a90667a3b0908b0f4ae56b55ef02f0b31f0709c82
> commons-compress-1.16-sources.jar
> 6381b09dfff184da2454b5590b94807604e5d7ee72af6eea6573d3b8af518a78
> commons-compress-1.16-tests.jar
> d963a9cc8e314de0aabc3d7adccf4bc8449223b50b97722a9c17c7bb34117677
> commons-compress-1.16-test-sources.jar
>
> I have tested this with JDK 8 ... using Maven 3
>
> Details of changes since 1.15 are in the release notes:
>     https://dist.apache.org/repos/dist/dev/commons/compress/
> RELEASE-NOTES.txt
>     https://stefan.samaflost.de/staging/commons-compress-1.16/
> changes-report.html
>
> Site:
>     https://stefan.samaflost.de/staging/commons-compress-1.16/
>
> As usual when I cut a release this is not the site I'm going to
> publish. I'll publish a fresh site from master once the release date
> is known.
>
> The download link and the link to the 1.16 javadocs are not expected
> to work.
>
> japicmp Report (compared to 1.15):
>     https://stefan.samaflost.de/staging/commons-compress-1.16/japicmp.html
>
> Note that japicmp reports a source incompatible change to
> LZ77Compressor.Block that I consider OK as the class is only used
> internally and nobody is supposed to create subclasses outside of
> Commons Compress.
>
> RAT Report:
>     https://stefan.samaflost.de/staging/commons-compress-1.16/
> rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now,
> i.e. sometime after 19:00 UTC 05-March 2018
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thanks!
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Compress 1.16 based on RC1

Stefan Bodewig
On 2018-02-02, Gary Gregory wrote:

> " LZ77Compressor.Block that I consider OK as the class is only used
> internally and nobody is supposed to create subclasses outside of
> Commons Compress."

> Can you Javadoc this for future releases then?

Will do.

> Did you consider using Rob's new Commons release plugin?

No, I don't think I'm in the target audience. I actually prefer a manual
approach with more checks over more automation. I don't use the maven
release plugin either. Rob's plugin is great but I'm to stubborn and
prefer my own way. :-)

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Compress 1.16 based on RC1

sebb-2-2
In reply to this post by Stefan Bodewig
I get the following failure with 'mvn clean site' using

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T16:41:47+00:00)
Maven home: /opt/apache-maven-3.3.9
Java version: 1.8.0_151, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_151.jdk/Contents/Home/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "mac os x", version: "10.13.3", arch: "x86_64", family: "mac"



[INFO] Generating "japicmp" report              ---
japicmp-maven-plugin:0.11.0:cmp-report
[debug] No packaging support defined, no filtering
[debug] Searching for versions in versionRange: (,1.16)
[INFO] artifact org.apache.commons:commons-compress: checking for
updates from central
[debug] Parameter <oldVersionPattern> not configured, i.e. no version filtered.
[warn] No new version specified and file
'/private/tmp/CC/commons-compress-1.16-src/target/classes' of artifact
could not be opened as jar archive:
/private/tmp/CC/commons-compress-1.16-src/target/classes (Is a
directory)
java.io.FileNotFoundException:
/private/tmp/CC/commons-compress-1.16-src/target/classes (Is a
directory)
at java.util.zip.ZipFile.open(Native Method)
at java.util.zip.ZipFile.<init>(ZipFile.java:225)
at java.util.zip.ZipFile.<init>(ZipFile.java:155)
at java.util.jar.JarFile.<init>(JarFile.java:166)
at java.util.jar.JarFile.<init>(JarFile.java:130)
...

Looks like this might be a pom config issue?

There are also some quite noisy tests.

On 2 February 2018 at 18:14, Stefan Bodewig <[hidden email]> wrote:

> As indicated I think it is time to get Compress 1.16 out.
>
> Compress 1.16 RC1 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/compress/ (svn revision 24646)
>
> The tag is here:
>     https://git-wip-us.apache.org/repos/asf?p=commons-compress.git;a=tag;h=ead7ce22ad9aae1d099bb920a5bd6968a62177ad
>
> Maven artifacts are here:
>     https://repository.apache.org/content/repositories/orgapachecommons-1303/org/apache/commons/commons-compress/1.16/
>
> These are the Maven artifacts and their sha256 hashes
>
> 24aecd2a5223cf38fa438c789eb150bf87808dde225c9f199025af3a3bf5f2a8  commons-compress-1.16.jar
> a7e719e734e28c2b05ad97cde17491d76ed2f82bfdaa3445d2ab0a5108494fc5  commons-compress-1.16-javadoc.jar
> 2f6f535dbad8d3929204608d0c6bf81bd0f94782aa2df89129e3ca10d7f54943  commons-compress-1.16.pom
> 1472aca5ea66fe67c4dcde1a90667a3b0908b0f4ae56b55ef02f0b31f0709c82  commons-compress-1.16-sources.jar
> 6381b09dfff184da2454b5590b94807604e5d7ee72af6eea6573d3b8af518a78  commons-compress-1.16-tests.jar
> d963a9cc8e314de0aabc3d7adccf4bc8449223b50b97722a9c17c7bb34117677  commons-compress-1.16-test-sources.jar
>
> I have tested this with JDK 8 ... using Maven 3
>
> Details of changes since 1.15 are in the release notes:
>     https://dist.apache.org/repos/dist/dev/commons/compress/RELEASE-NOTES.txt
>     https://stefan.samaflost.de/staging/commons-compress-1.16/changes-report.html
>
> Site:
>     https://stefan.samaflost.de/staging/commons-compress-1.16/
>
> As usual when I cut a release this is not the site I'm going to
> publish. I'll publish a fresh site from master once the release date
> is known.
>
> The download link and the link to the 1.16 javadocs are not expected
> to work.
>
> japicmp Report (compared to 1.15):
>     https://stefan.samaflost.de/staging/commons-compress-1.16/japicmp.html
>
> Note that japicmp reports a source incompatible change to
> LZ77Compressor.Block that I consider OK as the class is only used
> internally and nobody is supposed to create subclasses outside of
> Commons Compress.
>
> RAT Report:
>     https://stefan.samaflost.de/staging/commons-compress-1.16/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now,
> i.e. sometime after 19:00 UTC 05-March 2018
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thanks!
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Compress 1.16 based on RC1

sebb-2-2
The japicmp error is a bug in CP.

The tag <ignoreMissingNewVersion /> does not define the value as true;
instead it is ignored. The pom needs to provide an explicit value.

Also the config needs to be added to the report section instead (or
possibly as well to allow for cli use) because mvn site reports don't
use the build settings.

Fixing this avoids the build failure, though there is a stack trace
which should not be shown (this seems to have been introduced in
0.9.4)

Note that japicmp is enabled in compress; it can be disabled using -P-japicmp

I also see:

Feb 03, 2018 10:28:16 AM
net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver visit
WARNING: Could not find class
org.apache.commons.compress.archivers.sevenz.LZMADecoder, due to:
java.lang.IllegalAccessError: class
org.apache.commons.compress.archivers.sevenz.LZMADecoder cannot access
its superclass org.apache.commons.compress.archivers.sevenz.CoderBase


On 3 February 2018 at 09:40, sebb <[hidden email]> wrote:

> I get the following failure with 'mvn clean site' using
>
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T16:41:47+00:00)
> Maven home: /opt/apache-maven-3.3.9
> Java version: 1.8.0_151, vendor: Oracle Corporation
> Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_151.jdk/Contents/Home/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.3", arch: "x86_64", family: "mac"
>
>
>
> [INFO] Generating "japicmp" report              ---
> japicmp-maven-plugin:0.11.0:cmp-report
> [debug] No packaging support defined, no filtering
> [debug] Searching for versions in versionRange: (,1.16)
> [INFO] artifact org.apache.commons:commons-compress: checking for
> updates from central
> [debug] Parameter <oldVersionPattern> not configured, i.e. no version filtered.
> [warn] No new version specified and file
> '/private/tmp/CC/commons-compress-1.16-src/target/classes' of artifact
> could not be opened as jar archive:
> /private/tmp/CC/commons-compress-1.16-src/target/classes (Is a
> directory)
> java.io.FileNotFoundException:
> /private/tmp/CC/commons-compress-1.16-src/target/classes (Is a
> directory)
> at java.util.zip.ZipFile.open(Native Method)
> at java.util.zip.ZipFile.<init>(ZipFile.java:225)
> at java.util.zip.ZipFile.<init>(ZipFile.java:155)
> at java.util.jar.JarFile.<init>(JarFile.java:166)
> at java.util.jar.JarFile.<init>(JarFile.java:130)
> ...
>
> Looks like this might be a pom config issue?
>
> There are also some quite noisy tests.
>
> On 2 February 2018 at 18:14, Stefan Bodewig <[hidden email]> wrote:
>> As indicated I think it is time to get Compress 1.16 out.
>>
>> Compress 1.16 RC1 is available for review here:
>>     https://dist.apache.org/repos/dist/dev/commons/compress/ (svn revision 24646)
>>
>> The tag is here:
>>     https://git-wip-us.apache.org/repos/asf?p=commons-compress.git;a=tag;h=ead7ce22ad9aae1d099bb920a5bd6968a62177ad
>>
>> Maven artifacts are here:
>>     https://repository.apache.org/content/repositories/orgapachecommons-1303/org/apache/commons/commons-compress/1.16/
>>
>> These are the Maven artifacts and their sha256 hashes
>>
>> 24aecd2a5223cf38fa438c789eb150bf87808dde225c9f199025af3a3bf5f2a8  commons-compress-1.16.jar
>> a7e719e734e28c2b05ad97cde17491d76ed2f82bfdaa3445d2ab0a5108494fc5  commons-compress-1.16-javadoc.jar
>> 2f6f535dbad8d3929204608d0c6bf81bd0f94782aa2df89129e3ca10d7f54943  commons-compress-1.16.pom
>> 1472aca5ea66fe67c4dcde1a90667a3b0908b0f4ae56b55ef02f0b31f0709c82  commons-compress-1.16-sources.jar
>> 6381b09dfff184da2454b5590b94807604e5d7ee72af6eea6573d3b8af518a78  commons-compress-1.16-tests.jar
>> d963a9cc8e314de0aabc3d7adccf4bc8449223b50b97722a9c17c7bb34117677  commons-compress-1.16-test-sources.jar
>>
>> I have tested this with JDK 8 ... using Maven 3
>>
>> Details of changes since 1.15 are in the release notes:
>>     https://dist.apache.org/repos/dist/dev/commons/compress/RELEASE-NOTES.txt
>>     https://stefan.samaflost.de/staging/commons-compress-1.16/changes-report.html
>>
>> Site:
>>     https://stefan.samaflost.de/staging/commons-compress-1.16/
>>
>> As usual when I cut a release this is not the site I'm going to
>> publish. I'll publish a fresh site from master once the release date
>> is known.
>>
>> The download link and the link to the 1.16 javadocs are not expected
>> to work.
>>
>> japicmp Report (compared to 1.15):
>>     https://stefan.samaflost.de/staging/commons-compress-1.16/japicmp.html
>>
>> Note that japicmp reports a source incompatible change to
>> LZ77Compressor.Block that I consider OK as the class is only used
>> internally and nobody is supposed to create subclasses outside of
>> Commons Compress.
>>
>> RAT Report:
>>     https://stefan.samaflost.de/staging/commons-compress-1.16/rat-report.html
>>
>> KEYS:
>>   https://www.apache.org/dist/commons/KEYS
>>
>> Please review the release candidate and vote.
>> This vote will close no sooner that 72 hours from now,
>> i.e. sometime after 19:00 UTC 05-March 2018
>>
>>   [ ] +1 Release these artifacts
>>   [ ] +0 OK, but...
>>   [ ] -0 OK, but really should fix...
>>   [ ] -1 I oppose this release because...
>>
>> Thanks!
>>
>> Stefan
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Compress 1.16 based on RC1

Stefan Bodewig
In reply to this post by sebb-2-2
On 2018-02-03, sebb wrote:

> I get the following failure with 'mvn clean site' using

this is because japicmp requires the jar to be built, see the bottom of
BUILDING.md

> mvn package site -Pjacoco

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Compress 1.16 based on RC1

sebb-2-2
On 3 February 2018 at 12:26, Stefan Bodewig <[hidden email]> wrote:
> On 2018-02-03, sebb wrote:
>
>> I get the following failure with 'mvn clean site' using
>
> this is because japicmp requires the jar to be built, see the bottom of
> BUILDING.md

CP-42 was supposed to fix this by setting "ignoreMissingNewVersion" = true
However the fix was incorrect.

I have just updated CP 44-SNAPSHOT and it seems to work now; the build
no longer fails.
However the stack trace is still shown; that's a bug in japicmp.

Note that you have to define the snapshots repo locally if you want to
reference a snapshot parent.
This is because the ASF snapshot repo is not known by Maven.
It's defined in the apache pom which is referenced by the CP snapshot
which of course cannot be found until it is first downloaded...

To get round this, you can add a profile like this to your settings.xml:

    <profile>
      <id>snapshotrepo</id>
      <repositories>
        <repository>
          <id>apache.snapshots.https</id>
          <name>Apache Development Snapshot Repository</name>
          <url>https://repository.apache.org/content/repositories/snapshots</url>
          <releases>
            <enabled>false</enabled>
          </releases>
          <snapshots>
            <enabled>true</enabled>
            <updatePolicy>always</updatePolicy>
          </snapshots>
        </repository>
      </repositories>
    </profile>

and invoke it with -Psnapshotrepo

>> mvn package site -Pjacoco
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Compress 1.16 based on RC1

Gilles Sadowski
On Sat, 3 Feb 2018 13:25:25 +0000, sebb wrote:

> On 3 February 2018 at 12:26, Stefan Bodewig <[hidden email]>
> wrote:
>> On 2018-02-03, sebb wrote:
>>
>>> I get the following failure with 'mvn clean site' using
>>
>> this is because japicmp requires the jar to be built, see the bottom
>> of
>> BUILDING.md
>
> CP-42 was supposed to fix this by setting "ignoreMissingNewVersion" =
> true
> However the fix was incorrect.
>
> I have just updated CP 44-SNAPSHOT and it seems to work now; the
> build
> no longer fails.
> However the stack trace is still shown; that's a bug in japicmp.
>
> Note that you have to define the snapshots repo locally if you want
> to
> reference a snapshot parent.
> This is because the ASF snapshot repo is not known by Maven.
> It's defined in the apache pom which is referenced by the CP snapshot
> which of course cannot be found until it is first downloaded...
>
> To get round this, you can add a profile like this to your
> settings.xml:
>
>     <profile>
>       <id>snapshotrepo</id>
>       <repositories>
>         <repository>
>           <id>apache.snapshots.https</id>
>           <name>Apache Development Snapshot Repository</name>
>
>
> <url>https://repository.apache.org/content/repositories/snapshots</url>
>           <releases>
>             <enabled>false</enabled>
>           </releases>
>           <snapshots>
>             <enabled>true</enabled>
>             <updatePolicy>always</updatePolicy>
>           </snapshots>
>         </repository>
>       </repositories>
>     </profile>
>
> and invoke it with -Psnapshotrepo

In my "settings.xml", there is only a section with the credentials
for the snapshot repository; I can't see where the URL is defined
but the functionality works (snapshots are downloaded).

Gilles

>>> mvn package site -Pjacoco
>>
>> Stefan
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Compress 1.16 based on RC1

Stefan Bodewig
In reply to this post by sebb-2-2
On 2018-02-03, sebb wrote:

> On 3 February 2018 at 12:26, Stefan Bodewig <[hidden email]> wrote:
>> On 2018-02-03, sebb wrote:

>>> I get the following failure with 'mvn clean site' using

>> this is because japicmp requires the jar to be built, see the bottom of
>> BUILDING.md

> CP-42 was supposed to fix this by setting "ignoreMissingNewVersion" = true
> However the fix was incorrect.

> I have just updated CP 44-SNAPSHOT and it seems to work now; the build
> no longer fails.
> However the stack trace is still shown; that's a bug in japicmp.

Many thanks for looking into and mostly fixing the issue.

Please allow me to point out the site build requires the same procedure
that used to be necessary with 1.15 and probably before that (ever since
Compress switched to japicmp as Clirr didn't work for Java8). Also it is
"just" the site build, so I don't think this should block a release.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Compress 1.16 based on RC1

Oliver Heger-3
In reply to this post by Stefan Bodewig
Hi,

build works fine with Java 1.7 and 1.8 on Windows 10. When building the
site I get the same error as mentioned by sebb. Artifacts and site look
good.

+1

Oliver

Am 02.02.2018 um 19:14 schrieb Stefan Bodewig:

> As indicated I think it is time to get Compress 1.16 out.
>
> Compress 1.16 RC1 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/compress/ (svn revision 24646)
>
> The tag is here:
>     https://git-wip-us.apache.org/repos/asf?p=commons-compress.git;a=tag;h=ead7ce22ad9aae1d099bb920a5bd6968a62177ad
>
> Maven artifacts are here:
>     https://repository.apache.org/content/repositories/orgapachecommons-1303/org/apache/commons/commons-compress/1.16/
>
> These are the Maven artifacts and their sha256 hashes
>
> 24aecd2a5223cf38fa438c789eb150bf87808dde225c9f199025af3a3bf5f2a8  commons-compress-1.16.jar
> a7e719e734e28c2b05ad97cde17491d76ed2f82bfdaa3445d2ab0a5108494fc5  commons-compress-1.16-javadoc.jar
> 2f6f535dbad8d3929204608d0c6bf81bd0f94782aa2df89129e3ca10d7f54943  commons-compress-1.16.pom
> 1472aca5ea66fe67c4dcde1a90667a3b0908b0f4ae56b55ef02f0b31f0709c82  commons-compress-1.16-sources.jar
> 6381b09dfff184da2454b5590b94807604e5d7ee72af6eea6573d3b8af518a78  commons-compress-1.16-tests.jar
> d963a9cc8e314de0aabc3d7adccf4bc8449223b50b97722a9c17c7bb34117677  commons-compress-1.16-test-sources.jar
>
> I have tested this with JDK 8 ... using Maven 3
>
> Details of changes since 1.15 are in the release notes:
>     https://dist.apache.org/repos/dist/dev/commons/compress/RELEASE-NOTES.txt
>     https://stefan.samaflost.de/staging/commons-compress-1.16/changes-report.html
>
> Site:
>     https://stefan.samaflost.de/staging/commons-compress-1.16/
>
> As usual when I cut a release this is not the site I'm going to
> publish. I'll publish a fresh site from master once the release date
> is known.
>
> The download link and the link to the 1.16 javadocs are not expected
> to work.
>
> japicmp Report (compared to 1.15):
>     https://stefan.samaflost.de/staging/commons-compress-1.16/japicmp.html
>
> Note that japicmp reports a source incompatible change to
> LZ77Compressor.Block that I consider OK as the class is only used
> internally and nobody is supposed to create subclasses outside of
> Commons Compress.
>
> RAT Report:
>     https://stefan.samaflost.de/staging/commons-compress-1.16/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now,
> i.e. sometime after 19:00 UTC 05-March 2018
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thanks!
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[RESULT] Release Commons Compress 1.16 based on RC1

Stefan Bodewig
In reply to this post by Stefan Bodewig
Hi all

with +1s by

Gary Gregory
Oliver Heger
Stefan Bodewig

and no other votes the votes has passed. I'll proceed with publishing
the artifacts and give the mirrors a few hours time before announcing
the release.

Many thanks to those who took the time to evaluate the release

     Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]