[VOTE] Release Commons Release Plugin 1.0 base on RC1

classic Classic list List threaded Threaded
29 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Commons Release Plugin 1.0 base on RC1

Rob Tompkins-2
Hello all,

This is a [VOTE] for releasing Apache commons-release-plugin 1.0 (from RC1).

Tag name:
   commons-release-plugin-1.0-RC1 (signature can be checked from git using 'git tag -v')

Tag URL:
   https://git-wip-us.apache.org/repos/asf?p=commons-release-plugin.git;a=tag;h=6b05b8bee894ad471c5e1eda979550b344c21020

Commit ID the tag points at:
   2f48a0ebd07318419b4d92a7e7b594f4fca47428

Site:
   https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/site.zip

Distribution files (committed at revision 24125):
   https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/

Distribution files hashes (SHA1):
  commons-release-plugin-1.0-bin.tar.gz
  (SHA1: 02a0e034ed89c87e620ceaf4aef879121d4b87de)
  commons-release-plugin-1.0-bin.zip
  (SHA1: e0c4cf6449f6baab4c52c98c1e577512486d8fba)
  commons-release-plugin-1.0-src.tar.gz
  (SHA1: e48b67b70b154b7dc69914752814512225024504)
  commons-release-plugin-1.0-src.zip
  (SHA1: bc9a6c847899b2700e5873c4ac1a8d983476b255)

These are the Maven artifacts and their hashes:
  commons-release-plugin-1.0-javadoc.jar
  (SHA1: bc2cdfa56f55ee538087038a1194ea2789863ca9)
  commons-release-plugin-1.0-sources.jar
  (SHA1: eb20eec8580fd5a2633bd2822e951d57043d3d4e)
  commons-release-plugin-1.0-test-sources.jar
  (SHA1: 61aa51b44025ced470b0e21b19a3eb65e154df1f)
  commons-release-plugin-1.0-tests.jar
  (SHA1: a81f42e01ca77a86048e07963d4ea496a69251f6)
  commons-release-plugin-1.0.jar
  (SHA1: 2897ab01d2e8460d100d196db55e53b2a1bab73e)
  commons-release-plugin-1.0.pom
  (SHA1: 2bcc663eb212f9a2233acc21773ef80883ac0881)

KEYS file to check signatures:
   http://www.apache.org/dist/commons/KEYS

Maven artifacts:
   https://repository.apache.org/content/repositories/orgapachecommons-1302

Please select one of the following options[1]:
  [ ] +1 Release it.
  [ ] +0 Go ahead; I don't care.
  [ ] -0 There are a few minor glitches: ...
  [ ] -1 No, do not release it because ...


This vote will be open at least 72 hours, i.e. until
2018-01-14T03:00:00Z
(this is UTC time).

--------

Cheers,
-Rob

[1] http://apache.org/foundation/voting.html
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

garydgregory
Nit: main site page:
"This is a Maven 3.x <http://maven.apache.org/> Plugin which is used by Apache
Commons <http://commons.apache.org/> releases."
->
"This is a Maven 3.x <http://maven.apache.org/> Plugin which is used by Apache
Commons <http://commons.apache.org/> release managers."

Gary

On Wed, Jan 10, 2018 at 7:50 PM, Rob Tompkins <[hidden email]> wrote:

> Hello all,
>
> This is a [VOTE] for releasing Apache commons-release-plugin 1.0 (from
> RC1).
>
> Tag name:
>    commons-release-plugin-1.0-RC1 (signature can be checked from git using
> 'git tag -v')
>
> Tag URL:
>    https://git-wip-us.apache.org/repos/asf?p=commons-release-
> plugin.git;a=tag;h=6b05b8bee894ad471c5e1eda979550b344c21020
>
> Commit ID the tag points at:
>    2f48a0ebd07318419b4d92a7e7b594f4fca47428
>
> Site:
>    https://dist.apache.org/repos/dist/dev/commons/commons-
> release-plugin/site.zip
>
> Distribution files (committed at revision 24125):
>    https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/
>
> Distribution files hashes (SHA1):
>   commons-release-plugin-1.0-bin.tar.gz
>   (SHA1: 02a0e034ed89c87e620ceaf4aef879121d4b87de)
>   commons-release-plugin-1.0-bin.zip
>   (SHA1: e0c4cf6449f6baab4c52c98c1e577512486d8fba)
>   commons-release-plugin-1.0-src.tar.gz
>   (SHA1: e48b67b70b154b7dc69914752814512225024504)
>   commons-release-plugin-1.0-src.zip
>   (SHA1: bc9a6c847899b2700e5873c4ac1a8d983476b255)
>
> These are the Maven artifacts and their hashes:
>   commons-release-plugin-1.0-javadoc.jar
>   (SHA1: bc2cdfa56f55ee538087038a1194ea2789863ca9)
>   commons-release-plugin-1.0-sources.jar
>   (SHA1: eb20eec8580fd5a2633bd2822e951d57043d3d4e)
>   commons-release-plugin-1.0-test-sources.jar
>   (SHA1: 61aa51b44025ced470b0e21b19a3eb65e154df1f)
>   commons-release-plugin-1.0-tests.jar
>   (SHA1: a81f42e01ca77a86048e07963d4ea496a69251f6)
>   commons-release-plugin-1.0.jar
>   (SHA1: 2897ab01d2e8460d100d196db55e53b2a1bab73e)
>   commons-release-plugin-1.0.pom
>   (SHA1: 2bcc663eb212f9a2233acc21773ef80883ac0881)
>
> KEYS file to check signatures:
>    http://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
>    https://repository.apache.org/content/repositories/
> orgapachecommons-1302
>
> Please select one of the following options[1]:
>   [ ] +1 Release it.
>   [ ] +0 Go ahead; I don't care.
>   [ ] -0 There are a few minor glitches: ...
>   [ ] -1 No, do not release it because ...
>
>
> This vote will be open at least 72 hours, i.e. until
> 2018-01-14T03:00:00Z
> (this is UTC time).
>
> --------
>
> Cheers,
> -Rob
>
> [1] http://apache.org/foundation/voting.html
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

garydgregory
In reply to this post by Rob Tompkins-2
I wonder if:
- This should be a LAZY VOTE since this is not an official component but
rather a tool
- We should release it as 1.0 anyway (unless obvious bugs are found) to
avoid the chicken and egg problem: To really test this, I want to create an
RC for Commons Collection (for example). But that means using a
commons-release-plugin 1.0 version in my POM - which we cannot release as a
repeatable build since 1.0 is not out yet. And cutting an RC with a
1.0-SNAPSHOT is not acceptable (not repeatable.)

Gary

On Wed, Jan 10, 2018 at 7:50 PM, Rob Tompkins <[hidden email]> wrote:

> Hello all,
>
> This is a [VOTE] for releasing Apache commons-release-plugin 1.0 (from
> RC1).
>
> Tag name:
>    commons-release-plugin-1.0-RC1 (signature can be checked from git using
> 'git tag -v')
>
> Tag URL:
>    https://git-wip-us.apache.org/repos/asf?p=commons-release-
> plugin.git;a=tag;h=6b05b8bee894ad471c5e1eda979550b344c21020
>
> Commit ID the tag points at:
>    2f48a0ebd07318419b4d92a7e7b594f4fca47428
>
> Site:
>    https://dist.apache.org/repos/dist/dev/commons/commons-
> release-plugin/site.zip
>
> Distribution files (committed at revision 24125):
>    https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/
>
> Distribution files hashes (SHA1):
>   commons-release-plugin-1.0-bin.tar.gz
>   (SHA1: 02a0e034ed89c87e620ceaf4aef879121d4b87de)
>   commons-release-plugin-1.0-bin.zip
>   (SHA1: e0c4cf6449f6baab4c52c98c1e577512486d8fba)
>   commons-release-plugin-1.0-src.tar.gz
>   (SHA1: e48b67b70b154b7dc69914752814512225024504)
>   commons-release-plugin-1.0-src.zip
>   (SHA1: bc9a6c847899b2700e5873c4ac1a8d983476b255)
>
> These are the Maven artifacts and their hashes:
>   commons-release-plugin-1.0-javadoc.jar
>   (SHA1: bc2cdfa56f55ee538087038a1194ea2789863ca9)
>   commons-release-plugin-1.0-sources.jar
>   (SHA1: eb20eec8580fd5a2633bd2822e951d57043d3d4e)
>   commons-release-plugin-1.0-test-sources.jar
>   (SHA1: 61aa51b44025ced470b0e21b19a3eb65e154df1f)
>   commons-release-plugin-1.0-tests.jar
>   (SHA1: a81f42e01ca77a86048e07963d4ea496a69251f6)
>   commons-release-plugin-1.0.jar
>   (SHA1: 2897ab01d2e8460d100d196db55e53b2a1bab73e)
>   commons-release-plugin-1.0.pom
>   (SHA1: 2bcc663eb212f9a2233acc21773ef80883ac0881)
>
> KEYS file to check signatures:
>    http://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
>    https://repository.apache.org/content/repositories/
> orgapachecommons-1302
>
> Please select one of the following options[1]:
>   [ ] +1 Release it.
>   [ ] +0 Go ahead; I don't care.
>   [ ] -0 There are a few minor glitches: ...
>   [ ] -1 No, do not release it because ...
>
>
> This vote will be open at least 72 hours, i.e. until
> 2018-01-14T03:00:00Z
> (this is UTC time).
>
> --------
>
> Cheers,
> -Rob
>
> [1] http://apache.org/foundation/voting.html
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

Sergio Fernández
What about casting this first release as 0.1?

Then we solve the chicken & egg problem: we can verify it the actual
components before releasing 1.0 (which semantically speaking has a strong
meaning.


On Jan 11, 2018 04:35, "Gary Gregory" <[hidden email]> wrote:

I wonder if:
- This should be a LAZY VOTE since this is not an official component but
rather a tool
- We should release it as 1.0 anyway (unless obvious bugs are found) to
avoid the chicken and egg problem: To really test this, I want to create an
RC for Commons Collection (for example). But that means using a
commons-release-plugin 1.0 version in my POM - which we cannot release as a
repeatable build since 1.0 is not out yet. And cutting an RC with a
1.0-SNAPSHOT is not acceptable (not repeatable.)

Gary

On Wed, Jan 10, 2018 at 7:50 PM, Rob Tompkins <[hidden email]> wrote:

> Hello all,
>
> This is a [VOTE] for releasing Apache commons-release-plugin 1.0 (from
> RC1).
>
> Tag name:
>    commons-release-plugin-1.0-RC1 (signature can be checked from git using
> 'git tag -v')
>
> Tag URL:
>    https://git-wip-us.apache.org/repos/asf?p=commons-release-
> plugin.git;a=tag;h=6b05b8bee894ad471c5e1eda979550b344c21020
>
> Commit ID the tag points at:
>    2f48a0ebd07318419b4d92a7e7b594f4fca47428
>
> Site:
>    https://dist.apache.org/repos/dist/dev/commons/commons-
> release-plugin/site.zip
>
> Distribution files (committed at revision 24125):
>    https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/
>
> Distribution files hashes (SHA1):
>   commons-release-plugin-1.0-bin.tar.gz
>   (SHA1: 02a0e034ed89c87e620ceaf4aef879121d4b87de)
>   commons-release-plugin-1.0-bin.zip
>   (SHA1: e0c4cf6449f6baab4c52c98c1e577512486d8fba)
>   commons-release-plugin-1.0-src.tar.gz
>   (SHA1: e48b67b70b154b7dc69914752814512225024504)
>   commons-release-plugin-1.0-src.zip
>   (SHA1: bc9a6c847899b2700e5873c4ac1a8d983476b255)
>
> These are the Maven artifacts and their hashes:
>   commons-release-plugin-1.0-javadoc.jar
>   (SHA1: bc2cdfa56f55ee538087038a1194ea2789863ca9)
>   commons-release-plugin-1.0-sources.jar
>   (SHA1: eb20eec8580fd5a2633bd2822e951d57043d3d4e)
>   commons-release-plugin-1.0-test-sources.jar
>   (SHA1: 61aa51b44025ced470b0e21b19a3eb65e154df1f)
>   commons-release-plugin-1.0-tests.jar
>   (SHA1: a81f42e01ca77a86048e07963d4ea496a69251f6)
>   commons-release-plugin-1.0.jar
>   (SHA1: 2897ab01d2e8460d100d196db55e53b2a1bab73e)
>   commons-release-plugin-1.0.pom
>   (SHA1: 2bcc663eb212f9a2233acc21773ef80883ac0881)
>
> KEYS file to check signatures:
>    http://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
>    https://repository.apache.org/content/repositories/
> orgapachecommons-1302
>
> Please select one of the following options[1]:
>   [ ] +1 Release it.
>   [ ] +0 Go ahead; I don't care.
>   [ ] -0 There are a few minor glitches: ...
>   [ ] -1 No, do not release it because ...
>
>
> This vote will be open at least 72 hours, i.e. until
> 2018-01-14T03:00:00Z
> (this is UTC time).
>
> --------
>
> Cheers,
> -Rob
>
> [1] http://apache.org/foundation/voting.html
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

Jörg Schaible-5
In reply to this post by garydgregory
Am Wed, 10 Jan 2018 20:35:52 -0700 schrieb Gary Gregory:

> I wonder if:
> - This should be a LAZY VOTE since this is not an official component but
> rather a tool

+1

> - We should release it as 1.0 anyway (unless obvious bugs
> are found) to avoid the chicken and egg problem: To really test this, I
> want to create an RC for Commons Collection (for example). But that
> means using a commons-release-plugin 1.0 version in my POM - which we
> cannot release as a repeatable build since 1.0 is not out yet. And
> cutting an RC with a 1.0-SNAPSHOT is not acceptable (not repeatable.)

we might release 1.0-RC1 (or 0.1) as Sergio suggested.

Cheers,
Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

Bruno P. Kinoshita-3
In reply to this post by Rob Tompkins-2
[ X ] +1 Release it.

I'm OK with the lazy vote from the other thread, or with this vote process. Both work fine for me.


And fantastic work! Build from tag passing with `mvn clean test site` on:


Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T20:58:13+13:00)
Maven home: /opt/apache-maven-3.5.2
Java version: 1.8.0_151, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-oracle/jre
Default locale: en_NZ, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-104-generic", arch: "amd64", family: "unix"

Reports look good. Verified signatures of binaries in dist, and maven staging repo, and everything looks good.

Amazing work on the test coverage. The few maven-plugins I work so far had a very small amount of tests to be honest.

Had a look at the code and it looks good too.

Minor nit-picks but no blockers IMO:

1) In pom.xml, the website is http://commons.apache.org/proper/commons-release-plugin/, but in README.md the website links
are possibly broken. For example, the homepage link is pointing to https://commons.apache.org/proper/commons-commons-release-plugin, and the javadocs also contains similar URL.

(notice the part commons-commons in the URL)

Is that a typo or a problem in some script that generates that README file?

2) In NOTICE.txt, it says Apache Commons Build Plugin, with a Copyright from 2008 to 2018. Shouldn't it say Apache Commons Release Plugin, with a Copyright from 2018 only for now?

3) In my working copy (checked out the tag) I have LICENSE *and* LICENSE.txt. Do we need both files? assembly/xml files seem to include LICENSE.txt, so I assume LICENSE can be removed? Or the xml files could be updated perhaps...


4) There's a typo in src/changes/release-notes.vm

On the first paragraph, the component name is spelled as "commons-release-plgin" (missing u in plugin).


5) Some .java files contain the @author tags. I think the convention now is to drop the author tags from source files, and instead rely on the SCM history only?


6) Few StringBuffers in some Mojos that perhaps could be replaced by StringBuilders?



Again, just nit-picks. Release looks good, +1 and kudos!!!


Cheers
Bruno
________________________________

From: Rob Tompkins <[hidden email]>
To: Commons Developers List <[hidden email]>
Sent: Thursday, 11 January 2018 3:50 PM
Subject: [VOTE] Release Commons Release Plugin 1.0 base on RC1



Hello all,


This is a [VOTE] for releasing Apache commons-release-plugin 1.0 (from RC1).


Tag name:

   commons-release-plugin-1.0-RC1 (signature can be checked from git using 'git tag -v')


Tag URL:

  https://git-wip-us.apache.org/repos/asf?p=commons-release-plugin.git;a=tag;h=6b05b8bee894ad471c5e1eda979550b344c21020


Commit ID the tag points at:

   2f48a0ebd07318419b4d92a7e7b594f4fca47428


Site:

  https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/site.zip


Distribution files (committed at revision 24125):

  https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/


Distribution files hashes (SHA1):

  commons-release-plugin-1.0-bin.tar.gz

  (SHA1: 02a0e034ed89c87e620ceaf4aef879121d4b87de)

  commons-release-plugin-1.0-bin.zip

  (SHA1: e0c4cf6449f6baab4c52c98c1e577512486d8fba)

  commons-release-plugin-1.0-src.tar.gz

  (SHA1: e48b67b70b154b7dc69914752814512225024504)

  commons-release-plugin-1.0-src.zip

  (SHA1: bc9a6c847899b2700e5873c4ac1a8d983476b255)


These are the Maven artifacts and their hashes:

  commons-release-plugin-1.0-javadoc.jar

  (SHA1: bc2cdfa56f55ee538087038a1194ea2789863ca9)

  commons-release-plugin-1.0-sources.jar

  (SHA1: eb20eec8580fd5a2633bd2822e951d57043d3d4e)

  commons-release-plugin-1.0-test-sources.jar

  (SHA1: 61aa51b44025ced470b0e21b19a3eb65e154df1f)

  commons-release-plugin-1.0-tests.jar

  (SHA1: a81f42e01ca77a86048e07963d4ea496a69251f6)

  commons-release-plugin-1.0.jar

  (SHA1: 2897ab01d2e8460d100d196db55e53b2a1bab73e)

  commons-release-plugin-1.0.pom

  (SHA1: 2bcc663eb212f9a2233acc21773ef80883ac0881)


KEYS file to check signatures:

  http://www.apache.org/dist/commons/KEYS


Maven artifacts:

  https://repository.apache.org/content/repositories/orgapachecommons-1302


Please select one of the following options[1]:

  [ ] +1 Release it.

  [ ] +0 Go ahead; I don't care.

  [ ] -0 There are a few minor glitches: ...

  [ ] -1 No, do not release it because ...



This vote will be open at least 72 hours, i.e. until

2018-01-14T03:00:00Z

(this is UTC time).


--------


Cheers,

-Rob


[1] http://apache.org/foundation/voting.html

---------------------------------------------------------------------

To unsubscribe, e-mail: [hidden email]

For additional commands, e-mail: [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

Rob Tompkins
In reply to this post by Jörg Schaible-5
If you want to really test it in dry run mode you could run “mvn clean install” on the src artifact and then configure it in a component and run a test release. It should work just the same as if it was coming out of maven central.

-Rob

> On Jan 11, 2018, at 3:58 AM, Jörg Schaible <[hidden email]> wrote:
>
> Am Wed, 10 Jan 2018 20:35:52 -0700 schrieb Gary Gregory:
>
>> I wonder if:
>> - This should be a LAZY VOTE since this is not an official component but
>> rather a tool
>
> +1
>
>> - We should release it as 1.0 anyway (unless obvious bugs
>> are found) to avoid the chicken and egg problem: To really test this, I
>> want to create an RC for Commons Collection (for example). But that
>> means using a commons-release-plugin 1.0 version in my POM - which we
>> cannot release as a repeatable build since 1.0 is not out yet. And
>> cutting an RC with a 1.0-SNAPSHOT is not acceptable (not repeatable.)
>
> we might release 1.0-RC1 (or 0.1) as Sergio suggested.
>
> Cheers,
> Jörg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

Rob Tompkins
In reply to this post by Jörg Schaible-5
If you do try to run it locally make sure you add
<dryRun>true</dryRun>

To the configuration section of the plugin.

> On Jan 11, 2018, at 3:58 AM, Jörg Schaible <[hidden email]> wrote:
>
> Am Wed, 10 Jan 2018 20:35:52 -0700 schrieb Gary Gregory:
>
>> I wonder if:
>> - This should be a LAZY VOTE since this is not an official component but
>> rather a tool
>
> +1
>
>> - We should release it as 1.0 anyway (unless obvious bugs
>> are found) to avoid the chicken and egg problem: To really test this, I
>> want to create an RC for Commons Collection (for example). But that
>> means using a commons-release-plugin 1.0 version in my POM - which we
>> cannot release as a repeatable build since 1.0 is not out yet. And
>> cutting an RC with a 1.0-SNAPSHOT is not acceptable (not repeatable.)
>
> we might release 1.0-RC1 (or 0.1) as Sergio suggested.
>
> Cheers,
> Jörg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

sebb-2-2
On 11 January 2018 at 14:42, Rob Tompkins <[hidden email]> wrote:
> If you do try to run it locally make sure you add
> <dryRun>true</dryRun>

It would be useful to be able to define this on the command-line.

> To the configuration section of the plugin.
>
>> On Jan 11, 2018, at 3:58 AM, Jörg Schaible <[hidden email]> wrote:
>>
>> Am Wed, 10 Jan 2018 20:35:52 -0700 schrieb Gary Gregory:
>>
>>> I wonder if:
>>> - This should be a LAZY VOTE since this is not an official component but
>>> rather a tool
>>
>> +1
>>
>>> - We should release it as 1.0 anyway (unless obvious bugs
>>> are found) to avoid the chicken and egg problem: To really test this, I
>>> want to create an RC for Commons Collection (for example). But that
>>> means using a commons-release-plugin 1.0 version in my POM - which we
>>> cannot release as a repeatable build since 1.0 is not out yet. And
>>> cutting an RC with a 1.0-SNAPSHOT is not acceptable (not repeatable.)
>>
>> we might release 1.0-RC1 (or 0.1) as Sergio suggested.
>>
>> Cheers,
>> Jörg
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

Rob Tompkins
I had that quickly set up by adding

<dryRun>${dryRun}</dryRun>

to the plugin configuration, but I admit  that’s a bit of a hack. I was just trying to be speedy in the first version of the plugin for folks’ benefit.

> On Jan 11, 2018, at 7:25 PM, sebb <[hidden email]> wrote:
>
>> On 11 January 2018 at 14:42, Rob Tompkins <[hidden email]> wrote:
>> If you do try to run it locally make sure you add
>> <dryRun>true</dryRun>
>
> It would be useful to be able to define this on the command-line.
>
>> To the configuration section of the plugin.
>>
>>> On Jan 11, 2018, at 3:58 AM, Jörg Schaible <[hidden email]> wrote:
>>>
>>> Am Wed, 10 Jan 2018 20:35:52 -0700 schrieb Gary Gregory:
>>>
>>>> I wonder if:
>>>> - This should be a LAZY VOTE since this is not an official component but
>>>> rather a tool
>>>
>>> +1
>>>
>>>> - We should release it as 1.0 anyway (unless obvious bugs
>>>> are found) to avoid the chicken and egg problem: To really test this, I
>>>> want to create an RC for Commons Collection (for example). But that
>>>> means using a commons-release-plugin 1.0 version in my POM - which we
>>>> cannot release as a repeatable build since 1.0 is not out yet. And
>>>> cutting an RC with a 1.0-SNAPSHOT is not acceptable (not repeatable.)
>>>
>>> we might release 1.0-RC1 (or 0.1) as Sergio suggested.
>>>
>>> Cheers,
>>> Jörg
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

garydgregory
Tangent: It just occurred to me that this could have helped in the process
of developing this plugin:
https://github.com/ok2c/httpcomponents-release-tools/wiki

Gary

On Thu, Jan 11, 2018 at 6:54 PM, Rob Tompkins <[hidden email]> wrote:

> I had that quickly set up by adding
>
> <dryRun>${dryRun}</dryRun>
>
> to the plugin configuration, but I admit  that’s a bit of a hack. I was
> just trying to be speedy in the first version of the plugin for folks’
> benefit.
>
> > On Jan 11, 2018, at 7:25 PM, sebb <[hidden email]> wrote:
> >
> >> On 11 January 2018 at 14:42, Rob Tompkins <[hidden email]> wrote:
> >> If you do try to run it locally make sure you add
> >> <dryRun>true</dryRun>
> >
> > It would be useful to be able to define this on the command-line.
> >
> >> To the configuration section of the plugin.
> >>
> >>> On Jan 11, 2018, at 3:58 AM, Jörg Schaible <
> [hidden email]> wrote:
> >>>
> >>> Am Wed, 10 Jan 2018 20:35:52 -0700 schrieb Gary Gregory:
> >>>
> >>>> I wonder if:
> >>>> - This should be a LAZY VOTE since this is not an official component
> but
> >>>> rather a tool
> >>>
> >>> +1
> >>>
> >>>> - We should release it as 1.0 anyway (unless obvious bugs
> >>>> are found) to avoid the chicken and egg problem: To really test this,
> I
> >>>> want to create an RC for Commons Collection (for example). But that
> >>>> means using a commons-release-plugin 1.0 version in my POM - which we
> >>>> cannot release as a repeatable build since 1.0 is not out yet. And
> >>>> cutting an RC with a 1.0-SNAPSHOT is not acceptable (not repeatable.)
> >>>
> >>> we might release 1.0-RC1 (or 0.1) as Sergio suggested.
> >>>
> >>> Cheers,
> >>> Jörg
> >>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: [hidden email]
> >>> For additional commands, e-mail: [hidden email]
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

[release-plugin] release process (Was: Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1)

Rob Tompkins
Given that right now we don’t have sufficient votes to release the plugin, do folks want me to cancel this vote in leu of the lazy vote process cleaning up the nits that folks have found? I’m curious since folks don’t seem to have the appetite for this process.

> On Jan 11, 2018, at 10:51 PM, Gary Gregory <[hidden email]> wrote:
>
> Tangent: It just occurred to me that this could have helped in the process
> of developing this plugin:
> https://github.com/ok2c/httpcomponents-release-tools/wiki
>
> Gary
>
> On Thu, Jan 11, 2018 at 6:54 PM, Rob Tompkins <[hidden email]> wrote:
>
>> I had that quickly set up by adding
>>
>> <dryRun>${dryRun}</dryRun>
>>
>> to the plugin configuration, but I admit  that’s a bit of a hack. I was
>> just trying to be speedy in the first version of the plugin for folks’
>> benefit.
>>
>>> On Jan 11, 2018, at 7:25 PM, sebb <[hidden email]> wrote:
>>>
>>>> On 11 January 2018 at 14:42, Rob Tompkins <[hidden email]> wrote:
>>>> If you do try to run it locally make sure you add
>>>> <dryRun>true</dryRun>
>>>
>>> It would be useful to be able to define this on the command-line.
>>>
>>>> To the configuration section of the plugin.
>>>>
>>>>> On Jan 11, 2018, at 3:58 AM, Jörg Schaible <
>> [hidden email]> wrote:
>>>>>
>>>>> Am Wed, 10 Jan 2018 20:35:52 -0700 schrieb Gary Gregory:
>>>>>
>>>>>> I wonder if:
>>>>>> - This should be a LAZY VOTE since this is not an official component
>> but
>>>>>> rather a tool
>>>>>
>>>>> +1
>>>>>
>>>>>> - We should release it as 1.0 anyway (unless obvious bugs
>>>>>> are found) to avoid the chicken and egg problem: To really test this,
>> I
>>>>>> want to create an RC for Commons Collection (for example). But that
>>>>>> means using a commons-release-plugin 1.0 version in my POM - which we
>>>>>> cannot release as a repeatable build since 1.0 is not out yet. And
>>>>>> cutting an RC with a 1.0-SNAPSHOT is not acceptable (not repeatable.)
>>>>>
>>>>> we might release 1.0-RC1 (or 0.1) as Sergio suggested.
>>>>>
>>>>> Cheers,
>>>>> Jörg
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: [hidden email]
>>>>> For additional commands, e-mail: [hidden email]
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [hidden email]
>>>> For additional commands, e-mail: [hidden email]
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [release-plugin] release process (Was: Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1)

Gilles Sadowski
On Sat, 13 Jan 2018 08:48:19 -0500, Rob Tompkins wrote:
> Given that right now we don’t have sufficient votes to release the
> plugin, do folks want me to cancel this vote in leu of the lazy vote
> process cleaning up the nits that folks have found? I’m curious since
> folks don’t seem to have the appetite for this process.

?

I don't think that anyone disagreed about "lazy" voting.
So, you can do as you please.
[IIUC, Gary is waiting for a release of the your new release
plugin in order to attempt the release of a component.]

I surely am interested in the *idea* which I have about
what you have been doing.  [I did not read a single line of
the plugin code!  But I hope that it will solve the problem
which I have exposed (about creating the distribution files
for a modular project).]

Regards,
Gilles

>> On Jan 11, 2018, at 10:51 PM, Gary Gregory <[hidden email]>
>> wrote:
>>
>> Tangent: It just occurred to me that this could have helped in the
>> process
>> of developing this plugin:
>> https://github.com/ok2c/httpcomponents-release-tools/wiki
>>
>> Gary
>>
>> On Thu, Jan 11, 2018 at 6:54 PM, Rob Tompkins <[hidden email]>
>> wrote:
>>
>>> I had that quickly set up by adding
>>>
>>> <dryRun>${dryRun}</dryRun>
>>>
>>> to the plugin configuration, but I admit  that’s a bit of a hack. I
>>> was
>>> just trying to be speedy in the first version of the plugin for
>>> folks’
>>> benefit.
>>>
>>>> On Jan 11, 2018, at 7:25 PM, sebb <[hidden email]> wrote:
>>>>
>>>>> On 11 January 2018 at 14:42, Rob Tompkins <[hidden email]>
>>>>> wrote:
>>>>> If you do try to run it locally make sure you add
>>>>> <dryRun>true</dryRun>
>>>>
>>>> It would be useful to be able to define this on the command-line.
>>>>
>>>>> To the configuration section of the plugin.
>>>>>
>>>>>> On Jan 11, 2018, at 3:58 AM, Jörg Schaible <
>>> [hidden email]> wrote:
>>>>>>
>>>>>> Am Wed, 10 Jan 2018 20:35:52 -0700 schrieb Gary Gregory:
>>>>>>
>>>>>>> I wonder if:
>>>>>>> - This should be a LAZY VOTE since this is not an official
>>>>>>> component
>>> but
>>>>>>> rather a tool
>>>>>>
>>>>>> +1
>>>>>>
>>>>>>> - We should release it as 1.0 anyway (unless obvious bugs
>>>>>>> are found) to avoid the chicken and egg problem: To really test
>>>>>>> this,
>>> I
>>>>>>> want to create an RC for Commons Collection (for example). But
>>>>>>> that
>>>>>>> means using a commons-release-plugin 1.0 version in my POM -
>>>>>>> which we
>>>>>>> cannot release as a repeatable build since 1.0 is not out yet.
>>>>>>> And
>>>>>>> cutting an RC with a 1.0-SNAPSHOT is not acceptable (not
>>>>>>> repeatable.)
>>>>>>
>>>>>> we might release 1.0-RC1 (or 0.1) as Sergio suggested.
>>>>>>
>>>>>> Cheers,
>>>>>> Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [release-plugin] release process (Was: Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1)

garydgregory
In reply to this post by Rob Tompkins
I will find some time to review this weekend.

Gary

On Jan 13, 2018 6:48 AM, "Rob Tompkins" <[hidden email]> wrote:

> Given that right now we don’t have sufficient votes to release the plugin,
> do folks want me to cancel this vote in leu of the lazy vote process
> cleaning up the nits that folks have found? I’m curious since folks don’t
> seem to have the appetite for this process.
>
> > On Jan 11, 2018, at 10:51 PM, Gary Gregory <[hidden email]>
> wrote:
> >
> > Tangent: It just occurred to me that this could have helped in the
> process
> > of developing this plugin:
> > https://github.com/ok2c/httpcomponents-release-tools/wiki
> >
> > Gary
> >
> > On Thu, Jan 11, 2018 at 6:54 PM, Rob Tompkins <[hidden email]>
> wrote:
> >
> >> I had that quickly set up by adding
> >>
> >> <dryRun>${dryRun}</dryRun>
> >>
> >> to the plugin configuration, but I admit  that’s a bit of a hack. I was
> >> just trying to be speedy in the first version of the plugin for folks’
> >> benefit.
> >>
> >>> On Jan 11, 2018, at 7:25 PM, sebb <[hidden email]> wrote:
> >>>
> >>>> On 11 January 2018 at 14:42, Rob Tompkins <[hidden email]> wrote:
> >>>> If you do try to run it locally make sure you add
> >>>> <dryRun>true</dryRun>
> >>>
> >>> It would be useful to be able to define this on the command-line.
> >>>
> >>>> To the configuration section of the plugin.
> >>>>
> >>>>> On Jan 11, 2018, at 3:58 AM, Jörg Schaible <
> >> [hidden email]> wrote:
> >>>>>
> >>>>> Am Wed, 10 Jan 2018 20:35:52 -0700 schrieb Gary Gregory:
> >>>>>
> >>>>>> I wonder if:
> >>>>>> - This should be a LAZY VOTE since this is not an official component
> >> but
> >>>>>> rather a tool
> >>>>>
> >>>>> +1
> >>>>>
> >>>>>> - We should release it as 1.0 anyway (unless obvious bugs
> >>>>>> are found) to avoid the chicken and egg problem: To really test
> this,
> >> I
> >>>>>> want to create an RC for Commons Collection (for example). But that
> >>>>>> means using a commons-release-plugin 1.0 version in my POM - which
> we
> >>>>>> cannot release as a repeatable build since 1.0 is not out yet. And
> >>>>>> cutting an RC with a 1.0-SNAPSHOT is not acceptable (not
> repeatable.)
> >>>>>
> >>>>> we might release 1.0-RC1 (or 0.1) as Sergio suggested.
> >>>>>
> >>>>> Cheers,
> >>>>> Jörg
> >>>>>
> >>>>>
> >>>>> ------------------------------------------------------------
> ---------
> >>>>> To unsubscribe, e-mail: [hidden email]
> >>>>> For additional commands, e-mail: [hidden email]
> >>>>>
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: [hidden email]
> >>>> For additional commands, e-mail: [hidden email]
> >>>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: [hidden email]
> >>> For additional commands, e-mail: [hidden email]
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [release-plugin] release process (Was: Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1)

Oliver Heger-3
In reply to this post by Gilles Sadowski


Am 13.01.2018 um 15:36 schrieb Gilles:

> On Sat, 13 Jan 2018 08:48:19 -0500, Rob Tompkins wrote:
>> Given that right now we don’t have sufficient votes to release the
>> plugin, do folks want me to cancel this vote in leu of the lazy vote
>> process cleaning up the nits that folks have found? I’m curious since
>> folks don’t seem to have the appetite for this process.
>
> ?
>
> I don't think that anyone disagreed about "lazy" voting.
> So, you can do as you please.
> [IIUC, Gary is waiting for a release of the your new release
> plugin in order to attempt the release of a component.]

+1
Oliver

>
> I surely am interested in the *idea* which I have about
> what you have been doing.  [I did not read a single line of
> the plugin code!  But I hope that it will solve the problem
> which I have exposed (about creating the distribution files
> for a modular project).

>
> Regards,
> Gilles
>
>>> On Jan 11, 2018, at 10:51 PM, Gary Gregory <[hidden email]>
>>> wrote:
>>>
>>> Tangent: It just occurred to me that this could have helped in the
>>> process
>>> of developing this plugin:
>>> https://github.com/ok2c/httpcomponents-release-tools/wiki
>>>
>>> Gary
>>>
>>> On Thu, Jan 11, 2018 at 6:54 PM, Rob Tompkins <[hidden email]>
>>> wrote:
>>>
>>>> I had that quickly set up by adding
>>>>
>>>> <dryRun>${dryRun}</dryRun>
>>>>
>>>> to the plugin configuration, but I admit  that’s a bit of a hack. I was
>>>> just trying to be speedy in the first version of the plugin for folks’
>>>> benefit.
>>>>
>>>>> On Jan 11, 2018, at 7:25 PM, sebb <[hidden email]> wrote:
>>>>>
>>>>>> On 11 January 2018 at 14:42, Rob Tompkins <[hidden email]> wrote:
>>>>>> If you do try to run it locally make sure you add
>>>>>> <dryRun>true</dryRun>
>>>>>
>>>>> It would be useful to be able to define this on the command-line.
>>>>>
>>>>>> To the configuration section of the plugin.
>>>>>>
>>>>>>> On Jan 11, 2018, at 3:58 AM, Jörg Schaible <
>>>> [hidden email]> wrote:
>>>>>>>
>>>>>>> Am Wed, 10 Jan 2018 20:35:52 -0700 schrieb Gary Gregory:
>>>>>>>
>>>>>>>> I wonder if:
>>>>>>>> - This should be a LAZY VOTE since this is not an official
>>>>>>>> component
>>>> but
>>>>>>>> rather a tool
>>>>>>>
>>>>>>> +1
>>>>>>>
>>>>>>>> - We should release it as 1.0 anyway (unless obvious bugs
>>>>>>>> are found) to avoid the chicken and egg problem: To really test
>>>>>>>> this,
>>>> I
>>>>>>>> want to create an RC for Commons Collection (for example). But that
>>>>>>>> means using a commons-release-plugin 1.0 version in my POM -
>>>>>>>> which we
>>>>>>>> cannot release as a repeatable build since 1.0 is not out yet. And
>>>>>>>> cutting an RC with a 1.0-SNAPSHOT is not acceptable (not
>>>>>>>> repeatable.)
>>>>>>>
>>>>>>> we might release 1.0-RC1 (or 0.1) as Sergio suggested.
>>>>>>>
>>>>>>> Cheers,
>>>>>>> Jörg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

Rob Tompkins
In reply to this post by sebb-2-2


> On Jan 11, 2018, at 7:25 PM, sebb <[hidden email]> wrote:
>
> On 11 January 2018 at 14:42, Rob Tompkins <[hidden email]> wrote:
>> If you do try to run it locally make sure you add
>> <dryRun>true</dryRun>
>
> It would be useful to be able to define this on the command-line.

Bug found:

https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionStagingMojo.java#L88 <https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionStagingMojo.java#L88>

@Parameter(defaultValue = "false”)

should be:

@Parameter(property = "dryRun", defaultValue = "false”)

The intermediate workaround, like I emailed earlier, is:

<dryRun>${dryRun}</dryRun> in the configuration section.

-Rob

>
>> To the configuration section of the plugin.
>>
>>> On Jan 11, 2018, at 3:58 AM, Jörg Schaible <[hidden email]> wrote:
>>>
>>> Am Wed, 10 Jan 2018 20:35:52 -0700 schrieb Gary Gregory:
>>>
>>>> I wonder if:
>>>> - This should be a LAZY VOTE since this is not an official component but
>>>> rather a tool
>>>
>>> +1
>>>
>>>> - We should release it as 1.0 anyway (unless obvious bugs
>>>> are found) to avoid the chicken and egg problem: To really test this, I
>>>> want to create an RC for Commons Collection (for example). But that
>>>> means using a commons-release-plugin 1.0 version in my POM - which we
>>>> cannot release as a repeatable build since 1.0 is not out yet. And
>>>> cutting an RC with a 1.0-SNAPSHOT is not acceptable (not repeatable.)
>>>
>>> we might release 1.0-RC1 (or 0.1) as Sergio suggested.
>>>
>>> Cheers,
>>> Jörg
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

sebb-2-2
On 13 January 2018 at 15:56, Rob Tompkins <[hidden email]> wrote:

>
>
>> On Jan 11, 2018, at 7:25 PM, sebb <[hidden email]> wrote:
>>
>> On 11 January 2018 at 14:42, Rob Tompkins <[hidden email]> wrote:
>>> If you do try to run it locally make sure you add
>>> <dryRun>true</dryRun>
>>
>> It would be useful to be able to define this on the command-line.
>
> Bug found:
>
> https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionStagingMojo.java#L88 <https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionStagingMojo.java#L88>
>
> @Parameter(defaultValue = "false”)
>
> should be:
>
> @Parameter(property = "dryRun", defaultValue = "false”)

Can that clash with other plugins that have a dry-run feature?
If so, maybe it needs a distinguishing prefix.

>
> The intermediate workaround, like I emailed earlier, is:
>
> <dryRun>${dryRun}</dryRun> in the configuration section.
>
> -Rob
>
>>
>>> To the configuration section of the plugin.
>>>
>>>> On Jan 11, 2018, at 3:58 AM, Jörg Schaible <[hidden email]> wrote:
>>>>
>>>> Am Wed, 10 Jan 2018 20:35:52 -0700 schrieb Gary Gregory:
>>>>
>>>>> I wonder if:
>>>>> - This should be a LAZY VOTE since this is not an official component but
>>>>> rather a tool
>>>>
>>>> +1
>>>>
>>>>> - We should release it as 1.0 anyway (unless obvious bugs
>>>>> are found) to avoid the chicken and egg problem: To really test this, I
>>>>> want to create an RC for Commons Collection (for example). But that
>>>>> means using a commons-release-plugin 1.0 version in my POM - which we
>>>>> cannot release as a repeatable build since 1.0 is not out yet. And
>>>>> cutting an RC with a 1.0-SNAPSHOT is not acceptable (not repeatable.)
>>>>
>>>> we might release 1.0-RC1 (or 0.1) as Sergio suggested.
>>>>
>>>> Cheers,
>>>> Jörg
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [hidden email]
>>>> For additional commands, e-mail: [hidden email]
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

Rob Tompkins


> On Jan 14, 2018, at 6:50 PM, sebb <[hidden email]> wrote:
>
>> On 13 January 2018 at 15:56, Rob Tompkins <[hidden email]> wrote:
>>
>>
>>> On Jan 11, 2018, at 7:25 PM, sebb <[hidden email]> wrote:
>>>
>>> On 11 January 2018 at 14:42, Rob Tompkins <[hidden email]> wrote:
>>>> If you do try to run it locally make sure you add
>>>> <dryRun>true</dryRun>
>>>
>>> It would be useful to be able to define this on the command-line.
>>
>> Bug found:
>>
>> https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionStagingMojo.java#L88 <https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionStagingMojo.java#L88>
>>
>> @Parameter(defaultValue = "false”)
>>
>> should be:
>>
>> @Parameter(property = "dryRun", defaultValue = "false”)
>
> Can that clash with other plugins that have a dry-run feature?
> If so, maybe it needs a distinguishing prefix.
>

+1, thoughts on a follow on release with that and then some support for [rng]. Fortunately, as it is you can define your own dryRun -D variable based on what I said just below.

>>
>> The intermediate workaround, like I emailed earlier, is:
>>
>> <dryRun>${dryRun}</dryRun> in the configuration section.
>>
>> -Rob
>>
>>>
>>>> To the configuration section of the plugin.
>>>>
>>>>> On Jan 11, 2018, at 3:58 AM, Jörg Schaible <[hidden email]> wrote:
>>>>>
>>>>> Am Wed, 10 Jan 2018 20:35:52 -0700 schrieb Gary Gregory:
>>>>>
>>>>>> I wonder if:
>>>>>> - This should be a LAZY VOTE since this is not an official component but
>>>>>> rather a tool
>>>>>
>>>>> +1
>>>>>
>>>>>> - We should release it as 1.0 anyway (unless obvious bugs
>>>>>> are found) to avoid the chicken and egg problem: To really test this, I
>>>>>> want to create an RC for Commons Collection (for example). But that
>>>>>> means using a commons-release-plugin 1.0 version in my POM - which we
>>>>>> cannot release as a repeatable build since 1.0 is not out yet. And
>>>>>> cutting an RC with a 1.0-SNAPSHOT is not acceptable (not repeatable.)
>>>>>
>>>>> we might release 1.0-RC1 (or 0.1) as Sergio suggested.
>>>>>
>>>>> Cheers,
>>>>> Jörg
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: [hidden email]
>>>>> For additional commands, e-mail: [hidden email]
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [hidden email]
>>>> For additional commands, e-mail: [hidden email]
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

Stian Soiland-Reyes
In reply to this post by Rob Tompkins-2
+1 (Binding)

(While I might disagree in principle about removing source .tar.gz and
.zip from Maven repo, I say let's get the plugin released and find
more bugs later! :) )

Checked:

+1 gpg signatures
+1 sha1, md5
+1 source zip vs tar.gz
+1 binary zip vs tar.gz
+1 source vs git (for some reason git has duplicate LICENSE as well as
LICENSE.txt)
+1 mvn apache-rat:check
+1 no binaries (except test archives)
+1 LICENSE, NOTICE
+0 README refers to
https://commons.apache.org/proper/commons-commons-release-plugin/javadocs/api-release
which is 404 Not Found (site.zip has apidocs/)
+1 RELEASE-NOTES
+1 mvn clean install
+0 mvn repository kind of matches src? *)

*) I was unable to verify that
https://repository.apache.org/content/repositories/orgapachecommons-1302
contained artifacts from building this RC as the Maven repo do not
include the source zip/tar.gz (see principle above)




Tested with:

Apache Maven 3.3.9
Maven home: /usr/share/maven
Java version: 1.8.0_151, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.13.0-26-generic", arch: "amd64", family: "unix"

On 11 January 2018 at 02:50, Rob Tompkins <[hidden email]> wrote:

> Hello all,
>
> This is a [VOTE] for releasing Apache commons-release-plugin 1.0 (from RC1).
>
> Tag name:
>    commons-release-plugin-1.0-RC1 (signature can be checked from git using 'git tag -v')
>
> Tag URL:
>    https://git-wip-us.apache.org/repos/asf?p=commons-release-plugin.git;a=tag;h=6b05b8bee894ad471c5e1eda979550b344c21020
>
> Commit ID the tag points at:
>    2f48a0ebd07318419b4d92a7e7b594f4fca47428
>
> Site:
>    https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/site.zip
>
> Distribution files (committed at revision 24125):
>    https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/
>
> Distribution files hashes (SHA1):
>   commons-release-plugin-1.0-bin.tar.gz
>   (SHA1: 02a0e034ed89c87e620ceaf4aef879121d4b87de)
>   commons-release-plugin-1.0-bin.zip
>   (SHA1: e0c4cf6449f6baab4c52c98c1e577512486d8fba)
>   commons-release-plugin-1.0-src.tar.gz
>   (SHA1: e48b67b70b154b7dc69914752814512225024504)
>   commons-release-plugin-1.0-src.zip
>   (SHA1: bc9a6c847899b2700e5873c4ac1a8d983476b255)
>
> These are the Maven artifacts and their hashes:
>   commons-release-plugin-1.0-javadoc.jar
>   (SHA1: bc2cdfa56f55ee538087038a1194ea2789863ca9)
>   commons-release-plugin-1.0-sources.jar
>   (SHA1: eb20eec8580fd5a2633bd2822e951d57043d3d4e)
>   commons-release-plugin-1.0-test-sources.jar
>   (SHA1: 61aa51b44025ced470b0e21b19a3eb65e154df1f)
>   commons-release-plugin-1.0-tests.jar
>   (SHA1: a81f42e01ca77a86048e07963d4ea496a69251f6)
>   commons-release-plugin-1.0.jar
>   (SHA1: 2897ab01d2e8460d100d196db55e53b2a1bab73e)
>   commons-release-plugin-1.0.pom
>   (SHA1: 2bcc663eb212f9a2233acc21773ef80883ac0881)
>
> KEYS file to check signatures:
>    http://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
>    https://repository.apache.org/content/repositories/orgapachecommons-1302
>
> Please select one of the following options[1]:
>   [ ] +1 Release it.
>   [ ] +0 Go ahead; I don't care.
>   [ ] -0 There are a few minor glitches: ...
>   [ ] -1 No, do not release it because ...
>
>
> This vote will be open at least 72 hours, i.e. until
> 2018-01-14T03:00:00Z
> (this is UTC time).
>
> --------
>
> Cheers,
> -Rob
>
> [1] http://apache.org/foundation/voting.html
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>



--
Stian Soiland-Reyes
http://orcid.org/0000-0001-9842-9718

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Commons Release Plugin 1.0 base on RC1

Rob Tompkins
Curious if anyone else wants to weigh in?

> On Jan 16, 2018, at 6:55 AM, Stian Soiland-Reyes <[hidden email]> wrote:
>
> +1 (Binding)
>
> (While I might disagree in principle about removing source .tar.gz and
> .zip from Maven repo, I say let's get the plugin released and find
> more bugs later! :) )
>

This *should* be a configurable option. I don’t think though that it is in this version of the plugin. Personally, I want the plugin to accommodate any process that the project may use. So as the process changes one direction or another, so should the plugin.

> Checked:
>
> +1 gpg signatures
> +1 sha1, md5
> +1 source zip vs tar.gz
> +1 binary zip vs tar.gz
> +1 source vs git (for some reason git has duplicate LICENSE as well as
> LICENSE.txt)
> +1 mvn apache-rat:check
> +1 no binaries (except test archives)
> +1 LICENSE, NOTICE
> +0 README refers to
> https://commons.apache.org/proper/commons-commons-release-plugin/javadocs/api-release
> which is 404 Not Found (site.zip has apidocs/)
> +1 RELEASE-NOTES
> +1 mvn clean install
> +0 mvn repository kind of matches src? *)
>
> *) I was unable to verify that
> https://repository.apache.org/content/repositories/orgapachecommons-1302
> contained artifacts from building this RC as the Maven repo do not
> include the source zip/tar.gz (see principle above)
>
>
>
>
> Tested with:
>
> Apache Maven 3.3.9
> Maven home: /usr/share/maven
> Java version: 1.8.0_151, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.13.0-26-generic", arch: "amd64", family: "unix"
>
>> On 11 January 2018 at 02:50, Rob Tompkins <[hidden email]> wrote:
>> Hello all,
>>
>> This is a [VOTE] for releasing Apache commons-release-plugin 1.0 (from RC1).
>>
>> Tag name:
>>   commons-release-plugin-1.0-RC1 (signature can be checked from git using 'git tag -v')
>>
>> Tag URL:
>>   https://git-wip-us.apache.org/repos/asf?p=commons-release-plugin.git;a=tag;h=6b05b8bee894ad471c5e1eda979550b344c21020
>>
>> Commit ID the tag points at:
>>   2f48a0ebd07318419b4d92a7e7b594f4fca47428
>>
>> Site:
>>   https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/site.zip
>>
>> Distribution files (committed at revision 24125):
>>   https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/
>>
>> Distribution files hashes (SHA1):
>>  commons-release-plugin-1.0-bin.tar.gz
>>  (SHA1: 02a0e034ed89c87e620ceaf4aef879121d4b87de)
>>  commons-release-plugin-1.0-bin.zip
>>  (SHA1: e0c4cf6449f6baab4c52c98c1e577512486d8fba)
>>  commons-release-plugin-1.0-src.tar.gz
>>  (SHA1: e48b67b70b154b7dc69914752814512225024504)
>>  commons-release-plugin-1.0-src.zip
>>  (SHA1: bc9a6c847899b2700e5873c4ac1a8d983476b255)
>>
>> These are the Maven artifacts and their hashes:
>>  commons-release-plugin-1.0-javadoc.jar
>>  (SHA1: bc2cdfa56f55ee538087038a1194ea2789863ca9)
>>  commons-release-plugin-1.0-sources.jar
>>  (SHA1: eb20eec8580fd5a2633bd2822e951d57043d3d4e)
>>  commons-release-plugin-1.0-test-sources.jar
>>  (SHA1: 61aa51b44025ced470b0e21b19a3eb65e154df1f)
>>  commons-release-plugin-1.0-tests.jar
>>  (SHA1: a81f42e01ca77a86048e07963d4ea496a69251f6)
>>  commons-release-plugin-1.0.jar
>>  (SHA1: 2897ab01d2e8460d100d196db55e53b2a1bab73e)
>>  commons-release-plugin-1.0.pom
>>  (SHA1: 2bcc663eb212f9a2233acc21773ef80883ac0881)
>>
>> KEYS file to check signatures:
>>   http://www.apache.org/dist/commons/KEYS
>>
>> Maven artifacts:
>>   https://repository.apache.org/content/repositories/orgapachecommons-1302
>>
>> Please select one of the following options[1]:
>>  [ ] +1 Release it.
>>  [ ] +0 Go ahead; I don't care.
>>  [ ] -0 There are a few minor glitches: ...
>>  [ ] -1 No, do not release it because ...
>>
>>
>> This vote will be open at least 72 hours, i.e. until
>> 2018-01-14T03:00:00Z
>> (this is UTC time).
>>
>> --------
>>
>> Cheers,
>> -Rob
>>
>> [1] http://apache.org/foundation/voting.html
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
>
>
> --
> Stian Soiland-Reyes
> http://orcid.org/0000-0001-9842-9718
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

12