[VOTE] Release Imaging 1.0 from RC5

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Imaging 1.0 from RC5

Damjan Jovanovic-2
Please vote on releasing commons-imaging 1.0 from RC5.

RC4 and its problems and their fixes were in this thread:
http://mail-archives.apache.org/mod_mbox/commons-dev/201209.mbox/%3CCAJm2B-nbnbJwNUKkAtapZuzT5jfFODsk1aXcdsUUeoC%2BxXrDKg%40mail.gmail.com%3E
There were also many recent discussions on the development list.

Imaging 1.0 RC5 is available here:
https://dist.apache.org/repos/dist/dev/commons/imaging/ (SVN revision 3391)

Maven artifacts:
https://repository.apache.org/content/repositories/staging/org/apache/commons/commons-
imaging/

Change log(s):
https://dist.apache.org/repos/dist/dev/commons/imaging/RELEASE-NOTES.txt
http://people.apache.org/~damjan/imaging-1.0-RC5/changes-report.html
http://people.apache.org/~damjan/imaging-1.0-RC5/jira-report.html

Tag:
https://svn.apache.org/repos/asf/commons/proper/imaging/tags/IMAGING_1_0_RC5<https://svn.apache.org/repos/asf/commons/proper/imaging/tags/IMAGING_1_0_RC4>(SVN
revision 1537825)

Site:
http://people.apache.org/~damjan/imaging-1.0-RC5/<http://people.apache.org/%7Edamjan/imaging-1.0rc4/>

I have tested it with OpenJDK 6 on FreeBSD 9.1.

Please review and vote. This vote will close no sooner than 72 hours from
now, on Monday 4 November 2013 at 12:00 GMT.

[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...

Thank you!

Damjan Jovanovic
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Imaging 1.0 from RC5

Benedikt Ritter-4
Hello Damjan,

I've build the RC with:

Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
17:22:22+0200)
Maven home: /Applications/dev/maven/apache-maven-3.1.1
Java version: 1.7.0_40, vendor: Oracle Corporation
Java home:
/Library/Java/JavaVirtualMachines/jdk1.7.0_40.jdk/Contents/Home/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.9", arch: "x86_64", family:"mac"


- builds fine,

- signatures are ok

- src archives and tag contain the same content

- Some points about the site: There are a lot of FindBugs and PMD
violations. The test coverage in parts of the code base is very low (< 50%)


I can not comment about FindBugs and PMD. Imaging is a relatively low level
library and I guess this kind of things are hard to fix when doing this
kind of computations. So this ist not a blocker for me (but others my see
this differently)


The low test coverage really gives me a bad feeling... But again I don't
know how hard it is to improve it.


That said I'm hesitant to vote with +1. I'd give you a +1 if at least the
low test coverage was fixed (at least more than 50% in every package would
be fine).


For releasing RC5 I vote +0.5.


Thanks for pushing this forward!


Benedikt


2013/11/1 Damjan Jovanovic <[hidden email]>

> Please vote on releasing commons-imaging 1.0 from RC5.
>
> RC4 and its problems and their fixes were in this thread:
>
> http://mail-archives.apache.org/mod_mbox/commons-dev/201209.mbox/%3CCAJm2B-nbnbJwNUKkAtapZuzT5jfFODsk1aXcdsUUeoC%2BxXrDKg%40mail.gmail.com%3E
> There were also many recent discussions on the development list.
>
> Imaging 1.0 RC5 is available here:
> https://dist.apache.org/repos/dist/dev/commons/imaging/ (SVN revision
> 3391)
>
> Maven artifacts:
>
> https://repository.apache.org/content/repositories/staging/org/apache/commons/commons-
> imaging/
>
> Change log(s):
> https://dist.apache.org/repos/dist/dev/commons/imaging/RELEASE-NOTES.txt
> http://people.apache.org/~damjan/imaging-1.0-RC5/changes-report.html
> http://people.apache.org/~damjan/imaging-1.0-RC5/jira-report.html
>
> Tag:
>
> https://svn.apache.org/repos/asf/commons/proper/imaging/tags/IMAGING_1_0_RC5
> <
> https://svn.apache.org/repos/asf/commons/proper/imaging/tags/IMAGING_1_0_RC4
> >(SVN
> revision 1537825)
>
> Site:
> http://people.apache.org/~damjan/imaging-1.0-RC5/<
> http://people.apache.org/%7Edamjan/imaging-1.0rc4/>
>
> I have tested it with OpenJDK 6 on FreeBSD 9.1.
>
> Please review and vote. This vote will close no sooner than 72 hours from
> now, on Monday 4 November 2013 at 12:00 GMT.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thank you!
>
> Damjan Jovanovic
>



--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Imaging 1.0 from RC5

garydgregory
In reply to this post by Damjan Jovanovic-2
Thank you Damjan for cutting another release!

In the future, please summarize changes from RC to RC in the VOTE email.
The link to the VOTE thread is too much of a hunt to understand what's
changed. I might as well look at SVN.

I admire Damjan's persistence and patience in seeing through another RC
toward 1.0 :)

[X] -0 OK, but really should fix...

- The RAT report shows "40 Unknown Licenses", either add license headers or
get RAT to ignore these files.

- On the "References" page, all the links to Geocities are broken. Either
remove the broken links or link to the internet archive wayback machine or
similar.

- Is the to-do list on the site 100% accurate?
https://people.apache.org/~damjan/imaging-1.0-RC5/todo.html

- I would also change the title of the page from "To Do" to "Roadmap" and
talk about the upcoming 2.0 plan how 1.0 relates to 0.97 (new package).

- We need a "Migrating from 0.97 to 1.0" and "Plans for 2.0" sections, IMO.

- For the page "Project Status and History", I would just call it
"History". This page is missing versions.

- Javadoc: Most packages are missing a package-level description.

- Findbugs reports
org.apache.commons.imaging.icc.IccProfileParser.issRGB(ICC_Profile) has
Boolean return type and returns explicit null BAD_PRACTICE (and others like
it).
For methods like
org.apache.commons.imaging.icc.IccProfileParser.issRGB(ICC_Profile), it
seems to complicate the code a lot more to return a Boolean instead of a
boolean.
We should consider changing these APIs to boolean. I've only looks at
IccProfileParser.issRGB
and this one case seems OK for change.

- Checkstyle: We have a lot of 'Useless parentheses', the few I've checked
seem like they should be removed. This is a lot of work to check one at a
time and I do not think we should remove them all automatically (like
Eclipse can do) unless the person most familiar with the code chooses to do
so.

- I'm not a fan of using interfaces (instead of classes) to define
constants, but if this in fact the style we're going forward with, we
should not redundantly define each constant as public, a fact that is
implied by being an interface member (and which Checkstyle complains about.)

- Findbugs: WRT byte arrays and "malicious code", it seems safe to ignore
these since we are working with bytes all the time. I'm not sure if it is
worth Javadoc'ing this intention or adding some kinds of comment in the
source Findbugs can use to avoid these warnings. It's probably NOT worth
doing, but I thought I'd mention it.

Tested with:

Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
11:22:22-0400)
Maven home: C:\Java\apache-maven-3.1.1\bin\..
Java version: 1.7.0_45, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_45\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"

Gary


On Fri, Nov 1, 2013 at 7:57 AM, Damjan Jovanovic <[hidden email]> wrote:

> Please vote on releasing commons-imaging 1.0 from RC5.
>
> RC4 and its problems and their fixes were in this thread:
>
> http://mail-archives.apache.org/mod_mbox/commons-dev/201209.mbox/%3CCAJm2B-nbnbJwNUKkAtapZuzT5jfFODsk1aXcdsUUeoC%2BxXrDKg%40mail.gmail.com%3E
> There were also many recent discussions on the development list.
>
> Imaging 1.0 RC5 is available here:
> https://dist.apache.org/repos/dist/dev/commons/imaging/ (SVN revision
> 3391)
>
> Maven artifacts:
>
> https://repository.apache.org/content/repositories/staging/org/apache/commons/commons-
> imaging/
>
> Change log(s):
> https://dist.apache.org/repos/dist/dev/commons/imaging/RELEASE-NOTES.txt
> http://people.apache.org/~damjan/imaging-1.0-RC5/changes-report.html
> http://people.apache.org/~damjan/imaging-1.0-RC5/jira-report.html
>
> Tag:
>
> https://svn.apache.org/repos/asf/commons/proper/imaging/tags/IMAGING_1_0_RC5
> <
> https://svn.apache.org/repos/asf/commons/proper/imaging/tags/IMAGING_1_0_RC4
> >(SVN
> revision 1537825)
>
> Site:
> http://people.apache.org/~damjan/imaging-1.0-RC5/<
> http://people.apache.org/%7Edamjan/imaging-1.0rc4/>
>
> I have tested it with OpenJDK 6 on FreeBSD 9.1.
>
> Please review and vote. This vote will close no sooner than 72 hours from
> now, on Monday 4 November 2013 at 12:00 GMT.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thank you!
>
> Damjan Jovanovic
>



--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Imaging 1.0 from RC5

Jörg Schaible
In reply to this post by Damjan Jovanovic-2
Hi Damjan,

Damjan Jovanovic wrote:

> Please vote on releasing commons-imaging 1.0 from RC5.
>
> RC4 and its problems and their fixes were in this thread:
> http://mail-archives.apache.org/mod_mbox/commons-dev/201209.mbox/%3CCAJm2B-nbnbJwNUKkAtapZuzT5jfFODsk1aXcdsUUeoC%2BxXrDKg%40mail.gmail.com%3E
> There were also many recent discussions on the development list.
>
> Imaging 1.0 RC5 is available here:
> https://dist.apache.org/repos/dist/dev/commons/imaging/ (SVN revision
> 3391)
>
> Maven artifacts:
>
https://repository.apache.org/content/repositories/staging/org/apache/commons/commons-> imaging/
>
> Change log(s):
> https://dist.apache.org/repos/dist/dev/commons/imaging/RELEASE-NOTES.txt
> http://people.apache.org/~damjan/imaging-1.0-RC5/changes-report.html
> http://people.apache.org/~damjan/imaging-1.0-RC5/jira-report.html
>
> Tag:
>
https://svn.apache.org/repos/asf/commons/proper/imaging/tags/IMAGING_1_0_RC5<https://svn.apache.org/repos/asf/commons/proper/imaging/tags/IMAGING_1_0_RC4>(SVN

> revision 1537825)
>
> Site:
> http://people.apache.org/~damjan/imaging-1.0-RC5/<http://people.apache.org/%7Edamjan/imaging-1.0rc4/>
>
> I have tested it with OpenJDK 6 on FreeBSD 9.1.
>
> Please review and vote. This vote will close no sooner than 72 hours from
> now, on Monday 4 November 2013 at 12:00 GMT.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thank you!
>
> Damjan Jovanovic

The following error was some time ago normal, but I haven't seen it for some
time now:

================= %< =====================
$ tar xf commons-imaging-1.0-src.tar.gz
tar: Skipping to next header

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
================= %< =====================

Do you still use an old version of the assembly plugin to build the tar
balls?


Building from source with Maven I have the same 32 test failures for all my
JDKs:
================= %< =====================
Failed tests:
  IcnsReadTest.test:36->IcnsBaseTest.getIcnsImages:45-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  IcoReadTest.test:36->IcoBaseTest.getIcoImages:41-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  RgbeReadTest.test:34->RgbeBaseTest.getRgbeImages:43-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  WbmpReadTest.test:34->WbmpBaseTest.getWbmpImages:37-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  JpegXmpDumpTest.test:33->JpegXmpBaseTest.getImagesWithXmpData:73-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  JpegXmpRewriteTest.testRemoveInsertUpdate:38-
>JpegXmpBaseTest.getImagesWithXmpData:73->ImagingTest.getTestImages:108-
>ImagingTest.getTestImages:168 null
  IptcUpdateTest.setUp:46->IptcBaseTest.getImagesWithIptcData:71-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  IptcUpdateTest.setUp:46->IptcBaseTest.getImagesWithIptcData:71-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  IptcUpdateTest.setUp:46->IptcBaseTest.getImagesWithIptcData:71-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  IptcDumpTest.test:34->IptcBaseTest.getImagesWithIptcData:71-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  MicrosoftTagTest.testRewrite:66->ExifBaseTest.getImageWithExifData:73-
>ImagingTest.getTestImage:95->ImagingTest.getTestImages:168 null
  ExifRewriteTest.testRewriteLossless:277->rewrite:177-
>ExifBaseTest.getImagesWithExifData:78->ImagingTest.getTestImages:108-
>ImagingTest.getTestImages:168 null
  ExifRewriteTest.testRewriteLossy:264->rewrite:177-
>ExifBaseTest.getImagesWithExifData:78->ImagingTest.getTestImages:108-
>ImagingTest.getTestImages:168 null
  ExifRewriteTest.testInsert:96->ExifBaseTest.getImagesWithExifData:78-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  ExifRewriteTest.testRemove:55->ExifBaseTest.getImagesWithExifData:78-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  WriteExifMetadataExampleTest.test:36->ExifBaseTest.getJpegImages:91-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  WriteExifMetadataExampleTest.testInsert:63->ExifBaseTest.getJpegImages:91-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  AsciiFieldTest.testSingleImage:38->ImagingTest.getTestImageByName:85-
>ImagingTest.getTestImage:95->ImagingTest.getTestImages:168 null
  GpsTest.test:35->ExifBaseTest.getImagesWithExifData:83-
>ImagingTest.getTestImages:168 null
  ExifDumpTest.test:39->ExifBaseTest.getImagesWithExifData:78-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  MakerNoteFieldTest>SpecificExifTagTest.testAllImages:49-
>ExifBaseTest.getImagesWithExifData:78->ImagingTest.getTestImages:108-
>ImagingTest.getTestImages:168 null
  MakerNoteFieldTest>SpecificExifTagTest.testSingleImage:44-
>ExifBaseTest.getImageWithExifData:73->ImagingTest.getTestImage:95-
>ImagingTest.getTestImages:168 null
  TextFieldTest>SpecificExifTagTest.testAllImages:49-
>ExifBaseTest.getImagesWithExifData:78->ImagingTest.getTestImages:108-
>ImagingTest.getTestImages:168 null
  TextFieldTest>SpecificExifTagTest.testSingleImage:44-
>ExifBaseTest.getImageWithExifData:73->ImagingTest.getTestImage:95-
>ImagingTest.getTestImages:168 null
  JpegReadTest.test:35->JpegBaseTest.getJpegImages:45-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  JpegWithJpegThumbnailTest.testSingleImage:33-
>ImagingTest.getTestImageByName:85->ImagingTest.getTestImage:95-
>ImagingTest.getTestImages:168 null
  PsdReadTest.test:34->PsdBaseTest.getPsdImages:43-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  XbmReadTest.test:34->XbmBaseTest.getXbmImages:38-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  PamReadTest.test:36->PamBaseTest.getPamImages:45-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  GifReadTest.test:34->GifBaseTest.getGifImages:45-
>ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
  ImagingGuessFormatTest.testGuess_all:42->testGuess:71 null
  ImagingGuessFormatTest.testGuess_unknown:63->testGuess:71 null

Tests run: 90, Failures: 32, Errors: 0, Skipped: 0
================= %< =====================
$ mvn -version
Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19
14:51:28+0100)
Maven home: /usr/share/maven-bin-3.0
Java version: 1.6.0_45, vendor: Sun Microsystems Inc.
Java home: /opt/sun-jdk-1.6.0.45/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.10.7-gentoo-r1", arch: "amd64", family: "unix"
================= %< =====================

- Jörg



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Imaging 1.0 from RC5

Thomas Neidhart
In reply to this post by Damjan Jovanovic-2
On 11/01/2013 12:57 PM, Damjan Jovanovic wrote:

> Please vote on releasing commons-imaging 1.0 from RC5.
>
> RC4 and its problems and their fixes were in this thread:
> http://mail-archives.apache.org/mod_mbox/commons-dev/201209.mbox/%3CCAJm2B-nbnbJwNUKkAtapZuzT5jfFODsk1aXcdsUUeoC%2BxXrDKg%40mail.gmail.com%3E
> There were also many recent discussions on the development list.
>
> Imaging 1.0 RC5 is available here:
> https://dist.apache.org/repos/dist/dev/commons/imaging/ (SVN revision 3391)
>
> Maven artifacts:
> https://repository.apache.org/content/repositories/staging/org/apache/commons/commons-
> imaging/
>
> Change log(s):
> https://dist.apache.org/repos/dist/dev/commons/imaging/RELEASE-NOTES.txt
> http://people.apache.org/~damjan/imaging-1.0-RC5/changes-report.html
> http://people.apache.org/~damjan/imaging-1.0-RC5/jira-report.html
>
> Tag:
> https://svn.apache.org/repos/asf/commons/proper/imaging/tags/IMAGING_1_0_RC5<https://svn.apache.org/repos/asf/commons/proper/imaging/tags/IMAGING_1_0_RC4>(SVN
> revision 1537825)
>
> Site:
> http://people.apache.org/~damjan/imaging-1.0-RC5/<http://people.apache.org/%7Edamjan/imaging-1.0rc4/>
>
> I have tested it with OpenJDK 6 on FreeBSD 9.1.
>
> Please review and vote. This vote will close no sooner than 72 hours from
> now, on Monday 4 November 2013 at 12:00 GMT.
>
> [x] +1 Release these artifacts

builds fine in my environment (all tests pass):

java version "1.7.0_25"
OpenJDK Runtime Environment (IcedTea 2.3.10) (7u25-2.3.10-1ubuntu0.12.04.2)
OpenJDK Server VM (build 23.7-b01, mixed mode)

Site and artifacts look good to.

So +1 and you did a great job!

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Imaging 1.0 from RC5

Damjan Jovanovic-2
In reply to this post by Jörg Schaible
On Sun, Nov 3, 2013 at 1:00 AM, Jörg Schaible <[hidden email]> wrote:

> Hi Damjan,
>
> Damjan Jovanovic wrote:
>
> > Please vote on releasing commons-imaging 1.0 from RC5.
> >
> > RC4 and its problems and their fixes were in this thread:
> >
> http://mail-archives.apache.org/mod_mbox/commons-dev/201209.mbox/%3CCAJm2B-nbnbJwNUKkAtapZuzT5jfFODsk1aXcdsUUeoC%2BxXrDKg%40mail.gmail.com%3E
> > There were also many recent discussions on the development list.
> >
> > Imaging 1.0 RC5 is available here:
> > https://dist.apache.org/repos/dist/dev/commons/imaging/ (SVN revision
> > 3391)
> >
> > Maven artifacts:
> >
>
> https://repository.apache.org/content/repositories/staging/org/apache/commons/commons->
> imaging/
> >
> > Change log(s):
> > https://dist.apache.org/repos/dist/dev/commons/imaging/RELEASE-NOTES.txt
> > http://people.apache.org/~damjan/imaging-1.0-RC5/changes-report.html
> > http://people.apache.org/~damjan/imaging-1.0-RC5/jira-report.html
> >
> > Tag:
> >
>
> https://svn.apache.org/repos/asf/commons/proper/imaging/tags/IMAGING_1_0_RC5
> <
> https://svn.apache.org/repos/asf/commons/proper/imaging/tags/IMAGING_1_0_RC4
> >(SVN
> > revision 1537825)
> >
> > Site:
> > http://people.apache.org/~damjan/imaging-1.0-RC5/<
> http://people.apache.org/%7Edamjan/imaging-1.0rc4/>
> >
> > I have tested it with OpenJDK 6 on FreeBSD 9.1.
> >
> > Please review and vote. This vote will close no sooner than 72 hours from
> > now, on Monday 4 November 2013 at 12:00 GMT.
> >
> > [ ] +1 Release these artifacts
> > [ ] +0 OK, but...
> > [ ] -0 OK, but really should fix...
> > [ ] -1 I oppose this release because...
> >
> > Thank you!
> >
> > Damjan Jovanovic
>
> The following error was some time ago normal, but I haven't seen it for
> some
> time now:
>
> ================= %< =====================
> $ tar xf commons-imaging-1.0-src.tar.gz
> tar: Skipping to next header
>
> gzip: stdin: unexpected end of file
> tar: Child returned status 1
> tar: Error is not recoverable: exiting now
> ================= %< =====================
>
> Do you still use an old version of the assembly plugin to build the tar
> balls?
>
>
Don't know why you get that. The assembly plugin version - 2.4 - is set by
the parent POM, works fine for everyone in every commons project, and has
worked fine for ages.



>
> Building from source with Maven I have the same 32 test failures for all my
> JDKs:
> ================= %< =====================
> Failed tests:
>   IcnsReadTest.test:36->IcnsBaseTest.getIcnsImages:45-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   IcoReadTest.test:36->IcoBaseTest.getIcoImages:41-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   RgbeReadTest.test:34->RgbeBaseTest.getRgbeImages:43-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   WbmpReadTest.test:34->WbmpBaseTest.getWbmpImages:37-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   JpegXmpDumpTest.test:33->JpegXmpBaseTest.getImagesWithXmpData:73-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   JpegXmpRewriteTest.testRemoveInsertUpdate:38-
> >JpegXmpBaseTest.getImagesWithXmpData:73->ImagingTest.getTestImages:108-
> >ImagingTest.getTestImages:168 null
>

ImagingTest.getTestImages:168 is
assertTrue(images.size() > 0);
where images was set to:
final List<File> images = new ArrayList<File>();
and then populated with images.
Either your test images aren't being found or something else is broken in
your setup.



>   IptcUpdateTest.setUp:46->IptcBaseTest.getImagesWithIptcData:71-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   IptcUpdateTest.setUp:46->IptcBaseTest.getImagesWithIptcData:71-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   IptcUpdateTest.setUp:46->IptcBaseTest.getImagesWithIptcData:71-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   IptcDumpTest.test:34->IptcBaseTest.getImagesWithIptcData:71-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   MicrosoftTagTest.testRewrite:66->ExifBaseTest.getImageWithExifData:73-
> >ImagingTest.getTestImage:95->ImagingTest.getTestImages:168 null
>   ExifRewriteTest.testRewriteLossless:277->rewrite:177-
> >ExifBaseTest.getImagesWithExifData:78->ImagingTest.getTestImages:108-
> >ImagingTest.getTestImages:168 null
>   ExifRewriteTest.testRewriteLossy:264->rewrite:177-
> >ExifBaseTest.getImagesWithExifData:78->ImagingTest.getTestImages:108-
> >ImagingTest.getTestImages:168 null
>   ExifRewriteTest.testInsert:96->ExifBaseTest.getImagesWithExifData:78-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   ExifRewriteTest.testRemove:55->ExifBaseTest.getImagesWithExifData:78-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   WriteExifMetadataExampleTest.test:36->ExifBaseTest.getJpegImages:91-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>
> WriteExifMetadataExampleTest.testInsert:63->ExifBaseTest.getJpegImages:91-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   AsciiFieldTest.testSingleImage:38->ImagingTest.getTestImageByName:85-
> >ImagingTest.getTestImage:95->ImagingTest.getTestImages:168 null
>   GpsTest.test:35->ExifBaseTest.getImagesWithExifData:83-
> >ImagingTest.getTestImages:168 null
>   ExifDumpTest.test:39->ExifBaseTest.getImagesWithExifData:78-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   MakerNoteFieldTest>SpecificExifTagTest.testAllImages:49-
> >ExifBaseTest.getImagesWithExifData:78->ImagingTest.getTestImages:108-
> >ImagingTest.getTestImages:168 null
>   MakerNoteFieldTest>SpecificExifTagTest.testSingleImage:44-
> >ExifBaseTest.getImageWithExifData:73->ImagingTest.getTestImage:95-
> >ImagingTest.getTestImages:168 null
>   TextFieldTest>SpecificExifTagTest.testAllImages:49-
> >ExifBaseTest.getImagesWithExifData:78->ImagingTest.getTestImages:108-
> >ImagingTest.getTestImages:168 null
>   TextFieldTest>SpecificExifTagTest.testSingleImage:44-
> >ExifBaseTest.getImageWithExifData:73->ImagingTest.getTestImage:95-
> >ImagingTest.getTestImages:168 null
>   JpegReadTest.test:35->JpegBaseTest.getJpegImages:45-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   JpegWithJpegThumbnailTest.testSingleImage:33-
> >ImagingTest.getTestImageByName:85->ImagingTest.getTestImage:95-
> >ImagingTest.getTestImages:168 null
>   PsdReadTest.test:34->PsdBaseTest.getPsdImages:43-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   XbmReadTest.test:34->XbmBaseTest.getXbmImages:38-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   PamReadTest.test:36->PamBaseTest.getPamImages:45-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   GifReadTest.test:34->GifBaseTest.getGifImages:45-
> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>   ImagingGuessFormatTest.testGuess_all:42->testGuess:71 null
>   ImagingGuessFormatTest.testGuess_unknown:63->testGuess:71 null
>
> Tests run: 90, Failures: 32, Errors: 0, Skipped: 0
> ================= %< =====================
> $ mvn -version
> Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19
> 14:51:28+0100)
> Maven home: /usr/share/maven-bin-3.0
> Java version: 1.6.0_45, vendor: Sun Microsystems Inc.
> Java home: /opt/sun-jdk-1.6.0.45/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.10.7-gentoo-r1", arch: "amd64", family:
> "unix"
> ================= %< =====================
>
> - Jörg
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Imaging 1.0 from RC5

Jörg Schaible
Hi Damjan,

Damjan Jovanovic wrote:

> On Sun, Nov 3, 2013 at 1:00 AM, Jörg Schaible <[hidden email]>
> wrote:

[snip]

>> The following error was some time ago normal, but I haven't seen it for
>> some
>> time now:
>>
>> ================= %< =====================
>> $ tar xf commons-imaging-1.0-src.tar.gz
>> tar: Skipping to next header
>>
>> gzip: stdin: unexpected end of file
>> tar: Child returned status 1
>> tar: Error is not recoverable: exiting now
>> ================= %< =====================
>>
>> Do you still use an old version of the assembly plugin to build the tar
>> balls?
>>
>>
> Don't know why you get that. The assembly plugin version - 2.4 - is set by
> the parent POM, works fine for everyone in every commons project, and has
> worked fine for ages.

I should have possibly a closer look to the message, because it is different
from the ones I've seen on a regular base with former releases of other
commons artifacts ... let's see ...

============== %< =============
$ tar xf commons-logging-1.1.1-src.tar.gz
tar: A lone zero block at 1830
============== %< =============
 

>> Building from source with Maven I have the same 32 test failures for all
>> my JDKs:
>> ================= %< =====================
>> Failed tests:
>>   IcnsReadTest.test:36->IcnsBaseTest.getIcnsImages:45-
>> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>>   IcoReadTest.test:36->IcoBaseTest.getIcoImages:41-
>> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>>   RgbeReadTest.test:34->RgbeBaseTest.getRgbeImages:43-
>> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>>   WbmpReadTest.test:34->WbmpBaseTest.getWbmpImages:37-
>> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>>   JpegXmpDumpTest.test:33->JpegXmpBaseTest.getImagesWithXmpData:73-
>> >ImagingTest.getTestImages:108->ImagingTest.getTestImages:168 null
>>   JpegXmpRewriteTest.testRemoveInsertUpdate:38-
>> >JpegXmpBaseTest.getImagesWithXmpData:73->ImagingTest.getTestImages:108-
>> >ImagingTest.getTestImages:168 null
>>
>
> ImagingTest.getTestImages:168 is
> assertTrue(images.size() > 0);
> where images was set to:
> final List<File> images = new ArrayList<File>();
> and then populated with images.
> Either your test images aren't being found or something else is broken in
> your setup.

Meanwhile I fear that I started to extract the archive although it was not
yet complete. I just did not recognize that it is a lot bigger than the
average commons source ;-)

At least it would explain all the reported stuff.

Sorry for the noise :-/

- Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Imaging 1.0 from RC5

Damjan Jovanovic
In reply to this post by garydgregory
On Fri, Nov 1, 2013 at 8:24 PM, Gary Gregory <[hidden email]> wrote:

> Thank you Damjan for cutting another release!
>
> In the future, please summarize changes from RC to RC in the VOTE email.
> The link to the VOTE thread is too much of a hunt to understand what's
> changed. I might as well look at SVN.
>
> I admire Damjan's persistence and patience in seeing through another RC
> toward 1.0 :)
>

Thank you :).


> [X] -0 OK, but really should fix...
>
> - The RAT report shows "40 Unknown Licenses", either add license headers or
> get RAT to ignore these files.
>

RAT's Maven plugin doesn't have a setting to ignore files. I've merged the
info.txt files that state where each test image came from into one file and
put a license header in it. XPM/XBM/PAM/PGM are text-based images, so it
may not be possible to comment them.
src/main/resources/org/apache/commons/imaging/formats/xpm/rgb.txt is not
our file - it's an MIT licensed file from the X.org project as stated in
LICENSE.txt, so should we put an MIT header in it?


> - On the "References" page, all the links to Geocities are broken. Either
> remove the broken links or link to the internet archive wayback machine or
> similar.
>

Done.


> - Is the to-do list on the site 100% accurate?
> https://people.apache.org/~damjan/imaging-1.0-RC5/todo.html
>

Fixed it up.


> - I would also change the title of the page from "To Do" to "Roadmap" and
> talk about the upcoming 2.0 plan how 1.0 relates to 0.97 (new package).
>

It's "Roadmap" now.


> - We need a "Migrating from 0.97 to 1.0" and "Plans for 2.0" sections, IMO.
>

Judging by the bug reports, almost everyone is using 1.0-SNAPSHOT. Version
0.97 is a pre-release incubator version, and there's already documentation
about the transition in RELEASE-NOTES.txt and in the "History" page.


> - For the page "Project Status and History", I would just call it
> "History". This page is missing versions.
>

I did. Added the 2 versions that were missing.


> - Javadoc: Most packages are missing a package-level description.
>

Added it for the main packages.


> - Findbugs reports
> org.apache.commons.imaging.icc.IccProfileParser.issRGB(ICC_Profile) has
> Boolean return type and returns explicit null BAD_PRACTICE (and others like
> it).
> For methods like
> org.apache.commons.imaging.icc.IccProfileParser.issRGB(ICC_Profile), it
> seems to complicate the code a lot more to return a Boolean instead of a
> boolean.
> We should consider changing these APIs to boolean. I've only looks at
> IccProfileParser.issRGB
> and this one case seems OK for change.
>

The problem was that issRGB had failure states, such as when the input is
null, or when an exception gets thrown (it swallows them all), for which it
returns null. But I've made it return boolean and throw exceptions instead.


> - Checkstyle: We have a lot of 'Useless parentheses', the few I've checked
> seem like they should be removed. This is a lot of work to check one at a
> time and I do not think we should remove them all automatically (like
> Eclipse can do) unless the person most familiar with the code chooses to do
> so.
>

I am not sure which parentheses you mean, the () around expressions, or the
{} around statements. Which Checkstyle settings are you using?


> - I'm not a fan of using interfaces (instead of classes) to define
> constants, but if this in fact the style we're going forward with, we
> should not redundantly define each constant as public, a fact that is
> implied by being an interface member (and which Checkstyle complains
> about.)
>

The problem is that there are endless TIFF tags, so they're convenient to
split up into separate classes when implementing, but then difficult for
the user to find the right one. So they've been merged into AllTagConstants
by multi-inheritance, something classes cannot do. But I've deleted public
static final at least, and converted XyzConstants to classes in other
packages.


> - Findbugs: WRT byte arrays and "malicious code", it seems safe to ignore
> these since we are working with bytes all the time. I'm not sure if it is
> worth Javadoc'ing this intention or adding some kinds of comment in the
> source Findbugs can use to avoid these warnings. It's probably NOT worth
> doing, but I thought I'd mention it.
>

There is no source comment. Findbugs can use a filter to not examine
certain files/classes/methods, but I am not a fan - that filter could hide
other bugs in the future.


> Tested with:
>
> Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
> 11:22:22-0400)
> Maven home: C:\Java\apache-maven-3.1.1\bin\..
> Java version: 1.7.0_45, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_45\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>
> Gary
>
>
Damjan


>
> On Fri, Nov 1, 2013 at 7:57 AM, Damjan Jovanovic <[hidden email]>
> wrote:
>
> > Please vote on releasing commons-imaging 1.0 from RC5.
> >
> > RC4 and its problems and their fixes were in this thread:
> >
> >
> http://mail-archives.apache.org/mod_mbox/commons-dev/201209.mbox/%3CCAJm2B-nbnbJwNUKkAtapZuzT5jfFODsk1aXcdsUUeoC%2BxXrDKg%40mail.gmail.com%3E
> > There were also many recent discussions on the development list.
> >
> > Imaging 1.0 RC5 is available here:
> > https://dist.apache.org/repos/dist/dev/commons/imaging/ (SVN revision
> > 3391)
> >
> > Maven artifacts:
> >
> >
> https://repository.apache.org/content/repositories/staging/org/apache/commons/commons-
> > imaging/
> >
> > Change log(s):
> > https://dist.apache.org/repos/dist/dev/commons/imaging/RELEASE-NOTES.txt
> > http://people.apache.org/~damjan/imaging-1.0-RC5/changes-report.html
> > http://people.apache.org/~damjan/imaging-1.0-RC5/jira-report.html
> >
> > Tag:
> >
> >
> https://svn.apache.org/repos/asf/commons/proper/imaging/tags/IMAGING_1_0_RC5
> > <
> >
> https://svn.apache.org/repos/asf/commons/proper/imaging/tags/IMAGING_1_0_RC4
> > >(SVN
> > revision 1537825)
> >
> > Site:
> > http://people.apache.org/~damjan/imaging-1.0-RC5/<
> > http://people.apache.org/%7Edamjan/imaging-1.0rc4/>
> >
> > I have tested it with OpenJDK 6 on FreeBSD 9.1.
> >
> > Please review and vote. This vote will close no sooner than 72 hours from
> > now, on Monday 4 November 2013 at 12:00 GMT.
> >
> > [ ] +1 Release these artifacts
> > [ ] +0 OK, but...
> > [ ] -0 OK, but really should fix...
> > [ ] -1 I oppose this release because...
> >
> > Thank you!
> >
> > Damjan Jovanovic
> >
>
>
>
> --
> E-Mail: [hidden email] | [hidden email]
> Java Persistence with Hibernate, Second Edition<
> http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Imaging 1.0 from RC5

Andreas Lehmkuehler
Am 06.11.2013 19:14, schrieb Damjan Jovanovic:

> On Fri, Nov 1, 2013 at 8:24 PM, Gary Gregory <[hidden email]> wrote:
>
>> Thank you Damjan for cutting another release!
>>
>> In the future, please summarize changes from RC to RC in the VOTE email.
>> The link to the VOTE thread is too much of a hunt to understand what's
>> changed. I might as well look at SVN.
>>
>> I admire Damjan's persistence and patience in seeing through another RC
>> toward 1.0 :)
>>
>
> Thank you :).
>
>
>> [X] -0 OK, but really should fix...
>>
>> - The RAT report shows "40 Unknown Licenses", either add license headers or
>> get RAT to ignore these files.
>>
>
> RAT's Maven plugin doesn't have a setting to ignore files. I've merged the
That's not correct. Add something like the following to the pluginManagement section

<plugin>
        <groupId>org.apache.rat</groupId>
        <artifactId>apache-rat-plugin</artifactId>
        <version>0.6</version>
        <configuration>
                <excludes>
                        <exclude>src/test/data/**</exclude>
                </excludes>
        </configuration>
</plugin>

We are using it within PDFBox, see [1] for fruther details.

Thanks for the effort!

BR
Andreas Lehmkühler
[1] http://svn.apache.org/viewvc/pdfbox/trunk/parent/pom.xml?view=markup

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Imaging 1.0 from RC5

sebb-2-2
On 6 November 2013 21:25, Andreas Lehmkuehler <[hidden email]> wrote:

> Am 06.11.2013 19:14, schrieb Damjan Jovanovic:
>
>> On Fri, Nov 1, 2013 at 8:24 PM, Gary Gregory <[hidden email]>
>> wrote:
>>
>>> Thank you Damjan for cutting another release!
>>>
>>> In the future, please summarize changes from RC to RC in the VOTE email.
>>> The link to the VOTE thread is too much of a hunt to understand what's
>>> changed. I might as well look at SVN.
>>>
>>> I admire Damjan's persistence and patience in seeing through another RC
>>> toward 1.0 :)
>>>
>>
>> Thank you :).
>>
>>
>>> [X] -0 OK, but really should fix...
>>>
>>> - The RAT report shows "40 Unknown Licenses", either add license headers
>>> or
>>> get RAT to ignore these files.
>>>
>>
>> RAT's Maven plugin doesn't have a setting to ignore files. I've merged the
>
> That's not correct. Add something like the following to the pluginManagement
> section
>
> <plugin>
>         <groupId>org.apache.rat</groupId>
>         <artifactId>apache-rat-plugin</artifactId>
>         <version>0.6</version>

That is extremely old. Please use 0.10 instead.

>         <configuration>
>                 <excludes>
>                         <exclude>src/test/data/**</exclude>
>                 </excludes>
>         </configuration>
> </plugin>
>
> We are using it within PDFBox, see [1] for fruther details.
>
> Thanks for the effort!
>
> BR
> Andreas Lehmkühler
> [1] http://svn.apache.org/viewvc/pdfbox/trunk/parent/pom.xml?view=markup
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]