[VOTE] Release Validator 1.5.1 based on RC2

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Validator 1.5.1 based on RC2

sebb-2-2
Second try:

Validator 1.5.1 RC2 is available for review here:

https://dist.apache.org/repos/dist/dev/commons/validator/1.5.1_RC2/
(revision 13418)

commons-validator-1.5.1-bin.tar.gz.sha1:33a6ffa9b1e9eaa151912312a5ae3df6e996e06f
commons-validator-1.5.1-bin.zip.sha1:ffa68a2768c4edea00d16ac1f0481c5852aaff05
commons-validator-1.5.1-src.tar.gz.sha1:48e1cd7504ca2987e403948f46b6c46f136b0ccf
commons-validator-1.5.1-src.zip.sha1:706ffb941c4f31057d9a4d24e857e07498f971be

  Maven artifacts are here:
    https://repository.apache.org/content/repositories/orgapachecommons-1155/commons-validator/commons-validator/1.5.1/

These are the artifacts and their hashes

commons-validator-1.5.1-test-sources.jar
(SHA1: 41fa99c63b3ff4a65acf3324e9722591e2c7175c)
commons-validator-1.5.1-sources.jar
(SHA1: 1779e91e01dc506f388c350a8684f77c43943a08)
commons-validator-1.5.1.pom
(SHA1: ab12dc49a49d3ac67bcb949834cb2eed4ed26554)
commons-validator-1.5.1.jar
(SHA1: 86d05a46e8f064b300657f751b5a98c62807e2a0)
commons-validator-1.5.1-javadoc.jar
(SHA1: 1c5fbdeb20a211050d91366eb1a33d6b8adb3323)
commons-validator-1.5.1-tests.jar
(SHA1: 52f05bf0e7b66194e4fd99d9e10692e68fd16450)

  Details of changes since 1.5.0 are in the release notes:
    https://dist.apache.org/repos/dist/dev/commons/validator/1.5.1_RC2/RELEASE-NOTES.txt
    http://home.apache.org/~sebb/validator-1.5.1-RC2/changes-report.html


  The tag is here:
    http://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_5_1_RC2/
    (revision 1740857)

  Site:
    http://home.apache.org/~sebb/validator-1.5.1-RC2/

   (some *relative* links are broken - these will be OK once the site
is deployed)

  Clirr Report (compared to 1.5.0):
    http://home.apache.org/~sebb/validator-1.5.1-RC2/clirr-report.html

  RAT Report:
    http://home.apache.org/~sebb/validator-1.5.1-RC2/rat-report.html

  KEYS:
  https://www.apache.org/dist/commons/KEYS

  Please review the release candidate and vote.

  This vote will close no sooner than 72 hours from now,
  i.e. sometime after 22:00 GMT 28 Apr 2016


  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

  Thanks!

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Validator 1.5.1 based on RC2

sebb-2-2
On 25 April 2016 at 22:24, sebb <[hidden email]> wrote:

> Second try:
>
> Validator 1.5.1 RC2 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.5.1_RC2/
> (revision 13418)
>
> commons-validator-1.5.1-bin.tar.gz.sha1:33a6ffa9b1e9eaa151912312a5ae3df6e996e06f
> commons-validator-1.5.1-bin.zip.sha1:ffa68a2768c4edea00d16ac1f0481c5852aaff05
> commons-validator-1.5.1-src.tar.gz.sha1:48e1cd7504ca2987e403948f46b6c46f136b0ccf
> commons-validator-1.5.1-src.zip.sha1:706ffb941c4f31057d9a4d24e857e07498f971be
>
>   Maven artifacts are here:
>     https://repository.apache.org/content/repositories/orgapachecommons-1155/commons-validator/commons-validator/1.5.1/
>
> These are the artifacts and their hashes
>
> commons-validator-1.5.1-test-sources.jar
> (SHA1: 41fa99c63b3ff4a65acf3324e9722591e2c7175c)
> commons-validator-1.5.1-sources.jar
> (SHA1: 1779e91e01dc506f388c350a8684f77c43943a08)
> commons-validator-1.5.1.pom
> (SHA1: ab12dc49a49d3ac67bcb949834cb2eed4ed26554)
> commons-validator-1.5.1.jar
> (SHA1: 86d05a46e8f064b300657f751b5a98c62807e2a0)
> commons-validator-1.5.1-javadoc.jar
> (SHA1: 1c5fbdeb20a211050d91366eb1a33d6b8adb3323)
> commons-validator-1.5.1-tests.jar
> (SHA1: 52f05bf0e7b66194e4fd99d9e10692e68fd16450)
>
>   Details of changes since 1.5.0 are in the release notes:
>     https://dist.apache.org/repos/dist/dev/commons/validator/1.5.1_RC2/RELEASE-NOTES.txt
>     http://home.apache.org/~sebb/validator-1.5.1-RC2/changes-report.html
>
>
>   The tag is here:
>     http://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_5_1_RC2/
>     (revision 1740857)
>
>   Site:
>     http://home.apache.org/~sebb/validator-1.5.1-RC2/
>
>    (some *relative* links are broken - these will be OK once the site
> is deployed)
>
>   Clirr Report (compared to 1.5.0):
>     http://home.apache.org/~sebb/validator-1.5.1-RC2/clirr-report.html
>
>   RAT Report:
>     http://home.apache.org/~sebb/validator-1.5.1-RC2/rat-report.html
>
>   KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
>   Please review the release candidate and vote.
>
>   This vote will close no sooner than 72 hours from now,
>   i.e. sometime after 22:00 GMT 28 Apr 2016
>

PROPOSAL.html is missing from the source archives.
However it is not needed for building/testing and is only of
historical interest.
It could probably be removed from SVN now.

Here's my formal vote:

>   [X] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
>   Thanks!

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Validator 1.5.1 based on RC2

Emmanuel Bourg-3
In reply to this post by sebb-2-2
Le 25/04/2016 à 23:24, sebb a écrit :

>   [X] +1 Release these artifacts

Tested on Debian with Maven 3.3.9 and OpenJDK 8. Builds fine from the
tag and from the source archive. The changes look good.

Emmanuel Bourg



signature.asc (851 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Validator 1.5.1 based on RC2

garydgregory
In reply to this post by sebb-2-2
Note a blocker: Missing text in @link:

* Note: the {@link #isValid(String)} and {@link } methods strip off any
leading

+1

Release notes, MD5, SHA1, ASC, all OK.

Builds OK from src zip with the expected Slf4j report blow ups with:

Apache Maven *3.3.9* (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T08:41:47-08:00)
Maven home: E:\Java\apache-maven-3.3.9\bin\..
Java version: *1.8.0_91*, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_91\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"

Builds OK as above but with set MAVEN_OPTS=-Xmx2048m -XX:MaxPermSize=128m
in addition to avoid an OOME:

Apache Maven *3.3.9* (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T08:41:47-08:00)
Maven home: E:\Java\apache-maven-3.3.9\bin\..
Java version: *1.7.0_79*, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_79\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"

Builds OK with with set MAVEN_OPTS=-Xmx2048m -XX:MaxPermSize=128m:

Apache Maven *3.0.5* (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19
05:51:28-0800)
Maven home: E:\Java\apache-maven-3.0.5
Java version: *1.7.0_79*, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_79\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"

It builds but I get:

[INFO] Downloading from JIRA at:
http://issues.apache.org/jira/sr/jira.issueviews:searchrequest-xml/temp/SearchRequest.xml?tempMax=100&reset=true&jqlQuery=project+%3D+VALIDATOR+AND+status+in+
type+in+%28Bug%2C+%22New+Feature%22%2C+Task%2C+Improvement%2C+Wish%2C+Test%29+ORDER+BY+fixversion+DESC%2C+type+ASC%2C+key+DESC
[ERROR] Error downloading issues from JIRA. Cause is chunked stream ended
unexpectedly
[WARNING]
org.apache.maven.plugin.MojoExecutionException: Failed to parse JIRA XML.
        at org.apache.maven.plugin.jira.JiraXML.parse(JiraXML.java:132)
        at org.apache.maven.plugin.jira.JiraXML.parseXML(JiraXML.java:108)
        at
org.apache.maven.plugin.jira.ClassicJiraDownloader.getIssueList(ClassicJiraDownloader.java:458)
        at
org.apache.maven.plugin.jira.AdaptiveJiraDownloader.getIssueList(AdaptiveJiraDownloader.java:89)
        at
org.apache.maven.plugin.jira.JiraMojo.executeReport(JiraMojo.java:374)
        at
org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:255)
        at
org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument(ReportDocumentRenderer.java:224)
        at
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:311)
        at
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:129)
        at
org.apache.maven.plugins.site.render.SiteMojo.renderLocale(SiteMojo.java:182)
        at
org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:141)
        at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
        at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
        at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
        at
org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
        at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
Caused by: org.xml.sax.SAXParseException; lineNumber: 6998; columnNumber:
52; The element type "customfieldvalue" must be terminated by the matching
end-tag "</customfieldvalue>".
        at
org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown
Source)
        at org.apache.xerces.util.ErrorHandlerWrapper.fatalError(Unknown
Source)
        at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
Source)
        at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
Source)
        at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
Source)
        at org.apache.xerces.impl.XMLScanner.reportFatalError(Unknown
Source)
        at
org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanEndElement(Unknown
Source)
        at
org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
Source)
        at
org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown
Source)
        at org.apache.xerces.parsers.XML11Configuration.parse(Unknown
Source)
        at org.apache.xerces.parsers.XML11Configuration.parse(Unknown
Source)
        at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
        at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
        at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown
Source)
        at org.apache.xerces.jaxp.SAXParserImpl.parse(Unknown Source)
        at org.apache.maven.plugin.jira.JiraXML.parse(JiraXML.java:128)
        ... 31 more

I did not try Maven 3.2.5.

Gary


On Mon, Apr 25, 2016 at 2:24 PM, sebb <[hidden email]> wrote:

> Second try:
>
> Validator 1.5.1 RC2 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.5.1_RC2/
> (revision 13418)
>
>
> commons-validator-1.5.1-bin.tar.gz.sha1:33a6ffa9b1e9eaa151912312a5ae3df6e996e06f
>
> commons-validator-1.5.1-bin.zip.sha1:ffa68a2768c4edea00d16ac1f0481c5852aaff05
>
> commons-validator-1.5.1-src.tar.gz.sha1:48e1cd7504ca2987e403948f46b6c46f136b0ccf
>
> commons-validator-1.5.1-src.zip.sha1:706ffb941c4f31057d9a4d24e857e07498f971be
>
>   Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1155/commons-validator/commons-validator/1.5.1/
>
> These are the artifacts and their hashes
>
> commons-validator-1.5.1-test-sources.jar
> (SHA1: 41fa99c63b3ff4a65acf3324e9722591e2c7175c)
> commons-validator-1.5.1-sources.jar
> (SHA1: 1779e91e01dc506f388c350a8684f77c43943a08)
> commons-validator-1.5.1.pom
> (SHA1: ab12dc49a49d3ac67bcb949834cb2eed4ed26554)
> commons-validator-1.5.1.jar
> (SHA1: 86d05a46e8f064b300657f751b5a98c62807e2a0)
> commons-validator-1.5.1-javadoc.jar
> (SHA1: 1c5fbdeb20a211050d91366eb1a33d6b8adb3323)
> commons-validator-1.5.1-tests.jar
> (SHA1: 52f05bf0e7b66194e4fd99d9e10692e68fd16450)
>
>   Details of changes since 1.5.0 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.5.1_RC2/RELEASE-NOTES.txt
>     http://home.apache.org/~sebb/validator-1.5.1-RC2/changes-report.html
>
>
>   The tag is here:
>
> http://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_5_1_RC2/
>     (revision 1740857)
>
>   Site:
>     http://home.apache.org/~sebb/validator-1.5.1-RC2/
>
>    (some *relative* links are broken - these will be OK once the site
> is deployed)
>
>   Clirr Report (compared to 1.5.0):
>     http://home.apache.org/~sebb/validator-1.5.1-RC2/clirr-report.html
>
>   RAT Report:
>     http://home.apache.org/~sebb/validator-1.5.1-RC2/rat-report.html
>
>   KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
>   Please review the release candidate and vote.
>
>   This vote will close no sooner than 72 hours from now,
>   i.e. sometime after 22:00 GMT 28 Apr 2016
>
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
>   Thanks!
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Validator 1.5.1 based on RC2

sebb-2-2
On 28 April 2016 at 18:34, Gary Gregory <[hidden email]> wrote:
> Note a blocker: Missing text in @link:

I assume you mean "Not a blocker" above?

> * Note: the {@link #isValid(String)} and {@link } methods strip off any
> leading
>
> +1
>
> Release notes, MD5, SHA1, ASC, all OK.
>
> Builds OK from src zip with the expected Slf4j report blow ups with:
>
> Apache Maven *3.3.9* (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T08:41:47-08:00)
> Maven home: E:\Java\apache-maven-3.3.9\bin\..
> Java version: *1.8.0_91*, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_91\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
>
> Builds OK as above but with set MAVEN_OPTS=-Xmx2048m -XX:MaxPermSize=128m
> in addition to avoid an OOME:
>
> Apache Maven *3.3.9* (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T08:41:47-08:00)
> Maven home: E:\Java\apache-maven-3.3.9\bin\..
> Java version: *1.7.0_79*, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_79\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>
> Builds OK with with set MAVEN_OPTS=-Xmx2048m -XX:MaxPermSize=128m:
>
> Apache Maven *3.0.5* (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19
> 05:51:28-0800)
> Maven home: E:\Java\apache-maven-3.0.5
> Java version: *1.7.0_79*, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_79\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>
> It builds but I get:

What was the Maven command-line here?

> [INFO] Downloading from JIRA at:
> http://issues.apache.org/jira/sr/jira.issueviews:searchrequest-xml/temp/SearchRequest.xml?tempMax=100&reset=true&jqlQuery=project+%3D+VALIDATOR+AND+status+in+
> type+in+%28Bug%2C+%22New+Feature%22%2C+Task%2C+Improvement%2C+Wish%2C+Test%29+ORDER+BY+fixversion+DESC%2C+type+ASC%2C+key+DESC
> [ERROR] Error downloading issues from JIRA. Cause is chunked stream ended
> unexpectedly
> [WARNING]

I think that's a Maven issue.
It can be noted in BUILDING.txt

> org.apache.maven.plugin.MojoExecutionException: Failed to parse JIRA XML.
>         at org.apache.maven.plugin.jira.JiraXML.parse(JiraXML.java:132)
>         at org.apache.maven.plugin.jira.JiraXML.parseXML(JiraXML.java:108)
>         at
> org.apache.maven.plugin.jira.ClassicJiraDownloader.getIssueList(ClassicJiraDownloader.java:458)
>         at
> org.apache.maven.plugin.jira.AdaptiveJiraDownloader.getIssueList(AdaptiveJiraDownloader.java:89)
>         at
> org.apache.maven.plugin.jira.JiraMojo.executeReport(JiraMojo.java:374)
>         at
> org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:255)
>         at
> org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument(ReportDocumentRenderer.java:224)
>         at
> org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:311)
>         at
> org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:129)
>         at
> org.apache.maven.plugins.site.render.SiteMojo.renderLocale(SiteMojo.java:182)
>         at
> org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:141)
>         at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
>         at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
>         at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>         at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>         at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
>         at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
>         at
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
>         at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
>         at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
>         at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
>         at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
>         at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
>         at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>         at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:606)
>         at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
>         at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
>         at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
>         at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: org.xml.sax.SAXParseException; lineNumber: 6998; columnNumber:
> 52; The element type "customfieldvalue" must be terminated by the matching
> end-tag "</customfieldvalue>".
>         at
> org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown
> Source)
>         at org.apache.xerces.util.ErrorHandlerWrapper.fatalError(Unknown
> Source)
>         at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
> Source)
>         at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
> Source)
>         at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
> Source)
>         at org.apache.xerces.impl.XMLScanner.reportFatalError(Unknown
> Source)
>         at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanEndElement(Unknown
> Source)
>         at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
> Source)
>         at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown
> Source)
>         at org.apache.xerces.parsers.XML11Configuration.parse(Unknown
> Source)
>         at org.apache.xerces.parsers.XML11Configuration.parse(Unknown
> Source)
>         at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
>         at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
>         at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown
> Source)
>         at org.apache.xerces.jaxp.SAXParserImpl.parse(Unknown Source)
>         at org.apache.maven.plugin.jira.JiraXML.parse(JiraXML.java:128)
>         ... 31 more
>
> I did not try Maven 3.2.5.
>
> Gary
>
>
> On Mon, Apr 25, 2016 at 2:24 PM, sebb <[hidden email]> wrote:
>
>> Second try:
>>
>> Validator 1.5.1 RC2 is available for review here:
>>
>> https://dist.apache.org/repos/dist/dev/commons/validator/1.5.1_RC2/
>> (revision 13418)
>>
>>
>> commons-validator-1.5.1-bin.tar.gz.sha1:33a6ffa9b1e9eaa151912312a5ae3df6e996e06f
>>
>> commons-validator-1.5.1-bin.zip.sha1:ffa68a2768c4edea00d16ac1f0481c5852aaff05
>>
>> commons-validator-1.5.1-src.tar.gz.sha1:48e1cd7504ca2987e403948f46b6c46f136b0ccf
>>
>> commons-validator-1.5.1-src.zip.sha1:706ffb941c4f31057d9a4d24e857e07498f971be
>>
>>   Maven artifacts are here:
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1155/commons-validator/commons-validator/1.5.1/
>>
>> These are the artifacts and their hashes
>>
>> commons-validator-1.5.1-test-sources.jar
>> (SHA1: 41fa99c63b3ff4a65acf3324e9722591e2c7175c)
>> commons-validator-1.5.1-sources.jar
>> (SHA1: 1779e91e01dc506f388c350a8684f77c43943a08)
>> commons-validator-1.5.1.pom
>> (SHA1: ab12dc49a49d3ac67bcb949834cb2eed4ed26554)
>> commons-validator-1.5.1.jar
>> (SHA1: 86d05a46e8f064b300657f751b5a98c62807e2a0)
>> commons-validator-1.5.1-javadoc.jar
>> (SHA1: 1c5fbdeb20a211050d91366eb1a33d6b8adb3323)
>> commons-validator-1.5.1-tests.jar
>> (SHA1: 52f05bf0e7b66194e4fd99d9e10692e68fd16450)
>>
>>   Details of changes since 1.5.0 are in the release notes:
>>
>> https://dist.apache.org/repos/dist/dev/commons/validator/1.5.1_RC2/RELEASE-NOTES.txt
>>     http://home.apache.org/~sebb/validator-1.5.1-RC2/changes-report.html
>>
>>
>>   The tag is here:
>>
>> http://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_5_1_RC2/
>>     (revision 1740857)
>>
>>   Site:
>>     http://home.apache.org/~sebb/validator-1.5.1-RC2/
>>
>>    (some *relative* links are broken - these will be OK once the site
>> is deployed)
>>
>>   Clirr Report (compared to 1.5.0):
>>     http://home.apache.org/~sebb/validator-1.5.1-RC2/clirr-report.html
>>
>>   RAT Report:
>>     http://home.apache.org/~sebb/validator-1.5.1-RC2/rat-report.html
>>
>>   KEYS:
>>   https://www.apache.org/dist/commons/KEYS
>>
>>   Please review the release candidate and vote.
>>
>>   This vote will close no sooner than 72 hours from now,
>>   i.e. sometime after 22:00 GMT 28 Apr 2016
>>
>>
>>   [ ] +1 Release these artifacts
>>   [ ] +0 OK, but...
>>   [ ] -0 OK, but really should fix...
>>   [ ] -1 I oppose this release because...
>>
>>   Thanks!
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>
>
> --
> E-Mail: [hidden email] | [hidden email]
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Validator 1.5.1 based on RC2

garydgregory
On Apr 29, 2016 2:38 AM, "sebb" <[hidden email]> wrote:
>
> On 28 April 2016 at 18:34, Gary Gregory <[hidden email]> wrote:
> > Note a blocker: Missing text in @link:
>
> I assume you mean "Not a blocker" above?

Yes, not a blocker.

>
> > * Note: the {@link #isValid(String)} and {@link } methods strip off any
> > leading
> >
> > +1
> >
> > Release notes, MD5, SHA1, ASC, all OK.
> >
> > Builds OK from src zip with the expected Slf4j report blow ups with:
> >
> > Apache Maven *3.3.9* (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> > 2015-11-10T08:41:47-08:00)
> > Maven home: E:\Java\apache-maven-3.3.9\bin\..
> > Java version: *1.8.0_91*, vendor: Oracle Corporation
> > Java home: C:\Program Files\Java\jdk1.8.0_91\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
> >
> > Builds OK as above but with set MAVEN_OPTS=-Xmx2048m
-XX:MaxPermSize=128m

> > in addition to avoid an OOME:
> >
> > Apache Maven *3.3.9* (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> > 2015-11-10T08:41:47-08:00)
> > Maven home: E:\Java\apache-maven-3.3.9\bin\..
> > Java version: *1.7.0_79*, vendor: Oracle Corporation
> > Java home: C:\Program Files\Java\jdk1.7.0_79\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> >
> > Builds OK with with set MAVEN_OPTS=-Xmx2048m -XX:MaxPermSize=128m:
> >
> > Apache Maven *3.0.5* (r01de14724cdef164cd33c7c8c2fe155faf9602da;
2013-02-19

> > 05:51:28-0800)
> > Maven home: E:\Java\apache-maven-3.0.5
> > Java version: *1.7.0_79*, vendor: Oracle Corporation
> > Java home: C:\Program Files\Java\jdk1.7.0_79\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> >
> > It builds but I get:
>
> What was the Maven command-line here?

IIRC: mvn clean site

Gary
>
> > [INFO] Downloading from JIRA at:
> >
http://issues.apache.org/jira/sr/jira.issueviews:searchrequest-xml/temp/SearchRequest.xml?tempMax=100&reset=true&jqlQuery=project+%3D+VALIDATOR+AND+status+in+
> >
type+in+%28Bug%2C+%22New+Feature%22%2C+Task%2C+Improvement%2C+Wish%2C+Test%29+ORDER+BY+fixversion+DESC%2C+type+ASC%2C+key+DESC
> > [ERROR] Error downloading issues from JIRA. Cause is chunked stream
ended
> > unexpectedly
> > [WARNING]
>
> I think that's a Maven issue.
> It can be noted in BUILDING.txt
>
> > org.apache.maven.plugin.MojoExecutionException: Failed to parse JIRA
XML.
> >         at org.apache.maven.plugin.jira.JiraXML.parse(JiraXML.java:132)
> >         at
org.apache.maven.plugin.jira.JiraXML.parseXML(JiraXML.java:108)
> >         at
> >
org.apache.maven.plugin.jira.ClassicJiraDownloader.getIssueList(ClassicJiraDownloader.java:458)
> >         at
> >
org.apache.maven.plugin.jira.AdaptiveJiraDownloader.getIssueList(AdaptiveJiraDownloader.java:89)
> >         at
> > org.apache.maven.plugin.jira.JiraMojo.executeReport(JiraMojo.java:374)
> >         at
> >
org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:255)
> >         at
> >
org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument(ReportDocumentRenderer.java:224)
> >         at
> >
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:311)
> >         at
> >
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:129)
> >         at
> >
org.apache.maven.plugins.site.render.SiteMojo.renderLocale(SiteMojo.java:182)
> >         at
> > org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:141)
> >         at
> >
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
> >         at
> >
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
> >         at
> >
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> >         at
> >
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> >         at
> >
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
> >         at
> >
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
> >         at
> >
org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
> >         at
> >
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
> >         at
org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
> >         at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
> >         at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
> >         at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
> >         at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
> >         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> >         at
> >
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> >         at
> >
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> >         at java.lang.reflect.Method.invoke(Method.java:606)
> >         at
> >
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
> >         at
> >
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
> >         at
> >
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
> >         at
> >
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> > Caused by: org.xml.sax.SAXParseException; lineNumber: 6998;
columnNumber:
> > 52; The element type "customfieldvalue" must be terminated by the
matching
> > end-tag "</customfieldvalue>".
> >         at
> >
org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown

> > Source)
> >         at org.apache.xerces.util.ErrorHandlerWrapper.fatalError(Unknown
> > Source)
> >         at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
> > Source)
> >         at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
> > Source)
> >         at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
> > Source)
> >         at org.apache.xerces.impl.XMLScanner.reportFatalError(Unknown
> > Source)
> >         at
> >
org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanEndElement(Unknown
> > Source)
> >         at
> >
org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
> > Source)
> >         at
> >
org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown
> > Source)
> >         at org.apache.xerces.parsers.XML11Configuration.parse(Unknown
> > Source)
> >         at org.apache.xerces.parsers.XML11Configuration.parse(Unknown
> > Source)
> >         at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
> >         at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown
Source)
> >         at
org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown

> > Source)
> >         at org.apache.xerces.jaxp.SAXParserImpl.parse(Unknown Source)
> >         at org.apache.maven.plugin.jira.JiraXML.parse(JiraXML.java:128)
> >         ... 31 more
> >
> > I did not try Maven 3.2.5.
> >
> > Gary
> >
> >
> > On Mon, Apr 25, 2016 at 2:24 PM, sebb <[hidden email]> wrote:
> >
> >> Second try:
> >>
> >> Validator 1.5.1 RC2 is available for review here:
> >>
> >> https://dist.apache.org/repos/dist/dev/commons/validator/1.5.1_RC2/
> >> (revision 13418)
> >>
> >>
> >>
commons-validator-1.5.1-bin.tar.gz.sha1:33a6ffa9b1e9eaa151912312a5ae3df6e996e06f
> >>
> >>
commons-validator-1.5.1-bin.zip.sha1:ffa68a2768c4edea00d16ac1f0481c5852aaff05
> >>
> >>
commons-validator-1.5.1-src.tar.gz.sha1:48e1cd7504ca2987e403948f46b6c46f136b0ccf
> >>
> >>
commons-validator-1.5.1-src.zip.sha1:706ffb941c4f31057d9a4d24e857e07498f971be
> >>
> >>   Maven artifacts are here:
> >>
> >>
https://repository.apache.org/content/repositories/orgapachecommons-1155/commons-validator/commons-validator/1.5.1/

> >>
> >> These are the artifacts and their hashes
> >>
> >> commons-validator-1.5.1-test-sources.jar
> >> (SHA1: 41fa99c63b3ff4a65acf3324e9722591e2c7175c)
> >> commons-validator-1.5.1-sources.jar
> >> (SHA1: 1779e91e01dc506f388c350a8684f77c43943a08)
> >> commons-validator-1.5.1.pom
> >> (SHA1: ab12dc49a49d3ac67bcb949834cb2eed4ed26554)
> >> commons-validator-1.5.1.jar
> >> (SHA1: 86d05a46e8f064b300657f751b5a98c62807e2a0)
> >> commons-validator-1.5.1-javadoc.jar
> >> (SHA1: 1c5fbdeb20a211050d91366eb1a33d6b8adb3323)
> >> commons-validator-1.5.1-tests.jar
> >> (SHA1: 52f05bf0e7b66194e4fd99d9e10692e68fd16450)
> >>
> >>   Details of changes since 1.5.0 are in the release notes:
> >>
> >>
https://dist.apache.org/repos/dist/dev/commons/validator/1.5.1_RC2/RELEASE-NOTES.txt
> >>
http://home.apache.org/~sebb/validator-1.5.1-RC2/changes-report.html
> >>
> >>
> >>   The tag is here:
> >>
> >>
http://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_5_1_RC2/

> >>     (revision 1740857)
> >>
> >>   Site:
> >>     http://home.apache.org/~sebb/validator-1.5.1-RC2/
> >>
> >>    (some *relative* links are broken - these will be OK once the site
> >> is deployed)
> >>
> >>   Clirr Report (compared to 1.5.0):
> >>     http://home.apache.org/~sebb/validator-1.5.1-RC2/clirr-report.html
> >>
> >>   RAT Report:
> >>     http://home.apache.org/~sebb/validator-1.5.1-RC2/rat-report.html
> >>
> >>   KEYS:
> >>   https://www.apache.org/dist/commons/KEYS
> >>
> >>   Please review the release candidate and vote.
> >>
> >>   This vote will close no sooner than 72 hours from now,
> >>   i.e. sometime after 22:00 GMT 28 Apr 2016
> >>
> >>
> >>   [ ] +1 Release these artifacts
> >>   [ ] +0 OK, but...
> >>   [ ] -0 OK, but really should fix...
> >>   [ ] -1 I oppose this release because...
> >>
> >>   Thanks!
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
> >>
> >
> >
> > --
> > E-Mail: [hidden email] | [hidden email]
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Validator 1.5.1 based on RC2

Jörg Schaible
In reply to this post by sebb-2-2
+1

Built from source using tarball with my complete compiler zoo.

However, tests fail for JDK 9 (tested even with latest from today):

===================== %< ================
Failed tests:
  CalendarValidatorTest.testDateTimeStyle:197 validate(A) default
  CalendarValidatorTest.testFormat:215 default expected:<31/12/[]05> but
was:<31/12/[20]05>
  CurrencyValidatorTest.testIntegerValid:142 US negative expected:<-1234.00>
but was:<null>
  CurrencyValidatorTest.testInvalid:121 US wrong negative
  CurrencyValidatorTest.testValid:93 US negative expected:<-1234.56> but
was:<null>
  DateValidatorTest.testDateValidatorMethods:69 validate(A) both
expected:<Sat Dec 31 00:00:00 GMT 2005> but was:<null>
  TimeValidatorTest.testLocaleValid:157 compare 0 value=[23:59] failed  
expected:<Thu Jan 01 22:59:00 GMT 1970> but was:<Thu Jan 01 23:59:00 GMT
1970>
  TimeValidatorTest.testPatternValid:131 compare 0 value=[23-59-59] failed  
expected:<Thu Jan 01 22:59:59 GMT 1970> but was:<Thu Jan 01 23:59:59 GMT
1970>
  TimeValidatorTest.testTimeZone:219 pattern result
Tests in error:
  CalendarValidatorTest.testCalendarValidatorMethods:70 NullPointer
===================== %< ================

Not critical for this release, but a heads-up.

Cheers,
Jörg


sebb wrote:

> Second try:
>
> Validator 1.5.1 RC2 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.5.1_RC2/
> (revision 13418)
>
> commons-validator-1.5.1-
bin.tar.gz.sha1:33a6ffa9b1e9eaa151912312a5ae3df6e996e06f
> commons-validator-1.5.1-
bin.zip.sha1:ffa68a2768c4edea00d16ac1f0481c5852aaff05
> commons-validator-1.5.1-
src.tar.gz.sha1:48e1cd7504ca2987e403948f46b6c46f136b0ccf
> commons-validator-1.5.1-
src.zip.sha1:706ffb941c4f31057d9a4d24e857e07498f971be
>
>   Maven artifacts are here:
>    
https://repository.apache.org/content/repositories/orgapachecommons-1155/commons-validator/commons-validator/1.5.1/

>
> These are the artifacts and their hashes
>
> commons-validator-1.5.1-test-sources.jar
> (SHA1: 41fa99c63b3ff4a65acf3324e9722591e2c7175c)
> commons-validator-1.5.1-sources.jar
> (SHA1: 1779e91e01dc506f388c350a8684f77c43943a08)
> commons-validator-1.5.1.pom
> (SHA1: ab12dc49a49d3ac67bcb949834cb2eed4ed26554)
> commons-validator-1.5.1.jar
> (SHA1: 86d05a46e8f064b300657f751b5a98c62807e2a0)
> commons-validator-1.5.1-javadoc.jar
> (SHA1: 1c5fbdeb20a211050d91366eb1a33d6b8adb3323)
> commons-validator-1.5.1-tests.jar
> (SHA1: 52f05bf0e7b66194e4fd99d9e10692e68fd16450)
>
>   Details of changes since 1.5.0 are in the release notes:
>    
https://dist.apache.org/repos/dist/dev/commons/validator/1.5.1_RC2/RELEASE-NOTES.txt
>     http://home.apache.org/~sebb/validator-1.5.1-RC2/changes-report.html
>
>
>   The tag is here:
>    
http://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_5_1_RC2/

>     (revision 1740857)
>
>   Site:
>     http://home.apache.org/~sebb/validator-1.5.1-RC2/
>
>    (some *relative* links are broken - these will be OK once the site
> is deployed)
>
>   Clirr Report (compared to 1.5.0):
>     http://home.apache.org/~sebb/validator-1.5.1-RC2/clirr-report.html
>
>   RAT Report:
>     http://home.apache.org/~sebb/validator-1.5.1-RC2/rat-report.html
>
>   KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
>   Please review the release candidate and vote.
>
>   This vote will close no sooner than 72 hours from now,
>   i.e. sometime after 22:00 GMT 28 Apr 2016
>
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
>   Thanks!



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]