[VOTE] Release pool 2.4 based on RC1

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release pool 2.4 based on RC1

Phil Steitz
This is a vote to release version 2.4 of Apache Commons Pool based
on RC1.

Here is the release candidate:
https://dist.apache.org/repos/dist/dev/commons/pool/
(r9083)

Built from:
https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_4_RC1/
(r1680963)

Release notes:
https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt

Maven artifacts:
http://s.apache.org/Va6

site:
http://people.apache.org/~psteitz/pool/pool-2.4-rc1

keys:

https://www.apache.org/dist/commons/KEYS

Votes, please.

This vote will close no sooner that 72 hours from now (15:50 GMT
25-May-2015).

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thanks!

Phil



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release pool 2.4 based on RC1

Bruno P. Kinoshita
Build works fine in

Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-15T06:29:23+13:00)
Maven home: /opt/apache-maven-3.2.5
Java version: 1.8.0_45, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.16.0-38-generic", arch: "amd64", family: "unix"
Rat reports 1 binary, against 2 binaries from the previous web site. I think it is because the previous version included site.tgz in the report. One new error in checkstyle, but that doesn't seem relevant.
This version introduces five errors in FindBugs, all related to the same type [1]

I've changed locally a part of the code reported by FindBugs (GenericKeyedObjectPool L755). From
        for (K k : poolMap.keySet()) {
            ObjectDeque<T> queue = poolMap.get(k);
To

        for (Map.Entry<K, ObjectDeque<T>> entry : poolMap.entrySet()) {
            ObjectDeque<T> queue = entry.getValue();
Running the build again, all tests pass and the FindBugs error is gone. But I'm not sure if it wasn't intentional to avoid stale reads from the map.
Could anyone confirm if the errors reported by FindBugs can be ignored, please?
Thanks!Bruno

http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR

 
      From: Phil Steitz <[hidden email]>
 To: Commons Developers List <[hidden email]>
 Sent: Saturday, May 23, 2015 3:51 AM
 Subject: [VOTE] Release pool 2.4 based on RC1
   
This is a vote to release version 2.4 of Apache Commons Pool based
on RC1.

Here is the release candidate:
https://dist.apache.org/repos/dist/dev/commons/pool/
(r9083)

Built from:
https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_4_RC1/
(r1680963)

Release notes:
https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt

Maven artifacts:
http://s.apache.org/Va6

site:
http://people.apache.org/~psteitz/pool/pool-2.4-rc1

keys:

https://www.apache.org/dist/commons/KEYS

Votes, please.

This vote will close no sooner that 72 hours from now (15:50 GMT
25-May-2015).

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thanks!

Phil



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]


   
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release pool 2.4 based on RC1

Phil Steitz
On 5/22/15 8:10 PM, Bruno P. Kinoshita wrote:

> Build works fine in
>
> Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-15T06:29:23+13:00)
> Maven home: /opt/apache-maven-3.2.5
> Java version: 1.8.0_45, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-8-oracle/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.16.0-38-generic", arch: "amd64", family: "unix"
> Rat reports 1 binary, against 2 binaries from the previous web site. I think it is because the previous version included site.tgz in the report. One new error in checkstyle, but that doesn't seem relevant.
> This version introduces five errors in FindBugs, all related to the same type [1]
>
> I've changed locally a part of the code reported by FindBugs (GenericKeyedObjectPool L755). From
>         for (K k : poolMap.keySet()) {
>             ObjectDeque<T> queue = poolMap.get(k);
> To
>
>         for (Map.Entry<K, ObjectDeque<T>> entry : poolMap.entrySet()) {
>             ObjectDeque<T> queue = entry.getValue();
> Running the build again, all tests pass and the FindBugs error is gone. But I'm not sure if it wasn't intentional to avoid stale reads from the map.
> Could anyone confirm if the errors reported by FindBugs can be ignored, please?

Yes, "fixing" this would be a bad idea.  It is a false positive.  If
there is another RC, I will add a suppression filter for this "bug"
that must be due to findbugs version upgrade.  Otherwise, this can
be added post-release as part of the site update.

Thanks for the review!

Phil

> Thanks!Bruno
>
> http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR
>
>  
>       From: Phil Steitz <[hidden email]>
>  To: Commons Developers List <[hidden email]>
>  Sent: Saturday, May 23, 2015 3:51 AM
>  Subject: [VOTE] Release pool 2.4 based on RC1
>    
> This is a vote to release version 2.4 of Apache Commons Pool based
> on RC1.
>
> Here is the release candidate:
> https://dist.apache.org/repos/dist/dev/commons/pool/
> (r9083)
>
> Built from:
> https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_4_RC1/
> (r1680963)
>
> Release notes:
> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>
> Maven artifacts:
> http://s.apache.org/Va6
>
> site:
> http://people.apache.org/~psteitz/pool/pool-2.4-rc1
>
> keys:
>
> https://www.apache.org/dist/commons/KEYS
>
> Votes, please.
>
> This vote will close no sooner that 72 hours from now (15:50 GMT
> 25-May-2015).
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
>    
>



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release pool 2.4 based on RC1

Bruno P. Kinoshita
Thanks for clarifying Phil!
 [ X ] +1 Release these artifacts (not binding)
Bruno

 
      From: Phil Steitz <[hidden email]>
 To: Commons Developers List <[hidden email]>
 Sent: Saturday, May 23, 2015 4:22 PM
 Subject: Re: [VOTE] Release pool 2.4 based on RC1
   
On 5/22/15 8:10 PM, Bruno P. Kinoshita wrote:

> Build works fine in
>
> Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-15T06:29:23+13:00)
> Maven home: /opt/apache-maven-3.2.5
> Java version: 1.8.0_45, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-8-oracle/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.16.0-38-generic", arch: "amd64", family: "unix"
> Rat reports 1 binary, against 2 binaries from the previous web site. I think it is because the previous version included site.tgz in the report. One new error in checkstyle, but that doesn't seem relevant.
> This version introduces five errors in FindBugs, all related to the same type [1]
>
> I've changed locally a part of the code reported by FindBugs (GenericKeyedObjectPool L755). From
>        for (K k : poolMap.keySet()) {
>            ObjectDeque<T> queue = poolMap.get(k);
> To
>
>        for (Map.Entry<K, ObjectDeque<T>> entry : poolMap.entrySet()) {
>            ObjectDeque<T> queue = entry.getValue();
> Running the build again, all tests pass and the FindBugs error is gone. But I'm not sure if it wasn't intentional to avoid stale reads from the map.
> Could anyone confirm if the errors reported by FindBugs can be ignored, please?

Yes, "fixing" this would be a bad idea.  It is a false positive.  If
there is another RC, I will add a suppression filter for this "bug"
that must be due to findbugs version upgrade.  Otherwise, this can
be added post-release as part of the site update.

Thanks for the review!

Phil

> Thanks!Bruno
>
> http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR
>

>      From: Phil Steitz <[hidden email]>
>  To: Commons Developers List <[hidden email]>
>  Sent: Saturday, May 23, 2015 3:51 AM
>  Subject: [VOTE] Release pool 2.4 based on RC1
>   
> This is a vote to release version 2.4 of Apache Commons Pool based
> on RC1.
>
> Here is the release candidate:
> https://dist.apache.org/repos/dist/dev/commons/pool/
> (r9083)
>
> Built from:
> https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_4_RC1/
> (r1680963)
>
> Release notes:
> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>
> Maven artifacts:
> http://s.apache.org/Va6
>
> site:
> http://people.apache.org/~psteitz/pool/pool-2.4-rc1
>
> keys:
>
> https://www.apache.org/dist/commons/KEYS
>
> Votes, please.
>
> This vote will close no sooner that 72 hours from now (15:50 GMT
> 25-May-2015).
>
>  [ ] +1 Release these artifacts
>  [ ] +0 OK, but...
>  [ ] -0 OK, but really should fix...
>  [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]


>
>
>   
>



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]


   
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release pool 2.4 based on RC1

Oliver Heger-3
In reply to this post by Phil Steitz
Build with maven works fine with Java 1.6 and 1.8 on Windows 8.1. Site
and artifacts look good.

I had a problem with the ant build: I copied build.properties.sample
(which seems to be a working configuration) to build.properties and
called 'ant test'. This failed with the message below. So there may be
something missing in build.properties.

The ant problem is not blocking for me, so +1

Oliver

    [junit] Testcase: testAccessAfterReturn took 0,002 sec
    [junit]     Caused an ERROR
    [junit] Unexpected exception,
expected<java.lang.IllegalStateException> but
was<java.lang.NoClassDefFoundError>
    [junit] java.lang.Exception: Unexpected exception,
expected<java.lang.Illega
lStateException> but was<java.lang.NoClassDefFoundError>
    [junit] Caused by: java.lang.NoClassDefFoundError: Could not
initialize clas
s net.sf.cglib.proxy.Enhancer
    [junit]     at
org.apache.commons.pool2.proxy.CglibProxySource.createProxy(C
glibProxySource.java:47)
    [junit]     at
org.apache.commons.pool2.proxy.ProxiedKeyedObjectPool.borrowO
bject(ProxiedKeyedObjectPool.java:63)
    [junit]     at
org.apache.commons.pool2.proxy.BaseTestProxiedKeyedObjectPool
.testAccessAfterReturn(BaseTestProxiedKeyedObjectPool.java:73)
    [junit]
    [junit] Testcase: testAccessAfterInvalidate took 0,001 sec
    [junit]     Caused an ERROR
    [junit] Unexpected exception,
expected<java.lang.IllegalStateException> but
was<java.lang.NoClassDefFoundError>
    [junit] java.lang.Exception: Unexpected exception,
expected<java.lang.Illega
lStateException> but was<java.lang.NoClassDefFoundError>
    [junit] Caused by: java.lang.NoClassDefFoundError: Could not
initialize clas
s net.sf.cglib.proxy.Enhancer
    [junit]     at
org.apache.commons.pool2.proxy.CglibProxySource.createProxy(C
glibProxySource.java:47)
    [junit]     at
org.apache.commons.pool2.proxy.ProxiedKeyedObjectPool.borrowO
bject(ProxiedKeyedObjectPool.java:63)
    [junit]     at
org.apache.commons.pool2.proxy.BaseTestProxiedKeyedObjectPool
.testAccessAfterInvalidate(BaseTestProxiedKeyedObjectPool.java:90)
    [junit]

BUILD FAILED
C:\data\dev\projects\OpenSource\pool\commons-pool2-2.4-src\build.xml:137: Test
o
rg.apache.commons.pool2.proxy.TestProxiedKeyedObjectPoolWithCglibProxy
failed

Am 22.05.2015 um 17:51 schrieb Phil Steitz:

> This is a vote to release version 2.4 of Apache Commons Pool based
> on RC1.
>
> Here is the release candidate:
> https://dist.apache.org/repos/dist/dev/commons/pool/
> (r9083)
>
> Built from:
> https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_4_RC1/
> (r1680963)
>
> Release notes:
> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>
> Maven artifacts:
> http://s.apache.org/Va6
>
> site:
> http://people.apache.org/~psteitz/pool/pool-2.4-rc1
>
> keys:
>
> https://www.apache.org/dist/commons/KEYS
>
> Votes, please.
>
> This vote will close no sooner that 72 hours from now (15:50 GMT
> 25-May-2015).
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release pool 2.4 based on RC1

Phil Steitz
On 5/23/15 7:48 AM, Oliver Heger wrote:
> Build with maven works fine with Java 1.6 and 1.8 on Windows 8.1. Site
> and artifacts look good.
>
> I had a problem with the ant build: I copied build.properties.sample
> (which seems to be a working configuration) to build.properties and
> called 'ant test'. This failed with the message below. So there may be
> something missing in build.properties.
>
> The ant problem is not blocking for me, so +1

Can you check if in your local maven repo you have a jar here:
# asm
asm.home=${repository}/org/ow2/asm/asm/5.0.4
asm.jar=${asm.home}/asm-5.0.4.jar

I don't understand why, but on one of my machines I did not have a
jar there - just a pom.  The transitive dependencies from the maven
pom should cause this jar to be downloaded.

Thanks for testing!

Phil

>
> Oliver
>
>     [junit] Testcase: testAccessAfterReturn took 0,002 sec
>     [junit]     Caused an ERROR
>     [junit] Unexpected exception,
> expected<java.lang.IllegalStateException> but
> was<java.lang.NoClassDefFoundError>
>     [junit] java.lang.Exception: Unexpected exception,
> expected<java.lang.Illega
> lStateException> but was<java.lang.NoClassDefFoundError>
>     [junit] Caused by: java.lang.NoClassDefFoundError: Could not
> initialize clas
> s net.sf.cglib.proxy.Enhancer
>     [junit]     at
> org.apache.commons.pool2.proxy.CglibProxySource.createProxy(C
> glibProxySource.java:47)
>     [junit]     at
> org.apache.commons.pool2.proxy.ProxiedKeyedObjectPool.borrowO
> bject(ProxiedKeyedObjectPool.java:63)
>     [junit]     at
> org.apache.commons.pool2.proxy.BaseTestProxiedKeyedObjectPool
> .testAccessAfterReturn(BaseTestProxiedKeyedObjectPool.java:73)
>     [junit]
>     [junit] Testcase: testAccessAfterInvalidate took 0,001 sec
>     [junit]     Caused an ERROR
>     [junit] Unexpected exception,
> expected<java.lang.IllegalStateException> but
> was<java.lang.NoClassDefFoundError>
>     [junit] java.lang.Exception: Unexpected exception,
> expected<java.lang.Illega
> lStateException> but was<java.lang.NoClassDefFoundError>
>     [junit] Caused by: java.lang.NoClassDefFoundError: Could not
> initialize clas
> s net.sf.cglib.proxy.Enhancer
>     [junit]     at
> org.apache.commons.pool2.proxy.CglibProxySource.createProxy(C
> glibProxySource.java:47)
>     [junit]     at
> org.apache.commons.pool2.proxy.ProxiedKeyedObjectPool.borrowO
> bject(ProxiedKeyedObjectPool.java:63)
>     [junit]     at
> org.apache.commons.pool2.proxy.BaseTestProxiedKeyedObjectPool
> .testAccessAfterInvalidate(BaseTestProxiedKeyedObjectPool.java:90)
>     [junit]
>
> BUILD FAILED
> C:\data\dev\projects\OpenSource\pool\commons-pool2-2.4-src\build.xml:137: Test
> o
> rg.apache.commons.pool2.proxy.TestProxiedKeyedObjectPoolWithCglibProxy
> failed
>
> Am 22.05.2015 um 17:51 schrieb Phil Steitz:
>> This is a vote to release version 2.4 of Apache Commons Pool based
>> on RC1.
>>
>> Here is the release candidate:
>> https://dist.apache.org/repos/dist/dev/commons/pool/
>> (r9083)
>>
>> Built from:
>> https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_4_RC1/
>> (r1680963)
>>
>> Release notes:
>> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>>
>> Maven artifacts:
>> http://s.apache.org/Va6
>>
>> site:
>> http://people.apache.org/~psteitz/pool/pool-2.4-rc1
>>
>> keys:
>>
>> https://www.apache.org/dist/commons/KEYS
>>
>> Votes, please.
>>
>> This vote will close no sooner that 72 hours from now (15:50 GMT
>> 25-May-2015).
>>
>>   [ ] +1 Release these artifacts
>>   [ ] +0 OK, but...
>>   [ ] -0 OK, but really should fix...
>>   [ ] -1 I oppose this release because...
>>
>> Thanks!
>>
>> Phil
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release pool 2.4 based on RC1

Oliver Heger-3


Am 23.05.2015 um 16:53 schrieb Phil Steitz:

> On 5/23/15 7:48 AM, Oliver Heger wrote:
>> Build with maven works fine with Java 1.6 and 1.8 on Windows 8.1. Site
>> and artifacts look good.
>>
>> I had a problem with the ant build: I copied build.properties.sample
>> (which seems to be a working configuration) to build.properties and
>> called 'ant test'. This failed with the message below. So there may be
>> something missing in build.properties.
>>
>> The ant problem is not blocking for me, so +1
>
> Can you check if in your local maven repo you have a jar here:
> # asm
> asm.home=${repository}/org/ow2/asm/asm/5.0.4
> asm.jar=${asm.home}/asm-5.0.4.jar
>
> I don't understand why, but on one of my machines I did not have a
> jar there - just a pom.  The transitive dependencies from the maven
> pom should cause this jar to be downloaded.

Indeed, there is only a pom!

When I do mvn dependency:tree it gives me:

[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @
commons-pool2 ---
[INFO] org.apache.commons:commons-pool2:jar:2.4
[INFO] +- junit:junit:jar:4.12:test
[INFO] |  \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] +- cglib:cglib:jar:3.1:compile
[INFO] |  \- org.ow2.asm:asm:jar:4.2:compile
[INFO] \- org.ow2.asm:asm-util:jar:5.0.4:compile
[INFO]    \- org.ow2.asm:asm-tree:jar:5.0.4:compile

So it seems to use an older version of asm.

Oliver

>
> Thanks for testing!
>
> Phil
>>
>> Oliver
>>
>>     [junit] Testcase: testAccessAfterReturn took 0,002 sec
>>     [junit]     Caused an ERROR
>>     [junit] Unexpected exception,
>> expected<java.lang.IllegalStateException> but
>> was<java.lang.NoClassDefFoundError>
>>     [junit] java.lang.Exception: Unexpected exception,
>> expected<java.lang.Illega
>> lStateException> but was<java.lang.NoClassDefFoundError>
>>     [junit] Caused by: java.lang.NoClassDefFoundError: Could not
>> initialize clas
>> s net.sf.cglib.proxy.Enhancer
>>     [junit]     at
>> org.apache.commons.pool2.proxy.CglibProxySource.createProxy(C
>> glibProxySource.java:47)
>>     [junit]     at
>> org.apache.commons.pool2.proxy.ProxiedKeyedObjectPool.borrowO
>> bject(ProxiedKeyedObjectPool.java:63)
>>     [junit]     at
>> org.apache.commons.pool2.proxy.BaseTestProxiedKeyedObjectPool
>> .testAccessAfterReturn(BaseTestProxiedKeyedObjectPool.java:73)
>>     [junit]
>>     [junit] Testcase: testAccessAfterInvalidate took 0,001 sec
>>     [junit]     Caused an ERROR
>>     [junit] Unexpected exception,
>> expected<java.lang.IllegalStateException> but
>> was<java.lang.NoClassDefFoundError>
>>     [junit] java.lang.Exception: Unexpected exception,
>> expected<java.lang.Illega
>> lStateException> but was<java.lang.NoClassDefFoundError>
>>     [junit] Caused by: java.lang.NoClassDefFoundError: Could not
>> initialize clas
>> s net.sf.cglib.proxy.Enhancer
>>     [junit]     at
>> org.apache.commons.pool2.proxy.CglibProxySource.createProxy(C
>> glibProxySource.java:47)
>>     [junit]     at
>> org.apache.commons.pool2.proxy.ProxiedKeyedObjectPool.borrowO
>> bject(ProxiedKeyedObjectPool.java:63)
>>     [junit]     at
>> org.apache.commons.pool2.proxy.BaseTestProxiedKeyedObjectPool
>> .testAccessAfterInvalidate(BaseTestProxiedKeyedObjectPool.java:90)
>>     [junit]
>>
>> BUILD FAILED
>> C:\data\dev\projects\OpenSource\pool\commons-pool2-2.4-src\build.xml:137: Test
>> o
>> rg.apache.commons.pool2.proxy.TestProxiedKeyedObjectPoolWithCglibProxy
>> failed
>>
>> Am 22.05.2015 um 17:51 schrieb Phil Steitz:
>>> This is a vote to release version 2.4 of Apache Commons Pool based
>>> on RC1.
>>>
>>> Here is the release candidate:
>>> https://dist.apache.org/repos/dist/dev/commons/pool/
>>> (r9083)
>>>
>>> Built from:
>>> https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_4_RC1/
>>> (r1680963)
>>>
>>> Release notes:
>>> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>>>
>>> Maven artifacts:
>>> http://s.apache.org/Va6
>>>
>>> site:
>>> http://people.apache.org/~psteitz/pool/pool-2.4-rc1
>>>
>>> keys:
>>>
>>> https://www.apache.org/dist/commons/KEYS
>>>
>>> Votes, please.
>>>
>>> This vote will close no sooner that 72 hours from now (15:50 GMT
>>> 25-May-2015).
>>>
>>>   [ ] +1 Release these artifacts
>>>   [ ] +0 OK, but...
>>>   [ ] -0 OK, but really should fix...
>>>   [ ] -1 I oppose this release because...
>>>
>>> Thanks!
>>>
>>> Phil
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release pool 2.4 based on RC1

Phil Steitz
On 5/23/15 7:57 AM, Oliver Heger wrote:

>
> Am 23.05.2015 um 16:53 schrieb Phil Steitz:
>> On 5/23/15 7:48 AM, Oliver Heger wrote:
>>> Build with maven works fine with Java 1.6 and 1.8 on Windows 8.1. Site
>>> and artifacts look good.
>>>
>>> I had a problem with the ant build: I copied build.properties.sample
>>> (which seems to be a working configuration) to build.properties and
>>> called 'ant test'. This failed with the message below. So there may be
>>> something missing in build.properties.
>>>
>>> The ant problem is not blocking for me, so +1
>> Can you check if in your local maven repo you have a jar here:
>> # asm
>> asm.home=${repository}/org/ow2/asm/asm/5.0.4
>> asm.jar=${asm.home}/asm-5.0.4.jar
>>
>> I don't understand why, but on one of my machines I did not have a
>> jar there - just a pom.  The transitive dependencies from the maven
>> pom should cause this jar to be downloaded.
> Indeed, there is only a pom!
>
> When I do mvn dependency:tree it gives me:
>
> [INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @
> commons-pool2 ---
> [INFO] org.apache.commons:commons-pool2:jar:2.4
> [INFO] +- junit:junit:jar:4.12:test
> [INFO] |  \- org.hamcrest:hamcrest-core:jar:1.3:test
> [INFO] +- cglib:cglib:jar:3.1:compile
> [INFO] |  \- org.ow2.asm:asm:jar:4.2:compile
> [INFO] \- org.ow2.asm:asm-util:jar:5.0.4:compile
> [INFO]    \- org.ow2.asm:asm-tree:jar:5.0.4:compile
>
> So it seems to use an older version of asm.

Interesting.  I am not sure I get why, exactly, but asm-util ->
asm-tree at 5.0.4 does not pull in asm 5.0.4.  I guess that is
because the asm dependency is not versioned in the asm-tree pom:
<dependencies>
    <dependency>
      <artifactId>asm</artifactId>
      <groupId>org.ow2.asm</groupId>
    </dependency>
  </dependencies>

In any case, if there is in fact a jar at the indicated location in
build.properties, the build works so I don't see this as a
showstopper.  Not sure if I should "fix" this or not if I do another
RC (or post-release).  If I were building with Ant myself, I would
prefer to bring in the later jar.

Thanks!

Phil

>
> Oliver
>
>> Thanks for testing!
>>
>> Phil
>>> Oliver
>>>
>>>     [junit] Testcase: testAccessAfterReturn took 0,002 sec
>>>     [junit]     Caused an ERROR
>>>     [junit] Unexpected exception,
>>> expected<java.lang.IllegalStateException> but
>>> was<java.lang.NoClassDefFoundError>
>>>     [junit] java.lang.Exception: Unexpected exception,
>>> expected<java.lang.Illega
>>> lStateException> but was<java.lang.NoClassDefFoundError>
>>>     [junit] Caused by: java.lang.NoClassDefFoundError: Could not
>>> initialize clas
>>> s net.sf.cglib.proxy.Enhancer
>>>     [junit]     at
>>> org.apache.commons.pool2.proxy.CglibProxySource.createProxy(C
>>> glibProxySource.java:47)
>>>     [junit]     at
>>> org.apache.commons.pool2.proxy.ProxiedKeyedObjectPool.borrowO
>>> bject(ProxiedKeyedObjectPool.java:63)
>>>     [junit]     at
>>> org.apache.commons.pool2.proxy.BaseTestProxiedKeyedObjectPool
>>> .testAccessAfterReturn(BaseTestProxiedKeyedObjectPool.java:73)
>>>     [junit]
>>>     [junit] Testcase: testAccessAfterInvalidate took 0,001 sec
>>>     [junit]     Caused an ERROR
>>>     [junit] Unexpected exception,
>>> expected<java.lang.IllegalStateException> but
>>> was<java.lang.NoClassDefFoundError>
>>>     [junit] java.lang.Exception: Unexpected exception,
>>> expected<java.lang.Illega
>>> lStateException> but was<java.lang.NoClassDefFoundError>
>>>     [junit] Caused by: java.lang.NoClassDefFoundError: Could not
>>> initialize clas
>>> s net.sf.cglib.proxy.Enhancer
>>>     [junit]     at
>>> org.apache.commons.pool2.proxy.CglibProxySource.createProxy(C
>>> glibProxySource.java:47)
>>>     [junit]     at
>>> org.apache.commons.pool2.proxy.ProxiedKeyedObjectPool.borrowO
>>> bject(ProxiedKeyedObjectPool.java:63)
>>>     [junit]     at
>>> org.apache.commons.pool2.proxy.BaseTestProxiedKeyedObjectPool
>>> .testAccessAfterInvalidate(BaseTestProxiedKeyedObjectPool.java:90)
>>>     [junit]
>>>
>>> BUILD FAILED
>>> C:\data\dev\projects\OpenSource\pool\commons-pool2-2.4-src\build.xml:137: Test
>>> o
>>> rg.apache.commons.pool2.proxy.TestProxiedKeyedObjectPoolWithCglibProxy
>>> failed
>>>
>>> Am 22.05.2015 um 17:51 schrieb Phil Steitz:
>>>> This is a vote to release version 2.4 of Apache Commons Pool based
>>>> on RC1.
>>>>
>>>> Here is the release candidate:
>>>> https://dist.apache.org/repos/dist/dev/commons/pool/
>>>> (r9083)
>>>>
>>>> Built from:
>>>> https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_4_RC1/
>>>> (r1680963)
>>>>
>>>> Release notes:
>>>> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>>>>
>>>> Maven artifacts:
>>>> http://s.apache.org/Va6
>>>>
>>>> site:
>>>> http://people.apache.org/~psteitz/pool/pool-2.4-rc1
>>>>
>>>> keys:
>>>>
>>>> https://www.apache.org/dist/commons/KEYS
>>>>
>>>> Votes, please.
>>>>
>>>> This vote will close no sooner that 72 hours from now (15:50 GMT
>>>> 25-May-2015).
>>>>
>>>>   [ ] +1 Release these artifacts
>>>>   [ ] +0 OK, but...
>>>>   [ ] -0 OK, but really should fix...
>>>>   [ ] -1 I oppose this release because...
>>>>
>>>> Thanks!
>>>>
>>>> Phil
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [hidden email]
>>>> For additional commands, e-mail: [hidden email]
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release pool 2.4 based on RC1

Phil Steitz
In reply to this post by Phil Steitz
Here is my +1

Phil
On 5/22/15 8:51 AM, Phil Steitz wrote:

> This is a vote to release version 2.4 of Apache Commons Pool based
> on RC1.
>
> Here is the release candidate:
> https://dist.apache.org/repos/dist/dev/commons/pool/
> (r9083)
>
> Built from:
> https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_4_RC1/
> (r1680963)
>
> Release notes:
> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>
> Maven artifacts:
> http://s.apache.org/Va6
>
> site:
> http://people.apache.org/~psteitz/pool/pool-2.4-rc1
>
> keys:
>
> https://www.apache.org/dist/commons/KEYS
>
> Votes, please.
>
> This vote will close no sooner that 72 hours from now (15:50 GMT
> 25-May-2015).
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release pool 2.4 based on RC1

garydgregory
In reply to this post by Phil Steitz
+1

Based on src zip, MD5, ASC, OK. RAT, Clirr OK. "mvn clean site" builds OK.

A few interesting items in FinbBugs but no showstoppers.

Testing with:

Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1;
2014-12-14T09:29:23-08:00)
Maven home: C:\Java\apache-maven-3.2.5
Java version: 1.7.0_79, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_79\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"

Gary

On Fri, May 22, 2015 at 8:51 AM, Phil Steitz <[hidden email]> wrote:

> This is a vote to release version 2.4 of Apache Commons Pool based
> on RC1.
>
> Here is the release candidate:
> https://dist.apache.org/repos/dist/dev/commons/pool/
> (r9083)
>
> Built from:
> https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_4_RC1/
> (r1680963)
>
> Release notes:
> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>
> Maven artifacts:
> http://s.apache.org/Va6
>
> site:
> http://people.apache.org/~psteitz/pool/pool-2.4-rc1
>
> keys:
>
> https://www.apache.org/dist/commons/KEYS
>
> Votes, please.
>
> This vote will close no sooner that 72 hours from now (15:50 GMT
> 25-May-2015).
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
E-Mail: [hidden email] | [hidden email]
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Reply | Threaded
Open this post in threaded view
|

RESULT: [VOTE] Release pool 2.4 based on RC1

Phil Steitz
In reply to this post by Phil Steitz
This VOTE has passed.

+1 votes from

Oliver Heger*
Phil Steitz*
Gary Gregory*
Bruno Kinoshita

and no other votes.

*Commons PMC

Thanks!

Phil

On 5/22/15 8:51 AM, Phil Steitz wrote:

> This is a vote to release version 2.4 of Apache Commons Pool based
> on RC1.
>
> Here is the release candidate:
> https://dist.apache.org/repos/dist/dev/commons/pool/
> (r9083)
>
> Built from:
> https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_4_RC1/
> (r1680963)
>
> Release notes:
> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>
> Maven artifacts:
> http://s.apache.org/Va6
>
> site:
> http://people.apache.org/~psteitz/pool/pool-2.4-rc1
>
> keys:
>
> https://www.apache.org/dist/commons/KEYS
>
> Votes, please.
>
> This vote will close no sooner that 72 hours from now (15:50 GMT
> 25-May-2015).
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thanks!
>
> Phil
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]