[Vote] Release Apache Commons RNG v1.2 (RC1)

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[Vote] Release Apache Commons RNG v1.2 (RC1)

Gilles Sadowski
Hello.

I would like to release Apache Commons RNG v1.2.

Apache Commons RNG 1.2 RC1 is available for review:
     https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1 (svn
revision 31333)

The Git tag for this RC is "RNG_1_2_RC1":
     
https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_2_RC1

Maven artifacts:
     
https://repository.apache.org/content/repositories/orgapachecommons-1397/org/apache/commons/

Maven artifacts' SHA-512 hashes in Nexus:
     
commons-rng-1.2-bin-tar.gz=beba8312f8702563b7d2a8b3919e812b60e509342fb102274b1fef8107c67d8419b74a82b7c6fd6fdfd9ed03cd590751a80ca27614cca2a909ba057e3c513ef7
     
commons-rng-1.2-bin-tar.gz.asc=500c67f4c3c1fdc6583fab068f20664e7235e5f983dcc90c1c9d70290bf5eb3e4a76d7fb3eba56f4a3e8e957bf0c490db237698419c95e2dbca8716f393def4c
     
commons-rng-1.2-src-tar.gz=a9325efec521ff3f3489fa67568bc91b5a89014c888d81d14a39e669cf678648ba60722e3f3320ad643d9e84ef3193f272bfd78b4495044b6a763a6442590a3f
     
commons-rng-1.2-bin-zip=55342112a7e505882ad5739233508d2957c396f71bf22a45226844bf5ccdfb4947066a0fb111f1a51287ef359bdd1e84f9c7fdde7c3a02092b4cf45aa9eb3d99
     
commons-rng-1.2-src-zip=f2d7dbabb1479afd15adae00e9007480638d7c8b5a2900d1d43ec7497efd8f2a0a66bc84032c642de6b3ecf0829a01d3c6748e583b43476f4f36466667fe2292
     
commons-rng-1.2-src-zip.asc=e931a42202b3ba274ca07251d8114066c88085014823c421b0cba15c300596aad1d7a7c7f42f85fe0e62cfa3ab4dd4a7afd32ab18149d42e5e775c9c2bf0e187
     
commons-rng-1.2-pom.asc=4c9ebbb00fbc1b7f7a679c1f165fc6561ad69fd5e7ec2b268d89c26053643a9574ac69876d47cc8e1a27f595010a6466c4f679518ee7dec5b9c250a5a4720089
     
commons-rng-1.2-bin-zip.asc=30e72114890ad6551fb2dc21251d787cf7410d22c92960375d2bfc8586279d1981261af74ce9477313bd1dac4ee632d94100c0db6340a216e385c947b491f432
     
commons-rng-1.2-src-tar.gz.asc=e1a04875744dc3cd5b04bfbe5c6fa52e553ecc645c5923db53259202daf28f5fd8570c84a9fcb0ae10669a0924101d4d737ca23fb9cbcd4da7f708ce67c6b5f8

Details of changes:
     
https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/RELEASE-NOTES.txt
     
https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/changes-report.html

Site:
     http://commons.apache.org/proper/commons-rng/

KEYS:
    id=B39617E095CD748DFE505816703413011E22D5B8
    https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.

   [ ] +1 Release these artifacts
   [ ] +0 OK, but...
   [ ] -0 OK, but really should fix...
   [ ] -1 I oppose this release because...

Thanks,
Gilles


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Vote] Release Apache Commons RNG v1.2 (RC1)

Alex Herbert
+0 (non-binding)


The user guide shows updated Performance and Quality tables following
the changes to the core implementation for all tables (verses release
1.1). I note that the times for the BoxMullerNormalizedGaussianSampler
have all improved nearly 2-fold which is strange. The code appears to be
unchanged from v1.1.


The RC site:

https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/userguide/rng.html

Is also showing at the official location:

http://commons.apache.org/proper/commons-rng/

This link is broken from the 'Release History' page:

https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/release-notes/RELEASE-NOTES-1.2.txt


The following reports are empty in the Project Reports menu:

- Surefire Report

- japicmp

- JaCoCo Aggregate (this link jumps out of the 'frames' view an loses
the menu)

- Checkstyle

There are no spotbugs or PMD entries in the menu.


I'm not sure where to get the artifacts to check the hashes so I've not
done that.


The 'Project Documentation > Source Code Management' page states to use:

git clone http://git-wip-us.apache.org/repos/asf/commons-rng.git

This doesn't work for me. I used the mirror and the RC tag:

https://github.com/apache/commons-rng


Building with mvn verify site

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T19:33:14+01:00)
Maven home: /usr/local/apache-maven-3.5.4
Java version: 1.8.0_191, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-139-generic", arch: "amd64", family:
"unix"

This works but the local site is missing the same Project Reports. The
modules all have surefire reports, PMD, CPD, spotbugs, checkstyle in the
target directories. Not sure where japicmp writes plain results but the
japicmp.html page is always blank. So something is broken with
aggregating the reports and possibly the japicmp report.

Alex


On 04/12/2018 01:19, Gilles wrote:

> Hello.
>
> I would like to release Apache Commons RNG v1.2.
>
> Apache Commons RNG 1.2 RC1 is available for review:
>     https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1 (svn
> revision 31333)
>
> The Git tag for this RC is "RNG_1_2_RC1":
> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_2_RC1
>
> Maven artifacts:
> https://repository.apache.org/content/repositories/orgapachecommons-1397/org/apache/commons/
>
> Maven artifacts' SHA-512 hashes in Nexus:
> commons-rng-1.2-bin-tar.gz=beba8312f8702563b7d2a8b3919e812b60e509342fb102274b1fef8107c67d8419b74a82b7c6fd6fdfd9ed03cd590751a80ca27614cca2a909ba057e3c513ef7
> commons-rng-1.2-bin-tar.gz.asc=500c67f4c3c1fdc6583fab068f20664e7235e5f983dcc90c1c9d70290bf5eb3e4a76d7fb3eba56f4a3e8e957bf0c490db237698419c95e2dbca8716f393def4c
> commons-rng-1.2-src-tar.gz=a9325efec521ff3f3489fa67568bc91b5a89014c888d81d14a39e669cf678648ba60722e3f3320ad643d9e84ef3193f272bfd78b4495044b6a763a6442590a3f
> commons-rng-1.2-bin-zip=55342112a7e505882ad5739233508d2957c396f71bf22a45226844bf5ccdfb4947066a0fb111f1a51287ef359bdd1e84f9c7fdde7c3a02092b4cf45aa9eb3d99
> commons-rng-1.2-src-zip=f2d7dbabb1479afd15adae00e9007480638d7c8b5a2900d1d43ec7497efd8f2a0a66bc84032c642de6b3ecf0829a01d3c6748e583b43476f4f36466667fe2292
> commons-rng-1.2-src-zip.asc=e931a42202b3ba274ca07251d8114066c88085014823c421b0cba15c300596aad1d7a7c7f42f85fe0e62cfa3ab4dd4a7afd32ab18149d42e5e775c9c2bf0e187
> commons-rng-1.2-pom.asc=4c9ebbb00fbc1b7f7a679c1f165fc6561ad69fd5e7ec2b268d89c26053643a9574ac69876d47cc8e1a27f595010a6466c4f679518ee7dec5b9c250a5a4720089
> commons-rng-1.2-bin-zip.asc=30e72114890ad6551fb2dc21251d787cf7410d22c92960375d2bfc8586279d1981261af74ce9477313bd1dac4ee632d94100c0db6340a216e385c947b491f432
> commons-rng-1.2-src-tar.gz.asc=e1a04875744dc3cd5b04bfbe5c6fa52e553ecc645c5923db53259202daf28f5fd8570c84a9fcb0ae10669a0924101d4d737ca23fb9cbcd4da7f708ce67c6b5f8
>
> Details of changes:
> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/RELEASE-NOTES.txt
> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/changes-report.html
>
> Site:
>     http://commons.apache.org/proper/commons-rng/
>
> KEYS:
>    id=B39617E095CD748DFE505816703413011E22D5B8
>    https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thanks,
> Gilles
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Vote] Release Apache Commons RNG v1.2 (RC1)

Rob Tompkins
I’ll try to get to validation on this by the end of the day, unless @Gilles, you want to take into account the vote below.

-Rob

> On Dec 4, 2018, at 9:08 AM, Alex Herbert <[hidden email]> wrote:
>
> +0 (non-binding)
>
>
> The user guide shows updated Performance and Quality tables following the changes to the core implementation for all tables (verses release 1.1). I note that the times for the BoxMullerNormalizedGaussianSampler have all improved nearly 2-fold which is strange. The code appears to be unchanged from v1.1.
>
>
> The RC site:
>
> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/userguide/rng.html
>
> Is also showing at the official location:
>
> http://commons.apache.org/proper/commons-rng/
>
> This link is broken from the 'Release History' page:
>
> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/release-notes/RELEASE-NOTES-1.2.txt
>
>
> The following reports are empty in the Project Reports menu:
>
> - Surefire Report
>
> - japicmp
>
> - JaCoCo Aggregate (this link jumps out of the 'frames' view an loses the menu)
>
> - Checkstyle
>
> There are no spotbugs or PMD entries in the menu.
>
>
> I'm not sure where to get the artifacts to check the hashes so I've not done that.
>
>
> The 'Project Documentation > Source Code Management' page states to use:
>
> git clone http://git-wip-us.apache.org/repos/asf/commons-rng.git
>
> This doesn't work for me. I used the mirror and the RC tag:
>
> https://github.com/apache/commons-rng
>
>
> Building with mvn verify site
>
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T19:33:14+01:00)
> Maven home: /usr/local/apache-maven-3.5.4
> Java version: 1.8.0_191, vendor: Oracle Corporation, runtime: /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.4.0-139-generic", arch: "amd64", family: "unix"
>
> This works but the local site is missing the same Project Reports. The modules all have surefire reports, PMD, CPD, spotbugs, checkstyle in the target directories. Not sure where japicmp writes plain results but the japicmp.html page is always blank. So something is broken with aggregating the reports and possibly the japicmp report.
>
> Alex
>
>
> On 04/12/2018 01:19, Gilles wrote:
>> Hello.
>>
>> I would like to release Apache Commons RNG v1.2.
>>
>> Apache Commons RNG 1.2 RC1 is available for review:
>>     https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1 (svn revision 31333)
>>
>> The Git tag for this RC is "RNG_1_2_RC1":
>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_2_RC1
>>
>> Maven artifacts:
>> https://repository.apache.org/content/repositories/orgapachecommons-1397/org/apache/commons/
>>
>> Maven artifacts' SHA-512 hashes in Nexus:
>> commons-rng-1.2-bin-tar.gz=beba8312f8702563b7d2a8b3919e812b60e509342fb102274b1fef8107c67d8419b74a82b7c6fd6fdfd9ed03cd590751a80ca27614cca2a909ba057e3c513ef7
>> commons-rng-1.2-bin-tar.gz.asc=500c67f4c3c1fdc6583fab068f20664e7235e5f983dcc90c1c9d70290bf5eb3e4a76d7fb3eba56f4a3e8e957bf0c490db237698419c95e2dbca8716f393def4c
>> commons-rng-1.2-src-tar.gz=a9325efec521ff3f3489fa67568bc91b5a89014c888d81d14a39e669cf678648ba60722e3f3320ad643d9e84ef3193f272bfd78b4495044b6a763a6442590a3f
>> commons-rng-1.2-bin-zip=55342112a7e505882ad5739233508d2957c396f71bf22a45226844bf5ccdfb4947066a0fb111f1a51287ef359bdd1e84f9c7fdde7c3a02092b4cf45aa9eb3d99
>> commons-rng-1.2-src-zip=f2d7dbabb1479afd15adae00e9007480638d7c8b5a2900d1d43ec7497efd8f2a0a66bc84032c642de6b3ecf0829a01d3c6748e583b43476f4f36466667fe2292
>> commons-rng-1.2-src-zip.asc=e931a42202b3ba274ca07251d8114066c88085014823c421b0cba15c300596aad1d7a7c7f42f85fe0e62cfa3ab4dd4a7afd32ab18149d42e5e775c9c2bf0e187
>> commons-rng-1.2-pom.asc=4c9ebbb00fbc1b7f7a679c1f165fc6561ad69fd5e7ec2b268d89c26053643a9574ac69876d47cc8e1a27f595010a6466c4f679518ee7dec5b9c250a5a4720089
>> commons-rng-1.2-bin-zip.asc=30e72114890ad6551fb2dc21251d787cf7410d22c92960375d2bfc8586279d1981261af74ce9477313bd1dac4ee632d94100c0db6340a216e385c947b491f432
>> commons-rng-1.2-src-tar.gz.asc=e1a04875744dc3cd5b04bfbe5c6fa52e553ecc645c5923db53259202daf28f5fd8570c84a9fcb0ae10669a0924101d4d737ca23fb9cbcd4da7f708ce67c6b5f8
>>
>> Details of changes:
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/RELEASE-NOTES.txt
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/changes-report.html
>>
>> Site:
>>     http://commons.apache.org/proper/commons-rng/
>>
>> KEYS:
>>    id=B39617E095CD748DFE505816703413011E22D5B8
>>    https://www.apache.org/dist/commons/KEYS
>>
>> Please review the release candidate and vote.
>> This vote will close no sooner that 72 hours from now.
>>
>>   [ ] +1 Release these artifacts
>>   [ ] +0 OK, but...
>>   [ ] -0 OK, but really should fix...
>>   [ ] -1 I oppose this release because...
>>
>> Thanks,
>> Gilles
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Vote] Release Apache Commons RNG v1.2 (RC1)

Gilles Sadowski
In reply to this post by Alex Herbert
On Tue, 4 Dec 2018 14:08:59 +0000, Alex Herbert wrote:
> +0 (non-binding)
>
>
> The user guide shows updated Performance and Quality tables following
> the changes to the core implementation for all tables (verses release
> 1.1). I note that the times for the
> BoxMullerNormalizedGaussianSampler
> have all improved nearly 2-fold which is strange.

Agreed.  But I can't say much more.  You are welcome to
confirm that either the current or the previous values
(or neither) are correct.
And we'll update the site accordingly.

> The code appears to
> be unchanged from v1.1.

No change indeed, except the JVM version.

>
> The RC site:
>
>
> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/userguide/rng.html
>
> Is also showing at the official location:
>
> http://commons.apache.org/proper/commons-rng/

The release-plugin did not correctly generate the whole site for
review at
https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site
[All the modules' "sub-sites" are missing.]

Hence I chose to update the live site.

>
> This link is broken from the 'Release History' page:
>
>
> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/release-notes/RELEASE-NOTES-1.2.txt

This can be fixed later on. [I was expecting this copy to be done
automatically by the release-plugin...]

The "authoritative" file for the release is in the top-level
directory of the maven project, and here:
   
https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/RELEASE-NOTES.txt

>
> The following reports are empty in the Project Reports menu:
>
> - Surefire Report

There is one report per module (where the actual code is).
See e.g.
   
http://commons.apache.org/proper/commons-rng/commons-rng-core/surefire-report.html

Modules list is at that page:
   http://commons.apache.org/proper/commons-rng/modules.html

>
> - japicmp

This hasn't worked for me for months (see ML archive and a recent
post).

Clirr is the reference for BC of this release of the 4 official
artefacts:
   
http://commons.apache.org/proper/commons-rng/commons-rng-client-api/clirr-report.html
   
http://commons.apache.org/proper/commons-rng/commons-rng-core/clirr-report.html
   
http://commons.apache.org/proper/commons-rng/commons-rng-simple/clirr-report.html
   
http://commons.apache.org/proper/commons-rng/commons-rng-sampling/clirr-report.html

> - JaCoCo Aggregate (this link jumps out of the 'frames' view an loses
> the menu)

Always was so.  Perhaps something to report here:
   https://issues.apache.org/jira/projects/COMMONSSITE
[Or a maven issue.]

>
> - Checkstyle
>
> There are no spotbugs or PMD entries in the menu.

One per report per module, e.g.:
   
http://commons.apache.org/proper/commons-rng/commons-rng-core/spotbugs.html
   
http://commons.apache.org/proper/commons-rng/commons-rng-core/pmd.html

>
>
> I'm not sure where to get the artifacts to check the hashes so I've
> not done that.

They are next to the files, here:
   https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/binaries/
and here:
   https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/source/

>
>
> The 'Project Documentation > Source Code Management' page states to
> use:
>
> git clone http://git-wip-us.apache.org/repos/asf/commons-rng.git

Odd.
It works for me (TM). :-)

> This doesn't work for me. I used the mirror and the RC tag:
>
> https://github.com/apache/commons-rng
>
>
> Building with mvn verify site
>
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T19:33:14+01:00)
> Maven home: /usr/local/apache-maven-3.5.4
> Java version: 1.8.0_191, vendor: Oracle Corporation, runtime:
> /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.4.0-139-generic", arch: "amd64",
> family: "unix"
>
> This works but the local site is missing the same Project Reports.
> The modules all have surefire reports, PMD, CPD, spotbugs, checkstyle
> in the target directories. Not sure where japicmp writes plain
> results
> but the japicmp.html page is always blank. So something is broken
> with
> aggregating the reports and possibly the japicmp report.

The command to generate the full site for a multi-module project is
   $ mvn clean site site:stage
and the site will be in subdirectory
   target/staging"
of the top-level directory.


Thanks for the review,
Gilles

>
> Alex
>
>
> On 04/12/2018 01:19, Gilles wrote:
>> Hello.
>>
>> I would like to release Apache Commons RNG v1.2.
>>
>> Apache Commons RNG 1.2 RC1 is available for review:
>>     https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1 (svn
>> revision 31333)
>>
>> The Git tag for this RC is "RNG_1_2_RC1":
>>
>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_2_RC1
>>
>> Maven artifacts:
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1397/org/apache/commons/
>>
>> Maven artifacts' SHA-512 hashes in Nexus:
>>
>> commons-rng-1.2-bin-tar.gz=beba8312f8702563b7d2a8b3919e812b60e509342fb102274b1fef8107c67d8419b74a82b7c6fd6fdfd9ed03cd590751a80ca27614cca2a909ba057e3c513ef7
>>
>> commons-rng-1.2-bin-tar.gz.asc=500c67f4c3c1fdc6583fab068f20664e7235e5f983dcc90c1c9d70290bf5eb3e4a76d7fb3eba56f4a3e8e957bf0c490db237698419c95e2dbca8716f393def4c
>>
>> commons-rng-1.2-src-tar.gz=a9325efec521ff3f3489fa67568bc91b5a89014c888d81d14a39e669cf678648ba60722e3f3320ad643d9e84ef3193f272bfd78b4495044b6a763a6442590a3f
>>
>> commons-rng-1.2-bin-zip=55342112a7e505882ad5739233508d2957c396f71bf22a45226844bf5ccdfb4947066a0fb111f1a51287ef359bdd1e84f9c7fdde7c3a02092b4cf45aa9eb3d99
>>
>> commons-rng-1.2-src-zip=f2d7dbabb1479afd15adae00e9007480638d7c8b5a2900d1d43ec7497efd8f2a0a66bc84032c642de6b3ecf0829a01d3c6748e583b43476f4f36466667fe2292
>>
>> commons-rng-1.2-src-zip.asc=e931a42202b3ba274ca07251d8114066c88085014823c421b0cba15c300596aad1d7a7c7f42f85fe0e62cfa3ab4dd4a7afd32ab18149d42e5e775c9c2bf0e187
>>
>> commons-rng-1.2-pom.asc=4c9ebbb00fbc1b7f7a679c1f165fc6561ad69fd5e7ec2b268d89c26053643a9574ac69876d47cc8e1a27f595010a6466c4f679518ee7dec5b9c250a5a4720089
>>
>> commons-rng-1.2-bin-zip.asc=30e72114890ad6551fb2dc21251d787cf7410d22c92960375d2bfc8586279d1981261af74ce9477313bd1dac4ee632d94100c0db6340a216e385c947b491f432
>>
>> commons-rng-1.2-src-tar.gz.asc=e1a04875744dc3cd5b04bfbe5c6fa52e553ecc645c5923db53259202daf28f5fd8570c84a9fcb0ae10669a0924101d4d737ca23fb9cbcd4da7f708ce67c6b5f8
>>
>> Details of changes:
>>
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/RELEASE-NOTES.txt
>>
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/changes-report.html
>>
>> Site:
>>     http://commons.apache.org/proper/commons-rng/
>>
>> KEYS:
>>    id=B39617E095CD748DFE505816703413011E22D5B8
>>    https://www.apache.org/dist/commons/KEYS
>>
>> Please review the release candidate and vote.
>> This vote will close no sooner that 72 hours from now.
>>
>>   [ ] +1 Release these artifacts
>>   [ ] +0 OK, but...
>>   [ ] -0 OK, but really should fix...
>>   [ ] -1 I oppose this release because...
>>
>> Thanks,
>> Gilles
>>
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Vote] Release Apache Commons RNG v1.2 (RC1)

Rob Tompkins


> On Dec 4, 2018, at 10:15 AM, Gilles <[hidden email]> wrote:
>
> On Tue, 4 Dec 2018 14:08:59 +0000, Alex Herbert wrote:
>> +0 (non-binding)
>>
>>
>> The user guide shows updated Performance and Quality tables following
>> the changes to the core implementation for all tables (verses release
>> 1.1). I note that the times for the BoxMullerNormalizedGaussianSampler
>> have all improved nearly 2-fold which is strange.
>
> Agreed.  But I can't say much more.  You are welcome to
> confirm that either the current or the previous values
> (or neither) are correct.
> And we'll update the site accordingly.
>
>> The code appears to
>> be unchanged from v1.1.
>
> No change indeed, except the JVM version.
>
>>
>> The RC site:
>>
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/userguide/rng.html <https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/userguide/rng.html>
>>
>> Is also showing at the official location:
>>
>> http://commons.apache.org/proper/commons-rng/ <http://commons.apache.org/proper/commons-rng/>
>
> The release-plugin did not correctly generate the whole site for
> review at https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site <https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site>
> [All the modules' "sub-sites" are missing.]
>
> Hence I chose to update the live site.
>
>>
>> This link is broken from the 'Release History' page:
>>
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/release-notes/RELEASE-NOTES-1.2.txt <https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/release-notes/RELEASE-NOTES-1.2.txt>
>
> This can be fixed later on. [I was expecting this copy to be done
> automatically by the release-plugin...]
>
> The "authoritative" file for the release is in the top-level
> directory of the maven project, and here:
>  https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/RELEASE-NOTES.txt <https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/RELEASE-NOTES.txt>
>
>>
>> The following reports are empty in the Project Reports menu:
>>
>> - Surefire Report
>
> There is one report per module (where the actual code is).
> See e.g.
>  http://commons.apache.org/proper/commons-rng/commons-rng-core/surefire-report.html <http://commons.apache.org/proper/commons-rng/commons-rng-core/surefire-report.html>
>
> Modules list is at that page:
>  http://commons.apache.org/proper/commons-rng/modules.html <http://commons.apache.org/proper/commons-rng/modules.html>
>
>>
>> - japicmp
>
> This hasn't worked for me for months (see ML archive and a recent
> post).
>
> Clirr is the reference for BC of this release of the 4 official artefacts:
>  http://commons.apache.org/proper/commons-rng/commons-rng-client-api/clirr-report.html <http://commons.apache.org/proper/commons-rng/commons-rng-client-api/clirr-report.html>
>  http://commons.apache.org/proper/commons-rng/commons-rng-core/clirr-report.html <http://commons.apache.org/proper/commons-rng/commons-rng-core/clirr-report.html>
>  http://commons.apache.org/proper/commons-rng/commons-rng-simple/clirr-report.html <http://commons.apache.org/proper/commons-rng/commons-rng-simple/clirr-report.html>
>  http://commons.apache.org/proper/commons-rng/commons-rng-sampling/clirr-report.html <http://commons.apache.org/proper/commons-rng/commons-rng-sampling/clirr-report.html>
>
>> - JaCoCo Aggregate (this link jumps out of the 'frames' view an loses
>> the menu)
>
> Always was so.  Perhaps something to report here:
>  https://issues.apache.org/jira/projects/COMMONSSITE <https://issues.apache.org/jira/projects/COMMONSSITE>
> [Or a maven issue.]
>
>>
>> - Checkstyle
>>
>> There are no spotbugs or PMD entries in the menu.
>
> One per report per module, e.g.:
>  http://commons.apache.org/proper/commons-rng/commons-rng-core/spotbugs.html <http://commons.apache.org/proper/commons-rng/commons-rng-core/spotbugs.html>
>  http://commons.apache.org/proper/commons-rng/commons-rng-core/pmd.html <http://commons.apache.org/proper/commons-rng/commons-rng-core/pmd.html>
>
>>
>>
>> I'm not sure where to get the artifacts to check the hashes so I've
>> not done that.
>
> They are next to the files, here:
>  https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/binaries/ <https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/binaries/>
> and here:
>  https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/source/ <https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/source/>
>
>>
>>
>> The 'Project Documentation > Source Code Management' page states to use:
>>
>> git clone http://git-wip-us.apache.org/repos/asf/commons-rng.git <http://git-wip-us.apache.org/repos/asf/commons-rng.git>
>
> Odd.
> It works for me (TM). :-)
>
>> This doesn't work for me. I used the mirror and the RC tag:
>>
>> https://github.com/apache/commons-rng
>>
>>
>> Building with mvn verify site
>>
>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
>> 2018-06-17T19:33:14+01:00)
>> Maven home: /usr/local/apache-maven-3.5.4
>> Java version: 1.8.0_191, vendor: Oracle Corporation, runtime:
>> /usr/lib/jvm/java-8-openjdk-amd64/jre
>> Default locale: en_GB, platform encoding: UTF-8
>> OS name: "linux", version: "4.4.0-139-generic", arch: "amd64", family: "unix"
>>
>> This works but the local site is missing the same Project Reports.
>> The modules all have surefire reports, PMD, CPD, spotbugs, checkstyle
>> in the target directories. Not sure where japicmp writes plain results
>> but the japicmp.html page is always blank. So something is broken with
>> aggregating the reports and possibly the japicmp report.
>
> The command to generate the full site for a multi-module project is
>  $ mvn clean site site:stage
> and the site will be in subdirectory
>  target/staging"
> of the top-level directory.
>

Thanks for the reply there @Gilles. I’ll try to get to a validation today.

-Rob

>
> Thanks for the review,
> Gilles
>
>>
>> Alex
>>
>>
>> On 04/12/2018 01:19, Gilles wrote:
>>> Hello.
>>>
>>> I would like to release Apache Commons RNG v1.2.
>>>
>>> Apache Commons RNG 1.2 RC1 is available for review:
>>>     https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1 (svn revision 31333)
>>>
>>> The Git tag for this RC is "RNG_1_2_RC1":
>>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_2_RC1
>>>
>>> Maven artifacts:
>>> https://repository.apache.org/content/repositories/orgapachecommons-1397/org/apache/commons/
>>>
>>> Maven artifacts' SHA-512 hashes in Nexus:
>>> commons-rng-1.2-bin-tar.gz=beba8312f8702563b7d2a8b3919e812b60e509342fb102274b1fef8107c67d8419b74a82b7c6fd6fdfd9ed03cd590751a80ca27614cca2a909ba057e3c513ef7
>>> commons-rng-1.2-bin-tar.gz.asc=500c67f4c3c1fdc6583fab068f20664e7235e5f983dcc90c1c9d70290bf5eb3e4a76d7fb3eba56f4a3e8e957bf0c490db237698419c95e2dbca8716f393def4c
>>> commons-rng-1.2-src-tar.gz=a9325efec521ff3f3489fa67568bc91b5a89014c888d81d14a39e669cf678648ba60722e3f3320ad643d9e84ef3193f272bfd78b4495044b6a763a6442590a3f
>>> commons-rng-1.2-bin-zip=55342112a7e505882ad5739233508d2957c396f71bf22a45226844bf5ccdfb4947066a0fb111f1a51287ef359bdd1e84f9c7fdde7c3a02092b4cf45aa9eb3d99
>>> commons-rng-1.2-src-zip=f2d7dbabb1479afd15adae00e9007480638d7c8b5a2900d1d43ec7497efd8f2a0a66bc84032c642de6b3ecf0829a01d3c6748e583b43476f4f36466667fe2292
>>> commons-rng-1.2-src-zip.asc=e931a42202b3ba274ca07251d8114066c88085014823c421b0cba15c300596aad1d7a7c7f42f85fe0e62cfa3ab4dd4a7afd32ab18149d42e5e775c9c2bf0e187
>>> commons-rng-1.2-pom.asc=4c9ebbb00fbc1b7f7a679c1f165fc6561ad69fd5e7ec2b268d89c26053643a9574ac69876d47cc8e1a27f595010a6466c4f679518ee7dec5b9c250a5a4720089
>>> commons-rng-1.2-bin-zip.asc=30e72114890ad6551fb2dc21251d787cf7410d22c92960375d2bfc8586279d1981261af74ce9477313bd1dac4ee632d94100c0db6340a216e385c947b491f432
>>> commons-rng-1.2-src-tar.gz.asc=e1a04875744dc3cd5b04bfbe5c6fa52e553ecc645c5923db53259202daf28f5fd8570c84a9fcb0ae10669a0924101d4d737ca23fb9cbcd4da7f708ce67c6b5f8
>>>
>>> Details of changes:
>>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/RELEASE-NOTES.txt
>>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/changes-report.html
>>>
>>> Site:
>>>     http://commons.apache.org/proper/commons-rng/
>>>
>>> KEYS:
>>>    id=B39617E095CD748DFE505816703413011E22D5B8
>>>    https://www.apache.org/dist/commons/KEYS
>>>
>>> Please review the release candidate and vote.
>>> This vote will close no sooner that 72 hours from now.
>>>
>>>   [ ] +1 Release these artifacts
>>>   [ ] +0 OK, but...
>>>   [ ] -0 OK, but really should fix...
>>>   [ ] -1 I oppose this release because...
>>>
>>> Thanks,
>>> Gilles
>>>
>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Vote] Release Apache Commons RNG v1.2 (RC1)

Alex Herbert
In reply to this post by Alex Herbert
On 04/12/2018 14:08, Alex Herbert wrote:
>
> The user guide shows updated Performance and Quality tables following
> the changes to the core implementation for all tables (verses release
> 1.1). I note that the times for the BoxMullerNormalizedGaussianSampler
> have all improved nearly 2-fold which is strange. The code appears to
> be unchanged from v1.1.
>
I should have said that the updated Performance and Quality tables was
expected since the core library was modified for this release. I was
expecting (and there is) a big change in the the generating boolean and
int values tables. V1.2 has a new implementation of these methods in the
core module. However the change to the speed of the
BoxMullerNormalizedGaussianSampler is unexpected.

Alex



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Vote] Release Apache Commons RNG v1.2 (RC1)

Gilles Sadowski
In reply to this post by Rob Tompkins
On Tue, 4 Dec 2018 09:11:44 -0500, Rob Tompkins wrote:
> I’ll try to get to validation on this by the end of the day,

Thanks!

> unless
> @Gilles, you want to take into account the vote below.

I don't think anything mentioned is blocking (cf. my answer
in the other post).

[Hmm, it mostly stems from the release-plugin not being
robust yet when applied to a multi-module project, missing
(cf. generated "vote.txt") or unexpected conditions (it uses
default values where it shouldn't).  It also lacks reporting
adequate error messages when something goes wrong like SVN
authentication (1.5-SNAPSHOT is better!).].

So, please, do review the contents of the official release.

Regards,
Gilles

>
> -Rob
>
>> On Dec 4, 2018, at 9:08 AM, Alex Herbert <[hidden email]>
>> wrote:
>>
>> +0 (non-binding)
>>
>>
>> The user guide shows updated Performance and Quality tables
>> following the changes to the core implementation for all tables
>> (verses release 1.1). I note that the times for the
>> BoxMullerNormalizedGaussianSampler have all improved nearly 2-fold
>> which is strange. The code appears to be unchanged from v1.1.
>>
>>
>> The RC site:
>>
>>
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/userguide/rng.html
>>
>> Is also showing at the official location:
>>
>> http://commons.apache.org/proper/commons-rng/
>>
>> This link is broken from the 'Release History' page:
>>
>>
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/release-notes/RELEASE-NOTES-1.2.txt
>>
>>
>> The following reports are empty in the Project Reports menu:
>>
>> - Surefire Report
>>
>> - japicmp
>>
>> - JaCoCo Aggregate (this link jumps out of the 'frames' view an
>> loses the menu)
>>
>> - Checkstyle
>>
>> There are no spotbugs or PMD entries in the menu.
>>
>>
>> I'm not sure where to get the artifacts to check the hashes so I've
>> not done that.
>>
>>
>> The 'Project Documentation > Source Code Management' page states to
>> use:
>>
>> git clone http://git-wip-us.apache.org/repos/asf/commons-rng.git
>>
>> This doesn't work for me. I used the mirror and the RC tag:
>>
>> https://github.com/apache/commons-rng
>>
>>
>> Building with mvn verify site
>>
>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
>> 2018-06-17T19:33:14+01:00)
>> Maven home: /usr/local/apache-maven-3.5.4
>> Java version: 1.8.0_191, vendor: Oracle Corporation, runtime:
>> /usr/lib/jvm/java-8-openjdk-amd64/jre
>> Default locale: en_GB, platform encoding: UTF-8
>> OS name: "linux", version: "4.4.0-139-generic", arch: "amd64",
>> family: "unix"
>>
>> This works but the local site is missing the same Project Reports.
>> The modules all have surefire reports, PMD, CPD, spotbugs, checkstyle
>> in the target directories. Not sure where japicmp writes plain results
>> but the japicmp.html page is always blank. So something is broken with
>> aggregating the reports and possibly the japicmp report.
>>
>> Alex
>>
>>
>> On 04/12/2018 01:19, Gilles wrote:
>>> Hello.
>>>
>>> I would like to release Apache Commons RNG v1.2.
>>>
>>> Apache Commons RNG 1.2 RC1 is available for review:
>>>     https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1 (svn
>>> revision 31333)
>>>
>>> The Git tag for this RC is "RNG_1_2_RC1":
>>>
>>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_2_RC1
>>>
>>> Maven artifacts:
>>>
>>> https://repository.apache.org/content/repositories/orgapachecommons-1397/org/apache/commons/
>>>
>>> Maven artifacts' SHA-512 hashes in Nexus:
>>>
>>> commons-rng-1.2-bin-tar.gz=beba8312f8702563b7d2a8b3919e812b60e509342fb102274b1fef8107c67d8419b74a82b7c6fd6fdfd9ed03cd590751a80ca27614cca2a909ba057e3c513ef7
>>>
>>> commons-rng-1.2-bin-tar.gz.asc=500c67f4c3c1fdc6583fab068f20664e7235e5f983dcc90c1c9d70290bf5eb3e4a76d7fb3eba56f4a3e8e957bf0c490db237698419c95e2dbca8716f393def4c
>>>
>>> commons-rng-1.2-src-tar.gz=a9325efec521ff3f3489fa67568bc91b5a89014c888d81d14a39e669cf678648ba60722e3f3320ad643d9e84ef3193f272bfd78b4495044b6a763a6442590a3f
>>>
>>> commons-rng-1.2-bin-zip=55342112a7e505882ad5739233508d2957c396f71bf22a45226844bf5ccdfb4947066a0fb111f1a51287ef359bdd1e84f9c7fdde7c3a02092b4cf45aa9eb3d99
>>>
>>> commons-rng-1.2-src-zip=f2d7dbabb1479afd15adae00e9007480638d7c8b5a2900d1d43ec7497efd8f2a0a66bc84032c642de6b3ecf0829a01d3c6748e583b43476f4f36466667fe2292
>>>
>>> commons-rng-1.2-src-zip.asc=e931a42202b3ba274ca07251d8114066c88085014823c421b0cba15c300596aad1d7a7c7f42f85fe0e62cfa3ab4dd4a7afd32ab18149d42e5e775c9c2bf0e187
>>>
>>> commons-rng-1.2-pom.asc=4c9ebbb00fbc1b7f7a679c1f165fc6561ad69fd5e7ec2b268d89c26053643a9574ac69876d47cc8e1a27f595010a6466c4f679518ee7dec5b9c250a5a4720089
>>>
>>> commons-rng-1.2-bin-zip.asc=30e72114890ad6551fb2dc21251d787cf7410d22c92960375d2bfc8586279d1981261af74ce9477313bd1dac4ee632d94100c0db6340a216e385c947b491f432
>>>
>>> commons-rng-1.2-src-tar.gz.asc=e1a04875744dc3cd5b04bfbe5c6fa52e553ecc645c5923db53259202daf28f5fd8570c84a9fcb0ae10669a0924101d4d737ca23fb9cbcd4da7f708ce67c6b5f8
>>>
>>> Details of changes:
>>>
>>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/RELEASE-NOTES.txt
>>>
>>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/changes-report.html
>>>
>>> Site:
>>>     http://commons.apache.org/proper/commons-rng/
>>>
>>> KEYS:
>>>    id=B39617E095CD748DFE505816703413011E22D5B8
>>>    https://www.apache.org/dist/commons/KEYS
>>>
>>> Please review the release candidate and vote.
>>> This vote will close no sooner that 72 hours from now.
>>>
>>>   [ ] +1 Release these artifacts
>>>   [ ] +0 OK, but...
>>>   [ ] -0 OK, but really should fix...
>>>   [ ] -1 I oppose this release because...
>>>
>>> Thanks,
>>> Gilles
>>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Vote] Release Apache Commons RNG v1.2 (RC1)

Alex Herbert
In reply to this post by Gilles Sadowski
On 04/12/2018 15:15, Gilles wrote:

> On Tue, 4 Dec 2018 14:08:59 +0000, Alex Herbert wrote:
>> +0 (non-binding)
>>
>>
>> The user guide shows updated Performance and Quality tables following
>> the changes to the core implementation for all tables (verses release
>> 1.1). I note that the times for the BoxMullerNormalizedGaussianSampler
>> have all improved nearly 2-fold which is strange.
>
> Agreed.  But I can't say much more.  You are welcome to
> confirm that either the current or the previous values
> (or neither) are correct.
> And we'll update the site accordingly.

OK. I ran a quick trial of SamplersPerformance and it seems that the
BoxMullerNormalizedGaussianSampler should be slower than the others.
This matches the old results.

commons-rng/commons-rng-examples/examples-jmh > mvn -P benchmark
'-Dbenchmark=org.apache.commons.rng.examples.jmh.distribution.(Next*|SamplersPerformance.*Gaussian.*)'
test

Here are the results with 5 iterations:

RNG BoxMuller Marsaglia Ziggurat
ISAAC 0.9507838314 0.5394285144 0.2749968235
JDK 1.0688682596 0.6440317765 0.3243021893
KISS 0.9858236618 0.4700058858 0.2568217134
MT 1.0275424389 0.5268759359 0.2690456029
MT_64 0.8826816707 0.4557104478 0.2296754309
MWC_256 0.9507522353 0.4196383302 0.2114958789
SPLIT_MIX_64 0.8377382444 0.3617303709 0.1846275404
TWO_CMRES 0.8536155368 0.387562567 0.1884355236
WELL_1024_A 1.0855815254 0.5994046678 0.3088309612
WELL_19937_A 1.1350548335 0.6718304685 0.3952235947
WELL_19937_C 1.1518394142 0.6985743497 0.419527361
WELL_44497_A 1.1535128658 0.6958294048 0.4177399342
WELL_44497_B 1.1679061263 0.7237524243 0.4451146416
WELL_512_A 1.0579604922 0.5813859004 0.2975178907
XOR_SHIFT_1024_S 0.8405457368 0.3765978036 0.2007193048

I'll run the benchmark with more iterations...


Thanks for the clarifications about the reports being in the modules. It
is not obvious from the site. Now I've found them they look OK.

> They are next to the files, here:
> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/binaries/
> and here:
> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/source/
>
Downloaded and checked with gpg and sha512sum. All OK.

>> The 'Project Documentation > Source Code Management' page states to use:
>>
>> git clone http://git-wip-us.apache.org/repos/asf/commons-rng.git
>
> Odd.
> It works for me (TM). :-)

It now works for me too.

> The command to generate the full site for a multi-module project is
>   $ mvn clean site site:stage

Now I've found the module reports the local build looks good too.

Alex


Reply | Threaded
Open this post in threaded view
|

Re: [Vote] Release Apache Commons RNG v1.2 (RC1)

Alex Herbert
Results with 20 iterations:

RNG BoxMuller Marsaglia Ziggurat
ISAAC 0.948779993 0.5329378639 0.2799722904
JDK 1.0652839179 0.6410808496 0.3241359248
KISS 0.9857074339 0.4701037867 0.2574427254
MT 1.0288632336 0.5435846638 0.2935301968
MT_64 0.8824667687 0.4527381257 0.229167355
MWC_256 0.9503164333 0.4198549403 0.2117029629
SPLIT_MIX_64 0.8292249862 0.3615338019 0.1846202863
TWO_CMRES 0.85410102 0.385108558 0.1890249596
WELL_1024_A 1.0570756626 0.6787334034 0.3103621636
WELL_19937_A 1.1364874655 0.6674927603 0.4502170135
WELL_19937_C 1.1592364448 0.6983919657 0.4394263817
WELL_44497_A 1.1428982491 0.6881823457 0.4167840692
WELL_44497_B 1.1668242588 0.7234619929 0.4434243829
WELL_512_A 1.0022559778 0.6041361633 0.3109955059
XOR_SHIFT_1024_S 0.8383297298 0.3819338707 0.1975575019

This is more in-line with the results from V1.1. So the current results
in the RC do not match this.

Alex

Reply | Threaded
Open this post in threaded view
|

Re: [Vote] Release Apache Commons RNG v1.2 (RC1)

Gilles Sadowski
In reply to this post by Alex Herbert
On Tue, 4 Dec 2018 16:33:48 +0000, Alex Herbert wrote:

> On 04/12/2018 15:15, Gilles wrote:
>> On Tue, 4 Dec 2018 14:08:59 +0000, Alex Herbert wrote:
>>> +0 (non-binding)
>>>
>>>
>>> The user guide shows updated Performance and Quality tables
>>> following
>>> the changes to the core implementation for all tables (verses
>>> release
>>> 1.1). I note that the times for the
>>> BoxMullerNormalizedGaussianSampler
>>> have all improved nearly 2-fold which is strange.
>>
>> Agreed.  But I can't say much more.  You are welcome to
>> confirm that either the current or the previous values
>> (or neither) are correct.
>> And we'll update the site accordingly.
>
> OK. I ran a quick trial of SamplersPerformance and it seems that the
> BoxMullerNormalizedGaussianSampler should be slower than the others.
> This matches the old results.
>
> commons-rng/commons-rng-examples/examples-jmh > mvn -P benchmark
>
> '-Dbenchmark=org.apache.commons.rng.examples.jmh.distribution.(Next*|SamplersPerformance.*Gaussian.*)'
> test
>
> Here are the results with 5 iterations:
>
> RNG BoxMuller Marsaglia Ziggurat
> ISAAC 0.9507838314 0.5394285144 0.2749968235
> JDK 1.0688682596 0.6440317765 0.3243021893
> KISS 0.9858236618 0.4700058858 0.2568217134
> MT 1.0275424389 0.5268759359 0.2690456029
> MT_64 0.8826816707 0.4557104478 0.2296754309
> MWC_256 0.9507522353 0.4196383302 0.2114958789
> SPLIT_MIX_64 0.8377382444 0.3617303709 0.1846275404
> TWO_CMRES 0.8536155368 0.387562567 0.1884355236
> WELL_1024_A 1.0855815254 0.5994046678 0.3088309612
> WELL_19937_A 1.1350548335 0.6718304685 0.3952235947
> WELL_19937_C 1.1518394142 0.6985743497 0.419527361
> WELL_44497_A 1.1535128658 0.6958294048 0.4177399342
> WELL_44497_B 1.1679061263 0.7237524243 0.4451146416
> WELL_512_A 1.0579604922 0.5813859004 0.2975178907
> XOR_SHIFT_1024_S 0.8405457368 0.3765978036 0.2007193048
>
> I'll run the benchmark with more iterations...

I was in fact running Java 10 for the benchmarks: "BoxMuller" is indeed
50% faster on it than on Java 8 and "Marsaglia" 10% slower!

>
> Thanks for the clarifications about the reports being in the modules.
> It is not obvious from the site. Now I've found them they look OK.

So, you'll change your vote?

Regards,
Gilles

>
>> They are next to the files, here:
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/binaries/
>> and here:
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/source/
>>
> Downloaded and checked with gpg and sha512sum. All OK.
>
>>> The 'Project Documentation > Source Code Management' page states to
>>> use:
>>>
>>> git clone http://git-wip-us.apache.org/repos/asf/commons-rng.git
>>
>> Odd.
>> It works for me (TM). :-)
>
> It now works for me too.
>
>> The command to generate the full site for a multi-module project is
>>   $ mvn clean site site:stage
>
> Now I've found the module reports the local build looks good too.
>
> Alex


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Vote] Release Apache Commons RNG v1.2 (RC1)

Alex Herbert
On 04/12/2018 22:29, Gilles wrote:
>
> I was in fact running Java 10 for the benchmarks: "BoxMuller" is indeed
> 50% faster on it than on Java 8 and "Marsaglia" 10% slower!
>
Interesting. Given the relative popularity of Java 10 vs 8 (Java 10 was
only out in March 2018 and usage statistics are unknown on various
summary surveys) I suggest either (a) stating the benchmark was done on
Java 10, or (b) changing back to the Java 8 benchmark.

Note that the detail at the top of the 'User Guide > 4. Performance'
section states OpenJDK 1.8 was used.

> So, you'll change your vote?
>
Yes. +1 (non binding)



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Vote] Release Apache Commons RNG v1.2 (RC1)

Rob Tompkins
In reply to this post by Gilles Sadowski
With:

$ mvn -version
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T14:33:14-04:00)
Maven home: /usr/local/Cellar/maven/3.5.4/libexec
Java version: 9.0.4, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.14.1", arch: "x86_64", family: "mac"

I get this:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on project commons-rng-sampling: Error generating maven-javadoc-plugin:3.0.1:javadoc report:
[ERROR] Exit code: 1 - /Users/tompkicr/Desktop/commons-rng/source/commons-rng-1.2-src/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/SmallMeanPoissonSampler.java:35: error: reference not found
[ERROR]  * For large means, {@link LargePoissonSampler} should be used instead.
[ERROR]                            ^
[ERROR]
[ERROR] Command line was: /Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home/bin/javadoc @options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in '/Users/tompkicr/Desktop/commons-rng/source/commons-rng-1.2-src/commons-rng-sampling/target/site/apidocs' dir.

> On Dec 3, 2018, at 8:19 PM, Gilles <[hidden email]> wrote:
>
> Hello.
>
> I would like to release Apache Commons RNG v1.2.
>
> Apache Commons RNG 1.2 RC1 is available for review:
>    https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1 (svn revision 31333)
>
> The Git tag for this RC is "RNG_1_2_RC1":
>    https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_2_RC1
>
> Maven artifacts:
>    https://repository.apache.org/content/repositories/orgapachecommons-1397/org/apache/commons/
>
> Maven artifacts' SHA-512 hashes in Nexus:
>    commons-rng-1.2-bin-tar.gz=beba8312f8702563b7d2a8b3919e812b60e509342fb102274b1fef8107c67d8419b74a82b7c6fd6fdfd9ed03cd590751a80ca27614cca2a909ba057e3c513ef7
>    commons-rng-1.2-bin-tar.gz.asc=500c67f4c3c1fdc6583fab068f20664e7235e5f983dcc90c1c9d70290bf5eb3e4a76d7fb3eba56f4a3e8e957bf0c490db237698419c95e2dbca8716f393def4c
>    commons-rng-1.2-src-tar.gz=a9325efec521ff3f3489fa67568bc91b5a89014c888d81d14a39e669cf678648ba60722e3f3320ad643d9e84ef3193f272bfd78b4495044b6a763a6442590a3f
>    commons-rng-1.2-bin-zip=55342112a7e505882ad5739233508d2957c396f71bf22a45226844bf5ccdfb4947066a0fb111f1a51287ef359bdd1e84f9c7fdde7c3a02092b4cf45aa9eb3d99
>    commons-rng-1.2-src-zip=f2d7dbabb1479afd15adae00e9007480638d7c8b5a2900d1d43ec7497efd8f2a0a66bc84032c642de6b3ecf0829a01d3c6748e583b43476f4f36466667fe2292
>    commons-rng-1.2-src-zip.asc=e931a42202b3ba274ca07251d8114066c88085014823c421b0cba15c300596aad1d7a7c7f42f85fe0e62cfa3ab4dd4a7afd32ab18149d42e5e775c9c2bf0e187
>    commons-rng-1.2-pom.asc=4c9ebbb00fbc1b7f7a679c1f165fc6561ad69fd5e7ec2b268d89c26053643a9574ac69876d47cc8e1a27f595010a6466c4f679518ee7dec5b9c250a5a4720089
>    commons-rng-1.2-bin-zip.asc=30e72114890ad6551fb2dc21251d787cf7410d22c92960375d2bfc8586279d1981261af74ce9477313bd1dac4ee632d94100c0db6340a216e385c947b491f432
>    commons-rng-1.2-src-tar.gz.asc=e1a04875744dc3cd5b04bfbe5c6fa52e553ecc645c5923db53259202daf28f5fd8570c84a9fcb0ae10669a0924101d4d737ca23fb9cbcd4da7f708ce67c6b5f8
>
> Details of changes:
>    https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/RELEASE-NOTES.txt
>    https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/changes-report.html
>
> Site:
>    http://commons.apache.org/proper/commons-rng/
>
> KEYS:
>   id=B39617E095CD748DFE505816703413011E22D5B8
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>  [ ] +1 Release these artifacts
>  [ ] +0 OK, but...
>  [ ] -0 OK, but really should fix...
>  [ ] -1 I oppose this release because...
>
> Thanks,
> Gilles
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Vote] Release Apache Commons RNG v1.2 (RC1)

Gilles Sadowski
On Wed, 5 Dec 2018 21:29:26 -0500, Rob Tompkins wrote:

> With:
>
> $ mvn -version
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T14:33:14-04:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 9.0.4, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.14.1", arch: "x86_64", family:
> "mac"
>
> I get this:
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site)
> on project commons-rng-sampling: Error generating
> maven-javadoc-plugin:3.0.1:javadoc report:
> [ERROR] Exit code: 1 -
>
> /Users/tompkicr/Desktop/commons-rng/source/commons-rng-1.2-src/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/SmallMeanPoissonSampler.java:35:
> error: reference not found
> [ERROR]  * For large means, {@link LargePoissonSampler} should be
> used instead.

This is a type in the Javadoc (should have been
"LargeMeanPoissonSampler", fixed now).
In my environment, it only triggered a warning.
Does the policy consider this as a blocker?

Gilles

> [ERROR]                            ^
> [ERROR]
> [ERROR] Command line was:
>
> /Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home/bin/javadoc
> @options @packages
> [ERROR]
> [ERROR] Refer to the generated Javadoc files in
>
> '/Users/tompkicr/Desktop/commons-rng/source/commons-rng-1.2-src/commons-rng-sampling/target/site/apidocs'
> dir.
>
>> On Dec 3, 2018, at 8:19 PM, Gilles <[hidden email]>
>> wrote:
>>
>> Hello.
>>
>> I would like to release Apache Commons RNG v1.2.
>>
>> Apache Commons RNG 1.2 RC1 is available for review:
>>    https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1 (svn
>> revision 31333)
>>
>> The Git tag for this RC is "RNG_1_2_RC1":
>>    
>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_2_RC1
>>
>> Maven artifacts:
>>    
>> https://repository.apache.org/content/repositories/orgapachecommons-1397/org/apache/commons/
>>
>> Maven artifacts' SHA-512 hashes in Nexus:
>>    
>> commons-rng-1.2-bin-tar.gz=beba8312f8702563b7d2a8b3919e812b60e509342fb102274b1fef8107c67d8419b74a82b7c6fd6fdfd9ed03cd590751a80ca27614cca2a909ba057e3c513ef7
>>    
>> commons-rng-1.2-bin-tar.gz.asc=500c67f4c3c1fdc6583fab068f20664e7235e5f983dcc90c1c9d70290bf5eb3e4a76d7fb3eba56f4a3e8e957bf0c490db237698419c95e2dbca8716f393def4c
>>    
>> commons-rng-1.2-src-tar.gz=a9325efec521ff3f3489fa67568bc91b5a89014c888d81d14a39e669cf678648ba60722e3f3320ad643d9e84ef3193f272bfd78b4495044b6a763a6442590a3f
>>    
>> commons-rng-1.2-bin-zip=55342112a7e505882ad5739233508d2957c396f71bf22a45226844bf5ccdfb4947066a0fb111f1a51287ef359bdd1e84f9c7fdde7c3a02092b4cf45aa9eb3d99
>>    
>> commons-rng-1.2-src-zip=f2d7dbabb1479afd15adae00e9007480638d7c8b5a2900d1d43ec7497efd8f2a0a66bc84032c642de6b3ecf0829a01d3c6748e583b43476f4f36466667fe2292
>>    
>> commons-rng-1.2-src-zip.asc=e931a42202b3ba274ca07251d8114066c88085014823c421b0cba15c300596aad1d7a7c7f42f85fe0e62cfa3ab4dd4a7afd32ab18149d42e5e775c9c2bf0e187
>>    
>> commons-rng-1.2-pom.asc=4c9ebbb00fbc1b7f7a679c1f165fc6561ad69fd5e7ec2b268d89c26053643a9574ac69876d47cc8e1a27f595010a6466c4f679518ee7dec5b9c250a5a4720089
>>    
>> commons-rng-1.2-bin-zip.asc=30e72114890ad6551fb2dc21251d787cf7410d22c92960375d2bfc8586279d1981261af74ce9477313bd1dac4ee632d94100c0db6340a216e385c947b491f432
>>    
>> commons-rng-1.2-src-tar.gz.asc=e1a04875744dc3cd5b04bfbe5c6fa52e553ecc645c5923db53259202daf28f5fd8570c84a9fcb0ae10669a0924101d4d737ca23fb9cbcd4da7f708ce67c6b5f8
>>
>> Details of changes:
>>    
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/RELEASE-NOTES.txt
>>    
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/changes-report.html
>>
>> Site:
>>    http://commons.apache.org/proper/commons-rng/
>>
>> KEYS:
>>   id=B39617E095CD748DFE505816703413011E22D5B8
>>   https://www.apache.org/dist/commons/KEYS
>>
>> Please review the release candidate and vote.
>> This vote will close no sooner that 72 hours from now.
>>
>>  [ ] +1 Release these artifacts
>>  [ ] +0 OK, but...
>>  [ ] -0 OK, but really should fix...
>>  [ ] -1 I oppose this release because...
>>
>> Thanks,
>> Gilles


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Vote] Release Apache Commons RNG v1.2 (RC1)

sebb-2-2
On Thu, 6 Dec 2018 at 10:58, Gilles <[hidden email]> wrote:

>
> On Wed, 5 Dec 2018 21:29:26 -0500, Rob Tompkins wrote:
> > With:
> >
> > $ mvn -version
> > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> > 2018-06-17T14:33:14-04:00)
> > Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> > Java version: 9.0.4, vendor: Oracle Corporation, runtime:
> > /Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "mac os x", version: "10.14.1", arch: "x86_64", family:
> > "mac"
> >
> > I get this:
> >
> > [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site)
> > on project commons-rng-sampling: Error generating
> > maven-javadoc-plugin:3.0.1:javadoc report:
> > [ERROR] Exit code: 1 -
> >
> > /Users/tompkicr/Desktop/commons-rng/source/commons-rng-1.2-src/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/SmallMeanPoissonSampler.java:35:
> > error: reference not found
> > [ERROR]  * For large means, {@link LargePoissonSampler} should be
> > used instead.
>
> This is a type in the Javadoc (should have been
> "LargeMeanPoissonSampler", fixed now).
> In my environment, it only triggered a warning.
> Does the policy consider this as a blocker?

I don't think Javadoc errors are blockers per se, however a failing
build seems to me like a blocker unless there are extenutating
circumstances.
For example a very rarely used JVM/OS combination.

Whilst it may be tedious to fix this, if we don't, there are likely to
be ongoing complaints about the issue that will have to be dealt with,
possibly causing more work overall.

> Gilles
>
> > [ERROR]                            ^
> > [ERROR]
> > [ERROR] Command line was:
> >
> > /Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home/bin/javadoc
> > @options @packages
> > [ERROR]
> > [ERROR] Refer to the generated Javadoc files in
> >
> > '/Users/tompkicr/Desktop/commons-rng/source/commons-rng-1.2-src/commons-rng-sampling/target/site/apidocs'
> > dir.
> >
> >> On Dec 3, 2018, at 8:19 PM, Gilles <[hidden email]>
> >> wrote:
> >>
> >> Hello.
> >>
> >> I would like to release Apache Commons RNG v1.2.
> >>
> >> Apache Commons RNG 1.2 RC1 is available for review:
> >>    https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1 (svn
> >> revision 31333)
> >>
> >> The Git tag for this RC is "RNG_1_2_RC1":
> >>
> >> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_2_RC1
> >>
> >> Maven artifacts:
> >>
> >> https://repository.apache.org/content/repositories/orgapachecommons-1397/org/apache/commons/
> >>
> >> Maven artifacts' SHA-512 hashes in Nexus:
> >>
> >> commons-rng-1.2-bin-tar.gz=beba8312f8702563b7d2a8b3919e812b60e509342fb102274b1fef8107c67d8419b74a82b7c6fd6fdfd9ed03cd590751a80ca27614cca2a909ba057e3c513ef7
> >>
> >> commons-rng-1.2-bin-tar.gz.asc=500c67f4c3c1fdc6583fab068f20664e7235e5f983dcc90c1c9d70290bf5eb3e4a76d7fb3eba56f4a3e8e957bf0c490db237698419c95e2dbca8716f393def4c
> >>
> >> commons-rng-1.2-src-tar.gz=a9325efec521ff3f3489fa67568bc91b5a89014c888d81d14a39e669cf678648ba60722e3f3320ad643d9e84ef3193f272bfd78b4495044b6a763a6442590a3f
> >>
> >> commons-rng-1.2-bin-zip=55342112a7e505882ad5739233508d2957c396f71bf22a45226844bf5ccdfb4947066a0fb111f1a51287ef359bdd1e84f9c7fdde7c3a02092b4cf45aa9eb3d99
> >>
> >> commons-rng-1.2-src-zip=f2d7dbabb1479afd15adae00e9007480638d7c8b5a2900d1d43ec7497efd8f2a0a66bc84032c642de6b3ecf0829a01d3c6748e583b43476f4f36466667fe2292
> >>
> >> commons-rng-1.2-src-zip.asc=e931a42202b3ba274ca07251d8114066c88085014823c421b0cba15c300596aad1d7a7c7f42f85fe0e62cfa3ab4dd4a7afd32ab18149d42e5e775c9c2bf0e187
> >>
> >> commons-rng-1.2-pom.asc=4c9ebbb00fbc1b7f7a679c1f165fc6561ad69fd5e7ec2b268d89c26053643a9574ac69876d47cc8e1a27f595010a6466c4f679518ee7dec5b9c250a5a4720089
> >>
> >> commons-rng-1.2-bin-zip.asc=30e72114890ad6551fb2dc21251d787cf7410d22c92960375d2bfc8586279d1981261af74ce9477313bd1dac4ee632d94100c0db6340a216e385c947b491f432
> >>
> >> commons-rng-1.2-src-tar.gz.asc=e1a04875744dc3cd5b04bfbe5c6fa52e553ecc645c5923db53259202daf28f5fd8570c84a9fcb0ae10669a0924101d4d737ca23fb9cbcd4da7f708ce67c6b5f8
> >>
> >> Details of changes:
> >>
> >> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/RELEASE-NOTES.txt
> >>
> >> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/changes-report.html
> >>
> >> Site:
> >>    http://commons.apache.org/proper/commons-rng/
> >>
> >> KEYS:
> >>   id=B39617E095CD748DFE505816703413011E22D5B8
> >>   https://www.apache.org/dist/commons/KEYS
> >>
> >> Please review the release candidate and vote.
> >> This vote will close no sooner that 72 hours from now.
> >>
> >>  [ ] +1 Release these artifacts
> >>  [ ] +0 OK, but...
> >>  [ ] -0 OK, but really should fix...
> >>  [ ] -1 I oppose this release because...
> >>
> >> Thanks,
> >> Gilles
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Vote] Release Apache Commons RNG v1.2 (RC1)

Gilles Sadowski
On Thu, 6 Dec 2018 11:37:25 +0000, sebb wrote:

> On Thu, 6 Dec 2018 at 10:58, Gilles <[hidden email]>
> wrote:
>>
>> On Wed, 5 Dec 2018 21:29:26 -0500, Rob Tompkins wrote:
>> > With:
>> >
>> > $ mvn -version
>> > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
>> > 2018-06-17T14:33:14-04:00)
>> > Maven home: /usr/local/Cellar/maven/3.5.4/libexec
>> > Java version: 9.0.4, vendor: Oracle Corporation, runtime:
>> > /Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home
>> > Default locale: en_US, platform encoding: UTF-8
>> > OS name: "mac os x", version: "10.14.1", arch: "x86_64", family:
>> > "mac"
>> >
>> > I get this:
>> >
>> > [ERROR] Failed to execute goal
>> > org.apache.maven.plugins:maven-site-plugin:3.7.1:site
>> (default-site)
>> > on project commons-rng-sampling: Error generating
>> > maven-javadoc-plugin:3.0.1:javadoc report:
>> > [ERROR] Exit code: 1 -
>> >
>> >
>> /Users/tompkicr/Desktop/commons-rng/source/commons-rng-1.2-src/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/SmallMeanPoissonSampler.java:35:
>> > error: reference not found
>> > [ERROR]  * For large means, {@link LargePoissonSampler} should be
>> > used instead.
>>
>> This is a type in the Javadoc (should have been
>> "LargeMeanPoissonSampler", fixed now).
>> In my environment, it only triggered a warning.
>> Does the policy consider this as a blocker?
>
> I don't think Javadoc errors are blockers per se, however a failing
> build seems to me like a blocker unless there are extenutating
> circumstances.
> For example a very rarely used JVM/OS combination.
>
> Whilst it may be tedious to fix this, if we don't, there are likely
> to
> be ongoing complaints about the issue that will have to be dealt
> with,
> possibly causing more work overall.

OK.  I'll make a new RC.

But the thing is, although we expect support from
automated/reproducible
build (through common maven config), every time we advocate/work
towards
a single way to manage Commons projects, the discussion dies off with
TMTOWTDI.[1]
In my experience, this is what makes it painful to handle releases (for
manager and reviewers alike).[2]
The extenuating circumstance is that we don't want to enforce
convergence
of the release process, and then complain that it is tedious... :-}

Regards,
Gilles

[1] https://en.wiktionary.org/wiki/TMTOWTDI#English
[2] And also the Jenkins configuration (that now seem to break with
     every update of the CI system and/or POM upgrade).

>
>> [...]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Vote] Release Apache Commons RNG v1.2 (RC1)

Rob Tompkins
In reply to this post by sebb-2-2


> On Dec 6, 2018, at 6:37 AM, sebb <[hidden email]> wrote:
>
>> On Thu, 6 Dec 2018 at 10:58, Gilles <[hidden email]> wrote:
>>
>>> On Wed, 5 Dec 2018 21:29:26 -0500, Rob Tompkins wrote:
>>> With:
>>>
>>> $ mvn -version
>>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
>>> 2018-06-17T14:33:14-04:00)
>>> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
>>> Java version: 9.0.4, vendor: Oracle Corporation, runtime:
>>> /Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home
>>> Default locale: en_US, platform encoding: UTF-8
>>> OS name: "mac os x", version: "10.14.1", arch: "x86_64", family:
>>> "mac"
>>>
>>> I get this:
>>>
>>> [ERROR] Failed to execute goal
>>> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site)
>>> on project commons-rng-sampling: Error generating
>>> maven-javadoc-plugin:3.0.1:javadoc report:
>>> [ERROR] Exit code: 1 -
>>>
>>> /Users/tompkicr/Desktop/commons-rng/source/commons-rng-1.2-src/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/SmallMeanPoissonSampler.java:35:
>>> error: reference not found
>>> [ERROR]  * For large means, {@link LargePoissonSampler} should be
>>> used instead.
>>
>> This is a type in the Javadoc (should have been
>> "LargeMeanPoissonSampler", fixed now).
>> In my environment, it only triggered a warning.
>> Does the policy consider this as a blocker?
>
> I don't think Javadoc errors are blockers per se, however a failing
> build seems to me like a blocker unless there are extenutating
> circumstances.
> For example a very rarely used JVM/OS combination.
>
> Whilst it may be tedious to fix this, if we don't, there are likely to
> be ongoing complaints about the issue that will have to be dealt with,
> possibly causing more work overall.
>

@Sebb - many thanks for the insights.

@Gilles, thoughts?

-Rob

>> Gilles
>>
>>> [ERROR]                            ^
>>> [ERROR]
>>> [ERROR] Command line was:
>>>
>>> /Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home/bin/javadoc
>>> @options @packages
>>> [ERROR]
>>> [ERROR] Refer to the generated Javadoc files in
>>>
>>> '/Users/tompkicr/Desktop/commons-rng/source/commons-rng-1.2-src/commons-rng-sampling/target/site/apidocs'
>>> dir.
>>>
>>>> On Dec 3, 2018, at 8:19 PM, Gilles <[hidden email]>
>>>> wrote:
>>>>
>>>> Hello.
>>>>
>>>> I would like to release Apache Commons RNG v1.2.
>>>>
>>>> Apache Commons RNG 1.2 RC1 is available for review:
>>>>   https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1 (svn
>>>> revision 31333)
>>>>
>>>> The Git tag for this RC is "RNG_1_2_RC1":
>>>>
>>>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_2_RC1
>>>>
>>>> Maven artifacts:
>>>>
>>>> https://repository.apache.org/content/repositories/orgapachecommons-1397/org/apache/commons/
>>>>
>>>> Maven artifacts' SHA-512 hashes in Nexus:
>>>>
>>>> commons-rng-1.2-bin-tar.gz=beba8312f8702563b7d2a8b3919e812b60e509342fb102274b1fef8107c67d8419b74a82b7c6fd6fdfd9ed03cd590751a80ca27614cca2a909ba057e3c513ef7
>>>>
>>>> commons-rng-1.2-bin-tar.gz.asc=500c67f4c3c1fdc6583fab068f20664e7235e5f983dcc90c1c9d70290bf5eb3e4a76d7fb3eba56f4a3e8e957bf0c490db237698419c95e2dbca8716f393def4c
>>>>
>>>> commons-rng-1.2-src-tar.gz=a9325efec521ff3f3489fa67568bc91b5a89014c888d81d14a39e669cf678648ba60722e3f3320ad643d9e84ef3193f272bfd78b4495044b6a763a6442590a3f
>>>>
>>>> commons-rng-1.2-bin-zip=55342112a7e505882ad5739233508d2957c396f71bf22a45226844bf5ccdfb4947066a0fb111f1a51287ef359bdd1e84f9c7fdde7c3a02092b4cf45aa9eb3d99
>>>>
>>>> commons-rng-1.2-src-zip=f2d7dbabb1479afd15adae00e9007480638d7c8b5a2900d1d43ec7497efd8f2a0a66bc84032c642de6b3ecf0829a01d3c6748e583b43476f4f36466667fe2292
>>>>
>>>> commons-rng-1.2-src-zip.asc=e931a42202b3ba274ca07251d8114066c88085014823c421b0cba15c300596aad1d7a7c7f42f85fe0e62cfa3ab4dd4a7afd32ab18149d42e5e775c9c2bf0e187
>>>>
>>>> commons-rng-1.2-pom.asc=4c9ebbb00fbc1b7f7a679c1f165fc6561ad69fd5e7ec2b268d89c26053643a9574ac69876d47cc8e1a27f595010a6466c4f679518ee7dec5b9c250a5a4720089
>>>>
>>>> commons-rng-1.2-bin-zip.asc=30e72114890ad6551fb2dc21251d787cf7410d22c92960375d2bfc8586279d1981261af74ce9477313bd1dac4ee632d94100c0db6340a216e385c947b491f432
>>>>
>>>> commons-rng-1.2-src-tar.gz.asc=e1a04875744dc3cd5b04bfbe5c6fa52e553ecc645c5923db53259202daf28f5fd8570c84a9fcb0ae10669a0924101d4d737ca23fb9cbcd4da7f708ce67c6b5f8
>>>>
>>>> Details of changes:
>>>>
>>>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/RELEASE-NOTES.txt
>>>>
>>>> https://dist.apache.org/repos/dist/dev/commons/rng/1.2-RC1/site/changes-report.html
>>>>
>>>> Site:
>>>>   http://commons.apache.org/proper/commons-rng/
>>>>
>>>> KEYS:
>>>>  id=B39617E095CD748DFE505816703413011E22D5B8
>>>>  https://www.apache.org/dist/commons/KEYS
>>>>
>>>> Please review the release candidate and vote.
>>>> This vote will close no sooner that 72 hours from now.
>>>>
>>>> [ ] +1 Release these artifacts
>>>> [ ] +0 OK, but...
>>>> [ ] -0 OK, but really should fix...
>>>> [ ] -1 I oppose this release because...
>>>>
>>>> Thanks,
>>>> Gilles
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Cancel][Vote] Release Apache Commons RNG v1.2 (RC1)

Gilles Sadowski
In reply to this post by Gilles Sadowski

Preparing RC2.

Regards,
Gilles

On Tue, 04 Dec 2018 02:19:33 +0100, Gilles wrote:
> Hello.
>
> I would like to release Apache Commons RNG v1.2.
>
> Apache Commons RNG 1.2 RC1 is available for review:
> [...]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]