commons-codec pull request: More tests

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

commons-codec pull request: More tests

Turan91
GitHub user lathspell opened a pull request:

    https://github.com/apache/commons-codec/pull/1

    More tests

    Please apply the following commits:
   
    $ git log --name-status aead18a..71bdb57
    commit 71bdb5725169e4dba533ab50a3afab4b4fedb788
    Author: Christian Hammers <[hidden email]>
    Date:   Sat Sep 1 01:46:08 2012 +0200
   
        The header file is already specified in <properties>
   
    M       pom.xml
   
    commit 248bad1c748b902466ed8f8a6a99d500bc01ce7e
    Author: Christian Hammers <[hidden email]>
    Date:   Sat Sep 1 01:45:06 2012 +0200
   
        added more tests
   
    M       src/test/java/org/apache/commons/codec/digest/Sha512CryptTest.java
   
    commit 3b7f1a5b270082423317c78c3daf44a34d92dafe
    Author: Christian Hammers <[hidden email]>
    Date:   Sat Sep 1 01:43:00 2012 +0200
   
        added test
   
    M       src/test/java/org/apache/commons/codec/digest/B64Test.java
   
    commit 763d05d386509f4c38f2697b343a4534448a8a8c
    Author: Christian Hammers <[hidden email]>
    Date:   Sat Sep 1 01:42:52 2012 +0200
   
        added test
   
    M       src/test/java/org/apache/commons/codec/digest/Apr1CryptTest.java
   
    commit f1594524000781fb3042c4a9ba9e701871e10244
    Author: Christian Hammers <[hidden email]>
    Date:   Sat Sep 1 01:41:28 2012 +0200
   
        added test for invalid argument
   
    M       src/test/java/org/apache/commons/codec/digest/UnixCryptTest.java
   
    commit 704e046a60e344add510c4ee0de004f09cd46889
    Author: Christian Hammers <[hidden email]>
    Date:   Sat Sep 1 01:39:49 2012 +0200
   
        Removed superfluous long->int bit mask operations and added one more test.
   
    M       src/main/java/org/apache/commons/codec/digest/UnixCrypt.java
    M       src/test/java/org/apache/commons/codec/digest/CryptTest.java


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lathspell/commons-codec trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-codec/pull/1.patch

----
commit 704e046a60e344add510c4ee0de004f09cd46889
Author: Christian Hammers <[hidden email]>
Date:   2012-08-31T16:39:49-07:00

    Removed superfluous long->int bit mask operations and added one more test.

commit f1594524000781fb3042c4a9ba9e701871e10244
Author: Christian Hammers <[hidden email]>
Date:   2012-08-31T16:41:28-07:00

    added test for invalid argument

commit 763d05d386509f4c38f2697b343a4534448a8a8c
Author: Christian Hammers <[hidden email]>
Date:   2012-08-31T16:42:52-07:00

    added test

commit 3b7f1a5b270082423317c78c3daf44a34d92dafe
Author: Christian Hammers <[hidden email]>
Date:   2012-08-31T16:43:00-07:00

    added test

commit 248bad1c748b902466ed8f8a6a99d500bc01ce7e
Author: Christian Hammers <[hidden email]>
Date:   2012-08-31T16:45:06-07:00

    added more tests

commit 71bdb5725169e4dba533ab50a3afab4b4fedb788
Author: Christian Hammers <[hidden email]>
Date:   2012-08-31T16:46:08-07:00

    The header file is already specified in <properties>

----


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: commons-codec pull request: More tests

garydgregory
Can you provide an SVN diff file and attach it to a JIRA please?

Gary

On Aug 31, 2012, at 19:56, lathspell <[hidden email]> wrote:

> GitHub user lathspell opened a pull request:
>
>    https://github.com/apache/commons-codec/pull/1
>
>    More tests
>
>    Please apply the following commits:
>
>    $ git log --name-status aead18a..71bdb57
>    commit 71bdb5725169e4dba533ab50a3afab4b4fedb788
>    Author: Christian Hammers <[hidden email]>
>    Date:   Sat Sep 1 01:46:08 2012 +0200
>
>        The header file is already specified in <properties>
>
>    M       pom.xml
>
>    commit 248bad1c748b902466ed8f8a6a99d500bc01ce7e
>    Author: Christian Hammers <[hidden email]>
>    Date:   Sat Sep 1 01:45:06 2012 +0200
>
>        added more tests
>
>    M       src/test/java/org/apache/commons/codec/digest/Sha512CryptTest.java
>
>    commit 3b7f1a5b270082423317c78c3daf44a34d92dafe
>    Author: Christian Hammers <[hidden email]>
>    Date:   Sat Sep 1 01:43:00 2012 +0200
>
>        added test
>
>    M       src/test/java/org/apache/commons/codec/digest/B64Test.java
>
>    commit 763d05d386509f4c38f2697b343a4534448a8a8c
>    Author: Christian Hammers <[hidden email]>
>    Date:   Sat Sep 1 01:42:52 2012 +0200
>
>        added test
>
>    M       src/test/java/org/apache/commons/codec/digest/Apr1CryptTest.java
>
>    commit f1594524000781fb3042c4a9ba9e701871e10244
>    Author: Christian Hammers <[hidden email]>
>    Date:   Sat Sep 1 01:41:28 2012 +0200
>
>        added test for invalid argument
>
>    M       src/test/java/org/apache/commons/codec/digest/UnixCryptTest.java
>
>    commit 704e046a60e344add510c4ee0de004f09cd46889
>    Author: Christian Hammers <[hidden email]>
>    Date:   Sat Sep 1 01:39:49 2012 +0200
>
>        Removed superfluous long->int bit mask operations and added one more test.
>
>    M       src/main/java/org/apache/commons/codec/digest/UnixCrypt.java
>    M       src/test/java/org/apache/commons/codec/digest/CryptTest.java
>
>
> You can merge this pull request into a Git repository by running:
>
>    $ git pull https://github.com/lathspell/commons-codec trunk
>
> Alternatively you can review and apply these changes as the patch at:
>
>    https://github.com/apache/commons-codec/pull/1.patch
>
> ----
> commit 704e046a60e344add510c4ee0de004f09cd46889
> Author: Christian Hammers <[hidden email]>
> Date:   2012-08-31T16:39:49-07:00
>
>    Removed superfluous long->int bit mask operations and added one more test.
>
> commit f1594524000781fb3042c4a9ba9e701871e10244
> Author: Christian Hammers <[hidden email]>
> Date:   2012-08-31T16:41:28-07:00
>
>    added test for invalid argument
>
> commit 763d05d386509f4c38f2697b343a4534448a8a8c
> Author: Christian Hammers <[hidden email]>
> Date:   2012-08-31T16:42:52-07:00
>
>    added test
>
> commit 3b7f1a5b270082423317c78c3daf44a34d92dafe
> Author: Christian Hammers <[hidden email]>
> Date:   2012-08-31T16:43:00-07:00
>
>    added test
>
> commit 248bad1c748b902466ed8f8a6a99d500bc01ce7e
> Author: Christian Hammers <[hidden email]>
> Date:   2012-08-31T16:45:06-07:00
>
>    added more tests
>
> commit 71bdb5725169e4dba533ab50a3afab4b4fedb788
> Author: Christian Hammers <[hidden email]>
> Date:   2012-08-31T16:46:08-07:00
>
>    The header file is already specified in <properties>
>
> ----
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: commons-codec pull request: More tests

Christian Hammers
Hello

Ok, CODEC-148.

bye,

-christian-


Am Fri, 31 Aug 2012 19:57:54 -0400
schrieb Gary Gregory <[hidden email]>:

> Can you provide an SVN diff file and attach it to a JIRA please?
>
> Gary
>
> On Aug 31, 2012, at 19:56, lathspell <[hidden email]> wrote:
>
> > GitHub user lathspell opened a pull request:
> >
> >    https://github.com/apache/commons-codec/pull/1
> >
> >    More tests
> >
> >    Please apply the following commits:
> >
> >    $ git log --name-status aead18a..71bdb57
> >    commit 71bdb5725169e4dba533ab50a3afab4b4fedb788
> >    Author: Christian Hammers <[hidden email]>
> >    Date:   Sat Sep 1 01:46:08 2012 +0200
> >
> >        The header file is already specified in <properties>
> >
> >    M       pom.xml
> >
> >    commit 248bad1c748b902466ed8f8a6a99d500bc01ce7e
> >    Author: Christian Hammers <[hidden email]>
> >    Date:   Sat Sep 1 01:45:06 2012 +0200
> >
> >        added more tests
> >
> >    M
> > src/test/java/org/apache/commons/codec/digest/Sha512CryptTest.java
> >
> >    commit 3b7f1a5b270082423317c78c3daf44a34d92dafe
> >    Author: Christian Hammers <[hidden email]>
> >    Date:   Sat Sep 1 01:43:00 2012 +0200
> >
> >        added test
> >
> >    M
> > src/test/java/org/apache/commons/codec/digest/B64Test.java
> >
> >    commit 763d05d386509f4c38f2697b343a4534448a8a8c
> >    Author: Christian Hammers <[hidden email]>
> >    Date:   Sat Sep 1 01:42:52 2012 +0200
> >
> >        added test
> >
> >    M
> > src/test/java/org/apache/commons/codec/digest/Apr1CryptTest.java
> >
> >    commit f1594524000781fb3042c4a9ba9e701871e10244
> >    Author: Christian Hammers <[hidden email]>
> >    Date:   Sat Sep 1 01:41:28 2012 +0200
> >
> >        added test for invalid argument
> >
> >    M
> > src/test/java/org/apache/commons/codec/digest/UnixCryptTest.java
> >
> >    commit 704e046a60e344add510c4ee0de004f09cd46889
> >    Author: Christian Hammers <[hidden email]>
> >    Date:   Sat Sep 1 01:39:49 2012 +0200
> >
> >        Removed superfluous long->int bit mask operations and added
> > one more test.
> >
> >    M
> > src/main/java/org/apache/commons/codec/digest/UnixCrypt.java
> > M       src/test/java/org/apache/commons/codec/digest/CryptTest.java
> >
> >
> > You can merge this pull request into a Git repository by running:
> >
> >    $ git pull https://github.com/lathspell/commons-codec trunk
> >
> > Alternatively you can review and apply these changes as the patch
> > at:
> >
> >    https://github.com/apache/commons-codec/pull/1.patch
> >
> > ----
> > commit 704e046a60e344add510c4ee0de004f09cd46889
> > Author: Christian Hammers <[hidden email]>
> > Date:   2012-08-31T16:39:49-07:00
> >
> >    Removed superfluous long->int bit mask operations and added one
> > more test.
> >
> > commit f1594524000781fb3042c4a9ba9e701871e10244
> > Author: Christian Hammers <[hidden email]>
> > Date:   2012-08-31T16:41:28-07:00
> >
> >    added test for invalid argument
> >
> > commit 763d05d386509f4c38f2697b343a4534448a8a8c
> > Author: Christian Hammers <[hidden email]>
> > Date:   2012-08-31T16:42:52-07:00
> >
> >    added test
> >
> > commit 3b7f1a5b270082423317c78c3daf44a34d92dafe
> > Author: Christian Hammers <[hidden email]>
> > Date:   2012-08-31T16:43:00-07:00
> >
> >    added test
> >
> > commit 248bad1c748b902466ed8f8a6a99d500bc01ce7e
> > Author: Christian Hammers <[hidden email]>
> > Date:   2012-08-31T16:45:06-07:00
> >
> >    added more tests
> >
> > commit 71bdb5725169e4dba533ab50a3afab4b4fedb788
> > Author: Christian Hammers <[hidden email]>
> > Date:   2012-08-31T16:46:08-07:00
> >
> >    The header file is already specified in <properties>
> >
> > ----
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]