commons-lang class JsonToStringStyle does not escape double quote in a string value

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

commons-lang class JsonToStringStyle does not escape double quote in a string value

Jim Gan
If string value contains double quote,   JsonToStringStyle generates
invalid json string.

Here is the detail :

The code at line 2609  needs to escape the double quote before appending it
to the buffer.


https://github.com/apache/commons-lang/blob/c614fbcc79615f93d2c60a153db6e82d7474c425/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java

line 2608 and line 2609

       private void appendValueAsString(final StringBuffer buffer,
final String value) {
            buffer.append('"').append(value).append('"');
        }


Jim
Reply | Threaded
Open this post in threaded view
|

Re: commons-lang class JsonToStringStyle does not escape double quote in a string value

mgainty
can you submit a JIRA ticket with patch?


Martin

________________________________
From: Jim Gan <[hidden email]>
Sent: Tuesday, May 8, 2018 8:10 PM
To: [hidden email]
Subject: commons-lang class JsonToStringStyle does not escape double quote in a string value

If string value contains double quote,   JsonToStringStyle generates
invalid json string.

Here is the detail :

The code at line 2609  needs to escape the double quote before appending it
to the buffer.


https://github.com/apache/commons-lang/blob/c614fbcc79615f93d2c60a153db6e82d7474c425/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java
[https://avatars3.githubusercontent.com/u/47359?s=400&v=4]<https://github.com/apache/commons-lang/blob/c614fbcc79615f93d2c60a153db6e82d7474c425/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java>

apache/commons-lang<https://github.com/apache/commons-lang/blob/c614fbcc79615f93d2c60a153db6e82d7474c425/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java>
github.com
commons-lang - Mirror of Apache Commons Lang




line 2608 and line 2609

       private void appendValueAsString(final StringBuffer buffer,
final String value) {
            buffer.append('"').append(value).append('"');
        }


Jim
Reply | Threaded
Open this post in threaded view
|

Re: commons-lang class JsonToStringStyle does not escape double quote in a string value

sebb-2-2
Ticket exists:

https://issues.apache.org/jira/browse/LANG-1395

No patch as yet.

On 9 May 2018 at 13:46, Martin Gainty <[hidden email]> wrote:

> can you submit a JIRA ticket with patch?
>
>
> Martin
>
> ________________________________
> From: Jim Gan <[hidden email]>
> Sent: Tuesday, May 8, 2018 8:10 PM
> To: [hidden email]
> Subject: commons-lang class JsonToStringStyle does not escape double quote in a string value
>
> If string value contains double quote,   JsonToStringStyle generates
> invalid json string.
>
> Here is the detail :
>
> The code at line 2609  needs to escape the double quote before appending it
> to the buffer.
>
>
> https://github.com/apache/commons-lang/blob/c614fbcc79615f93d2c60a153db6e82d7474c425/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java
> [https://avatars3.githubusercontent.com/u/47359?s=400&v=4]<https://github.com/apache/commons-lang/blob/c614fbcc79615f93d2c60a153db6e82d7474c425/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java>
>
> apache/commons-lang<https://github.com/apache/commons-lang/blob/c614fbcc79615f93d2c60a153db6e82d7474c425/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java>
> github.com
> commons-lang - Mirror of Apache Commons Lang
>
>
>
>
> line 2608 and line 2609
>
>        private void appendValueAsString(final StringBuffer buffer,
> final String value) {
>             buffer.append('"').append(value).append('"');
>         }
>
>
> Jim

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]