[configuration] review for PR 30

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[configuration] review for PR 30

garydgregory
Hi All:

May anyone that knows enough of the internals of [configuration] please
comment on https://github.com/apache/commons-configuration/pull/30

?

Gary
Reply | Threaded
Open this post in threaded view
|

Re: [configuration] review for PR 30

Emmanuel Bourg-3
Le 01/07/2019 à 16:26, Gary Gregory a écrit :

> May anyone that knows enough of the internals of [configuration] please
> comment on https://github.com/apache/commons-configuration/pull/30

I got a quick look, besides the setArrayProperty method that doesn't
seem to have the right name (there is nothing specific to arrays in the
implementation, it just sets the value as is) the PR looks good.

Emmanuel Bourg

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [configuration] review for PR 30

garydgregory
On Mon, Jul 1, 2019 at 6:46 PM Emmanuel Bourg <[hidden email]> wrote:

> Le 01/07/2019 à 16:26, Gary Gregory a écrit :
>
> > May anyone that knows enough of the internals of [configuration] please
> > comment on https://github.com/apache/commons-configuration/pull/30
>
> I got a quick look, besides the setArrayProperty method that doesn't
> seem to have the right name (there is nothing specific to arrays in the
> implementation, it just sets the value as is) the PR looks good.
>

What would you call the method?

Gary


>
> Emmanuel Bourg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [configuration] review for PR 30

Emmanuel Bourg-3
Le 02/07/2019 à 01:59, Gary Gregory a écrit :

> What would you call the method?

I don't know, setPropertyDirectInternal? It's private anyway, the name
isn't important.

Emmanuel Bourg

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]