[fileupload] changes for FILEUPLOAD-250 not included in current releases...

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[fileupload] changes for FILEUPLOAD-250 not included in current releases...

Wes Wannemacher
Hello,

I am kinda confused about the status of this change:
https://github.com/apache/commons-fileupload/commit/5b4881d7f75f439326f54fa554a9ca7de6d60814#diff-861c1620cf9c75438b70a5678da1b289

On the JIRA ticket (https://issues.apache.org/jira/browse/FILEUPLOAD-250),
it lists the fixVersion as 1.4, but it seems that the ticket was worked
quite a while back. The link above shows the 1.3.2 tag, but I looked in the
sources jars for 1.3.2 and 1.3.3 on maven central as well as the zips on
github:
https://github.com/apache/commons-fileupload/releases/tag/commons-fileupload-1.3.2
&
https://github.com/apache/commons-fileupload/releases/tag/commons-fileupload-1.3.3.
The calls to IOUtils.closeQuietly are not included anywhere.

Based on the JIRA ticket, it seems like they will be included in 1.4, but
the tagging in git and the fact that the changes have landed on master 5
years ago (
https://github.com/apache/commons-fileupload/blame/master/src/main/java/org/apache/commons/fileupload/FileUploadBase.java),
I'm a bit worried that something weird is going on.

I'm really just looking to understand whether this is upcoming, or is
somehow accidentally not being included in recent releases.

Thanks!

-Wes

--
Wes Wannemacher