[javaflow] integrating the latest BCEL

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[javaflow] integrating the latest BCEL

Kohsuke Kawaguchi

Torsten,

When I instrument one of my classes with javaflow. I get a VerifyError
from JVM --- the instrumented code isn't correct.

While I haven't done much research on why/how, apparently the problem
only happens when I use the 2004/03/29 version of BCEL. If I use the
current trunk of BCEL as of today, the problem goes away.

The 2004/03/29 version is more than a year old now, so I'd imagine
there's been some bug fixes done since then. Now that BCEL has fixed
36110 (see [1]) at least to the point that our test cases won't break,
would it make sense to modify javaflow to use the current trunk version?

[1] http://issues.apache.org/bugzilla/show_bug.cgi?id=36110
--
Kohsuke Kawaguchi

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [javaflow] integrating the latest BCEL

Torsten Curdt
>

> Torsten,
>
> When I instrument one of my classes with javaflow. I get a  
> VerifyError from JVM --- the instrumented code isn't correct.
>
> While I haven't done much research on why/how, apparently the  
> problem only happens when I use the 2004/03/29 version of BCEL. If  
> I use the current trunk of BCEL as of today, the problem goes away.
>
> The 2004/03/29 version is more than a year old now, so I'd imagine  
> there's been some bug fixes done since then. Now that BCEL has  
> fixed 36110 (see [1]) at least to the point that our test cases  
> won't break, would it make sense to modify javaflow to use the  
> current trunk version?
>
Sure!

If it works - go ahead :)

The BCEL version that
comes with javaflow just
had some bugs fixed.

Add that time I did not
have BCEL commit access.

cheers
--
Torsten


PGP.sig (193 bytes) Download Attachment