[jira] [Closed] (DIGESTER-118) ObjectCreateRule shouldn't keep className as a field

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Closed] (DIGESTER-118) ObjectCreateRule shouldn't keep className as a field

Gary D. Gregory (Jira)

     [ https://issues.apache.org/jira/browse/DIGESTER-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi closed DIGESTER-118.

included in Apache Commons Digester 3.0 release

> ObjectCreateRule shouldn't keep className as a field
> ----------------------------------------------------
>                 Key: DIGESTER-118
>                 URL: https://issues.apache.org/jira/browse/DIGESTER-118
>             Project: Commons Digester
>          Issue Type: Bug
>    Affects Versions: 1.7
>            Reporter: Kohsuke Kawaguchi
>            Assignee: Simone Tripodi
>             Fix For: 3.0
> Currently ObjectCreateRule refers to the class by using the name, but this is highly undesirable.
> 1. "begin" uses the classloader that loaded Digester to resolve this class name, but this won't work in multi-classloader environment (like IDE, Maven, etc.)
> 2. "begin" invokes the loadClass method each time a new object is created. This is unnecessary performance hit.
> The proper thing to do is to retain the Class object, and convert String to Class in the constructor.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira