[jira] [Comment Edited] (LANG-572) [XSS] StringEscapeUtils.escapeHtml() must escape ' chars to '

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (LANG-572) [XSS] StringEscapeUtils.escapeHtml() must escape ' chars to '

Dmitri Blinov (Jira)

    [ https://issues.apache.org/jira/browse/LANG-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639199#comment-13639199 ]

jukefox edited comment on LANG-572 at 4/23/13 5:44 PM:
-------------------------------------------------------

Could you please describe why you conclude that the request is out of scope for {{escapeHtml}}?
I cannot find any explanation in this ticket.
From my point of view it is essential to escape single quote characters not only because of possible XSS as described above but also to prevent syntactically illegal code when putting variable data as part of a value to an attribute when relying on {{escapeHtml}}.

Thanks.

PS: There are examples out there that do escape the character as expected. You can have a look at [http://www.opinionatedgeek.com/dotnet/tools/htmlencode/encode.aspx] and give it a try.

               
      was (Author: jukefox):
    Could you please describe why you conclude that the request is out of scope for {{escapeHtml}}?
I cannot find any explanation in this ticket.
From my point of view it is essential to escape single quote characters not only because of possible XSS as described above but also to prevent syntactically illegal code when putting variable data as part of a value to an attribute when relying on {{escapeHtml}}.

Thanks.

                 

> [XSS] StringEscapeUtils.escapeHtml() must escape ' chars to '
> ------------------------------------------------------------------
>
>                 Key: LANG-572
>                 URL: https://issues.apache.org/jira/browse/LANG-572
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>    Affects Versions: 2.4
>         Environment: Operating System: All
> Platform: All
>            Reporter: Keisuke Kato
>            Priority: Minor
>
> If developers putting untrusted data into attribute values using the single quote character ' and StringEscapeUtils.escapeHtml() like:
> <input type='text' name='input' value=*'<%=StringEscapeUtils.escapeHtml(request.getParameter("input"))%>'*>
> Then, the attacker is able to break out of the HTML attribute context like:
> hxxp://example.org/?input=*' onfocus='alert(document.cookie);' id='*
> <input type='text' name='input' value='*'onfocus='alert(document.cookie);'id='*'>
> I think [LANG\-122|https://issues.apache.org/jira/browse/LANG-122] is not truly fixed from this aspect (XSS).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira