[jira] [Comment Edited] (MATH-851) Add convolution

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (MATH-851) Add convolution

Lars Bruun-Hansen (Jira)

    [ https://issues.apache.org/jira/browse/MATH-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667951#comment-13667951 ]

Thomas Neidhart edited comment on MATH-851 at 5/27/13 9:01 PM:
---------------------------------------------------------------

Imho, we should add the variant with arrays to MathArrays: double[] convolve(double[], double[])

Edit: and I volunteer to clean up the code, which is pretty much ok, why has there been so much discussion about it? ;-)

btw. I think one of the responsibilities as committer is to do the final touch of a contribution before committing. If we would only accept perfect contributions we could wait a long time imho (I struggled myself a lot with my first patch if I remember correctly).
               
      was (Author: tn):
    Imho, we should add the variant with arrays to MathArrays: double[] convolve(double[], double[])
                 

> Add convolution
> ---------------
>
>                 Key: MATH-851
>                 URL: https://issues.apache.org/jira/browse/MATH-851
>             Project: Commons Math
>          Issue Type: New Feature
>            Reporter: Clemens Novak
>            Priority: Minor
>         Attachments: Filter.java, FilterTest.java, FilterUtils.java, FilterUtils.java, FilterUtilsTest.java, FilterUtilsTest.java
>
>
> I created a function performing (one-dimensional) convolution. Currently, the function is in a class called Filter, but I am not sure whether this is the appropriate place for it(?).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira