[jira] [Commented] (CHAIN-88) Refactor tests in class ContextBaseTestCase

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CHAIN-88) Refactor tests in class ContextBaseTestCase

AD_LB (Jira)

    [ https://issues.apache.org/jira/browse/CHAIN-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683540#comment-13683540 ]

Benedikt Ritter commented on CHAIN-88:
--------------------------------------

Hello again Stephan,

I've reviewed your second patch. I like the simplification of {{checkAttributeCount(int}} and the new test methods {{contextKeySetDoesNotSupportAddOperation()}} and {{contextKeySetDoesNotSupportAddAllOperation()}} (nice an meaningful names, although "Operation" could be dropped).

However there are some very tiny issues that need fixing before I can apply the patch:
 * There are several lines formatted in {{testAttributes()}} - please try to create patches that only contain the changes that belong to the issue
 * There are changes in {{testSerialization()}} - see above
 * There are several tabs used - please only use spaces for indentation

One comment to your changes in {{testSerialization()}}: You have removed the comment explaining the reason for {{@SuppressWarnings("unchecked")}}. It is considered good style to always make explicit why warnings can be suppressed. So no need for removing that comment :)

All together good work. Fix the issues and I'll apply your patch.
TIA and keep up the good work!

Benedikt
               

> Refactor tests in class ContextBaseTestCase
> --------------------------------------------
>
>                 Key: CHAIN-88
>                 URL: https://issues.apache.org/jira/browse/CHAIN-88
>             Project: Commons Chain
>          Issue Type: Task
>    Affects Versions: 2.0
>            Reporter: Stephan K├Âninger
>            Priority: Minor
>              Labels: patch
>         Attachments: CHAIN-88-1-patch.txt, CHAIN-88-patch.txt
>
>
> Some tests in ContextBaseTestCase contain strange code which is much too complicated or seems unnecessary. I have created a patch to address this issues. All tests run on my machine after applying the patches.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira