[jira] [Commented] (CODEC-161) Add Match Rating Approach (MRA) phonetic algorithm encoder

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CODEC-161) Add Match Rating Approach (MRA) phonetic algorithm encoder

David Costanzo (Jira)

    [ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546002#comment-13546002 ]

Gary Gregory commented on CODEC-161:
------------------------------------

As you can see from my previous comment, I've applied the latest patch. Please get the latest from trunk.

The tests are still not 100% but your JPG shows 100%. Note that we use Cobertura, not Emma.

I am sorry to keeping bugging you about this but I think it would be best of this new encoder to be fully tested to ease maintenance.

Run 'mvn site' and look at the Cobertura report, I see 100% line coverage but 91% branch coverage (which is still quite good, but why not aim for 100% on a 113 line class ;)

Did I miss one of your patches or is the coverage indeed incomplete?

Also, please give your patches unique file names like ID-nnn-1, ID-nnn-2, and so on. It will make it easier I think.

Thank you!
Gary
               

> Add Match Rating Approach (MRA) phonetic algorithm encoder
> ----------------------------------------------------------
>
>                 Key: CODEC-161
>                 URL: https://issues.apache.org/jira/browse/CODEC-161
>             Project: Commons Codec
>          Issue Type: New Feature
>    Affects Versions: 1.6
>            Reporter: Colm Rice
>            Priority: Minor
>              Labels: newbie
>             Fix For: 1.8
>
>         Attachments: CODEC-161-MatchRatingApproach.patch, CODEC-161.patch, CODEC-161.patch, CODEC-161.patch, CODEC-161.patch, CODEC-161.patch, Code_Coverage_EclEmma_MRA_TargetAlgo_03Dec2012.jpg, CODED-161.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-)  C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira