[jira] [Commented] (CODEC-161) Add Match Rating Approach (MRA) phonetic algorithm encoder

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CODEC-161) Add Match Rating Approach (MRA) phonetic algorithm encoder

Gary Lucas (Jira)

    [ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559005#comment-13559005 ]

Gary Gregory commented on CODEC-161:
------------------------------------

I applied the patch to the test class only. Thank you.

The encoder changes affected the logic of the getMinRating(int) method in a manner that was unexplained and could potentially introduce bugs when maintained in the future. It would also be slower because each 'if' would always be tested.

Was the change to getMinRating(int) only made to attempt to increase coverage or to fix a bug? The tests pass with the getMinRating change.

It feels like we are ready to close this unless you can find a different manner to increase coverage.

Thank you!
Gary
               

> Add Match Rating Approach (MRA) phonetic algorithm encoder
> ----------------------------------------------------------
>
>                 Key: CODEC-161
>                 URL: https://issues.apache.org/jira/browse/CODEC-161
>             Project: Commons Codec
>          Issue Type: New Feature
>    Affects Versions: 1.6
>            Reporter: Colm Rice
>            Priority: Minor
>              Labels: newbie
>             Fix For: 1.8
>
>         Attachments: CODEC-161-18Jan2013.patch, CODEC-161-MatchRatingApproach.patch, CODEC-161.patch, CODEC-161.patch, CODEC-161.patch, CODEC-161.patch, CODEC-161.patch, Code_Coverage_EclEmma_MRA_TargetAlgo_03Dec2012.jpg, CODED-161.patch, MRA_Cobertura_CodeCoverage_18Jan2013.jpg, MRA_Cobertura_ScreenShot_01Jan2013.jpg, MRA_eCobertura_Output.jpg
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-)  C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira