[jira] [Commented] (COMPRESS-410) Remove ZipEncoding implementations introduced to work around problems in jdk 1.4

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (COMPRESS-410) Remove ZipEncoding implementations introduced to work around problems in jdk 1.4

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/COMPRESS-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053357#comment-16053357 ]

ASF GitHub Bot commented on COMPRESS-410:
-----------------------------------------

GitHub user sesuncedu opened a pull request:

    https://github.com/apache/commons-compress/pull/37

    COMPRESS-410 - cherry picked  to fix merging issues

    Remove non-NIO character set encoders.
   
    Fixes rebasing related issues in previous PR


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sesuncedu/commons-compress COMPRESS-410-REDUX

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-compress/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #37
   
----
commit 5a7ecf1a52d078cf005082c22d302ee9dcc2faf0
Author: Simon Spero <[hidden email]>
Date:   2017-06-17T00:17:13Z

    COMPRESS-410 Remove Non-NIO character set encoders.
    As a special case, the UTF-8 encoder will replace malformed / unmappable input with '?'.
    This behavior is required for compatibility with existing behavior.
   
    Signed-off-by: Simon Spero <[hidden email]>
   
    (cherry picked from commit 0d41ac4)
    Signed-off-by: Simon Spero <[hidden email]>

commit 8125dccb36792fdcc83c7359d13ecade39852562
Author: Simon Spero <[hidden email]>
Date:   2017-06-17T16:45:44Z

    javadoc for HasCharset
   
    Signed-off-by: Simon Spero <[hidden email]>
   
    (cherry picked from commit b70c7c2)
    Signed-off-by: Simon Spero <[hidden email]>

commit cf3fa1ecd677b0d405e6018b91aa13f90ecb3b7c
Author: Simon Spero <[hidden email]>
Date:   2017-06-17T00:17:13Z

    COMPRESS-410 Remove Non-NIO character set encoders.
    As a special case, the UTF-8 encoder will replace malformed / unmappable input with '?'.
    This behavior is required for compatibility with existing behavior.
   
    Signed-off-by: Simon Spero <[hidden email]>
   
    (cherry picked from commit 1987719)
    Signed-off-by: Simon Spero <[hidden email]>

commit fb52100291ed3f69581f6a6dc5062a07e6d52ae8
Author: Simon Spero <[hidden email]>
Date:   2017-06-18T22:55:38Z

    Do better estimating of required buffer size for character encoding.  If an unencodable character is found that requires output buffer expansion,  scan buffer for all such characters, and attempt to expand buffer only once.
   
    Signed-off-by: Simon Spero <[hidden email]>
   
    (cherry picked from commit aa30e21)
    Signed-off-by: Simon Spero <[hidden email]>

commit 9f76e86f71d36897895e1e5f49b522d12602f3cc
Author: Simon Spero <[hidden email]>
Date:   2017-06-15T18:27:48Z

    Redoing more buffer stuff
   
    Signed-off-by: Simon Spero <[hidden email]>
   
    (cherry picked from commit 330c8b3)
    Signed-off-by: Simon Spero <[hidden email]>

commit b92044a5fe95a8b6901040ee8b4c698c0a650e7d
Author: Simon Spero <[hidden email]>
Date:   2017-06-18T23:27:42Z

    Test that ebcidic encoding is supported (making sure "%Uxxxx" replacement strings don't use ascii encodings)
   
    Signed-off-by: Simon Spero <[hidden email]>
   
    (cherry picked from commit f1ec715)
    Signed-off-by: Simon Spero <[hidden email]>

----


> Remove   ZipEncoding implementations introduced to work around problems in jdk 1.4
> ----------------------------------------------------------------------------------
>
>                 Key: COMPRESS-410
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-410
>             Project: Commons Compress
>          Issue Type: Improvement
>          Components: Archivers
>    Affects Versions: 1.14
>            Reporter: Simon Spero
>            Priority: Minor
>
> There are several implementations of ZipEncoding that are provided to work around missing character sets  in JDK 1.4.
> Since commons-compress requires JDK7 or later, this code is no longer needed. As the classes are package private, they can be removed without affecting the API.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Loading...