[jira] [Commented] (COMPRESS-411) TarUtils.formatLongOctalOrBinaryBytes never uses result of formatLongBinary

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (COMPRESS-411) TarUtils.formatLongOctalOrBinaryBytes never uses result of formatLongBinary

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/COMPRESS-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053067#comment-16053067 ]

Stefan Bodewig commented on COMPRESS-411:
-----------------------------------------

I agree that {{TarUtils}} and all its methods being public is more of a historical accident than something that was really required. It's been that way since the very first version of the tar package I'm aware of: https://github.com/apache/ant/commit/bf94e2fb091644d9c249322d9574ab6bb1e6a3d8

We've never used JIRA workflows in any structured way for this project. In particular we almost never assign issues. And RESOLVED is the state when the code has reached the ASF repo, not when a patch is available. Usually effort isn't duplicated by virtue of not enough people being around who would work on an issue anyway. If you intend to work on an issue, just leave a comment.

> TarUtils.formatLongOctalOrBinaryBytes never uses result of formatLongBinary
> ---------------------------------------------------------------------------
>
>                 Key: COMPRESS-411
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-411
>             Project: Commons Compress
>          Issue Type: Bug
>          Components: Archivers
>    Affects Versions: 1.14
>            Reporter: Simon Spero
>            Priority: Minor
>             Fix For: 1.15
>
>
> if the length < 9, formatLongBinary is executed, then overwritten by the results of formatBigIntegerBinary.
> If the results are not ignored, a unit test would fail.
> Also, do the binary hacks  need to support negative numbers?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Loading...