[jira] [Commented] (COMPRESS-411) TarUtils.formatLongOctalOrBinaryBytes never uses result of formatLongBinary

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (COMPRESS-411) TarUtils.formatLongOctalOrBinaryBytes never uses result of formatLongBinary

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/COMPRESS-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053527#comment-16053527 ]

Stefan Bodewig commented on COMPRESS-411:
-----------------------------------------

{quote}Everything I've opened so far has been something I'm working on, or will be shortly {quote}

This may be true in your case but for most JIRAs the reporter is not the one who's going to provide the changes :-)

The issue of where to discuss things is bothering me as well. github is a read-only mirror but PRs are becoming more important than patches attached to JIRA lately. Comments on PRs get reflected in JIRA but not the other way around, so for review comments I prefer to use github. For discussion about the content of the issue itself - what is the problem, is there a problem at all? - I prefer JIRA. And then there are things that may need a bigger audience than two people involved in a single JIRA ticket in order to get them resolved, this where I really prefer the mailing list over any tracker.

> TarUtils.formatLongOctalOrBinaryBytes never uses result of formatLongBinary
> ---------------------------------------------------------------------------
>
>                 Key: COMPRESS-411
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-411
>             Project: Commons Compress
>          Issue Type: Bug
>          Components: Archivers
>    Affects Versions: 1.14
>            Reporter: Simon Spero
>            Priority: Minor
>             Fix For: 1.15
>
>
> if the length < 9, formatLongBinary is executed, then overwritten by the results of formatBigIntegerBinary.
> If the results are not ignored, a unit test would fail.
> Also, do the binary hacks  need to support negative numbers?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)