[jira] [Commented] (FILEUPLOAD-238) Default charset hardcoded in FileItem (must be used Charset.defaultCharset())

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (FILEUPLOAD-238) Default charset hardcoded in FileItem (must be used Charset.defaultCharset())

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/FILEUPLOAD-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053304#comment-16053304 ]

ASF GitHub Bot commented on FILEUPLOAD-238:
-------------------------------------------

Github user kinow commented on the issue:

    https://github.com/apache/commons-fileupload/pull/7
 
    I use pull requests when I want someone else to review my code. In this case, I modified the tests design a wee bit too (not just added portlet tests), so would like that someone confirmed the change looks OK.


> Default charset hardcoded in FileItem (must be used Charset.defaultCharset())
> -----------------------------------------------------------------------------
>
>                 Key: FILEUPLOAD-238
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-238
>             Project: Commons FileUpload
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Kislin Grigory
>
> It is no way to set charset in form with mixed text and file input and enctype="multipart/form-data". So request ContextType is null and FileItem.getString() used default charset.
> But default charset taken not from java Charset.defaultCharset() but hardcoded in DiskFileItem.DEFAULT_CHARSET="ISO-8859-1". So use UTF-8 only possible in own toString.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Loading...