[jira] [Commented] (GEOMETRY-32) BSPTree Updates

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (GEOMETRY-32) BSPTree Updates

Gary D. Gregory (Jira)

    [ https://issues.apache.org/jira/browse/GEOMETRY-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931028#comment-16931028 ]

Matt Juntunen commented on GEOMETRY-32:

I've just implemented an updated {{Transform}} interface. We now have {{TransformXD}} interfaces for each dimension along with {{FunctionalTransformXD}} classes that contain the factory methods for creating a transform from a function. There are more classes overall, but I was able to remove those methods from {{Hyperplane}} and I think the overall design is more maintainable.

> BSPTree Updates
> ---------------
>                 Key: GEOMETRY-32
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-32
>             Project: Apache Commons Geometry
>          Issue Type: Improvement
>          Components: core
>            Reporter: Matt Juntunen
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
> The following updates should be made to the BSPTree class:
> - add an {{isLeaf()}} method to replace all of the {{node.getCut() == null}} expressions
> - add unit tests
> _Edit [2019-02-17]:_
> Additional goals:
> - Refactor the API to split the idea of a general BSPTree and a BSPTree used for defining in/out regions. This could result in a BSPTree interface and a RegionBSPTree interface. The goal here is to allow end-users to create their own extensions of these classes and specialize them for their own applications (for example, to implement spatial sorting or other algorithms). This will be one of the only planned extension points in the library.
> - Make the API easier to use and extend and reduce the necessity of casting (especially unchecked casting) as much as possible.
> - Add the idea of convex subhyperplanes to allow for more efficient tree construction.

This message was sent by Atlassian Jira